mirror of
https://github.com/outbackdingo/mt76.git
synced 2026-10-24 21:36:52 +00:00
Stephen BoydandFelix Fietkau
2d5928fef2
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.
// <smpl>
@@
expression ret;
struct platform_device *E;
@@
ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);
if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>
While we're here, remove braces on if statements that only have one
statement (manually).
Cc: "David S. Miller" <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: Saeed Mahameed <[email protected]>
Cc: Jeff Kirsher <[email protected]>
Cc: Felix Fietkau <[email protected]>
Cc: Lorenzo Bianconi <[email protected]>
Cc: [email protected]
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
84 lines
1.8 KiB
C
84 lines
1.8 KiB
C
// SPDX-License-Identifier: ISC
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include "mt7603.h"
|
|
|
|
static int
|
|
mt76_wmac_probe(struct platform_device *pdev)
|
|
{
|
|
struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
struct mt7603_dev *dev;
|
|
void __iomem *mem_base;
|
|
struct mt76_dev *mdev;
|
|
int irq;
|
|
int ret;
|
|
|
|
irq = platform_get_irq(pdev, 0);
|
|
if (irq < 0)
|
|
return irq;
|
|
|
|
mem_base = devm_ioremap_resource(&pdev->dev, res);
|
|
if (IS_ERR(mem_base)) {
|
|
dev_err(&pdev->dev, "Failed to get memory resource\n");
|
|
return PTR_ERR(mem_base);
|
|
}
|
|
|
|
mdev = mt76_alloc_device(&pdev->dev, sizeof(*dev), &mt7603_ops,
|
|
&mt7603_drv_ops);
|
|
if (!mdev)
|
|
return -ENOMEM;
|
|
|
|
dev = container_of(mdev, struct mt7603_dev, mt76);
|
|
mt76_mmio_init(mdev, mem_base);
|
|
|
|
mdev->rev = (mt76_rr(dev, MT_HW_CHIPID) << 16) |
|
|
(mt76_rr(dev, MT_HW_REV) & 0xff);
|
|
dev_info(mdev->dev, "ASIC revision: %04x\n", mdev->rev);
|
|
|
|
ret = devm_request_irq(mdev->dev, irq, mt7603_irq_handler,
|
|
IRQF_SHARED, KBUILD_MODNAME, dev);
|
|
if (ret)
|
|
goto error;
|
|
|
|
ret = mt7603_register_device(dev);
|
|
if (ret)
|
|
goto error;
|
|
|
|
return 0;
|
|
error:
|
|
ieee80211_free_hw(mt76_hw(dev));
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
mt76_wmac_remove(struct platform_device *pdev)
|
|
{
|
|
struct mt76_dev *mdev = platform_get_drvdata(pdev);
|
|
struct mt7603_dev *dev = container_of(mdev, struct mt7603_dev, mt76);
|
|
|
|
mt7603_unregister_device(dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id of_wmac_match[] = {
|
|
{ .compatible = "mediatek,mt7628-wmac" },
|
|
{},
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, of_wmac_match);
|
|
MODULE_FIRMWARE(MT7628_FIRMWARE_E1);
|
|
MODULE_FIRMWARE(MT7628_FIRMWARE_E2);
|
|
|
|
struct platform_driver mt76_wmac_driver = {
|
|
.probe = mt76_wmac_probe,
|
|
.remove = mt76_wmac_remove,
|
|
.driver = {
|
|
.name = "mt76_wmac",
|
|
.of_match_table = of_wmac_match,
|
|
},
|
|
};
|