net: Remove dev_err() usage after platform_get_irq()

mirror of https://github.com/outbackdingo/mt76.git synced 2026-10-24 13:26:48 +00:00

We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// <smpl>
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: "David S. Miller" <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: Saeed Mahameed <[email protected]>
Cc: Jeff Kirsher <[email protected]>
Cc: Felix Fietkau <[email protected]>
Cc: Lorenzo Bianconi <[email protected]>
Cc: [email protected]
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

This commit is contained in:

Stephen Boyd

2019-08-22 09:27:55 +02:00

committed by

Felix Fietkau

parent 0e3baf0213

commit 2d5928fef2

1 changed files with 1 additions and 3 deletions

									
										mt7603/soc.c
									
		+1
		-3
	
												View File
												
				@@ -17,10 +17,8 @@ mt76_wmac_probe(struct platform_device *pdev)

					int ret;

					irq = platform_get_irq(pdev, 0);

					if (irq < 0) {

						dev_err(&pdev->dev, "Failed to get device IRQ\n");

					if (irq < 0)

						return irq;

					}

					mem_base = devm_ioremap_resource(&pdev->dev, res);

					if (IS_ERR(mem_base)) {