mirror of
https://github.com/outbackdingo/patroni.git
synced 2026-08-25 14:53:37 +00:00
Alexander KukushkinandGitHub
56dba93c55
There was one oversight of #2781 - to influence external tools that Patroni could execute, we set global `umask` value based on permissions of the $PGDATA directory. As a result, it also influenced permissions of log files created by Patroni. To address the problem we implement two measures: 1. Make `log.mode` configurable. 2. If the value is not set - calculate permissions from the original value of the umask setting.
36 lines
1.4 KiB
Python
36 lines
1.4 KiB
Python
import unittest
|
|
import stat
|
|
from unittest.mock import Mock, patch
|
|
|
|
from patroni.file_perm import pg_perm
|
|
|
|
|
|
class TestFilePermissions(unittest.TestCase):
|
|
|
|
@patch('os.stat')
|
|
@patch('os.umask')
|
|
@patch('patroni.file_perm.logger.error')
|
|
def test_set_umask(self, mock_logger, mock_umask, mock_stat):
|
|
mock_umask.side_effect = Exception
|
|
mock_stat.return_value.st_mode = stat.S_IRWXU | stat.S_IRGRP | stat.S_IXGRP
|
|
pg_perm.set_permissions_from_data_directory('test')
|
|
|
|
# umask is called with PG_MODE_MASK_GROUP
|
|
self.assertEqual(mock_umask.call_args[0][0], stat.S_IWGRP | stat.S_IRWXO)
|
|
self.assertEqual(mock_logger.call_args[0][0], 'Can not set umask to %03o: %r')
|
|
|
|
mock_umask.reset_mock()
|
|
mock_stat.return_value.st_mode = stat.S_IRWXU
|
|
pg_perm.set_permissions_from_data_directory('test')
|
|
# umask is called with PG_MODE_MASK_OWNER (permissions changed from group to owner)
|
|
self.assertEqual(mock_umask.call_args[0][0], stat.S_IRWXG | stat.S_IRWXO)
|
|
|
|
@patch('os.stat', Mock(side_effect=FileNotFoundError))
|
|
@patch('patroni.file_perm.logger.error')
|
|
def test_set_permissions_from_data_directory(self, mock_logger):
|
|
pg_perm.set_permissions_from_data_directory('test')
|
|
self.assertEqual(mock_logger.call_args[0][0], 'Can not check permissions on %s: %r')
|
|
|
|
def test_orig_umask(self):
|
|
self.assertIsNotNone(pg_perm.orig_umask)
|