arm64 compatibility

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,48 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Environment**
+- Patroni version:
+- PostgreSQL version:
+- DCS (and its version):
+
+**Patroni configuration file**
+```
+Please copy&paste your Patroni configuration file here
+```
+
+**patronictl show-config**
+```
+Please copy&paste the output of "patronictl show-config" command here
+```
+
+**Have you checked Patroni logs?**
+Please provide a snippet of Patroni log files here
+
+**Have you checked PostgreSQL logs?**
+Please provide a snippet here
+
+**Have you tried to use GitHub issue search?**
+Maybe there is already a similar issue solved.
+
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,97 +0,0 @@
-name: Bug Report
-description: Create a report to help us improve
-labels:
-- bug
-body:
-- type: markdown
-  attributes:
-    value: |
-      If you have a question please post it on channel [#patroni](https://postgresteam.slack.com/archives/C9XPYG92A) in the [PostgreSQL Slack](https://pgtreats.info/slack-invite).
-      Before reporting a bug please make sure to **reproduce it with the latest Patroni version**!
-      Please fill the form below and provide as much information as possible.
-      Not doing so may result in your bug not being addressed in a timely manner.
-
-- type: textarea
-  id: problem
-  attributes:
-    label: What happened?
-  validations:
-    required: true
-
-- type: textarea
-  id: repro
-  attributes:
-    label: How can we reproduce it (as minimally and precisely as possible)?
-  validations:
-    required: true
-
-- type: textarea
-  id: expected
-  attributes:
-    label: What did you expect to happen?
-  validations:
-    required: true
-
-- type: textarea
-  id: environment
-  attributes:
-    label: Patroni/PostgreSQL/DCS version
-    value: |
-      -   Patroni version: 
-      -   PostgreSQL version: 
-      -   DCS (and its version): 
-  validations:
-    required: true
-
-- type: textarea
-  id: patroniConfig
-  attributes:
-    label: Patroni configuration file
-    description: Please copy and paste Patroni configuration file here. This will be automatically formatted into code, so no need for backticks.
-    render: yaml
-  validations:
-    required: true
-
-- type: textarea
-  id: globalConfig
-  attributes:
-    label: patronictl show-config
-    description: Please copy and paste `patronictl show-config` output here. This will be automatically formatted into code, so no need for backticks.
-    render: yaml
-  validations:
-    required: true
-
-- type: textarea
-  id: patroniLogs
-  attributes:
-    label: Patroni log files
-    description: Please copy and paste any relevant Patroni log output. This will be automatically formatted into code, so no need for backticks.
-    render: shell
-  validations:
-    required: true
-
-- type: textarea
-  id: postgresLogs
-  attributes:
-    label: PostgreSQL log files
-    description: Please copy and paste any relevant PostgreSQL log output. This will be automatically formatted into code, so no need for backticks.
-    render: shell
-  validations:
-    required: true
-
-- type: checkboxes
-  id: issueSearch
-  attributes:
-    label: Have you tried to use GitHub issue search?
-    description: Maybe there is already a similar issue solved.
-    options:
-    - label: 'Yes'
-      required: true
-  validations:
-    required: true
-
-- type: textarea
-  id: additional
-  attributes:
-    label: Anything else we need to know?
-    description: Add any other context about the problem here.

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +0,0 @@
-blank_issues_enabled: false
-contact_links:
-- name: Question
-  url: https://pgtreats.info/slack-invite
-  about: "Please ask questions on channel #patroni in the PostgreSQL Slack"

.github/workflows/install_deps.py

@@ -5,6 +5,7 @@ import subprocess
 import stat
 import sys
 import tarfile
+import time
 import zipfile
 
 
@@ -19,7 +20,7 @@ def install_requirements(what):
     requirements = ['mock>=2.0.0', 'flake8', 'pytest', 'pytest-cov'] if what == 'all' else ['behave']
     requirements += ['coverage']
     # try to split tests between psycopg2 and psycopg3
-    requirements += ['psycopg[binary]'] if sys.version_info >= (3, 8, 0) and\
+    requirements += ['psycopg[binary]'] if sys.version_info >= (3, 6, 0) and\
         (sys.platform != 'darwin' or what == 'etcd3') else ['psycopg2-binary']
     for r in read('requirements.txt').split('\n'):
         r = r.strip()
@@ -29,7 +30,6 @@ def install_requirements(what):
                 requirements.append(r)
 
     subprocess.call([sys.executable, '-m', 'pip', 'install', '--upgrade', 'pip'])
-    subprocess.call([sys.executable, '-m', 'pip', 'install', '--upgrade', 'wheel'])
     r = subprocess.call([sys.executable, '-m', 'pip', 'install'] + requirements)
     s = subprocess.call([sys.executable, '-m', 'pip', 'install', '--upgrade', 'setuptools'])
     return s | r
@@ -45,10 +45,10 @@ def install_packages(what):
     packages['exhibitor'] = packages['zookeeper']
     packages = packages.get(what, [])
     ver = versions.get(what)
-    if float(ver) >= 15:
-        packages += ['postgresql-{0}-citus-11.2'.format(ver)]
+    subprocess.call(['sudo', 'sed', '-i', 's/pgdg main.*$/pgdg main {0}/'.format(ver),
+                     '/etc/apt/sources.list.d/pgdg.list'])
     subprocess.call(['sudo', 'apt-get', 'update', '-y'])
-    return subprocess.call(['sudo', 'apt-get', 'install', '-y', 'postgresql-' + ver, 'expect-dev'] + packages)
+    return subprocess.call(['sudo', 'apt-get', 'install', '-y', 'postgresql-' + ver, 'expect-dev', 'wget'] + packages)
 
 
 def get_file(url, name):
@@ -85,8 +85,8 @@ def unzip_all(archive):
 
 
 def chmod_755(name):
-    os.chmod(name, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR
-             | stat.S_IRGRP | stat.S_IXGRP | stat.S_IROTH | stat.S_IXOTH)
+    os.chmod(name, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR |
+             stat.S_IRGRP | stat.S_IXGRP | stat.S_IROTH | stat.S_IXOTH)
 
 
 def unpack(archive, name):
@@ -98,7 +98,7 @@ def unpack(archive, name):
 
 
 def install_etcd():
-    version = os.environ.get('ETCDVERSION', '3.4.23')
+    version = os.environ.get('ETCDVERSION', '3.3.13')
     platform = {'linux2': 'linux', 'win32': 'windows', 'cygwin': 'windows'}.get(sys.platform, sys.platform)
     dirname = 'etcd-v{0}-{1}-amd64'.format(version, platform)
     ext = 'tar.gz' if platform == 'linux' else 'zip'
@@ -110,17 +110,59 @@ def install_etcd():
 
 
 def install_postgres():
-    version = os.environ.get('PGVERSION', '15.1-1')
+    version = os.environ.get('PGVERSION', '14.1-1')
     platform = {'darwin': 'osx', 'win32': 'windows-x64', 'cygwin': 'windows-x64'}[sys.platform]
-    if platform == 'osx':
-        return subprocess.call(['brew', 'install', 'expect', 'postgresql@{0}'.format(version.split('.')[0])])
     name = 'postgresql-{0}-{1}-binaries.zip'.format(version, platform)
     get_file('http://get.enterprisedb.com/postgresql/' + name, name)
     unzip_all(name)
     bin_dir = os.path.join('pgsql', 'bin')
     for f in os.listdir(bin_dir):
         chmod_755(os.path.join(bin_dir, f))
-    return subprocess.call(['pgsql/bin/postgres', '-V'])
+    subprocess.call(['pgsql/bin/postgres', '-V'])
+    return 0
+
+
+def setup_kubernetes():
+    get_file('https://storage.googleapis.com/minikube/k8sReleases/v1.7.0/localkube-linux-amd64', 'localkube')
+    chmod_755('localkube')
+
+    devnull = open(os.devnull, 'w')
+    subprocess.Popen(['sudo', 'nohup', './localkube', '--logtostderr=true', '--enable-dns=false'],
+                     stdout=devnull, stderr=devnull)
+    for _ in range(0, 120):
+        if subprocess.call(['wget', '-qO', '-', 'http://127.0.0.1:8080/'], stdout=devnull, stderr=devnull) == 0:
+            break
+        time.sleep(1)
+    else:
+        print('localkube did not start')
+        return 1
+
+    subprocess.call('sudo chmod 644 /var/lib/localkube/certs/*', shell=True)
+    print('Set up .kube/config')
+    kube = os.path.join(os.path.expanduser('~'), '.kube')
+    os.makedirs(kube)
+    with open(os.path.join(kube, 'config'), 'w') as f:
+        f.write("""apiVersion: v1
+clusters:
+- cluster:
+    certificate-authority: /var/lib/localkube/certs/ca.crt
+    server: https://127.0.0.1:8443
+  name: local
+contexts:
+- context:
+    cluster: local
+    user: myself
+  name: local
+current-context: local
+kind: Config
+preferences: {}
+users:
+- name: myself
+  user:
+    client-certificate: /var/lib/localkube/certs/apiserver.crt
+    client-key: /var/lib/localkube/certs/apiserver.key
+""")
+    return 0
 
 
 def main():
@@ -129,6 +171,8 @@ def main():
     if what != 'all':
         if sys.platform.startswith('linux'):
             r = install_packages(what)
+            if r == 0 and what == 'kubernetes':
+                r = setup_kubernetes()
         else:
             r = install_postgres()
 

.github/workflows/mapping.py

@@ -1 +1 @@
-versions = {'etcd': '9.6', 'etcd3': '14', 'consul': '13', 'exhibitor': '12', 'raft': '11', 'kubernetes': '15'}
+versions = {'etcd': '9.6', 'etcd3': '14', 'consul': '13', 'exhibitor': '12', 'raft': '11', 'kubernetes': '14'}

.github/workflows/release.yaml

@@ -1,41 +0,0 @@
-name: Publish Patroni distributions to PyPI and TestPyPI
-on:
-  push:
-    tags:
-      - 'v[0-9]+.[0-9]+.[0-9]+'
-  release:
-    types:
-      - published
-jobs:
-  build-n-publish:
-    name: Build and publish Patroni distributions to PyPI and TestPyPI
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@master
-
-    - name: Set up Python 3.9
-      uses: actions/setup-python@v4
-      with:
-        python-version: 3.9
-
-    - name: Install dependencies
-      run: python .github/workflows/install_deps.py
-
-    - name: Run tests and flake8
-      run: python .github/workflows/run_tests.py
-
-    - name: Build a binary wheel and a source tarball
-      run: python setup.py sdist bdist_wheel
-
-    - name: Publish distribution to Test PyPI
-      if: github.event_name == 'push'
-      uses: pypa/[email protected]
-      with:
-        password: ${{ secrets.TEST_PYPI_API_TOKEN }}
-        repository_url: https://test.pypi.org/legacy/
-
-    - name: Publish distribution to PyPI
-      if: github.event_name == 'release'
-      uses: pypa/[email protected]
-      with:
-        password: ${{ secrets.PYPI_API_TOKEN }}

.github/workflows/run_tests.py

@@ -28,20 +28,22 @@ def main():
         version = versions.get(what)
         path = '/usr/lib/postgresql/{0}/bin:.'.format(version)
         unbuffer = ['timeout', '900', 'unbuffer']
+        args = ['--tags=-skip'] if what == 'etcd' else []
     else:
+        path = os.path.abspath(os.path.join('pgsql', 'bin'))
         if sys.platform == 'darwin':
-            version = os.environ.get('PGVERSION', '15.1-1')
-            path = '/usr/local/opt/postgresql@{0}/bin:.'.format(version.split('.')[0])
-            unbuffer = ['unbuffer']
-        else:
-            path = os.path.abspath(os.path.join('pgsql', 'bin'))
-            unbuffer = []
+            path += ':.'
+        args = unbuffer = []
     env['PATH'] = path + os.pathsep + env['PATH']
     env['DCS'] = what
-    if what == 'kubernetes':
-        env['PATRONI_KUBERNETES_CONTEXT'] = 'k3d-k3s-default'
 
-    return subprocess.call(unbuffer + [sys.executable, '-m', 'behave'], env=env)
+    ret = subprocess.call(unbuffer + [sys.executable, '-m', 'behave'] + args, env=env)
+
+    if ret != 0:
+        if subprocess.call('grep . features/output/*_failed/*postgres?.*', shell=True) != 0:
+            subprocess.call('grep . features/output/*/*postgres?.*', shell=True)
+        return 1
+    return 0
 
 
 if __name__ == '__main__':

.github/workflows/tests.yaml

@@ -5,10 +5,8 @@ on:
   push:
     branches:
     - master
-
-env:
-  CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
-  SECRETS_AVAILABLE: ${{ secrets.CODACY_PROJECT_TOKEN != '' }}
+    tags:
+    - v.*
 
 jobs:
   unit:
@@ -19,10 +17,30 @@ jobs:
         os: [ubuntu, windows, macos]
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v1
+    - name: Set up Python 2.7
+      uses: actions/setup-python@v2
+      with:
+        python-version: 2.7
+      if: matrix.os != 'windows'
+    - name: Install dependencies
+      run: python .github/workflows/install_deps.py
+      if: matrix.os != 'windows'
+    - name: Run tests and flake8
+      run: python .github/workflows/run_tests.py
+      if: matrix.os != 'windows'
+
+    - name: Set up Python 3.6
+      uses: actions/setup-python@v2
+      with:
+        python-version: 3.6
+    - name: Install dependencies
+      run: python .github/workflows/install_deps.py
+    - name: Run tests and flake8
+      run: python .github/workflows/run_tests.py
 
     - name: Set up Python 3.7
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v2
       with:
         python-version: 3.7
     - name: Install dependencies
@@ -31,7 +49,7 @@ jobs:
       run: python .github/workflows/run_tests.py
 
     - name: Set up Python 3.8
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v2
       with:
         python-version: 3.8
     - name: Install dependencies
@@ -40,7 +58,7 @@ jobs:
       run: python .github/workflows/run_tests.py
 
     - name: Set up Python 3.9
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v2
       with:
         python-version: 3.9
     - name: Install dependencies
@@ -49,7 +67,7 @@ jobs:
       run: python .github/workflows/run_tests.py
 
     - name: Set up Python 3.10
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v2
       with:
         python-version: '3.10'
     - name: Install dependencies
@@ -57,15 +75,6 @@ jobs:
     - name: Run tests and flake8
       run: python .github/workflows/run_tests.py
 
-    - name: Set up Python 3.11
-      uses: actions/setup-python@v4
-      with:
-        python-version: 3.11
-    - name: Install dependencies
-      run: python .github/workflows/install_deps.py
-    - name: Run tests and flake8
-      run: python .github/workflows/run_tests.py
-
     - name: Combine coverage
       run: python .github/workflows/run_tests.py combine
 
@@ -83,118 +92,60 @@ jobs:
     runs-on: ${{ matrix.os }}-latest
     env:
       DCS: ${{ matrix.dcs }}
-      ETCDVERSION: 3.4.23
-      PGVERSION: 15.1-1  # for windows and macos
+      ETCDVERSION: 3.3.13
+      PGVERSION: 12.1-1  # for windows and macos
     strategy:
       fail-fast: false
       matrix:
         os: [ubuntu]
-        python-version: [3.7, '3.10']
+        python-version: [2.7, 3.6, 3.9]
         dcs: [etcd, etcd3, consul, exhibitor, kubernetes, raft]
+        exclude:
+        - dcs: kubernetes
+          python-version: 2.7
         include:
         - os: macos
-          python-version: 3.8
+          python-version: 3.7
           dcs: raft
         - os: macos
-          python-version: 3.9
+          python-version: 3.8
           dcs: etcd
         - os: macos
-          python-version: 3.11
+          python-version: '3.10'
           dcs: etcd3
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v1
     - name: Set up Python
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v2
       with:
         python-version: ${{ matrix.python-version }}
-    - uses: nolar/setup-k3d-k3s@v1
-      if: matrix.dcs == 'kubernetes'
-    - name: Add postgresql and citus apt repo
-      run: |
-        sudo apt-get update -y
-        sudo apt-get install -y wget ca-certificates gnupg debian-archive-keyring apt-transport-https
-        sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
-        sudo sh -c 'wget -qO - https://www.postgresql.org/media/keys/ACCC4CF8.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/apt.postgresql.org.gpg'
-        sudo sh -c 'echo "deb [signed-by=/etc/apt/trusted.gpg.d/citusdata_community.gpg] https://packagecloud.io/citusdata/community/ubuntu/ $(lsb_release -cs) main" > /etc/apt/sources.list.d/citusdata_community.list'
-        sudo sh -c 'wget -qO - https://packagecloud.io/citusdata/community/gpgkey | gpg --dearmor > /etc/apt/trusted.gpg.d/citusdata_community.gpg'
+    - name: Add postgresql apt repo
+      run: sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
       if: matrix.os == 'ubuntu'
     - name: Install dependencies
       run: python .github/workflows/install_deps.py
     - name: Run behave tests
       run: python .github/workflows/run_tests.py
-    - name: Upload logs if behave failed
-      uses: actions/upload-artifact@v3
-      if: failure()
+    - uses: actions/setup-python@v2
       with:
-        name: behave-${{ matrix.os }}-${{ matrix.dcs }}-${{ matrix.python-version }}-logs
-        path: |
-          features/output/*_failed/*postgres?.*
-          features/output/*.log
-        if-no-files-found: error
-        retention-days: 5
-    - name: Generate coverage xml report
-      run: python -m coverage xml -o cobertura.xml
-    - name: Upload coverage to Codacy
-      run: bash <(curl -Ls https://coverage.codacy.com/get.sh) report -r cobertura.xml -l Python --partial
-      if: ${{ env.SECRETS_AVAILABLE == 'true' }}
+        python-version: '3.10'
+    - name: Install coveralls
+      run: python -m pip install coveralls
+    - name: Upload Coverage
+      env:
+        COVERALLS_FLAG_NAME: behave-${{ matrix.os }}-${{ matrix.dcs }}-${{ matrix.python-version }}
+        COVERALLS_PARALLEL: 'true'
+        GITHUB_TOKEN: ${{ secrets.github_token }}
+      run: python -m coveralls --service=github
 
   coveralls-finish:
     name: Finalize coveralls.io
-    needs: unit
+    needs: [unit, behave]
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/setup-python@v4
+    - uses: actions/setup-python@v2
     - run: python -m pip install coveralls
     - run: python -m coveralls --service=github --finish
       env:
         GITHUB_TOKEN: ${{ secrets.github_token }}
-
-  codacy-final:
-    name: Finalize Codacy
-    needs: behave
-    runs-on: ubuntu-latest
-    steps:
-    - run: bash <(curl -Ls https://coverage.codacy.com/get.sh) final
-      if: ${{ env.SECRETS_AVAILABLE == 'true' }}
-
-  pyright:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v3
-
-    - name: Set up Python 3.11
-      uses: actions/setup-python@v4
-      with:
-        python-version: 3.11
-
-    - name: Install dependencies
-      run: python -m pip install -r requirements.txt psycopg2-binary psycopg
-
-    - uses: jakebailey/pyright-action@v1
-      with:
-        version: 1.1.320
-
-  docs:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v3
-
-    - name: Set up Python 3.11
-      uses: actions/setup-python@v4
-      with:
-        python-version: 3.11
-        cache: pip
-
-    - name: Install dependencies
-      run: pip install tox
-
-    - name: Install package dependencies
-      run: |
-        sudo apt update \
-        && sudo apt install -y \
-            latexmk texlive-latex-extra tex-gyre \
-            --no-install-recommends
-
-    - name: Generate documentation
-      run: tox -m docs

.gitignore

@@ -51,19 +51,9 @@ scm-source.json
 docs/build/
 docs/source/_static/
 docs/source/_templates/
-docs/modules/
 
 # Pycharm IDE
 .idea/
 
 #VSCode IDE
 .vscode/
-
-# Virtual environment
-venv*/
-
-# Default test data directory
-data/
-
-# macOS
-**/.DS_Store

.readthedocs.yaml

@@ -1,26 +0,0 @@
-# .readthedocs.yaml
-# Read the Docs configuration file
-# See https://docs.readthedocs.io/en/stable/config-file/v2.html for details
-
-# Required
-version: 2
-
-# Set the version of Python and other tools you might need
-build:
-  os: ubuntu-22.04
-  tools:
-    python: "3.11"
-
-# Build documentation in the docs/ directory with Sphinx
-sphinx:
-  configuration: docs/conf.py
-
-formats:
-  - epub
-  - pdf
-  - htmlzip
-
-python:
-  install:
-    - requirements: requirements.docs.txt
-    - requirements: requirements.txt

CODEOWNERS

@@ -1,2 +0,0 @@
-# global owners
-*        @CyberDem0n @hughcapet

Dockerfile

@@ -1,6 +1,6 @@
 ## This Dockerfile is meant to aid in the building and debugging patroni whilst developing on your local machine
 ## It has all the necessary components to play/debug with a single node appliance, running etcd
-ARG PG_MAJOR=15
+ARG PG_MAJOR=14
 ARG COMPRESS=false
 ARG PGHOME=/home/postgres
 ARG PGDATA=$PGHOME/data
@@ -14,7 +14,7 @@ ARG PGDATA
 ARG LC_ALL
 ARG LANG
 
-ENV ETCDVERSION=3.3.13 CONFDVERSION=0.16.0
+ENV ETCDVERSION=3.5.4 CONFDVERSION=0.16.0
 
 RUN set -ex \
     && export DEBIAN_FRONTEND=noninteractive \
@@ -25,7 +25,8 @@ RUN set -ex \
             | grep -Ev '^python3-(sphinx|etcd|consul|kazoo|kubernetes)' \
             | xargs apt-get install -y vim curl less jq locales haproxy sudo \
                             python3-etcd python3-kazoo python3-pip busybox \
-                            net-tools iputils-ping dumb-init --fix-missing \
+                            net-tools iputils-ping --fix-missing \
+    && pip3 install dumb-init \
 \
     # Cleanup all locales but en_US.UTF-8
     && find /usr/share/i18n/charmaps/ -type f ! -name UTF-8.gz -delete \
@@ -42,36 +43,24 @@ RUN set -ex \
     && echo 'syntax on\nfiletype plugin indent on\nset mouse-=a\nautocmd FileType yaml setlocal ts=2 sts=2 sw=2 expandtab' > /etc/vim/vimrc.local \
 \
     # Prepare postgres/patroni/haproxy environment
-    && mkdir -p "$PGHOME/.config/patroni" /patroni /run/haproxy \
-    && ln -s ../../postgres0.yml "$PGHOME/.config/patroni/patronictl.yaml" \
+    && mkdir -p $PGHOME/.config/patroni /patroni /run/haproxy \
+    && ln -s ../../postgres0.yml $PGHOME/.config/patroni/patronictl.yaml \
     && ln -s /patronictl.py /usr/local/bin/patronictl \
     && sed -i "s|/var/lib/postgresql.*|$PGHOME:/bin/bash|" /etc/passwd \
     && chown -R postgres:postgres /var/log \
 \
     # Download etcd
-    && curl -sL "https://github.com/coreos/etcd/releases/download/v$ETCDVERSION/etcd-v$ETCDVERSION-linux-$(dpkg --print-architecture).tar.gz" \
+    && curl -L https://github.com/coreos/etcd/releases/download/v${ETCDVERSION}/etcd-v${ETCDVERSION}-linux-$(dpkg --print-architecture).tar.gz \
             | tar xz -C /usr/local/bin --strip=1 --wildcards --no-anchored etcd etcdctl \
 \
-    && if [ $(dpkg --print-architecture) = 'arm64' ]; then \
-        # Build confd
-        apt-get install -y git make \
-        && curl -sL https://go.dev/dl/go1.20.4.linux-arm64.tar.gz | tar xz -C /usr/local go \
-        && export GOROOT=/usr/local/go && export PATH=$PATH:$GOROOT/bin \
-        && git clone --recurse-submodules https://github.com/kelseyhightower/confd.git \
-        && make -C confd \
-        && cp confd/bin/confd /usr/local/bin/confd \
-        && rm -rf /confd /usr/local/go; \
-    else \
-        # Download confd
-        curl -sL "https://github.com/kelseyhightower/confd/releases/download/v$CONFDVERSION/confd-$CONFDVERSION-linux-$(dpkg --print-architecture)" \
-            > /usr/local/bin/confd && chmod +x /usr/local/bin/confd; \
-    fi \
+    # Download confd
+    && curl -sL https://github.com/kelseyhightower/confd/releases/download/v${CONFDVERSION}/confd-${CONFDVERSION}-linux-$(dpkg --print-architecture) \
+            > /usr/local/bin/confd && chmod +x /usr/local/bin/confd \
 \
     # Clean up all useless packages and some files
     && apt-get purge -y --allow-remove-essential python3-pip gzip bzip2 util-linux e2fsprogs \
                 libmagic1 bsdmainutils login ncurses-bin libmagic-mgc e2fslibs bsdutils \
-                exim4-config gnupg-agent dirmngr \
-                git make \
+                exim4-config gnupg-agent dirmngr libpython2.7-stdlib libpython2.7-minimal \
     && apt-get autoremove -y \
     && apt-get clean -y \
     && rm -rf /var/lib/apt/lists/* \
@@ -100,37 +89,12 @@ RUN set -ex \
 #        /var/lib/dpkg/info/* \
     && find /usr/bin -xtype l -delete \
     && find /var/log -type f -exec truncate --size 0 {} \; \
-    && find /usr/lib/python3/dist-packages -name '*test*' | xargs rm -fr \
-    && find /lib/$(uname -m)-linux-gnu/security -type f ! -name pam_env.so ! -name pam_permit.so ! -name pam_unix.so -delete
-
-# perform compression if it is necessary
-ARG COMPRESS
-RUN if [ "$COMPRESS" = "true" ]; then \
-        set -ex \
-        # Allow certain sudo commands from postgres
-        && echo 'postgres ALL=(ALL) NOPASSWD: /bin/tar xpJf /a.tar.xz -C /, /bin/rm /a.tar.xz, /bin/ln -snf dash /bin/sh' >> /etc/sudoers \
-        && ln -snf busybox /bin/sh \
-        && arch=$(uname -m) \
-        && darch=$(uname -m | sed 's/_/-/') \
-        && files="/bin/sh /usr/bin/sudo /usr/lib/sudo/sudoers.so /lib/$arch-linux-gnu/security/pam_*.so" \
-        && libs="$(ldd $files | awk '{print $3;}' | grep '^/' | sort -u) /lib/ld-linux-$darch.so.* /lib/$arch-linux-gnu/ld-linux-$darch.so.* /lib/$arch-linux-gnu/libnsl.so.* /lib/$arch-linux-gnu/libnss_compat.so.* /lib/$arch-linux-gnu/libnss_files.so.*" \
-        && (echo /var/run $files $libs | tr ' ' '\n' && realpath $files $libs) | sort -u | sed 's/^\///' > /exclude \
-        && find /etc/alternatives -xtype l -delete \
-        && save_dirs="usr lib var bin sbin etc/ssl etc/init.d etc/alternatives etc/apt" \
-        && XZ_OPT=-e9v tar -X /exclude -cpJf a.tar.xz $save_dirs \
-        # we call "cat /exclude" to avoid including files from the $save_dirs that are also among
-        # the exceptions listed in the /exclude, as "uniq -u" eliminates all non-unique lines.
-        # By calling "cat /exclude" a second time we guarantee that there will be at least two lines
-        # for each exception and therefore they will be excluded from the output passed to 'rm'.
-        && /bin/busybox sh -c "(find $save_dirs -not -type d && cat /exclude /exclude && echo exclude) | sort | uniq -u | xargs /bin/busybox rm" \
-        && /bin/busybox --install -s \
-        && /bin/busybox sh -c "find $save_dirs -type d -depth -exec rmdir -p {} \; 2> /dev/null"; \
-    fi
+    && find /usr/lib/python3/dist-packages -name '*test*' | xargs rm -fr
 
 FROM scratch
 COPY --from=builder / /
 
-LABEL maintainer="Alexander Kukushkin <akukushkin@microsoft.com>"
+LABEL maintainer="Alexander Kukushkin <alexander.kukushkin@zalando.de>"
 
 ARG PG_MAJOR
 ARG COMPRESS
@@ -154,18 +118,17 @@ WORKDIR $PGHOME
 
 RUN sed -i 's/env python/&3/' /patroni*.py \
     # "fix" patroni configs
+    && sed -i 's/^\(  connect_address:\|  - host\)/#&/' postgres?.yml \
     && sed -i 's/^  listen: 127.0.0.1/  listen: 0.0.0.0/' postgres?.yml \
     && sed -i "s|^\(  data_dir: \).*|\1$PGDATA|" postgres?.yml \
     && sed -i "s|^#\(  bin_dir: \).*|\1$PGBIN|" postgres?.yml \
     && sed -i 's/^  - encoding: UTF8/  - locale: en_US.UTF-8\n&/' postgres?.yml \
-    && sed -i 's/^\(scope\|name\|etcd\|  host\|  authentication\|  connect_address\|  parameters\):/#&/' postgres?.yml \
+    && sed -i 's/^\(scope\|name\|etcd\|  host\|  authentication\|  pg_hba\|  parameters\):/#&/' postgres?.yml \
     && sed -i 's/^    \(replication\|superuser\|rewind\|unix_socket_directories\|\(\(  \)\{0,1\}\(username\|password\)\)\):/#&/' postgres?.yml \
-    && sed -i 's/^      parameters:/&\n        max_connections: 100/'  postgres?.yml \
-    && sed -i 's/^      pg_hba:/&\n      - local all all trust/' postgres?.yml \
-    && sed -i 's/^\(.*\) \(.*\) md5/\1 all md5/' postgres?.yml \
+    && sed -i 's/^      parameters:/      pg_hba:\n      - local all all trust\n      - host replication all all md5\n      - host all all all md5\n&\n        max_connections: 100/'  postgres?.yml \
     && if [ "$COMPRESS" = "true" ]; then chmod u+s /usr/bin/sudo; fi \
     && chmod +s /bin/ping \
-    && chown -R postgres:postgres "$PGHOME" /run /etc/haproxy
+    && chown -R postgres:postgres $PGHOME /run /etc/haproxy
 
 USER postgres
 

Dockerfile.citus

@@ -1,200 +0,0 @@
-## This Dockerfile is meant to aid in the building and debugging patroni whilst developing on your local machine
-## It has all the necessary components to play/debug with a single node appliance, running etcd
-ARG PG_MAJOR=15
-ARG COMPRESS=false
-ARG PGHOME=/home/postgres
-ARG PGDATA=$PGHOME/data
-ARG LC_ALL=C.UTF-8
-ARG LANG=C.UTF-8
-
-FROM postgres:$PG_MAJOR as builder
-
-ARG PGHOME
-ARG PGDATA
-ARG LC_ALL
-ARG LANG
-
-ENV ETCDVERSION=3.3.13 CONFDVERSION=0.16.0
-
-RUN set -ex \
-    && export DEBIAN_FRONTEND=noninteractive \
-    && echo 'APT::Install-Recommends "0";\nAPT::Install-Suggests "0";' > /etc/apt/apt.conf.d/01norecommend \
-    && apt-get update -y \
-    # postgres:PG_MAJOR is based on debian, which has the patroni package. We will install all required dependencies
-    && apt-cache depends patroni | sed -n -e 's/.*Depends: \(python3-.\+\)$/\1/p' \
-            | grep -Ev '^python3-(sphinx|etcd|consul|kazoo|kubernetes)' \
-            | xargs apt-get install -y vim curl less jq locales haproxy sudo \
-                            python3-etcd python3-kazoo python3-pip busybox \
-                            net-tools iputils-ping lsb-release dumb-init --fix-missing \
-    && if [ $(dpkg --print-architecture) = 'arm64' ]; then \
-        apt-get install -y postgresql-server-dev-$PG_MAJOR \
-                           git gcc make autoconf \
-                           libc6-dev flex libcurl4-gnutls-dev \
-                           libicu-dev libkrb5-dev liblz4-dev \
-                           libpam0g-dev libreadline-dev libselinux1-dev\
-                           libssl-dev libxslt1-dev libzstd-dev uuid-dev \
-        && git clone -b "main" https://github.com/citusdata/citus.git \
-        && MAKEFLAGS="-j $(grep -c ^processor /proc/cpuinfo)" \
-        && cd citus && ./configure && make install && cd ../ && rm -rf /citus; \
-    else \
-        echo "deb [signed-by=/etc/apt/trusted.gpg.d/citusdata_community.gpg] https://packagecloud.io/citusdata/community/debian/ $(lsb_release -cs) main" > /etc/apt/sources.list.d/citusdata_community.list \
-        && curl -sL https://packagecloud.io/citusdata/community/gpgkey | gpg --dearmor > /etc/apt/trusted.gpg.d/citusdata_community.gpg \
-        && apt-get update -y \
-        && apt-get -y install postgresql-$PG_MAJOR-citus-11.3; \
-    fi \
-\
-    # Cleanup all locales but en_US.UTF-8
-    && find /usr/share/i18n/charmaps/ -type f ! -name UTF-8.gz -delete \
-    && find /usr/share/i18n/locales/ -type f ! -name en_US ! -name en_GB ! -name i18n* ! -name iso14651_t1 ! -name iso14651_t1_common ! -name 'translit_*' -delete \
-    && echo 'en_US.UTF-8 UTF-8' > /usr/share/i18n/SUPPORTED \
-\
-    # Make sure we have a en_US.UTF-8 locale available
-    && localedef -i en_US -c -f UTF-8 -A /usr/share/locale/locale.alias en_US.UTF-8 \
-\
-    # haproxy dummy config
-    && echo 'global\n        stats socket /run/haproxy/admin.sock mode 660 level admin' > /etc/haproxy/haproxy.cfg \
-\
-    # vim config
-    && echo 'syntax on\nfiletype plugin indent on\nset mouse-=a\nautocmd FileType yaml setlocal ts=2 sts=2 sw=2 expandtab' > /etc/vim/vimrc.local \
-\
-    # Prepare postgres/patroni/haproxy environment
-    && mkdir -p $PGHOME/.config/patroni /patroni /run/haproxy \
-    && ln -s ../../postgres0.yml $PGHOME/.config/patroni/patronictl.yaml \
-    && ln -s /patronictl.py /usr/local/bin/patronictl \
-    && sed -i "s|/var/lib/postgresql.*|$PGHOME:/bin/bash|" /etc/passwd \
-    && chown -R postgres:postgres /var/log \
-\
-    # Download etcd
-    && curl -sL https://github.com/coreos/etcd/releases/download/v${ETCDVERSION}/etcd-v${ETCDVERSION}-linux-$(dpkg --print-architecture).tar.gz \
-            | tar xz -C /usr/local/bin --strip=1 --wildcards --no-anchored etcd etcdctl \
-\
-    && if [ $(dpkg --print-architecture) = 'arm64' ]; then \
-        # Build confd
-        curl -sL https://go.dev/dl/go1.20.4.linux-arm64.tar.gz | tar xz -C /usr/local go \
-        && export GOROOT=/usr/local/go && export PATH=$PATH:$GOROOT/bin \
-        && git clone --recurse-submodules https://github.com/kelseyhightower/confd.git \
-        && make -C confd \
-        && cp confd/bin/confd /usr/local/bin/confd \
-        && rm -rf /confd /usr/local/go; \
-    else \
-        # Download confd
-        curl -sL "https://github.com/kelseyhightower/confd/releases/download/v$CONFDVERSION/confd-$CONFDVERSION-linux-$(dpkg --print-architecture)" \
-            > /usr/local/bin/confd && chmod +x /usr/local/bin/confd; \
-    fi \
-    # Prepare client cert for HAProxy
-    && cat /etc/ssl/private/ssl-cert-snakeoil.key  /etc/ssl/certs/ssl-cert-snakeoil.pem > /etc/ssl/private/ssl-cert-snakeoil.crt \
-\
-    # Clean up all useless packages and some files
-    && apt-get purge -y --allow-remove-essential python3-pip gzip bzip2 util-linux e2fsprogs \
-                libmagic1 bsdmainutils login ncurses-bin libmagic-mgc e2fslibs bsdutils \
-                exim4-config gnupg-agent dirmngr \
-                postgresql-server-dev-$PG_MAJOR git gcc make autoconf \
-                libc6-dev flex libicu-dev libkrb5-dev liblz4-dev \
-                libpam0g-dev libreadline-dev libselinux1-dev libssl-dev libxslt1-dev libzstd-dev uuid-dev \
-    && apt-get autoremove -y \
-    && apt-get clean -y \
-    && rm -rf /var/lib/apt/lists/* \
-        /root/.cache \
-        /var/cache/debconf/* \
-        /etc/rc?.d \
-        /etc/systemd \
-        /docker-entrypoint* \
-        /sbin/pam* \
-        /sbin/swap* \
-        /sbin/unix* \
-        /usr/local/bin/gosu \
-        /usr/sbin/[acgipr]* \
-        /usr/sbin/*user* \
-        /usr/share/doc* \
-        /usr/share/man \
-        /usr/share/info \
-        /usr/share/i18n/locales/translit_hangul \
-        /usr/share/locale/?? \
-        /usr/share/locale/??_?? \
-        /usr/share/postgresql/*/man \
-        /usr/share/postgresql-common/pg_wrapper \
-        /usr/share/vim/vim80/doc \
-        /usr/share/vim/vim80/lang \
-        /usr/share/vim/vim80/tutor \
-#        /var/lib/dpkg/info/* \
-    && find /usr/bin -xtype l -delete \
-    && find /var/log -type f -exec truncate --size 0 {} \; \
-    && find /usr/lib/python3/dist-packages -name '*test*' | xargs rm -fr \
-    && find /lib/$(uname -m)-linux-gnu/security -type f ! -name pam_env.so ! -name pam_permit.so ! -name pam_unix.so -delete
-
-# perform compression if it is necessary
-ARG COMPRESS
-RUN if [ "$COMPRESS" = "true" ]; then \
-        set -ex \
-        # Allow certain sudo commands from postgres
-        && echo 'postgres ALL=(ALL) NOPASSWD: /bin/tar xpJf /a.tar.xz -C /, /bin/rm /a.tar.xz, /bin/ln -snf dash /bin/sh' >> /etc/sudoers \
-        && ln -snf busybox /bin/sh \
-        && arch=$(uname -m) \
-        && darch=$(uname -m | sed 's/_/-/') \
-        && files="/bin/sh /usr/bin/sudo /usr/lib/sudo/sudoers.so /lib/$arch-linux-gnu/security/pam_*.so" \
-        && libs="$(ldd $files | awk '{print $3;}' | grep '^/' | sort -u) /lib/ld-linux-$darch.so.* /lib/$arch-linux-gnu/ld-linux-$darch.so.* /lib/$arch-linux-gnu/libnsl.so.* /lib/$arch-linux-gnu/libnss_compat.so.* /lib/$arch-linux-gnu/libnss_files.so.*" \
-        && (echo /var/run $files $libs | tr ' ' '\n' && realpath $files $libs) | sort -u | sed 's/^\///' > /exclude \
-        && find /etc/alternatives -xtype l -delete \
-        && save_dirs="usr lib var bin sbin etc/ssl etc/init.d etc/alternatives etc/apt" \
-        && XZ_OPT=-e9v tar -X /exclude -cpJf a.tar.xz $save_dirs \
-        # we call "cat /exclude" to avoid including files from the $save_dirs that are also among
-        # the exceptions listed in the /exclude, as "uniq -u" eliminates all non-unique lines.
-        # By calling "cat /exclude" a second time we guarantee that there will be at least two lines
-        # for each exception and therefore they will be excluded from the output passed to 'rm'.
-        && /bin/busybox sh -c "(find $save_dirs -not -type d && cat /exclude /exclude && echo exclude) | sort | uniq -u | xargs /bin/busybox rm" \
-        && /bin/busybox --install -s \
-        && /bin/busybox sh -c "find $save_dirs -type d -depth -exec rmdir -p {} \; 2> /dev/null"; \
-    else \
-        /bin/busybox --install -s; \
-    fi
-
-FROM scratch
-COPY --from=builder / /
-
-LABEL maintainer="Alexander Kukushkin <[email protected]>"
-
-ARG PG_MAJOR
-ARG COMPRESS
-ARG PGHOME
-ARG PGDATA
-ARG LC_ALL
-ARG LANG
-
-ARG PGBIN=/usr/lib/postgresql/$PG_MAJOR/bin
-
-ENV LC_ALL=$LC_ALL LANG=$LANG EDITOR=/usr/bin/editor
-ENV PGDATA=$PGDATA PATH=$PATH:$PGBIN
-
-COPY patroni /patroni/
-COPY extras/confd/conf.d/haproxy.toml /etc/confd/conf.d/
-COPY extras/confd/templates/haproxy-citus.tmpl /etc/confd/templates/haproxy.tmpl
-COPY patroni*.py docker/entrypoint.sh /
-COPY postgres?.yml $PGHOME/
-
-WORKDIR $PGHOME
-
-RUN sed -i 's/env python/&3/' /patroni*.py \
-    # "fix" patroni configs
-    && sed -i 's/^  listen: 127.0.0.1/  listen: 0.0.0.0/' postgres?.yml \
-    && sed -i "s|^\(  data_dir: \).*|\1$PGDATA|" postgres?.yml \
-    && sed -i "s|^#\(  bin_dir: \).*|\1$PGBIN|" postgres?.yml \
-    && sed -i 's/^  - encoding: UTF8/  - locale: en_US.UTF-8\n&/' postgres?.yml \
-    && sed -i 's/^scope:/log:\n  loggers:\n    patroni.postgresql.citus: DEBUG\n#&/' postgres?.yml \
-    && sed -i 's/^\(name\|etcd\|  host\|  authentication\|  connect_address\|  parameters\):/#&/' postgres?.yml \
-    && sed -i 's/^    \(replication\|superuser\|rewind\|unix_socket_directories\|\(\(  \)\{0,1\}\(username\|password\)\)\):/#&/' postgres?.yml \
-    && sed -i 's/^postgresql:/&\n  basebackup:\n    checkpoint: fast/' postgres?.yml \
-    && sed -i 's|^      parameters:|&\n        max_connections: 100\n        shared_buffers: 16MB\n        ssl: "on"\n        ssl_ca_file: /etc/ssl/certs/ssl-cert-snakeoil.pem\n        ssl_cert_file: /etc/ssl/certs/ssl-cert-snakeoil.pem\n        ssl_key_file: /etc/ssl/private/ssl-cert-snakeoil.key\n        citus.node_conninfo: "sslrootcert=/etc/ssl/certs/ssl-cert-snakeoil.pem sslkey=/etc/ssl/private/ssl-cert-snakeoil.key sslcert=/etc/ssl/certs/ssl-cert-snakeoil.pem sslmode=verify-ca"|'  postgres?.yml \
-    && sed -i 's/^      pg_hba:/&\n      - local all all trust/' postgres?.yml \
-    && sed -i 's/^\(.*\) \(.*\) \(.*\) \(.*\) \(.*\) md5.*$/\1 hostssl \3 \4 all md5 clientcert=verify-ca/' postgres?.yml \
-    && sed -i 's/^#\(ctl\|  certfile\|  keyfile\)/\1/' postgres?.yml \
-    && sed -i 's|^#  cafile: .*$|  verify_client: required\n  cafile: /etc/ssl/certs/ssl-cert-snakeoil.pem|' postgres?.yml \
-    && sed -i 's|^#  cacert: .*$|  cacert: /etc/ssl/certs/ssl-cert-snakeoil.pem|' postgres?.yml \
-    && sed -i 's/^#  insecure: .*/  insecure: on/' postgres?.yml \
-    # client cert for HAProxy to access Patroni REST API
-    && if [ "$COMPRESS" = "true" ]; then chmod u+s /usr/bin/sudo; fi \
-    && chmod +s /bin/ping \
-    && chown -R postgres:postgres $PGHOME /run /etc/haproxy
-
-USER postgres
-
-ENTRYPOINT ["/bin/sh", "/entrypoint.sh"]

MAINTAINERS

@@ -1,2 +1,3 @@
-Alexander Kukushkin <akukushkin@microsoft.com>
-Polina Bungina <polina.bungina@zalando.de>
+Alexander Kukushkin <alexander.kukushkin@zalando.de>
+Feike Steenbergen <feike.steenbergen@zalando.de>
+Oleksii Kliukin <[email protected]>

README.rst

@@ -8,13 +8,11 @@ You can find a version of this documentation that is searchable and also easier
 
 There are many ways to run high availability with PostgreSQL; for a list, see the `PostgreSQL Documentation <https://wiki.postgresql.org/wiki/Replication,_Clustering,_and_Connection_Pooling>`__.
 
-Patroni is a template for high availability (HA) PostgreSQL solutions using Python. For maximum accessibility, Patroni supports a variety of distributed configuration stores like `ZooKeeper <https://zookeeper.apache.org/>`__, `etcd <https://github.com/coreos/etcd>`__, `Consul <https://github.com/hashicorp/consul>`__ or `Kubernetes <https://kubernetes.io>`__. Database engineers, DBAs, DevOps engineers, and SREs who are looking to quickly deploy HA PostgreSQL in datacenters - or anywhere else - will hopefully find it useful.
+Patroni is a template for you to create your own customized, high-availability solution using Python and - for maximum accessibility - a distributed configuration store like `ZooKeeper <https://zookeeper.apache.org/>`__, `etcd <https://github.com/coreos/etcd>`__, `Consul <https://github.com/hashicorp/consul>`__ or `Kubernetes <https://kubernetes.io>`__. Database engineers, DBAs, DevOps engineers, and SREs who are looking to quickly deploy HA PostgreSQL in the datacenter-or anywhere else-will hopefully find it useful.
 
 We call Patroni a "template" because it is far from being a one-size-fits-all or plug-and-play replication system. It will have its own caveats. Use wisely.
 
-Currently supported PostgreSQL versions: 9.3 to 15.
-
-**Note to Citus users**: Starting from 3.0 Patroni nicely integrates with the `Citus <https://github.com/citusdata/citus>`__ database extension to Postgres. Please check the `Citus support page <https://github.com/zalando/patroni/blob/master/docs/citus.rst>`__ in the Patroni documentation for more info about how to use Patroni high availability together with a Citus distributed cluster.
+Currently supported PostgreSQL versions: 9.3 to 14.
 
 **Note to Kubernetes users**: Patroni can run natively on top of Kubernetes. Take a look at the `Kubernetes <https://github.com/zalando/patroni/blob/master/docs/kubernetes.rst>`__ chapter of the Patroni documentation.
 
@@ -49,7 +47,7 @@ We report new releases information `here <https://github.com/zalando/patroni/rel
 Community
 =========
 
-There are two places to connect with the Patroni community: `on github <https://github.com/zalando/patroni>`__, via Issues and PRs, and on channel `#patroni <https://postgresteam.slack.com/archives/C9XPYG92A>`__ in the `PostgreSQL Slack <https://pgtreats.info/slack-invite>`__.  If you're using Patroni, or just interested, please join us.
+There are two places to connect with the Patroni community: `on github <https://github.com/zalando/patroni>`__, via Issues and PRs, and on channel #patroni in the `PostgreSQL Slack <https://postgres-slack.herokuapp.com/>`__.  If you're using Patroni, or just interested, please join us.
 
 ===================================
 Technical Requirements/Installation
@@ -74,8 +72,9 @@ There are a few options available:
 
 ::
 
-    sudo apt-get install python3-psycopg2  # install psycopg2 module on Debian/Ubuntu
-    sudo yum install python3-psycopg2      # install psycopg2 on RedHat/Fedora/CentOS
+    sudo apt-get install python-psycopg2   # install python2 psycopg2 module on Debian/Ubuntu
+    sudo apt-get install python3-psycopg2  # install python3 psycopg2 module on Debian/Ubuntu
+    sudo yum install python-psycopg2       # install python2 psycopg2 on RedHat/Fedora/CentOS
 
 2. Install psycopg2 from the binary package
 
@@ -93,7 +92,7 @@ There are a few options available:
 
 ::
 
-    pip install psycopg[binary]>=3.0.0
+    pip install psycopg[binary]
 
 **General installation for pip**
 
@@ -118,7 +117,7 @@ kubernetes
 raft
     `pysyncobj` module in order to use python Raft implementation as DCS
 aws
-    `boto3` in order to use AWS callbacks
+    `boto` in order to use AWS callbacks
 
 For example, the command in order to install Patroni together with dependencies for Etcd as a DCS and AWS callbacks is:
 

TODO.md

@@ -0,0 +1,12 @@
+Failover
+========
+- When determining who should become master, include the minor version of PostgreSQL in the decision.
+
+Configuration
+==============
+- Provide a way to change pg_hba.conf of a running cluster on the Patroni level, without changing individual nodes.
+- Provide hooks to store and retrieve cluster-wide passwords without exposing them in a plain-text form to unauthorized users.
+
+Documentation
+==============
+- Document how to run cascading replication and possibly initialize the cluster without an access to the master node.

docker-compose-citus.yml

@@ -1,140 +0,0 @@
-# docker compose file for running a Citus cluster
-# with 3-node etcd v3 cluster as the DCS and one haproxy node.
-# The Citus cluster has a coordinator (3 nodes)
-# and two worker clusters (2 nodes).
-#
-# Before starting it up you need to build the docker image:
-# $ docker build -f Dockerfile.citus -t patroni-citus .
-# The cluster could be started as:
-# $ docker-compose -f docker-compose-citus.yml up -d
-# You can read more about it in the:
-# https://github.com/zalando/patroni/blob/master/docker/README.md#citus-cluster
-version: "2"
-
-networks:
-    demo:
-
-services:
-    etcd1: &etcd
-        image: ${PATRONI_TEST_IMAGE:-patroni-citus}
-        networks: [ demo ]
-        environment:
-            ETCDCTL_API: 3
-            ETCD_LISTEN_PEER_URLS: http://0.0.0.0:2380
-            ETCD_LISTEN_CLIENT_URLS: http://0.0.0.0:2379
-            ETCD_INITIAL_CLUSTER: etcd1=http://etcd1:2380,etcd2=http://etcd2:2380,etcd3=http://etcd3:2380
-            ETCD_INITIAL_CLUSTER_STATE: new
-            ETCD_INITIAL_CLUSTER_TOKEN: tutorial
-            ETCD_UNSUPPORTED_ARCH: arm64
-        container_name: demo-etcd1
-        hostname: etcd1
-        command: etcd -name etcd1 -initial-advertise-peer-urls http://etcd1:2380
-
-    etcd2:
-        <<: *etcd
-        container_name: demo-etcd2
-        hostname: etcd2
-        command: etcd -name etcd2 -initial-advertise-peer-urls http://etcd2:2380
-
-    etcd3:
-        <<: *etcd
-        container_name: demo-etcd3
-        hostname: etcd3
-        command: etcd -name etcd3 -initial-advertise-peer-urls http://etcd3:2380
-
-    haproxy:
-        image: ${PATRONI_TEST_IMAGE:-patroni-citus}
-        networks: [ demo ]
-        env_file: docker/patroni.env
-        hostname: haproxy
-        container_name: demo-haproxy
-        ports:
-            - "5000:5000"  # Access to the coorinator primary
-            - "5001:5001"  # Load-balancing across workers primaries
-        command: haproxy
-        environment: &haproxy_env
-            ETCDCTL_API: 3
-            ETCDCTL_ENDPOINTS: http://etcd1:2379,http://etcd2:2379,http://etcd3:2379
-            PATRONI_ETCD3_HOSTS: "'etcd1:2379','etcd2:2379','etcd3:2379'"
-            PATRONI_SCOPE: demo
-            PATRONI_CITUS_GROUP: 0
-            PATRONI_CITUS_DATABASE: citus
-            PGSSLMODE: verify-ca
-            PGSSLKEY: /etc/ssl/private/ssl-cert-snakeoil.key
-            PGSSLCERT: /etc/ssl/certs/ssl-cert-snakeoil.pem
-            PGSSLROOTCERT: /etc/ssl/certs/ssl-cert-snakeoil.pem
-
-    coord1:
-        image: ${PATRONI_TEST_IMAGE:-patroni-citus}
-        networks: [ demo ]
-        env_file: docker/patroni.env
-        hostname: coord1
-        container_name: demo-coord1
-        environment: &coord_env
-            <<: *haproxy_env
-            PATRONI_NAME: coord1
-            PATRONI_CITUS_GROUP: 0
-
-    coord2:
-        image: ${PATRONI_TEST_IMAGE:-patroni-citus}
-        networks: [ demo ]
-        env_file: docker/patroni.env
-        hostname: coord2
-        container_name: demo-coord2
-        environment:
-            <<: *coord_env
-            PATRONI_NAME: coord2
-
-    coord3:
-        image: ${PATRONI_TEST_IMAGE:-patroni-citus}
-        networks: [ demo ]
-        env_file: docker/patroni.env
-        hostname: coord3
-        container_name: demo-coord3
-        environment:
-            <<: *coord_env
-            PATRONI_NAME: coord3
-
-
-    work1-1:
-        image: ${PATRONI_TEST_IMAGE:-patroni-citus}
-        networks: [ demo ]
-        env_file: docker/patroni.env
-        hostname: work1-1
-        container_name: demo-work1-1
-        environment: &work1_env
-            <<: *haproxy_env
-            PATRONI_NAME: work1-1
-            PATRONI_CITUS_GROUP: 1
-
-    work1-2:
-        image: ${PATRONI_TEST_IMAGE:-patroni-citus}
-        networks: [ demo ]
-        env_file: docker/patroni.env
-        hostname: work1-2
-        container_name: demo-work1-2
-        environment:
-            <<: *work1_env
-            PATRONI_NAME: work1-2
-
-
-    work2-1:
-        image: ${PATRONI_TEST_IMAGE:-patroni-citus}
-        networks: [ demo ]
-        env_file: docker/patroni.env
-        hostname: work2-1
-        container_name: demo-work2-1
-        environment: &work2_env
-            <<: *haproxy_env
-            PATRONI_NAME: work2-1
-            PATRONI_CITUS_GROUP: 2
-
-    work2-2:
-        image: ${PATRONI_TEST_IMAGE:-patroni-citus}
-        networks: [ demo ]
-        env_file: docker/patroni.env
-        hostname: work2-2
-        container_name: demo-work2-2
-        environment:
-            <<: *work2_env
-            PATRONI_NAME: work2-2

docker-compose.yml

@@ -1,12 +1,5 @@
 # docker compose file for running a 3-node PostgreSQL cluster
 # with 3-node etcd cluster as the DCS and one haproxy node
-#
-# requires a patroni image build from the Dockerfile:
-# $ docker build -t patroni .
-# The cluster could be started as:
-# $ docker-compose up -d
-# You can read more about it in the:
-# https://github.com/zalando/patroni/blob/master/docker/README.md
 version: "2"
 
 networks:
@@ -14,7 +7,7 @@ networks:
 
 services:
     etcd1: &etcd
-        image: ${PATRONI_TEST_IMAGE:-patroni}
+        image: patroni
         networks: [ demo ]
         environment:
             ETCD_LISTEN_PEER_URLS: http://0.0.0.0:2380
@@ -40,7 +33,7 @@ services:
         command: etcd -name etcd3 -initial-advertise-peer-urls http://etcd3:2380
 
     haproxy:
-        image: ${PATRONI_TEST_IMAGE:-patroni}
+        image: patroni
         networks: [ demo ]
         env_file: docker/patroni.env
         hostname: haproxy
@@ -55,7 +48,7 @@ services:
             PATRONI_SCOPE: demo
 
     patroni1:
-        image: ${PATRONI_TEST_IMAGE:-patroni}
+        image: patroni
         networks: [ demo ]
         env_file: docker/patroni.env
         hostname: patroni1
@@ -65,7 +58,7 @@ services:
             PATRONI_NAME: patroni1
 
     patroni2:
-        image: ${PATRONI_TEST_IMAGE:-patroni}
+        image: patroni
         networks: [ demo ]
         env_file: docker/patroni.env
         hostname: patroni2
@@ -75,7 +68,7 @@ services:
             PATRONI_NAME: patroni2
 
     patroni3:
-        image: ${PATRONI_TEST_IMAGE:-patroni}
+        image: patroni
         networks: [ demo ]
         env_file: docker/patroni.env
         hostname: patroni3

docker/README.md

@@ -1,10 +1,10 @@
-# Dockerfile and Dockerfile.citus
-You can run Patroni in a docker container using these Dockerfiles
+# Patroni Dockerfile
+You can run Patroni in a docker container using this Dockerfile
 
-They are meant in aiding development of Patroni and quick testing of features and not a production-worthy!
+This Dockerfile is meant in aiding development of Patroni and quick testing of features. It is not a production-worthy
+Dockerfile
 
     docker build -t patroni .
-    docker build -f Dockerfile.citus -t patroni-citus .
 
 # Examples
 
@@ -12,10 +12,7 @@ They are meant in aiding development of Patroni and quick testing of features an
 
     docker run -d patroni
 
-## Three-node Patroni cluster
-
-In addition to three Patroni containers the stack starts three containers with etcd (forming a three-node cluster), and one container with haproxy.
-The haproxy listens on ports 5000 (connects to the primary) and 5001 (does load-balancing between healthy standbys).
+## Three-node Patroni cluster with three-node etcd cluster and one haproxy container using docker-compose
 
 Example session:
 
@@ -95,8 +92,7 @@ Example session:
     b2e169fcb8a34028: name=etcd1 peerURLs=http://etcd1:2380 clientURLs=http://etcd1:2379 isLeader=false
     postgres@patroni1:~$ exit
 
-    $ docker exec -ti demo-haproxy bash
-    postgres@haproxy:~$ psql -h localhost -p 5000 -U postgres -W
+    $ psql -h localhost -p 5000 -U postgres -W
     Password: postgres
     psql (11.2 (Ubuntu 11.2-1.pgdg18.04+1), server 10.7 (Debian 10.7-1.pgdg90+1))
     Type "help" for help.
@@ -109,7 +105,7 @@ Example session:
 
     localhost/postgres=# \q
 
-    $postgres@haproxy:~ psql -h localhost -p 5001 -U postgres -W
+    $ psql -h localhost -p 5001 -U postgres -W
     Password: postgres
     psql (11.2 (Ubuntu 11.2-1.pgdg18.04+1), server 10.7 (Debian 10.7-1.pgdg90+1))
     Type "help" for help.
@@ -119,188 +115,3 @@ Example session:
     ───────────────────
      t
     (1 row)
-
-## Citus cluster
-
-The stack starts three containers with etcd (forming a three-node etcd cluster), seven containers with Patroni+PostgreSQL+Citus (three coordinator nodes, and two worker clusters with two nodes each), and one container with haproxy.
-The haproxy listens on ports 5000 (connects to the coordinator primary) and 5001 (does load-balancing between worker primary nodes).
-
-Example session:
-
-    $ docker-compose -f docker-compose-citus.yml up -d
-    Creating demo-work2-1 ... done
-    Creating demo-work1-1 ... done
-    Creating demo-etcd2   ... done
-    Creating demo-etcd1   ... done
-    Creating demo-coord3  ... done
-    Creating demo-etcd3   ... done
-    Creating demo-coord1  ... done
-    Creating demo-haproxy ... done
-    Creating demo-work2-2 ... done
-    Creating demo-coord2  ... done
-    Creating demo-work1-2 ... done
-
-    $ docker ps
-    CONTAINER ID   IMAGE                  COMMAND                  CREATED         STATUS         PORTS                              NAMES
-    852d8885a612   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 3 seconds                                      demo-coord3
-    cdd692f947ab   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 3 seconds                                      demo-work1-2
-    9f4e340b36da   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 3 seconds                                      demo-etcd3
-    d69c129a960a   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 4 seconds                                      demo-etcd1
-    c5849689b8cd   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 4 seconds                                      demo-coord1
-    c9d72bd6217d   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 3 seconds                                      demo-work2-1
-    24b1b43efa05   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 4 seconds                                      demo-coord2
-    cb0cc2b4ca0a   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 3 seconds                                      demo-work2-2
-    9796c6b8aad5   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 5 seconds                                      demo-work1-1
-    8baccd74dcae   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 4 seconds                                      demo-etcd2
-    353ec62a0187   patroni-citus          "/bin/sh /entrypoint…"   6 seconds ago   Up 4 seconds   0.0.0.0:5000-5001->5000-5001/tcp   demo-haproxy
-
-    $ docker logs demo-coord1
-    2023-01-05 15:09:31,295 INFO: Selected new etcd server http://172.27.0.4:2379
-    2023-01-05 15:09:31,388 INFO: Lock owner: None; I am coord1
-    2023-01-05 15:09:31,501 INFO: trying to bootstrap a new cluster
-    ...
-    2023-01-05 15:09:45,096 INFO: postmaster pid=39
-    localhost:5432 - no response
-    2023-01-05 15:09:45.137 UTC [39] LOG:  starting PostgreSQL 15.1 (Debian 15.1-1.pgdg110+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 10.2.1-6) 10.2.1 20210110, 64-bit
-    2023-01-05 15:09:45.137 UTC [39] LOG:  listening on IPv4 address "0.0.0.0", port 5432
-    2023-01-05 15:09:45.152 UTC [39] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
-    2023-01-05 15:09:45.177 UTC [43] LOG:  database system was shut down at 2023-01-05 15:09:32 UTC
-    2023-01-05 15:09:45.193 UTC [39] LOG:  database system is ready to accept connections
-    localhost:5432 - accepting connections
-    localhost:5432 - accepting connections
-    2023-01-05 15:09:46,139 INFO: establishing a new patroni connection to the postgres cluster
-    2023-01-05 15:09:46,208 INFO: running post_bootstrap
-    2023-01-05 15:09:47.209 UTC [55] LOG:  starting maintenance daemon on database 16386 user 10
-    2023-01-05 15:09:47.209 UTC [55] CONTEXT:  Citus maintenance daemon for database 16386 user 10
-    2023-01-05 15:09:47,215 WARNING: Could not activate Linux watchdog device: "Can't open watchdog device: [Errno 2] No such file or directory: '/dev/watchdog'"
-    2023-01-05 15:09:47.446 UTC [41] LOG:  checkpoint starting: immediate force wait
-    2023-01-05 15:09:47,466 INFO: initialized a new cluster
-    2023-01-05 15:09:47,594 DEBUG: query(SELECT nodeid, groupid, nodename, nodeport, noderole FROM pg_catalog.pg_dist_node WHERE noderole = 'primary', ())
-    2023-01-05 15:09:47,594 INFO: establishing a new patroni connection to the postgres cluster
-    2023-01-05 15:09:47,467 INFO: Lock owner: coord1; I am coord1
-    2023-01-05 15:09:47,613 DEBUG: query(SELECT pg_catalog.citus_set_coordinator_host(%s, %s, 'primary', 'default'), ('172.27.0.6', 5432))
-    2023-01-05 15:09:47,924 INFO: no action. I am (coord1), the leader with the lock
-    2023-01-05 15:09:51.282 UTC [41] LOG:  checkpoint complete: wrote 1086 buffers (53.0%); 0 WAL file(s) added, 0 removed, 0 recycled; write=0.029 s, sync=3.746 s, total=3.837 s; sync files=280, longest=0.028 s, average=0.014 s; distance=8965 kB, estimate=8965 kB
-    2023-01-05 15:09:51.283 UTC [41] LOG:  checkpoint starting: immediate force wait
-    2023-01-05 15:09:51.495 UTC [41] LOG:  checkpoint complete: wrote 18 buffers (0.9%); 0 WAL file(s) added, 0 removed, 0 recycled; write=0.044 s, sync=0.091 s, total=0.212 s; sync files=15, longest=0.015 s, average=0.007 s; distance=67 kB, estimate=8076 kB
-    2023-01-05 15:09:57,467 INFO: Lock owner: coord1; I am coord1
-    2023-01-05 15:09:57,569 INFO: Assigning synchronous standby status to ['coord3']
-    server signaled
-    2023-01-05 15:09:57.574 UTC [39] LOG:  received SIGHUP, reloading configuration files
-    2023-01-05 15:09:57.580 UTC [39] LOG:  parameter "synchronous_standby_names" changed to "coord3"
-    2023-01-05 15:09:59,637 INFO: Synchronous standby status assigned to ['coord3']
-    2023-01-05 15:09:59,638 DEBUG: query(SELECT pg_catalog.citus_add_node(%s, %s, %s, 'primary', 'default'), ('172.27.0.2', 5432, 1))
-    2023-01-05 15:09:59.690 UTC [67] LOG:  standby "coord3" is now a synchronous standby with priority 1
-    2023-01-05 15:09:59.690 UTC [67] STATEMENT:  START_REPLICATION SLOT "coord3" 0/3000000 TIMELINE 1
-    2023-01-05 15:09:59,694 INFO: no action. I am (coord1), the leader with the lock
-    2023-01-05 15:09:59,704 DEBUG: query(SELECT pg_catalog.citus_add_node(%s, %s, %s, 'primary', 'default'), ('172.27.0.8', 5432, 2))
-    2023-01-05 15:10:07,625 INFO: no action. I am (coord1), the leader with the lock
-    2023-01-05 15:10:17,579 INFO: no action. I am (coord1), the leader with the lock
-
-    $ docker exec -ti demo-haproxy bash
-    postgres@haproxy:~$ etcdctl member list
-    1bab629f01fa9065, started, etcd3, http://etcd3:2380, http://172.27.0.10:2379
-    8ecb6af518d241cc, started, etcd2, http://etcd2:2380, http://172.27.0.4:2379
-    b2e169fcb8a34028, started, etcd1, http://etcd1:2380, http://172.27.0.7:2379
-
-    postgres@haproxy:~$ etcdctl get --keys-only --prefix /service/demo
-    /service/demo/0/config
-    /service/demo/0/initialize
-    /service/demo/0/leader
-    /service/demo/0/members/coord1
-    /service/demo/0/members/coord2
-    /service/demo/0/members/coord3
-    /service/demo/0/status
-    /service/demo/0/sync
-    /service/demo/1/config
-    /service/demo/1/initialize
-    /service/demo/1/leader
-    /service/demo/1/members/work1-1
-    /service/demo/1/members/work1-2
-    /service/demo/1/status
-    /service/demo/1/sync
-    /service/demo/2/config
-    /service/demo/2/initialize
-    /service/demo/2/leader
-    /service/demo/2/members/work2-1
-    /service/demo/2/members/work2-2
-    /service/demo/2/status
-    /service/demo/2/sync
-
-    postgres@haproxy:~$ psql -h localhost -p 5000 -U postgres -d citus
-    Password for user postgres: postgres
-    psql (15.1 (Debian 15.1-1.pgdg110+1))
-    SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA384, compression: off)
-    Type "help" for help.
-
-    citus=# select pg_is_in_recovery();
-     pg_is_in_recovery
-    -------------------
-     f
-    (1 row)
-
-    citus=# table pg_dist_node;
-     nodeid | groupid |  nodename  | nodeport | noderack | hasmetadata | isactive | noderole | nodecluster | metadatasynced | shouldhaveshards
-    --------+---------+------------+----------+----------+-------------+----------+----------+-------------+----------------+------------------
-          1 |       0 | 172.27.0.6 |     5432 | default  | t           | t        | primary  | default     | t              | f
-          2 |       1 | 172.27.0.2 |     5432 | default  | t           | t        | primary  | default     | t              | t
-          3 |       2 | 172.27.0.8 |     5432 | default  | t           | t        | primary  | default     | t              | t
-    (3 rows)
-
-    citus=# \q
-
-    postgres@haproxy:~$ patronictl list
-    + Citus cluster: demo ----------+--------------+---------+----+-----------+
-    | Group | Member  | Host        | Role         | State   | TL | Lag in MB |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-    |     0 | coord1  | 172.27.0.6  | Leader       | running |  1 |           |
-    |     0 | coord2  | 172.27.0.5  | Replica      | running |  1 |         0 |
-    |     0 | coord3  | 172.27.0.9  | Sync Standby | running |  1 |         0 |
-    |     1 | work1-1 | 172.27.0.2  | Leader       | running |  1 |           |
-    |     1 | work1-2 | 172.27.0.12 | Sync Standby | running |  1 |         0 |
-    |     2 | work2-1 | 172.27.0.11 | Sync Standby | running |  1 |         0 |
-    |     2 | work2-2 | 172.27.0.8  | Leader       | running |  1 |           |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-
-    postgres@haproxy:~$ patronictl switchover --group 2 --force
-    Current cluster topology
-    + Citus cluster: demo (group: 2, 7185185529556963355) +-----------+
-    | Member  | Host        | Role         | State   | TL | Lag in MB |
-    +---------+-------------+--------------+---------+----+-----------+
-    | work2-1 | 172.27.0.11 | Sync Standby | running |  1 |         0 |
-    | work2-2 | 172.27.0.8  | Leader       | running |  1 |           |
-    +---------+-------------+--------------+---------+----+-----------+
-    2023-01-05 15:29:29.54204 Successfully switched over to "work2-1"
-    + Citus cluster: demo (group: 2, 7185185529556963355) -------+
-    | Member  | Host        | Role    | State   | TL | Lag in MB |
-    +---------+-------------+---------+---------+----+-----------+
-    | work2-1 | 172.27.0.11 | Leader  | running |  1 |           |
-    | work2-2 | 172.27.0.8  | Replica | stopped |    |   unknown |
-    +---------+-------------+---------+---------+----+-----------+
-
-    postgres@haproxy:~$ patronictl list
-    + Citus cluster: demo ----------+--------------+---------+----+-----------+
-    | Group | Member  | Host        | Role         | State   | TL | Lag in MB |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-    |     0 | coord1  | 172.27.0.6  | Leader       | running |  1 |           |
-    |     0 | coord2  | 172.27.0.5  | Replica      | running |  1 |         0 |
-    |     0 | coord3  | 172.27.0.9  | Sync Standby | running |  1 |         0 |
-    |     1 | work1-1 | 172.27.0.2  | Leader       | running |  1 |           |
-    |     1 | work1-2 | 172.27.0.12 | Sync Standby | running |  1 |         0 |
-    |     2 | work2-1 | 172.27.0.11 | Leader       | running |  2 |           |
-    |     2 | work2-2 | 172.27.0.8  | Sync Standby | running |  2 |         0 |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-
-    postgres@haproxy:~$ psql -h localhost -p 5000 -U postgres -d citus
-    Password for user postgres: postgres
-    psql (15.1 (Debian 15.1-1.pgdg110+1))
-    SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA384, compression: off)
-    Type "help" for help.
-
-    citus=# table pg_dist_node;
-     nodeid | groupid |  nodename   | nodeport | noderack | hasmetadata | isactive | noderole | nodecluster | metadatasynced | shouldhaveshards
-    --------+---------+-------------+----------+----------+-------------+----------+----------+-------------+----------------+------------------
-          1 |       0 | 172.27.0.6  |     5432 | default  | t           | t        | primary  | default     | t              | f
-          3 |       2 | 172.27.0.11 |     5432 | default  | t           | t        | primary  | default     | t              | t
-          2 |       1 | 172.27.0.2  |     5432 | default  | t           | t        | primary  | default     | t              | t
-    (3 rows)

docker/entrypoint.sh

@@ -7,36 +7,29 @@ if [ -f /a.tar.xz ]; then
     sudo ln -snf dash /bin/sh
 fi
 
-readonly PATRONI_SCOPE="${PATRONI_SCOPE:-batman}"
-PATRONI_NAMESPACE="${PATRONI_NAMESPACE:-/service}"
-readonly PATRONI_NAMESPACE="${PATRONI_NAMESPACE%/}"
-DOCKER_IP=$(hostname --ip-address)
-readonly DOCKER_IP
+readonly PATRONI_SCOPE=${PATRONI_SCOPE:-batman}
+PATRONI_NAMESPACE=${PATRONI_NAMESPACE:-/service}
+readonly PATRONI_NAMESPACE=${PATRONI_NAMESPACE%/}
+readonly DOCKER_IP=$(hostname --ip-address)
 
 case "$1" in
     haproxy)
         haproxy -f /etc/haproxy/haproxy.cfg -p /var/run/haproxy.pid -D
-        set -- confd "-prefix=$PATRONI_NAMESPACE/$PATRONI_SCOPE" -interval=10 -backend
-        if [ -n "$PATRONI_ZOOKEEPER_HOSTS" ]; then
-            while ! /usr/share/zookeeper/bin/zkCli.sh -server "$PATRONI_ZOOKEEPER_HOSTS" ls /; do
+        CONFD="confd -prefix=$PATRONI_NAMESPACE/$PATRONI_SCOPE -interval=10 -backend"
+        if [ ! -z "$PATRONI_ZOOKEEPER_HOSTS" ]; then
+            while ! /usr/share/zookeeper/bin/zkCli.sh -server $PATRONI_ZOOKEEPER_HOSTS ls /; do
                 sleep 1
             done
-            set -- "$@" zookeeper -node "$PATRONI_ZOOKEEPER_HOSTS"
+            exec dumb-init $CONFD zookeeper -node $PATRONI_ZOOKEEPER_HOSTS
         else
-            while ! etcdctl member list 2> /dev/null; do
+            while ! etcdctl cluster-health 2> /dev/null; do
                 sleep 1
             done
-            set -- "$@" etcdv3
-            while IFS='' read -r line; do
-                set -- "$@" -node "$line"
-            done <<-EOT
-$(echo "$ETCDCTL_ENDPOINTS" | sed 's/,/\n/g')
-EOT
+            exec dumb-init $CONFD etcdv3 -node $(echo $ETCDCTL_ENDPOINTS | sed 's/,/ -node /g')
         fi
-        exec dumb-init "$@"
         ;;
     etcd)
-        exec "$@" -advertise-client-urls "http://$DOCKER_IP:2379"
+        exec "$@" -advertise-client-urls http://$DOCKER_IP:2379
         ;;
     zookeeper)
         exec /usr/share/zookeeper/bin/zkServer.sh start-foreground
@@ -63,13 +56,5 @@ export PATRONI_REPLICATION_USERNAME="${PATRONI_REPLICATION_USERNAME:-replicator}
 export PATRONI_REPLICATION_PASSWORD="${PATRONI_REPLICATION_PASSWORD:-replicate}"
 export PATRONI_SUPERUSER_USERNAME="${PATRONI_SUPERUSER_USERNAME:-postgres}"
 export PATRONI_SUPERUSER_PASSWORD="${PATRONI_SUPERUSER_PASSWORD:-postgres}"
-export PATRONI_REPLICATION_SSLMODE="${PATRONI_REPLICATION_SSLMODE:-$PGSSLMODE}"
-export PATRONI_REPLICATION_SSLKEY="${PATRONI_REPLICATION_SSLKEY:-$PGSSLKEY}"
-export PATRONI_REPLICATION_SSLCERT="${PATRONI_REPLICATION_SSLCERT:-$PGSSLCERT}"
-export PATRONI_REPLICATION_SSLROOTCERT="${PATRONI_REPLICATION_SSLROOTCERT:-$PGSSLROOTCERT}"
-export PATRONI_SUPERUSER_SSLMODE="${PATRONI_SUPERUSER_SSLMODE:-$PGSSLMODE}"
-export PATRONI_SUPERUSER_SSLKEY="${PATRONI_SUPERUSER_SSLKEY:-$PGSSLKEY}"
-export PATRONI_SUPERUSER_SSLCERT="${PATRONI_SUPERUSER_SSLCERT:-$PGSSLCERT}"
-export PATRONI_SUPERUSER_SSLROOTCERT="${PATRONI_SUPERUSER_SSLROOTCERT:-$PGSSLROOTCERT}"
 
 exec python3 /patroni.py postgres0.yml

docs/CONTRIBUTING.rst

@@ -1,12 +1,62 @@
 .. _contributing:
 
-Contributing
-============
+Contributing guidelines
+=======================
 
-Resources and information for developers can be found in the pages below.
+Wanna contribute to Patroni? Yay - here is how!
 
-.. toctree::
-   :maxdepth: 2
+Chatting
+--------
 
-   contributing_guidelines
-   Patroni API docs<modules/modules>
+Just want to chat with other Patroni users?  Looking for interactive troubleshooting help? Join us on channel #patroni in the `PostgreSQL Slack <https://postgres-slack.herokuapp.com/>`__.
+
+Running tests
+-------------
+
+Requirements for running behave tests:
+
+1. PostgreSQL packages need to be installed.
+2. PostgreSQL binaries must be available in your `PATH`. You may need to add them to the path with something like `PATH=/usr/lib/postgresql/11/bin:$PATH python -m behave`.
+3. If you'd like to test with external DCSs (e.g., Etcd, Consul, and Zookeeper) you'll need the packages installed and respective services running and accepting unencrypted/unprotected connections on localhost and default port. In the case of Etcd or Consul, the behave test suite could start them up if binaries are available in the `PATH`.
+
+ Install dependencies:
+
+.. code-block:: bash
+
+    # You may want to use Virtualenv or specify pip3.
+    pip install -r requirements.txt
+    pip install -r requirements.dev.txt
+
+After you have all dependencies installed, you can run the various test suites:
+
+.. code-block:: bash
+
+    # You may want to use Virtualenv or specify python3.
+
+    # Run flake8 to check syntax and formatting:
+    python setup.py flake8
+
+    # Run the pytest suite in tests/:
+    python setup.py test
+
+    # Run the behave (https://behave.readthedocs.io/en/latest/) test suite in features/;
+    # modify DCS as desired (raft has no dependencies so is the easiest to start with):
+    DCS=raft python -m behave
+
+Reporting issues
+----------------
+
+If you have a question about patroni or have a problem using it, please read the :ref:`README <readme>` before filing an issue.
+Also double check with the current issues on our `Issues Tracker <https://github.com/zalando/patroni/issues>`__.
+
+Contributing a pull request
+---------------------------
+
+1) Submit a comment to the relevant issue or create a new issue describing your proposed change.
+2) Do a fork, develop and test your code changes.
+3) Include documentation
+4) Submit a pull request.
+
+You'll get feedback about your pull request as soon as possible.
+
+Happy Patroni hacking ;-)

docs/ENVIRONMENT.rst

@@ -33,13 +33,6 @@ It is possible to create new database users right after the successful initializ
 
 Example: defining ``PATRONI_admin_PASSWORD=strongpasswd`` and ``PATRONI_admin_OPTIONS='createrole,createdb'`` will cause creation of the user **admin** with the password **strongpasswd** that is allowed to create other users and databases.
 
-Citus
------
-Enables integration Patroni with `Citus <https://docs.citusdata.com>`__. If configured, Patroni will take care of registering Citus worker nodes on the coordinator. You can find more information about Citus support :ref:`here <citus>`.
-
--  **PATRONI\_CITUS\_GROUP**: the Citus group id, integer. Use ``0`` for coordinator and ``1``, ``2``, etc... for workers
--  **PATRONI\_CITUS\_DATABASE**: the database where ``citus`` extension should be created. Must be the same on the coordinator and all workers. Currently only one database is supported.
-
 Consul
 ------
 -  **PATRONI\_CONSUL\_HOST**: the host:port for the Consul local agent.
@@ -54,8 +47,7 @@ Consul
 -  **PATRONI\_CONSUL\_DC**: (optional) Datacenter to communicate with. By default the datacenter of the host is used.
 -  **PATRONI\_CONSUL\_CONSISTENCY**: (optional) Select consul consistency mode. Possible values are ``default``, ``consistent``, or ``stale`` (more details in `consul API reference <https://www.consul.io/api/features/consistency.html/>`__)
 -  **PATRONI\_CONSUL\_CHECKS**: (optional) list of Consul health checks used for the session. By default an empty list is used.
--  **PATRONI\_CONSUL\_REGISTER\_SERVICE**: (optional) whether or not to register a service with the name defined by the scope parameter and the tag master, primary, replica, or standby-leader depending on the node's role. Defaults to **false**
--  **PATRONI\_CONSUL\_SERVICE\_TAGS**: (optional) additional static tags to add to the Consul service apart from the role (``master``/``primary``/``replica``/``standby-leader``). By default an empty list is used.
+-  **PATRONI\_CONSUL\_REGISTER\_SERVICE**: (optional) whether or not to register a service with the name defined by the scope parameter and the tag master, replica or standby-leader depending on the node's role. Defaults to **false**
 -  **PATRONI\_CONSUL\_SERVICE\_CHECK\_INTERVAL**: (optional) how often to perform health check against registered url
 -  **PATRONI\_CONSUL\_SERVICE\_CHECK\_TLS\_SERVER\_NAME**: (optional) overide SNI host when connecting via TLS, see also `consul agent check API reference <https://www.consul.io/api-docs/agent/check#tlsservername>`__.
 
@@ -112,19 +104,14 @@ Kubernetes
 -  **PATRONI\_KUBERNETES\_NAMESPACE**: (optional) Kubernetes namespace where the Patroni pod is running. Default value is `default`.
 -  **PATRONI\_KUBERNETES\_LABELS**: Labels in format ``{label1: value1, label2: value2}``. These labels will be used to find existing objects (Pods and either Endpoints or ConfigMaps) associated with the current cluster. Also Patroni will set them on every object (Endpoint or ConfigMap) it creates.
 -  **PATRONI\_KUBERNETES\_SCOPE\_LABEL**: (optional) name of the label containing cluster name. Default value is `cluster-name`.
--  **PATRONI\_KUBERNETES\_ROLE\_LABEL**: (optional) name of the label containing role (master or replica or other custom value). Patroni will set this label on the pod it runs in. Default value is ``role``.
--  **PATRONI\_KUBERNETES\_LEADER\_LABEL\_VALUE**: (optional) value of the pod label when Postgres role is `master`. Default value is `master`.
--  **PATRONI\_KUBERNETES\_FOLLOWER\_LABEL\_VALUE**: (optional) value of the pod label when Postgres role is `replica`. Default value is `replica`.
--  **PATRONI\_KUBERNETES\_STANDBY\_LEADER\_LABEL\_VALUE**: (optional) value of the pod label when Postgres role is ``standby-leader``. Default value is ``standby-leader``.
--  **PATRONI\_KUBERNETES\_TMP\_ROLE\_LABEL**: (optional) name of the temporary label containing role (master or replica). Value of this label will always use the default of corresponding role. Set only when necessary.
+-  **PATRONI\_KUBERNETES\_ROLE\_LABEL**: (optional) name of the label containing Postgres role (`master` or `replica`). Patroni will set this label on the pod it is running in. Default value is `role`.
 -  **PATRONI\_KUBERNETES\_USE\_ENDPOINTS**: (optional) if set to true, Patroni will use Endpoints instead of ConfigMaps to run leader elections and keep cluster state.
 -  **PATRONI\_KUBERNETES\_POD\_IP**: (optional) IP address of the pod Patroni is running in. This value is required when `PATRONI_KUBERNETES_USE_ENDPOINTS` is enabled and is used to populate the leader endpoint subsets when the pod's PostgreSQL is promoted.
 -  **PATRONI\_KUBERNETES\_PORTS**: (optional) if the Service object has the name for the port, the same name must appear in the Endpoint object, otherwise service won't work. For example, if your service is defined as ``{Kind: Service, spec: {ports: [{name: postgresql, port: 5432, targetPort: 5432}]}}``, then you have to set ``PATRONI_KUBERNETES_PORTS='[{"name": "postgresql", "port": 5432}]'`` and Patroni will use it for updating subsets of the leader Endpoint. This parameter is used only if `PATRONI_KUBERNETES_USE_ENDPOINTS` is set.
 -  **PATRONI\_KUBERNETES\_CACERT**: (optional) Specifies the file with the CA_BUNDLE file with certificates of trusted CAs to use while verifying Kubernetes API SSL certs. If not provided, patroni will use the value provided by the ServiceAccount secret.
--  **PATRONI\_RETRIABLE\_HTTP\_CODES**: (optional) list of HTTP status codes from K8s API to retry on. By default Patroni is retrying on ``500``, ``503``, and ``504``, or if K8s API response has ``retry-after`` HTTP header.
 
-Raft (deprecated)
------------------
+Raft
+----
 
 -  **PATRONI\_RAFT\_SELF\_ADDR**: ``ip:port`` to listen on for Raft connections. The ``self_addr`` must be accessible from other nodes of the cluster. If not set, the node will not participate in consensus.
 -  **PATRONI\_RAFT\_BIND\_ADDR**: (optional) ``ip:port`` to listen on for Raft connections. If not specified the ``self_addr`` will be used.
@@ -136,19 +123,11 @@ PostgreSQL
 ----------
 -  **PATRONI\_POSTGRESQL\_LISTEN**: IP address + port that Postgres listens to. Multiple comma-separated addresses are permitted, as long as the port component is appended after to the last one with a colon, i.e. ``listen: 127.0.0.1,127.0.0.2:5432``. Patroni will use the first address from this list to establish local connections to the PostgreSQL node.
 -  **PATRONI\_POSTGRESQL\_CONNECT\_ADDRESS**: IP address + port through which Postgres is accessible from other nodes and applications.
--  **PATRONI\_POSTGRESQL\_PROXY\_ADDRESS**: IP address + port through which a connection pool (e.g. pgbouncer) running next to Postgres is accessible. The value is written to the member key in DCS as ``proxy_url`` and could be used/useful for service discovery.
 -  **PATRONI\_POSTGRESQL\_DATA\_DIR**: The location of the Postgres data directory, either existing or to be initialized by Patroni.
 -  **PATRONI\_POSTGRESQL\_CONFIG\_DIR**: The location of the Postgres configuration directory, defaults to the data directory. Must be writable by Patroni.
--  **PATRONI\_POSTGRESQL\_BIN_DIR**: Path to PostgreSQL binaries. (pg_ctl, initdb, pg_controldata, pg_basebackup, postgres, pg_isready, pg_rewind) The  default value is an empty string meaning that PATH environment variable will be used to find the executables.
--  **PATRONI\_POSTGRESQL\_BIN\_PG\_CTL**: (optional) Custom name for ``pg_ctl`` binary.
--  **PATRONI\_POSTGRESQL\_BIN\_INITDB**: (optional) Custom name for ``initdb`` binary.
--  **PATRONI\_POSTGRESQL\_BIN\_PG\_CONTROLDATA**: (optional) Custom name for ``pg_controldata`` binary.
--  **PATRONI\_POSTGRESQL\_BIN\_PG\_BASEBACKUP**: (optional) Custom name for ``pg_basebackup`` binary.
--  **PATRONI\_POSTGRESQL\_BIN\_POSTGRES**: (optional) Custom name for ``postgres`` binary.
--  **PATRONI\_POSTGRESQL\_BIN\_IS\_READY**: (optional) Custom name for ``pg_isready`` binary.
--  **PATRONI\_POSTGRESQL\_BIN\_PG\_REWIND**: (optional) Custom name for ``pg_rewind`` binary.
+-  **PATRONI\_POSTGRESQL\_BIN_DIR**: Path to PostgreSQL binaries. (pg_ctl, pg_rewind, pg_basebackup, postgres) The  default value is an empty string meaning that PATH environment variable will be used to find the executables.
 -  **PATRONI\_POSTGRESQL\_PGPASS**: path to the `.pgpass <https://www.postgresql.org/docs/current/static/libpq-pgpass.html>`__ password file. Patroni creates this file before executing pg\_basebackup and under some other circumstances. The location must be writable by Patroni.
--  **PATRONI\_REPLICATION\_USERNAME**: replication username; the user will be created during initialization. Replicas will use this user to access the replication source via streaming replication
+-  **PATRONI\_REPLICATION\_USERNAME**: replication username; the user will be created during initialization. Replicas will use this user to access master via streaming replication
 -  **PATRONI\_REPLICATION\_PASSWORD**: replication password; the user will be created during initialization.
 -  **PATRONI\_REPLICATION\_SSLMODE**: (optional) maps to the `sslmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLMODE>`__ connection parameter, which allows a client to specify the type of TLS negotiation mode with the server. For more information on how each mode works, please visit the `PostgreSQL documentation <https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS>`__. The default mode is ``prefer``.
 -  **PATRONI\_REPLICATION\_SSLKEY**: (optional) maps to the `sslkey <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLKEY>`__ connection parameter, which specifies the location of the secret key used with the client's certificate.
@@ -170,8 +149,8 @@ PostgreSQL
 -  **PATRONI\_SUPERUSER\_SSLCRLDIR**: (optional) maps to the `sslcrldir <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRLDIR>`__ connection parameter, which specifies the location of a directory with files containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
 -  **PATRONI\_SUPERUSER\_GSSENCMODE**: (optional) maps to the `gssencmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-GSSENCMODE>`__ connection parameter, which determines whether or with what priority a secure GSS TCP/IP connection will be negotiated with the server
 -  **PATRONI\_SUPERUSER\_CHANNEL\_BINDING**: (optional) maps to the `channel_binding <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-CHANNEL-BINDING>`__ connection parameter, which controls the client's use of channel binding.
--  **PATRONI\_REWIND\_USERNAME**: (optional) name for the user for ``pg_rewind``; the user will be created during initialization of postgres 11+ and all necessary `permissions <https://www.postgresql.org/docs/11/app-pgrewind.html#id-1.9.5.8.8>`__ will be granted.
--  **PATRONI\_REWIND\_PASSWORD**: (optional) password for the user for ``pg_rewind``; the user will be created during initialization.
+-  **PATRONI\_REWIND\_USERNAME**: name for the user for ``pg_rewind``; the user will be created during initialization of postgres 11+ and all necessary `permissions <https://www.postgresql.org/docs/11/app-pgrewind.html#id-1.9.5.8.8>`__ will be granted.
+-  **PATRONI\_REWIND\_PASSWORD**: password for the user for ``pg_rewind``; the user will be created during initialization.
 -  **PATRONI\_REWIND\_SSLMODE**: (optional) maps to the `sslmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLMODE>`__ connection parameter, which allows a client to specify the type of TLS negotiation mode with the server. For more information on how each mode works, please visit the `PostgreSQL documentation <https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS>`__. The default mode is ``prefer``.
 -  **PATRONI\_REWIND\_SSLKEY**: (optional) maps to the `sslkey <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLKEY>`__ connection parameter, which specifies the location of the secret key used with the client's certificate.
 -  **PATRONI\_REWIND\_SSLPASSWORD**: (optional) maps to the `sslpassword <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLPASSWORD>`__ connection parameter, which specifies the password for the secret key specified in ``PATRONI_REWIND_SSLKEY``.
@@ -198,21 +177,11 @@ REST API
 -  **PATRONI\_RESTAPI\_ALLOWLIST\_INCLUDE\_MEMBERS**: (optional): If set to ``true`` it allows accessing unsafe REST API endpoints from other cluster members registered in DCS (IP address or hostname is taken from the members ``api_url``). Be careful, it might happen that OS will use a different IP for outgoing connections.
 -  **PATRONI\_RESTAPI\_HTTP\_EXTRA\_HEADERS**: (optional) HTTP headers let the REST API server pass additional information with an HTTP response.
 -  **PATRONI\_RESTAPI\_HTTPS\_EXTRA\_HEADERS**: (optional) HTTPS headers let the REST API server pass additional information with an HTTP response when TLS is enabled. This will also pass additional information set in ``http_extra_headers``.
--  **PATRONI\_RESTAPI\_REQUEST\_QUEUE\_SIZE**: (optional): Sets request queue size for TCP socket used by Patroni REST API.  Once the queue is full, further requests get a "Connection denied" error. The default value is 5.
-
-.. warning::
-
-    - The ``PATRONI_RESTAPI_CONNECT_ADDRESS`` must be accessible from all nodes of a given Patroni cluster. Internally Patroni is using it during the leader race to find nodes with minimal replication lag.
-    - If you enabled client certificates validation (``PATRONI_RESTAPI_VERIFY_CLIENT`` is set to ``required``), you also **must** provide **valid client certificates** in the ``PATRONI_CTL_CERTFILE``, ``PATRONI_CTL_KEYFILE``, ``PATRONI_CTL_KEYFILE_PASSWORD``. If not provided, Patroni will not work correctly.
-
 
 CTL
 ---
--  **PATRONICTL\_CONFIG\_FILE**: (optional) location of the configuration file.
--  **PATRONI\_CTL\_USERNAME**: (optional) Basic-auth username for accessing protected REST API endpoints. If not provided patronictl will use the value provided for REST API "username" parameter.
--  **PATRONI\_CTL\_PASSWORD**: (optional) Basic-auth password for accessing protected REST API endpoints. If not provided patronictl will use the value provided for REST API "password" parameter.
--  **PATRONI\_CTL\_INSECURE**: (optional) Allow connections to REST API without verifying SSL certs.
--  **PATRONI\_CTL\_CACERT**: (optional) Specifies the file with the CA_BUNDLE file or directory with certificates of trusted CAs to use while verifying REST API SSL certs. If not provided patronictl will use the value provided for REST API "cafile" parameter.
--  **PATRONI\_CTL\_CERTFILE**: (optional) Specifies the file with the client certificate in the PEM format.
--  **PATRONI\_CTL\_KEYFILE**: (optional) Specifies the file with the client secret key in the PEM format.
--  **PATRONI\_CTL\_KEYFILE\_PASSWORD**: (optional) Specifies a password for decrypting the client keyfile.
+-  **PATRONICTL\_CONFIG\_FILE**: location of the configuration file.
+-  **PATRONI\_CTL\_INSECURE**: Allow connections to REST API without verifying SSL certs.
+-  **PATRONI\_CTL\_CACERT**: Specifies the file with the CA_BUNDLE file or directory with certificates of trusted CAs to use while verifying REST API SSL certs. If not provided patronictl will use the value provided for REST API "cafile" parameter.
+-  **PATRONI\_CTL\_CERTFILE**: Specifies the file with the client certificate in the PEM format. If not provided patronictl will use the value provided for REST API "certfile" parameter.
+-  **PATRONI\_CTL\_KEYFILE**: Specifies the file with the client secret key in the PEM format. If not provided patronictl will use the value provided for REST API "keyfile" parameter.

docs/README.rst

@@ -4,7 +4,7 @@
 Introduction
 ============
 
-Patroni is a template for high availability (HA) PostgreSQL solutions using Python. Patroni originated as a fork of `Governor <https://github.com/compose/governor>`__, the project from Compose. It includes plenty of new features.
+Patroni originated as a fork of `Governor <https://github.com/compose/governor>`__, the project from Compose. It includes plenty of new features.
 
 For an example of a Docker-based deployment with Patroni, see `Spilo <https://github.com/zalando/spilo>`__, currently in use at Zalando.
 
@@ -46,8 +46,9 @@ There are a few options available:
 
 ::
 
-    sudo apt-get install python3-psycopg2  # install psycopg2 module on Debian/Ubuntu
-    sudo yum install python3-psycopg2      # install psycopg2 on RedHat/Fedora/CentOS
+    sudo apt-get install python-psycopg2   # install python2 psycopg2 module on Debian/Ubuntu
+    sudo apt-get install python3-psycopg2  # install python3 psycopg2 module on Debian/Ubuntu
+    sudo yum install python-psycopg2       # install python2 psycopg2 on RedHat/Fedora/CentOS
 
 2. Install psycopg2 from the binary package
 
@@ -90,7 +91,7 @@ kubernetes
 raft
     `pysyncobj` module in order to use python Raft implementation as DCS
 aws
-    `boto3` in order to use AWS callbacks
+    `boto` in order to use AWS callbacks
 
 For example, the command in order to install Patroni together with dependencies for Etcd as a DCS and AWS callbacks is:
 
@@ -108,7 +109,7 @@ Planning the Number of PostgreSQL Nodes
 ---------------------------------------
 
 Patroni/PostgreSQL nodes are decoupled from DCS nodes (except when Patroni implements RAFT on its own) and therefore
-there is no requirement on the minimal number of nodes. Running a cluster consisting of one primary and one standby is
+there is no requirement on the minimal number of nodes. Running a cluster consisting of one master and one standby is 
 perfectly fine. You can add more standby nodes later.
 
 Running and Configuring
@@ -144,7 +145,7 @@ run:
 YAML Configuration
 ------------------
 
-Go :ref:`here <yaml_configuration>` for comprehensive information about settings for etcd, consul, and ZooKeeper. And for an example, see `postgres0.yml <https://github.com/zalando/patroni/blob/master/postgres0.yml>`__.
+Go :ref:`here <settings>` for comprehensive information about settings for etcd, consul, and ZooKeeper. And for an example, see `postgres0.yml <https://github.com/zalando/patroni/blob/master/postgres0.yml>`__.
 
 
 Environment Configuration
@@ -164,6 +165,10 @@ Applications Should Not Use Superusers
 
 When connecting from an application, always use a non-superuser. Patroni requires access to the database to function properly. By using a superuser from an application, you can potentially use the entire connection pool, including the connections reserved for superusers, with the ``superuser_reserved_connections`` setting. If Patroni cannot access the Primary because the connection pool is full, behavior will be undesirable.
 
+.. |Build Status| image:: https://travis-ci.org/zalando/patroni.svg?branch=master
+   :target: https://travis-ci.org/zalando/patroni
+.. |Coverage Status| image:: https://coveralls.io/repos/zalando/patroni/badge.svg?branch=master
+   :target: https://coveralls.io/r/zalando/patroni?branch=master
 
 Testing Your HA Solution
 --------------------------------------
@@ -172,9 +177,9 @@ Testing an HA solution is a time consuming process, with many variables. This is
 That said, here are some pieces of your infrastructure you should be sure to test:
 
 * Network (the network in front of your system as well as the NICs [physical or virtual] themselves)
-* Disk IO
+* Disk IO 
 * file limits (nofile in Linux)
-* RAM. Even if you have oomkiller turned off, the unavailability of RAM could cause issues.
+* RAM. Even if you have oomkiller turned off as suggested, the unavailability of RAM could cause issues.
 * CPU
 * Virtualization Contention (overcommitting the hypervisor)
 * Any cgroup limitation (likely to be related to the above)

docs/SETTINGS.rst

@@ -0,0 +1,396 @@
+.. _settings:
+
+===========================
+YAML Configuration Settings
+===========================
+
+.. _dynamic_configuration_settings:
+
+Dynamic configuration settings
+------------------------------
+
+Dynamic configuration is stored in the DCS (Distributed Configuration Store) and applied on all cluster nodes. Some parameters, like **loop_wait**, **ttl**, **postgresql.parameters.max_connections**, **postgresql.parameters.max_worker_processes** and so on could be set only in the dynamic configuration. Some other parameters like **postgresql.listen**, **postgresql.data_dir** could be set only locally, i.e. in the Patroni config file or via :ref:`configuration <environment>` variable. In most cases the local configuration will override the dynamic configuration. In order to change the dynamic configuration you can use either ``patronictl edit-config`` tool or Patroni :ref:`REST API <rest_api>`.
+
+-  **loop\_wait**: the number of seconds the loop will sleep. Default value: 10
+-  **ttl**: the TTL to acquire the leader lock (in seconds). Think of it as the length of time before initiation of the automatic failover process. Default value: 30
+-  **retry\_timeout**: timeout for DCS and PostgreSQL operation retries (in seconds). DCS or network issues shorter than this will not cause Patroni to demote the leader. Default value: 10
+-  **maximum\_lag\_on\_failover**: the maximum bytes a follower may lag to be able to participate in leader election.
+-  **maximum\_lag\_on\_syncnode**: the maximum bytes a synchronous follower may lag before it is considered as an unhealthy candidate and swapped by healthy asynchronous follower. Patroni utilize the max replica lsn if there is more than one follower, otherwise it will use leader's current wal lsn. Default is -1, Patroni will not take action to swap synchronous unhealthy follower when the value is set to 0 or below. Please set the value high enough so Patroni won't swap synchrounous follower fequently during high transaction volume.
+-  **max\_timelines\_history**: maximum number of timeline history items kept in DCS.  Default value: 0. When set to 0, it keeps the full history in DCS.
+-  **master\_start\_timeout**: the amount of time a master is allowed to recover from failures before failover is triggered (in seconds). Default is 300 seconds. When set to 0 failover is done immediately after a crash is detected if possible. When using asynchronous replication a failover can cause lost transactions. Worst case failover time for master failure is: loop\_wait + master\_start\_timeout + loop\_wait, unless master\_start\_timeout is zero, in which case it's just loop\_wait. Set the value according to your durability/availability tradeoff.
+- **master\_stop\_timeout**: The number of seconds Patroni is allowed to wait when stopping Postgres and effective only when synchronous_mode is enabled. When set to > 0 and the synchronous_mode is enabled, Patroni sends SIGKILL to the postmaster if the stop operation is running for more than the value set by master_stop_timeout. Set the value according to your durability/availability tradeoff. If the parameter is not set or set <= 0, master_stop_timeout does not apply.
+-  **synchronous\_mode**: turns on synchronous replication mode. In this mode a replica will be chosen as synchronous and only the latest leader and synchronous replica are able to participate in leader election. Synchronous mode makes sure that successfully committed transactions will not be lost at failover, at the cost of losing availability for writes when Patroni cannot ensure transaction durability. See :ref:`replication modes documentation <replication_modes>` for details.
+-  **synchronous\_mode\_strict**: prevents disabling synchronous replication if no synchronous replicas are available, blocking all client writes to the master. See :ref:`replication modes documentation <replication_modes>` for details.
+-  **postgresql**:
+    -  **use\_pg\_rewind**: whether or not to use pg_rewind. Defaults to `false`.
+    -  **use\_slots**: whether or not to use replication slots. Defaults to `true` on PostgreSQL 9.4+.
+    -  **recovery\_conf**: additional configuration settings written to recovery.conf when configuring follower. There is no recovery.conf anymore in PostgreSQL 12, but you may continue using this section, because Patroni handles it transparently.
+    -  **parameters**: list of configuration settings for Postgres.
+-  **standby\_cluster**: if this section is defined, we want to bootstrap a standby cluster.
+    -  **host**: an address of remote master
+    -  **port**: a port of remote master
+    -  **primary\_slot\_name**: which slot on the remote master to use for replication. This parameter is optional, the default value is derived from the instance name (see function `slot_name_from_member_name`).
+    -  **create\_replica\_methods**: an ordered list of methods that can be used to bootstrap standby leader from the remote master, can be different from the list defined in :ref:`postgresql_settings`
+    -  **restore\_command**: command to restore WAL records from the remote master to standby leader, can be different from the list defined in :ref:`postgresql_settings`
+    -  **archive\_cleanup\_command**: cleanup command for standby leader
+    -  **recovery\_min\_apply\_delay**: how long to wait before actually apply WAL records on a standby leader
+-  **slots**: define permanent replication slots. These slots will be preserved during switchover/failover. The logical slots are copied from the primary to a standby with restart, and after that their position advanced every **loop_wait** seconds (if necessary). Copying logical slot files performed via ``libpq`` connection and using either rewind or superuser credentials (see **postgresql.authentication** section). There is always a chance that the logical slot position on the replica is a bit behind the former primary, therefore application should be prepared that some messages could be received the second time after the failover. The easiest way of doing so - tracking ``confirmed_flush_lsn``. Enabling permanent logical replication slots requires **postgresql.use_slots** to be set and will also automatically enable the ``hot_standby_feedback``. Since the failover of logical replication slots is unsafe on PostgreSQL 9.6 and older and PostgreSQL version 10 is missing some important functions, the feature only works with PostgreSQL 11+.
+    -  **my_slot_name**: the name of replication slot. If the permanent slot name matches with the name of the current primary it will not be created. Everything else is the responsibility of the operator to make sure that there are no clashes in names between replication slots automatically created by Patroni for members and permanent replication slots.
+        -  **type**: slot type. Could be ``physical`` or ``logical``. If the slot is logical, you have to additionally define ``database`` and ``plugin``.
+        -  **database**: the database name where logical slots should be created.
+        -  **plugin**: the plugin name for the logical slot.
+-  **ignore_slots**: list of sets of replication slot properties for which Patroni should ignore matching slots. This configuration/feature/etc. is useful when some replication slots are managed outside of Patroni. Any subset of matching properties will cause a slot to be ignored.
+    -  **name**: the name of the replication slot.
+    -  **type**: slot type. Can be ``physical`` or ``logical``. If the slot is logical, you may additionally define ``database`` and/or ``plugin``.
+    -  **database**: the database name (when matching a ``logical`` slot).
+    -  **plugin**: the logical decoding plugin (when matching a ``logical`` slot).
+
+Note: **slots** is a hashmap while **ignore_slots** is an array. For example:
+
+.. code:: YAML
+
+        slots:
+          permanent_logical_slot_name:
+            type: logical
+            database: my_db
+            plugin: test_decoding
+          permanent_physical_slot_name:
+            type: physical
+          ...
+        ignore_slots:
+          - name: ignored_logical_slot_name
+            type: logical
+            database: my_db
+            plugin: test_decoding
+          - name: ignored_physical_slot_name
+            type: physical
+          ...
+
+Global/Universal
+----------------
+-  **name**: the name of the host. Must be unique for the cluster.
+-  **namespace**: path within the configuration store where Patroni will keep information about the cluster. Default value: "/service"
+-  **scope**: cluster name
+
+Log
+---
+-  **level**: sets the general logging level. Default value is **INFO** (see `the docs for Python logging <https://docs.python.org/3.6/library/logging.html#levels>`_)
+-  **traceback\_level**: sets the level where tracebacks will be visible. Default value is **ERROR**. Set it to **DEBUG** if you want to see tracebacks only if you enable **log.level=DEBUG**.
+-  **format**: sets the log formatting string. Default value is **%(asctime)s %(levelname)s: %(message)s** (see `the LogRecord attributes <https://docs.python.org/3.6/library/logging.html#logrecord-attributes>`_)
+-  **dateformat**: sets the datetime formatting string. (see the `formatTime() documentation <https://docs.python.org/3.6/library/logging.html#logging.Formatter.formatTime>`_)
+-  **max\_queue\_size**: Patroni is using two-step logging. Log records are written into the in-memory queue and there is a separate thread which pulls them from the queue and writes to stderr or file. The maximum size of the internal queue is limited by default by **1000** records, which is enough to keep logs for the past 1h20m.
+-  **dir**: Directory to write application logs to. The directory must exist and be writable by the user executing Patroni. If you set this value, the application will retain 4 25MB logs by default. You can tune those retention values with `file_num` and `file_size` (see below).
+-  **file\_num**: The number of application logs to retain.
+-  **file\_size**: Size of patroni.log file (in bytes) that triggers a log rolling.
+-  **loggers**: This section allows redefining logging level per python module
+    -  **patroni.postmaster: WARNING**
+    -  **urllib3: DEBUG**
+
+.. _bootstrap_settings:
+
+Bootstrap configuration
+-----------------------
+-  **bootstrap**:
+    -  **dcs**: This section will be written into `/<namespace>/<scope>/config` of the given configuration store after initializing of new cluster. The global dynamic configuration for the cluster. Under the ``bootstrap.dcs`` you can put any of the parameters described in the :ref:`Dynamic Configuration settings <dynamic_configuration_settings>` and after Patroni initialized (bootstrapped) the new cluster, it will write this section into `/<namespace>/<scope>/config` of the configuration store. All later changes of ``bootstrap.dcs`` will not take any effect! If you want to change them please use either ``patronictl edit-config`` or Patroni :ref:`REST API <rest_api>`.
+    -  **method**: custom script to use for bootstrapping this cluster.
+       See :ref:`custom bootstrap methods documentation <custom_bootstrap>` for details.
+       When ``initdb`` is specified revert to the default ``initdb`` command. ``initdb`` is also triggered when no ``method``
+       parameter is present in the configuration file.
+    -  **initdb**: List options to be passed on to initdb.
+            -  **- data-checksums**: Must be enabled when pg_rewind is needed on 9.3.
+            -  **- encoding: UTF8**: default encoding for new databases.
+            -  **- locale: UTF8**: default locale for new databases.
+    -  **pg\_hba**: list of lines that you should add to pg\_hba.conf.
+            -  **- host all all 0.0.0.0/0 md5**.
+            -  **- host replication replicator 127.0.0.1/32 md5**: A line like this is required for replication.
+    -  **users**: Some additional users which need to be created after initializing new cluster
+        -  **admin**: the name of user
+            -  **password: zalando**:
+            -  **options**: list of options for CREATE USER statement
+                -  **- createrole**
+                -  **- createdb**
+    -  **post\_bootstrap** or **post\_init**: An additional script that will be executed after initializing the cluster. The script receives a connection string URL (with the cluster superuser as a user name). The PGPASSFILE variable is set to the location of pgpass file.
+
+.. _consul_settings:
+
+Consul
+------
+Most of the parameters are optional, but you have to specify one of the **host** or **url**
+
+-  **host**: the host:port for the Consul local agent.
+-  **url**: url for the Consul local agent, in format: http(s)://host:port.
+-  **port**: (optional) Consul port.
+-  **scheme**: (optional) **http** or **https**, defaults to **http**.
+-  **token**: (optional) ACL token.
+-  **verify**: (optional) whether to verify the SSL certificate for HTTPS requests.
+-  **cacert**: (optional) The ca certificate. If present it will enable validation.
+-  **cert**: (optional) file with the client certificate.
+-  **key**: (optional) file with the client key. Can be empty if the key is part of **cert**.
+-  **dc**: (optional) Datacenter to communicate with. By default the datacenter of the host is used.
+-  **consistency**: (optional) Select consul consistency mode. Possible values are ``default``, ``consistent``, or ``stale`` (more details in `consul API reference <https://www.consul.io/api/features/consistency.html/>`__)
+-  **checks**: (optional) list of Consul health checks used for the session. By default an empty list is used.
+-  **register\_service**: (optional) whether or not to register a service with the name defined by the scope parameter and the tag master, replica or standby-leader depending on the node's role. Defaults to **false**.
+-  **service\_tags**: (optional) additional static tags to add to the Consul service apart from the role (``master``/``replica``/``standby-leader``).  By default an empty list is used.
+-  **service\_check\_interval**: (optional) how often to perform health check against registered url.
+-  **service\_check\_tls\_server\_name**: (optional) overide SNI host when connecting via TLS, see also `consul agent check API reference <https://www.consul.io/api-docs/agent/check#tlsservername>`__.
+
+The ``token`` needs to have the following ACL permissions:
+
+::
+
+    service_prefix "${scope}" {
+        policy = "write"
+    }
+    key_prefix "${namespace}/${scope}" {
+        policy = "write"
+    }
+    session_prefix "" {
+        policy = "write"
+    }
+
+Etcd
+----
+Most of the parameters are optional, but you have to specify one of the **host**, **hosts**, **url**, **proxy** or **srv**
+
+-  **host**: the host:port for the etcd endpoint.
+-  **hosts**: list of etcd endpoint in format host1:port1,host2:port2,etc... Could be a comma separated string or an actual yaml list.
+-  **use\_proxies**: If this parameter is set to true, Patroni will consider **hosts** as a list of proxies and will not perform a topology discovery of etcd cluster.
+-  **url**: url for the etcd.
+-  **proxy**: proxy url for the etcd. If you are connecting to the etcd using proxy, use this parameter instead of **url**.
+-  **srv**: Domain to search the SRV record(s) for cluster autodiscovery. Patroni will try to query these SRV service names for specified domain (in that order until first success): ``_etcd-client-ssl``, ``_etcd-client``, ``_etcd-ssl``, ``_etcd``, ``_etcd-server-ssl``, ``_etcd-server``. If SRV records for ``_etcd-server-ssl`` or ``_etcd-server`` are retrieved then ETCD peer protocol is used do query ETCD for available members. Otherwise hosts from SRV records will be used.
+-  **srv\_suffix**: Configures a suffix to the SRV name that is queried during discovery. Use this flag to differentiate between multiple etcd clusters under the same domain. Works only with conjunction with **srv**. For example, if ``srv_suffix: foo`` and ``srv: example.org`` are set, the following DNS SRV query is made:``_etcd-client-ssl-foo._tcp.example.com`` (and so on for every possible ETCD SRV service name).
+-  **protocol**: (optional) http or https, if not specified http is used. If the **url** or **proxy** is specified - will take protocol from them.
+-  **username**: (optional) username for etcd authentication.
+-  **password**: (optional) password for etcd authentication.
+-  **cacert**: (optional) The ca certificate. If present it will enable validation.
+-  **cert**: (optional) file with the client certificate.
+-  **key**: (optional) file with the client key. Can be empty if the key is part of **cert**.
+
+Etcdv3
+------
+If you want that Patroni works with Etcd cluster via protocol version 3, you need to use the ``etcd3`` section in the Patroni configuration file. All configuration parameters are the same as for ``etcd``.
+
+.. warning::
+    Keys created with protocol version 2 are not visible with protocol version 3 and the other way around, therefore it is not possible to switch from ``etcd`` to ``etcd3`` just by updating Patroni config file.
+
+
+ZooKeeper
+----------
+-  **hosts**: List of ZooKeeper cluster members in format: ['host1:port1', 'host2:port2', 'etc...'].
+-  **use_ssl**: (optional) Whether SSL is used or not. Defaults to ``false``. If set to ``false``, all SSL specific parameters are ignored.
+-  **cacert**: (optional) The CA certificate. If present it will enable validation.
+-  **cert**: (optional) File with the client certificate.
+-  **key**: (optional) File with the client key.
+-  **key_password**: (optional) The client key password.
+-  **verify**: (optional) Whether to verify certificate or not. Defaults to ``true``.
+-  **set_acls**: (optional) If set, configure Kazoo to apply a default ACL to each ZNode that it creates. ACLs will assume 'x509' schema and should be specified as a dictionary with the principal as the key and one or more permissions as a list in the value.  Permissions may be one of ``CREATE``, ``READ``, ``WRITE``, ``DELETE`` or ``ADMIN``.  For example, ``set_acls: {CN=principal1: [CREATE, READ], CN=principal2: [ALL]}``. 
+
+.. note::
+    It is required to install ``kazoo>=2.6.0`` to support SSL.
+
+
+Exhibitor
+---------
+-  **hosts**: initial list of Exhibitor (ZooKeeper) nodes in format: 'host1,host2,etc...'. This list updates automatically whenever the Exhibitor (ZooKeeper) cluster topology changes.
+-  **poll\_interval**: how often the list of ZooKeeper and Exhibitor nodes should be updated from Exhibitor.
+-  **port**: Exhibitor port.
+
+.. _kubernetes_settings:
+
+Kubernetes
+----------
+-  **bypass\_api\_service**: (optional) When communicating with the Kubernetes API, Patroni is usually relying on the `kubernetes` service, the address of which is exposed in the pods via the `KUBERNETES_SERVICE_HOST` environment variable. If `bypass_api_service` is set to ``true``, Patroni will resolve the list of API nodes behind the service and connect directly to them.
+-  **namespace**: (optional) Kubernetes namespace where Patroni pod is running. Default value is `default`.
+-  **labels**: Labels in format ``{label1: value1, label2: value2}``. These labels will be used to find existing objects (Pods and either Endpoints or ConfigMaps) associated with the current cluster. Also Patroni will set them on every object (Endpoint or ConfigMap) it creates.
+-  **scope\_label**: (optional) name of the label containing cluster name. Default value is `cluster-name`.
+-  **role\_label**: (optional) name of the label containing role (master or replica). Patroni will set this label on the pod it runs in. Default value is ``role``.
+-  **use\_endpoints**: (optional) if set to true, Patroni will use Endpoints instead of ConfigMaps to run leader elections and keep cluster state.
+-  **pod\_ip**: (optional) IP address of the pod Patroni is running in. This value is required when `use_endpoints` is enabled and is used to populate the leader endpoint subsets when the pod's PostgreSQL is promoted.
+-  **ports**: (optional) if the Service object has the name for the port, the same name must appear in the Endpoint object, otherwise service won't work. For example, if your service is defined as ``{Kind: Service, spec: {ports: [{name: postgresql, port: 5432, targetPort: 5432}]}}``, then you have to set ``kubernetes.ports: [{"name": "postgresql", "port": 5432}]`` and Patroni will use it for updating subsets of the leader Endpoint. This parameter is used only if `kubernetes.use_endpoints` is set.
+-  **cacert**: (optional) Specifies the file with the CA_BUNDLE file with certificates of trusted CAs to use while verifying Kubernetes API SSL certs. If not provided, patroni will use the value provided by the ServiceAccount secret.
+
+
+.. _raft_settings:
+
+Raft
+----
+-  **self\_addr**: ``ip:port`` to listen on for Raft connections. The ``self_addr`` must be accessible from other nodes of the cluster. If not set, the node will not participate in consensus.
+-  **bind\_addr**: (optional) ``ip:port`` to listen on for Raft connections. If not specified the ``self_addr`` will be used.
+-  **partner\_addrs**: list of other Patroni nodes in the cluster in format: ['ip1:port', 'ip2:port', 'etc...']
+-  **data\_dir**: directory where to store Raft log and snapshot. If not specified the current working directory is used.
+-  **password**: (optional) Encrypt Raft traffic with a specified password, requires ``cryptography`` python module.
+
+  Short FAQ about Raft implementation
+
+  - Q: How to list all the nodes providing consensus?
+
+    A: ``syncobj_admin -conn host:port -status`` where the host:port is the address of one of the cluster nodes
+
+  - Q: Node that was a part of consensus and has gone and I can't reuse the same IP for other node. How to remove this node from the consensus?
+
+    A: ``syncobj_admin -conn host:port -remove host2:port2`` where the ``host2:port2`` is the address of the node you want to remove from consensus.
+
+  - Q: Where to get the ``syncobj_admin`` utility?
+
+    A: It is installed together with ``pysyncobj`` module (python RAFT implementation), which is Patroni dependency.
+
+  - Q: it is possible to run Patroni node without adding in to the consensus?
+
+    A: Yes, just comment out or remove ``raft.self_addr`` from Patroni configuration.
+
+  - Q: It is possible to run Patroni and PostgreSQL only on two nodes?
+
+    A: Yes, on the third node you can run ``patroni_raft_controller`` (without Patroni and PostgreSQL). In such a setup, one can temporarily lose one node without affecting the primary.
+
+
+.. _postgresql_settings:
+
+PostgreSQL
+----------
+-  **postgresql**:
+    -  **authentication**:
+        -  **superuser**:
+            -  **username**: name for the superuser, set during initialization (initdb) and later used by Patroni to connect to the postgres.
+            -  **password**: password for the superuser, set during initialization (initdb).
+            -  **sslmode**: (optional) maps to the `sslmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLMODE>`__ connection parameter, which allows a client to specify the type of TLS negotiation mode with the server. For more information on how each mode works, please visit the `PostgreSQL documentation <https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS>`__. The default mode is ``prefer``.
+            -  **sslkey**: (optional) maps to the `sslkey <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLKEY>`__ connection parameter, which specifies the location of the secret key used with the client's certificate.
+            -  **sslpassword**: (optional) maps to the `sslpassword <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLPASSWORD>`__ connection parameter, which specifies the password for the secret key specified in ``sslkey``.
+            -  **sslcert**: (optional) maps to the `sslcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCERT>`__ connection parameter, which specifies the location of the client certificate.
+            -  **sslrootcert**: (optional) maps to the `sslrootcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLROOTCERT>`__ connection parameter, which specifies the location of a file containing one ore more certificate authorities (CA) certificates that the client will use to verify a server's certificate.
+            -  **sslcrl**: (optional) maps to the `sslcrl <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRL>`__ connection parameter, which specifies the location of a file containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
+            -  **sslcrldir**: (optional) maps to the `sslcrldir <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRLDIR>`__ connection parameter, which specifies the location of a directory with files containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
+            -  **gssencmode**: (optional) maps to the `gssencmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-GSSENCMODE>`__ connection parameter, which determines whether or with what priority a secure GSS TCP/IP connection will be negotiated with the server
+            -  **channel_binding**: (optional) maps to the `channel_binding <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-CHANNEL-BINDING>`__ connection parameter, which controls the client's use of channel binding.
+        -  **replication**:
+            -  **username**: replication username; the user will be created during initialization. Replicas will use this user to access master via streaming replication
+            -  **password**: replication password; the user will be created during initialization.
+            -  **sslmode**: (optional) maps to the `sslmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLMODE>`__ connection parameter, which allows a client to specify the type of TLS negotiation mode with the server. For more information on how each mode works, please visit the `PostgreSQL documentation <https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS>`__. The default mode is ``prefer``.
+            -  **sslkey**: (optional) maps to the `sslkey <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLKEY>`__ connection parameter, which specifies the location of the secret key used with the client's certificate.
+            -  **sslpassword**: (optional) maps to the `sslpassword <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLPASSWORD>`__ connection parameter, which specifies the password for the secret key specified in ``sslkey``.
+            -  **sslcert**: (optional) maps to the `sslcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCERT>`__ connection parameter, which specifies the location of the client certificate.
+            -  **sslrootcert**: (optional) maps to the `sslrootcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLROOTCERT>`__ connection parameter, which specifies the location of a file containing one ore more certificate authorities (CA) certificates that the client will use to verify a server's certificate.
+            -  **sslcrl**: (optional) maps to the `sslcrl <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRL>`__ connection parameter, which specifies the location of a file containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
+            -  **sslcrldir**: (optional) maps to the `sslcrldir <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRLDIR>`__ connection parameter, which specifies the location of a directory with files containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
+            -  **gssencmode**: (optional) maps to the `gssencmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-GSSENCMODE>`__ connection parameter, which determines whether or with what priority a secure GSS TCP/IP connection will be negotiated with the server
+            -  **channel_binding**: (optional) maps to the `channel_binding <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-CHANNEL-BINDING>`__ connection parameter, which controls the client's use of channel binding.
+        -  **rewind**:
+            -  **username**: name for the user for ``pg_rewind``; the user will be created during initialization of postgres 11+ and all necessary `permissions <https://www.postgresql.org/docs/11/app-pgrewind.html#id-1.9.5.8.8>`__ will be granted.
+            -  **password**: password for the user for ``pg_rewind``; the user will be created during initialization.
+            -  **sslmode**: (optional) maps to the `sslmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLMODE>`__ connection parameter, which allows a client to specify the type of TLS negotiation mode with the server. For more information on how each mode works, please visit the `PostgreSQL documentation <https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS>`__. The default mode is ``prefer``.
+            -  **sslkey**: (optional) maps to the `sslkey <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLKEY>`__ connection parameter, which specifies the location of the secret key used with the client's certificate.
+            -  **sslpassword**: (optional) maps to the `sslpassword <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLPASSWORD>`__ connection parameter, which specifies the password for the secret key specified in ``sslkey``.
+            -  **sslcert**: (optional) maps to the `sslcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCERT>`__ connection parameter, which specifies the location of the client certificate.
+            -  **sslrootcert**: (optional) maps to the `sslrootcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLROOTCERT>`__ connection parameter, which specifies the location of a file containing one ore more certificate authorities (CA) certificates that the client will use to verify a server's certificate.
+            -  **sslcrl**: (optional) maps to the `sslcrl <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRL>`__ connection parameter, which specifies the location of a file containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
+            -  **sslcrldir**: (optional) maps to the `sslcrldir <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRLDIR>`__ connection parameter, which specifies the location of a directory with files containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
+            -  **gssencmode**: (optional) maps to the `gssencmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-GSSENCMODE>`__ connection parameter, which determines whether or with what priority a secure GSS TCP/IP connection will be negotiated with the server
+            -  **channel_binding**: (optional) maps to the `channel_binding <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-CHANNEL-BINDING>`__ connection parameter, which controls the client's use of channel binding.
+    -  **callbacks**: callback scripts to run on certain actions. Patroni will pass the action, role and cluster name. (See scripts/aws.py as an example of how to write them.)
+            -  **on\_reload**: run this script when configuration reload is triggered.
+            -  **on\_restart**: run this script when the postgres restarts (without changing role).
+            -  **on\_role\_change**: run this script when the postgres is being promoted or demoted.
+            -  **on\_start**: run this script when the postgres starts.
+            -  **on\_stop**: run this script when the postgres stops.
+    -  **connect\_address**: IP address + port through which Postgres is accessible from other nodes and applications.
+    -  **create\_replica\_methods**: an ordered list of the create methods for turning a Patroni node into a new replica.
+       "basebackup" is the default method; other methods are assumed to refer to scripts, each of which is configured as its
+       own config item. See :ref:`custom replica creation methods documentation <custom_replica_creation>` for further explanation.
+    -  **data\_dir**: The location of the Postgres data directory, either :ref:`existing <existing_data>` or to be initialized by Patroni.
+    -  **config\_dir**: The location of the Postgres configuration directory, defaults to the data directory. Must be writable by Patroni.
+    -  **bin\_dir**: Path to PostgreSQL binaries (pg_ctl, pg_rewind, pg_basebackup, postgres). The default value is an empty string meaning that PATH environment variable will be used to find the executables.
+    -  **listen**: IP address + port that Postgres listens to; must be accessible from other nodes in the cluster, if you're using streaming replication. Multiple comma-separated addresses are permitted, as long as the port component is appended after to the last one with a colon, i.e. ``listen: 127.0.0.1,127.0.0.2:5432``. Patroni will use the first address from this list to establish local connections to the PostgreSQL node.
+    -  **use\_unix\_socket**: specifies that Patroni should prefer to use unix sockets to connect to the cluster. Default value is ``false``. If ``unix_socket_directories`` is defined, Patroni will use the first suitable value from it to connect to the cluster and fallback to tcp if nothing is suitable. If ``unix_socket_directories`` is not specified in ``postgresql.parameters``, Patroni will assume that the default value should be used and omit ``host`` from the connection parameters.
+    -  **use\_unix\_socket\_repl**: specifies that Patroni should prefer to use unix sockets for replication user cluster connection. Default value is ``false``. If ``unix_socket_directories`` is defined, Patroni will use the first suitable value from it to connect to the cluster and fallback to tcp if nothing is suitable. If ``unix_socket_directories`` is not specified in ``postgresql.parameters``, Patroni will assume that the default value should be used and omit ``host`` from the connection parameters.
+    -  **pgpass**: path to the `.pgpass <https://www.postgresql.org/docs/current/static/libpq-pgpass.html>`__ password file. Patroni creates this file before executing pg\_basebackup, the post_init script and under some other circumstances. The location must be writable by Patroni.
+    -  **recovery\_conf**: additional configuration settings written to recovery.conf when configuring follower.
+    -  **custom\_conf** : path to an optional custom ``postgresql.conf`` file, that will be used in place of ``postgresql.base.conf``. The file must exist on all cluster nodes, be readable by PostgreSQL and will be included from its location on the real ``postgresql.conf``. Note that Patroni will not monitor this file for changes, nor backup it. However, its settings can still be overridden by Patroni's own configuration facilities - see :ref:`dynamic configuration <dynamic_configuration>` for details.
+    -  **parameters**: list of configuration settings for Postgres. Many of these are required for replication to work.
+    -  **pg\_hba**: list of lines that Patroni will use to generate ``pg_hba.conf``. This parameter has higher priority than ``bootstrap.pg_hba``. Together with :ref:`dynamic configuration <dynamic_configuration>` it simplifies management of ``pg_hba.conf``.
+            -  **- host all all 0.0.0.0/0 md5**.
+            -  **- host replication replicator 127.0.0.1/32 md5**: A line like this is required for replication.
+    -  **pg\_ident**: list of lines that Patroni will use to generate ``pg_ident.conf``. Together with :ref:`dynamic configuration <dynamic_configuration>` it simplifies management of ``pg_ident.conf``.
+            -  **- mapname1 systemname1 pguser1**.
+            -  **- mapname1 systemname2 pguser2**.
+    -  **pg\_ctl\_timeout**: How long should pg_ctl wait when doing ``start``, ``stop`` or ``restart``. Default value is 60 seconds.
+    -  **use\_pg\_rewind**: try to use pg\_rewind on the former leader when it joins cluster as a replica.
+    -  **remove\_data\_directory\_on\_rewind\_failure**: If this option is enabled, Patroni will remove the PostgreSQL data directory and recreate the replica. Otherwise it will try to follow the new leader. Default value is **false**.
+    -  **remove\_data\_directory\_on\_diverged\_timelines**: Patroni will remove the PostgreSQL data directory and recreate the replica if it notices that timelines are diverging and the former master can not start streaming from the new master. This option is useful when ``pg_rewind`` can not be used. While performing timelines divergence check on PostgreSQL v10 and older Patroni will try to connect with replication credential to the "postgres" database. Hence, such access should be allowed in the  pg_hba.conf. Default value is **false**.
+    -  **replica\_method**: for each create_replica_methods other than basebackup, you would add a configuration section of the same name. At a minimum, this should include "command" with a full path to the actual script to be executed. Other configuration parameters will be passed along to the script in the form "parameter=value".
+    -  **pre\_promote**: a fencing script that executes during a failover after acquiring the leader lock but before promoting the replica. If the script exits with a non-zero code, Patroni does not promote the replica and removes the leader key from DCS.
+
+REST API
+--------
+-  **restapi**:
+        -  **connect\_address**: IP address (or hostname) and port, to access the Patroni's :ref:`REST API <rest_api>`. All the members of the cluster must be able to connect to this address, so unless the Patroni setup is intended for a demo inside the localhost, this address must be a non "localhost" or loopback address (ie: "localhost" or "127.0.0.1"). It can serve as an endpoint for HTTP health checks (read below about the "listen" REST API parameter), and also for user queries (either directly or via the REST API), as well as for the health checks done by the cluster members during leader elections (for example, to determine whether the master is still running, or if there is a node which has a WAL position that is ahead of the one doing the query; etc.) The connect_address is put in the member key in DCS, making it possible to translate the member name into the address to connect to its REST API.
+
+        -  **listen**: IP address (or hostname) and port that Patroni will listen to for the REST API - to provide also the same health checks and cluster messaging between the participating nodes, as described above. to provide health-check information for HAProxy (or any other load balancer capable of doing a HTTP "OPTION" or "GET" checks).
+
+        -  **authentication**: (optional)
+            -  **username**: Basic-auth username to protect unsafe REST API endpoints.
+            -  **password**: Basic-auth password to protect unsafe REST API endpoints.
+        -  **certfile**: (optional): Specifies the file with the certificate in the PEM format. If the certfile is not specified or is left empty, the API server will work without SSL.
+        -  **keyfile**: (optional): Specifies the file with the secret key in the PEM format.
+        -  **keyfile\_password**: (optional): Specifies a password for decrypting the keyfile.
+        -  **cafile**: (optional): Specifies the file with the CA_BUNDLE with certificates of trusted CAs to use while verifying client certs.
+        -  **ciphers**: (optional): Specifies the permitted cipher suites (e.g. "ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES128-GCM-SHA256:!SSLv1:!SSLv2:!SSLv3:!TLSv1:!TLSv1.1")
+        -  **verify\_client**: (optional): ``none`` (default), ``optional`` or ``required``. When ``none`` REST API will not check client certificates. When ``required`` client certificates are required for all REST API calls. When ``optional`` client certificates are required for all unsafe REST API endpoints. When ``required`` is used, then client authentication succeeds, if the certificate signature verification succeeds.  For ``optional`` the client cert will only be checked for ``PUT``, ``POST``, ``PATCH``, and ``DELETE`` requests.
+        -  **allowlist**: (optional): Specifies the set of hosts that are allowed to call unsafe REST API endpoints. The single element could be a host name, an IP address or a network address using CIDR notation. By default ``allow all`` is used. In case if ``allowlist`` or ``allowlist_include_members`` are set, anything that is not included is rejected.
+        -  **allowlist\_include\_members**: (optional): If set to ``true`` it allows accessing unsafe REST API endpoints from other cluster members registered in DCS (IP address or hostname is taken from the members ``api_url``). Be careful, it might happen that OS will use a different IP for outgoing connections.
+        -  **http\_extra\_headers**: (optional): HTTP headers let the REST API server pass additional information with an HTTP response.
+        -  **https\_extra\_headers**: (optional): HTTPS headers let the REST API server pass additional information with an HTTP response when TLS is enabled. This will also pass additional information set in ``http_extra_headers``.
+
+Here is an example of both **http_extra_headers** and **https_extra_headers**:
+
+.. code:: YAML
+
+        restapi:
+          listen: <listen>
+          connect_address: <connect_address>
+          authentication:
+            username: <username>
+            password: <password>
+          http_extra_headers:
+            'X-Frame-Options': 'SAMEORIGIN'
+            'X-XSS-Protection': '1; mode=block'
+            'X-Content-Type-Options': 'nosniff'
+          cafile: <ca file>
+          certfile: <cert>
+          keyfile: <key>
+          https_extra_headers:
+            'Strict-Transport-Security': 'max-age=31536000; includeSubDomains'
+
+.. _patronictl_settings:
+
+CTL
+---
+- **ctl**: (optional)
+    -  **insecure**: Allow connections to REST API without verifying SSL certs.
+    -  **cacert**: Specifies the file with the CA_BUNDLE file or directory with certificates of trusted CAs to use while verifying REST API SSL certs. If not provided patronictl will use the value provided for REST API "cafile" parameter.
+    -  **certfile**: Specifies the file with the client certificate in the PEM format. If not provided patronictl will use the value provided for REST API "certfile" parameter.
+    -  **keyfile**: Specifies the file with the client secret key in the PEM format. If not provided patronictl will use the value provided for REST API "keyfile" parameter.
+    -  **keyfile\_password**: Specifies a password for decrypting the keyfile. If not provided patronictl will use the value provided for REST API "keyfile\_password" parameter.
+
+Watchdog
+--------
+- **mode**: ``off``, ``automatic`` or ``required``. When ``off`` watchdog is disabled. When ``automatic`` watchdog will be used if available, but ignored if it is not. When ``required`` the node will not become a leader unless watchdog can be successfully enabled.
+- **device**: Path to watchdog device. Defaults to ``/dev/watchdog``.
+- **safety_margin**: Number of seconds of safety margin between watchdog triggering and leader key expiration.
+
+.. _tags_settings:
+
+Tags
+----
+- **nofailover**: ``true`` or ``false``, controls whether this node is allowed to participate in the leader race and become a leader. Defaults to ``false``
+- **clonefrom**: ``true`` or ``false``. If set to ``true`` other nodes might prefer to use this node for bootstrap (take ``pg_basebackup`` from). If there are several nodes with ``clonefrom`` tag set to ``true`` the node to bootstrap from will be chosen randomly. The default value is ``false``.
+- **noloadbalance**: ``true`` or ``false``. If set to ``true`` the node will return HTTP Status Code 503 for the ``GET /replica`` REST API health-check and therefore will be excluded from the load-balancing. Defaults to ``false``.
+- **replicatefrom**: The IP address/hostname of another replica. Used to support cascading replication.
+- **nosync**: ``true`` or ``false``. If set to ``true`` the node will never be selected as a synchronous replica.
+
+In addition to these predefined tags, you can also add your own ones:
+
+- **key1**: ``true``
+- **key2**: ``false``
+- **key3**: ``1.4``
+- **key4**: ``"RandomString"``
+
+Tags are visible in the :ref:`REST API <rest_api>` and ``patronictl list`` You can also check for an instance health using these tags. If the tag isn't defined for an instance, or if the respective value doesn't match the querying value, it will return HTTP Status Code 503.

docs/_static/multi-dc-asynchronous-replication.drawio

@@ -1 +0,0 @@
-<mxfile host="app.diagrams.net" modified="2023-03-13T14:29:21.924Z" agent="5.0 (X11; Ubuntu)" etag="sukwsRuBYbiX8e-LLYnw" version="21.0.6" type="device"><diagram name="Page-1" id="Xu3tU9JEMeQEUPilRV_D">7Vxtb9s2EP41BrYPNfTmt4+Jk2bFOixrihXYF4O2aEkNLaoUZTv99SMlUhZF+i2RE8dVEsDiiTxKd88deXeMO+54sb4jIAn/wj5EHcfy1x33puM4tud67INTngrKkLc4ISCRLzptCA/RTyiIlqBmkQ9TpSPFGNEoUYkzHMdwRhUaIASv1G5zjNRZExBAjfAwA0infot8Ggqq3R9tbvwBoyCk8v0GxY0FkJ3Fm6Qh8PGqQnJvO+6YYEyLq8V6DBEXnpRLMe7jlrvlgxEY00MG/L3474v99d/Hb+jnn596d99vsjj7ILgsAcrEC9+MhYJS+iSFkOAoprkge9fsj80ztjo9dmfMW12nVyPU2wOVYOstzkMl1NsDlWDX2du1+e36A1YIWkthb9XmtyoPyP7ca5xRFMVwXELOYsSAAD9iqhhjhAmjxThm0rsO6QKxls0uV2FE4UMCZlyqK2YujDbHMRWgtx3ZFoLnXBmsKWBzEcEj1wQkt0tYKKTogxBI0mhajiJwlpE0WsIvMC2YcyoDYMKvF+uA22oXrFKvGxCcJfnjf2JzGe9O2OVkhnDmcyaU4EcoX7LjuOz3Iwfc9TxCqPbyS0hoxGzpCkUB500xnwqIFoJzyjkyiURx8Dlv3biWkIJpCh+kIfTF6+j4l2Bms8J1hSTs4Q7iBaTkiXURd3vSNoVz8kRztbF0T9LCipF7chwQ3iUoWW8MkF0IGzzCHh3NHu8Bk3gcaTZpELemm95VfzzsVwVnb9VKHXk1HZSsTCiugFzXyk6/c7CqbHvAzXq3shyrpyur7Ni4slxdWXd8TJxSEDP5OH3EAT4l7CrIoc7o/vRJ02X6COksFII3epdtFrHF6xxmpYw+z3/qpiUR8hlMIbrHaUSj3DdMMaV4sdewZ5D7KBUX+xwdSJPibefRGvrbvBWBKc7IDBa+ivm51OS1/OlE6mAiRX5CZI5UJzLQcdk3+JD+qVDpHYtKAoHPOhCYIKbTFpyvB04u+YmU+wkR2lMRar81RHstRFuIKhB13DODaF+D6O3X8Q0PNFGWcu04lh4nKTisKE8BR76BSmthgIoqK/8x4bDEWz0k61pWHmR1+24t+BLxVY06MlKLOK3Wc7SF8SAfze4bmNg1mjOs9c0Dqb12olmE2XDqWH/MppDEkIm5GxVIT2R4wxTkn8zPDlUQu44O4qEpnBieCMQDDcQtZFvIViHbPzPEDjWAQj+AcqHDhIY4wDFAtxvqNcFZ7JdY3fT5jLmkczR/h5Q+ieUTZBS/JGYtVtAd/URmkAISwF38xBLDX3CnqghEgEZLNSFpkrwYes/trLK01r2S56ksigcVo2r6Kx/j+SodtU6odUI7nRDT23l5IVl8eNduaPBWbuhlorcvQPT9A0U/Oi/R6475ckU/OC/R66nkG74WFHkQtujFil76PzJeNSyWxA9iTbziYiQwF6nsIPMn7JMtgqPiChWUjwVb2aEt+bUlv03Jb4ZJggmgcOIDCiblPmJ7iel05T+9itVQ+c9Ttx1vX/2zDbn7yyz/ucfqyrbPrfpnt1nsS89iH49Sr16lfvNEtq0nAVuY/uIwdZzzg+lQg6lWcNFDwzZxdFGJo+P97blVXOw229mC9p3VXJyzznYK8e5N/JSnw/dlfuRKc+l1lzIebl1R64reS+XFgNF36IvkLuANfNHLpO9ehPSHB0pfyvFcpO/9UtKXRvL60n+kftr/Z/jtGi7DW39l/0juoeEwv8yM+NGyUkepJUsq9RRDv5xkKNzwhMKHIk/Pyzb9ZN3ZUrY5fjqVxGc65BFsd88zHMzIa4pRrylG+8R7MKNBU4yGTTEaNcSIeYCGGNlNMXKaYtQUsp1tyL6vWGXBTDPWX5qsuKV6BJIHDPJfax11bapvk+cIr2YhILTLq5JTkPIV0FSROtmG2altmAc9bb/slrnV6o6510Di1Lhu6QfVj1x87KYMbSsjY73hQLic2as0xigh0QJw9e+UhnHhf4aVMXRT1bT2BqqLyPeLHSY/UAA2Jw3UQJ5HxXxTKQ4d5Far5ABEkcdQr65UWdjW95RVuUGt2OHqUe7IFOWeymbPZKNvOFO1a2u8d0fvntWGXi/PS2MJ3WearjVDIE2VQTSiCL6Cw9l6BixntBKo5axiTBYAGZk9UALBIooD1u1LUWbME1iO9RtIn+JZSHCMs/T3ildRD4nt80FcsltcEEdFnjY7nR/SEb7L+jT/UX6JiJikU/2eDpNfsbqW5wwV1yJt4Lm5Y9kFz+cpPDItzJqbbxMpum++k8W9/R8=</diagram></mxfile>

docs/_static/multi-dc-synchronous-replication.drawio

@@ -1 +0,0 @@
-<mxfile host="app.diagrams.net" modified="2023-03-13T14:25:32.295Z" agent="5.0 (X11; Ubuntu)" etag="EcVEbU6F-AyuIGXoP3hl" version="21.0.6" type="device"><diagram id="SVgELWPNXIlR7V7eDs_m" name="Page-1">7Vtbc5s4FP41frQHgY3tx9hO2u5kZ9Km7c70xSODDGxlxAoRO/31K4FkgwS2k+DGTZxmpuggjsS5fOci0nGmq80HCpPwb+Ij3LEtf9NxZh3bBn2nz/8TlMeCMhyOCkJAI19O2hHuo19IEi1JzSIfpZWJjBDMoqRK9EgcI49VaJBSsq5OWxJcXTWBATII9x7EJvWfyGehpAJ3vLvxEUVBKJce2cPixgqqyfJN0hD6ZF0iOdcdZ0oJYcXVajNFWAhPyaV47qbh7nZjFMXsmAf8b7fdj9cAuzc/wOTz92/W3Y+vXafg8gBxJl94NrXlftmjEkJCopjlghxM+C9fZ2p1BvzOVIx69kAj6ONhlQDMkeBRJejjYZUAdPZAWx/oGywRjFGFvaWtb5U2yH+dCckYjmI03ZqcxYkBhX7EVTElmFBOi0nMpTcJ2QrzEeCX6zBi6D6BnpDqmrsLpy1JzKTRA1uNpeAFV27WDPK1qOSRawLR6wdUKKSYgzFM0mixfYoiL6Np9IC+oLRgLqjcABNxvdoEwld7cJ32ewElWZJv/xNfq/bunF/OPUwyXzBhlPxE6iU7tsP/3QiDmywjjLWXf0CURdyXrnAUCN6MiKWgHGG0ZIIjl0gUB7f5aOZYUgp1S/gwDZEvX8e0f+kSYlW0KZGkP3xAZIUYfeRT5N2+JX3zUY2L4Xrn6Y5y37Dk5I56Dkp0Cbasdw7IL6QPPsEf3b7hkHeQizyODKeskbehnMGVOx25ZcmBRrXopqcpYcuqzoxLVm6qZS/wHK0roOvKNnQF6nQFHPtEunKAoavrr9OZCEY4S7mX8itgqC39iZgXShmX5Fax7VzGqQYVJX13hAmKnzqlL/MfBRYl2O5ZVg7EPdfRAFpisEYd11ILLNdmjhsYD/On+f0aJkCj2SNtbg62ylhv4QLhO5JGLMpxakEYI6sSnHhIIGOjeevo9zNbIBojLuZelCPfJFEQyBXkn8yM7aoZ25aJOaMaM+6PXm7F6ch2HA96nxfjq1/hp+zT9C+vaxpxx3axAGY/euCXAcuduiAtqE7ha9bMy0klq3f/y0Sak2NKtwhJV3yCm2yKh+TtFy1XJYmVjtkCcA7s4WhG/bYYDdpidEi8RzMatsVo1BajcUuMuIu3xAi0xchui1Fblm03WfZdySsLZoazvmtyBZb0NCCP2qqktKu5gB6rlpisvRBS1vMhgwuYooY8rCEaHRvImqNWvxq1RMWlJ8rD3sAMW4MWEuXasGXvD1tHQEhbftbI6O6DeIk4ZTDmOnqatZzZq7TGKKHRCgr175VGbdx/hpNxL2BVzzqYLK4i3xeP8xqavw7c1dTVZFpkpjBjRJbXudNW8nBZkdUUaaWS3+6f0mfBoOKzwDEzzXFdpnmq2tYsbWeiBig0yYuduNaycpjrylpI2FZCUZON8uJnXLWOgm2DeVzaWu+6reURmhAKGZqLqDrfQkJzF+V0LS6zUdNai+vMOlxgbHa46gLlLgZQBHk5blGUYC7p/Q2VWhtuaic22PZxLc5yo6WitIMNi/0mszXDkosdcieYJsXbLqMN8pt8gkc0klEPFR4hAlydb/iLuVLFXEh+ruR+dGuv/1Qb3UYmaaSu2dpza2zUPZWJqu1cGnvvt7H3dCN+xcZe/VGCWSK9zaOEp6vq8LHPbz5KAGYXdjZ1LgnrJWF9F+ewQ/fsstThJUt921kqeLKVnl2a6hpWhvwAKZETykISkBji6x11woEk9rdWsJtzS4R+cz3+ixh7lIoUPa5nBWUl3kKZ+95CSlFsfa8WKMKQcSytYEydUOWjdwKid9rrAg1kOMxUeTBIA8TkY5putvt4gbrMfOxSVbyzquIZoHN2ZYX7TsqKZ+jq7D5RskfnESLUl7s5wu6T+fj3BIOBFsoNDRRh63SxwEwvVUYZOnlEgGmxE3XKwSKGUQsHc219pnDwqLDxQCdntJbmL1jFhK4grmV2/xh7IccWkqV84pcix8sRvemI55lH9ULqDadEwhbzaNI52UnikYikvLnmrFB+/i5X6ZS/MK9Dqi4P7mPHqfiA+hLsua6lppDlMkUn8Rp7/Ieh2fA3odn4ldFM2WUDmh0GE/MrrBNCYFuffLXH6ALKLZD/DAhXp58vhnCO4CN3WEVw59wR3DF72q+J4IebE9aRUK/+FqA9qH9Za6j/h8n52JCqFHIuch68VTm33pVrkDMf7v4EsoCZ3R+SOtf/Aw==</diagram></mxfile>

docs/citus.rst

@@ -1,355 +0,0 @@
-.. _citus:
-
-Citus support
-=============
-
-Patroni makes it extremely simple to deploy `Multi-Node Citus`__ clusters.
-
-__ https://docs.citusdata.com/en/stable/installation/multi_node.html
-
-TL;DR
------
-
-There are only a few simple rules you need to follow:
-
-1. `Citus <https://github.com/citusdata/citus>`__ database extension to
-   PostgreSQL must be available on all nodes.  Absolute minimum supported Citus
-   version is 10.0, but, to take all benefits from transparent switchovers and
-   restarts of workers we recommend using at least Citus 11.2.
-2. Cluster name (``scope``) must be the same for all Citus nodes!
-3. Superuser credentials must be the same on coordinator and all worker
-   nodes, and ``pg_hba.conf`` should allow superuser access between all nodes.
-4. :ref:`REST API <restapi_settings>` access should be allowed from worker
-   nodes to the coordinator. E.g., credentials should be the same and if
-   configured, client certificates from worker nodes must be accepted by the
-   coordinator.
-5. Add the following section to the ``patroni.yaml``:
-
-.. code:: YAML
-
-        citus:
-          group: X  # 0 for coordinator and 1, 2, 3, etc for workers
-          database: citus  # must be the same on all nodes
-
-
-After that you just need to start Patroni and it will handle the rest:
-
-1. ``citus`` extension will be automatically added to ``shared_preload_libraries``.
-2. If ``max_prepared_transactions`` isn't explicitly set in the global
-   :ref:`dynamic configuration <dynamic_configuration>` Patroni will
-   automatically set it to ``2*max_connections``.
-3. The ``citus.database`` will be automatically created followed by ``CREATE EXTENSION citus``.
-4. Current superuser :ref:`credentials <postgresql_settings>` will be added to the ``pg_dist_authinfo``
-   table to allow cross-node communication. Don't forget to update them if
-   later you decide to change superuser username/password/sslcert/sslkey!
-5. The coordinator primary node will automatically discover worker primary
-   nodes and add them to the ``pg_dist_node`` table using the
-   ``citus_add_node()`` function.
-6. Patroni will also maintain ``pg_dist_node`` in case failover/switchover
-   on the coordinator or worker clusters occurs.
-
-patronictl
-----------
-
-Coordinator and worker clusters are physically different PostgreSQL/Patroni
-clusters that are just logically groupped together using the
-`Citus <https://github.com/citusdata/citus>`__ database extension to
-PostgreSQL. Therefore in most cases it is not possible to manage them as a
-single entity.
-
-It results in two major differences in ``patronictl`` behaviour when
-``patroni.yaml`` has the ``citus`` section comparing with the usual:
-
-1. The ``list`` and the ``topology`` by default output all members of the Citus
-   formation (coordinators and workers). The new column ``Group`` indicates
-   which Citus group they belong to.
-2. For all ``patronictl`` commands the new option is introduced, named
-   ``--group``. For some commands the default value for the group might be
-   taken from the ``patroni.yaml``. For example, ``patronictl pause`` will
-   enable the maintenance mode by default for the ``group`` that is set in the
-   ``citus`` section, but for example for ``patronictl  switchover`` or
-   ``patronictl remove`` the group must be explicitly specified.
-
-An example of ``patronictl list`` output for the Citus cluster::
-
-    postgres@coord1:~$ patronictl list demo
-    + Citus cluster: demo ----------+--------------+---------+----+-----------+
-    | Group | Member  | Host        | Role         | State   | TL | Lag in MB |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-    |     0 | coord1  | 172.27.0.10 | Replica      | running |  1 |         0 |
-    |     0 | coord2  | 172.27.0.6  | Sync Standby | running |  1 |         0 |
-    |     0 | coord3  | 172.27.0.4  | Leader       | running |  1 |           |
-    |     1 | work1-1 | 172.27.0.8  | Sync Standby | running |  1 |         0 |
-    |     1 | work1-2 | 172.27.0.2  | Leader       | running |  1 |           |
-    |     2 | work2-1 | 172.27.0.5  | Sync Standby | running |  1 |         0 |
-    |     2 | work2-2 | 172.27.0.7  | Leader       | running |  1 |           |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-
-If we add the ``--group`` option, the output will change to::
-
-    postgres@coord1:~$ patronictl list demo --group 0
-    + Citus cluster: demo (group: 0, 7179854923829112860) -----------+
-    | Member | Host        | Role         | State   | TL | Lag in MB |
-    +--------+-------------+--------------+---------+----+-----------+
-    | coord1 | 172.27.0.10 | Replica      | running |  1 |         0 |
-    | coord2 | 172.27.0.6  | Sync Standby | running |  1 |         0 |
-    | coord3 | 172.27.0.4  | Leader       | running |  1 |           |
-    +--------+-------------+--------------+---------+----+-----------+
-
-    postgres@coord1:~$ patronictl list demo --group 1
-    + Citus cluster: demo (group: 1, 7179854923881963547) -----------+
-    | Member  | Host       | Role         | State   | TL | Lag in MB |
-    +---------+------------+--------------+---------+----+-----------+
-    | work1-1 | 172.27.0.8 | Sync Standby | running |  1 |         0 |
-    | work1-2 | 172.27.0.2 | Leader       | running |  1 |           |
-    +---------+------------+--------------+---------+----+-----------+
-
-Citus worker switchover
------------------------
-
-When a switchover is orchestrated for a Citus worker node, Citus offers the
-opportunity to make the switchover close to transparent for an application.
-Because the application connects to the coordinator, which in turn connects to
-the worker nodes, then it is possible with Citus to `pause` the SQL traffic on
-the coordinator for the shards hosted on a worker node. The switchover then
-happens while the traffic is kept on the coordinator, and resumes as soon as a
-new primary worker node is ready to accept read-write queries.
-
-An example of ``patronictl switchover`` on the worker cluster::
-
-    postgres@coord1:~$ patronictl switchover demo
-    + Citus cluster: demo ----------+--------------+---------+----+-----------+
-    | Group | Member  | Host        | Role         | State   | TL | Lag in MB |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-    |     0 | coord1  | 172.27.0.10 | Replica      | running |  1 |         0 |
-    |     0 | coord2  | 172.27.0.6  | Sync Standby | running |  1 |         0 |
-    |     0 | coord3  | 172.27.0.4  | Leader       | running |  1 |           |
-    |     1 | work1-1 | 172.27.0.8  | Leader       | running |  1 |           |
-    |     1 | work1-2 | 172.27.0.2  | Sync Standby | running |  1 |         0 |
-    |     2 | work2-1 | 172.27.0.5  | Sync Standby | running |  1 |         0 |
-    |     2 | work2-2 | 172.27.0.7  | Leader       | running |  1 |           |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-    Citus group: 2
-    Primary [work2-2]:
-    Candidate ['work2-1'] []:
-    When should the switchover take place (e.g. 2022-12-22T08:02 )  [now]:
-    Current cluster topology
-    + Citus cluster: demo (group: 2, 7179854924063375386) -----------+
-    | Member  | Host       | Role         | State   | TL | Lag in MB |
-    +---------+------------+--------------+---------+----+-----------+
-    | work2-1 | 172.27.0.5 | Sync Standby | running |  1 |         0 |
-    | work2-2 | 172.27.0.7 | Leader       | running |  1 |           |
-    +---------+------------+--------------+---------+----+-----------+
-    Are you sure you want to switchover cluster demo, demoting current primary work2-2? [y/N]: y
-    2022-12-22 07:02:40.33003 Successfully switched over to "work2-1"
-    + Citus cluster: demo (group: 2, 7179854924063375386) ------+
-    | Member  | Host       | Role    | State   | TL | Lag in MB |
-    +---------+------------+---------+---------+----+-----------+
-    | work2-1 | 172.27.0.5 | Leader  | running |  1 |           |
-    | work2-2 | 172.27.0.7 | Replica | stopped |    |   unknown |
-    +---------+------------+---------+---------+----+-----------+
-
-    postgres@coord1:~$ patronictl list demo
-    + Citus cluster: demo ----------+--------------+---------+----+-----------+
-    | Group | Member  | Host        | Role         | State   | TL | Lag in MB |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-    |     0 | coord1  | 172.27.0.10 | Replica      | running |  1 |         0 |
-    |     0 | coord2  | 172.27.0.6  | Sync Standby | running |  1 |         0 |
-    |     0 | coord3  | 172.27.0.4  | Leader       | running |  1 |           |
-    |     1 | work1-1 | 172.27.0.8  | Leader       | running |  1 |           |
-    |     1 | work1-2 | 172.27.0.2  | Sync Standby | running |  1 |         0 |
-    |     2 | work2-1 | 172.27.0.5  | Leader       | running |  2 |           |
-    |     2 | work2-2 | 172.27.0.7  | Sync Standby | running |  2 |         0 |
-    +-------+---------+-------------+--------------+---------+----+-----------+
-
-And this is how it looks on the coordinator side::
-
-    # The worker primary notifies the coordinator that it is going to execute "pg_ctl stop".
-    2022-12-22 07:02:38,636 DEBUG: query("BEGIN")
-    2022-12-22 07:02:38,636 DEBUG: query("SELECT pg_catalog.citus_update_node(3, '172.27.0.7-demoted', 5432, true, 10000)")
-    # From this moment all application traffic on the coordinator to the worker group 2 is paused.
-
-    # The future worker primary notifies the coordinator that it acquired the leader lock in DCS and about to run "pg_ctl promote".
-    2022-12-22 07:02:40,085 DEBUG: query("SELECT pg_catalog.citus_update_node(3, '172.27.0.5', 5432)")
-
-    # The new worker primary just finished promote and notifies coordinator that it is ready to accept read-write traffic.
-    2022-12-22 07:02:41,485 DEBUG: query("COMMIT")
-    # From this moment the application traffic on the coordinator to the worker group 2 is unblocked.
-
-Peek into DCS
--------------
-
-The Citus cluster (coordinator and workers) are stored in DCS as a fleet of
-Patroni clusters logically grouped together::
-
-    /service/batman/              # scope=batman
-    /service/batman/0/            # citus.group=0, coordinator
-    /service/batman/0/initialize
-    /service/batman/0/leader
-    /service/batman/0/members/
-    /service/batman/0/members/m1
-    /service/batman/0/members/m2
-    /service/batman/1/            # citus.group=1, worker
-    /service/batman/1/initialize
-    /service/batman/1/leader
-    /service/batman/1/members/
-    /service/batman/1/members/m3
-    /service/batman/1/members/m4
-    ...
-
-Such an approach was chosen because for most DCS it becomes possible to fetch
-the entire Citus cluster with a single recursive read request. Only Citus
-coordinator nodes are reading the whole tree, because they have to discover
-worker nodes. Worker nodes are reading only the subtree for their own group and
-in some cases they could read the subtree of the coordinator group.
-
-Citus on Kubernetes
--------------------
-
-Since Kubernetes doesn't support hierarchical structures we had to include the
-citus group to all K8s objects Patroni creates::
-
-    batman-0-leader  # the leader config map for the coordinator
-    batman-0-config  # the config map holding initialize, config, and history "keys"
-    ...
-    batman-1-leader  # the leader config map for worker group 1
-    batman-1-config
-    ...
-
-I.e., the naming pattern is: ``${scope}-${citus.group}-${type}``.
-
-All Kubernetes objects are discovered by Patroni using the `label selector`__,
-therefore all Pods with Patroni&Citus and Endpoints/ConfigMaps must have
-similar labels, and Patroni must be configured to use them using Kubernetes
-:ref:`settings <kubernetes_settings>` or :ref:`environment variables
-<kubernetes_environment>`.
-
-__ https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors
-
-A couple of examples of Patroni configuration using Pods environment variables:
-
-1. for the coordinator cluster
-
-.. code:: YAML
-
-        apiVersion: v1
-        kind: Pod
-        metadata:
-          labels:
-            application: patroni
-            citus-group: "0"
-            citus-type: coordinator
-            cluster-name: citusdemo
-          name: citusdemo-0-0
-          namespace: default
-        spec:
-          containers:
-          - env:
-            - name: PATRONI_SCOPE
-              value: citusdemo
-            - name: PATRONI_NAME
-              valueFrom:
-                fieldRef:
-                  apiVersion: v1
-                  fieldPath: metadata.name
-            - name: PATRONI_KUBERNETES_POD_IP
-              valueFrom:
-                fieldRef:
-                  apiVersion: v1
-                  fieldPath: status.podIP
-            - name: PATRONI_KUBERNETES_NAMESPACE
-              valueFrom:
-                fieldRef:
-                  apiVersion: v1
-                  fieldPath: metadata.namespace
-            - name: PATRONI_KUBERNETES_LABELS
-              value: '{application: patroni}'
-            - name: PATRONI_CITUS_DATABASE
-              value: citus
-            - name: PATRONI_CITUS_GROUP
-              value: "0"
-
-2. for the worker cluster from the group 2
-
-.. code:: YAML
-
-        apiVersion: v1
-        kind: Pod
-        metadata:
-          labels:
-            application: patroni
-            citus-group: "2"
-            citus-type: worker
-            cluster-name: citusdemo
-          name: citusdemo-2-0
-          namespace: default
-        spec:
-          containers:
-          - env:
-            - name: PATRONI_SCOPE
-              value: citusdemo
-            - name: PATRONI_NAME
-              valueFrom:
-                fieldRef:
-                  apiVersion: v1
-                  fieldPath: metadata.name
-            - name: PATRONI_KUBERNETES_POD_IP
-              valueFrom:
-                fieldRef:
-                  apiVersion: v1
-                  fieldPath: status.podIP
-            - name: PATRONI_KUBERNETES_NAMESPACE
-              valueFrom:
-                fieldRef:
-                  apiVersion: v1
-                  fieldPath: metadata.namespace
-            - name: PATRONI_KUBERNETES_LABELS
-              value: '{application: patroni}'
-            - name: PATRONI_CITUS_DATABASE
-              value: citus
-            - name: PATRONI_CITUS_GROUP
-              value: "2"
-
-As you may noticed, both examples have ``citus-group`` label set. This label
-allows Patroni to identify object as belonging to a certain Citus group. In
-addition to that, there is also ``PATRONI_CITUS_GROUP`` environment variable,
-which has the same value as the ``citus-group`` label. When Patroni creates
-new Kubernetes objects ConfigMaps or Endpoints, it automatically puts the
-``citus-group: ${env.PATRONI_CITUS_GROUP}`` label on them:
-
-.. code:: YAML
-
-        apiVersion: v1
-        kind: ConfigMap
-        metadata:
-          name: citusdemo-0-leader  # Is generated as ${env.PATRONI_SCOPE}-${env.PATRONI_CITUS_GROUP}-leader
-          labels:
-            application: patroni    # Is set from the ${env.PATRONI_KUBERNETES_LABELS}
-            cluster-name: citusdemo # Is automatically set from the ${env.PATRONI_SCOPE}
-            citus-group: '0'        # Is automatically set from the ${env.PATRONI_CITUS_GROUP}
-
-You can find a complete example of Patroni deployment on Kubernetes with Citus
-support in the `kubernetes`__ folder of the Patroni repository.
-
-__ https://github.com/zalando/patroni/tree/master/kubernetes
-
-There are two important files for you:
-
-1. Dockerfile.citus
-2. citus_k8s.yaml
-
-Citus upgrades and PostgreSQL major upgrades
---------------------------------------------
-
-First, please read about upgrading Citus version in the `documentation`__.
-There is one minor change in the process. When executing upgrade, you have to
-use ``patronictl restart`` instead of ``systemctl restart`` to restart
-PostgreSQL.
-
-__ https://docs.citusdata.com/en/latest/admin_guide/upgrading_citus.html
-
-The PostgreSQL major upgrade with Citus is a bit more complex. You will have to
-combine techniques used in the Citus documentation about major upgrades and
-Patroni documentation about :ref:`PostgreSQL major upgrade<major_upgrade>`.
-Please keep in mind that Citus cluster consists of many Patroni clusters
-(coordinator and workers) and they all have to be upgraded independently.

docs/conf.py

@@ -20,15 +20,10 @@
 import os
 
 import sys
-
 sys.path.insert(0, os.path.abspath('..'))
 
 from patroni.version import __version__
 
-project_root = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))
-module_dir = os.path.abspath(os.path.join(project_root, 'patroni'))
-excludes = ['tests', 'setup.py', 'conf']
-
 # -- General configuration ------------------------------------------------
 
 # If your documentation needs a minimal Sphinx version, state it here.
@@ -38,21 +33,11 @@ excludes = ['tests', 'setup.py', 'conf']
 # Add any Sphinx extension module names here, as strings. They can be
 # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom
 # ones.
-extensions = [
-    'sphinx.ext.intersphinx',
+extensions = ['sphinx.ext.intersphinx',
     'sphinx.ext.todo',
     'sphinx.ext.mathjax',
     'sphinx.ext.ifconfig',
-    # 'sphinx.ext.viewcode',
-    'sphinx_github_style',  # Generate "View on GitHub" for source code
-    'sphinxcontrib.apidoc',  # For generating module docs from code
-    'sphinx.ext.autodoc',  # For generating module docs from docstrings
-    'sphinx.ext.napoleon',  # For Google and Numpy formatted docstrings
-]
-apidoc_module_dir = module_dir
-apidoc_output_dir = 'modules'
-apidoc_excluded_paths = excludes
-apidoc_separate_modules = True
+    'sphinx.ext.viewcode']
 
 # Add any paths that contain templates here, relative to this directory.
 templates_path = ['_templates']
@@ -85,7 +70,7 @@ release = __version__
 #
 # This is also used if you do content translation via gettext catalogs.
 # Usually you set "language" from the command line for these cases.
-language = 'en'
+language = None
 
 # List of patterns, relative to source directory, that match files and
 # directories to ignore when looking for source files.
@@ -122,34 +107,6 @@ if not on_rtd:  # only import and set the theme if we're building docs locally
 # so a file named "default.css" will overwrite the builtin "default.css".
 html_static_path = ['_static']
 
-# Replace "source" links with "edit on GitHub" when using rtd theme
-html_context = {
-    'display_github': True,
-    'github_user': 'zalando',
-    'github_repo': 'patroni',
-    'github_version': 'master',
-    'conf_py_path': '/docs/',
-}
-
-# sphinx-github-style options, https://sphinx-github-style.readthedocs.io/en/latest/index.html
-
-# The name of the top-level package.
-top_level = "patroni"
-
-# The blob to link to on GitHub - any of "head", "last_tag", or "{blob}"
-# linkcode_blob = 'head'
-
-# The link to your GitHub repository formatted as https://github.com/user/repo
-# If not provided, will attempt to create the link from the html_context dict
-# linkcode_url = f"https://github.com/{html_context['github_user']}/" \
-#                f"{html_context['github_repo']}/{html_context['github_version']}"
-
-# The text to use for the linkcode link
-# linkcode_link_text: str = "View on GitHub"
-
-# A linkcode_resolve() function to use for resolving the link target
-# linkcode_resolve: types.FunctionType
-
 
 # -- Options for HTMLHelp output ------------------------------------------
 
@@ -208,6 +165,7 @@ texinfo_documents = [
 ]
 
 
+
 # -- Options for Epub output ----------------------------------------------
 
 # Bibliographic Dublin Core info.
@@ -229,56 +187,9 @@ epub_copyright = copyright
 epub_exclude_files = ['search.html']
 
 
+
 # Example configuration for intersphinx: refer to the Python standard library.
-intersphinx_mapping = {'python': ('https://docs.python.org/', None)}
-
-
-# Remove these pages from index, references, toc trees, etc.
-# If the builder is not 'html' then add the API docs modules index to pages to be removed.
-exclude_from_builder = {
-    'latex': ['modules/modules'],
-    'epub': ['modules/modules'],
-}
-# Internal holding list, anything added here will always be excluded
-_docs_to_remove = []
-
-
-def builder_inited(app):
-    """Run during Sphinx `builder-inited` phase.
-
-    Set a config value to builder name and add module docs to `docs_to_remove`.
-    """
-    print(f'The builder is: {app.builder.name}')
-    app.add_config_value('builder', app.builder.name, 'env')
-
-    # Remove pages when builder matches any referenced in exclude_from_builder
-    if exclude_from_builder.get(app.builder.name):
-        _docs_to_remove.extend(exclude_from_builder[app.builder.name])
-
-
-def env_get_outdated(app, env, added, changed, removed):
-    """Run during Sphinx `env-get-outdated` phase.
-
-    Remove the items listed in `docs_to_remove` from known pages.
-    """
-    added.difference_update(_docs_to_remove)
-    changed.difference_update(_docs_to_remove)
-    removed.update(_docs_to_remove)
-    return []
-
-
-def doctree_read(app, doctree):
-    """Run during Sphinx `doctree-read` phase.
-
-    Remove the items listed in `docs_to_remove` from the table of contents.
-    """
-    from sphinx import addnodes
-    for toc_tree_node in doctree.traverse(addnodes.toctree):
-        for e in toc_tree_node['entries']:
-            ref = str(e[1])
-            if ref in _docs_to_remove:
-                toc_tree_node['entries'].remove(e)
-
+intersphinx_mapping = {'https://docs.python.org/': None}
 
 # A possibility to have an own stylesheet, to add new rules or override existing ones
 # For the latter case, the CSS specificity of the rules should be higher than the default ones
@@ -287,8 +198,3 @@ def setup(app):
         app.add_css_file('custom.css')
     else:
         app.add_stylesheet('custom.css')
-
-    # Run extra steps to remove module docs when running with a non-html builder
-    app.connect('builder-inited', builder_inited)
-    app.connect('env-get-outdated', env_get_outdated)
-    app.connect('doctree-read', doctree_read)

docs/contributing_guidelines.rst

@@ -1,182 +0,0 @@
-.. _contributing_guidelines:
-
-Contributing guidelines
-=======================
-
-Wanna contribute to Patroni? Yay - here is how!
-
-Chatting
---------
-
-Just want to chat with other Patroni users?  Looking for interactive troubleshooting help? Join us on channel `#patroni <https://postgresteam.slack.com/archives/C9XPYG92A>`__ in the `PostgreSQL Slack <https://pgtreats.info/slack-invite>`__.
-
-Running tests
--------------
-
-Requirements for running behave tests:
-
-1. PostgreSQL packages need to be installed.
-2. PostgreSQL binaries must be available in your `PATH`. You may need to add them to the path with something like `PATH=/usr/lib/postgresql/11/bin:$PATH python -m behave`.
-3. If you'd like to test with external DCSs (e.g., Etcd, Consul, and Zookeeper) you'll need the packages installed and respective services running and accepting unencrypted/unprotected connections on localhost and default port. In the case of Etcd or Consul, the behave test suite could start them up if binaries are available in the `PATH`.
-
-Install dependencies:
-
-.. code-block:: bash
-
-    # You may want to use Virtualenv or specify pip3.
-    pip install -r requirements.txt
-    pip install -r requirements.dev.txt
-
-After you have all dependencies installed, you can run the various test suites:
-
-.. code-block:: bash
-
-    # You may want to use Virtualenv or specify python3.
-
-    # Run flake8 to check syntax and formatting:
-    python setup.py flake8
-
-    # Run the pytest suite in tests/:
-    python setup.py test
-
-    # Run the behave (https://behave.readthedocs.io/en/latest/) test suite in features/;
-    # modify DCS as desired (raft has no dependencies so is the easiest to start with):
-    DCS=raft python -m behave
-
-Testing with tox
-----------------
-
-To run tox tests you only need to install one dependency (other than Python)
-
-.. code-block:: bash
-
-    pip install tox>=4
-
-If you wish to run `behave` tests then you also need docker installed.
-
-Tox configuration in `tox.ini` has "environments" to run the following tasks:
-
-* lint: Python code lint with `flake8`
-* test: unit tests for all available python interpreters with `pytest`,
-  generates XML reports or HTML reports if a TTY is detected
-* dep: detect package dependency conflicts using `pipdeptree`
-* type: static type checking with `pyright`
-* black: code formatting with `black`
-* docker-build: build docker image used for the `behave` env
-* docker-cmd: run arbitrary command with the above image
-* docker-behave-etcd: run tox for behave tests with above image
-* py*behave: run behave with available python interpreters (without docker, although
-  this is what is called inside docker containers)
-* docs: build docs with `sphinx`
-
-Running tox
-^^^^^^^^^^^
-
-To run the default env list; dep, lint, test, and docs, just run:
-
-.. code-block:: bash
-
-    tox
-
-The `test` envs can be run with the label `test`:
-
-.. code-block:: bash
-
-   tox -m test
-
-The `behave` docker tests can be run with the label `behave`:
-
-.. code-block:: bash
-
-   tox -m behave
-
-Similarly, docs has the label `docs`.
-
-All other envs can be run with their respective env names:
-
-.. code-block:: bash
-
-   tox -e lint
-   tox -e py39-test-lin
-
-It is also possible to select partial env lists using `factors`. For example, if you want to run
-all envs for python 3.10:
-
-.. code-block:: bash
-
-    tox -f py310
-
-This is equivalent to running all the envs listed below:
-
-.. code-block:: bash
-
-    $ tox -l -f py310
-    py310-test-lin
-    py310-test-mac
-    py310-test-win
-    py310-type-lin
-    py310-type-mac
-    py310-type-win
-    py310-behave-etcd-lin
-    py310-behave-etcd-win
-    py310-behave-etcd-mac
-
-
-You can list all configured combinations of environments with tox (>=v4) like so
-
-.. code-block:: bash
-
-    tox l
-
-The envs `test` and `docs` will attempt to open the HTML output files
-when the job completes, if tox is run with an active terminal. This
-is intended to be for benefit of the developer running this env locally.
-It will attempt to run `open` on a mac and `xdg-open` on Linux.
-To use a different command set the env var `OPEN_CMD` to the name or path of
-the command. If this step fails it will not fail the run overall.
-If you want to disable this facility set the env var `OPEN_CMD` to the `:` no-op command.
-
-.. code-block:: bash
-
-   OPEN_CMD=: tox -m docs
-
-Behave tests
-^^^^^^^^^^^^
-
-Behave tests with `-m behave` will build docker images based on PG_MAJOR version 11 through 15 and then run all
-behave tests. This can take quite a long time to run so you might want to limit the scope to a select version of
-Postgres or to a specific feature set or steps.
-
-To specify the version of postgres include the full name of the dependent image build env that you want and then the
-behave env name. For instance if you want Postgres 15 use:
-
-.. code-block:: bash
-
-    tox -e pg14-docker-build,pg14-docker-behave-etcd-lin
-
-If on the other hand you want to test a specific feature you can pass positional arguments to behave. This will run
-the watchdog behave feature test scenario with all versions of Postgres.
-
-.. code-block:: bash
-
-    tox -m behave -- features/watchdog.feature
-
-Of course you can combine the two.
-
-Reporting issues
-----------------
-
-If you have a question about patroni or have a problem using it, please read the :ref:`README <readme>` before filing an issue.
-Also double check with the current issues on our `Issues Tracker <https://github.com/zalando/patroni/issues>`__.
-
-Contributing a pull request
----------------------------
-
-1) Submit a comment to the relevant issue or create a new issue describing your proposed change.
-2) Do a fork, develop and test your code changes.
-3) Include documentation
-4) Submit a pull request.
-
-You'll get feedback about your pull request as soon as possible.
-
-Happy Patroni hacking ;-)

docs/dcs_failsafe_mode.rst

@@ -1,63 +0,0 @@
-.. _dcs_failsafe_mode:
-
-DCS Failsafe Mode
-=================
-
-The problem
------------
-
-Patroni is heavily relying on Distributed Configuration Store (DCS) to solve the task of leader elections and detect network partitioning. That is, the node is allowed to run Postgres as the primary only if it can update the leader lock in DCS. In case the update of the leader lock fails, Postgres is immediately demoted and started as read-only. Depending on which DCS is used, the chances of hitting the "problem" differ. For example, with Etcd which is only used for Patroni, chances are close to zero, while with K8s API (backed by Etcd) it could be observed more frequently.
-
-
-Reasons for the current implementation
----------------------------------------
-
-The leader lock update failure could be caused by two main reasons:
-
-1. Network partitioning
-2. DCS being down
-
-In general, it is impossible to distinguish between these two from a single node, and therefore Patroni assumes the worst case - network partitioning. In the case of a partitioned network, other nodes of the Patroni cluster may successfully grab the leader lock and promote Postgres to primary. In order to avoid a split-brain, the old primary is demoted before the leader lock expires.
-
-
-DCS Failsafe Mode
------------------
-
-We introduce a new special option, the ``failsafe_mode``. It could be enabled only via global :ref:`dynamic configuration <dynamic_configuration>` stored in the DCS ``/config`` key. If the failsafe mode is enabled and the leader lock update in DCS failed due to reasons different from the version/value/index mismatch, Postgres may continue to run as a primary if it can access all known members of the cluster via Patroni REST API.
-
-
-Low-level implementation details
---------------------------------
-
-- We introduce a new, permanent key in DCS, named ``/failsafe``.
-- The ``/failsafe`` key contains all known members of the given Patroni cluster at a given time.
-- The current leader maintains the ``/failsafe`` key.
-- The member is allowed to participate in the leader race and become the new leader only if it is present in the ``/failsafe`` key.
-- If the cluster consists of a single node the ``/failsafe`` key will contain a single member.
-- In the case of DCS "outage" the existing primary connects to all members presented in the ``/failsafe`` key via the ``POST /failsafe`` REST API and may continue to run as the primary if all replicas acknowledge it.
-- If one of the members doesn't respond, the primary is demoted.
-- Replicas are using incoming ``POST /failsafe`` REST API requests as an indicator that the primary is still alive. This information is cached for ``ttl`` seconds.
-
-
-F.A.Q.
-------
-
-- Why MUST the current primary see ALL other members? Can’t we rely on quorum here?
-
-  This is a great question! The problem is that the view on the quorum might be different from the perspective of DCS and Patroni. While DCS nodes must be evenly distributed across availability zones, there is no such rule for Patroni, and more importantly, there is no mechanism for introducing and enforcing such a rule. If the majority of Patroni nodes ends up in the losing part of the partitioned network (including primary) while minority nodes are in the winning part, the primary must be demoted. Only checking ALL other members allows detecting such a situation.
-
-- What if node/pod gets terminated while DCS is down?
-
-  If DCS isn’t accessible, the check “are ALL other cluster members accessible?” is executed every cycle of the heartbeat loop (every ``loop_wait`` seconds). If pod/node is terminated, the check will fail and Postgres will be demoted to a read-only and will not recover until DCS is restored.
-
-- What if all members of the Patroni cluster are lost while DCS is down?
-
-  Patroni could be configured to create the new replica from the backup even when the cluster doesn't have a leader. But, if the new member isn't present in the ``/failsafe`` key, it will not be able to grab the leader lock and promote.
-
-- What will happen if the primary lost access to DCS while replicas didn't?
-
-  The primary will execute the failsafe code and contact all known replicas. These replicas will use this information as an indicator that the primary is alive and will not start the leader race even if the leader lock in DCS has expired.
-
-- How to enable the Failsafe Mode?
-
-  Before enabling the ``failsafe_mode`` please make sure that Patroni version on all members is up-to-date. After that, you can use either the ``PATCH /config`` :ref:`REST API <rest_api>` or ``patronictl edit-config -s failsafe_mode=true``

docs/dynamic_configuration.rst

@@ -1,83 +1,89 @@
 .. _dynamic_configuration:
 
-==============================
-Dynamic Configuration Settings
-==============================
+Patroni configuration
+=====================
 
-Dynamic configuration is stored in the DCS (Distributed Configuration Store) and applied on all cluster nodes.
+Patroni configuration is stored in the DCS (Distributed Configuration Store). There are 3 types of configuration:
 
-In order to change the dynamic configuration you can use either ``patronictl edit-config`` tool or Patroni :ref:`REST API <rest_api>`.
+- Dynamic configuration.
+	These options can be set in DCS at any time. If the options changed are not part of the startup configuration,
+	they are applied asynchronously (upon the next wake up cycle) to every node, which gets subsequently reloaded.
+	If the node requires a restart to apply the configuration (for options with context postmaster, if their values
+	have changed), a special flag, ``pending_restart`` indicating this, is set in the members.data JSON.
+	Additionally, the node status also indicates this, by showing ``"restart_pending": true``.
 
--  **loop\_wait**: the number of seconds the loop will sleep. Default value: 10
--  **ttl**: the TTL to acquire the leader lock (in seconds). Think of it as the length of time before initiation of the automatic failover process. Default value: 30
--  **retry\_timeout**: timeout for DCS and PostgreSQL operation retries (in seconds). DCS or network issues shorter than this will not cause Patroni to demote the leader. Default value: 10
--  **maximum\_lag\_on\_failover**: the maximum bytes a follower may lag to be able to participate in leader election.
--  **maximum\_lag\_on\_syncnode**: the maximum bytes a synchronous follower may lag before it is considered as an unhealthy candidate and swapped by healthy asynchronous follower. Patroni utilize the max replica lsn if there is more than one follower, otherwise it will use leader's current wal lsn. Default is -1, Patroni will not take action to swap synchronous unhealthy follower when the value is set to 0 or below. Please set the value high enough so Patroni won't swap synchrounous follower fequently during high transaction volume.
--  **max\_timelines\_history**: maximum number of timeline history items kept in DCS.  Default value: 0. When set to 0, it keeps the full history in DCS.
--  **primary\_start\_timeout**: the amount of time a primary is allowed to recover from failures before failover is triggered (in seconds). Default is 300 seconds. When set to 0 failover is done immediately after a crash is detected if possible. When using asynchronous replication a failover can cause lost transactions. Worst case failover time for primary failure is: loop\_wait + primary\_start\_timeout + loop\_wait, unless primary\_start\_timeout is zero, in which case it's just loop\_wait. Set the value according to your durability/availability tradeoff.
--  **primary\_stop\_timeout**: The number of seconds Patroni is allowed to wait when stopping Postgres and effective only when synchronous_mode is enabled. When set to > 0 and the synchronous_mode is enabled, Patroni sends SIGKILL to the postmaster if the stop operation is running for more than the value set by primary\_stop\_timeout. Set the value according to your durability/availability tradeoff. If the parameter is not set or set <= 0, primary\_stop\_timeout does not apply.
--  **synchronous\_mode**: turns on synchronous replication mode. In this mode a replica will be chosen as synchronous and only the latest leader and synchronous replica are able to participate in leader election. Synchronous mode makes sure that successfully committed transactions will not be lost at failover, at the cost of losing availability for writes when Patroni cannot ensure transaction durability. See :ref:`replication modes documentation <replication_modes>` for details.
--  **synchronous\_mode\_strict**: prevents disabling synchronous replication if no synchronous replicas are available, blocking all client writes to the primary. See :ref:`replication modes documentation <replication_modes>` for details.
--  **failsafe\_mode**: Enables :ref:`DCS Failsafe Mode <dcs_failsafe_mode>`. Defaults to `false`.
--  **postgresql**:
+- Local :ref:`configuration <settings>` (patroni.yml).
+	These options are defined in the configuration file and take precedence over dynamic configuration.
+	patroni.yml could be changed and reloaded in runtime (without restart of Patroni) by sending SIGHUP to the Patroni process, performing ``POST /reload`` REST-API request or executing ``patronictl reload``.
 
-   -  **use\_pg\_rewind**: whether or not to use pg_rewind. Defaults to `false`.
-   -  **use\_slots**: whether or not to use replication slots. Defaults to `true` on PostgreSQL 9.4+.
-   -  **recovery\_conf**: additional configuration settings written to recovery.conf when configuring follower. There is no recovery.conf anymore in PostgreSQL 12, but you may continue using this section, because Patroni handles it transparently.
-   -  **parameters**: list of configuration settings for Postgres.
+- Environment :ref:`configuration <environment>`.
+	It is possible to set/override some of the "Local" configuration parameters with environment variables.
+	Environment configuration is very useful when you are running in a dynamic environment and you don't know some of the parameters in advance (for example it's not possible to know your external IP address when you are running inside ``docker``).
 
-   -  **pg\_hba**: list of lines that Patroni will use to generate ``pg_hba.conf``. Patroni ignores this parameter if ``hba_file`` PostgreSQL parameter is set to a non-default value.
+The local configuration can be either a single YAML file or a directory. When it is a directory, all YAML files in that directory are loaded one by one in sorted order. In case a key is defined in multiple files, the occurrence in the last file takes precedence.
 
-      -  **- host all all 0.0.0.0/0 md5**
-      -  **- host replication replicator 127.0.0.1/32 md5**: A line like this is required for replication.
+Some of the PostgreSQL parameters must hold the same values on the master and the replicas. For those, values set either in the local patroni configuration files or via the environment variables take no effect. To alter or set their values one must change the shared configuration in the DCS. Below is the actual list of such parameters together with the default values:
 
-   -  **pg\_ident**: list of lines that Patroni will use to generate ``pg_ident.conf``. Patroni ignores this parameter if ``ident_file`` PostgreSQL parameter is set to a non-default value.
+- max_connections: 100
+- max_locks_per_transaction: 64
+- max_worker_processes: 8
+- max_prepared_transactions: 0
+- wal_level: hot_standby
+- wal_log_hints: on
+- track_commit_timestamp: off
 
-      -  **- mapname1 systemname1 pguser1**
-      -  **- mapname1 systemname2 pguser2**
+For the parameters below, PostgreSQL does not require equal values among the master and all the replicas. However, considering the possibility of a replica to become the master at any time, it doesn't really make sense to set them differently; therefore, Patroni restricts setting their values to the Dynamic configuration
 
--  **standby\_cluster**: if this section is defined, we want to bootstrap a standby cluster.
+- max_wal_senders: 5
+- max_replication_slots: 5
+- wal_keep_segments: 8
+- wal_keep_size: 128MB
 
-   -  **host**: an address of remote node
-   -  **port**: a port of remote node
-   -  **primary\_slot\_name**: which slot on the remote node to use for replication. This parameter is optional, the default value is derived from the instance name (see function `slot_name_from_member_name`).
-   -  **create\_replica\_methods**: an ordered list of methods that can be used to bootstrap standby leader from the remote primary, can be different from the list defined in :ref:`postgresql_settings`
-   -  **restore\_command**: command to restore WAL records from the remote primary to nodes in a standby cluster, can be different from the list defined in :ref:`postgresql_settings`
-   -  **archive\_cleanup\_command**: cleanup command for standby leader
-   -  **recovery\_min\_apply\_delay**: how long to wait before actually apply WAL records on a standby leader
+These parameters are validated to ensure they are sane, or meet a minimum value.
 
--  **slots**: define permanent replication slots. These slots will be preserved during switchover/failover. Permanent slots that don't exist will be created by Patroni. The physical slots are maintained only in the current primary. The logical slots are copied from the primary to a standby with restart, and after that their position advanced every **loop_wait** seconds (if necessary). Copying logical slot files performed via ``libpq`` connection and using either rewind or superuser credentials (see **postgresql.authentication** section). There is always a chance that the logical slot position on the replica is a bit behind the former primary, therefore application should be prepared that some messages could be received the second time after the failover. The easiest way of doing so - tracking ``confirmed_flush_lsn``. Enabling permanent logical replication slots requires **postgresql.use_slots** to be set and will also automatically enable the ``hot_standby_feedback``. Since the failover of logical replication slots is unsafe on PostgreSQL 9.6 and older and PostgreSQL version 10 is missing some important functions, the feature only works with PostgreSQL 11+.
+There are some other Postgres parameters controlled by Patroni:
 
-   -  **my\_slot\_name**: the name of the permanent replication slot. If the permanent slot name matches with the name of the current leader it will not be created. Please note that Patroni does not make checks for permanent slot names added to this configuration matching those that Patroni creates automatically for members. If those names are added, Patroni will ensure that any slots that were created are not removed even if the member becomes unresponsive, situation which would normally result in the slot's removal by Patroni. Although this can be useful in some situations, such as when importing existing members to a new Patroni cluster (see :ref:`Convert a Standalone to a Patroni Cluster <existing_data>` for details), caution should be exercised by the operator that these clashes in names are not persisted in the DCS due to its effect on normal functioning of Patroni.
+- listen_addresses - is set either from ``postgresql.listen`` or from ``PATRONI_POSTGRESQL_LISTEN`` environment variable
+- port - is set either from ``postgresql.listen`` or from ``PATRONI_POSTGRESQL_LISTEN`` environment variable
+- cluster_name - is set either from ``scope`` or from ``PATRONI_SCOPE`` environment variable
+- hot_standby: on
 
-      -  **type**: slot type. Could be ``physical`` or ``logical``. If the slot is logical, you have to additionally define ``database`` and ``plugin``.
-      -  **database**: the database name where logical slots should be created.
-      -  **plugin**: the plugin name for the logical slot.
+To be on the safe side parameters from the above lists are not written into ``postgresql.conf``, but passed as a list of arguments to the ``pg_ctl start`` which gives them the highest precedence, even above `ALTER SYSTEM <https://www.postgresql.org/docs/current/static/sql-altersystem.html>`__
 
--  **ignore\_slots**: list of sets of replication slot properties for which Patroni should ignore matching slots. This configuration/feature/etc. is useful when some replication slots are managed outside of Patroni. Any subset of matching properties will cause a slot to be ignored.
 
-   -  **name**: the name of the replication slot.
-   -  **type**: slot type. Can be ``physical`` or ``logical``. If the slot is logical, you may additionally define ``database`` and/or ``plugin``.
-   -  **database**: the database name (when matching a ``logical`` slot).
-   -  **plugin**: the logical decoding plugin (when matching a ``logical`` slot).
+When applying the local or dynamic configuration options, the following actions are taken:
 
-Note: **slots** is a hashmap while **ignore_slots** is an array. For example:
+- The node first checks if there is a postgresql.base.conf or if the ``custom_conf`` parameter is set.
+- If the `custom_conf` parameter is set, it will take the file specified on it as a base configuration, ignoring `postgresql.base.conf` and `postgresql.conf`.
+- If the `custom_conf` parameter is not set and `postgresql.base.conf` exists, it contains the renamed "original" configuration and it will be used as a base configuration.
+- If there is no `custom_conf` nor `postgresql.base.conf`, the original postgresql.conf is taken and renamed to postgresql.base.conf.
+- The dynamic options (with the exceptions above) are dumped into the postgresql.conf and an include is set in
+  postgresql.conf to the used base configuration (either postgresql.base.conf or what is on ``custom_conf``). Therefore, we would be able to apply new options without re-reading the configuration file to check if the include is present not.
+- Some parameters that are essential for Patroni to manage the cluster are overridden using the command line.
+- If some of the options that require restart are changed (we should look at the context in pg_settings and at the actual
+  values of those options), a pending_restart flag of a given node is set. This flag is reset on any restart.
 
-.. code:: YAML
+The parameters would be applied in the following order (run-time are given the highest priority):
 
-        slots:
-          permanent_logical_slot_name:
-            type: logical
-            database: my_db
-            plugin: test_decoding
-          permanent_physical_slot_name:
-            type: physical
-          ...
-        ignore_slots:
-          - name: ignored_logical_slot_name
-            type: logical
-            database: my_db
-            plugin: test_decoding
-          - name: ignored_physical_slot_name
-            type: physical
-          ...
+1. load parameters from file `postgresql.base.conf` (or from a `custom_conf` file, if set)
+2. load parameters from file `postgresql.conf`
+3. load parameters from file `postgresql.auto.conf`
+4. run-time parameter using `-o --name=value`
+
+This allows configuration for all the nodes (2), configuration for a specific node using `ALTER SYSTEM` (3) and ensures that parameters essential to the running of Patroni are enforced (4), as well as leaves room for configuration tools that manage `postgresql.conf` directly without involving Patroni (1).
+
+
+Also, the following Patroni configuration options can be changed only dynamically:
+
+- ttl: 30
+- loop_wait: 10
+- retry_timeouts: 10
+- maximum_lag_on_failover: 1048576
+- max_timelines_history: 0
+- check_timeline: false
+- postgresql.use_slots: true
+
+Upon changing these options, Patroni will read the relevant section of the configuration stored in DCS and change its
+run-time values.
+
+Patroni nodes are dumping the state of the DCS options to disk upon for every change of the configuration into the file ``patroni.dynamic.json`` located in the Postgres data directory. Only the master is allowed to restore these options from the on-disk dump if these are completely absent from the DCS or if they are invalid.

docs/existing_data.rst

@@ -10,74 +10,32 @@ To deploy a Patroni cluster without using a pre-existing PostgreSQL instance, se
 Procedure
 ---------
 
-You can find below an overview of steps for converting an existing Postgres cluster to a Patroni managed cluster. In the steps we assume all nodes that are part of the existing cluster are currently up and running, and that you *do not* intend to change Postgres configuration while the migration is ongoing. The steps:
+A Patroni cluster can be started with a data directory from a single-node PostgreSQL database. This is achieved by following closely these steps:
 
-#. Create the Postgres users as explained for :ref:`authentication <postgresql_settings>` section of the Patroni configuration. You can find sample SQL commands to create the users in the code block below, in which you need to replace the usernames and passwords as per your environment. If you already have the relevant users, then you can skip this step.
+1. Manually start PostgreSQL daemon
+2. Create Patroni superuser and replication users as defined in the :ref:`authentication <postgresql_settings>` section of the Patroni configuration. If this user is created in SQL, the following queries achieve this:
 
-   .. code-block:: sql
+.. code-block:: sql
 
-      -- Patroni superuser
-      -- Replace PATRONI_SUPERUSER_USERNAME and PATRONI_SUPERUSER_PASSWORD accordingly
-      CREATE USER PATRONI_SUPERUSER_USERNAME WITH SUPERUSER ENCRYPTED PASSWORD 'PATRONI_SUPERUSER_PASSWORD';
+   CREATE USER $PATRONI_SUPERUSER_USERNAME WITH SUPERUSER ENCRYPTED PASSWORD '$PATRONI_SUPERUSER_PASSWORD';
+   CREATE USER $PATRONI_REPLICATION_USERNAME WITH REPLICATION ENCRYPTED PASSWORD '$PATRONI_REPLICATION_PASSWORD';
 
-      -- Patroni replication user
-      -- Replace PATRONI_REPLICATION_USERNAME and PATRONI_REPLICATION_PASSWORD accordingly
-      CREATE USER PATRONI_REPLICATION_USERNAME WITH REPLICATION ENCRYPTED PASSWORD 'PATRONI_REPLICATION_PASSWORD';
-
-      -- Patroni rewind user, if you intend to enable use_pg_rewind in your Patroni configuration
-      -- Replace PATRONI_REWIND_USERNAME and PATRONI_REWIND_PASSWORD accordingly
-      CREATE USER PATRONI_REWIND_USERNAME WITH ENCRYPTED PASSWORD 'PATRONI_REWIND_PASSWORD';
-      GRANT EXECUTE ON function pg_catalog.pg_ls_dir(text, boolean, boolean) TO PATRONI_REWIND_USERNAME;
-      GRANT EXECUTE ON function pg_catalog.pg_stat_file(text, boolean) TO PATRONI_REWIND_USERNAME;
-      GRANT EXECUTE ON function pg_catalog.pg_read_binary_file(text) TO PATRONI_REWIND_USERNAME;
-      GRANT EXECUTE ON function pg_catalog.pg_read_binary_file(text, bigint, bigint, boolean) TO PATRONI_REWIND_USERNAME;
-
-#. Perform the following steps on all Postgres nodes. Perform all steps on one node before proceeding with the next node. Start with the primary node, then proceed with each standby node:
-
-   #. If you are running Postgres through systemd, then disable the Postgres systemd unit. This is performed as Patroni manages starting and stopping the Postgres daemon.
-
-   #. Create a YAML configuration file for Patroni.
-
-      * **Note (specific for the primary node):** If you have replication slots being used for replication between cluster members, then it is recommended that you enable ``use_slots`` and configure the existing replication slots as permanent via the ``slots`` configuration item. Be aware that Patroni automatically creates replication slots for replication between members, and drops replication slots that it does not recognize, when ``use_slots`` is enabled. The idea of using permanent slots here is to allow your existing slots to persist while the migration to Patroni is in progress. See :ref:`YAML Configuration Settings <yaml_configuration>` for details.
-
-   #. Start Patroni using the ``patroni`` systemd service unit. It automatically detects that Postgres is already running and starts monitoring the instance.
-
-#. Hand over Postgres "start up procedure" to Patroni. In order to do that you need to restart the cluster members through ``patronictl restart cluster-name member-name`` command. For minimal downtime you might want to split this step into:
-
-   #. Immediate restart of the standby nodes.
-   #. Scheduled restart of the primary node within a maintenance window.
-
-#. If you configured permanent slots in step ``1.2.``, then you should remove them from ``slots`` configuration through ``patronictl edit-config cluster-name member-name`` command once the ``restart_lsn`` of the slots created by Patroni is able to catch up with the ``restart_lsn`` of the original slots for the corresponding members. By removing the slots from ``slots`` configuration you will allow Patroni to drop the original slots from your cluster once they are not needed anymore. You can find below an example query to check the ``restart_lsn`` of a couple slots, so you can compare them:
-
-   .. code-block:: sql
-
-      -- Assume original_slot_for_member_x is the name of the slot in your original
-      -- cluster for replicating changes to member X, and slot_for_member_x is the
-      -- slot created by Patroni for that purpose. You need restart_lsn of
-      -- slot_for_member_x to be >= restart_lsn of original_slot_for_member_x
-      SELECT slot_name,
-             restart_lsn
-      FROM pg_replication_slots
-      WHERE slot_name IN (
-          'original_slot_for_member_x',
-          'slot_for_member_x'
-      )
-
-.. _major_upgrade:
+3. Start Patroni (e.g. ``patroni /etc/patroni/patroni.yml``). It automatically detects that PostgreSQL daemon is already running but its configuration might be out-of-date.
+4. Ask Patroni to restart the node with ``patronictl restart cluster-name node-name``. This step is only required if PostgreSQL configuration is out-of-date.
 
 Major Upgrade of PostgreSQL Version
 ===================================
 
 The only possible way to do a major upgrade currently is:
 
-#. Stop Patroni
-#. Upgrade PostgreSQL binaries and perform `pg_upgrade <https://www.postgresql.org/docs/current/pgupgrade.html>`_ on the primary node
-#. Update patroni.yml
-#. Remove the initialize key from DCS or wipe complete cluster state from DCS. The second one could be achieved by running ``patronictl remove <cluster-name>``. It is necessary because pg_upgrade runs initdb which actually creates a new database with a new PostgreSQL system identifier.
-#. If you wiped the cluster state in the previous step, you may wish to copy patroni.dynamic.json from old data dir to the new one.  It will help you to retain some PostgreSQL parameters you had set before.
-#. Start Patroni on the primary node.
-#. Upgrade PostgreSQL binaries, update patroni.yml and wipe the data_dir on standby nodes.
-#. Start Patroni on the standby nodes and wait for the replication to complete.
+1. Stop Patroni
+2. Upgrade PostgreSQL binaries and perform `pg_upgrade <https://www.postgresql.org/docs/current/pgupgrade.html>`_ on the master node
+3. Update patroni.yml
+4. Remove the initialize key from DCS or wipe complete cluster state from DCS. The second one could be achieved by running ``patronictl remove <cluster-name>``. It is necessary because pg_upgrade runs initdb which actually creates a new database with a new PostgreSQL system identifier.
+5. If you wiped the cluster state in the previous step, you may wish to copy patroni.dynamic.json from old data dir to the new one.  It will help you to retain some PostgreSQL parameters you had set before.
+6. Start Patroni on the master node.
+7. Upgrade PostgreSQL binaries, update patroni.yml and wipe the data_dir on standby nodes.
+8. Start Patroni on the standby nodes and wait for the replication to complete.
 
 Running pg_upgrade on standby nodes is not supported by PostgreSQL. If you know what you are doing, you can try the rsync procedure described in https://www.postgresql.org/docs/current/pgupgrade.html instead of wiping data_dir on standby nodes. The safest way is however to let Patroni replicate the data for you.
 

docs/ha_multi_dc.rst

@@ -1,54 +0,0 @@
-.. _ha_multi_dc:
-
-===================
-HA multi datacenter
-===================
-
-The high availability of a PostgreSQL cluster deployed in multiple data centers is based on replication, which can be synchronous or asynchronous (`replication_modes <replication_modes.rst>`_).
-
-In both cases, it is important to be clear about the following concepts:
-
-- Postgres can run as primary or standby leader only when it owns the leading key and can update the leading key.
-- You should run the odd number of etcd, ZooKeeper or Consul nodes: 3 or 5!
-
-Synchronous Replication
------------------------
-
-To have a multi DC cluster that can automatically tolerate a zone drop, a minimum of 3 is required.
-
-The architecture diagram would be the following:
-
-.. image:: _static/multi-dc-synchronous-replication.png
-
-We must deploy a cluster of etcd, ZooKeeper or Consul through the different DC, with a minimum of 3 nodes, one in each zone.
-
-Regarding postgres, we must deploy at least 2 nodes, in different DC. Then you have to set ``synchronous_mode: true`` in the global :ref:`dynamic configuration <dynamic_configuration>`.
-
-This enables sync replication and the primary node will choose one of the nodes as synchronous.
-
-Asynchronous Replication
-------------------------
-
-With only two data centers it would be better to have two independent etcd clusters and run Patroni :ref:`standby cluster <standby_cluster>` in the second data center. If the first site is down, you can MANUALLY promote the ``standby_cluster``.
-
-The architecture diagram would be the following:
-
-.. image:: _static/multi-dc-asynchronous-replication.png
-
-Automatic promotion is not possible, because DC2 will never able to figure out the state of DC1.
-
-You should not use ``pg_ctl promote`` in this scenario, you need "manually promote" the healthy cluster by removing ``standby_cluster`` section from the :ref:`dynamic configuration <dynamic_configuration>`.
-
-.. warning::
-    If the source cluster is still up and running and you promote the standby cluster you create a split-brain.
-
-In case you want to return to the "initial" state, there are only two ways of resolving it:
-
-- Add the standby_cluster section back and it will trigger pg_rewind, but there are chances that pg_rewind will fail.
-- Rebuild the standby cluster from scratch.
-
-Before promoting standby cluster one have to manually ensure that the source cluster is down (STONITH). When DC1 recovers, the cluster has to be converted to a standby cluster.
-
-Before doing that you may manually examine the database and extract all changes that happened between the time when network between DC1 and DC2 has stopped working and the time when you manually stopped the cluster in DC1.
-
-Once extracted, you may also manually apply these changes to the cluster in DC2.

docs/index.rst

@@ -6,13 +6,11 @@
 Introduction
 ============
 
-Patroni is a template for high availability (HA) PostgreSQL solutions using Python. For maximum accessibility, Patroni supports a variety of distributed configuration stores like `ZooKeeper <https://zookeeper.apache.org/>`__, `etcd <https://github.com/coreos/etcd>`__, `Consul <https://github.com/hashicorp/consul>`__ or `Kubernetes <https://kubernetes.io>`__. Database engineers, DBAs, DevOps engineers, and SREs who are looking to quickly deploy HA PostgreSQL in datacenters — or anywhere else — will hopefully find it useful.
+Patroni is a template for you to create your own customized, high-availability solution using Python and - for maximum accessibility - a distributed configuration store like `ZooKeeper <https://zookeeper.apache.org/>`__, `etcd <https://github.com/coreos/etcd>`__, `Consul <https://github.com/hashicorp/consul>`__ or `Kubernetes <https://kubernetes.io>`__. Database engineers, DBAs, DevOps engineers, and SREs who are looking to quickly deploy HA PostgreSQL in the datacenter-or anywhere else-will hopefully find it useful.
 
 We call Patroni a "template" because it is far from being a one-size-fits-all or plug-and-play replication system. It will have its own caveats. Use wisely. There are many ways to run high availability with PostgreSQL; for a list, see the `PostgreSQL Documentation <https://wiki.postgresql.org/wiki/Replication,_Clustering,_and_Connection_Pooling>`__.
 
-Currently supported PostgreSQL versions: 9.3 to 15.
-
-**Note to Citus users**: Starting from 3.0 Patroni nicely integrates with the `Citus <https://github.com/citusdata/citus>`__ database extension to Postgres. Please check the :ref:`Citus support page <citus>` in the Patroni documentation for more info about how to use Patroni high availability together with a Citus distributed cluster.
+Currently supported PostgreSQL versions: 9.3 to 14.
 
 **Note to Kubernetes users**: Patroni can run natively on top of Kubernetes. Take a look at the :ref:`Kubernetes <kubernetes>` chapter of the Patroni documentation.
 
@@ -22,31 +20,23 @@ Currently supported PostgreSQL versions: 9.3 to 15.
    :caption: Contents:
 
    README
-   patroni_configuration
+   dynamic_configuration
    rest_api
+   existing_data
+   ENVIRONMENT
+   SETTINGS
+   security
    replica_bootstrap
    replication_modes
-   watchdog
    pause
-   dcs_failsafe_mode
    kubernetes
-   citus
-   existing_data
-   security
-   ha_multi_dc
+   watchdog
    releases
    CONTRIBUTING
 
 Indices and tables
 ==================
 
-.. ifconfig:: builder == 'html'
-
-  * :ref:`genindex`
-  * :ref:`modindex`
-  * :ref:`search`
-
-.. ifconfig:: builder != 'html'
-
-  * :ref:`genindex`
-  * :ref:`search`
+* :ref:`genindex`
+* :ref:`modindex`
+* :ref:`search`

docs/kubernetes.rst

@@ -23,7 +23,10 @@ Use ConfigMaps
 In this mode, Patroni will create ConfigMaps instead of Endpoints and store keys inside meta-data of those ConfigMaps.
 Changing the leader takes at least two updates, one to the leader ConfigMap and another to the respective Endpoint.
 
-To direct the traffic to the Postgres leader you need to configure the Kubernetes Postgres service to use the label selector with the `role_label` (configured in patroni configuration).
+There are two ways to direct the traffic to the Postgres master:
+
+- use the `callback script <https://github.com/zalando/patroni/blob/master/kubernetes/callback.py>`_ provided by Patroni
+- configure the Kubernetes Postgres service to use the label selector with the `role_label` (configured in patroni configuration).
 
 Note that in some cases, for instance, when running on OpenShift, there is no alternative to using ConfigMaps.
 
@@ -32,63 +35,11 @@ Configuration
 
 Patroni Kubernetes :ref:`settings <kubernetes_settings>` and :ref:`environment variables <kubernetes_environment>` are described in the general chapters of the documentation.
 
-.. _kubernetes_role_values:
-
-Customize role label
-^^^^^^^^^^^^^^^^^^^^
-
-By default, Patroni will set corresponding labels on the pod it runs in based on node's role, such as ``role=master``.
-The key and value of label can be customized by `kubernetes.role_label`, `kubernetes.leader_label_value`, `kubernetes.follower_label_value` and `kubernetes.standby_leader_label_value`.
-
-Note that if you migrate from default role labels to custom ones, you can reduce downtime by following migration steps:
-
-1. Add a temporary label using original role value for the pod with `kubernetes.tmp_role_label` (like ``tmp_role``). Once pods are restarted they will get following labels set by Patroni:
-
-  .. code:: YAML
-
-    labels:
-      cluster-name: foo
-      role: master
-      tmp_role: master
-
-2. After all pods have been updated, modify the service selector to select the temporary label.
-
-  .. code:: YAML
-
-    selector:
-      cluster-name: foo
-      tmp_role: master
-
-3. Add your custom role label (e.g., set `kubernetes.leader_label_value=primary`). Once pods are restarted they will get following new labels set by Patroni:
-
-  .. code:: YAML
-
-    labels:
-      cluster-name: foo
-      role: primary
-      tmp_role: master
-
-4. After all pods have been updated again, modify the service selector to use new role value.
-
-  .. code:: YAML
-
-    selector:
-      cluster-name: foo
-      role: primary
-
-5. Finally, remove the temporary label from your configuration and update all pods.
-
-  .. code:: YAML
-
-    labels:
-      cluster-name: foo
-      role: primary
-
 Examples
 --------
 
 - The `kubernetes <https://github.com/zalando/patroni/tree/master/kubernetes>`__ folder of the Patroni repository contains
-  examples of the Docker image, and the Kubernetes manifest to test Patroni Kubernetes setup.
+  examples of the Docker image, the Kubernetes manifest and the callback script in order to test Patroni Kubernetes setup.
   Note that in the current state it will not be able to use PersistentVolumes because of permission issues.
 
 - You can find the full-featured Docker image that can use Persistent Volumes in the

docs/patroni_configuration.rst

@@ -1,108 +0,0 @@
-.. _patroni_configuration:
-
-Patroni configuration
-=====================
-
-.. toctree::
-   :hidden:
-
-   dynamic_configuration
-   yaml_configuration
-   ENVIRONMENT
-
-
-There are 3 types of Patroni configuration:
-
-- Global :ref:`dynamic configuration <dynamic_configuration>`.
-	These options are stored in the DCS (Distributed Configuration Store) and applied on all cluster nodes.
-	Dynamic configuration can be set at any time using ``patronictl edit-config`` tool or Patroni :ref:`REST API <rest_api>`.
-	If the options changed are not part of the startup configuration, they are applied asynchronously (upon the next wake up cycle)
-	to every node, which gets subsequently reloaded.
-	If the node requires a restart to apply the configuration (for `PostgreSQL parameters <https://www.postgresql.org/docs/current/view-pg-settings.html>`__ with context postmaster, if their values
-	have changed), a special flag ``pending_restart`` indicating this is set in the members.data JSON.
-	Additionally, the node status indicates this by showing ``"restart_pending": true``.
-
-- Local :ref:`configuration file <yaml_configuration>` (patroni.yml).
-	These options are defined in the configuration file and take precedence over dynamic configuration.
-	``patroni.yml`` can be changed and reloaded at runtime (without restart of Patroni) by sending SIGHUP to the Patroni process, performing ``POST /reload`` REST-API request or executing ``patronictl reload``. Local configuration can be either a single YAML file or a directory. When it is a directory, all YAML files in that directory are loaded one by one in sorted order. In case a key is defined in multiple files, the occurrence in the last file takes precedence.
-
-- :ref:`Environment configuration <environment>`.
-	It is possible to set/override some of the "Local" configuration parameters with environment variables.
-	Environment configuration is very useful when you are running in a dynamic environment and you don't know some of the parameters in advance (for example it's not possible to know your external IP address when you are running inside ``docker``).
-
-
-Important rules
----------------
-
-PostgreSQL parameters controlled by Patroni
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-Some of the PostgreSQL parameters **must hold the same values on the primary and the replicas**. For those, **values set either in the local patroni configuration files or via the environment variables take no effect**. To alter or set their values one must change the shared configuration in the DCS. Below is the actual list of such parameters together with the default values:
-
-- **max_connections**: 100
-- **max_locks_per_transaction**: 64
-- **max_worker_processes**: 8
-- **max_prepared_transactions**: 0
-- **wal_level**: hot_standby
-- **track_commit_timestamp**: off
-
-For the parameters below, PostgreSQL does not require equal values among the primary and all the replicas. However, considering the possibility of a replica to become the primary at any time, it doesn't really make sense to set them differently; therefore, **Patroni restricts setting their values to the** :ref:`dynamic configuration <dynamic_configuration>`.
-
-- **max_wal_senders**: 5
-- **max_replication_slots**: 5
-- **wal_keep_segments**: 8
-- **wal_keep_size**: 128MB
-
-These parameters are validated to ensure they are sane, or meet a minimum value.
-
-There are some other Postgres parameters controlled by Patroni:
-
-- **listen_addresses** - is set either from ``postgresql.listen`` or from ``PATRONI_POSTGRESQL_LISTEN`` environment variable
-- **port** - is set either from ``postgresql.listen`` or from ``PATRONI_POSTGRESQL_LISTEN`` environment variable
-- **cluster_name** - is set either from ``scope`` or from ``PATRONI_SCOPE`` environment variable
-- **hot_standby: on**
-- **wal_log_hints: on** - for Postgres 9.4 and newer.
-
-To be on the safe side parameters from the above lists are not written into ``postgresql.conf``, but passed as a list of arguments to the ``pg_ctl start`` which gives them the highest precedence, even above `ALTER SYSTEM <https://www.postgresql.org/docs/current/static/sql-altersystem.html>`__
-
-There also are some parameters like **postgresql.listen**, **postgresql.data_dir** that **can be set only locally**, i.e. in the Patroni :ref:`config file <yaml_configuration>` or via :ref:`configuration <environment>` variable. In most cases the local configuration will override the dynamic configuration.
-
-
-When applying the local or dynamic configuration options, the following actions are taken:
-
-- The node first checks if there is a `postgresql.base.conf` or if the ``custom_conf`` parameter is set.
-- If the ``custom_conf`` parameter is set, it will take the file specified on it as a base configuration, ignoring `postgresql.base.conf` and `postgresql.conf`.
-- If the ``custom_conf`` parameter is not set and `postgresql.base.conf` exists, it contains the renamed "original" configuration and it will be used as a base configuration.
-- If there is no ``custom_conf``` nor `postgresql.base.conf`, the original `postgresql.conf`` is taken and renamed to postgresql.base.conf.
-- The dynamic options (with the exceptions above) are dumped into the `postgresql.conf`` and an include is set in
-  postgresql.conf to the used base configuration (either `postgresql.base.conf` or what is on ``custom_conf``). Therefore, we would be able to apply new options without re-reading the configuration file to check if the include is present not.
-- Some parameters that are essential for Patroni to manage the cluster are overridden using the command line.
-- If some of the options that require restart are changed (we should look at the context in pg_settings and at the actual
-  values of those options), a pending_restart flag of a given node is set. This flag is reset on any restart.
-
-The parameters would be applied in the following order (run-time are given the highest priority):
-
-1. load parameters from file `postgresql.base.conf` (or from a ``custom_conf`` file, if set)
-2. load parameters from file `postgresql.conf`
-3. load parameters from file `postgresql.auto.conf`
-4. run-time parameter using `-o --name=value`
-
-This allows configuration for all the nodes (2), configuration for a specific node using ``ALTER SYSTEM`` (3) and ensures that parameters essential to the running of Patroni are enforced (4), as well as leaves room for configuration tools that manage `postgresql.conf` directly without involving Patroni (1).
-
-
-Patroni configuration parameters
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-Also the following Patroni configuration options **can be changed only dynamically**:
-
-- **ttl**: 30
-- **loop_wait**: 10
-- **retry_timeouts**: 10
-- **maximum_lag_on_failover**: 1048576
-- **max_timelines_history**: 0
-- **check_timeline**: false
-- **postgresql.use_slots**: true
-
-Upon changing these options, Patroni will read the relevant section of the configuration stored in DCS and change its run-time values.
-
-Patroni nodes are dumping the state of the DCS options to disk upon for every change of the configuration into the file ``patroni.dynamic.json`` located in the Postgres data directory. Only the leader is allowed to restore these options from the on-disk dump if these are completely absent from the DCS or if they are invalid.

docs/pause.rst

@@ -6,7 +6,7 @@ Pause/Resume mode for the cluster
 The goal
 --------
 
-Under certain circumstances Patroni needs to temporarily step down from managing the cluster, while still retaining the cluster state in DCS. Possible use cases are uncommon activities on the cluster, such as major version upgrades or corruption recovery. During those activities nodes are often started and stopped for reasons unknown to Patroni, some nodes can be even temporarily promoted, violating the assumption of running only one primary. Therefore, Patroni needs to be able to "detach" from the running cluster, implementing an equivalent of the maintenance mode in Pacemaker.
+Under certain circumstances Patroni needs to temporary step down from managing the cluster, while still retaining the cluster state in DCS. Possible use cases are uncommon activities on the cluster, such as major version upgrades or corruption recovery. During those activities nodes are often started and stopped for the reason unknown to Patroni, some nodes can be even temporary promoted, violating the assumption of running only one master. Therefore, Patroni needs to be able to "detach" from the running cluster, implementing an equivalent of the maintenance mode in Pacemaker.
 
 
 
@@ -17,18 +17,16 @@ When Patroni runs in a paused mode, it does not change the state of PostgreSQL,
 
 - For each node, the member key in DCS is updated with the current information about the cluster. This causes Patroni to run read-only queries on a member node if the member is running.
 
-- For the Postgres primary with the leader lock Patroni updates the lock. If the node with the leader lock stops being the primary (i.e. is demoted manually), Patroni will release the lock instead of promoting the node back.
+- For the Postgres master with the leader lock Patroni updates the lock. If the node with the leader lock stops being the master (i.e. is demoted manually), Patroni will release the lock instead of promoting the node back.
 
-- Manual unscheduled restart, manual unscheduled failover/switchover and reinitialize are allowed. No scheduled action is allowed. Manual switchover is only allowed if the node to switchover to is specified.
+- Manual unscheduled restart, reinitialize and manual failover are allowed. Manual failover is only allowed if the node to failover to is specified. In the paused mode, manual failover does not require a running master node.
 
-- If 'parallel' primaries are detected by Patroni, it emits a warning, but does not demote the primary without the leader lock.
+- If 'parallel' masters are detected by Patroni, it emits a warning, but does not demote the masters without the leader lock.
 
-- If there is no leader lock in the cluster, the running primary acquires the lock. If there is more than one primary node, then the first primary to acquire the lock wins. If there are no primary altogether, Patroni does not try to promote any replicas. There is an exception in this rule: if there is no leader lock because the old primary has demoted itself due to the manual promotion, then only the candidate node mentioned in the promotion request may take the leader lock. When the new leader lock is granted (i.e. after promoting a replica manually), Patroni makes sure the replicas that were streaming from the previous leader will switch to the new one.
+- If there is no leader lock in the cluster, the running master acquires the lock. If there is more than one master node, then the first master to acquire the lock wins. If there are no masters altogether, Patroni does not try to promote any replicas. There is an exception in this rule: if there is no leader lock because the old master has demoted itself due to the manual promotion, then only the candidate node mentioned in the promotion request may take the leader lock. When the new leader lock is granted (i.e. after promoting a replica manually), Patroni makes sure the replicas that were streaming from the previous leader will switch to the new one.
 
 - When Postgres is stopped, Patroni does not try to start it. When Patroni is stopped, it does not try to stop the Postgres instance it is managing.
 
-- Patroni will not try to remove replication slots that don't represent the other cluster member or are not listed in the configuration of the permanent slots.
-
 User guide
 ----------
 

docs/replica_bootstrap.rst

@@ -63,7 +63,7 @@ Building replicas
 -----------------
 
 Patroni uses tried and proven ``pg_basebackup`` in order to create new replicas. One downside of it is that it requires
-a running leader node. Another one is the lack of 'on-the-fly' compression for the backup data and no built-in cleanup
+a running master node. Another one is the lack of 'on-the-fly' compression for the backup data and no built-in cleanup
 for outdated backup files. Some people prefer other backup solutions, such as ``WAL-E``, ``pgBackRest``, ``Barman`` and
 others, or simply roll their own scripts. In order to accommodate all those use-cases Patroni supports running custom
 scripts to clone a new replica. Those are configured in the ``postgresql`` configuration block:
@@ -77,7 +77,7 @@ scripts to clone a new replica. Those are configured in the ``postgresql`` confi
             command: <command name>
             keep_data: True
             no_params: True
-            no_leader: 1
+            no_master: 1
 
 example: wal_e
 
@@ -89,7 +89,7 @@ example: wal_e
             - basebackup
         wal_e:
             command: patroni_wale_restore
-            no_leader: 1
+            no_master: 1
             envdir: {{WALE_ENV_DIR}}
             use_iam: 1
         basebackup:
@@ -123,11 +123,11 @@ to execute and any custom parameters that should be passed to that command. All
 --role
     Always 'replica'
 --connstring
-    Connection string to connect to the cluster member to clone from (primary or other replica). The user in the
+    Connection string to connect to the cluster member to clone from (master or other replica). The user in the
     connection string can execute SQL and replication protocol commands.
 
-A special ``no_leader`` parameter, if defined, allows Patroni to call the replica creation method even if there is no
-running leader or replicas. In that case, an empty string will be passed in a connection string. This is useful for
+A special ``no_master`` parameter, if defined, allows Patroni to call the replica creation method even if there is no
+running master or replicas. In that case, an empty string will be passed in a connection string. This is useful for
 restoring the formerly running cluster from the binary backup.
 
 A special ``keep_data`` parameter, if defined, will instruct Patroni to  not clean PGDATA folder before calling restore.
@@ -137,7 +137,7 @@ A special ``no_params`` parameter, if defined, restricts passing parameters to c
 A ``basebackup`` method is a special case: it will be used if
 ``create_replica_methods`` is empty, although it is possible
 to list it explicitly among the ``create_replica_methods`` methods. This method initializes a new replica with the
-``pg_basebackup``, the base backup is taken from the leader unless there are replicas with ``clonefrom`` tag, in which case one
+``pg_basebackup``, the base backup is taken from the master unless there are replicas with ``clonefrom`` tag, in which case one
 of such replicas will be used as the origin for pg_basebackup. It works without any configuration; however, it is
 possible to specify a ``basebackup`` configuration section. Same rules as with the other method configuration apply,
 namely, only long (with --) options should be specified there. Not all parameters make sense, if you override a connection
@@ -176,10 +176,10 @@ Standby cluster
 ---------------
 
 Another available option is to run a "standby cluster", that contains only of
-standby nodes replicating from some remote node. This type of clusters has:
+standby nodes replicating from some remote master. This type of clusters has:
 
 * "standby leader", that behaves pretty much like a regular cluster leader,
-  except it replicates from a remote node.
+  except it replicates from a remote master.
 
 * cascade replicas, that are replicating from standby leader.
 
@@ -187,13 +187,6 @@ Standby leader holds and updates a leader lock in DCS. If the leader lock
 expires, cascade replicas will perform an election to choose another leader
 from the standbys.
 
-There is no further relationship between the standby cluster and the primary
-cluster it replicates from, in particular, they must not share the same DCS
-scope if they use the same DCS. They do not know anything else from each other
-apart from replication information. Also, the standby cluster is not being
-displayed in ``patronictl list`` or ``patronictl topology`` output on the
-primary cluster.
-
 For the sake of flexibility, you can specify methods of creating a replica and
 recovery WAL records when a cluster is in the "standby mode" by providing
 `create_replica_methods` key in `standby_cluster` section. It is distinct from
@@ -219,9 +212,4 @@ in a patroni configuration:
 Note, that these options will be applied only once during cluster bootstrap,
 and the only way to change them afterwards is through DCS.
 
-Patroni expects to find `postgresql.conf` or `postgresql.conf.backup` in PGDATA
-of the remote primary and will not start if it does not find it after a
-basebackup. If the remote primary keeps its `postgresql.conf` elsewhere, it is
-your responsibility to copy it to PGDATA.
-
 If you use replication slots on the standby cluster, you must also create the corresponding replication slot on the primary cluster.  It will not be done automatically by the standby cluster implementation.  You can use Patroni's permanent replication slots feature on the primary cluster to maintain a replication slot with the same name as ``primary_slot_name``, or its default value if ``primary_slot_name`` is not provided.

docs/replication_modes.rst

@@ -13,7 +13,7 @@ In asynchronous mode the cluster is allowed to lose some committed transactions
 
 The amount of transactions that can be lost is controlled via ``maximum_lag_on_failover`` parameter. Because the primary transaction log position is not sampled in real time, in reality the amount of lost data on failover is worst case bounded by  ``maximum_lag_on_failover`` bytes of transaction log plus the amount that is written in the last ``ttl`` seconds (``loop_wait``/2 seconds in the average case). However typical steady state replication delay is well under a second.
 
-By default, when running leader elections, Patroni does not take into account the current timeline of replicas, what in some cases could be undesirable behavior. You can prevent the node not having the same timeline as a former primary become the new leader by changing the value of ``check_timeline`` parameter to ``true``.
+By default, when running leader elections, Patroni does not take into account the current timeline of replicas, what in some cases could be undesirable behavior. You can prevent the node not having the same timeline as a former master become the new leader by changing the value of ``check_timeline`` parameter to ``true``.
 
 PostgreSQL synchronous replication
 ----------------------------------
@@ -49,7 +49,7 @@ on at least two nodes, enable ``synchronous_mode_strict`` in addition to the
 ``synchronous_mode``. This parameter prevents Patroni from switching off the
 synchronous replication on the primary when no synchronous standby candidates
 are available. As a downside, the primary is not be available for writes
-(unless the Postgres transaction explicitly turns off ``synchronous_mode``),
+(unless the Postgres transaction explicitly turns of ``synchronous_mode``),
 blocking all client write requests until at least one synchronous replica comes
 up.
 

docs/rest_api.rst

@@ -7,11 +7,12 @@ Patroni has a rich REST API, which is used by Patroni itself during the leader r
 
 Health check endpoints
 ----------------------
-For all health check ``GET`` requests Patroni returns a JSON document with the status of the node, along with the HTTP status code. If you don't want or don't need the JSON document, you might consider using the ``HEAD`` or ``OPTIONS`` method instead of ``GET``.
+For all health check ``GET`` requests Patroni returns a JSON document with the status of the node, along with the HTTP status code. If you don't want or don't need the JSON document, you might consider using the ``OPTIONS`` method instead of ``GET``.
 
 - The following requests to Patroni REST API will return HTTP status code **200** only when the Patroni node is running as the primary with leader lock:
 
   - ``GET /``
+  - ``GET /master``
   - ``GET /primary``
   - ``GET /read-write``
 
@@ -30,9 +31,9 @@ For all health check ``GET`` requests Patroni returns a JSON document with the s
 
 - ``GET /replica?tag_key1=value1&tag_key2=value2``: replica check endpoint. In addition, It will also check for user defined tags ``key1`` and ``key2`` and their respective values in the **tags** section of the yaml configuration management. If the tag isn't defined for an instance, or if the value in the yaml configuration doesn't match the querying value, it will return HTTP Status Code 503.
 
-  In the following requests, since we are checking for the leader or standby-leader status, Patroni doesn't apply any of the user defined tags and they will be ignored.
-
+ In the following requests, since we are checking for the leader or standby-leader status, Patroni doesn't apply any of the user defined tags and they will be ignored.
   - ``GET /?tag_key1=value1&tag_key2=value2``
+  - ``GET /master?tag_key1=value1&tag_key2=value2``
   - ``GET /leader?tag_key1=value1&tag_key2=value2``
   - ``GET /primary?tag_key1=value1&tag_key2=value2``
   - ``GET /read-write?tag_key1=value1&tag_key2=value2``
@@ -57,7 +58,7 @@ For all health check ``GET`` requests Patroni returns a JSON document with the s
 
 - ``GET /health``: returns HTTP status code **200** only when PostgreSQL is up and running.
 
-- ``GET /liveness``: returns HTTP status code **200** if Patroni heartbeat loop is properly running and **503** if the last run was more than ``ttl`` seconds ago on the primary or ``2*ttl`` on the replica. Could be used for ``livenessProbe``.
+- ``GET /liveness``: always returns HTTP status code **200** what only indicates that Patroni is running. Could be used for ``livenessProbe``.
 
 - ``GET /readiness``: returns HTTP status code **200** when the Patroni node is running as the leader or when PostgreSQL is up and running. The endpoint could be used for ``readinessProbe`` when it is not possible to use Kubernetes endpoints for leader elections (OpenShift).
 
@@ -92,259 +93,26 @@ Monitoring endpoint
 
 The ``GET /patroni`` is used by Patroni during the leader race. It also could be used by your monitoring system. The JSON document produced by this endpoint has the same structure as the JSON produced by the health check endpoints.
 
-**Example:** A healthy cluster
-
 .. code-block:: bash
 
     $ curl -s http://localhost:8008/patroni | jq .
     {
       "state": "running",
-      "postmaster_start_time": "2023-08-18 11:03:37.966359+00:00",
+      "postmaster_start_time": "2019-09-24 09:22:32.555 CEST",
       "role": "master",
-      "server_version": 150004,
+      "server_version": 110005,
+      "cluster_unlocked": false,
       "xlog": {
-        "location": 67395656
+        "location": 25624640
       },
-      "timeline": 1,
-      "replication": [
-        {
-          "usename": "replicator",
-          "application_name": "patroni2",
-          "client_addr": "10.89.0.6",
-          "state": "streaming",
-          "sync_state": "async",
-          "sync_priority": 0
-        },
-        {
-          "usename": "replicator",
-          "application_name": "patroni3",
-          "client_addr": "10.89.0.2",
-          "state": "streaming",
-          "sync_state": "async",
-          "sync_priority": 0
-        }
-      ],
-      "dcs_last_seen": 1692356718,
-      "tags": {
-        "clonefrom": true
-      },
-      "database_system_identifier": "7268616322854375442",
+      "timeline": 3,
+      "database_system_identifier": "6739877027151648096",
       "patroni": {
-        "version": "3.1.0",
-        "scope": "demo"
+        "version": "1.6.0",
+        "scope": "batman"
       }
     }
 
-**Example:** An unlocked cluster
-
-.. code-block:: bash
-
-    $ curl -s http://localhost:8008/patroni  | jq .
-    {
-      "state": "running",
-      "postmaster_start_time": "2023-08-18 11:09:08.615242+00:00",
-      "role": "replica",
-      "server_version": 150004,
-      "xlog": {
-        "received_location": 67419744,
-        "replayed_location": 67419744,
-        "replayed_timestamp": null,
-        "paused": false
-      },
-      "timeline": 1,
-      "replication": [
-        {
-          "usename": "replicator",
-          "application_name": "patroni2",
-          "client_addr": "10.89.0.6",
-          "state": "streaming",
-          "sync_state": "async",
-          "sync_priority": 0
-        },
-        {
-          "usename": "replicator",
-          "application_name": "patroni3",
-          "client_addr": "10.89.0.2",
-          "state": "streaming",
-          "sync_state": "async",
-          "sync_priority": 0
-        }
-      ],
-      "cluster_unlocked": true,
-      "dcs_last_seen": 1692356928,
-      "tags": {
-        "clonefrom": true
-      },
-      "database_system_identifier": "7268616322854375442",
-      "patroni": {
-        "version": "3.1.0",
-        "scope": "demo"
-      }
-    }
-
-**Example:** An unlocked cluster with :ref:`DCS failsafe mode <dcs_failsafe_mode>` enabled
-
-.. code-block:: bash
-
-    $ curl -s http://localhost:8008/patroni  | jq .
-    {
-      "state": "running",
-      "postmaster_start_time": "2023-08-18 11:09:08.615242+00:00",
-      "role": "replica",
-      "server_version": 150004,
-      "xlog": {
-        "location": 67420024
-      },
-      "timeline": 1,
-      "replication": [
-        {
-          "usename": "replicator",
-          "application_name": "patroni2",
-          "client_addr": "10.89.0.6",
-          "state": "streaming",
-          "sync_state": "async",
-          "sync_priority": 0
-        },
-        {
-          "usename": "replicator",
-          "application_name": "patroni3",
-          "client_addr": "10.89.0.2",
-          "state": "streaming",
-          "sync_state": "async",
-          "sync_priority": 0
-        }
-      ],
-      "cluster_unlocked": true,
-      "failsafe_mode_is_active": true,
-      "dcs_last_seen": 1692356928,
-      "tags": {
-        "clonefrom": true
-      },
-      "database_system_identifier": "7268616322854375442",
-      "patroni": {
-        "version": "3.1.0",
-        "scope": "demo"
-      }
-    }
-
-**Example:** A cluster with the :ref:`pause mode <pause>` enabled
-
-.. code-block:: bash
-
-    $ curl -s http://localhost:8008/patroni  | jq .
-    {
-      "state": "running",
-      "postmaster_start_time": "2023-08-18 11:09:08.615242+00:00",
-      "role": "replica",
-      "server_version": 150004,
-      "xlog": {
-        "location": 67420024
-      },
-      "timeline": 1,
-      "replication": [
-        {
-          "usename": "replicator",
-          "application_name": "patroni2",
-          "client_addr": "10.89.0.6",
-          "state": "streaming",
-          "sync_state": "async",
-          "sync_priority": 0
-        },
-        {
-          "usename": "replicator",
-          "application_name": "patroni3",
-          "client_addr": "10.89.0.2",
-          "state": "streaming",
-          "sync_state": "async",
-          "sync_priority": 0
-        }
-      ],
-      "pause": true,
-      "dcs_last_seen": 1692356928,
-      "tags": {
-        "clonefrom": true
-      },
-      "database_system_identifier": "7268616322854375442",
-      "patroni": {
-        "version": "3.1.0",
-        "scope": "demo"
-      }
-    }
-
-Retrieve the Patroni metrics in Prometheus format through the ``GET /metrics`` endpoint.
-
-.. code-block:: bash
-
-	$ curl http://localhost:8008/metrics
-	
-	# HELP patroni_version Patroni semver without periods. \
-	# TYPE patroni_version gauge
-	patroni_version{scope="batman"} 020103
-	# HELP patroni_postgres_running Value is 1 if Postgres is running, 0 otherwise.
-	# TYPE patroni_postgres_running gauge
-	patroni_postgres_running{scope="batman"} 1
-	# HELP patroni_postmaster_start_time Epoch seconds since Postgres started.
-	# TYPE patroni_postmaster_start_time gauge
-	patroni_postmaster_start_time{scope="batman"} 1657656955.179243
-	# HELP patroni_master Value is 1 if this node is the leader, 0 otherwise.
-	# TYPE patroni_master gauge
-	patroni_master{scope="batman"} 1
-	# HELP patroni_primary Value is 1 if this node is the leader, 0 otherwise.
-	# TYPE patroni_primary gauge
-	patroni_primary{scope="batman"} 1
-	# HELP patroni_xlog_location Current location of the Postgres transaction log, 0 if this node is not the leader.
-	# TYPE patroni_xlog_location counter
-	patroni_xlog_location{scope="batman"} 22320573386952
-	# HELP patroni_standby_leader Value is 1 if this node is the standby_leader, 0 otherwise.
-	# TYPE patroni_standby_leader gauge
-	patroni_standby_leader{scope="batman"} 0
-	# HELP patroni_replica Value is 1 if this node is a replica, 0 otherwise.
-	# TYPE patroni_replica gauge
-	patroni_replica{scope="batman"} 0
-	# HELP patroni_sync_standby Value is 1 if this node is a sync standby replica, 0 otherwise.
-	# TYPE patroni_sync_standby gauge
-	patroni_sync_standby{scope="batman"} 0
-	# HELP patroni_xlog_received_location Current location of the received Postgres transaction log, 0 if this node is not a replica.
-	# TYPE patroni_xlog_received_location counter
-	patroni_xlog_received_location{scope="batman"} 0
-	# HELP patroni_xlog_replayed_location Current location of the replayed Postgres transaction log, 0 if this node is not a replica.
-	# TYPE patroni_xlog_replayed_location counter
-	patroni_xlog_replayed_location{scope="batman"} 0
-	# HELP patroni_xlog_replayed_timestamp Current timestamp of the replayed Postgres transaction log, 0 if null.
-	# TYPE patroni_xlog_replayed_timestamp gauge
-	patroni_xlog_replayed_timestamp{scope="batman"} 0
-	# HELP patroni_xlog_paused Value is 1 if the Postgres xlog is paused, 0 otherwise.
-	# TYPE patroni_xlog_paused gauge
-	patroni_xlog_paused{scope="batman"} 0
-	# HELP patroni_postgres_streaming Value is 1 if Postgres is streaming, 0 otherwise.
-	# TYPE patroni_postgres_streaming gauge
-	patroni_postgres_streaming{scope="batman"} 1
-	# HELP patroni_postgres_in_archive_recovery Value is 1 if Postgres is replicating from archive, 0 otherwise.
-	# TYPE patroni_postgres_in_archive_recovery gauge
-	patroni_postgres_in_archive_recovery{scope="batman"} 0
-	# HELP patroni_postgres_server_version Version of Postgres (if running), 0 otherwise.
-	# TYPE patroni_postgres_server_version gauge
-	patroni_postgres_server_version {scope="batman"} 140004
-	# HELP patroni_cluster_unlocked Value is 1 if the cluster is unlocked, 0 if locked.
-	# TYPE patroni_cluster_unlocked gauge
-	patroni_cluster_unlocked{scope="batman"} 0
-	# HELP patroni_postgres_timeline Postgres timeline of this node (if running), 0 otherwise.
-	# TYPE patroni_postgres_timeline counter
-	patroni_failsafe_mode_is_active{scope="batman"} 0
-	# HELP patroni_postgres_timeline Postgres timeline of this node (if running), 0 otherwise.
-	# TYPE patroni_postgres_timeline counter
-	patroni_postgres_timeline{scope="batman"} 24
-	# HELP patroni_dcs_last_seen Epoch timestamp when DCS was last contacted successfully by Patroni.
-	# TYPE patroni_dcs_last_seen gauge
-	patroni_dcs_last_seen{scope="batman"} 1677658321
-	# HELP patroni_pending_restart Value is 1 if the node needs a restart, 0 otherwise.
-	# TYPE patroni_pending_restart gauge
-	patroni_pending_restart{scope="batman"} 1
-	# HELP patroni_is_paused Value is 1 if auto failover is disabled, 0 otherwise.
-	# TYPE patroni_is_paused gauge
-	patroni_is_paused{scope="batman"} 1
-
-
 Cluster status endpoints
 ------------------------
 
@@ -356,24 +124,24 @@ Cluster status endpoints
     {
       "members": [
         {
-          "name": "patroni1",
+          "name": "postgresql0",
+          "host": "127.0.0.1",
+          "port": 5432,
           "role": "leader",
           "state": "running",
-          "api_url": "http://10.89.0.4:8008/patroni",
-          "host": "10.89.0.4",
-          "port": 5432,
+          "api_url": "http://127.0.0.1:8008/patroni",
           "timeline": 5,
           "tags": {
             "clonefrom": true
           }
         },
         {
-          "name": "patroni2",
-          "role": "replica",
-          "state": "streaming",
-          "api_url": "http://10.89.0.6:8008/patroni",
-          "host": "10.89.0.6",
+          "name": "postgresql1",
+          "host": "127.0.0.1",
           "port": 5433,
+          "role": "replica",
+          "state": "running",
+          "api_url": "http://127.0.0.1:8009/patroni",
           "timeline": 5,
           "tags": {
             "clonefrom": true
@@ -382,9 +150,8 @@ Cluster status endpoints
         }
       ],
       "scheduled_switchover": {
-        "at": "2023-09-24T10:36:00+02:00",
-        "from": "patroni1",
-        "to": "patroni3"
+        "at": "2019-09-24T10:36:00+02:00",
+        "from": "postgresql0"
       }
     }
 
@@ -429,7 +196,7 @@ Config endpoint
 
 .. code-block:: bash
 
-	$ curl -s http://localhost:8008/config | jq .
+	$ curl -s localhost:8008/config | jq .
 	{
 	  "ttl": 30,
 	  "loop_wait": 10,
@@ -440,6 +207,7 @@ Config endpoint
 	    "use_pg_rewind": true,
 	    "parameters": {
 	      "hot_standby": "on",
+	      "wal_log_hints": "on",
 	      "wal_level": "hot_standby",
 	      "max_wal_senders": 5,
 	      "max_replication_slots": 5,
@@ -466,6 +234,7 @@ Config endpoint
 	    "use_pg_rewind": true,
 	    "parameters": {
 	      "hot_standby": "on",
+	      "wal_log_hints": "on",
 	      "wal_level": "hot_standby",
 	      "max_wal_senders": 5,
 	      "max_replication_slots": 5,
@@ -518,6 +287,7 @@ If you want to remove (reset) some setting just patch it with ``null``:
 	      "hot_standby": "on",
 	      "unix_socket_directories": ".",
 	      "wal_level": "hot_standby",
+	      "wal_log_hints": "on",
 	      "max_wal_senders": 5,
 	      "max_replication_slots": 5
 	    }
@@ -531,7 +301,7 @@ The above call removes ``postgresql.parameters.max_connections`` from the dynami
 .. code-block:: bash
 
 	$ curl -s -XPUT -d \
-		'{"maximum_lag_on_failover":1048576,"retry_timeout":10,"postgresql":{"use_slots":true,"use_pg_rewind":true,"parameters":{"hot_standby":"on","wal_level":"hot_standby","unix_socket_directories":".","max_wal_senders":5}},"loop_wait":3,"ttl":20}' \
+		'{"maximum_lag_on_failover":1048576,"retry_timeout":10,"postgresql":{"use_slots":true,"use_pg_rewind":true,"parameters":{"hot_standby":"on","wal_log_hints":"on","wal_level":"hot_standby","unix_socket_directories":".","max_wal_senders":5}},"loop_wait":3,"ttl":20}' \
 		http://localhost:8008/config | jq .
 	{
 	  "ttl": 20,
@@ -543,6 +313,7 @@ The above call removes ``postgresql.parameters.max_connections`` from the dynami
 	      "hot_standby": "on",
 	      "unix_socket_directories": ".",
 	      "wal_level": "hot_standby",
+	      "wal_log_hints": "on",
 	      "max_wal_senders": 5
 	    },
 	    "use_pg_rewind": true
@@ -554,111 +325,39 @@ The above call removes ``postgresql.parameters.max_connections`` from the dynami
 Switchover and failover endpoints
 ---------------------------------
 
-.. _switchover_api:
+``POST /switchover`` or ``POST /failover``. These endpoints are very similar to each other. There are a couple of minor differences though:
 
-Switchover
-^^^^^^^^^^
+1. The failover endpoint allows to perform a manual failover when there are no healthy nodes, but at the same time it will not allow you to schedule a switchover.
 
-``/switchover`` endpoint only works when cluster is healthy (there is a leader). It allows to schedule a switchover at a given time.
+2. The switchover endpoint is the opposite. It works only when the cluster is healthy (there is a leader) and allows to schedule a switchover at a given time.
 
-When calling ``/switchover`` endpoint candidate can be specified but is not required, in contrast to ``/failover`` endpoint. If candidate is not provided, all the healthy nodes that are allowed to failover participate in the leader race.
 
-In the JSON body of the ``POST`` request, you must specify at least the ``leader`` field and, optionally, the ``candidate`` and ``scheduled_at`` field if you want to schedule a switchover at a specific time.
+In the JSON body of the ``POST`` request you must specify at least the ``leader`` or ``candidate`` fields and optionally the ``scheduled_at`` field if you want to schedule a switchover at a specific time.
 
-Depending on the situation, requests might return different HTTP status codes and bodies. Status code **200** is returned when the switchover or failover successfully completed. If the switchover was successfully scheduled, Patroni will return HTTP status code **202**. In case something went wrong, the error status code (one of **400**, **412**, or **503**) will be returned with some details in the response body.
 
-``DELETE /switchover`` can be used to delete the currently scheduled switchover.
-
-**Example:** perform a switchover to any healthy standby
+Example: perform a failover to the specific node:
 
 .. code-block:: bash
 
-	$ curl -s http://localhost:8008/switchover -XPOST -d '{"leader":"postgresql1"}'
-	Successfully switched over to "postgresql2"
+    $ curl -s http://localhost:8009/failover -XPOST -d '{"candidate":"postgresql1"}'
+    Successfully failed over to "postgresql1"
 
 
-**Example:** perform a switchover to a specific node
+Example: schedule a switchover from the leader to any other healthy replica in the cluster at a specific time:
 
 .. code-block:: bash
 
-	$ curl -s http://localhost:8008/switchover -XPOST -d \
-		'{"leader":"postgresql1","candidate":"postgresql2"}'
-	Successfully switched over to "postgresql2"
+    $ curl -s http://localhost:8008/switchover -XPOST -d \
+	    '{"leader":"postgresql0","scheduled_at":"2019-09-24T12:00+00"}'
+    Switchover scheduled
 
 
-**Example:** schedule a switchover from the leader to any other healthy standby in the cluster at a specific time.
+Depending on the situation the request might finish with a different HTTP status code and body. The status code **200** is returned when the switchover or failover successfully completed. If the switchover was successfully scheduled, Patroni will return HTTP status code **202**. In case something went wrong, the error status code (one of **400**, **412** or **503**) will be returned with some details in the response body. For more information please check the source code of ``patroni/api.py:do_POST_failover()`` method.
 
-.. code-block:: bash
+- ``DELETE /switchover``: delete the scheduled switchover
 
-	$ curl -s http://localhost:8008/switchover -XPOST -d \
-		'{"leader":"postgresql0","scheduled_at":"2019-09-24T12:00+00"}'
-	Switchover scheduled
-
-
-Failover
-^^^^^^^^
-
-``/failover`` endpoint can be used to perform a manual failover when there are no healthy nodes (e.g. to an asynchronous standby if all synchronous standbys are not healthy enough to promote). However there is no requirement for a cluster not to have leader - failover can also be run on a healthy cluster.
-
-In the JSON body of the ``POST`` request you must specify ``candidate`` field. If ``leader`` field is specified, switchover is triggered. 
-
-**Example:**
-
-.. code-block:: bash
-
-	$ curl -s http://localhost:8008/failover -XPOST -d '{"candidate":"postgresql1"}'
-	Successfully failed over to "postgresql1"
-
-.. warning::
-	:ref:`Be very careful <failover_healthcheck>` using this endpoint, as this can cause data loss in certain situations. In most cases, :ref:`the switchover endpoint <switchover_api>` satisfies the administrator's needs. 
-
-
-``POST /switchover`` and ``POST /failover`` endpoints are used by ``patronictl switchover`` and ``patronictl failover``, respectively.
-
-``DELETE /switchover`` is used by ``patronictl flush <cluster-name> switchover``.
-
-.. list-table:: Failover/Switchover comparison
-   :widths: 25 25 25
-   :header-rows: 1
-
-   * -
-     - Failover
-     - Switchover
-   * - Requires leader specified
-     - no
-     - yes
-   * - Requires candidate specified
-     - yes
-     - no
-   * - Can be run in pause
-     - yes
-     - yes (only to a specific candidate)
-   * - Can be scheduled
-     - no
-     - yes (if not in pause)
-
-.. _failover_healthcheck:
-
-Healthy standby
-^^^^^^^^^^^^^^^
-
-There are a couple of checks that a member of a cluster should pass to be able to participate in the leader race during a switchover or to become a leader as a failover/switchover candidate:
-
-- be reachable via Patroni API,
-- not have ``nofailover`` tag set to ``true``,
-- have watchdog fully functional (if required by the configuration),
-- in case of a switchover or a failover in a healthy cluster, not exceed maximum replication lag (``maximum_lag_on_failover`` :ref:`configuration parameter <dynamic_configuration>`),
-- in case of a switchover or a failover in a healthy cluster, not have a timeline number smaller than the cluster timeline,
-- in :ref:`synchronous mode <synchronous_mode>`:
-
-  - In case of a switchover (both with and without a candidate): be listed in the ``/sync`` key members.
-  - For a failover in both healthy and unhealthy clusters, this check is omitted.
-
-.. warning::
-    In case of a failover in a cluster without a leader, a candidate will be allowed to promote even if:
-	- it is not in the ``/sync`` key members when synchronous mode is enabled,
-	- its lag exceeds the maximum replication lag allowed,
-	- it has the timeline number smaller than the cluster timeline.
+The ``POST /switchover`` and ``POST failover`` endpoints are used by ``patronictl switchover`` and ``patronictl failover``, respectively.
+The ``DELETE /switchover`` is used by ``patronictl flush <cluster-name> switchover``.
 
 
 Restart endpoint
@@ -669,7 +368,7 @@ Restart endpoint
   - **restart_pending**: boolean, if set to ``true`` Patroni will restart PostgreSQL only when restart is pending in order to apply some changes in the PostgreSQL config.
   - **role**: perform restart only if the current role of the node matches with the role from the POST request.
   - **postgres_version**: perform restart only if the current version of postgres is smaller than specified in the POST request.
-  - **timeout**: how long we should wait before PostgreSQL starts accepting connections. Overrides ``primary_start_timeout``.
+  - **timeout**: how long we should wait before PostgreSQL starts accepting connections. Overrides ``master_start_timeout``.
   - **schedule**: timestamp with time zone, schedule the restart somewhere in the future.
 
 - ``DELETE /restart``: delete the scheduled restart

docs/security.rst

@@ -9,11 +9,11 @@ A Patroni cluster has two interfaces to be protected from unauthorized access: t
 Protecting DCS
 ==============
 
-Patroni and patronictl both store and retrieve data to/from the DCS.
+Patroni and patronictl both store and retrieve data to/from the DCS. 
 
 Despite DCS doesn't contain any sensitive information, it allows changing some of Patroni/Postgres configuration. Therefore the very first thing that should be protected is DCS itself.
 
-The details of protection depend on the type of DCS used. The authentication and encryption parameters (tokens/basic-auth/client certificates) for the supported types of DCS are covered in :ref:`settings <yaml_configuration>`.
+The details of protection depend on the type of DCS used. The authentication and encryption parameters (tokens/basic-auth/client certificates) for the supported types of DCS are covered in :ref:`SETTINGS <bootstrap_settings>` 
 
 The general recommendation is to enable TLS for all DCS communication.
 
@@ -22,7 +22,7 @@ Protecting the REST API
 
 Protecting the REST API is a more complicated task.
 
-The Patroni REST API is used by Patroni itself during the leader race, by the ``patronictl`` tool in order to perform failovers/switchovers/reinitialize/restarts/reloads, by HAProxy or any other kind of load balancer to perform HTTP health checks, and of course could also be used for monitoring.
+The Patroni REST API is used by Patroni itself during the leader race, by the ``patronictl`` tool in order to perform failovers/switchovers/reinitialize/restarts/reloads, by HAProxy or any other kind of load balancer to perform HTTP health checks, and of course could also be used for monitoring. 
 
 From the point of view of security, REST API contains safe (``GET`` requests, only retrieve information) and unsafe (``PUT``, ``POST``, ``PATCH`` and ``DELETE`` requests, change the state of nodes) endpoints.
 
@@ -32,6 +32,6 @@ When TLS for the REST API is enabled and a PKI is established, mutual authentica
 
 The ``restapi`` section parameters enable TLS client authentication to the server. Depending on the value of the ``verify_client`` parameter, the API server requires a successful client certificate verification for both safe and unsafe API calls (``verify_client: required``), or only for unsafe API calls (``verify_client: optional``), or for no API calls (``verify_client: none``).
 
-The ``ctl`` section parameters enable TLS server authentication to the client (the ``patronictl`` tool which uses the same config as patroni). Set ``insecure: true`` to disable the server certificate verification by the client. See :ref:`settings <patronictl_settings>` for a detailed description of the TLS client parameters.
+The ``ctl`` section parameters enable TLS server authentication to the client (the ``patronictl`` tool which uses the same config as patroni). Set ``insecure: true`` to disable the server certificate verification by the client. See :ref:`SETTINGS <patronictl_settings>` for a detailed description of the TLS client parameters.
 
 Protecting the PostgreSQL database proper from unauthorized access is beyond the scope of this document and is covered in https://www.postgresql.org/docs/current/client-authentication.html

docs/watchdog.rst

@@ -3,7 +3,7 @@
 Watchdog support
 ================
 
-Having multiple PostgreSQL servers running as primary can result in transactions lost due to diverging timelines. This situation is also called a split-brain problem. To avoid split-brain Patroni needs to ensure PostgreSQL will not accept any transaction commits after leader key expires in the DCS. Under normal circumstances Patroni will try to achieve this by stopping PostgreSQL when leader lock update fails for any reason. However, this may fail to happen due to various reasons:
+Having multiple PostgreSQL servers running as master can result in transactions lost due to diverging timelines. This situation is also called a split-brain problem. To avoid split-brain Patroni needs to ensure PostgreSQL will not accept any transaction commits after leader key expires in the DCS. Under normal circumstances Patroni will try to achieve this by stopping PostgreSQL when leader lock update fails for any reason. However, this may fail to happen due to various reasons:
 
 - Patroni has crashed due to a bug, out-of-memory condition or by being accidentally killed by a system administrator.
 
@@ -13,7 +13,7 @@ Having multiple PostgreSQL servers running as primary can result in transactions
 
 To guarantee correct behavior under these conditions Patroni supports watchdog devices. Watchdog devices are software or hardware mechanisms that will reset the whole system when they do not get a keepalive heartbeat within a specified timeframe. This adds an additional layer of fail safe in case usual Patroni split-brain protection mechanisms fail.
 
-Patroni will try to activate the watchdog before promoting PostgreSQL to primary. If watchdog activation fails and watchdog mode is ``required`` then the node will refuse to become leader. When deciding to participate in leader election Patroni will also check that watchdog configuration will allow it to become leader at all. After demoting PostgreSQL (for example due to a manual failover) Patroni will disable the watchdog again. Watchdog will also be disabled while Patroni is in paused state.
+Patroni will try to activate the watchdog before promoting PostgreSQL to master. If watchdog activation fails and watchdog mode is ``required`` then the node will refuse to become master. When deciding to participate in leader election Patroni will also check that watchdog configuration will allow it to become leader at all. After demoting PostgreSQL (for example due to a manual failover) Patroni will disable the watchdog again. Watchdog will also be disabled while Patroni is in paused state.
 
 By default Patroni will set up the watchdog to expire 5 seconds before TTL expires. With the default setup of ``loop_wait=10`` and ``ttl=30`` this gives HA loop at least 15 seconds (``ttl`` - ``safety_margin`` - ``loop_wait``) to complete before the system gets forcefully reset. By default accessing DCS is configured to time out after 10 seconds. This means that when DCS is unavailable, for example due to network issues, Patroni and PostgreSQL will have at least 5 seconds (``ttl`` - ``safety_margin`` - ``loop_wait`` - ``retry_timeout``) to come to a state where all client connections are terminated.
 

docs/yaml_configuration.rst

@@ -1,400 +0,0 @@
-.. _yaml_configuration:
-
-============================
-YAML Configuration Settings
-============================
-
-
-Global/Universal
-----------------
--  **name**: the name of the host. Must be unique for the cluster.
--  **namespace**: path within the configuration store where Patroni will keep information about the cluster. Default value: "/service"
--  **scope**: cluster name
-
-Log
----
--  **level**: sets the general logging level. Default value is **INFO** (see `the docs for Python logging <https://docs.python.org/3.6/library/logging.html#levels>`_)
--  **traceback\_level**: sets the level where tracebacks will be visible. Default value is **ERROR**. Set it to **DEBUG** if you want to see tracebacks only if you enable **log.level=DEBUG**.
--  **format**: sets the log formatting string. Default value is **%(asctime)s %(levelname)s: %(message)s** (see `the LogRecord attributes <https://docs.python.org/3.6/library/logging.html#logrecord-attributes>`_)
--  **dateformat**: sets the datetime formatting string. (see the `formatTime() documentation <https://docs.python.org/3.6/library/logging.html#logging.Formatter.formatTime>`_)
--  **max\_queue\_size**: Patroni is using two-step logging. Log records are written into the in-memory queue and there is a separate thread which pulls them from the queue and writes to stderr or file. The maximum size of the internal queue is limited by default by **1000** records, which is enough to keep logs for the past 1h20m.
--  **dir**: Directory to write application logs to. The directory must exist and be writable by the user executing Patroni. If you set this value, the application will retain 4 25MB logs by default. You can tune those retention values with `file_num` and `file_size` (see below).
--  **file\_num**: The number of application logs to retain.
--  **file\_size**: Size of patroni.log file (in bytes) that triggers a log rolling.
--  **loggers**: This section allows redefining logging level per python module
-
-   -  **patroni.postmaster: WARNING**
-   -  **urllib3: DEBUG**
-
-.. _bootstrap_settings:
-
-Bootstrap configuration
------------------------
-
-.. note::
-    Once Patroni has initialized the cluster for the first time and settings have been stored in the DCS, all future
-    changes to the ``bootstrap.dcs`` section of the YAML configuration will not take any effect! If you want to change
-    them please use either ``patronictl edit-config`` or the Patroni :ref:`REST API <rest_api>`.
-
--  **bootstrap**:
-
-   -  **dcs**: This section will be written into `/<namespace>/<scope>/config` of the given configuration store after initializing the new cluster. The global dynamic configuration for the cluster. You can put any of the parameters described in the :ref:`Dynamic Configuration settings <dynamic_configuration>` under ``bootstrap.dcs`` and after Patroni has initialized (bootstrapped) the new cluster, it will write this section into `/<namespace>/<scope>/config` of the configuration store.
-   -  **method**: custom script to use for bootstrapping this cluster.
-
-      See :ref:`custom bootstrap methods documentation <custom_bootstrap>` for details.
-      When ``initdb`` is specified revert to the default ``initdb`` command. ``initdb`` is also triggered when no ``method``
-      parameter is present in the configuration file.
-   -  **initdb**: (optional) list options to be passed on to initdb.
-
-      -  **- data-checksums**: Must be enabled when pg_rewind is needed on 9.3.
-      -  **- encoding: UTF8**: default encoding for new databases.
-      -  **- locale: UTF8**: default locale for new databases.
-   -  **users**: Some additional users which need to be created after initializing new cluster, see :ref:`Bootstrap users configuration <bootstrap_users_configuration>` below.
-   -  **post\_bootstrap** or **post\_init**: An additional script that will be executed after initializing the cluster. The script receives a connection string URL (with the cluster superuser as a user name). The PGPASSFILE variable is set to the location of pgpass file.
-
-.. _bootstrap_users_configuration:
-
-Bootstrap users configuration
-=============================
-
-Users which need to be created after initializing the cluster:
-
--  **admin**: the name of user
-
-  -  **password**: (optional) password for the user
-  -  **options**: list of options for CREATE USER statement
-
-    -  **- createrole**
-    -  **- createdb**
-
-.. _citus_settings:
-
-Citus
------
-Enables integration Patroni with `Citus <https://docs.citusdata.com>`__. If configured, Patroni will take care of registering Citus worker nodes on the coordinator. You can find more information about Citus support :ref:`here <citus>`.
-
--  **group**: the Citus group id, integer. Use ``0`` for coordinator and ``1``, ``2``, etc... for workers
--  **database**: the database where ``citus`` extension should be created. Must be the same on the coordinator and all workers. Currently only one database is supported.
-
-.. _consul_settings:
-
-Consul
-------
-Most of the parameters are optional, but you have to specify one of the **host** or **url**
-
--  **host**: the host:port for the Consul local agent.
--  **url**: url for the Consul local agent, in format: http(s)://host:port.
--  **port**: (optional) Consul port.
--  **scheme**: (optional) **http** or **https**, defaults to **http**.
--  **token**: (optional) ACL token.
--  **verify**: (optional) whether to verify the SSL certificate for HTTPS requests.
--  **cacert**: (optional) The ca certificate. If present it will enable validation.
--  **cert**: (optional) file with the client certificate.
--  **key**: (optional) file with the client key. Can be empty if the key is part of **cert**.
--  **dc**: (optional) Datacenter to communicate with. By default the datacenter of the host is used.
--  **consistency**: (optional) Select consul consistency mode. Possible values are ``default``, ``consistent``, or ``stale`` (more details in `consul API reference <https://www.consul.io/api/features/consistency.html/>`__)
--  **checks**: (optional) list of Consul health checks used for the session. By default an empty list is used.
--  **register\_service**: (optional) whether or not to register a service with the name defined by the scope parameter and the tag master, primary, replica, or standby-leader depending on the node's role. Defaults to **false**.
--  **service\_tags**: (optional) additional static tags to add to the Consul service apart from the role (``master``/``primary``/``replica``/``standby-leader``). By default an empty list is used.
--  **service\_check\_interval**: (optional) how often to perform health check against registered url. Defaults to '5s'.
--  **service\_check\_tls\_server\_name**: (optional) overide SNI host when connecting via TLS, see also `consul agent check API reference <https://www.consul.io/api-docs/agent/check#tlsservername>`__.
-
-The ``token`` needs to have the following ACL permissions:
-
-::
-
-    service_prefix "${scope}" {
-        policy = "write"
-    }
-    key_prefix "${namespace}/${scope}" {
-        policy = "write"
-    }
-    session_prefix "" {
-        policy = "write"
-    }
-
-Etcd
-----
-Most of the parameters are optional, but you have to specify one of the **host**, **hosts**, **url**, **proxy** or **srv**
-
--  **host**: the host:port for the etcd endpoint.
--  **hosts**: list of etcd endpoint in format host1:port1,host2:port2,etc... Could be a comma separated string or an actual yaml list.
--  **use\_proxies**: If this parameter is set to true, Patroni will consider **hosts** as a list of proxies and will not perform a topology discovery of etcd cluster.
--  **url**: url for the etcd.
--  **proxy**: proxy url for the etcd. If you are connecting to the etcd using proxy, use this parameter instead of **url**.
--  **srv**: Domain to search the SRV record(s) for cluster autodiscovery. Patroni will try to query these SRV service names for specified domain (in that order until first success): ``_etcd-client-ssl``, ``_etcd-client``, ``_etcd-ssl``, ``_etcd``, ``_etcd-server-ssl``, ``_etcd-server``. If SRV records for ``_etcd-server-ssl`` or ``_etcd-server`` are retrieved then ETCD peer protocol is used do query ETCD for available members. Otherwise hosts from SRV records will be used.
--  **srv\_suffix**: Configures a suffix to the SRV name that is queried during discovery. Use this flag to differentiate between multiple etcd clusters under the same domain. Works only with conjunction with **srv**. For example, if ``srv_suffix: foo`` and ``srv: example.org`` are set, the following DNS SRV query is made:``_etcd-client-ssl-foo._tcp.example.com`` (and so on for every possible ETCD SRV service name).
--  **protocol**: (optional) http or https, if not specified http is used. If the **url** or **proxy** is specified - will take protocol from them.
--  **username**: (optional) username for etcd authentication.
--  **password**: (optional) password for etcd authentication.
--  **cacert**: (optional) The ca certificate. If present it will enable validation.
--  **cert**: (optional) file with the client certificate.
--  **key**: (optional) file with the client key. Can be empty if the key is part of **cert**.
-
-Etcdv3
-------
-If you want that Patroni works with Etcd cluster via protocol version 3, you need to use the ``etcd3`` section in the Patroni configuration file. All configuration parameters are the same as for ``etcd``.
-
-.. warning::
-    Keys created with protocol version 2 are not visible with protocol version 3 and the other way around, therefore it is not possible to switch from ``etcd`` to ``etcd3`` just by updating Patroni config file.
-
-
-ZooKeeper
-----------
--  **hosts**: List of ZooKeeper cluster members in format: ['host1:port1', 'host2:port2', 'etc...'].
--  **use_ssl**: (optional) Whether SSL is used or not. Defaults to ``false``. If set to ``false``, all SSL specific parameters are ignored.
--  **cacert**: (optional) The CA certificate. If present it will enable validation.
--  **cert**: (optional) File with the client certificate.
--  **key**: (optional) File with the client key.
--  **key_password**: (optional) The client key password.
--  **verify**: (optional) Whether to verify certificate or not. Defaults to ``true``.
--  **set_acls**: (optional) If set, configure Kazoo to apply a default ACL to each ZNode that it creates. ACLs will assume 'x509' schema and should be specified as a dictionary with the principal as the key and one or more permissions as a list in the value.  Permissions may be one of ``CREATE``, ``READ``, ``WRITE``, ``DELETE`` or ``ADMIN``.  For example, ``set_acls: {CN=principal1: [CREATE, READ], CN=principal2: [ALL]}``.
-
-.. note::
-    It is required to install ``kazoo>=2.6.0`` to support SSL.
-
-
-Exhibitor
----------
--  **hosts**: initial list of Exhibitor (ZooKeeper) nodes in format: 'host1,host2,etc...'. This list updates automatically whenever the Exhibitor (ZooKeeper) cluster topology changes.
--  **poll\_interval**: how often the list of ZooKeeper and Exhibitor nodes should be updated from Exhibitor.
--  **port**: Exhibitor port.
-
-.. _kubernetes_settings:
-
-Kubernetes
-----------
--  **bypass\_api\_service**: (optional) When communicating with the Kubernetes API, Patroni is usually relying on the `kubernetes` service, the address of which is exposed in the pods via the `KUBERNETES_SERVICE_HOST` environment variable. If `bypass_api_service` is set to ``true``, Patroni will resolve the list of API nodes behind the service and connect directly to them.
--  **namespace**: (optional) Kubernetes namespace where Patroni pod is running. Default value is `default`.
--  **labels**: Labels in format ``{label1: value1, label2: value2}``. These labels will be used to find existing objects (Pods and either Endpoints or ConfigMaps) associated with the current cluster. Also Patroni will set them on every object (Endpoint or ConfigMap) it creates.
--  **scope\_label**: (optional) name of the label containing cluster name. Default value is `cluster-name`.
--  **role\_label**: (optional) name of the label containing role (master or replica or other custom value). Patroni will set this label on the pod it runs in. Default value is ``role``.
--  **leader\_label\_value**: (optional) value of the pod label when Postgres role is ``master``. Default value is ``master``.
--  **follower\_label\_value**: (optional) value of the pod label when Postgres role is ``replica``. Default value is ``replica``.
--  **standby\_leader\_label\_value**: (optional) value of the pod label when Postgres role is ``standby-leader``. Default value is ``standby-leader``.
--  **tmp_\role\_label**: (optional) name of the temporary label containing role (master or replica). Value of this label will always use the default of corresponding role. Set only when necessary.
--  **use\_endpoints**: (optional) if set to true, Patroni will use Endpoints instead of ConfigMaps to run leader elections and keep cluster state.
--  **pod\_ip**: (optional) IP address of the pod Patroni is running in. This value is required when `use_endpoints` is enabled and is used to populate the leader endpoint subsets when the pod's PostgreSQL is promoted.
--  **ports**: (optional) if the Service object has the name for the port, the same name must appear in the Endpoint object, otherwise service won't work. For example, if your service is defined as ``{Kind: Service, spec: {ports: [{name: postgresql, port: 5432, targetPort: 5432}]}}``, then you have to set ``kubernetes.ports: [{"name": "postgresql", "port": 5432}]`` and Patroni will use it for updating subsets of the leader Endpoint. This parameter is used only if `kubernetes.use_endpoints` is set.
--  **cacert**: (optional) Specifies the file with the CA_BUNDLE file with certificates of trusted CAs to use while verifying Kubernetes API SSL certs. If not provided, patroni will use the value provided by the ServiceAccount secret.
--  **retriable\_http\_codes**: (optional) list of HTTP status codes from K8s API to retry on. By default Patroni is retrying on ``500``, ``503``, and ``504``, or if K8s API response has ``retry-after`` HTTP header.
-
-
-.. _raft_settings:
-
-Raft (deprecated)
------------------
--  **self\_addr**: ``ip:port`` to listen on for Raft connections. The ``self_addr`` must be accessible from other nodes of the cluster. If not set, the node will not participate in consensus.
--  **bind\_addr**: (optional) ``ip:port`` to listen on for Raft connections. If not specified the ``self_addr`` will be used.
--  **partner\_addrs**: list of other Patroni nodes in the cluster in format: ['ip1:port', 'ip2:port', 'etc...']
--  **data\_dir**: directory where to store Raft log and snapshot. If not specified the current working directory is used.
--  **password**: (optional) Encrypt Raft traffic with a specified password, requires ``cryptography`` python module.
-
-   Short FAQ about Raft implementation
-
-   - Q: How to list all the nodes providing consensus?
-
-     A: ``syncobj_admin -conn host:port -status`` where the host:port is the address of one of the cluster nodes
-
-   - Q: Node that was a part of consensus and has gone and I can't reuse the same IP for other node. How to remove this node from the consensus?
-
-     A: ``syncobj_admin -conn host:port -remove host2:port2`` where the ``host2:port2`` is the address of the node you want to remove from consensus.
-
-   - Q: Where to get the ``syncobj_admin`` utility?
-
-     A: It is installed together with ``pysyncobj`` module (python RAFT implementation), which is Patroni dependency.
-
-   - Q: it is possible to run Patroni node without adding in to the consensus?
-
-     A: Yes, just comment out or remove ``raft.self_addr`` from Patroni configuration.
-
-   - Q: It is possible to run Patroni and PostgreSQL only on two nodes?
-
-     A: Yes, on the third node you can run ``patroni_raft_controller`` (without Patroni and PostgreSQL). In such a setup, one can temporarily lose one node without affecting the primary.
-
-
-.. _postgresql_settings:
-
-PostgreSQL
-----------
--  **postgresql**:
-
-   -  **authentication**:
-
-      -  **superuser**:
-
-         -  **username**: name for the superuser, set during initialization (initdb) and later used by Patroni to connect to the postgres.
-         -  **password**: password for the superuser, set during initialization (initdb).
-         -  **sslmode**: (optional) maps to the `sslmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLMODE>`__ connection parameter, which allows a client to specify the type of TLS negotiation mode with the server. For more information on how each mode works, please visit the `PostgreSQL documentation <https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS>`__. The default mode is ``prefer``.
-         -  **sslkey**: (optional) maps to the `sslkey <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLKEY>`__ connection parameter, which specifies the location of the secret key used with the client's certificate.
-         -  **sslpassword**: (optional) maps to the `sslpassword <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLPASSWORD>`__ connection parameter, which specifies the password for the secret key specified in ``sslkey``.
-         -  **sslcert**: (optional) maps to the `sslcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCERT>`__ connection parameter, which specifies the location of the client certificate.
-         -  **sslrootcert**: (optional) maps to the `sslrootcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLROOTCERT>`__ connection parameter, which specifies the location of a file containing one ore more certificate authorities (CA) certificates that the client will use to verify a server's certificate.
-         -  **sslcrl**: (optional) maps to the `sslcrl <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRL>`__ connection parameter, which specifies the location of a file containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
-         -  **sslcrldir**: (optional) maps to the `sslcrldir <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRLDIR>`__ connection parameter, which specifies the location of a directory with files containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
-         -  **gssencmode**: (optional) maps to the `gssencmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-GSSENCMODE>`__ connection parameter, which determines whether or with what priority a secure GSS TCP/IP connection will be negotiated with the server
-         -  **channel_binding**: (optional) maps to the `channel_binding <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-CHANNEL-BINDING>`__ connection parameter, which controls the client's use of channel binding.
-      -  **replication**:
-
-         -  **username**: replication username; the user will be created during initialization. Replicas will use this user to access the replication source via streaming replication
-         -  **password**: replication password; the user will be created during initialization.
-         -  **sslmode**: (optional) maps to the `sslmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLMODE>`__ connection parameter, which allows a client to specify the type of TLS negotiation mode with the server. For more information on how each mode works, please visit the `PostgreSQL documentation <https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS>`__. The default mode is ``prefer``.
-         -  **sslkey**: (optional) maps to the `sslkey <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLKEY>`__ connection parameter, which specifies the location of the secret key used with the client's certificate.
-         -  **sslpassword**: (optional) maps to the `sslpassword <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLPASSWORD>`__ connection parameter, which specifies the password for the secret key specified in ``sslkey``.
-         -  **sslcert**: (optional) maps to the `sslcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCERT>`__ connection parameter, which specifies the location of the client certificate.
-         -  **sslrootcert**: (optional) maps to the `sslrootcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLROOTCERT>`__ connection parameter, which specifies the location of a file containing one ore more certificate authorities (CA) certificates that the client will use to verify a server's certificate.
-         -  **sslcrl**: (optional) maps to the `sslcrl <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRL>`__ connection parameter, which specifies the location of a file containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
-         -  **sslcrldir**: (optional) maps to the `sslcrldir <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRLDIR>`__ connection parameter, which specifies the location of a directory with files containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
-         -  **gssencmode**: (optional) maps to the `gssencmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-GSSENCMODE>`__ connection parameter, which determines whether or with what priority a secure GSS TCP/IP connection will be negotiated with the server
-         -  **channel_binding**: (optional) maps to the `channel_binding <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-CHANNEL-BINDING>`__ connection parameter, which controls the client's use of channel binding.
-      -  **rewind**:
-
-         -  **username**: (optional) name for the user for ``pg_rewind``; the user will be created during initialization of postgres 11+ and all necessary `permissions <https://www.postgresql.org/docs/11/app-pgrewind.html#id-1.9.5.8.8>`__ will be granted.
-         -  **password**: (optional) password for the user for ``pg_rewind``; the user will be created during initialization.
-         -  **sslmode**: (optional) maps to the `sslmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLMODE>`__ connection parameter, which allows a client to specify the type of TLS negotiation mode with the server. For more information on how each mode works, please visit the `PostgreSQL documentation <https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-SSLMODE-STATEMENTS>`__. The default mode is ``prefer``.
-         -  **sslkey**: (optional) maps to the `sslkey <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLKEY>`__ connection parameter, which specifies the location of the secret key used with the client's certificate.
-         -  **sslpassword**: (optional) maps to the `sslpassword <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLPASSWORD>`__ connection parameter, which specifies the password for the secret key specified in ``sslkey``.
-         -  **sslcert**: (optional) maps to the `sslcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCERT>`__ connection parameter, which specifies the location of the client certificate.
-         -  **sslrootcert**: (optional) maps to the `sslrootcert <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLROOTCERT>`__ connection parameter, which specifies the location of a file containing one ore more certificate authorities (CA) certificates that the client will use to verify a server's certificate.
-         -  **sslcrl**: (optional) maps to the `sslcrl <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRL>`__ connection parameter, which specifies the location of a file containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
-         -  **sslcrldir**: (optional) maps to the `sslcrldir <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLCRLDIR>`__ connection parameter, which specifies the location of a directory with files containing a certificate revocation list. A client will reject connecting to any server that has a certificate present in this list.
-         -  **gssencmode**: (optional) maps to the `gssencmode <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-GSSENCMODE>`__ connection parameter, which determines whether or with what priority a secure GSS TCP/IP connection will be negotiated with the server
-         -  **channel_binding**: (optional) maps to the `channel_binding <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-CHANNEL-BINDING>`__ connection parameter, which controls the client's use of channel binding.
-
-   -  **callbacks**: callback scripts to run on certain actions. Patroni will pass the action, role and cluster name. (See scripts/aws.py as an example of how to write them.)
-
-      -  **on\_reload**: run this script when configuration reload is triggered.
-      -  **on\_restart**: run this script when the postgres restarts (without changing role).
-      -  **on\_role\_change**: run this script when the postgres is being promoted or demoted.
-      -  **on\_start**: run this script when the postgres starts.
-      -  **on\_stop**: run this script when the postgres stops.
-   -  **connect\_address**: IP address + port through which Postgres is accessible from other nodes and applications.
-   -  **proxy\_address**: IP address + port through which a connection pool (e.g. pgbouncer) running next to Postgres is accessible. The value is written to the member key in DCS as ``proxy_url`` and could be used/useful for service discovery.
-   -  **create\_replica\_methods**: an ordered list of the create methods for turning a Patroni node into a new replica.
-      "basebackup" is the default method; other methods are assumed to refer to scripts, each of which is configured as its
-      own config item. See :ref:`custom replica creation methods documentation <custom_replica_creation>` for further explanation.
-   -  **data\_dir**: The location of the Postgres data directory, either :ref:`existing <existing_data>` or to be initialized by Patroni.
-   -  **config\_dir**: The location of the Postgres configuration directory, defaults to the data directory. Must be writable by Patroni.
-   -  **bin\_dir**: (optional) Path to PostgreSQL binaries (pg_ctl, initdb, pg_controldata, pg_basebackup, postgres, pg_isready, pg_rewind). If not provided or is an empty string, PATH environment variable will be used to find the executables.
-   -  **bin\_name**: (optional) Make it possible to override Postgres binary names, if you are using a custom Postgres distribution:
-
-      - **pg\_ctl**: (optional) Custom name for ``pg_ctl`` binary.
-      - **initdb**: (optional) Custom name for ``initdb`` binary.
-      - **pg\controldata**: (optional) Custom name for ``pg_controldata`` binary.
-      - **pg\_basebackup**: (optional) Custom name for ``pg_basebackup`` binary.
-      - **postgres**: (optional) Custom name for ``postgres`` binary.
-      - **pg\_isready**: (optional) Custom name for ``pg_isready`` binary.
-      - **pg\_rewind**: (optional) Custom name for ``pg_rewind`` binary.
-   -  **listen**: IP address + port that Postgres listens to; must be accessible from other nodes in the cluster, if you're using streaming replication. Multiple comma-separated addresses are permitted, as long as the port component is appended after to the last one with a colon, i.e. ``listen: 127.0.0.1,127.0.0.2:5432``. Patroni will use the first address from this list to establish local connections to the PostgreSQL node.
-   -  **use\_unix\_socket**: specifies that Patroni should prefer to use unix sockets to connect to the cluster. Default value is ``false``. If ``unix_socket_directories`` is defined, Patroni will use the first suitable value from it to connect to the cluster and fallback to tcp if nothing is suitable. If ``unix_socket_directories`` is not specified in ``postgresql.parameters``, Patroni will assume that the default value should be used and omit ``host`` from the connection parameters.
-   -  **use\_unix\_socket\_repl**: specifies that Patroni should prefer to use unix sockets for replication user cluster connection. Default value is ``false``. If ``unix_socket_directories`` is defined, Patroni will use the first suitable value from it to connect to the cluster and fallback to tcp if nothing is suitable. If ``unix_socket_directories`` is not specified in ``postgresql.parameters``, Patroni will assume that the default value should be used and omit ``host`` from the connection parameters.
-   -  **pgpass**: path to the `.pgpass <https://www.postgresql.org/docs/current/static/libpq-pgpass.html>`__ password file. Patroni creates this file before executing pg\_basebackup, the post_init script and under some other circumstances. The location must be writable by Patroni.
-   -  **recovery\_conf**: additional configuration settings written to recovery.conf when configuring follower.
-   -  **custom\_conf** : path to an optional custom ``postgresql.conf`` file, that will be used in place of ``postgresql.base.conf``. The file must exist on all cluster nodes, be readable by PostgreSQL and will be included from its location on the real ``postgresql.conf``. Note that Patroni will not monitor this file for changes, nor backup it. However, its settings can still be overridden by Patroni's own configuration facilities - see :ref:`dynamic configuration <patroni_configuration>` for details.
-   -  **parameters**: list of configuration settings for Postgres. Many of these are required for replication to work.
-   -  **pg\_hba**: list of lines that Patroni will use to generate ``pg_hba.conf``. Patroni ignores this parameter if ``hba_file`` PostgreSQL parameter is set to a non-default value. Together with :ref:`dynamic configuration <dynamic_configuration>` this parameter simplifies management of ``pg_hba.conf``.
-
-      -  **- host all all 0.0.0.0/0 md5**
-      -  **- host replication replicator 127.0.0.1/32 md5**: A line like this is required for replication.
-   -  **pg\_ident**: list of lines that Patroni will use to generate ``pg_ident.conf``. Patroni ignores this parameter if ``ident_file`` PostgreSQL parameter is set to a non-default value. Together with :ref:`dynamic configuration <dynamic_configuration>` this parameter simplifies management of ``pg_ident.conf``.
-
-      -  **- mapname1 systemname1 pguser1**
-      -  **- mapname1 systemname2 pguser2**
-   -  **pg\_ctl\_timeout**: How long should pg_ctl wait when doing ``start``, ``stop`` or ``restart``. Default value is 60 seconds.
-   -  **use\_pg\_rewind**: try to use pg\_rewind on the former leader when it joins cluster as a replica.
-   -  **remove\_data\_directory\_on\_rewind\_failure**: If this option is enabled, Patroni will remove the PostgreSQL data directory and recreate the replica. Otherwise it will try to follow the new leader. Default value is **false**.
-   -  **remove\_data\_directory\_on\_diverged\_timelines**: Patroni will remove the PostgreSQL data directory and recreate the replica if it notices that timelines are diverging and the former primary can not start streaming from the new primary. This option is useful when ``pg_rewind`` can not be used. While performing timelines divergence check on PostgreSQL v10 and older Patroni will try to connect with replication credential to the "postgres" database. Hence, such access should be allowed in the pg_hba.conf. Default value is **false**.
-   -  **replica\_method**: for each create_replica_methods other than basebackup, you would add a configuration section of the same name. At a minimum, this should include "command" with a full path to the actual script to be executed. Other configuration parameters will be passed along to the script in the form "parameter=value".
-   -  **pre\_promote**: a fencing script that executes during a failover after acquiring the leader lock but before promoting the replica. If the script exits with a non-zero code, Patroni does not promote the replica and removes the leader key from DCS.
-   -  **before\_stop**: a script that executes immediately prior to stopping postgres. As opposed to a callback, this script runs synchronously, blocking shutdown until it has completed. The return code of this script does not impact whether shutdown proceeds afterwards.
-
-.. _restapi_settings:
-
-REST API
---------
--  **restapi**:
-
-   -  **connect\_address**: IP address (or hostname) and port, to access the Patroni's :ref:`REST API <rest_api>`. All the members of the cluster must be able to connect to this address, so unless the Patroni setup is intended for a demo inside the localhost, this address must be a non "localhost" or loopback address (ie: "localhost" or "127.0.0.1"). It can serve as an endpoint for HTTP health checks (read below about the "listen" REST API parameter), and also for user queries (either directly or via the REST API), as well as for the health checks done by the cluster members during leader elections (for example, to determine whether the leader is still running, or if there is a node which has a WAL position that is ahead of the one doing the query; etc.) The connect_address is put in the member key in DCS, making it possible to translate the member name into the address to connect to its REST API.
-   -  **listen**: IP address (or hostname) and port that Patroni will listen to for the REST API - to provide also the same health checks and cluster messaging between the participating nodes, as described above. to provide health-check information for HAProxy (or any other load balancer capable of doing a HTTP "OPTION" or "GET" checks).
-   -  **authentication**: (optional)
-
-      -  **username**: Basic-auth username to protect unsafe REST API endpoints.
-      -  **password**: Basic-auth password to protect unsafe REST API endpoints.
-   -  **certfile**: (optional): Specifies the file with the certificate in the PEM format. If the certfile is not specified or is left empty, the API server will work without SSL.
-   -  **keyfile**: (optional): Specifies the file with the secret key in the PEM format.
-   -  **keyfile\_password**: (optional): Specifies a password for decrypting the keyfile.
-   -  **cafile**: (optional): Specifies the file with the CA_BUNDLE with certificates of trusted CAs to use while verifying client certs.
-   -  **ciphers**: (optional): Specifies the permitted cipher suites (e.g. "ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES128-GCM-SHA256:!SSLv1:!SSLv2:!SSLv3:!TLSv1:!TLSv1.1")
-   -  **verify\_client**: (optional): ``none`` (default), ``optional`` or ``required``. When ``none`` REST API will not check client certificates. When ``required`` client certificates are required for all REST API calls. When ``optional`` client certificates are required for all unsafe REST API endpoints. When ``required`` is used, then client authentication succeeds, if the certificate signature verification succeeds.  For ``optional`` the client cert will only be checked for ``PUT``, ``POST``, ``PATCH``, and ``DELETE`` requests.
-   -  **allowlist**: (optional): Specifies the set of hosts that are allowed to call unsafe REST API endpoints. The single element could be a host name, an IP address or a network address using CIDR notation. By default ``allow all`` is used. In case if ``allowlist`` or ``allowlist_include_members`` are set, anything that is not included is rejected.
-   -  **allowlist\_include\_members**: (optional): If set to ``true`` it allows accessing unsafe REST API endpoints from other cluster members registered in DCS (IP address or hostname is taken from the members ``api_url``). Be careful, it might happen that OS will use a different IP for outgoing connections.
-   -  **http\_extra\_headers**: (optional): HTTP headers let the REST API server pass additional information with an HTTP response.
-   -  **https\_extra\_headers**: (optional): HTTPS headers let the REST API server pass additional information with an HTTP response when TLS is enabled. This will also pass additional information set in ``http_extra_headers``.
-   -  **request_queue_size**: (optional): Sets request queue size for TCP socket used by Patroni REST API.  Once the queue is full, further requests get a "Connection denied" error. The default value is 5.
-
-Here is an example of both **http_extra_headers** and **https_extra_headers**:
-
-.. code:: YAML
-
-        restapi:
-          listen: <listen>
-          connect_address: <connect_address>
-          authentication:
-            username: <username>
-            password: <password>
-          http_extra_headers:
-            'X-Frame-Options': 'SAMEORIGIN'
-            'X-XSS-Protection': '1; mode=block'
-            'X-Content-Type-Options': 'nosniff'
-          cafile: <ca file>
-          certfile: <cert>
-          keyfile: <key>
-          https_extra_headers:
-            'Strict-Transport-Security': 'max-age=31536000; includeSubDomains'
-
-.. warning::
-
-    - The ``restapi.connect_address`` must be accessible from all nodes of a given Patroni cluster. Internally Patroni is using it during the leader race to find nodes with minimal replication lag.
-    - If you enabled client certificates validation (``restapi.verify_client`` is set to ``required``), you also **must** provide **valid client certificates** in the ``ctl.certfile``, ``ctl.keyfile``, ``ctl.keyfile_password``. If not provided, Patroni will not work correctly.
-
-
-.. _patronictl_settings:
-
-CTL
----
--  **ctl**: (optional)
-
-   -  **authentication**:
-
-      -  **username**: Basic-auth username for accessing protected REST API endpoints. If not provided patronictl will use the value provided for REST API "username" parameter.
-      -  **password**: Basic-auth password for accessing protected REST API endpoints. If not provided patronictl will use the value provided for REST API "password" parameter.
-   -  **insecure**: Allow connections to REST API without verifying SSL certs.
-   -  **cacert**: Specifies the file with the CA_BUNDLE file or directory with certificates of trusted CAs to use while verifying REST API SSL certs. If not provided patronictl will use the value provided for REST API "cafile" parameter.
-   -  **certfile**: Specifies the file with the client certificate in the PEM format.
-   -  **keyfile**: Specifies the file with the client secret key in the PEM format.
-   -  **keyfile\_password**: Specifies a password for decrypting the client keyfile.
-
-Watchdog
---------
--  **mode**: ``off``, ``automatic`` or ``required``. When ``off`` watchdog is disabled. When ``automatic`` watchdog will be used if available, but ignored if it is not. When ``required`` the node will not become a leader unless watchdog can be successfully enabled.
--  **device**: Path to watchdog device. Defaults to ``/dev/watchdog``.
--  **safety_margin**: Number of seconds of safety margin between watchdog triggering and leader key expiration.
-
-.. _tags_settings:
-
-Tags
-----
--  **nofailover**: ``true`` or ``false``, controls whether this node is allowed to participate in the leader race and become a leader. Defaults to ``false``
--  **clonefrom**: ``true`` or ``false``. If set to ``true`` other nodes might prefer to use this node for bootstrap (take ``pg_basebackup`` from). If there are several nodes with ``clonefrom`` tag set to ``true`` the node to bootstrap from will be chosen randomly. The default value is ``false``.
--  **noloadbalance**: ``true`` or ``false``. If set to ``true`` the node will return HTTP Status Code 503 for the ``GET /replica`` REST API health-check and therefore will be excluded from the load-balancing. Defaults to ``false``.
--  **replicatefrom**: The IP address/hostname of another replica. Used to support cascading replication.
--  **nosync**: ``true`` or ``false``. If set to ``true`` the node will never be selected as a synchronous replica.
-
-In addition to these predefined tags, you can also add your own ones:
-
--  **key1**: ``true``
--  **key2**: ``false``
--  **key3**: ``1.4``
--  **key4**: ``"RandomString"``
-
-Tags are visible in the :ref:`REST API <rest_api>` and ``patronictl list`` You can also check for an instance health using these tags. If the tag isn't defined for an instance, or if the respective value doesn't match the querying value, it will return HTTP Status Code 503.

extras/confd/conf.d/haproxy.toml

@@ -9,5 +9,5 @@ check_cmd = "/usr/sbin/haproxy -c -f {{ .src }}"
 reload_cmd = "haproxy -f /etc/haproxy/haproxy.cfg -p /var/run/haproxy.pid -D -sf $(cat /var/run/haproxy.pid)"
 
 keys = [
-    "/",
+    "/members/",
 ]

extras/confd/templates/haproxy-citus.tmpl

@@ -1,32 +0,0 @@
-global
-	maxconn 100
-
-defaults
-	log	global
-	mode	tcp
-	retries 2
-	timeout client 30m
-	timeout connect 4s
-	timeout server 30m
-	timeout check 5s
-
-listen stats
-	mode http
-	bind *:7000
-	stats enable
-	stats uri /
-
-listen coordinator
-	bind *:5000
-	option httpchk HEAD /primary
-	http-check expect status 200
-	default-server inter 3s fall 3 rise 2 on-marked-down shutdown-sessions
-{{range gets "/0/members/*"}}	server {{base .Key}} {{$data := json .Value}}{{base (replace (index (split $data.conn_url "/") 2) "@" "/" -1)}} maxconn 100 check check-ssl port {{index (split (index (split $data.api_url "/") 2) ":") 1}} verify required ca-file /etc/ssl/certs/ssl-cert-snakeoil.pem crt /etc/ssl/private/ssl-cert-snakeoil.crt
-{{end}}
-listen workers
-	bind *:5001
-	option httpchk HEAD /primary
-	http-check expect status 200
-	default-server inter 3s fall 3 rise 2 on-marked-down shutdown-sessions
-{{range gets "/*/members/*"}}{{$group := index (split .Key "/") 1}}{{if ne $group "0"}}	server {{base .Key}} {{$data := json .Value}}{{base (replace (index (split $data.conn_url "/") 2) "@" "/" -1)}} maxconn 100 check check-ssl port {{index (split (index (split $data.api_url "/") 2) ":") 1}} verify required ca-file /etc/ssl/certs/ssl-cert-snakeoil.pem crt /etc/ssl/private/ssl-cert-snakeoil.crt
-{{end}}{{end}}

extras/confd/templates/haproxy.tmpl

@@ -16,16 +16,16 @@ listen stats
 	stats enable
 	stats uri /
 
-listen primary
+listen master
 	bind *:5000
-	option httpchk HEAD /primary
+	option httpchk OPTIONS /master
 	http-check expect status 200
 	default-server inter 3s fall 3 rise 2 on-marked-down shutdown-sessions
 {{range gets "/members/*"}}	server {{base .Key}} {{$data := json .Value}}{{base (replace (index (split $data.conn_url "/") 2) "@" "/" -1)}} maxconn 100 check port {{index (split (index (split $data.api_url "/") 2) ":") 1}}
 {{end}}
 listen replicas
 	bind *:5001
-	option httpchk HEAD /replica
+	option httpchk OPTIONS /replica
 	http-check expect status 200
 	default-server inter 3s fall 3 rise 2 on-marked-down shutdown-sessions
 {{range gets "/members/*"}}	server {{base .Key}} {{$data := json .Value}}{{base (replace (index (split $data.conn_url "/") 2) "@" "/" -1)}} maxconn 100 check port {{index (split (index (split $data.api_url "/") 2) ":") 1}}

extras/startup-scripts/README.md

@@ -1,6 +1,6 @@
 # startup scripts for Patroni
 
-This directory contains sample startup scripts for various OSes
+This directory contains sample startup scripts for various OSes 
 and management tools for Patroni.
 
 Scripts supplied:
@@ -10,7 +10,7 @@ Scripts supplied:
 Upstart job for Ubuntu 12.04 or 14.04.  Requires Upstart > 1.4. Intended for systems where Patroni has been installed on a base system, rather than in Docker.
 
 ### patroni.service
-Systemd service file, to be copied to /etc/systemd/system/patroni.service, tested on Centos 7.1 with Patroni installed from pip.
+Systemd service file, to be copied to /etc/systemd/system/patroni.service, tested on Centos 7.1 with Patroni installed from pip. 
 
 ### patroni
 Init.d service file for Debian-like distributions. Copy it to /etc/init.d/, make executable:

extras/startup-scripts/patroni.service

@@ -14,7 +14,7 @@ Group=postgres
 # Read in configuration file if it exists, otherwise proceed
 EnvironmentFile=-/etc/patroni_env.conf
 
-# The default is the user's home directory, and if you want to change it, you must provide an absolute path.
+# the default is the user's home directory, and if you want to change it, you must provide an absolute path.
 # WorkingDirectory=/home/sameuser
 
 # Where to send early-startup messages from the server
@@ -32,14 +32,14 @@ ExecStart=/bin/patroni /etc/patroni.yml
 # Send HUP to reload from patroni.yml
 ExecReload=/bin/kill -s HUP $MAINPID
 
-# Only kill the patroni process, not it's children, so it will gracefully stop postgres
+# only kill the patroni process, not it's children, so it will gracefully stop postgres
 KillMode=process
 
 # Give a reasonable amount of time for the server to start up/shut down
 TimeoutSec=30
 
-# Restart the service if it crashed
-Restart=on-failure
+# Do not restart the service if it crashes, we want to manually inspect database on failure
+Restart=no
 
 [Install]
 WantedBy=multi-user.target

features/Dockerfile

@@ -1,94 +0,0 @@
-# syntax = docker/dockerfile:1.5
-# Used only for running tests using tox, see ../tox.ini
-ARG PG_MAJOR
-ARG PGHOME=/home/postgres
-ARG LC_ALL=C.UTF-8
-ARG LANG=C.UTF-8
-ARG BASE_IMAGE=postgres
-
-FROM ${BASE_IMAGE}:${PG_MAJOR}
-
-ARG PGHOME
-ARG LC_ALL
-ARG LANG
-
-ENV PGHOME="$PGHOME"
-ENV PG_USER="${PG_USER:-postgres}"
-ENV PG_GROUP="${PG_GROUP:-$PG_USER}"
-ENV LC_ALL="$LC_ALL"
-ENV LANG="$LANG"
-
-ARG ETCDVERSION=3.3.13
-ENV ETCDVERSION="$ETCDVERSION"
-ARG ETCDURL="https://github.com/coreos/etcd/releases/download/v$ETCDVERSION"
-
-USER root
-RUN set -ex \
-    && apt-get update \
-    && apt-get reinstall init-system-helpers \
-    && apt-get install -y \
-      python3-pip \
-      python3-dev \
-      rsync \
-      curl \
-      gcc \
-      golang \
-      jq  \
-      locales  \
-      sudo \
-      busybox \
-      net-tools \
-      iputils-ping \
-    && rm -rf /var/cache/apt \
-    && python3 -m pip install --no-cache-dir tox \
-    \
-    && mkdir -p "$PGHOME" \
-    && sed -i "s|/var/lib/postgresql.*|$PGHOME:/bin/bash|" /etc/passwd \
-    && chown -R "$PG_USER:$PG_GROUP" /var/log /home/postgres \
-    \
-    # Download etcd \
-    && curl -sL "$ETCDURL/etcd-v$ETCDVERSION-linux-$(dpkg --print-architecture).tar.gz" \
-       | tar xz -C /usr/local/bin --strip=1 --wildcards --no-anchored etcd etcdctl
-
-
-# This Dockerfile syntax only works with docker buildx and the syntax
-# line at the top of this file.
-COPY <<EOF /tox-wrapper.sh
-#!/usr/bin/env bash
-set -ex
-copy_output() {
-    if [[ -d "\$PGHOME/src/features/output" && /src/features ]] ;then
-        cp -a "\$PGHOME/src/features/output" "/src/features/output-\$HOSTNAME"
-        find "/src/features/output-\$HOSTNAME" -type f -exec chmod 666 {} \\;
-        find "/src/features/output-\$HOSTNAME" -type d -exec chmod 777 {} \\;
-    fi
-}
-
-# Ensure the copy is ran if the container is stopped with `docker stop` or `docker kill`
-trap 'copy_output' SIGTERM
-# For architectures such as aarch we need to get the respective GOARCH
-# so we can tell etcd we're ok with running an unsupported architecture.
-export ETCD_UNSUPPORTED_ARCH=$(go env GOARCH)
-cd /src
-runuser -u "\$PG_USER" -- \\
-    find . ! -readable 2>/dev/null \\
-    | sed 's|^./||' >/tmp/copy_exclude.lst \\
-    || true
-runuser -u "\$PG_USER" -- \\
-    rsync -a \\
-    --exclude=.tox \\
-    --exclude="features/output*" \\
-    --exclude-from="/tmp/copy_exclude.lst" \\
-    . "\$PGHOME/src/"
-cd "\$PGHOME/src"
-runuser -u "\$PG_USER" -w ETCD_UNSUPPORTED_ARCH -- "\$@" &
-wait $!
-# SIGINT whilst child proc is running is not seen by trap so we run a copy here instead of using
-# trap copy_output SIGINT EXIT
-copy_output
-EOF
-RUN chmod +x /tox-wrapper.sh
-
-VOLUME /src
-
-ENTRYPOINT ["/tox-wrapper.sh"]

features/basic_replication.feature

@@ -5,7 +5,7 @@ Feature: basic replication
     Given I start postgres0
     Then postgres0 is a leader after 10 seconds
     And there is a non empty initialize key in DCS after 15 seconds
-    When I issue a PATCH request to http://127.0.0.1:8008/config with {"ttl": 20, "synchronous_mode": true}
+    When I issue a PATCH request to http://127.0.0.1:8008/config with {"ttl": 20, "loop_wait": 2, "synchronous_mode": true}
     Then I receive a response code 200
     When I start postgres1
     And I configure and start postgres2 with a tag replicatefrom postgres0
@@ -21,9 +21,12 @@ Feature: basic replication
     And I shut down postgres1
     Then "sync" key in DCS has sync_standby=postgres2 after 10 seconds
     When I start postgres1
-    Then "members/postgres1" key in DCS has state=running after 10 seconds
-    And Status code on GET http://127.0.0.1:8010/sync is 200 after 3 seconds
-    And Status code on GET http://127.0.0.1:8009/async is 200 after 3 seconds
+    And "members/postgres1" key in DCS has state=running after 10 seconds
+    And I sleep for 2 seconds
+    When I issue a GET request to http://127.0.0.1:8010/sync
+    Then I receive a response code 200
+    When I issue a GET request to http://127.0.0.1:8009/async
+    Then I receive a response code 200
 
   Scenario: check stuck sync replica
     Given I issue a PATCH request to http://127.0.0.1:8008/config with {"pause": true, "maximum_lag_on_syncnode": 15000000, "postgresql": {"parameters": {"synchronous_commit": "remote_apply"}}}
@@ -35,8 +38,11 @@ Feature: basic replication
     And I load data on postgres0
     Then "sync" key in DCS has sync_standby=postgres1 after 15 seconds
     And I resume wal replay on postgres2
-    And Status code on GET http://127.0.0.1:8009/sync is 200 after 3 seconds
-    And Status code on GET http://127.0.0.1:8010/async is 200 after 3 seconds
+    And I sleep for 2 seconds
+    And I issue a GET request to http://127.0.0.1:8009/sync
+    Then I receive a response code 200
+    When I issue a GET request to http://127.0.0.1:8010/async
+    Then I receive a response code 200
     When I issue a PATCH request to http://127.0.0.1:8008/config with {"pause": null, "maximum_lag_on_syncnode": -1, "postgresql": {"parameters": {"synchronous_commit": "on"}}}
     Then I receive a response code 200
     And I drop table on postgres0
@@ -44,17 +50,23 @@ Feature: basic replication
   Scenario: check multi sync replication
     Given I issue a PATCH request to http://127.0.0.1:8008/config with {"synchronous_node_count": 2}
     Then I receive a response code 200
-    Then "sync" key in DCS has sync_standby=postgres1,postgres2 after 10 seconds
-    And Status code on GET http://127.0.0.1:8010/sync is 200 after 3 seconds
-    And Status code on GET http://127.0.0.1:8009/sync is 200 after 3 seconds
+    And I sleep for 10 seconds
+    Then "sync" key in DCS has sync_standby=postgres1,postgres2 after 5 seconds
+    When I issue a GET request to http://127.0.0.1:8010/sync
+    Then I receive a response code 200
+    When I issue a GET request to http://127.0.0.1:8009/sync
+    Then I receive a response code 200
     When I issue a PATCH request to http://127.0.0.1:8008/config with {"synchronous_node_count": 1}
     Then I receive a response code 200
     And I shut down postgres1
+    And I sleep for 10 seconds
     Then "sync" key in DCS has sync_standby=postgres2 after 10 seconds
     When I start postgres1
-    Then "members/postgres1" key in DCS has state=running after 10 seconds
-    And Status code on GET http://127.0.0.1:8010/sync is 200 after 3 seconds
-    And Status code on GET http://127.0.0.1:8009/async is 200 after 3 seconds
+    And "members/postgres1" key in DCS has state=running after 10 seconds
+    When I issue a GET request to http://127.0.0.1:8010/sync
+    Then I receive a response code 200
+    When I issue a GET request to http://127.0.0.1:8009/async
+    Then I receive a response code 200
 
   Scenario: check the basic failover in synchronous mode
     Given I run patronictl.py pause batman
@@ -65,21 +77,20 @@ Feature: basic replication
     Then I receive a response returncode 0
     And postgres2 role is the primary after 24 seconds
     And Response on GET http://127.0.0.1:8010/history contains recovery after 10 seconds
-    And there is a postgres2_cb.log with "on_role_change master batman" in postgres2 data directory
     When I issue a PATCH request to http://127.0.0.1:8010/config with {"synchronous_mode": null, "master_start_timeout": 0}
     Then I receive a response code 200
     When I add the table bar to postgres2
     Then table bar is present on postgres1 after 20 seconds
     And Response on GET http://127.0.0.1:8010/config contains master_start_timeout after 10 seconds
 
-  Scenario: check rejoin of the former primary with pg_rewind
+  Scenario: check immediate failover when master_start_timeout=0
+    Given I kill postmaster on postgres2
+    Then postgres1 is a leader after 10 seconds
+    And postgres1 role is the primary after 10 seconds
+
+  Scenario: check rejoin of the former master with pg_rewind
     Given I add the table splitbrain to postgres0
     And I start postgres0
     Then postgres0 role is the secondary after 20 seconds
-    When I add the table buz to postgres2
+    When I add the table buz to postgres1
     Then table buz is present on postgres0 after 20 seconds
-
-  @reject-duplicate-name
-  Scenario: check graceful rejection when two nodes have the same name
-    Given I start duplicate postgres0 on port 8011
-    Then there is a "Can't start; there is already a node named 'postgres0' running" CRITICAL in the dup-postgres0 patroni log

features/citus.feature

@@ -1,73 +0,0 @@
-Feature: citus
-  We should check that coordinator discovers and registers workers and clients don't have errors when worker cluster switches over
-
-  Scenario: check that worker cluster is registered in the coordinator
-    Given I start postgres0 in citus group 0
-    And I start postgres2 in citus group 1
-    Then postgres0 is a leader in a group 0 after 10 seconds
-    And postgres2 is a leader in a group 1 after 10 seconds
-    When I start postgres1 in citus group 0
-    And I start postgres3 in citus group 1
-    Then replication works from postgres0 to postgres1 after 15 seconds
-    Then replication works from postgres2 to postgres3 after 15 seconds
-    And postgres0 is registered in the postgres0 as the primary in group 0 after 5 seconds
-    And postgres2 is registered in the postgres0 as the primary in group 1 after 5 seconds
-
-  Scenario: coordinator failover updates pg_dist_node
-    Given I run patronictl.py failover batman --group 0 --candidate postgres1 --force
-    Then postgres1 role is the primary after 10 seconds
-    And "members/postgres0" key in a group 0 in DCS has state=running after 15 seconds
-    And replication works from postgres1 to postgres0 after 15 seconds
-    And postgres1 is registered in the postgres2 as the primary in group 0 after 5 seconds
-    And "sync" key in a group 0 in DCS has sync_standby=postgres0 after 15 seconds
-    When I run patronictl.py switchover batman --group 0 --candidate postgres0 --force
-    Then postgres0 role is the primary after 10 seconds
-    And replication works from postgres0 to postgres1 after 15 seconds
-    And postgres0 is registered in the postgres2 as the primary in group 0 after 5 seconds
-    And "sync" key in a group 0 in DCS has sync_standby=postgres1 after 15 seconds
-
-  Scenario: worker switchover doesn't break client queries on the coordinator
-    Given I create a distributed table on postgres0
-    And I start a thread inserting data on postgres0
-    When I run patronictl.py switchover batman --group 1 --force
-    Then I receive a response returncode 0
-    And postgres3 role is the primary after 10 seconds
-    And "members/postgres2" key in a group 1 in DCS has state=running after 15 seconds
-    And replication works from postgres3 to postgres2 after 15 seconds
-    And postgres3 is registered in the postgres0 as the primary in group 1 after 5 seconds
-    And "sync" key in a group 1 in DCS has sync_standby=postgres2 after 15 seconds
-    And a thread is still alive
-    When I run patronictl.py switchover batman --group 1 --force
-    Then I receive a response returncode 0
-    And postgres2 role is the primary after 10 seconds
-    And replication works from postgres2 to postgres3 after 15 seconds
-    And postgres2 is registered in the postgres0 as the primary in group 1 after 5 seconds
-    And "sync" key in a group 1 in DCS has sync_standby=postgres3 after 15 seconds
-    And a thread is still alive
-    When I stop a thread
-    Then a distributed table on postgres0 has expected rows
-
-  Scenario: worker primary restart doesn't break client queries on the coordinator
-    Given I cleanup a distributed table on postgres0
-    And I start a thread inserting data on postgres0
-    When I run patronictl.py restart batman postgres2 --group 1 --force
-    Then I receive a response returncode 0
-    And postgres2 role is the primary after 10 seconds
-    And replication works from postgres2 to postgres3 after 15 seconds
-    And postgres2 is registered in the postgres0 as the primary in group 1 after 5 seconds
-    And a thread is still alive
-    When I stop a thread
-    Then a distributed table on postgres0 has expected rows
-
-  Scenario: check that in-flight transaction is rolled back after timeout when other workers need to change pg_dist_node
-    Given I start postgres4 in citus group 2
-    Then postgres4 is a leader in a group 2 after 10 seconds
-    And "members/postgres4" key in a group 2 in DCS has role=master after 3 seconds
-    When I run patronictl.py edit-config batman --group 2 -s ttl=20 --force
-    Then I receive a response returncode 0
-    And I receive a response output "+ttl: 20"
-    Then postgres4 is registered in the postgres2 as the primary in group 2 after 5 seconds
-    When I shut down postgres4
-    Then There is a transaction in progress on postgres0 changing pg_dist_node
-    When I run patronictl.py restart batman postgres2 --group 1 --force
-    Then a transaction finishes in 20 seconds

features/dcs_failsafe_mode.feature

@@ -1,85 +0,0 @@
-Feature: dcs failsafe mode
-  We should check the basic dcs failsafe mode functioning
-
-  Scenario: check failsafe mode can be successfully enabled
-    Given I start postgres0
-    And postgres0 is a leader after 10 seconds
-    And I sleep for 3 seconds
-    When I issue a PATCH request to http://127.0.0.1:8008/config with {"loop_wait": 2, "ttl": 20, "retry_timeout": 5, "failsafe_mode": true}
-    Then I receive a response code 200
-    And Response on GET http://127.0.0.1:8008/failsafe contains postgres0 after 10 seconds
-    When I issue a GET request to http://127.0.0.1:8008/failsafe
-    Then I receive a response code 200
-    And I receive a response postgres0 http://127.0.0.1:8008/patroni
-    When I issue a PATCH request to http://127.0.0.1:8008/config with {"postgresql": {"parameters": {"wal_level": "logical"}}}
-    Then I receive a response code 200
-    When I issue a PATCH request to http://127.0.0.1:8008/config with {"slots": {"dcs_slot_0": {"type": "logical", "database": "postgres", "plugin": "test_decoding"}}}
-    Then I receive a response code 200
-
-  @dcs-failsafe
-  Scenario: check one-node cluster is functioning while DCS is down
-    Given DCS is down
-    Then Response on GET http://127.0.0.1:8008/primary contains failsafe_mode_is_active after 12 seconds
-    And postgres0 role is the primary after 10 seconds
-
-  @dcs-failsafe
-  Scenario: check new replica isn't promoted when leader is down and DCS is up
-    Given DCS is up
-    When I do a backup of postgres0
-    And I shut down postgres0
-    When I start postgres1 in a cluster batman from backup with no_leader
-    And I sleep for 2 seconds
-    Then postgres1 role is the replica after 12 seconds
-
-  Scenario: check leader and replica are both in /failsafe key after leader is back
-    Given I start postgres0
-    And I start postgres1
-    Then "members/postgres0" key in DCS has state=running after 10 seconds
-    And "members/postgres1" key in DCS has state=running after 2 seconds
-    And Response on GET http://127.0.0.1:8009/failsafe contains postgres1 after 10 seconds
-    When I issue a GET request to http://127.0.0.1:8009/failsafe
-    Then I receive a response code 200
-    And I receive a response postgres0 http://127.0.0.1:8008/patroni
-    And I receive a response postgres1 http://127.0.0.1:8009/patroni
-
-  @dcs-failsafe
-  @slot-advance
-  Scenario: check leader and replica are functioning while DCS is down
-    Given logical slot dcs_slot_0 is in sync between postgres0 and postgres1 after 10 seconds
-    And DCS is down
-    Then Response on GET http://127.0.0.1:8008/primary contains failsafe_mode_is_active after 12 seconds
-    Then postgres0 role is the primary after 10 seconds
-    And postgres1 role is the replica after 2 seconds
-    And replication works from postgres0 to postgres1 after 10 seconds
-    And I get all changes from logical slot dcs_slot_0 on postgres0
-    And logical slot dcs_slot_0 is in sync between postgres0 and postgres1 after 20 seconds
-
-  @dcs-failsafe
-  Scenario: check primary is demoted when one replica is shut down and DCS is down
-    Given DCS is down
-    And I kill postgres1
-    And I kill postmaster on postgres1
-    And I sleep for 2 seconds
-    Then postgres0 role is the replica after 12 seconds
-
-  @dcs-failsafe
-  Scenario: check known replica is promoted when leader is down and DCS is up
-    Given I shut down postgres0
-    And DCS is up
-    When I start postgres1
-    Then "members/postgres1" key in DCS has state=running after 10 seconds
-    And postgres1 role is the primary after 25 seconds
-
-  @dcs-failsafe
-  Scenario: check three-node cluster is functioning while DCS is down
-    Given I start postgres0
-    And I start postgres2
-    Then "members/postgres2" key in DCS has state=running after 10 seconds
-    And "members/postgres0" key in DCS has state=running after 20 seconds
-    And Response on GET http://127.0.0.1:8008/failsafe contains postgres2 after 10 seconds
-    And replication works from postgres1 to postgres0 after 10 seconds
-    Given DCS is down
-    Then Response on GET http://127.0.0.1:8008/primary contains failsafe_mode_is_active after 12 seconds
-    Then postgres1 role is the primary after 10 seconds
-    And postgres0 role is the replica after 2 seconds
-    And postgres2 role is the replica after 2 seconds

features/environment.py

@@ -1,13 +1,10 @@
 import abc
 import datetime
-import glob
 import os
 import json
-import psutil
-import re
 import shutil
 import signal
-import stat
+import six
 import subprocess
 import sys
 import tempfile
@@ -17,11 +14,11 @@ import yaml
 
 import patroni.psycopg as psycopg
 
-from http.server import BaseHTTPRequestHandler, HTTPServer
-from patroni.request import PatroniRequest
+from six.moves.BaseHTTPServer import BaseHTTPRequestHandler, HTTPServer
 
 
-class AbstractController(abc.ABC):
+@six.add_metaclass(abc.ABCMeta)
+class AbstractController(object):
 
     def __init__(self, context, name, work_directory, output_dir):
         self._context = context
@@ -52,14 +49,15 @@ class AbstractController(abc.ABC):
         self._log = open(os.path.join(self._output_dir, self._name + '.log'), 'a')
         self._handle = self._start()
 
+        assert self._has_started(), "Process {0} is not running after being started".format(self._name)
+
         max_wait_limit *= self._context.timeout_multiplier
         for _ in range(max_wait_limit):
-            assert self._has_started(), "Process {0} is not running after being started".format(self._name)
             if self._is_accessible():
                 break
             time.sleep(1)
         else:
-            assert False, \
+            assert False,\
                 "{0} instance is not available for queries after {1} seconds".format(self._name, max_wait_limit)
 
     def stop(self, kill=False, timeout=15, _=False):
@@ -101,7 +99,6 @@ class PatroniController(AbstractController):
             self.watchdog = None
 
         self._scope = (custom_config or {}).get('scope', 'batman')
-        self._citus_group = (custom_config or {}).get('citus', {}).get('group')
         self._config = self._make_patroni_test_config(name, custom_config)
         self._closables = []
 
@@ -141,24 +138,12 @@ class PatroniController(AbstractController):
     def _start(self):
         if self.watchdog:
             self.watchdog.start()
-        env = os.environ.copy()
         if isinstance(self._context.dcs_ctl, KubernetesController):
-            self._context.dcs_ctl.create_pod(self._name[8:], self._scope, self._citus_group)
-            env['PATRONI_KUBERNETES_POD_IP'] = '10.0.0.' + self._name[-1]
-        if os.name == 'nt':
-            env['BEHAVE_DEBUG'] = 'true'
-        patroni = subprocess.Popen([sys.executable, '-m', 'coverage', 'run',
-                                   '--source=patroni', '-p', 'patroni.py', self._config], env=env,
-                                   stdout=self._log, stderr=subprocess.STDOUT, cwd=self._work_directory)
-        if os.name == 'nt':
-            patroni.terminate = self.terminate
-        return patroni
-
-    def terminate(self):
-        try:
-            self._context.request_executor.request('POST', self._restapi_url + '/sigterm')
-        except Exception:
-            pass
+            self._context.dcs_ctl.create_pod(self._name[8:], self._scope)
+            os.environ['PATRONI_KUBERNETES_POD_IP'] = '10.0.0.' + self._name[-1]
+        return subprocess.Popen([sys.executable, '-m', 'coverage', 'run',
+                                '--source=patroni', '-p', 'patroni.py', self._config],
+                                stdout=self._log, stderr=subprocess.STDOUT, cwd=self._work_directory)
 
     def stop(self, kill=False, timeout=15, postgres=False):
         if postgres:
@@ -179,61 +164,29 @@ class PatroniController(AbstractController):
         patroni_config_name = self.PATRONI_CONFIG.format(name)
         patroni_config_path = os.path.join(self._output_dir, patroni_config_name)
 
-        with open('postgres0.yml') as f:
+        with open(patroni_config_name) as f:
             config = yaml.safe_load(f)
             config.pop('etcd', None)
 
         raft_port = os.environ.get('RAFT_PORT')
-        # If patroni_raft_controller is suspended two Patroni members is enough to get a quorum,
-        # therefore we don't want Patroni to join as a voting member when testing dcs_failsafe_mode.
-        if raft_port and not self._output_dir.endswith('dcs_failsafe_mode'):
+        if raft_port:
             os.environ['RAFT_PORT'] = str(int(raft_port) + 1)
             config['raft'] = {'data_dir': self._output_dir, 'self_addr': 'localhost:' + os.environ['RAFT_PORT']}
 
-        host = config['restapi']['listen'].rsplit(':', 1)[0]
-        config['restapi']['listen'] = config['restapi']['connect_address'] = '{}:{}'.format(host, 8008 + int(name[-1]))
+        host = config['postgresql']['listen'].split(':')[0]
 
-        host = config['postgresql']['listen'].rsplit(':', 1)[0]
         config['postgresql']['listen'] = config['postgresql']['connect_address'] = '{0}:{1}'.format(host, self.__PORT)
 
         config['name'] = name
-        config['postgresql']['data_dir'] = self._data_dir.replace('\\', '/')
+        config['postgresql']['data_dir'] = self._data_dir
         config['postgresql']['basebackup'] = [{'checkpoint': 'fast'}]
-        config['postgresql']['callbacks'] = {
-            'on_role_change': '{0} features/callback2.py {1}'.format(self._context.pctl.PYTHON, name)}
         config['postgresql']['use_unix_socket'] = os.name != 'nt'  # windows doesn't yet support unix-domain sockets
-        config['postgresql']['use_unix_socket_repl'] = os.name != 'nt'
-        config['postgresql']['pgpass'] = os.path.join(tempfile.gettempdir(), 'pgpass_' + name).replace('\\', '/')
+        config['postgresql']['use_unix_socket_repl'] = os.name != 'nt'  # windows doesn't yet support unix-domain sockets
+        config['postgresql']['pgpass'] = os.path.join(tempfile.gettempdir(), 'pgpass_' + name)
         config['postgresql']['parameters'].update({
-            'logging_collector': 'on', 'log_destination': 'csvlog',
-            'log_directory': self._output_dir.replace('\\', '/'),
+            'logging_collector': 'on', 'log_destination': 'csvlog', 'log_directory': self._output_dir,
             'log_filename': name + '.log', 'log_statement': 'all', 'log_min_messages': 'debug1',
-            'shared_buffers': '1MB', 'unix_socket_directories': tempfile.gettempdir().replace('\\', '/')})
-        config['postgresql']['pg_hba'] = [
-            'local all all trust',
-            'local replication all trust',
-            'host replication replicator all md5',
-            'host all all all md5'
-        ]
-
-        if self._context.postgres_supports_ssl and self._context.certfile:
-            config['postgresql']['parameters'].update({
-                'ssl': 'on',
-                'ssl_ca_file': self._context.certfile.replace('\\', '/'),
-                'ssl_cert_file': self._context.certfile.replace('\\', '/'),
-                'ssl_key_file': self._context.keyfile.replace('\\', '/')
-            })
-            for user in config['postgresql'].get('authentication').keys():
-                config['postgresql'].get('authentication', {}).get(user, {}).update({
-                    'sslmode': 'verify-ca',
-                    'sslrootcert': self._context.certfile,
-                    'sslcert': self._context.certfile,
-                    'sslkey': self._context.keyfile
-                })
-            for i, line in enumerate(list(config['postgresql']['pg_hba'])):
-                if line.endswith('md5'):
-                    # we want to verify client cert first and than password
-                    config['postgresql']['pg_hba'][i] = 'hostssl' + line[4:] + ' clientcert=verify-ca'
+            'unix_socket_directories': tempfile.gettempdir()})
 
         if 'bootstrap' in config:
             config['bootstrap']['post_bootstrap'] = 'psql -w -c "SELECT 1"'
@@ -244,43 +197,26 @@ class PatroniController(AbstractController):
             self.recursive_update(config, custom_config)
 
         self.recursive_update(config, {
-            'bootstrap': {
-                'dcs': {
-                    'loop_wait': 2,
-                    'postgresql': {
-                        'parameters': {
-                            'wal_keep_segments': 100,
-                            'archive_mode': 'on',
-                            'archive_command': (PatroniPoolController.ARCHIVE_RESTORE_SCRIPT
-                                                + ' --mode archive '
-                                                + '--dirname {} --filename %f --pathname %p').format(
-                                                    os.path.join(self._work_directory, 'data', 'wal_archive'))
-                        }
-                    }
-                }
-            }
-        })
+            'bootstrap': {'dcs': {'postgresql': {'parameters': {'wal_keep_segments': 100}}}}})
         if config['postgresql'].get('callbacks', {}).get('on_role_change'):
             config['postgresql']['callbacks']['on_role_change'] += ' ' + str(self.__PORT)
 
         with open(patroni_config_path, 'w') as f:
             yaml.safe_dump(config, f, default_flow_style=False)
 
-        self._connkwargs = config['postgresql'].get('authentication', config['postgresql']).get('superuser', {})
-        self._connkwargs.update({'host': host, 'port': self.__PORT, 'dbname': 'postgres',
-                                 'user': self._connkwargs.pop('username', None)})
+        user = config['postgresql'].get('authentication', config['postgresql']).get('superuser', {})
+        self._connkwargs = {k: user[n] for n, k in [('username', 'user'), ('password', 'password')] if n in user}
+        self._connkwargs.update({'host': host, 'port': self.__PORT, 'dbname': 'postgres'})
 
         self._replication = config['postgresql'].get('authentication', config['postgresql']).get('replication', {})
-        self._replication.update({'host': host, 'port': self.__PORT, 'user': self._replication.pop('username', None)})
-        self._restapi_url = 'http://{0}'.format(config['restapi']['connect_address'])
-        if self._context.certfile:
-            self._restapi_url = self._restapi_url.replace('http://', 'https://')
+        self._replication.update({'host': host, 'port': self.__PORT, 'dbname': 'postgres'})
 
         return patroni_config_path
 
     def _connection(self):
         if not self._conn or self._conn.closed != 0:
             self._conn = psycopg.connect(**self._connkwargs)
+            self._conn.autocommit = True
         return self._conn
 
     def _cursor(self):
@@ -333,23 +269,13 @@ class PatroniController(AbstractController):
 
     @property
     def backup_source(self):
-        def escape(value):
-            return re.sub(r'([\'\\ ])', r'\\\1', str(value))
-
-        return ' '.join('{0}={1}'.format(k, escape(v)) for k, v in self._replication.items())
+        return 'postgres://{username}:{password}@{host}:{port}/{dbname}'.format(**self._replication)
 
     def backup(self, dest=os.path.join('data', 'basebackup')):
         subprocess.call(PatroniPoolController.BACKUP_SCRIPT + ['--walmethod=none',
                         '--datadir=' + os.path.join(self._work_directory, dest),
                         '--dbname=' + self.backup_source])
 
-    def read_patroni_log(self, level):
-        try:
-            with open(str(os.path.join(self._output_dir or '', self._name + ".log"))) as f:
-                return [line for line in f.readlines() if line[24:24 + len(level)] == level]
-        except IOError:
-            return []
-
 
 class ProcessHang(object):
 
@@ -382,7 +308,6 @@ class AbstractDcsController(AbstractController):
 
     def __init__(self, context, mktemp=True):
         work_directory = mktemp and tempfile.mkdtemp() or None
-        self._paused = False
         super(AbstractDcsController, self).__init__(context, self.name(), work_directory, context.pctl.output_dir)
 
     def _is_accessible(self):
@@ -394,22 +319,11 @@ class AbstractDcsController(AbstractController):
         if self._work_directory:
             shutil.rmtree(self._work_directory)
 
-    def path(self, key=None, scope='batman', group=None):
-        citus_group = '/{0}'.format(group) if group is not None else ''
-        return self._CLUSTER_NODE.format(scope) + citus_group + (key and '/' + key or '')
-
-    def start_outage(self):
-        if not self._paused and self._handle:
-            self._handle.suspend()
-            self._paused = True
-
-    def stop_outage(self):
-        if self._paused and self._handle:
-            self._handle.resume()
-            self._paused = False
+    def path(self, key=None, scope='batman'):
+        return self._CLUSTER_NODE.format(scope) + (key and '/' + key or '')
 
     @abc.abstractmethod
-    def query(self, key, scope='batman', group=None):
+    def query(self, key, scope='batman'):
         """ query for a value of a given key """
 
     @abc.abstractmethod
@@ -443,8 +357,8 @@ class ConsulController(AbstractDcsController):
         self._config_file = self._work_directory + '.json'
         with open(self._config_file, 'wb') as f:
             f.write(b'{"session_ttl_min":"5s","server":true,"bootstrap":true,"advertise_addr":"127.0.0.1"}')
-        return psutil.Popen(['consul', 'agent', '-config-file', self._config_file, '-data-dir',
-                             self._work_directory], stdout=self._log, stderr=subprocess.STDOUT)
+        return subprocess.Popen(['consul', 'agent', '-config-file', self._config_file, '-data-dir',
+                                 self._work_directory], stdout=self._log, stderr=subprocess.STDOUT)
 
     def stop(self, kill=False, timeout=15):
         super(ConsulController, self).stop(kill=kill, timeout=timeout)
@@ -457,11 +371,11 @@ class ConsulController(AbstractDcsController):
         except Exception:
             return False
 
-    def path(self, key=None, scope='batman', group=None):
-        return super(ConsulController, self).path(key, scope, group)[1:]
+    def path(self, key=None, scope='batman'):
+        return super(ConsulController, self).path(key, scope)[1:]
 
-    def query(self, key, scope='batman', group=None):
-        _, value = self._client.kv.get(self.path(key, scope, group))
+    def query(self, key, scope='batman'):
+        _, value = self._client.kv.get(self.path(key, scope))
         return value and value['Value'].decode('utf-8')
 
     def cleanup_service_tree(self):
@@ -480,8 +394,8 @@ class AbstractEtcdController(AbstractDcsController):
         self._client_cls = client_cls
 
     def _start(self):
-        return psutil.Popen(["etcd", "--enable-v2=true", "--data-dir", self._work_directory],
-                            stdout=self._log, stderr=subprocess.STDOUT)
+        return subprocess.Popen(["etcd", "--debug", "--data-dir", self._work_directory],
+                                stdout=self._log, stderr=subprocess.STDOUT)
 
     def _is_running(self):
         from patroni.dcs.etcd import DnsCachingResolver
@@ -501,10 +415,10 @@ class EtcdController(AbstractEtcdController):
         super(EtcdController, self).__init__(context, EtcdClient)
         os.environ['PATRONI_ETCD_HOST'] = 'localhost:2379'
 
-    def query(self, key, scope='batman', group=None):
+    def query(self, key, scope='batman'):
         import etcd
         try:
-            return self._client.get(self.path(key, scope, group)).value
+            return self._client.get(self.path(key, scope)).value
         except etcd.EtcdKeyNotFound:
             return None
 
@@ -525,9 +439,9 @@ class Etcd3Controller(AbstractEtcdController):
         super(Etcd3Controller, self).__init__(context, Etcd3Client)
         os.environ['PATRONI_ETCD3_HOST'] = 'localhost:2379'
 
-    def query(self, key, scope='batman', group=None):
+    def query(self, key, scope='batman'):
         import base64
-        response = self._client.range(self.path(key, scope, group))
+        response = self._client.range(self.path(key, scope))
         for k in response.get('kvs', []):
             return base64.b64decode(k['value']).decode('utf-8') if 'value' in k else None
 
@@ -538,43 +452,7 @@ class Etcd3Controller(AbstractEtcdController):
             assert False, "exception when cleaning up etcd contents: {0}".format(e)
 
 
-class AbstractExternalDcsController(AbstractDcsController):
-
-    def __init__(self, context, mktemp=True):
-        super(AbstractExternalDcsController, self).__init__(context, mktemp)
-        self._wrapper = ['sudo']
-
-    def _start(self):
-        return self._external_pid
-
-    def start_outage(self):
-        if not self._paused:
-            subprocess.call(self._wrapper + ['kill', '-SIGSTOP', self._external_pid])
-            self._paused = True
-
-    def stop_outage(self):
-        if self._paused:
-            subprocess.call(self._wrapper + ['kill', '-SIGCONT', self._external_pid])
-            self._paused = False
-
-    def _has_started(self):
-        return True
-
-    @abc.abstractmethod
-    def process_name():
-        """process name to search with pgrep"""
-
-    def _is_running(self):
-        if not self._handle:
-            self._external_pid = subprocess.check_output(['pgrep', '-nf', self.process_name()]).decode('utf-8').strip()
-            return False
-        return True
-
-    def stop(self):
-        pass
-
-
-class KubernetesController(AbstractExternalDcsController):
+class KubernetesController(AbstractDcsController):
 
     def __init__(self, context):
         super(KubernetesController, self).__init__(context)
@@ -583,48 +461,19 @@ class KubernetesController(AbstractExternalDcsController):
         self._label_selector = ','.join('{0}={1}'.format(k, v) for k, v in self._labels.items())
         os.environ['PATRONI_KUBERNETES_LABELS'] = json.dumps(self._labels)
         os.environ['PATRONI_KUBERNETES_USE_ENDPOINTS'] = 'true'
-        os.environ.setdefault('PATRONI_KUBERNETES_BYPASS_API_SERVICE', 'true')
+        os.environ['PATRONI_KUBERNETES_BYPASS_API_SERVICE'] = 'true'
 
         from patroni.dcs.kubernetes import k8s_client, k8s_config
-        k8s_config.load_kube_config(context=os.environ.setdefault('PATRONI_KUBERNETES_CONTEXT', 'kind-kind'))
+        k8s_config.load_kube_config(context='local')
         self._client = k8s_client
         self._api = self._client.CoreV1Api()
 
-    def process_name(self):
-        return "localkube"
+    def _start(self):
+        pass
 
-    def _is_running(self):
-        if not self._handle:
-            context = os.environ.get('PATRONI_KUBERNETES_CONTEXT')
-            if context.startswith('kind-'):
-                container = '{0}-control-plane'.format(context[5:])
-                api_process = 'kube-apiserver'
-            elif context.startswith('k3d-'):
-                container = '{0}-server-0'.format(context)
-                api_process = 'k3s server'
-            else:
-                return super(KubernetesController, self)._is_running()
-            try:
-                docker = 'docker'
-                with open(os.devnull, 'w') as null:
-                    if subprocess.call([docker, 'info'], stdout=null, stderr=null) != 0:
-                        raise Exception
-            except Exception:
-                docker = 'podman'
-                with open(os.devnull, 'w') as null:
-                    if subprocess.call([docker, 'info'], stdout=null, stderr=null) != 0:
-                        raise Exception
-            self._wrapper = [docker, 'exec', container]
-            self._external_pid = subprocess.check_output(self._wrapper + ['pidof', api_process]).decode('utf-8').strip()
-            return False
-        return True
-
-    def create_pod(self, name, scope, group=None):
-        self.delete_pod(name)
+    def create_pod(self, name, scope):
         labels = self._labels.copy()
         labels['cluster-name'] = scope
-        if group is not None:
-            labels['citus-group'] = str(group)
         metadata = self._client.V1ObjectMeta(namespace=self._namespace, name=name, labels=labels)
         spec = self._client.V1PodSpec(containers=[self._client.V1Container(name=name, image='empty')])
         body = self._client.V1Pod(metadata=metadata, spec=spec)
@@ -641,14 +490,12 @@ class KubernetesController(AbstractExternalDcsController):
             except Exception:
                 break
 
-    def query(self, key, scope='batman', group=None):
+    def query(self, key, scope='batman'):
         if key.startswith('members/'):
             pod = self._api.read_namespaced_pod(key[8:], self._namespace)
             return (pod.metadata.annotations or {}).get('status', '')
         else:
             try:
-                if group is not None:
-                    scope = '{0}-{1}'.format(scope, group)
                 ep = scope + {'leader': '', 'history': '-config', 'initialize': '-config'}.get(key, '-' + key)
                 e = self._api.read_namespaced_endpoints(ep, self._namespace)
                 if key != 'sync':
@@ -673,8 +520,11 @@ class KubernetesController(AbstractExternalDcsController):
             if len(result.items) < 1:
                 break
 
+    def _is_running(self):
+        return True
 
-class ZooKeeperController(AbstractExternalDcsController):
+
+class ZooKeeperController(AbstractDcsController):
 
     """ handles all zookeeper related tasks, used for the tests setup and cleanup """
 
@@ -686,13 +536,13 @@ class ZooKeeperController(AbstractExternalDcsController):
         import kazoo.client
         self._client = kazoo.client.KazooClient()
 
-    def process_name(self):
-        return "zookeeper"
+    def _start(self):
+        pass  # TODO: implement later
 
-    def query(self, key, scope='batman', group=None):
+    def query(self, key, scope='batman'):
         import kazoo.exceptions
         try:
-            return self._client.get(self.path(key, scope, group))[0].decode('utf-8')
+            return self._client.get(self.path(key, scope))[0].decode('utf-8')
         except kazoo.exceptions.NoNodeError:
             return None
 
@@ -706,9 +556,6 @@ class ZooKeeperController(AbstractExternalDcsController):
             assert False, "exception when cleaning up zookeeper contents: {0}".format(e)
 
     def _is_running(self):
-        if not super(ZooKeeperController, self)._is_running():
-            return False
-
         # if zookeeper is running, but we didn't start it
         if self._client.connected:
             return True
@@ -758,12 +605,12 @@ class RaftController(AbstractDcsController):
         del env['PATRONI_RAFT_PARTNER_ADDRS']
         env['PATRONI_RAFT_SELF_ADDR'] = self.CONTROLLER_ADDR
         env['PATRONI_RAFT_DATA_DIR'] = self._work_directory
-        return psutil.Popen([sys.executable, '-m', 'coverage', 'run',
-                             '--source=patroni', '-p', 'patroni_raft_controller.py'],
-                            stdout=self._log, stderr=subprocess.STDOUT, env=env)
+        return subprocess.Popen([sys.executable, '-m', 'coverage', 'run',
+                                '--source=patroni', '-p', 'patroni_raft_controller.py'],
+                                stdout=self._log, stderr=subprocess.STDOUT, env=env)
 
-    def query(self, key, scope='batman', group=None):
-        ret = self._raft.get(self.path(key, scope, group))
+    def query(self, key, scope='batman'):
+        ret = self._raft.get(self.path(key, scope))
         return ret and ret['value']
 
     def set(self, key, value):
@@ -779,18 +626,15 @@ class RaftController(AbstractDcsController):
             self.start()
 
         ready_event = threading.Event()
-        self._raft = KVStoreTTL(ready_event.set, None, None,
-                                partner_addrs=[self.CONTROLLER_ADDR], password=self.PASSWORD)
+        self._raft = KVStoreTTL(ready_event.set, None, None, partner_addrs=[self.CONTROLLER_ADDR], password=self.PASSWORD)
         self._raft.startAutoTick()
         ready_event.wait()
 
 
 class PatroniPoolController(object):
 
-    PYTHON = sys.executable.replace('\\', '/')
-    BACKUP_SCRIPT = [PYTHON, 'features/backup_create.py']
-    BACKUP_RESTORE_SCRIPT = ' '.join((PYTHON, os.path.abspath('features/backup_restore.py'))).replace('\\', '/')
-    ARCHIVE_RESTORE_SCRIPT = ' '.join((PYTHON, os.path.abspath('features/archive-restore.py')))
+    BACKUP_SCRIPT = [sys.executable, 'features/backup_create.py']
+    ARCHIVE_RESTORE_SCRIPT = ' '.join((sys.executable, os.path.abspath('features/archive-restore.py')))
 
     def __init__(self, context):
         self._context = context
@@ -799,17 +643,8 @@ class PatroniPoolController(object):
         self._patroni_path = None
         self._processes = {}
         self.create_and_set_output_directory('')
-        self._check_postgres_ssl()
         self.known_dcs = {subclass.name(): subclass for subclass in AbstractDcsController.get_subclasses()}
 
-    def _check_postgres_ssl(self):
-        try:
-            subprocess.check_output(['postgres', '-D', os.devnull, '-c', 'ssl=on'], stderr=subprocess.STDOUT)
-            raise Exception  # this one should never happen because the previous line will always raise and exception
-        except Exception as e:
-            self._context.postgres_supports_ssl = isinstance(e, subprocess.CalledProcessError)\
-                and 'SSL is not supported by this build' not in e.output.decode()
-
     @property
     def patroni_path(self):
         if self._patroni_path is None:
@@ -833,7 +668,7 @@ class PatroniPoolController(object):
 
     def __getattr__(self, func):
         if func not in ['stop', 'query', 'write_label', 'read_label', 'check_role_has_changed_to',
-                        'add_tag_to_config', 'get_watchdog', 'patroni_hang', 'backup', 'read_patroni_log']:
+                        'add_tag_to_config', 'get_watchdog', 'patroni_hang', 'backup']:
             raise AttributeError("PatroniPoolController instance has no attribute '{0}'".format(func))
 
         def wrapper(name, *args, **kwargs):
@@ -860,8 +695,7 @@ class PatroniPoolController(object):
             'bootstrap': {
                 'method': 'pg_basebackup',
                 'pg_basebackup': {
-                    'command': " ".join(self.BACKUP_SCRIPT
-                                        + ['--walmethod=stream', '--dbname="{0}"'.format(f.backup_source)])
+                    'command': " ".join(self.BACKUP_SCRIPT) + ' --walmethod=stream --dbname=' + f.backup_source
                 },
                 'dcs': {
                     'postgresql': {
@@ -874,9 +708,9 @@ class PatroniPoolController(object):
             'postgresql': {
                 'parameters': {
                     'archive_mode': 'on',
-                    'archive_command': (self.ARCHIVE_RESTORE_SCRIPT + ' --mode archive '
-                                        + '--dirname {} --filename %f --pathname %p')
-                    .format(os.path.join(self.patroni_path, 'data', 'wal_archive_clone').replace('\\', '/'))
+                    'archive_command': (self.ARCHIVE_RESTORE_SCRIPT + ' --mode archive ' +
+                                        '--dirname {} --filename %f --pathname %p').format(
+                                        os.path.join(self.patroni_path, 'data', 'wal_archive'))
                 },
                 'authentication': {
                     'superuser': {'password': 'zalando1'},
@@ -892,14 +726,14 @@ class PatroniPoolController(object):
             'bootstrap': {
                 'method': 'backup_restore',
                 'backup_restore': {
-                    'command': (self.BACKUP_RESTORE_SCRIPT + ' --sourcedir='
-                                + os.path.join(self.patroni_path, 'data', 'basebackup').replace('\\', '/')),
+                    'command': (sys.executable + ' features/backup_restore.py --sourcedir=' +
+                                os.path.join(self.patroni_path, 'data', 'basebackup')),
                     'recovery_conf': {
                         'recovery_target_action': 'promote',
                         'recovery_target_timeline': 'latest',
-                        'restore_command': (self.ARCHIVE_RESTORE_SCRIPT + ' --mode restore '
-                                            + '--dirname {} --filename %f --pathname %p').format(
-                            os.path.join(self.patroni_path, 'data', 'wal_archive_clone').replace('\\', '/'))
+                        'restore_command': (self.ARCHIVE_RESTORE_SCRIPT + ' --mode restore ' +
+                                            '--dirname {} --filename %f --pathname %p').format(
+                                            os.path.join(self.patroni_path, 'data', 'wal_archive'))
                     }
                 }
             },
@@ -912,25 +746,6 @@ class PatroniPoolController(object):
         }
         self.start(name, custom_config=custom_config)
 
-    def bootstrap_from_backup_no_leader(self, name, cluster_name):
-        custom_config = {
-            'scope': cluster_name,
-            'postgresql': {
-                'recovery_conf': {
-                    'restore_command': (self.ARCHIVE_RESTORE_SCRIPT + ' --mode restore '
-                                        + '--dirname {} --filename %f --pathname %p')
-                    .format(os.path.join(self.patroni_path, 'data', 'wal_archive').replace('\\', '/'))
-                },
-                'create_replica_methods': ['no_leader_bootstrap'],
-                'no_leader_bootstrap': {
-                    'command': (self.BACKUP_RESTORE_SCRIPT + ' --sourcedir='
-                                + os.path.join(self.patroni_path, 'data', 'basebackup').replace('\\', '/')),
-                    'no_leader': '1'
-                }
-            }
-        }
-        self.start(name, custom_config=custom_config)
-
     @property
     def dcs(self):
         if self._dcs is None:
@@ -1057,36 +872,10 @@ class WatchdogMonitor(object):
 
 # actions to execute on start/stop of the tests and before running individual features
 def before_all(context):
-    context.ci = os.name == 'nt' or\
-        any(a in os.environ for a in ('TRAVIS_BUILD_NUMBER', 'BUILD_NUMBER', 'GITHUB_ACTIONS'))
+    os.environ.update({'PATRONI_RESTAPI_USERNAME': 'username', 'PATRONI_RESTAPI_PASSWORD': 'password'})
+    context.ci = any(a in os.environ for a in ('TRAVIS_BUILD_NUMBER', 'BUILD_NUMBER', 'GITHUB_ACTIONS'))
     context.timeout_multiplier = 5 if context.ci else 1  # MacOS sometimes is VERY slow
     context.pctl = PatroniPoolController(context)
-
-    context.keyfile = os.path.join(context.pctl.output_dir, 'patroni.key')
-    context.certfile = os.path.join(context.pctl.output_dir, 'patroni.crt')
-    try:
-        with open(os.devnull, 'w') as null:
-            ret = subprocess.call(['openssl', 'req', '-nodes', '-new', '-x509', '-subj', '/CN=batman.patroni',
-                                   '-addext', 'subjectAltName=IP:127.0.0.1', '-keyout', context.keyfile,
-                                   '-out', context.certfile], stdout=null, stderr=null)
-            if ret != 0:
-                raise Exception
-            os.chmod(context.keyfile, stat.S_IWRITE | stat.S_IREAD)
-    except Exception:
-        context.keyfile = context.certfile = None
-
-    os.environ.update({'PATRONI_RESTAPI_USERNAME': 'username', 'PATRONI_RESTAPI_PASSWORD': 'password'})
-    ctl = {'auth': os.environ['PATRONI_RESTAPI_USERNAME'] + ':' + os.environ['PATRONI_RESTAPI_PASSWORD']}
-    if context.certfile:
-        os.environ.update({'PATRONI_RESTAPI_CAFILE': context.certfile,
-                           'PATRONI_RESTAPI_CERTFILE': context.certfile,
-                           'PATRONI_RESTAPI_KEYFILE': context.keyfile,
-                           'PATRONI_RESTAPI_VERIFY_CLIENT': 'required',
-                           'PATRONI_CTL_INSECURE': 'on',
-                           'PATRONI_CTL_CERTFILE': context.certfile,
-                           'PATRONI_CTL_KEYFILE': context.keyfile})
-        ctl.update({'cacert': context.certfile, 'certfile': context.certfile, 'keyfile': context.keyfile})
-    context.request_executor = PatroniRequest({'ctl': ctl}, True)
     context.dcs_ctl = context.pctl.known_dcs[context.pctl.dcs](context)
     context.dcs_ctl.start()
     try:
@@ -1104,47 +893,13 @@ def after_all(context):
 
 def before_feature(context, feature):
     """ create per-feature output directory to collect Patroni and PostgreSQL logs """
-    if feature.name == 'watchdog' and os.name == 'nt':
-        return feature.skip("Watchdog isn't supported on Windows")
-    elif feature.name == 'citus':
-        lib = subprocess.check_output(['pg_config', '--pkglibdir']).decode('utf-8').strip()
-        if not os.path.exists(os.path.join(lib, 'citus.so')):
-            return feature.skip("Citus extenstion isn't available")
     context.pctl.create_and_set_output_directory(feature.name)
 
 
 def after_feature(context, feature):
-    """ send SIGCONT to a dcs if neccessary,
-    stop all Patronis remove their data directory and cleanup the keys in etcd """
-    context.dcs_ctl.stop_outage()
+    """ stop all Patronis, remove their data directory and cleanup the keys in etcd """
     context.pctl.stop_all()
-    data = os.path.join(context.pctl.patroni_path, 'data')
-    if os.path.exists(data):
-        shutil.rmtree(data)
+    shutil.rmtree(os.path.join(context.pctl.patroni_path, 'data'))
     context.dcs_ctl.cleanup_service_tree()
-
-    found = False
-    logs = glob.glob(context.pctl.output_dir + '/patroni_*.log')
-    for log in logs:
-        with open(log) as f:
-            for line in f:
-                if 'please report it as a BUG' in line:
-                    print(':'.join([log, line.rstrip()]))
-                    found = True
-
-    if feature.status == 'failed' or found:
+    if feature.status == 'failed':
         shutil.copytree(context.pctl.output_dir, context.pctl.output_dir + '_failed')
-    if found:
-        raise Exception('Unexpected errors in Patroni log files')
-
-
-def before_scenario(context, scenario):
-    if 'slot-advance' in scenario.effective_tags:
-        for p in context.pctl._processes.values():
-            if p._conn and p._conn.server_version < 110000:
-                scenario.skip('pg_replication_slot_advance() is not supported on {0}'.format(p._conn.server_version))
-                break
-    if 'dcs-failsafe' in scenario.effective_tags and not context.dcs_ctl._handle:
-        scenario.skip('it is not possible to control state of {0} from tests'.format(context.dcs_ctl.name()))
-    if 'reject-duplicate-name' in scenario.effective_tags and context.dcs_ctl.name() == 'raft':
-        scenario.skip('Flaky test with Raft')

features/ignored_slots.feature

@@ -3,14 +3,14 @@ Feature: ignored slots
     Given I start postgres1
     Then postgres1 is a leader after 10 seconds
     And there is a non empty initialize key in DCS after 15 seconds
-    When I issue a PATCH request to http://127.0.0.1:8009/config with {"ignore_slots": [{"name": "unmanaged_slot_0", "database": "postgres", "plugin": "test_decoding", "type": "logical"}, {"name": "unmanaged_slot_1", "database": "postgres", "plugin": "test_decoding"}, {"name": "unmanaged_slot_2", "database": "postgres"}, {"name": "unmanaged_slot_3"}], "postgresql": {"parameters": {"wal_level": "logical"}}}
+    When I issue a PATCH request to http://127.0.0.1:8009/config with {"loop_wait": 2, "ignore_slots": [{"name": "unmanaged_slot_0", "database": "postgres", "plugin": "test_decoding", "type": "logical"}, {"name": "unmanaged_slot_1", "database": "postgres", "plugin": "test_decoding"}, {"name": "unmanaged_slot_2", "database": "postgres"}, {"name": "unmanaged_slot_3"}], "postgresql": {"parameters": {"wal_level": "logical"}}}
     Then I receive a response code 200
     And Response on GET http://127.0.0.1:8009/config contains ignore_slots after 10 seconds
     # Make sure the wal_level has been changed.
     When I shut down postgres1
     And I start postgres1
     Then postgres1 is a leader after 10 seconds
-    And "members/postgres1" key in DCS has role=master after 10 seconds
+    And "members/postgres1" key in DCS has role=master after 3 seconds
     # Make sure Patroni has finished telling Postgres it should be accepting writes.
     And postgres1 role is the primary after 20 seconds
     # 1. Create our test logical replication slot.
@@ -31,19 +31,19 @@ Feature: ignored slots
     And postgres1 has a logical replication slot named unmanaged_slot_3 with the test_decoding plugin
 
     When I start postgres0
-    Then "members/postgres0" key in DCS has role=replica after 10 seconds
+    Then "members/postgres0" key in DCS has role=replica after 3 seconds
     And postgres0 role is the secondary after 20 seconds
     # Verify that the replica has advanced beyond the point in the WAL
     # where we created the replication slot so that on the next failover
     # cycle we don't accidentally rewind to before the slot creation.
     And replication works from postgres1 to postgres0 after 20 seconds
     When I shut down postgres1
-    Then "members/postgres0" key in DCS has role=master after 10 seconds
+    Then "members/postgres0" key in DCS has role=master after 3 seconds
 
     # 2. After a failover the server (now a replica) still has the slot.
     When I start postgres1
     Then postgres1 role is the secondary after 20 seconds
-    And "members/postgres1" key in DCS has role=replica after 10 seconds
+    And "members/postgres1" key in DCS has role=replica after 3 seconds
     # give Patroni time to sync replication slots
     And I sleep for 2 seconds
     And postgres1 has a logical replication slot named unmanaged_slot_0 with the test_decoding plugin
@@ -52,9 +52,9 @@ Feature: ignored slots
     And postgres1 has a logical replication slot named unmanaged_slot_3 with the test_decoding plugin
     And postgres1 does not have a logical replication slot named dummy_slot
 
-    # 3. After a failover the server (now a primary) still has the slot.
+    # 3. After a failover the server (now a master) still has the slot.
     When I shut down postgres0
-    Then "members/postgres1" key in DCS has role=master after 10 seconds
+    Then "members/postgres1" key in DCS has role=master after 3 seconds
     And postgres1 has a logical replication slot named unmanaged_slot_0 with the test_decoding plugin
     And postgres1 has a logical replication slot named unmanaged_slot_1 with the test_decoding plugin
     And postgres1 has a logical replication slot named unmanaged_slot_2 with the test_decoding plugin

features/patroni_api.feature

@@ -14,9 +14,9 @@ Scenario: check API requests on a stand-alone server
 	Then I receive a response code 200
 	When I issue a GET request to http://127.0.0.1:8008/replica
 	Then I receive a response code 503
-	When I issue a POST request to http://127.0.0.1:8008/reinitialize with {"force": true}
-	Then I receive a response code 503
-	And I receive a response text I am the leader, can not reinitialize
+	When I run patronictl.py reinit batman postgres0 --force
+	Then I receive a response returncode 0
+	And I receive a response output "Failed: reinitialize for member postgres0, status code=503, (I am the leader, can not reinitialize)"
 	When I run patronictl.py switchover batman --master postgres0 --force
 	Then I receive a response returncode 1
 	And I receive a response output "Error: No candidates found to switchover to"
@@ -35,30 +35,30 @@ Scenario: check local configuration reload
 	Then I receive a response code 202
 
 Scenario: check dynamic configuration change via DCS
-	Given I issue a PATCH request to http://127.0.0.1:8008/config with {"ttl": 20, "postgresql": {"parameters": {"max_connections": "101"}}}
-	Then I receive a response code 200
+	Given I run patronictl.py edit-config -s 'ttl=10' -s 'loop_wait=2' -p 'max_connections=101' --force batman
+	Then I receive a response returncode 0
+	And I receive a response output "+loop_wait: 2"
 	And Response on GET http://127.0.0.1:8008/patroni contains pending_restart after 11 seconds
 	When I issue a GET request to http://127.0.0.1:8008/config
 	Then I receive a response code 200
-	And I receive a response ttl 20
+	And I receive a response loop_wait 2
 	When I issue a GET request to http://127.0.0.1:8008/patroni
 	Then I receive a response code 200
 	And I receive a response tags {'new_tag': 'new_value'}
 	And I sleep for 4 seconds
 
 Scenario: check the scheduled restart
-	Given I run patronictl.py edit-config -p 'superuser_reserved_connections=6' --force batman
-	Then I receive a response returncode 0
-	And I receive a response output "+    superuser_reserved_connections: 6"
-	And Response on GET http://127.0.0.1:8008/patroni contains pending_restart after 5 seconds
+	Given I issue a PATCH request to http://127.0.0.1:8008/config with {"postgresql": {"parameters": {"superuser_reserved_connections": "6"}}}
+	Then I receive a response code 200
+		And Response on GET http://127.0.0.1:8008/patroni contains pending_restart after 5 seconds
 	Given I issue a scheduled restart at http://127.0.0.1:8008 in 5 seconds with {"role": "replica"}
 	Then I receive a response code 202
-	And I sleep for 8 seconds
-	And Response on GET http://127.0.0.1:8008/patroni contains pending_restart after 10 seconds
+		And I sleep for 8 seconds
+		And Response on GET http://127.0.0.1:8008/patroni contains pending_restart after 10 seconds
 	Given I issue a scheduled restart at http://127.0.0.1:8008 in 5 seconds with {"restart_pending": "True"}
 	Then I receive a response code 202
-	And Response on GET http://127.0.0.1:8008/patroni does not contain pending_restart after 10 seconds
-	And postgres0 role is the primary after 10 seconds
+		And Response on GET http://127.0.0.1:8008/patroni does not contain pending_restart after 10 seconds
+		And postgres0 role is the primary after 10 seconds
 
 Scenario: check API requests for the primary-replica pair in the pause mode
 	Given I start postgres1
@@ -79,12 +79,12 @@ Scenario: check API requests for the primary-replica pair in the pause mode
 	When I run patronictl.py reinit batman postgres1 --force
 	Then I receive a response returncode 0
 	And I receive a response output "Success: reinitialize for member postgres1"
-	And postgres1 role is the secondary after 30 seconds
-	And replication works from postgres0 to postgres1 after 20 seconds
 	When I run patronictl.py restart batman postgres0 --force
 	Then I receive a response returncode 0
 	And I receive a response output "Success: restart on member postgres0"
 	And postgres0 role is the primary after 5 seconds
+	When I sleep for 10 seconds
+	Then postgres1 role is the secondary after 15 seconds
 
 Scenario: check the switchover via the API in the pause mode
 	Given I issue a POST request to http://127.0.0.1:8008/switchover with {"leader": "postgres0", "candidate": "postgres1"}
@@ -94,11 +94,11 @@ Scenario: check the switchover via the API in the pause mode
 	And postgres0 role is the secondary after 10 seconds
 	And replication works from postgres1 to postgres0 after 20 seconds
 	And "members/postgres0" key in DCS has state=running after 10 seconds
-	When I issue a GET request to http://127.0.0.1:8008/primary
+	When I issue a GET request to http://127.0.0.1:8008/master
 	Then I receive a response code 503
 	When I issue a GET request to http://127.0.0.1:8008/replica
 	Then I receive a response code 200
-	When I issue a GET request to http://127.0.0.1:8009/primary
+	When I issue a GET request to http://127.0.0.1:8009/master
 	Then I receive a response code 200
 	When I issue a GET request to http://127.0.0.1:8009/replica
 	Then I receive a response code 503
@@ -109,18 +109,18 @@ Scenario: check the scheduled switchover
 	And I receive a response output "Can't schedule switchover in the paused state"
 	When I run patronictl.py resume batman
 	Then I receive a response returncode 0
-	Given I issue a scheduled switchover from postgres1 to postgres0 in 10 seconds
+	Given I issue a scheduled switchover from postgres1 to postgres0 in 5 seconds
 	Then I receive a response returncode 0
 	And postgres0 is a leader after 20 seconds
 	And postgres0 role is the primary after 10 seconds
 	And postgres1 role is the secondary after 10 seconds
 	And replication works from postgres0 to postgres1 after 25 seconds
 	And "members/postgres1" key in DCS has state=running after 10 seconds
-	When I issue a GET request to http://127.0.0.1:8008/primary
+	When I issue a GET request to http://127.0.0.1:8008/master
 	Then I receive a response code 200
 	When I issue a GET request to http://127.0.0.1:8008/replica
 	Then I receive a response code 503
-	When I issue a GET request to http://127.0.0.1:8009/primary
+	When I issue a GET request to http://127.0.0.1:8009/master
 	Then I receive a response code 503
 	When I issue a GET request to http://127.0.0.1:8009/replica
 	Then I receive a response code 200

features/recovery.feature

@@ -1,24 +0,0 @@
-Feature: recovery
-  We want to check that crashed postgres is started back
-
-  Scenario: check that timeline is not incremented when primary is started after crash
-    Given I start postgres0
-    Then postgres0 is a leader after 10 seconds
-    And there is a non empty initialize key in DCS after 15 seconds
-    When I start postgres1
-    And I add the table foo to postgres0
-    Then table foo is present on postgres1 after 20 seconds
-    When I kill postmaster on postgres0
-    Then postgres0 role is the primary after 10 seconds
-    When I issue a GET request to http://127.0.0.1:8008/
-    Then I receive a response code 200
-    And I receive a response role master
-    And I receive a response timeline 1
-
-  Scenario: check immediate failover when master_start_timeout=0
-    Given I issue a PATCH request to http://127.0.0.1:8008/config with {"master_start_timeout": 0}
-    Then I receive a response code 200
-    And Response on GET http://127.0.0.1:8008/config contains master_start_timeout after 10 seconds
-    When I kill postmaster on postgres0
-    Then postgres1 is a leader after 10 seconds
-    And postgres1 role is the primary after 10 seconds

features/standby_cluster.feature

@@ -3,7 +3,7 @@ Feature: standby cluster
     Given I start postgres1
     Then postgres1 is a leader after 10 seconds
     And there is a non empty initialize key in DCS after 15 seconds
-    When I issue a PATCH request to http://127.0.0.1:8009/config with {"slots": {"pm_1": {"type": "physical"}}, "postgresql": {"parameters": {"wal_level": "logical"}}}
+    When I issue a PATCH request to http://127.0.0.1:8009/config with {"loop_wait": 2, "slots": {"pm_1": {"type": "physical"}}, "postgresql": {"parameters": {"wal_level": "logical"}}}
     Then I receive a response code 200
     And Response on GET http://127.0.0.1:8009/config contains slots after 10 seconds
     And I sleep for 3 seconds
@@ -13,12 +13,8 @@ Feature: standby cluster
     When I start postgres0
     Then "members/postgres0" key in DCS has state=running after 10 seconds
     And replication works from postgres1 to postgres0 after 15 seconds
-    When I issue a GET request to http://127.0.0.1:8008/patroni
-    Then I receive a response code 200
-    And I receive a response replication_state streaming
-    And "members/postgres0" key in DCS has replication_state=streaming after 10 seconds
 
-  @slot-advance
+  @skip
   Scenario: check permanent logical slots are synced to the replica
     Given I run patronictl.py restart batman postgres1 --force
     Then Logical slot test_logical is in sync between postgres0 and postgres1 after 10 seconds
@@ -38,11 +34,8 @@ Feature: standby cluster
     Then postgres1 is a leader of batman1 after 10 seconds
     When I add the table foo to postgres0
     Then table foo is present on postgres1 after 20 seconds
-    When I issue a GET request to http://127.0.0.1:8009/patroni
-    Then I receive a response code 200
-    And I receive a response replication_state streaming
     And I sleep for 3 seconds
-    When I issue a GET request to http://127.0.0.1:8009/primary
+    When I issue a GET request to http://127.0.0.1:8009/master
     Then I receive a response code 503
     When I issue a GET request to http://127.0.0.1:8009/standby_leader
     Then I receive a response code 200
@@ -51,16 +44,13 @@ Feature: standby cluster
     When I start postgres2 in a cluster batman1
     Then postgres2 role is the replica after 24 seconds
     And table foo is present on postgres2 after 20 seconds
-    When I issue a GET request to http://127.0.0.1:8010/patroni
-    Then I receive a response code 200
-    And I receive a response replication_state streaming
     And postgres1 does not have a logical replication slot named test_logical
 
   Scenario: check failover
     When I kill postgres1
     And I kill postmaster on postgres1
     Then postgres2 is replicating from postgres0 after 32 seconds
-    When I issue a GET request to http://127.0.0.1:8010/primary
+    When I issue a GET request to http://127.0.0.1:8010/master
     Then I receive a response code 503
     And I sleep for 3 seconds
     When I issue a GET request to http://127.0.0.1:8010/standby_leader

features/steps/basic_replication.py

@@ -9,22 +9,6 @@ def start_patroni(context, name):
     return context.pctl.start(name)
 
 
-@step('I start duplicate {name:w} on port {port:d}')
-def start_duplicate_patroni(context, name, port):
-    config = {
-        "name": name,
-        "restapi": {
-            "listen": "127.0.0.1:{0}".format(port)
-        }
-    }
-    try:
-        context.pctl.start('dup-' + name, custom_config=config)
-        assert False, "Process was expected to fail"
-    except AssertionError as e:
-        assert 'is not running after being started' in str(e), \
-            "No error was raised by duplicate start of {0} ".format(name)
-
-
 @step('I shut down {name:w}')
 def stop_patroni(context, name):
     return context.pctl.stop(name, timeout=60)
@@ -44,7 +28,7 @@ def stop_postgres(context, name):
 def add_table(context, table_name, pg_name):
     # parse the configuration file and get the port
     try:
-        context.pctl.query(pg_name, "CREATE TABLE public.{0}()".format(table_name))
+        context.pctl.query(pg_name, "CREATE TABLE {0}()".format(table_name))
     except pg.Error as e:
         assert False, "Error creating table {0} on {1}: {2}".format(table_name, pg_name, e)
 
@@ -53,9 +37,9 @@ def add_table(context, table_name, pg_name):
 def toggle_wal_replay(context, action, pg_name):
     # pause or resume the wal replay process
     try:
-        version = context.pctl.query(pg_name, "SHOW server_version_num").fetchone()[0]
-        wal_name = 'xlog' if int(version) / 10000 < 10 else 'wal'
-        context.pctl.query(pg_name, "SELECT pg_{0}_replay_{1}()".format(wal_name, action))
+       version = context.pctl.query(pg_name, "select pg_catalog.pg_read_file('PG_VERSION', 0, 2)").fetchone()
+       wal = version and version[0] and int(version[0].split('.')[0]) < 10 and "xlog" or "wal"
+       context.pctl.query(pg_name, "SELECT pg_{0}_replay_{1}()".format(wal, action))
     except pg.Error as e:
         assert False, "Error during {0} wal recovery on {1}: {2}".format(action, pg_name, e)
 
@@ -63,10 +47,10 @@ def toggle_wal_replay(context, action, pg_name):
 @step('I {action:w} table on {pg_name:w}')
 def crdr_mytest(context, action, pg_name):
     try:
-        if (action == "create"):
-            context.pctl.query(pg_name, "create table if not exists public.mytest(id numeric)")
-        else:
-            context.pctl.query(pg_name, "drop table if exists public.mytest")
+       if (action == "create"):
+           context.pctl.query(pg_name, "create table if not exists mytest(id Numeric)")
+       else:
+           context.pctl.query(pg_name, "drop table if exists mytest")
     except pg.Error as e:
         assert False, "Error {0} table mytest on {1}: {2}".format(action, pg_name, e)
 
@@ -75,7 +59,7 @@ def crdr_mytest(context, action, pg_name):
 def initiate_load(context, pg_name):
     # perform dummy load
     try:
-        context.pctl.query(pg_name, "insert into public.mytest select r::numeric from generate_series(1, 350000) r")
+       context.pctl.query(pg_name, "begin; insert into mytest select r::numeric from generate_series(1, 350000) r; commit;")
     except pg.Error as e:
         assert False, "Error loading test data on {0}: {1}".format(pg_name, e)
 
@@ -84,32 +68,25 @@ def initiate_load(context, pg_name):
 def table_is_present_on(context, table_name, pg_name, max_replication_delay):
     max_replication_delay *= context.timeout_multiplier
     for _ in range(int(max_replication_delay)):
-        if context.pctl.query(pg_name, "SELECT 1 FROM public.{0}".format(table_name), fail_ok=True) is not None:
+        if context.pctl.query(pg_name, "SELECT 1 FROM {0}".format(table_name), fail_ok=True) is not None:
             break
         sleep(1)
     else:
-        assert False, \
+        assert False,\
             "Table {0} is not present on {1} after {2} seconds".format(table_name, pg_name, max_replication_delay)
 
 
 @then('{pg_name:w} role is the {pg_role:w} after {max_promotion_timeout:d} seconds')
 def check_role(context, pg_name, pg_role, max_promotion_timeout):
     max_promotion_timeout *= context.timeout_multiplier
-    assert context.pctl.check_role_has_changed_to(pg_name, pg_role, timeout=int(max_promotion_timeout)), \
+    assert context.pctl.check_role_has_changed_to(pg_name, pg_role, timeout=int(max_promotion_timeout)),\
         "{0} role didn't change to {1} after {2} seconds".format(pg_name, pg_role, max_promotion_timeout)
 
 
-@step('replication works from {primary:w} to {replica:w} after {time_limit:d} seconds')
-@then('replication works from {primary:w} to {replica:w} after {time_limit:d} seconds')
-def replication_works(context, primary, replica, time_limit):
+@step('replication works from {master:w} to {replica:w} after {time_limit:d} seconds')
+@then('replication works from {master:w} to {replica:w} after {time_limit:d} seconds')
+def replication_works(context, master, replica, time_limit):
     context.execute_steps(u"""
         When I add the table test_{0} to {1}
         Then table test_{0} is present on {2} after {3} seconds
-    """.format(int(time()), primary, replica, time_limit))
-
-
-@then('there is a "{message}" {level:w} in the {node} patroni log')
-def check_patroni_log(context, message, level, node):
-    messsages_of_level = context.pctl.read_patroni_log(node, level)
-    assert any(message in line for line in messsages_of_level), \
-        "There was no {0} {1} in the {2} patroni log".format(message, level, node)
+    """.format(int(time()), master, replica, time_limit))

features/steps/cascading_replication.py

@@ -11,8 +11,11 @@ def start_patroni_with_a_name_value_tag(context, name, tag_name, tag_value):
 
 @then('There is a {label} with "{content}" in {name:w} data directory')
 def check_label(context, label, content, name):
-    value = (context.pctl.read_label(name, label) or '').replace('\n', '\\n')
-    assert content in value, "\"{0}\" in {1} doesn't contain {2}".format(value, label, content)
+    label = context.pctl.read_label(name, label)
+    if label is None:
+        label = ""
+    label = label.replace('\n', '\\n')
+    assert content in label, "\"{0}\" doesn't contain {1}".format(label, content)
 
 
 @step('I create label with "{content:w}" in {name:w} data directory')

features/steps/citus.py

@@ -1,129 +0,0 @@
-import json
-import time
-
-from behave import step, then
-from dateutil import tz
-from datetime import datetime
-from functools import partial
-from threading import Thread, Event
-
-tzutc = tz.tzutc()
-
-
-@step('{name:w} is a leader in a group {group:d} after {time_limit:d} seconds')
-@then('{name:w} is a leader in a group {group:d} after {time_limit:d} seconds')
-def is_a_group_leader(context, name, group, time_limit):
-    time_limit *= context.timeout_multiplier
-    max_time = time.time() + int(time_limit)
-    while (context.dcs_ctl.query("leader", group=group) != name):
-        time.sleep(1)
-        assert time.time() < max_time, "{0} is not a leader in dcs after {1} seconds".format(name, time_limit)
-
-
-@step('"{name}" key in a group {group:d} in DCS has {key:w}={value} after {time_limit:d} seconds')
-def check_group_member(context, name, group, key, value, time_limit):
-    time_limit *= context.timeout_multiplier
-    max_time = time.time() + int(time_limit)
-    dcs_value = None
-    response = None
-    while time.time() < max_time:
-        try:
-            response = json.loads(context.dcs_ctl.query(name, group=group))
-            dcs_value = response.get(key)
-            if dcs_value == value:
-                return
-        except Exception:
-            pass
-        time.sleep(1)
-    assert False, ("{0} in a group {1} does not have {2}={3} (found {4}) in dcs"
-                   " after {5} seconds").format(name, group, key, value, response, time_limit)
-
-
-@step('I start {name:w} in citus group {group:d}')
-def start_citus(context, name, group):
-    return context.pctl.start(name, custom_config={"citus": {"database": "postgres", "group": int(group)}})
-
-
-@step('{name1:w} is registered in the {name2:w} as the {role:w} in group {group:d} after {time_limit:d} seconds')
-def check_registration(context, name1, name2, role, group, time_limit):
-    time_limit *= context.timeout_multiplier
-    max_time = time.time() + int(time_limit)
-
-    worker_port = int(context.pctl.query(name1, "SHOW port").fetchone()[0])
-
-    while time.time() < max_time:
-        try:
-            cur = context.pctl.query(name2, "SELECT nodeport, noderole"
-                                            " FROM pg_catalog.pg_dist_node WHERE groupid = {0}".format(group))
-            mapping = {r[0]: r[1] for r in cur}
-            if mapping.get(worker_port) == role:
-                return
-        except Exception:
-            pass
-        time.sleep(1)
-    assert False, "Node {0} is not registered in pg_dist_node on the node {1}".format(name1, name2)
-
-
-@step('I create a distributed table on {name:w}')
-def create_distributed_table(context, name):
-    context.pctl.query(name, 'CREATE TABLE public.d(id int not null)')
-    context.pctl.query(name, "SELECT create_distributed_table('public.d', 'id')")
-
-
-@step('I cleanup a distributed table on {name:w}')
-def cleanup_distributed_table(context, name):
-    context.pctl.query(name, 'TRUNCATE public.d')
-
-
-def insert_thread(query_func, context):
-    while True:
-        if context.thread_stop_event.is_set():
-            break
-
-        context.insert_counter += 1
-        query_func('INSERT INTO public.d VALUES({0})'.format(context.insert_counter))
-
-        context.thread_stop_event.wait(0.01)
-
-
-@step('I start a thread inserting data on {name:w}')
-def start_insert_thread(context, name):
-    context.thread_stop_event = Event()
-    context.insert_counter = 0
-    query_func = partial(context.pctl.query, name)
-    thread_func = partial(insert_thread, query_func, context)
-    context.thread = Thread(target=thread_func)
-    context.thread.daemon = True
-    context.thread.start()
-
-
-@then('a thread is still alive')
-def thread_is_alive(context):
-    assert context.thread.is_alive(), "Thread is not alive"
-
-
-@step("I stop a thread")
-def stop_insert_thread(context):
-    context.thread_stop_event.set()
-    context.thread.join(1 * context.timeout_multiplier)
-    assert not context.thread.is_alive(), "Thread is still alive"
-
-
-@step("a distributed table on {name:w} has expected rows")
-def count_rows(context, name):
-    rows = context.pctl.query(name, "SELECT COUNT(*) FROM public.d").fetchone()[0]
-    assert rows == context.insert_counter, "Distributed table doesn't have expected amount of rows"
-
-
-@step("There is a transaction in progress on {name:w} changing pg_dist_node")
-def check_transaction(context, name):
-    cur = context.pctl.query(name, "SELECT xact_start FROM pg_stat_activity WHERE pid <> pg_backend_pid()"
-                                   " AND state = 'idle in transaction' AND query ~ 'citus_update_node'")
-    assert cur.rowcount == 1, "There is no idle in transaction updating pg_dist_node"
-    context.xact_start = cur.fetchone()[0]
-
-
-@step("a transaction finishes in {timeout:d} seconds")
-def check_transaction_timeout(context, timeout):
-    assert (datetime.now(tzutc) - context.xact_start).seconds > timeout, \
-        "a transaction finished earlier than in {0} seconds".format(timeout)

features/steps/dcs_failsafe_mode.py

@@ -1,16 +0,0 @@
-from behave import step
-
-
-@step('DCS is down')
-def start_dcs_outage(context):
-    context.dcs_ctl.start_outage()
-
-
-@step('DCS is up')
-def stop_dcs_outage(context):
-    context.dcs_ctl.stop_outage()
-
-
-@step('I start {name:w} in a cluster {cluster_name:w} from backup with no_leader')
-def start_cluster_from_backup_no_leader(context, name, cluster_name):
-    context.pctl.bootstrap_from_backup_no_leader(name, cluster_name)

features/steps/patroni_api.py

@@ -1,4 +1,5 @@
 import json
+import os
 import parse
 import shlex
 import subprocess
@@ -9,8 +10,10 @@ import yaml
 from behave import register_type, step, then
 from dateutil import tz
 from datetime import datetime, timedelta
+from patroni.request import PatroniRequest
 
 tzutc = tz.tzutc()
+request_executor = PatroniRequest({'ctl': {'auth': 'username:password'}})
 
 
 @parse.with_pattern(r'https?://(?:\w|\.|:|/)+')
@@ -70,13 +73,11 @@ def do_post_empty(context, url):
 
 @step('I issue a {request_method:w} request to {url:url} with {data}')
 def do_request(context, request_method, url, data):
-    if context.certfile:
-        url = url.replace('http://', 'https://')
     data = data and json.loads(data)
     try:
-        r = context.request_executor.request(request_method, url, data)
+        r = request_executor.request(request_method, url, data)
         if request_method == 'PATCH' and r.status == 409:
-            r = context.request_executor.request(request_method, url, data)
+            r = request_executor.request(request_method, url, data)
     except Exception:
         context.status_code = context.response = None
     else:
@@ -87,7 +88,10 @@ def do_request(context, request_method, url, data):
 def do_run(context, cmd):
     cmd = [sys.executable, '-m', 'coverage', 'run', '--source=patroni', '-p'] + shlex.split(cmd)
     try:
-        response = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
+        # XXX: Dirty hack! We need to take name/passwd from the config!
+        env = os.environ.copy()
+        env.update({'PATRONI_RESTAPI_USERNAME': 'username', 'PATRONI_RESTAPI_PASSWORD': 'password'})
+        response = subprocess.check_output(cmd, stderr=subprocess.STDOUT, env=env)
         context.status_code = 0
     except subprocess.CalledProcessError as e:
         response = e.output
@@ -98,7 +102,7 @@ def do_run(context, cmd):
 @then('I receive a response {component:w} {data}')
 def check_response(context, component, data):
     if component == 'code':
-        assert context.status_code == int(data), \
+        assert context.status_code == int(data),\
             "status code {0} != {1}, response: {2}".format(context.status_code, data, context.response)
     elif component == 'returncode':
         assert context.status_code == int(data), "return code {0} != {1}, {2}".format(context.status_code,
@@ -109,8 +113,6 @@ def check_response(context, component, data):
         assert data.strip('"') in context.response, "response {0} does not contain {1}".format(context.response, data)
     else:
         assert component in context.response, "{0} is not part of the response".format(component)
-        if context.certfile:
-            data = data.replace('http://', 'https://')
         assert str(context.response[component]) == str(data), "{0} does not contain {1}".format(component, data)
 
 
@@ -133,32 +135,16 @@ def add_tag_to_config(context, tag, value, pg_name):
     context.pctl.add_tag_to_config(pg_name, tag, value)
 
 
-@then('Status code on GET {url:url} is {code:d} after {timeout:d} seconds')
-def check_http_code(context, url, code, timeout):
-    if context.certfile:
-        url = url.replace('http://', 'https://')
-    timeout *= context.timeout_multiplier
-    for _ in range(int(timeout)):
-        r = context.request_executor.request('GET', url)
-        if int(code) == int(r.status):
-            break
-        time.sleep(1)
-    else:
-        assert False, "HTTP Status Code is not {0} after {1} seconds".format(code, timeout)
-
-
-@then('Response on GET {url:url} contains {value} after {timeout:d} seconds')
+@then('Response on GET {url} contains {value} after {timeout:d} seconds')
 def check_http_response(context, url, value, timeout, negate=False):
-    if context.certfile:
-        url = url.replace('http://', 'https://')
     timeout *= context.timeout_multiplier
     for _ in range(int(timeout)):
-        r = context.request_executor.request('GET', url)
+        r = request_executor.request('GET', url)
         if (value in r.data.decode('utf-8')) != negate:
             break
         time.sleep(1)
     else:
-        assert False, \
+        assert False,\
             "Value {0} is {1} present in response after {2} seconds".format(value, "not" if not negate else "", timeout)
 
 

features/steps/standby_cluster.py

@@ -1,12 +1,17 @@
 import os
+import sys
 import time
 
 from behave import step
 
 
-def callbacks(context, name):
-    return {c: '{0} features/callback2.py {1}'.format(context.pctl.PYTHON, name)
-            for c in ('on_start', 'on_stop', 'on_restart', 'on_role_change')}
+select_replication_query = """
+SELECT * FROM pg_catalog.pg_stat_replication
+WHERE application_name = '{0}'
+"""
+
+executable = sys.executable if os.name != 'nt' else sys.executable.replace('\\', '/')
+callback = executable + " features/callback2.py "
 
 
 @step('I start {name:w} in a cluster {cluster_name:w}')
@@ -14,10 +19,10 @@ def start_patroni(context, name, cluster_name):
     return context.pctl.start(name, custom_config={
         "scope": cluster_name,
         "postgresql": {
-            "callbacks": callbacks(context, name),
+            "callbacks": {c: callback + name for c in ('on_start', 'on_stop', 'on_restart', 'on_role_change')},
             "backup_restore": {
-                "command": (context.pctl.PYTHON + " features/backup_restore.py --sourcedir="
-                            + os.path.join(context.pctl.patroni_path, 'data', 'basebackup').replace('\\', '/'))}
+                "command": (executable + " features/backup_restore.py --sourcedir=" +
+                            os.path.join(context.pctl.patroni_path, 'data', 'basebackup'))}
         }
     })
 
@@ -44,7 +49,7 @@ def start_patroni_standby_cluster(context, name, cluster_name, name2):
             }
         },
         "postgresql": {
-            "callbacks": callbacks(context, name)
+            "callbacks": {c: callback + name for c in ('on_start', 'on_stop', 'on_restart', 'on_role_change')}
         }
     })
     return context.pctl.start(name)
@@ -57,7 +62,7 @@ def check_replication_status(context, pg_name1, pg_name2, timeout):
     while time.time() < bound_time:
         cur = context.pctl.query(
             pg_name2,
-            "SELECT * FROM pg_catalog.pg_stat_replication WHERE application_name = '{0}'".format(pg_name1),
+            select_replication_query.format(pg_name1),
             fail_ok=True
         )
 

features/steps/watchdog.py

@@ -15,7 +15,7 @@ def polling_loop(timeout, interval=1):
 
 @step('I start {name:w} with watchdog')
 def start_patroni_with_watchdog(context, name):
-    return context.pctl.start(name, custom_config={'watchdog': True, 'bootstrap': {'dcs': {'ttl': 20}}})
+    return context.pctl.start(name, custom_config={'watchdog': True})
 
 
 @step('{name:w} watchdog has been pinged after {timeout:d} seconds')
@@ -31,11 +31,6 @@ def watchdog_was_closed(context, name):
     assert context.pctl.get_watchdog(name).was_closed
 
 
-@step('{name:w} watchdog has a {timeout:d} second timeout')
-def watchdog_has_timeout(context, name, timeout):
-    assert context.pctl.get_watchdog(name).timeout == timeout
-
-
 @step('I reset {name:w} watchdog state')
 def watchdog_reset_pinged(context, name):
     context.pctl.get_watchdog(name).reset()

features/watchdog.feature

@@ -6,14 +6,6 @@ Feature: watchdog
     Then postgres0 is a leader after 10 seconds
     And postgres0 role is the primary after 10 seconds
     And postgres0 watchdog has been pinged after 10 seconds
-    And postgres0 watchdog has a 15 second timeout
-
-  Scenario: watchdog is reconfigured after global ttl changed
-    Given I run patronictl.py edit-config batman -s ttl=30 --force
-    Then I receive a response returncode 0
-    And I receive a response output "+ttl: 30"
-    When I sleep for 4 seconds
-    Then postgres0 watchdog has a 25 second timeout
 
   Scenario: watchdog is disabled during pause
     Given I run patronictl.py pause batman

kubernetes/Dockerfile

@@ -1,9 +1,10 @@
-FROM postgres:15
-LABEL maintainer="Alexander Kukushkin <akukushkin@microsoft.com>"
+FROM postgres:11
+MAINTAINER Alexander Kukushkin <alexander.kukushkin@zalando.de>
 
 RUN export DEBIAN_FRONTEND=noninteractive \
     && echo 'APT::Install-Recommends "0";\nAPT::Install-Suggests "0";' > /etc/apt/apt.conf.d/01norecommend \
     && apt-get update -y \
+    && apt-get upgrade -y \
     && apt-cache depends patroni | sed -n -e 's/.* Depends: \(python3-.\+\)$/\1/p' \
             | grep -Ev '^python3-(sphinx|etcd|consul|kazoo|kubernetes)' \
             | xargs apt-get install -y vim-tiny curl jq locales git python3-pip python3-wheel \
@@ -24,7 +25,7 @@ RUN export DEBIAN_FRONTEND=noninteractive \
     && apt-get clean -y \
     && rm -rf /var/lib/apt/lists/* /root/.cache
 
-COPY entrypoint.sh /
+ADD entrypoint.sh /
 
 EXPOSE 5432 8008
 ENV LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 EDITOR=/usr/bin/editor

kubernetes/Dockerfile.citus

@@ -1,46 +0,0 @@
-FROM postgres:15
-LABEL maintainer="Alexander Kukushkin <[email protected]>"
-
-RUN export DEBIAN_FRONTEND=noninteractive \
-    && echo 'APT::Install-Recommends "0";\nAPT::Install-Suggests "0";' > /etc/apt/apt.conf.d/01norecommend \
-    && apt-get update -y \
-    && apt-get upgrade -y \
-    && apt-cache depends patroni | sed -n -e 's/.* Depends: \(python3-.\+\)$/\1/p' \
-            | grep -Ev '^python3-(sphinx|etcd|consul|kazoo|kubernetes)' \
-            | xargs apt-get install -y busybox vim-tiny curl jq less locales git python3-pip python3-wheel lsb-release \
-    ## Make sure we have a en_US.UTF-8 locale available
-    && localedef -i en_US -c -f UTF-8 -A /usr/share/locale/locale.alias en_US.UTF-8 \
-    && echo "deb [signed-by=/etc/apt/trusted.gpg.d/citusdata_community.gpg] https://packagecloud.io/citusdata/community/debian/ $(lsb_release -cs) main" > /etc/apt/sources.list.d/citusdata_community.list \
-    && curl -sL https://packagecloud.io/citusdata/community/gpgkey | gpg --dearmor > /etc/apt/trusted.gpg.d/citusdata_community.gpg \
-    && apt-get update -y \
-    && apt-get -y install postgresql-$PG_MAJOR-citus-11.3 \
-    && pip3 install setuptools \
-    && pip3 install 'git+https://github.com/zalando/patroni.git#egg=patroni[kubernetes]' \
-    && PGHOME=/home/postgres \
-    && mkdir -p $PGHOME \
-    && chown postgres $PGHOME \
-    && sed -i "s|/var/lib/postgresql.*|$PGHOME:/bin/bash|" /etc/passwd \
-    && /bin/busybox --install -s \
-    # Set permissions for OpenShift
-    && chmod 775 $PGHOME \
-    && chmod 664 /etc/passwd \
-    # Clean up
-    && apt-get remove -y git python3-pip python3-wheel \
-    && apt-get autoremove -y \
-    && apt-get clean -y \
-    && rm -rf /var/lib/apt/lists/* /root/.cache
-
-ADD entrypoint.sh /
-ENV PGSSLMODE=verify-ca PGSSLKEY=/etc/ssl/private/ssl-cert-snakeoil.key PGSSLCERT=/etc/ssl/certs/ssl-cert-snakeoil.pem PGSSLROOTCERT=/etc/ssl/certs/ssl-cert-snakeoil.pem
-
-RUN sed -i 's/^postgresql:/&\n  basebackup:\n    checkpoint: fast/' /entrypoint.sh \
-    && sed -i "s|^    postgresql:|&\n      parameters:\n        max_connections: 100\n        shared_buffers: 16MB\n        ssl: 'on'\n        ssl_ca_file: $PGSSLROOTCERT\n        ssl_cert_file: $PGSSLCERT\n        ssl_key_file: $PGSSLKEY\n        citus.node_conninfo: 'sslrootcert=$PGSSLROOTCERT sslkey=$PGSSLKEY sslcert=$PGSSLCERT sslmode=$PGSSLMODE'|"  /entrypoint.sh \
-    && sed -i 's/^      pg_hba:/&\n      - local all all trust/' /entrypoint.sh \
-    && sed -i "s/^\(.*\) \(.*\) \(.*\) \(.*\) \(.*\) md5.*$/\1 hostssl \3 \4 all md5 clientcert=$PGSSLMODE/" /entrypoint.sh \
-    && sed -i "s#^    \(superuser\|replication\):#&\n      sslmode: $PGSSLMODE\n      sslkey: $PGSSLKEY\n      sslcert: $PGSSLCERT\n      sslrootcert: $PGSSLROOTCERT#" /entrypoint.sh
-
-EXPOSE 5432 8008
-ENV LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 EDITOR=/usr/bin/editor
-USER postgres
-WORKDIR /home/postgres
-CMD ["/bin/bash", "/entrypoint.sh"]

kubernetes/README.md

@@ -1,154 +0,0 @@
-# Kubernetes deployment examples
-Below you will find examples of Patroni deployments using [kind](https://kind.sigs.k8s.io/).
-
-# Patroni on K8s
-The Patroni cluster deployment with a StatefulSet consisting of three Pods.
-
-Example session:
-
-    $ kind create cluster
-    Creating cluster "kind" ...
-     ✓ Ensuring node image (kindest/node:v1.25.3) 🖼
-     ✓ Preparing nodes 📦
-     ✓ Writing configuration 📜
-     ✓ Starting control-plane 🕹️
-     ✓ Installing CNI 🔌
-     ✓ Installing StorageClass 💾
-    Set kubectl context to "kind-kind"
-    You can now use your cluster with:
-
-    kubectl cluster-info --context kind-kind
-
-    Thanks for using kind! 😊
-
-    $ docker build -t patroni .
-    Sending build context to Docker daemon  138.8kB
-    Step 1/9 : FROM postgres:15
-    ...
-    Successfully built e9bfe69c5d2b
-    Successfully tagged patroni:latest
-
-    $ kind load docker-image patroni
-    Image: "" with ID "sha256:e9bfe69c5d2b319dec0cf564fb895484537664775e18f37f9b707914cc5537e6" not yet present on node "kind-control-plane", loading...
-
-    $ kubectl apply -f patroni_k8s.yaml
-    service/patronidemo-config created
-    statefulset.apps/patronidemo created
-    endpoints/patronidemo created
-    service/patronidemo created
-    service/patronidemo-repl created
-    secret/patronidemo created
-    serviceaccount/patronidemo created
-    role.rbac.authorization.k8s.io/patronidemo created
-    rolebinding.rbac.authorization.k8s.io/patronidemo created
-    clusterrole.rbac.authorization.k8s.io/patroni-k8s-ep-access created
-    clusterrolebinding.rbac.authorization.k8s.io/patroni-k8s-ep-access created
-
-    $ kubectl get pods -L role
-    NAME            READY   STATUS    RESTARTS   AGE   ROLE
-    patronidemo-0   1/1     Running   0          34s   master
-    patronidemo-1   1/1     Running   0          30s   replica
-    patronidemo-2   1/1     Running   0          26s   replica
-
-    $ kubectl exec -ti patronidemo-0 -- bash
-    postgres@patronidemo-0:~$ patronictl list
-    + Cluster: patronidemo (7186662553319358497) ----+----+-----------+
-    | Member        | Host       | Role    | State   | TL | Lag in MB |
-    +---------------+------------+---------+---------+----+-----------+
-    | patronidemo-0 | 10.244.0.5 | Leader  | running |  1 |           |
-    | patronidemo-1 | 10.244.0.6 | Replica | running |  1 |         0 |
-    | patronidemo-2 | 10.244.0.7 | Replica | running |  1 |         0 |
-    +---------------+------------+---------+---------+----+-----------+
-
-# Citus on K8s
-The Citus cluster with the StatefulSets, one coordinator with three Pods and two workers with two pods each.
-
-Example session:
-
-    $ kind create cluster
-    Creating cluster "kind" ...
-     ✓ Ensuring node image (kindest/node:v1.25.3) 🖼
-     ✓ Preparing nodes 📦
-     ✓ Writing configuration 📜
-     ✓ Starting control-plane 🕹️
-     ✓ Installing CNI 🔌
-     ✓ Installing StorageClass 💾
-    Set kubectl context to "kind-kind"
-    You can now use your cluster with:
-
-    kubectl cluster-info --context kind-kind
-
-    Thanks for using kind! 😊
-
-    demo@localhost:~/git/patroni/kubernetes$ docker build -f Dockerfile.citus -t patroni-citus-k8s .
-    Sending build context to Docker daemon  138.8kB
-    Step 1/11 : FROM postgres:15
-    ...
-    Successfully built 8cd73e325028
-    Successfully tagged patroni-citus-k8s:latest
-
-    $ kind load docker-image patroni-citus-k8s
-    Image: "" with ID "sha256:8cd73e325028d7147672494965e53453f5540400928caac0305015eb2c7027c7" not yet present on node "kind-control-plane", loading...
-
-    $ kubectl apply -f citus_k8s.yaml
-    service/citusdemo-0-config created
-    service/citusdemo-1-config created
-    service/citusdemo-2-config created
-    statefulset.apps/citusdemo-0 created
-    statefulset.apps/citusdemo-1 created
-    statefulset.apps/citusdemo-2 created
-    endpoints/citusdemo-0 created
-    service/citusdemo-0 created
-    endpoints/citusdemo-1 created
-    service/citusdemo-1 created
-    endpoints/citusdemo-2 created
-    service/citusdemo-2 created
-    service/citusdemo-workers created
-    secret/citusdemo created
-    serviceaccount/citusdemo created
-    role.rbac.authorization.k8s.io/citusdemo created
-    rolebinding.rbac.authorization.k8s.io/citusdemo created
-    clusterrole.rbac.authorization.k8s.io/patroni-k8s-ep-access created
-    clusterrolebinding.rbac.authorization.k8s.io/patroni-k8s-ep-access created
-
-    $ kubectl get sts
-    NAME          READY   AGE
-    citusdemo-0   1/3     6s  # coodinator (group=0)
-    citusdemo-1   1/2     6s  # worker (group=1)
-    citusdemo-2   1/2     6s  # worker (group=2)
-
-    $ kubectl get pods -l cluster-name=citusdemo -L role
-    NAME            READY   STATUS    RESTARTS   AGE    ROLE
-    citusdemo-0-0   1/1     Running   0          105s   master
-    citusdemo-0-1   1/1     Running   0          101s   replica
-    citusdemo-0-2   1/1     Running   0          96s    replica
-    citusdemo-1-0   1/1     Running   0          105s   master
-    citusdemo-1-1   1/1     Running   0          101s   replica
-    citusdemo-2-0   1/1     Running   0          105s   master
-    citusdemo-2-1   1/1     Running   0          101s   replica
-
-    $ kubectl exec -ti citusdemo-0-0 -- bash
-    postgres@citusdemo-0-0:~$ patronictl list
-    + Citus cluster: citusdemo -----------+--------------+---------+----+-----------+
-    | Group | Member        | Host        | Role         | State   | TL | Lag in MB |
-    +-------+---------------+-------------+--------------+---------+----+-----------+
-    |     0 | citusdemo-0-0 | 10.244.0.10 | Leader       | running |  1 |           |
-    |     0 | citusdemo-0-1 | 10.244.0.12 | Replica      | running |  1 |         0 |
-    |     0 | citusdemo-0-2 | 10.244.0.14 | Sync Standby | running |  1 |         0 |
-    |     1 | citusdemo-1-0 | 10.244.0.8  | Leader       | running |  1 |           |
-    |     1 | citusdemo-1-1 | 10.244.0.11 | Sync Standby | running |  1 |         0 |
-    |     2 | citusdemo-2-0 | 10.244.0.9  | Leader       | running |  1 |           |
-    |     2 | citusdemo-2-1 | 10.244.0.13 | Sync Standby | running |  1 |         0 |
-    +-------+---------------+-------------+--------------+---------+----+-----------+
-
-    postgres@citusdemo-0-0:~$ psql citus
-    psql (15.1 (Debian 15.1-1.pgdg110+1))
-    Type "help" for help.
-
-    citus=# table pg_dist_node;
-     nodeid | groupid |  nodename   | nodeport | noderack | hasmetadata | isactive | noderole | nodecluster | metadatasynced | shouldhaveshards
-    --------+---------+-------------+----------+----------+-------------+----------+----------+-------------+----------------+------------------
-          1 |       0 | 10.244.0.10 |     5432 | default  | t           | t        | primary  | default     | t              | f
-          2 |       1 | 10.244.0.8  |     5432 | default  | t           | t        | primary  | default     | t              | t
-          3 |       2 | 10.244.0.9  |     5432 | default  | t           | t        | primary  | default     | t              | t
-    (3 rows)

kubernetes/citus_k8s.yaml

@@ -1,590 +0,0 @@
-# headless services to avoid deletion of citusdemo-*-config endpoints
-apiVersion: v1
-kind: Service
-metadata:
-  name: citusdemo-0-config
-  labels:
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '0'
-spec:
-  clusterIP: None
-
----
-apiVersion: v1
-kind: Service
-metadata:
-  name: citusdemo-1-config
-  labels:
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '1'
-spec:
-  clusterIP: None
-
----
-
-apiVersion: v1
-kind: Service
-metadata:
-  name: citusdemo-2-config
-  labels:
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '2'
-spec:
-  clusterIP: None
-
----
-apiVersion: apps/v1
-kind: StatefulSet
-metadata:
-  name: &cluster_name citusdemo-0
-  labels: &labels
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '0'
-    citus-type: coordinator
-spec:
-  replicas: 3
-  serviceName: *cluster_name
-  selector:
-    matchLabels:
-      <<: *labels
-  template:
-    metadata:
-      labels:
-        <<: *labels
-    spec:
-      serviceAccountName: citusdemo
-      containers:
-      - name: *cluster_name
-        image: patroni-citus-k8s  # docker build -f Dockerfile.citus -t patroni-citus-k8s .
-        imagePullPolicy: IfNotPresent
-        readinessProbe:
-          httpGet:
-            scheme: HTTP
-            path: /readiness
-            port: 8008
-          initialDelaySeconds: 3
-          periodSeconds: 10
-          timeoutSeconds: 5
-          successThreshold: 1
-          failureThreshold: 3
-        ports:
-        - containerPort: 8008
-          protocol: TCP
-        - containerPort: 5432
-          protocol: TCP
-        volumeMounts:
-        - mountPath: /home/postgres/pgdata
-          name: pgdata
-        env:
-        - name: PATRONI_KUBERNETES_POD_IP
-          valueFrom:
-            fieldRef:
-              fieldPath: status.podIP
-        - name: PATRONI_KUBERNETES_NAMESPACE
-          valueFrom:
-            fieldRef:
-              fieldPath: metadata.namespace
-        - name: PATRONI_KUBERNETES_BYPASS_API_SERVICE
-          value: 'true'
-        - name: PATRONI_KUBERNETES_USE_ENDPOINTS
-          value: 'true'
-        - name: PATRONI_KUBERNETES_LABELS
-          value: '{application: patroni, cluster-name: citusdemo}'
-        - name: PATRONI_CITUS_DATABASE
-          value: citus
-        - name: PATRONI_CITUS_GROUP
-          value: '0'
-        - name: PATRONI_SUPERUSER_USERNAME
-          value: postgres
-        - name: PATRONI_SUPERUSER_PASSWORD
-          valueFrom:
-            secretKeyRef:
-              name: citusdemo
-              key: superuser-password
-        - name: PATRONI_REPLICATION_USERNAME
-          value: standby
-        - name: PATRONI_REPLICATION_PASSWORD
-          valueFrom:
-            secretKeyRef:
-              name: citusdemo
-              key: replication-password
-        - name: PATRONI_SCOPE
-          value: citusdemo
-        - name: PATRONI_NAME
-          valueFrom:
-            fieldRef:
-              fieldPath: metadata.name
-        - name: PATRONI_POSTGRESQL_DATA_DIR
-          value: /home/postgres/pgdata/pgroot/data
-        - name: PATRONI_POSTGRESQL_PGPASS
-          value: /tmp/pgpass
-        - name: PATRONI_POSTGRESQL_LISTEN
-          value: '0.0.0.0:5432'
-        - name: PATRONI_RESTAPI_LISTEN
-          value: '0.0.0.0:8008'
-      terminationGracePeriodSeconds: 0
-      volumes:
-      - name: pgdata
-        emptyDir: {}
-#  volumeClaimTemplates:
-#  - metadata:
-#      labels:
-#        application: spilo
-#        spilo-cluster: *cluster_name
-#      annotations:
-#        volume.alpha.kubernetes.io/storage-class: anything
-#      name: pgdata
-#    spec:
-#      accessModes:
-#      - ReadWriteOnce
-#      resources:
-#        requests:
-#          storage: 5Gi
-
----
-apiVersion: apps/v1
-kind: StatefulSet
-metadata:
-  name: &cluster_name citusdemo-1
-  labels: &labels
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '1'
-    citus-type: worker
-spec:
-  replicas: 2
-  serviceName: *cluster_name
-  selector:
-    matchLabels:
-      <<: *labels
-  template:
-    metadata:
-      labels:
-        <<: *labels
-    spec:
-      serviceAccountName: citusdemo
-      containers:
-      - name: *cluster_name
-        image: patroni-citus-k8s  # docker build -f Dockerfile.citus -t patroni-citus-k8s .
-        imagePullPolicy: IfNotPresent
-        readinessProbe:
-          httpGet:
-            scheme: HTTP
-            path: /readiness
-            port: 8008
-          initialDelaySeconds: 3
-          periodSeconds: 10
-          timeoutSeconds: 5
-          successThreshold: 1
-          failureThreshold: 3
-        ports:
-        - containerPort: 8008
-          protocol: TCP
-        - containerPort: 5432
-          protocol: TCP
-        volumeMounts:
-        - mountPath: /home/postgres/pgdata
-          name: pgdata
-        env:
-        - name: PATRONI_KUBERNETES_POD_IP
-          valueFrom:
-            fieldRef:
-              fieldPath: status.podIP
-        - name: PATRONI_KUBERNETES_NAMESPACE
-          valueFrom:
-            fieldRef:
-              fieldPath: metadata.namespace
-        - name: PATRONI_KUBERNETES_BYPASS_API_SERVICE
-          value: 'true'
-        - name: PATRONI_KUBERNETES_USE_ENDPOINTS
-          value: 'true'
-        - name: PATRONI_KUBERNETES_LABELS
-          value: '{application: patroni, cluster-name: citusdemo}'
-        - name: PATRONI_CITUS_DATABASE
-          value: citus
-        - name: PATRONI_CITUS_GROUP
-          value: '1'
-        - name: PATRONI_SUPERUSER_USERNAME
-          value: postgres
-        - name: PATRONI_SUPERUSER_PASSWORD
-          valueFrom:
-            secretKeyRef:
-              name: citusdemo
-              key: superuser-password
-        - name: PATRONI_REPLICATION_USERNAME
-          value: standby
-        - name: PATRONI_REPLICATION_PASSWORD
-          valueFrom:
-            secretKeyRef:
-              name: citusdemo
-              key: replication-password
-        - name: PATRONI_SCOPE
-          value: citusdemo
-        - name: PATRONI_NAME
-          valueFrom:
-            fieldRef:
-              fieldPath: metadata.name
-        - name: PATRONI_POSTGRESQL_DATA_DIR
-          value: /home/postgres/pgdata/pgroot/data
-        - name: PATRONI_POSTGRESQL_PGPASS
-          value: /tmp/pgpass
-        - name: PATRONI_POSTGRESQL_LISTEN
-          value: '0.0.0.0:5432'
-        - name: PATRONI_RESTAPI_LISTEN
-          value: '0.0.0.0:8008'
-      terminationGracePeriodSeconds: 0
-      volumes:
-      - name: pgdata
-        emptyDir: {}
-#  volumeClaimTemplates:
-#  - metadata:
-#      labels:
-#        application: spilo
-#        spilo-cluster: *cluster_name
-#      annotations:
-#        volume.alpha.kubernetes.io/storage-class: anything
-#      name: pgdata
-#    spec:
-#      accessModes:
-#      - ReadWriteOnce
-#      resources:
-#        requests:
-#          storage: 5Gi
-
----
-apiVersion: apps/v1
-kind: StatefulSet
-metadata:
-  name: &cluster_name citusdemo-2
-  labels: &labels
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '2'
-    citus-type: worker
-spec:
-  replicas: 2
-  serviceName: *cluster_name
-  selector:
-    matchLabels:
-      <<: *labels
-  template:
-    metadata:
-      labels:
-        <<: *labels
-    spec:
-      serviceAccountName: citusdemo
-      containers:
-      - name: *cluster_name
-        image: patroni-citus-k8s  # docker build -f Dockerfile.citus -t patroni-citus-k8s .
-        imagePullPolicy: IfNotPresent
-        readinessProbe:
-          httpGet:
-            scheme: HTTP
-            path: /readiness
-            port: 8008
-          initialDelaySeconds: 3
-          periodSeconds: 10
-          timeoutSeconds: 5
-          successThreshold: 1
-          failureThreshold: 3
-        ports:
-        - containerPort: 8008
-          protocol: TCP
-        - containerPort: 5432
-          protocol: TCP
-        volumeMounts:
-        - mountPath: /home/postgres/pgdata
-          name: pgdata
-        env:
-        - name: PATRONI_KUBERNETES_POD_IP
-          valueFrom:
-            fieldRef:
-              fieldPath: status.podIP
-        - name: PATRONI_KUBERNETES_NAMESPACE
-          valueFrom:
-            fieldRef:
-              fieldPath: metadata.namespace
-        - name: PATRONI_KUBERNETES_BYPASS_API_SERVICE
-          value: 'true'
-        - name: PATRONI_KUBERNETES_USE_ENDPOINTS
-          value: 'true'
-        - name: PATRONI_KUBERNETES_LABELS
-          value: '{application: patroni, cluster-name: citusdemo}'
-        - name: PATRONI_CITUS_DATABASE
-          value: citus
-        - name: PATRONI_CITUS_GROUP
-          value: '2'
-        - name: PATRONI_SUPERUSER_USERNAME
-          value: postgres
-        - name: PATRONI_SUPERUSER_PASSWORD
-          valueFrom:
-            secretKeyRef:
-              name: citusdemo
-              key: superuser-password
-        - name: PATRONI_REPLICATION_USERNAME
-          value: standby
-        - name: PATRONI_REPLICATION_PASSWORD
-          valueFrom:
-            secretKeyRef:
-              name: citusdemo
-              key: replication-password
-        - name: PATRONI_SCOPE
-          value: citusdemo
-        - name: PATRONI_NAME
-          valueFrom:
-            fieldRef:
-              fieldPath: metadata.name
-        - name: PATRONI_POSTGRESQL_DATA_DIR
-          value: /home/postgres/pgdata/pgroot/data
-        - name: PATRONI_POSTGRESQL_PGPASS
-          value: /tmp/pgpass
-        - name: PATRONI_POSTGRESQL_LISTEN
-          value: '0.0.0.0:5432'
-        - name: PATRONI_RESTAPI_LISTEN
-          value: '0.0.0.0:8008'
-      terminationGracePeriodSeconds: 0
-      volumes:
-      - name: pgdata
-        emptyDir: {}
-#  volumeClaimTemplates:
-#  - metadata:
-#      labels:
-#        application: spilo
-#        spilo-cluster: *cluster_name
-#      annotations:
-#        volume.alpha.kubernetes.io/storage-class: anything
-#      name: pgdata
-#    spec:
-#      accessModes:
-#      - ReadWriteOnce
-#      resources:
-#        requests:
-#          storage: 5Gi
-          
----
-apiVersion: v1
-kind: Endpoints
-metadata:
-  name: citusdemo-0
-  labels:
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '0'
-    citus-type: coordinator
-subsets: []
-
----
-apiVersion: v1
-kind: Service
-metadata:
-  name: citusdemo-0
-  labels:
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '0'
-    citus-type: coordinator
-spec:
-  type: ClusterIP
-  ports:
-  - port: 5432
-    targetPort: 5432
-
----
-apiVersion: v1
-kind: Endpoints
-metadata:
-  name: citusdemo-1
-  labels:
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '1'
-    citus-type: worker
-subsets: []
-
----
-apiVersion: v1
-kind: Service
-metadata:
-  name: citusdemo-1
-  labels:
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '1'
-    citus-type: worker
-spec:
-  type: ClusterIP
-  ports:
-  - port: 5432
-    targetPort: 5432
-
----
-apiVersion: v1
-kind: Endpoints
-metadata:
-  name: citusdemo-2
-  labels:
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '2'
-    citus-type: worker
-subsets: []
-
----
-apiVersion: v1
-kind: Service
-metadata:
-  name: citusdemo-2
-  labels:
-    application: patroni
-    cluster-name: citusdemo
-    citus-group: '2'
-    citus-type: worker
-spec:
-  type: ClusterIP
-  ports:
-  - port: 5432
-    targetPort: 5432
-
----
-apiVersion: v1
-kind: Service
-metadata:
-  name: citusdemo-workers
-  labels: &labels
-    application: patroni
-    cluster-name: citusdemo
-    citus-type: worker
-    role: master
-spec:
-  type: ClusterIP
-  selector:
-    <<: *labels
-  ports:
-  - port: 5432
-    targetPort: 5432
-
----
-apiVersion: v1
-kind: Secret
-metadata:
-  name: &cluster_name citusdemo
-  labels:
-    application: patroni
-    cluster-name: *cluster_name
-type: Opaque
-data:
-  superuser-password: emFsYW5kbw==
-  replication-password: cmVwLXBhc3M=
-
----
-apiVersion: v1
-kind: ServiceAccount
-metadata:
-  name: citusdemo
-
----
-apiVersion: rbac.authorization.k8s.io/v1
-kind: Role
-metadata:
-  name: citusdemo
-rules:
-- apiGroups:
-  - ""
-  resources:
-  - configmaps
-  verbs:
-  - create
-  - get
-  - list
-  - patch
-  - update
-  - watch
-  # delete and deletecollection are required only for 'patronictl remove'
-  - delete
-  - deletecollection
-- apiGroups:
-  - ""
-  resources:
-  - endpoints
-  verbs:
-  - get
-  - patch
-  - update
-  # the following three privileges are necessary only when using endpoints
-  - create
-  - list
-  - watch
-  # delete and deletecollection are required only for for 'patronictl remove'
-  - delete
-  - deletecollection
-- apiGroups:
-  - ""
-  resources:
-  - pods
-  verbs:
-  - get
-  - list
-  - patch
-  - update
-  - watch
-# The following privilege is only necessary for creation of headless service
-# for citusdemo-config endpoint, in order to prevent cleaning it up by the
-# k8s master. You can avoid giving this privilege by explicitly creating the
-# service like it is done in this manifest (lines 2..10)
-- apiGroups:
-  - ""
-  resources:
-  - services
-  verbs:
-  - create
-
----
-apiVersion: rbac.authorization.k8s.io/v1
-kind: RoleBinding
-metadata:
-  name: citusdemo
-roleRef:
-  apiGroup: rbac.authorization.k8s.io
-  kind: Role
-  name: citusdemo
-subjects:
-- kind: ServiceAccount
-  name: citusdemo
-
-# Following privileges are only required if deployed not in the "default"
-# namespace and you want Patroni to bypass kubernetes service
-# (PATRONI_KUBERNETES_BYPASS_API_SERVICE=true)
----
-apiVersion: rbac.authorization.k8s.io/v1
-kind: ClusterRole
-metadata:
-  name: patroni-k8s-ep-access
-rules:
-- apiGroups:
-  - ""
-  resources:
-  - endpoints
-  resourceNames:
-  - kubernetes
-  verbs:
-  - get
-
----
-apiVersion: rbac.authorization.k8s.io/v1
-kind: ClusterRoleBinding
-metadata:
-  name: patroni-k8s-ep-access
-roleRef:
-  apiGroup: rbac.authorization.k8s.io
-  kind: ClusterRole
-  name: patroni-k8s-ep-access
-subjects:
-- kind: ServiceAccount
-  name: citusdemo
-# The namespace must be specified explicitly.
-# If deploying to the different namespace you have to change it.
-  namespace: default

kubernetes/entrypoint.sh

@@ -12,15 +12,15 @@ bootstrap:
   dcs:
     postgresql:
       use_pg_rewind: true
-      pg_hba:
-      - host all all 0.0.0.0/0 md5
-      - host replication ${PATRONI_REPLICATION_USERNAME} ${PATRONI_KUBERNETES_POD_IP}/16 md5
   initdb:
   - auth-host: md5
   - auth-local: trust
   - encoding: UTF8
   - locale: en_US.UTF-8
   - data-checksums
+  pg_hba:
+  - host all all 0.0.0.0/0 md5
+  - host replication ${PATRONI_REPLICATION_USERNAME} ${PATRONI_KUBERNETES_POD_IP}/16 md5
 restapi:
   connect_address: '${PATRONI_KUBERNETES_POD_IP}:8008'
 postgresql:

kubernetes/openshift-example/README.md

@@ -1,5 +1,5 @@
 # Patroni OpenShift Configuration
-Patroni can be run in OpenShift. Based on the kubernetes configuration, the Dockerfile and Entrypoint has been modified to support the dynamic UID/GID configuration that is applied in OpenShift. This can be run under the standard `restricted` SCC.
+Patroni can be run in OpenShift. Based on the kubernetes configuration, the Dockerfile and Entrypoint has been modified to support the dynamic UID/GID configuration that is applied in OpenShift. This can be run under the standard `restricted` SCC. 
 
 # Examples
 
@@ -11,39 +11,39 @@ oc new-project patroni-test
 
 ## Build the image
 
-Note: Update the references when merged upstream.
-Note: If deploying as a template for multiple users, the following commands should be performed in a shared namespace like `openshift`.
+Note: Update the references when merged upstream. 
+Note: If deploying as a template for multiple users, the following commands should be performed in a shared namespace like `openshift`. 
 
 ```
 oc import-image postgres:10 --confirm -n openshift
 oc new-build https://github.com/zalando/patroni --context-dir=kubernetes -n openshift
 ```
 
-## Deploy the Image
-Two configuration templates exist in [templates](templates) directory:
--   Patroni Ephemeral
--   Patroni Persistent
+## Deploy the Image 
+Two configuration templates exist in [templates](templates) directory: 
+- Patroni Ephemeral
+- Patroni Persistent
 
-The only difference is whether or not the statefulset requests persistent storage.
+The only difference is whether or not the statefulset requests persistent storage. 
 
 ## Create the Template
-Install the template into the `openshift` namespace if this should be shared across projects:
+Install the template into the `openshift` namespace if this should be shared across projects: 
 
 ```
 oc create -f templates/template_patroni_ephemeral.yml -n openshift
 ```
 
-Then, from your own project:
+Then, from your own project: 
 
 ```
 oc new-app patroni-pgsql-ephemeral
 ```
 
-Once the pods are running, two configmaps should be available:
+Once the pods are running, two configmaps should be available: 
 
 ```
 $ oc get configmap
 NAME                DATA      AGE
 patroniocp-config   0         1m
 patroniocp-leader   0         1m
-```
+```

kubernetes/openshift-example/test/README.md

@@ -1,2 +1,2 @@
 # Jenkins Test
-This pipeline test will create a separate deployment config for a pgbench pod and execute a test against the patroni cluster. This is a sample and should be customized.
+This pipeline test will create a separate deployment config for a pgbench pod and execute a test against the patroni cluster. This is a sample and should be customized. 

mkbinary.sh

@@ -1,5 +1,5 @@
 #!/bin/sh
 set -e
 
-pip install --ignore-installed pyinstaller
-pyinstaller --clean patroni.spec
+pip install --ignore-installed setuptools==19.2 pyinstaller
+pyinstaller --clean --onefile patroni.spec

patroni.spec

@@ -8,7 +8,7 @@ def hiddenimports():
     sys.path.insert(0, '.')
     try:
         import patroni.dcs
-        return patroni.dcs.dcs_modules() + ['http.server']
+        return patroni.dcs.dcs_modules()
     finally:
         sys.path.pop(0)
 
@@ -16,10 +16,7 @@ def hiddenimports():
 a = Analysis(['patroni/__main__.py'],
              pathex=[],
              binaries=None,
-             datas=[
-                ('patroni/postgresql/available_parameters/*.yml', 'patroni/postgresql/available_parameters'),
-                ('patroni/postgresql/available_parameters/*.yaml', 'patroni/postgresql/available_parameters'),
-            ],
+             datas=None,
              hiddenimports=hiddenimports(),
              hookspath=[],
              runtime_hooks=[],

patroni/__init__.py

@@ -1,54 +1,17 @@
-"""Define general variables and functions for :mod:`patroni`.
-
-:var PATRONI_ENV_PREFIX: prefix for Patroni related configuration environment variables.
-:var KUBERNETES_ENV_PREFIX: prefix for Kubernetes related configuration environment variables.
-:var MIN_PSYCOPG2: minimum version of :mod:`psycopg2` required by Patroni to work.
-"""
-
 import sys
 
-from typing import Any, Callable, Iterator, Tuple
-
 PATRONI_ENV_PREFIX = 'PATRONI_'
 KUBERNETES_ENV_PREFIX = 'KUBERNETES_'
 MIN_PSYCOPG2 = (2, 5, 4)
 
 
-def fatal(string: str, *args: Any) -> None:
-    """Write a fatal message to stderr and exit with code ``1``.
-
-    :param string: message to be written before exiting.
-    """
-    sys.exit('FATAL: ' + string.format(*args))
+def fatal(string, *args):
+    sys.stderr.write('FATAL: ' + string.format(*args) + '\n')
+    sys.exit(1)
 
 
-def parse_version(version: str) -> Tuple[int, ...]:
-    """Convert *version* from human-readable format to tuple of integers.
-
-    .. note::
-        Designed for easy comparison of software versions in Python.
-
-    :param version: human-readable software version, e.g. ``2.5.4``.
-
-    :returns: tuple of *version* parts, each part as an integer.
-
-    :Example:
-
-        >>> parse_version('2.5.4')
-        (2, 5, 4)
-    """
-    def _parse_version(version: str) -> Iterator[int]:
-        """Yield each part of a human-readable version string as an integer.
-
-        :param version: human-readable software version, e.g. ``2.5.4``.
-
-        :yields: each part of *version* as an integer.
-
-        :Example:
-
-            >>> tuple(_parse_version('2.5.4'))
-            (2, 5, 4)
-        """
+def parse_version(version):
+    def _parse_version(version):
         for e in version.split('.'):
             try:
                 yield int(e)
@@ -57,25 +20,10 @@ def parse_version(version: str) -> Tuple[int, ...]:
     return tuple(_parse_version(version.split(' ')[0]))
 
 
-def check_psycopg(_min_psycopg2: Tuple[int, ...] = MIN_PSYCOPG2,
-                  _parse_version: Callable[[str], Tuple[int, ...]] = parse_version) -> None:
-    """Ensure at least one among :mod:`psycopg2` or :mod:`psycopg` libraries are available in the environment.
-
-    .. note::
-        We pass ``MIN_PSYCOPG2`` and :func:`parse_version` as arguments to simplify usage of :func:`check_psycopg` from
-        the ``setup.py``.
-
-    .. note::
-        Patroni chooses :mod:`psycopg2` over :mod:`psycopg`, if possible.
-
-        If nothing meeting the requirements is found, then exit with a fatal message.
-
-    :param _min_psycopg2: minimum required version in case :mod:`psycopg2` is chosen.
-    :param _parse_version: function used to parse :mod:`psycopg2`/:mod:`psycopg` version into a comparable object.
-    """
+# We pass MIN_PSYCOPG2 and parse_version as arguments to simplify usage of check_psycopg from the setup.py
+def check_psycopg(_min_psycopg2=MIN_PSYCOPG2, _parse_version=parse_version):
     min_psycopg2_str = '.'.join(map(str, _min_psycopg2))
 
-    # try psycopg2
     try:
         from psycopg2 import __version__
         if _parse_version(__version__) >= _min_psycopg2:
@@ -84,11 +32,10 @@ def check_psycopg(_min_psycopg2: Tuple[int, ...] = MIN_PSYCOPG2,
     except ImportError:
         version_str = None
 
-    # try psycopg3
     try:
         from psycopg import __version__
     except ImportError:
         error = 'Patroni requires psycopg2>={0}, psycopg2-binary, or psycopg>=3.0'.format(min_psycopg2_str)
-        if version_str is not None:
+        if version_str:
             error += ', but only psycopg2=={0} is available'.format(version_str)
         fatal(error)

patroni/__main__.py

@@ -1,92 +1,41 @@
-"""Patroni main entry point.
-
-Implement ``patroni`` main daemon and expose its entry point.
-"""
-
 import logging
 import os
 import signal
-import sys
 import time
 
-from argparse import Namespace
-from typing import Any, Dict, Optional, TYPE_CHECKING
-
-from patroni.daemon import AbstractPatroniDaemon, abstract_main, get_base_arg_parser
-
-if TYPE_CHECKING:  # pragma: no cover
-    from .config import Config
+from .daemon import AbstractPatroniDaemon, abstract_main
 
 logger = logging.getLogger(__name__)
 
 
 class Patroni(AbstractPatroniDaemon):
-    """Implement ``patroni`` command daemon.
 
-    :ivar version: Patroni version.
-    :ivar dcs: DCS object.
-    :ivar watchdog: watchdog handler, if configured to use watchdog.
-    :ivar postgresql: managed Postgres instance.
-    :ivar api: REST API server instance of this node.
-    :ivar request: wrapper for performing HTTP requests.
-    :ivar ha: HA handler.
-    :ivar tags: cache of custom tags configured for this node.
-    :ivar next_run: time when to run the next HA loop cycle.
-    :ivar scheduled_restart: when a restart has been scheduled to occur, if any. In that case, should contain two keys:
-        * ``schedule``: timestamp when restart should occur;
-        * ``postmaster_start_time``: timestamp when Postgres was last started.
-    """
-
-    def __init__(self, config: 'Config') -> None:
-        """Create a :class:`Patroni` instance with the given *config*.
-
-        Get a connection to the DCS, configure watchdog (if required), set up Patroni interface with Postgres, configure
-        the HA loop and bring the REST API up.
-
-        .. note::
-            Expected to be instantiated and run through :func:`~patroni.daemon.abstract_main`.
-
-        :param config: Patroni configuration.
-        """
-        from patroni.api import RestApiServer
-        from patroni.dcs import get_dcs
-        from patroni.ha import Ha
-        from patroni.postgresql import Postgresql
-        from patroni.request import PatroniRequest
-        from patroni.version import __version__
-        from patroni.watchdog import Watchdog
+    def __init__(self, config):
+        from .api import RestApiServer
+        from .dcs import get_dcs
+        from .ha import Ha
+        from .postgresql import Postgresql
+        from .request import PatroniRequest
+        from .version import __version__
+        from .watchdog import Watchdog
 
         super(Patroni, self).__init__(config)
 
         self.version = __version__
         self.dcs = get_dcs(self.config)
-        self.request = PatroniRequest(self.config, True)
-
-        self.ensure_unique_name()
-
         self.watchdog = Watchdog(self.config)
         self.load_dynamic_configuration()
 
         self.postgresql = Postgresql(self.config['postgresql'])
         self.api = RestApiServer(self, self.config['restapi'])
+        self.request = PatroniRequest(self.config, True)
         self.ha = Ha(self)
 
         self.tags = self.get_tags()
         self.next_run = time.time()
-        self.scheduled_restart: Dict[str, Any] = {}
+        self.scheduled_restart = {}
 
-    def load_dynamic_configuration(self) -> None:
-        """Load Patroni dynamic configuration.
-
-        Load dynamic configuration from the DCS, if `/config` key is available in the DCS, otherwise fall back to
-        ``bootstrap.dcs`` section from the configuration file.
-
-        If the DCS connection fails returning the exception :class:`~patroni.exceptions.DCSError` an attempt will be
-        remade every 5 seconds.
-
-        .. note::
-            This method is called only once, at the time when Patroni is started.
-        """
+    def load_dynamic_configuration(self):
         from patroni.exceptions import DCSError
         while True:
             try:
@@ -98,71 +47,24 @@ class Patroni(AbstractPatroniDaemon):
                 elif not self.config.dynamic_configuration and 'bootstrap' in self.config:
                     if self.config.set_dynamic_configuration(self.config['bootstrap']['dcs']):
                         self.dcs.reload_config(self.config)
-                        self.watchdog.reload_config(self.config)
                 break
             except DCSError:
                 logger.warning('Can not get cluster from dcs')
                 time.sleep(5)
 
-    def ensure_unique_name(self) -> None:
-        """A helper method to prevent splitbrain from operator naming error."""
-        from patroni.dcs import Member
-
-        cluster = self.dcs.get_cluster()
-        if not cluster:
-            return
-        member = cluster.get_member(self.config['name'], False)
-        if not isinstance(member, Member):
-            return
-        try:
-            _ = self.request(member, endpoint="/liveness", timeout=3)
-            logger.fatal("Can't start; there is already a node named '%s' running", self.config['name'])
-            sys.exit(1)
-        except Exception:
-            return
-
-    def get_tags(self) -> Dict[str, Any]:
-        """Get tags configured for this node, if any.
-
-        Handle both predefined Patroni tags and custom defined tags.
-
-        .. note::
-            A custom tag is any tag added to the configuration ``tags`` section that is not one of ``clonefrom``,
-            ``nofailover``, ``noloadbalance`` or ``nosync``.
-
-            For the Patroni predefined tags, the returning object will only contain them if they are enabled as they
-            all are boolean values that default to disabled.
-
-        :returns: a dictionary of tags set for this node. The key is the tag name, and the value is the corresponding
-            tag value.
-        """
+    def get_tags(self):
         return {tag: value for tag, value in self.config.get('tags', {}).items()
                 if tag not in ('clonefrom', 'nofailover', 'noloadbalance', 'nosync') or value}
 
     @property
-    def nofailover(self) -> bool:
-        """``True`` if ``tags.nofailover`` configuration is enabled for this node, else ``False``."""
+    def nofailover(self):
         return bool(self.tags.get('nofailover', False))
 
     @property
-    def nosync(self) -> bool:
-        """``True`` if ``tags.nosync`` configuration is enabled for this node, else ``False``."""
+    def nosync(self):
         return bool(self.tags.get('nosync', False))
 
-    def reload_config(self, sighup: bool = False, local: Optional[bool] = False) -> None:
-        """Apply new configuration values for ``patroni`` daemon.
-
-        Reload:
-            * Cached tags;
-            * Request wrapper configuration;
-            * REST API configuration;
-            * Watchdog configuration;
-            * Postgres configuration;
-            * DCS configuration.
-
-        :param sighup: if it is related to a SIGHUP signal.
-        :param local: if there has been changes to the local configuration file.
-        """
+    def reload_config(self, sighup=False, local=False):
         try:
             super(Patroni, self).reload_config(sighup, local)
             if local:
@@ -177,21 +79,14 @@ class Patroni(AbstractPatroniDaemon):
             logger.exception('Failed to reload config_file=%s', self.config.config_file)
 
     @property
-    def replicatefrom(self) -> Optional[str]:
-        """Value of ``tags.replicatefrom`` configuration, if any."""
+    def replicatefrom(self):
         return self.tags.get('replicatefrom')
 
     @property
-    def noloadbalance(self) -> bool:
-        """``True`` if ``tags.noloadbalance`` configuration is enabled for this node, else ``False``."""
+    def noloadbalance(self):
         return bool(self.tags.get('noloadbalance', False))
 
-    def schedule_next_run(self) -> None:
-        """Schedule the next run of the ``patroni`` daemon main loop.
-
-        Next run is scheduled based on previous run plus value of ``loop_wait`` configuration from DCS. If that has
-        already been exceeded, run the next cycle immediately.
-        """
+    def schedule_next_run(self):
         self.next_run += self.dcs.loop_wait
         current_time = time.time()
         nap_time = self.next_run - current_time
@@ -204,22 +99,12 @@ class Patroni(AbstractPatroniDaemon):
         elif self.ha.watch(nap_time):
             self.next_run = time.time()
 
-    def run(self) -> None:
-        """Run ``patroni`` daemon process main loop.
-
-        Start the REST API and keep running HA cycles every ``loop_wait`` seconds.
-        """
+    def run(self):
         self.api.start()
         self.next_run = time.time()
         super(Patroni, self).run()
 
-    def _run_cycle(self) -> None:
-        """Run a cycle of the ``patroni`` daemon main loop.
-
-        Run an HA cycle and schedule the next cycle run. If any dynamic configuration change request is detected, apply
-        the change and cache the new dynamic configuration values in ``patroni.dynamic.json`` file under Postgres data
-        directory.
-        """
+    def _run_cycle(self):
         logger.info(self.ha.run_cycle())
 
         if self.dcs.cluster and self.dcs.cluster.config and self.dcs.cluster.config.data \
@@ -231,11 +116,7 @@ class Patroni(AbstractPatroniDaemon):
 
         self.schedule_next_run()
 
-    def _shutdown(self) -> None:
-        """Perform shutdown of ``patroni`` daemon process.
-
-        Shut down the REST API and the HA handler.
-        """
+    def _shutdown(self):
         try:
             self.api.shutdown()
         except Exception:
@@ -246,100 +127,27 @@ class Patroni(AbstractPatroniDaemon):
             logger.exception('Exception during Ha.shutdown')
 
 
-def patroni_main(configfile: str) -> None:
-    """Configure and start ``patroni`` main daemon process.
-
-    :param configfile: path to Patroni configuration file.
-    """
+def patroni_main():
     from multiprocessing import freeze_support
+    from patroni.validator import schema
 
-    # Windows executables created by PyInstaller are frozen, thus we need to enable frozen support for
-    # :mod:`multiprocessing` to avoid :class:`RuntimeError` exceptions.
     freeze_support()
-    abstract_main(Patroni, configfile)
+    abstract_main(Patroni, schema)
 
 
-def process_arguments() -> Namespace:
-    """Process command-line arguments.
-
-    Create a basic command-line parser through :func:`~patroni.daemon.get_base_arg_parser`, extend its capabilities by
-    adding these flags and parse command-line arguments.:
-
-      * ``--validate-config`` -- used to validate the Patroni configuration file
-      * ``--generate-config`` -- used to generate Patroni configuration from a running PostgreSQL instance
-      * ``--generate-sample-config`` -- used to generate a sample Patroni configuration
-
-    .. note::
-        If running with ``--generate-config``, ``--generate-sample-config`` or ``--validate-flag`` will exit
-        after generating or validating configuration.
-
-    :returns: parsed arguments, if not running with ``--validate-config`` flag.
-    """
-    from patroni.config_generator import generate_config
-
-    parser = get_base_arg_parser()
-    group = parser.add_mutually_exclusive_group()
-    group.add_argument('--validate-config', action='store_true', help='Run config validator and exit')
-    group.add_argument('--generate-sample-config', action='store_true',
-                       help='Generate a sample Patroni yaml configuration file')
-    group.add_argument('--generate-config', action='store_true',
-                       help='Generate a Patroni yaml configuration file for a running instance')
-    parser.add_argument('--dsn', help='Optional DSN string of the instance to be used as a source \
-                                    for config generation. Superuser connection is required.')
-    args = parser.parse_args()
-
-    if args.generate_sample_config:
-        generate_config(args.configfile, True, None)
-        sys.exit(0)
-    elif args.generate_config:
-        generate_config(args.configfile, False, args.dsn)
-        sys.exit(0)
-    elif args.validate_config:
-        from patroni.validator import schema
-        from patroni.config import Config, ConfigParseError
-
-        try:
-            Config(args.configfile, validator=schema)
-            sys.exit()
-        except ConfigParseError as e:
-            sys.exit(e.value)
-
-    return args
-
-
-def main() -> None:
-    """Main entrypoint of :mod:`patroni.__main__`.
-
-    Process command-line arguments, ensure :mod:`psycopg2` (or :mod:`psycopg`) attendee the pre-requisites and start
-    ``patroni`` daemon process.
-
-    .. note::
-        If running through a Docker container, make the main process take care of init process duties and run
-        ``patroni`` daemon as another process. In that case relevant signals received by the main process and forwarded
-        to ``patroni`` daemon process.
-    """
-    from patroni import check_psycopg
-
-    args = process_arguments()
-
-    check_psycopg()
-
+def main():
     if os.getpid() != 1:
-        return patroni_main(args.configfile)
+        from . import check_psycopg
+
+        check_psycopg()
+        return patroni_main()
 
     # Patroni started with PID=1, it looks like we are in the container
-    from types import FrameType
     pid = 0
 
     # Looks like we are in a docker, so we will act like init
-    def sigchld_handler(signo: int, stack_frame: Optional[FrameType]) -> None:
-        """Handle ``SIGCHLD`` received by main process from ``patroni`` daemon when the daemon terminates.
-
-        :param signo: signal number.
-        :param stack_frame: current stack frame.
-        """
+    def sigchld_handler(signo, stack_frame):
         try:
-            # log exit code of all children processes, and break loop when there is none left
             while True:
                 ret = os.waitpid(-1, os.WNOHANG)
                 if ret == (0, 0):
@@ -349,12 +157,7 @@ def main() -> None:
         except OSError:
             pass
 
-    def passtochild(signo: int, stack_frame: Optional[FrameType]) -> None:
-        """Forward a signal *signo* from main process to child process.
-
-        :param signo: signal number.
-        :param stack_frame: current stack frame.
-        """
+    def passtochild(signo, stack_frame):
         if pid:
             os.kill(pid, signo)
 
@@ -369,7 +172,7 @@ def main() -> None:
     signal.signal(signal.SIGTERM, passtochild)
 
     import multiprocessing
-    patroni = multiprocessing.Process(target=patroni_main, args=(args.configfile,))
+    patroni = multiprocessing.Process(target=patroni_main)
     patroni.start()
     pid = patroni.pid
     patroni.join()

patroni/async_executor.py

@@ -1,11 +1,5 @@
-"""Implement facilities for executing asynchronous tasks."""
 import logging
-
 from threading import Event, Lock, RLock, Thread
-from types import TracebackType
-from typing import Any, Callable, Optional, Tuple, Type
-
-from .postgresql.cancellable import CancellableSubprocess
 
 logger = logging.getLogger(__name__)
 
@@ -14,110 +8,65 @@ class CriticalTask(object):
     """Represents a critical task in a background process that we either need to cancel or get the result of.
 
     Fields of this object may be accessed only when holding a lock on it. To perform the critical task the background
-    thread must, while holding lock on this object, check ``is_cancelled`` flag, run the task and mark the task as
-    complete using :func:`complete`.
+    thread must, while holding lock on this object, check `is_cancelled` flag, run the task and mark the task as
+    complete using `complete()`.
 
     The main thread must hold async lock to prevent the task from completing, hold lock on critical task object,
-    call :func:`cancel`. If the task has completed :func:`cancel` will return ``False`` and ``result`` field will
-    contain the result of the task. When :func:`cancel` returns ``True`` it is guaranteed that the background task will
-    notice the ``is_cancelled`` flag.
-
-    :ivar is_cancelled: if the critical task has been cancelled.
-    :ivar result: contains the result of the task, if it has already been completed.
+    call cancel. If the task has completed `cancel()` will return False and `result` field will contain the result of
+    the task. When cancel returns True it is guaranteed that the background task will notice the `is_cancelled` flag.
     """
-
-    def __init__(self) -> None:
-        """Create a new instance of :class:`CriticalTask`.
-
-        Instantiate the lock and the task control attributes.
-        """
+    def __init__(self):
         self._lock = Lock()
         self.is_cancelled = False
         self.result = None
 
-    def reset(self) -> None:
+    def reset(self):
         """Must be called every time the background task is finished.
 
-        .. note::
-            Must be called from async thread. Caller must hold lock on async executor when calling.
-        """
+        Must be called from async thread. Caller must hold lock on async executor when calling."""
         self.is_cancelled = False
         self.result = None
 
-    def cancel(self) -> bool:
-        """Tries to cancel the task.
+    def cancel(self):
+        """Tries to cancel the task, returns True if the task has already run.
 
-        .. note::
-            Caller must hold lock on async executor and the task when calling.
-
-        :returns: ``False`` if the task has already run, or ``True`` it has been cancelled.
-        """
+        Caller must hold lock on async executor and the task when calling."""
         if self.result is not None:
             return False
         self.is_cancelled = True
         return True
 
-    def complete(self, result: Any) -> None:
-        """Mark task as completed along with a *result*.
+    def complete(self, result):
+        """Mark task as completed along with a result.
 
-        .. note::
-            Must be called from async thread. Caller must hold lock on task when calling.
-        """
+        Must be called from async thread. Caller must hold lock on task when calling."""
         self.result = result
 
-    def __enter__(self) -> 'CriticalTask':
-        """Acquire the object lock when entering the context manager."""
+    def __enter__(self):
         self._lock.acquire()
         return self
 
-    def __exit__(self, exc_type: Optional[Type[BaseException]],
-                 exc_val: Optional[BaseException], exc_tb: Optional[TracebackType]) -> None:
-        """Release the object lock when exiting the context manager."""
+    def __exit__(self, exc_type, exc_val, exc_tb):
         self._lock.release()
 
 
 class AsyncExecutor(object):
-    """Asynchronous executor of (long) tasks.
 
-    :ivar critical_task: a :class:`CriticalTask` instance to handle execution of critical background tasks.
-    """
-
-    def __init__(self, cancellable: CancellableSubprocess, ha_wakeup: Callable[..., None]) -> None:
-        """Create a new instance of :class:`AsyncExecutor`.
-
-        Configure the given *cancellable* and *ha_wakeup*, initializes the control attributes, and instantiate the lock
-        and event objects that are used to access attributes and manage communication between threads.
-
-        :param cancellable: a subprocess that supports being cancelled.
-        :param ha_wakeup: function to wake up the HA loop.
-        """
+    def __init__(self, cancellable, ha_wakeup):
         self._cancellable = cancellable
         self._ha_wakeup = ha_wakeup
         self._thread_lock = RLock()
-        self._scheduled_action: Optional[str] = None
+        self._scheduled_action = None
         self._scheduled_action_lock = RLock()
         self._is_cancelled = False
         self._finish_event = Event()
         self.critical_task = CriticalTask()
 
     @property
-    def busy(self) -> bool:
-        """``True`` if there is an action scheduled to occur, else ``False``."""
+    def busy(self):
         return self.scheduled_action is not None
 
-    def schedule(self, action: str) -> Optional[str]:
-        """Schedule *action* to be executed.
-
-        .. note::
-            Must be called before executing a task.
-
-        .. note::
-            *action* can only be scheduled if there is no other action currently scheduled.
-
-        :param action: action to be executed.
-
-        :returns: ``None`` if *action* has been successfully scheduled, or the previously scheduled action, if any.
-        """
+    def schedule(self, action):
         with self._scheduled_action_lock:
             if self._scheduled_action is not None:
                 return self._scheduled_action
@@ -127,33 +76,15 @@ class AsyncExecutor(object):
         return None
 
     @property
-    def scheduled_action(self) -> Optional[str]:
-        """The currently scheduled action, if any, else ``None``."""
+    def scheduled_action(self):
         with self._scheduled_action_lock:
             return self._scheduled_action
 
-    def reset_scheduled_action(self) -> None:
-        """Unschedule a previously scheduled action, if any.
-
-        .. note::
-            Must be called once the scheduled task finishes or is cancelled.
-        """
+    def reset_scheduled_action(self):
         with self._scheduled_action_lock:
             self._scheduled_action = None
 
-    def run(self, func: Callable[..., Any], args: Tuple[Any, ...] = ()) -> Optional[Any]:
-        """Run *func* with *args*.
-
-        .. note::
-            Expected to be executed through a thread.
-
-        :param func: function to be run. If it returns anything other than ``None``, HA loop will be woken up at the end
-            of :func:`run` execution.
-        :param args: arguments to be passed to *func*.
-
-        :returns: ``None`` if *func* execution has been cancelled or faced any exception, otherwise the result of
-            *func*.
-        """
+    def run(self, func, args=()):
         wakeup = False
         try:
             with self:
@@ -176,37 +107,16 @@ class AsyncExecutor(object):
             if wakeup is not None:
                 self._ha_wakeup()
 
-    def run_async(self, func: Callable[..., Any], args: Tuple[Any, ...] = ()) -> None:
-        """Start an async thread that runs *func* with *args*.
-
-        :param func: function to be run. Will be passed through args to :class:`~threading.Thread` with a target of
-            :func:`run`.
-        :param args: arguments to be passed along to :class:`~threading.Thread` with *func*.
-
-        """
+    def run_async(self, func, args=()):
         Thread(target=self.run, args=(func, args)).start()
 
-    def try_run_async(self, action: str, func: Callable[..., Any], args: Tuple[Any, ...] = ()) -> Optional[str]:
-        """Try to run an async task, if none is currently being executed.
-
-        :param action: name of the task to be executed.
-        :param func: actual function that performs the task *action*.
-        :param args: arguments to be passed to *func*.
-
-        :returns: ``None`` if *func* was scheduled successfully, otherwise an error message informing of an already
-            ongoing task.
-        """
+    def try_run_async(self, action, func, args=()):
         prev = self.schedule(action)
         if prev is None:
             return self.run_async(func, args)
         return 'Failed to run {0}, {1} is already in progress'.format(action, prev)
 
-    def cancel(self) -> None:
-        """Request cancellation of a scheduled async task, if any.
-
-        .. note::
-            Wait until task is cancelled before returning control to caller.
-        """
+    def cancel(self):
         with self:
             with self._scheduled_action_lock:
                 if self._scheduled_action is None:
@@ -220,16 +130,8 @@ class AsyncExecutor(object):
         with self:
             self.reset_scheduled_action()
 
-    def __enter__(self) -> 'AsyncExecutor':
-        """Acquire the thread lock when entering the context manager."""
+    def __enter__(self):
         self._thread_lock.acquire()
-        return self
 
-    def __exit__(self, exc_type: Optional[Type[BaseException]],
-                 exc_val: Optional[BaseException], exc_tb: Optional[TracebackType]) -> None:
-        """Release the thread lock when exiting the context manager.
-
-        .. note::
-            The arguments are not used, but we need them to match the expected method signature.
-        """
+    def __exit__(self, *args):
         self._thread_lock.release()

patroni/collections.py

@@ -1,209 +0,0 @@
-"""Patroni custom object types somewhat like :mod:`collections` module.
-
-Provides a case insensitive :class:`dict` and :class:`set` object types.
-"""
-from collections import OrderedDict
-from typing import Any, Collection, Dict, Iterator, KeysView, MutableMapping, MutableSet, Optional
-
-
-class CaseInsensitiveSet(MutableSet[str]):
-    """A case-insensitive :class:`set`-like object.
-
-    Implements all methods and operations of :class:`~typing.MutableSet`. All values are expected to be strings.
-    The structure remembers the case of the last value set, however, contains testing is case insensitive.
-    """
-
-    def __init__(self, values: Optional[Collection[str]] = None) -> None:
-        """Create a new instance of :class:`CaseInsensitiveSet` with the given *values*.
-
-        :param values: values to be added to the set.
-        """
-        self._values: Dict[str, str] = {}
-        for v in values or ():
-            self.add(v)
-
-    def __repr__(self) -> str:
-        """Get a string representation of the set.
-
-        Provide a helpful way of recreating the set.
-
-        :returns: representation of the set, showing its values.
-
-        :Example:
-
-            >>> repr(CaseInsensitiveSet(('1', 'test', 'Test', 'TESt', 'test2')))  # doctest: +ELLIPSIS
-            "<CaseInsensitiveSet('1', 'TESt', 'test2') at ..."
-        """
-        return '<{0}{1} at {2:x}>'.format(type(self).__name__, tuple(self._values.values()), id(self))
-
-    def __str__(self) -> str:
-        """Get set values for printing.
-
-        :returns: set of values in string format.
-
-        :Example:
-
-            >>> str(CaseInsensitiveSet(('1', 'test', 'Test', 'TESt', 'test2')))  # doctest: +SKIP
-            "{'TESt', 'test2', '1'}"
-        """
-        return str(set(self._values.values()))
-
-    def __contains__(self, value: str) -> bool:
-        """Check if set contains *value*.
-
-        The check is performed case-insensitively.
-
-        :param value: value to be checked.
-
-        :returns: ``True`` if *value* is already in the set, ``False`` otherwise.
-        """
-        return value.lower() in self._values
-
-    def __iter__(self) -> Iterator[str]:
-        """Iterate over the values in this set.
-
-        :yields: values from set.
-        """
-        return iter(self._values.values())
-
-    def __len__(self) -> int:
-        """Get the length of this set.
-
-        :returns: number of values in the set.
-
-        :Example:
-
-        >>> len(CaseInsensitiveSet(('1', 'test', 'Test', 'TESt', 'test2')))
-        3
-        """
-        return len(self._values)
-
-    def add(self, value: str) -> None:
-        """Add *value* to this set.
-
-        Search is performed case-insensitively. If *value* is already in the set, overwrite it with *value*, so we
-        "remember" the last case of *value*.
-
-        :param value: value to be added to the set.
-        """
-        self._values[value.lower()] = value
-
-    def discard(self, value: str) -> None:
-        """Remove *value* from this set.
-
-        Search is performed case-insensitively. If *value* is not present in the set, no exception is raised.
-
-        :param value: value to be removed from the set.
-        """
-        self._values.pop(value.lower(), None)
-
-    def issubset(self, other: 'CaseInsensitiveSet') -> bool:
-        """Check if this set is a subset of *other*.
-
-        :param other: another set to be compared with this set.
-        :returns: ``True`` if this set is a subset of *other*, else ``False``.
-        """
-        return self <= other
-
-
-class CaseInsensitiveDict(MutableMapping[str, Any]):
-    """A case-insensitive :class:`dict`-like object.
-
-    Implements all methods and operations of :class:`~typing.MutableMapping` as well as :class:`dict`'s
-    :func:`~dict.copy`. All keys are expected to be strings. The structure remembers the case of the last key to be set,
-    and :func:`iter`, :func:`dict.keys`, :func:`dict.items`, :func:`dict.iterkeys`, and :func:`dict.iteritems` will
-    contain case-sensitive keys. However, querying and contains testing is case insensitive.
-    """
-
-    def __init__(self, data: Optional[Dict[str, Any]] = None) -> None:
-        """Create a new instance of :class:`CaseInsensitiveDict` with the given *data*.
-
-        :param data: initial dictionary to create a :class:`CaseInsensitiveDict` from.
-        """
-        self._values: OrderedDict[str, Any] = OrderedDict()
-        self.update(data or {})
-
-    def __setitem__(self, key: str, value: Any) -> None:
-        """Assign *value* to *key* in this dict.
-
-        *key* is searched/stored case-insensitively in the dict. The corresponding value in the dict is a tuple of:
-            * original *key*;
-            * *value*.
-
-        :param key: key to be created or updated in the dict.
-        :param value: value for *key*.
-        """
-        self._values[key.lower()] = (key, value)
-
-    def __getitem__(self, key: str) -> Any:
-        """Get the value corresponding to *key*.
-
-        *key* is searched case-insensitively in the dict.
-
-        .. note:
-            If *key* is not present in the dict, :class:`KeyError` will be triggered.
-
-        :param key: key to be searched in the dict.
-
-        :returns: value corresponding to *key*.
-        """
-        return self._values[key.lower()][1]
-
-    def __delitem__(self, key: str) -> None:
-        """Remove *key* from this dict.
-
-        *key* is searched case-insensitively in the dict.
-
-        .. note:
-            If *key* is not present in the dict, :class:`KeyError` will be triggered.
-
-        :param key: key to be removed from the dict.
-        """
-        del self._values[key.lower()]
-
-    def __iter__(self) -> Iterator[str]:
-        """Iterate over keys of this dict.
-
-        :yields: each key present in the dict. Yields each key with its last case that has been stored.
-        """
-        return iter(key for key, _ in self._values.values())
-
-    def __len__(self) -> int:
-        """Get the length of this dict.
-
-        :returns: number of keys in the dict.
-
-        :Example:
-
-        >>> len(CaseInsensitiveDict({'a': 'b', 'A': 'B', 'c': 'd'}))
-        2
-        """
-        return len(self._values)
-
-    def copy(self) -> 'CaseInsensitiveDict':
-        """Create a copy of this dict.
-
-        :return: a new dict object with the same keys and values of this dict.
-        """
-        return CaseInsensitiveDict({v[0]: v[1] for v in self._values.values()})
-
-    def keys(self) -> KeysView[str]:
-        """Return a new view of the dict's keys.
-
-        :returns: a set-like object providing a view on the dict's keys
-        """
-        return self._values.keys()
-
-    def __repr__(self) -> str:
-        """Get a string representation of the dict.
-
-        Provide a helpful way of recreating the dict.
-
-        :returns: representation of the dict, showing its keys and values.
-
-        :Example:
-
-            >>> repr(CaseInsensitiveDict({'a': 'b', 'A': 'B', 'c': 'd'}))  # doctest: +ELLIPSIS
-            "<CaseInsensitiveDict{'A': 'B', 'c': 'd'} at ..."
-        """
-        return '<{0}{1} at {2:x}>'.format(type(self).__name__, dict(self.items()), id(self))

patroni/config.py

@@ -1,4 +1,3 @@
-"""Facilities related to Patroni configuration."""
 import json
 import logging
 import os
@@ -8,15 +7,11 @@ import yaml
 
 from collections import defaultdict
 from copy import deepcopy
-from typing import Any, Callable, Collection, Dict, List, Optional, Union, TYPE_CHECKING
-
-from . import PATRONI_ENV_PREFIX
-from .collections import CaseInsensitiveDict
-from .dcs import ClusterConfig, Cluster
-from .exceptions import ConfigParseError
-from .file_perm import pg_perm
-from .postgresql.config import ConfigHandler
-from .utils import deep_compare, parse_bool, parse_int, patch_config
+from patroni import PATRONI_ENV_PREFIX
+from patroni.exceptions import ConfigParseError
+from patroni.dcs import ClusterConfig
+from patroni.postgresql.config import CaseInsensitiveDict, ConfigHandler
+from patroni.utils import deep_compare, parse_bool, parse_int, patch_config
 
 logger = logging.getLogger(__name__)
 
@@ -35,203 +30,44 @@ _AUTH_ALLOWED_PARAMETERS = (
 )
 
 
-def default_validator(conf: Dict[str, Any]) -> List[str]:
-    """Ensure *conf* is not empty.
-
-    Designed to be used as default validator for :class:`Config` objects, if no specific validator is provided.
-
-    :param conf: configuration to be validated.
-
-    :returns: an empty list -- :class:`Config` expects the validator to return a list of 0 or more issues found while
-        validating the configuration.
-
-    :raises:
-        :class:`ConfigParseError`: if *conf* is empty.
-    """
+def default_validator(conf):
     if not conf:
-        raise ConfigParseError("Config is empty.")
-    return []
-
-
-class GlobalConfig(object):
-    """A class that wraps global configuration and provides convenient methods to access/check values.
-
-    It is instantiated either by calling :func:`get_global_config` or :meth:`Config.get_global_config`, which picks
-    either a configuration from provided :class:`Cluster` object (the most up-to-date) or from the
-    local cache if :class:`ClusterConfig` is not initialized or doesn't have a valid config.
-    """
-
-    def __init__(self, config: Dict[str, Any]) -> None:
-        """Initialize :class:`GlobalConfig` object with given *config*.
-
-        :param config: current configuration either from
-                       :class:`ClusterConfig` or from :func:`Config.dynamic_configuration`.
-        """
-        self.__config = config
-
-    def get(self, name: str) -> Any:
-        """Gets global configuration value by *name*.
-
-        :param name: parameter name.
-
-        :returns: configuration value or ``None`` if it is missing.
-        """
-        return self.__config.get(name)
-
-    def check_mode(self, mode: str) -> bool:
-        """Checks whether the certain parameter is enabled.
-
-        :param mode: parameter name, e.g. ``synchronous_mode``, ``failsafe_mode``, ``pause``, ``check_timeline``, and
-            so on.
-
-        :returns: ``True`` if parameter *mode* is enabled in the global configuration.
-        """
-        return bool(parse_bool(self.__config.get(mode)))
-
-    @property
-    def is_paused(self) -> bool:
-        """``True`` if cluster is in maintenance mode."""
-        return self.check_mode('pause')
-
-    @property
-    def is_synchronous_mode(self) -> bool:
-        """``True`` if synchronous replication is requested."""
-        return self.check_mode('synchronous_mode')
-
-    @property
-    def is_synchronous_mode_strict(self) -> bool:
-        """``True`` if at least one synchronous node is required."""
-        return self.check_mode('synchronous_mode_strict')
-
-    def get_standby_cluster_config(self) -> Union[Dict[str, Any], Any]:
-        """Get ``standby_cluster`` configuration.
-
-        :returns: a copy of ``standby_cluster`` configuration.
-        """
-        return deepcopy(self.get('standby_cluster'))
-
-    @property
-    def is_standby_cluster(self) -> bool:
-        """``True`` if global configuration has a valid ``standby_cluster`` section."""
-        config = self.get_standby_cluster_config()
-        return isinstance(config, dict) and\
-            bool(config.get('host') or config.get('port') or config.get('restore_command'))
-
-    def get_int(self, name: str, default: int = 0) -> int:
-        """Gets current value of *name* from the global configuration and try to return it as :class:`int`.
-
-        :param name: name of the parameter.
-        :param default: default value if *name* is not in the configuration or invalid.
-
-        :returns: currently configured value of *name* from the global configuration or *default* if it is not set or
-            invalid.
-        """
-        ret = parse_int(self.get(name))
-        return default if ret is None else ret
-
-    @property
-    def min_synchronous_nodes(self) -> int:
-        """The minimal number of synchronous nodes based on whether ``synchronous_mode_strict`` is enabled or not."""
-        return 1 if self.is_synchronous_mode_strict else 0
-
-    @property
-    def synchronous_node_count(self) -> int:
-        """Currently configured value of ``synchronous_node_count`` from the global configuration.
-
-        Assume ``1`` if it is not set or invalid.
-        """
-        return max(self.get_int('synchronous_node_count', 1), self.min_synchronous_nodes)
-
-    @property
-    def maximum_lag_on_failover(self) -> int:
-        """Currently configured value of ``maximum_lag_on_failover`` from the global configuration.
-
-        Assume ``1048576`` if it is not set or invalid.
-        """
-        return self.get_int('maximum_lag_on_failover', 1048576)
-
-    @property
-    def maximum_lag_on_syncnode(self) -> int:
-        """Currently configured value of ``maximum_lag_on_syncnode`` from the global configuration.
-
-        Assume ``-1`` if it is not set or invalid.
-        """
-        return self.get_int('maximum_lag_on_syncnode', -1)
-
-    @property
-    def primary_start_timeout(self) -> int:
-        """Currently configured value of ``primary_start_timeout`` from the global configuration.
-
-        Assume ``300`` if it is not set or invalid.
-
-        .. note::
-            ``master_start_timeout`` is still supported to keep backward compatibility.
-        """
-        default = 300
-        return self.get_int('primary_start_timeout', default)\
-            if 'primary_start_timeout' in self.__config else self.get_int('master_start_timeout', default)
-
-    @property
-    def primary_stop_timeout(self) -> int:
-        """Currently configured value of ``primary_stop_timeout`` from the global configuration.
-
-        Assume ``0`` if it is not set or invalid.
-
-        .. note::
-            ``master_stop_timeout`` is still supported to keep backward compatibility.
-        """
-        default = 0
-        return self.get_int('primary_stop_timeout', default)\
-            if 'primary_stop_timeout' in self.__config else self.get_int('master_stop_timeout', default)
-
-
-def get_global_config(cluster: Optional[Cluster], default: Optional[Dict[str, Any]] = None) -> GlobalConfig:
-    """Instantiates :class:`GlobalConfig` based on the input.
-
-    :param cluster: the currently known cluster state from DCS.
-    :param default: default configuration, which will be used if there is no valid *cluster.config*.
-
-    :returns: :class:`GlobalConfig` object.
-    """
-    # Try to protect from the case when DCS was wiped out
-    if cluster and cluster.config and cluster.config.modify_version:
-        config = cluster.config.data
-    else:
-        config = default or {}
-    return GlobalConfig(deepcopy(config))
+        return "Config is empty."
 
 
 class Config(object):
-    """Handle Patroni configuration.
-
+    """
     This class is responsible for:
 
-      1) Building and giving access to ``effective_configuration`` from:
+      1) Building and giving access to `effective_configuration` from:
+         * `Config.__DEFAULT_CONFIG` -- some sane default values
+         * `dynamic_configuration` -- configuration stored in DCS
+         * `local_configuration` -- configuration from `config.yml` or environment
 
-         * ``Config.__DEFAULT_CONFIG`` -- some sane default values;
-         * ``dynamic_configuration`` -- configuration stored in DCS;
-         * ``local_configuration`` -- configuration from `config.yml` or environment.
-
-      2) Saving and loading ``dynamic_configuration`` into 'patroni.dynamic.json' file
+      2) Saving and loading `dynamic_configuration` into 'patroni.dynamic.json' file
          located in local_configuration['postgresql']['data_dir'] directory.
-         This is necessary to be able to restore ``dynamic_configuration``
-         if DCS was accidentally wiped.
+         This is necessary to be able to restore `dynamic_configuration`
+         if DCS was accidentally wiped
 
-      3) Loading of configuration file in the old format and converting it into new format.
+      3) Loading of configuration file in the old format and converting it into new format
 
-      4) Mimicking some ``dict`` interfaces to make it possible
-         to work with it as with the old ``config`` object.
-
-    :cvar PATRONI_CONFIG_VARIABLE: name of the environment variable that can be used to load Patroni configuration from.
-    :cvar __CACHE_FILENAME: name of the file used to cache dynamic configuration under Postgres data directory.
-    :cvar __DEFAULT_CONFIG: default configuration values for some Patroni settings.
+      4) Mimicking some of the `dict` interfaces to make it possible
+         to work with it as with the old `config` object.
     """
 
     PATRONI_CONFIG_VARIABLE = PATRONI_ENV_PREFIX + 'CONFIGURATION'
 
     __CACHE_FILENAME = 'patroni.dynamic.json'
-    __DEFAULT_CONFIG: Dict[str, Any] = {
+    __DEFAULT_CONFIG = {
         'ttl': 30, 'loop_wait': 10, 'retry_timeout': 10,
+        'maximum_lag_on_failover': 1048576,
+        'maximum_lag_on_syncnode': -1,
+        'check_timeline': False,
+        'master_start_timeout': 300,
+        'master_stop_timeout': 0,
+        'synchronous_mode': False,
+        'synchronous_mode_strict': False,
+        'synchronous_node_count': 1,
         'standby_cluster': {
             'create_replica_methods': '',
             'host': '',
@@ -242,95 +78,55 @@ class Config(object):
             'recovery_min_apply_delay': ''
         },
         'postgresql': {
+            'bin_dir': '',
             'use_slots': True,
             'parameters': CaseInsensitiveDict({p: v[0] for p, v in ConfigHandler.CMDLINE_OPTIONS.items()
-                                               if v[0] is not None and p not in ('wal_keep_segments', 'wal_keep_size')})
+                                               if p not in ('wal_keep_segments', 'wal_keep_size')})
+        },
+        'watchdog': {
+            'mode': 'automatic',
         }
     }
 
-    def __init__(self, configfile: str,
-                 validator: Optional[Callable[[Dict[str, Any]], List[str]]] = default_validator) -> None:
-        """Create a new instance of :class:`Config` and validate the loaded configuration using *validator*.
-
-        .. note::
-            Patroni will read configuration from these locations in this order:
-
-              * file or directory path passed as command-line argument (*configfile*), if it exists and the file or
-                files found in the directory can be parsed (see :meth:`~Config._load_config_path`), otherwise
-              * YAML file passed via the environment variable (see :cvar:`PATRONI_CONFIG_VARIABLE`), if the referenced
-                file exists and can be parsed, otherwise
-              * from configuration values defined as environment variables, see
-                :meth:`~Config._build_environment_configuration`.
-
-        :param configfile: path to Patroni configuration file.
-        :param validator: function used to validate Patroni configuration. It should receive a dictionary which
-            represents Patroni configuration, and return a list of zero or more error messages based on validation.
-
-        :raises:
-            :class:`ConfigParseError`: if any issue is reported by *validator*.
-        """
-        self._modify_version = -1
+    def __init__(self, configfile, validator=default_validator):
+        self._modify_index = -1
         self._dynamic_configuration = {}
 
         self.__environment_configuration = self._build_environment_configuration()
 
-        self._config_file = configfile if configfile and os.path.exists(configfile) else None
+        # Patroni reads the configuration from the command-line argument if it exists, otherwise from the environment
+        self._config_file = configfile and os.path.exists(configfile) and configfile
         if self._config_file:
             self._local_configuration = self._load_config_file()
         else:
             config_env = os.environ.pop(self.PATRONI_CONFIG_VARIABLE, None)
             self._local_configuration = config_env and yaml.safe_load(config_env) or self.__environment_configuration
-
         if validator:
-            errors = validator(self._local_configuration)
-            if errors:
-                raise ConfigParseError("\n".join(errors))
+            error = validator(self._local_configuration)
+            if error:
+                raise ConfigParseError(error)
 
         self.__effective_configuration = self._build_effective_configuration({}, self._local_configuration)
         self._data_dir = self.__effective_configuration.get('postgresql', {}).get('data_dir', "")
         self._cache_file = os.path.join(self._data_dir, self.__CACHE_FILENAME)
-        if validator:  # patronictl uses validator=None and we don't want to load anything from local cache in this case
-            self._load_cache()
+        self._load_cache()
         self._cache_needs_saving = False
 
     @property
-    def config_file(self) -> Optional[str]:
-        """Path to Patroni configuration file, if any, else ``None``."""
+    def config_file(self):
         return self._config_file
 
     @property
-    def dynamic_configuration(self) -> Dict[str, Any]:
-        """Deep copy of cached Patroni dynamic configuration."""
+    def dynamic_configuration(self):
         return deepcopy(self._dynamic_configuration)
 
-    @property
-    def local_configuration(self) -> Dict[str, Any]:
-        """Deep copy of cached Patroni local configuration.
+    def check_mode(self, mode):
+        return bool(parse_bool(self._dynamic_configuration.get(mode)))
 
-        :returns: copy of :attr:`~Config._local_configuration`
+    def _load_config_path(self, path):
         """
-        return deepcopy(dict(self._local_configuration))
-
-    @classmethod
-    def get_default_config(cls) -> Dict[str, Any]:
-        """Deep copy default configuration.
-
-        :returns: copy of :attr:`~Config.__DEFAULT_CONFIG`
-        """
-        return deepcopy(cls.__DEFAULT_CONFIG)
-
-    def _load_config_path(self, path: str) -> Dict[str, Any]:
-        """Load Patroni configuration file(s) from *path*.
-
-        If *path* is a file, load the yml file pointed to by *path*.
-        If *path* is a directory, load all yml files in that directory in alphabetical order.
-
-        :param path: path to either an YAML configuration file, or to a folder containing YAML configuration files.
-
-        :returns: configuration after reading the configuration file(s) from *path*.
-
-        :raises:
-            :class:`ConfigParseError`: if *path* is invalid.
+        If path is a file, loads the yml file pointed to by path.
+        If path is a directory, loads all yml files in that directory in alphabetical order
         """
         if os.path.isfile(path):
             files = [path]
@@ -341,26 +137,20 @@ class Config(object):
             logger.error('config path %s is neither directory nor file', path)
             raise ConfigParseError('invalid config path')
 
-        overall_config: Dict[str, Any] = {}
+        overall_config = {}
         for fname in files:
             with open(fname) as f:
                 config = yaml.safe_load(f)
                 patch_config(overall_config, config)
         return overall_config
 
-    def _load_config_file(self) -> Dict[str, Any]:
-        """Load configuration file(s) from filesystem and apply values which were set via environment variables.
-
-        :returns: final configuration after merging configuration file(s) and environment variables.
-        """
-        if TYPE_CHECKING:  # pragma: no cover
-            assert self.config_file is not None
-        config = self._load_config_path(self.config_file)
+    def _load_config_file(self):
+        """Loads config.yaml from filesystem and applies some values which were set via ENV"""
+        config = self._load_config_path(self._config_file)
         patch_config(config, self.__environment_configuration)
         return config
 
-    def _load_cache(self) -> None:
-        """Load dynamic configuration from ``patroni.dynamic.json``."""
+    def _load_cache(self):
         if os.path.isfile(self._cache_file):
             try:
                 with open(self._cache_file) as f:
@@ -368,23 +158,15 @@ class Config(object):
             except Exception:
                 logger.exception('Exception when loading file: %s', self._cache_file)
 
-    def save_cache(self) -> None:
-        """Save dynamic configuration to ``patroni.dynamic.json`` under Postgres data directory.
-
-        .. note::
-            ``patroni.dynamic.jsonXXXXXX`` is created as a temporary file and than renamed to ``patroni.dynamic.json``,
-            where ``XXXXXX`` is a random suffix.
-        """
+    def save_cache(self):
         if self._cache_needs_saving:
             tmpfile = fd = None
             try:
-                pg_perm.set_permissions_from_data_directory(self._data_dir)
                 (fd, tmpfile) = tempfile.mkstemp(prefix=self.__CACHE_FILENAME, dir=self._data_dir)
                 with os.fdopen(fd, 'w') as f:
                     fd = None
                     json.dump(self.dynamic_configuration, f)
                 tmpfile = shutil.move(tmpfile, self._cache_file)
-                os.chmod(self._cache_file, pg_perm.file_create_mode)
                 self._cache_needs_saving = False
             except Exception:
                 logger.exception('Exception when saving file: %s', self._cache_file)
@@ -400,18 +182,11 @@ class Config(object):
                         logger.error('Can not remove temporary file %s', tmpfile)
 
     # configuration could be either ClusterConfig or dict
-    def set_dynamic_configuration(self, configuration: Union[ClusterConfig, Dict[str, Any]]) -> bool:
-        """Set dynamic configuration values with given *configuration*.
-
-        :param configuration: new dynamic configuration values. Supports :class:`dict` for backward compatibility.
-
-        :returns: ``True`` if changes have been detected between current dynamic configuration and the new dynamic
-            *configuration*, ``False`` otherwise.
-        """
+    def set_dynamic_configuration(self, configuration):
         if isinstance(configuration, ClusterConfig):
-            if self._modify_version == configuration.modify_version:
-                return False  # If the version didn't change there is nothing to do
-            self._modify_version = configuration.modify_version
+            if self._modify_index == configuration.modify_index:
+                return False  # If the index didn't changed there is nothing to do
+            self._modify_index = configuration.modify_index
             configuration = configuration.data
 
         if not deep_compare(self._dynamic_configuration, configuration):
@@ -423,17 +198,8 @@ class Config(object):
                 return True
             except Exception:
                 logger.exception('Exception when setting dynamic_configuration')
-        return False
 
-    def reload_local_configuration(self) -> Optional[bool]:
-        """Reload configuration values from the configuration file(s).
-
-        .. note::
-            Designed to be used when user applies changes to configuration file(s), so Patroni can use the new values
-            with a reload instead of a restart.
-
-        :returns: ``True`` if changes have been detected between current local configuration
-        """
+    def reload_local_configuration(self):
         if self.config_file:
             try:
                 configuration = self._load_config_file()
@@ -448,119 +214,37 @@ class Config(object):
                 logger.exception('Exception when reloading local configuration from %s', self.config_file)
 
     @staticmethod
-    def _process_postgresql_parameters(parameters: Dict[str, Any], is_local: bool = False) -> Dict[str, Any]:
-        """Process Postgres *parameters*.
+    def _process_postgresql_parameters(parameters, is_local=False):
+        return {name: value for name, value in (parameters or {}).items()
+                if name not in ConfigHandler.CMDLINE_OPTIONS or
+                not is_local and ConfigHandler.CMDLINE_OPTIONS[name][1](value)}
 
-        .. note::
-            If *is_local* configuration discard any setting from *parameters* that is listed under
-            :attr:`~patroni.postgresql.config.ConfigHandler.CMDLINE_OPTIONS` as those are supposed to be set only
-            through dynamic configuration.
-
-            When setting parameters from :attr:`~patroni.postgresql.config.ConfigHandler.CMDLINE_OPTIONS` through
-            dynamic configuration their value will be validated as per the validator defined in that very same
-            attribute entry. If the given value cannot be validated, a warning will be logged and the default value of
-            the GUC will be used instead.
-
-            Some parameters from :attr:`~patroni.postgresql.config.ConfigHandler.CMDLINE_OPTIONS` cannot be set even if
-            not *is_local* configuration:
-
-                * ``listen_addresses``: inferred from ``postgresql.listen`` local configuration or from
-                    ``PATRONI_POSTGRESQL_LISTEN`` environment variable;
-                * ``port``: inferred from ``postgresql.listen`` local configuration or from
-                    ``PATRONI_POSTGRESQL_LISTEN`` environment variable;
-                * ``cluster_name``: set through ``scope`` local configuration or through ``PATRONI_SCOPE`` environment
-                    variable;
-                * ``hot_standby``: always enabled;
-                * ``wal_log_hints``: always enabled.
-
-        :param parameters: Postgres parameters to be processed. Should be the parsed YAML value of
-            ``postgresql.parameters`` configuration, either from local or from dynamic configuration.
-
-        :param is_local: should be ``True`` if *parameters* refers to local configuration, or ``False`` if *parameters*
-            refers to dynamic configuration.
-
-        :returns: new value for ``postgresql.parameters`` after processing and validating *parameters*.
-        """
-        pg_params: Dict[str, Any] = {}
-
-        for name, value in (parameters or {}).items():
-            if name not in ConfigHandler.CMDLINE_OPTIONS:
-                pg_params[name] = value
-            elif not is_local:
-                if ConfigHandler.CMDLINE_OPTIONS[name][1](value):
-                    pg_params[name] = value
-                else:
-                    logger.warning("postgresql parameter %s=%s failed validation, defaulting to %s",
-                                   name, value, ConfigHandler.CMDLINE_OPTIONS[name][0])
-
-        return pg_params
-
-    def _safe_copy_dynamic_configuration(self, dynamic_configuration: Dict[str, Any]) -> Dict[str, Any]:
-        """Create a copy of *dynamic_configuration*.
-
-        Merge *dynamic_configuration* with :attr:`__DEFAULT_CONFIG` (*dynamic_configuration* takes precedence), and
-        process ``postgresql.parameters`` from *dynamic_configuration* through :func:`_process_postgresql_parameters`,
-        if present.
-
-        .. note::
-            The following settings are not allowed in ``postgresql`` section as they are intended to be local
-            configuration, and are removed if present:
-
-                * ``connect_address``;
-                * ``proxy_address``;
-                * ``listen``;
-                * ``config_dir``;
-                * ``data_dir``;
-                * ``pgpass``;
-                * ``authentication``;
-
-            Besides that any setting present in *dynamic_configuration* but absent from :attr:`__DEFAULT_CONFIG` is
-            discarded.
-
-        :param dynamic_configuration: Patroni dynamic configuration.
-
-        :returns: copy of *dynamic_configuration*, merged with default dynamic configuration and with some sanity checks
-            performed over it.
-        """
-        config = self.get_default_config()
+    def _safe_copy_dynamic_configuration(self, dynamic_configuration):
+        config = deepcopy(self.__DEFAULT_CONFIG)
 
         for name, value in dynamic_configuration.items():
             if name == 'postgresql':
                 for name, value in (value or {}).items():
                     if name == 'parameters':
                         config['postgresql'][name].update(self._process_postgresql_parameters(value))
-                    elif name not in ('connect_address', 'proxy_address', 'listen',
-                                      'config_dir', 'data_dir', 'pgpass', 'authentication'):
+                    elif name not in ('connect_address', 'listen', 'data_dir', 'pgpass', 'authentication'):
                         config['postgresql'][name] = deepcopy(value)
             elif name == 'standby_cluster':
                 for name, value in (value or {}).items():
                     if name in self.__DEFAULT_CONFIG['standby_cluster']:
                         config['standby_cluster'][name] = deepcopy(value)
             elif name in config:  # only variables present in __DEFAULT_CONFIG allowed to be overridden from DCS
-                config[name] = int(value)
+                if name in ('synchronous_mode', 'synchronous_mode_strict'):
+                    config[name] = value
+                else:
+                    config[name] = int(value)
         return config
 
     @staticmethod
-    def _build_environment_configuration() -> Dict[str, Any]:
-        """Get local configuration settings that were specified through environment variables.
+    def _build_environment_configuration():
+        ret = defaultdict(dict)
 
-        :returns: dictionary containing the found environment variables and their values, respecting the expected
-            structure of Patroni configuration.
-        """
-        ret: Dict[str, Any] = defaultdict(dict)
-
-        def _popenv(name: str) -> Optional[str]:
-            """Get value of environment variable *name*.
-
-            .. note::
-                *name* is prefixed with :data:`~patroni.PATRONI_ENV_PREFIX` when searching in the environment.
-
-                Also, the corresponding environment variable is removed from the environment upon reading its value.
-
-            :param name: name of the environment variable.
-
-            :returns: value of *name*, if present in the environment, otherwise ``None``.
-            """
+        def _popenv(name):
             return os.environ.pop(PATRONI_ENV_PREFIX + name.upper(), None)
 
         for param in ('name', 'namespace', 'scope'):
@@ -568,24 +252,7 @@ class Config(object):
             if value:
                 ret[param] = value
 
-        def _fix_log_env(name: str, oldname: str) -> None:
-            """Normalize a log related environment variable.
-
-            .. note::
-                Patroni used to support different names for log related environment variables in the past. As the
-                environment variables were renamed, this function takes care of mapping and normalizing the environment.
-
-                *name* is prefixed with :data:`~patroni.PATRONI_ENV_PREFIX` and ``LOG`` when searching in the
-                environment.
-
-                *oldname* is prefixed with :data:`~patroni.PATRONI_ENV_PREFIX` when searching in the environment.
-
-                If both *name* and *oldname* are set in the environment, *name* takes precedence.
-
-            :param name: new name of a log related environment variable.
-            :param oldname: original name of a log related environment variable.
-            :type oldname: str
-            """
+        def _fix_log_env(name, oldname):
             value = _popenv(oldname)
             name = PATRONI_ENV_PREFIX + 'LOG_' + name.upper()
             if value and name not in os.environ:
@@ -594,16 +261,7 @@ class Config(object):
         for name, oldname in (('level', 'loglevel'), ('format', 'logformat'), ('dateformat', 'log_datefmt')):
             _fix_log_env(name, oldname)
 
-        def _set_section_values(section: str, params: List[str]) -> None:
-            """Get value of *params* environment variables that are related with *section*.
-
-            .. note::
-                The values are retrieved from the environment and updated directly into the returning dictionary of
-                :func:`_build_environment_configuration`.
-
-            :param section: configuration section the *params* belong to.
-            :param params: name of the Patroni settings.
-            """
+        def _set_section_values(section, params):
             for param in params:
                 value = _popenv(section + '_' + param)
                 if value:
@@ -611,21 +269,13 @@ class Config(object):
 
         _set_section_values('restapi', ['listen', 'connect_address', 'certfile', 'keyfile', 'keyfile_password',
                                         'cafile', 'ciphers', 'verify_client', 'http_extra_headers',
-                                        'https_extra_headers', 'allowlist', 'allowlist_include_members',
-                                        'request_queue_size'])
+                                        'https_extra_headers', 'allowlist', 'allowlist_include_members'])
         _set_section_values('ctl', ['insecure', 'cacert', 'certfile', 'keyfile', 'keyfile_password'])
-        _set_section_values('postgresql', ['listen', 'connect_address', 'proxy_address',
-                                           'config_dir', 'data_dir', 'pgpass', 'bin_dir'])
+        _set_section_values('postgresql', ['listen', 'connect_address', 'config_dir', 'data_dir', 'pgpass', 'bin_dir'])
         _set_section_values('log', ['level', 'traceback_level', 'format', 'dateformat', 'max_queue_size',
                                     'dir', 'file_size', 'file_num', 'loggers'])
         _set_section_values('raft', ['data_dir', 'self_addr', 'partner_addrs', 'password', 'bind_addr'])
 
-        for binary in ('pg_ctl', 'initdb', 'pg_controldata', 'pg_basebackup', 'postgres', 'pg_isready', 'pg_rewind'):
-            value = _popenv('POSTGRESQL_BIN_' + binary)
-            if value:
-                ret['postgresql'].setdefault('bin_name', {})[binary] = value
-
-        # parse all values retrieved from the environment as Python objects, according to the expected type
         for first, second in (('restapi', 'allowlist_include_members'), ('ctl', 'insecure')):
             value = ret.get(first, {}).pop(second, None)
             if value:
@@ -633,22 +283,14 @@ class Config(object):
                 if value is not None:
                     ret[first][second] = value
 
-        for first, params in (('restapi', ('request_queue_size',)),
-                              ('log', ('max_queue_size', 'file_size', 'file_num'))):
-            for second in params:
-                value = ret.get(first, {}).pop(second, None)
-                if value:
-                    value = parse_int(value)
-                    if value is not None:
-                        ret[first][second] = value
+        for second in ('max_queue_size', 'file_size', 'file_num'):
+            value = ret.get('log', {}).pop(second, None)
+            if value:
+                value = parse_int(value)
+                if value is not None:
+                    ret['log'][second] = value
 
-        def _parse_list(value: str) -> Optional[List[str]]:
-            """Parse an YAML list *value* as a :class:`list`.
-
-            :param value: YAML list as a string.
-
-            :returns: *value* as :class:`list`.
-            """
+        def _parse_list(value):
             if not (value.strip().startswith('-') or '[' in value):
                 value = '[{0}]'.format(value)
             try:
@@ -664,13 +306,7 @@ class Config(object):
                 if value:
                     ret[first][second] = value
 
-        def _parse_dict(value: str) -> Optional[Dict[str, Any]]:
-            """Parse an YAML dictionary *value* as a :class:`dict`.
-
-            :param value: YAML dictionary as a string.
-
-            :returns: *value* as :class:`dict`.
-            """
+        def _parse_dict(value):
             if not value.strip().startswith('{'):
                 value = '{{{0}}}'.format(value)
             try:
@@ -687,25 +323,17 @@ class Config(object):
                     if value:
                         ret[first][second] = value
 
-        def _get_auth(name: str, params: Collection[str] = _AUTH_ALLOWED_PARAMETERS[:2]) -> Dict[str, str]:
-            """Get authorization related environment variables *params* from section *name*.
-
-            :param name: name of a configuration section that may contain authorization *params*.
-            :param params: the authorization settings that may be set under section *name*.
-
-            :returns: dictionary containing environment values for authorization *params* of section *name*.
-            """
-            ret: Dict[str, str] = {}
-            for param in params:
+        def _get_auth(name, params=None):
+            ret = {}
+            for param in params or _AUTH_ALLOWED_PARAMETERS[:2]:
                 value = _popenv(name + '_' + param)
                 if value:
                     ret[param] = value
             return ret
 
-        for section in ('ctl', 'restapi'):
-            auth = _get_auth(section)
-            if auth:
-                ret[section]['authentication'] = auth
+        restapi_auth = _get_auth('restapi')
+        if restapi_auth:
+            ret['restapi']['authentication'] = restapi_auth
 
         authentication = {}
         for user_type in ('replication', 'superuser', 'rewind'):
@@ -719,29 +347,22 @@ class Config(object):
         for param in list(os.environ.keys()):
             if param.startswith(PATRONI_ENV_PREFIX):
                 # PATRONI_(ETCD|CONSUL|ZOOKEEPER|EXHIBITOR|...)_(HOSTS?|PORT|..)
-                name, suffix = (param[len(PATRONI_ENV_PREFIX):].split('_', 1) + [''])[:2]
+                name, suffix = (param[8:].split('_', 1) + [''])[:2]
                 if suffix in ('HOST', 'HOSTS', 'PORT', 'USE_PROXIES', 'PROTOCOL', 'SRV', 'SRV_SUFFIX', 'URL', 'PROXY',
                               'CACERT', 'CERT', 'KEY', 'VERIFY', 'TOKEN', 'CHECKS', 'DC', 'CONSISTENCY',
                               'REGISTER_SERVICE', 'SERVICE_CHECK_INTERVAL', 'SERVICE_CHECK_TLS_SERVER_NAME',
-                              'SERVICE_TAGS', 'NAMESPACE', 'CONTEXT', 'USE_ENDPOINTS', 'SCOPE_LABEL', 'ROLE_LABEL',
-                              'POD_IP', 'PORTS', 'LABELS', 'BYPASS_API_SERVICE', 'RETRIABLE_HTTP_CODES', 'KEY_PASSWORD',
-                              'USE_SSL', 'SET_ACLS', 'GROUP', 'DATABASE', 'LEADER_LABEL_VALUE', 'FOLLOWER_LABEL_VALUE',
-                              'STANDBY_LEADER_LABEL_VALUE', 'TMP_ROLE_LABEL') and name:
+                              'NAMESPACE', 'CONTEXT', 'USE_ENDPOINTS', 'SCOPE_LABEL', 'ROLE_LABEL', 'POD_IP',
+                              'PORTS', 'LABELS', 'BYPASS_API_SERVICE', 'KEY_PASSWORD', 'USE_SSL', 'SET_ACLS') and name:
                     value = os.environ.pop(param)
-                    if name == 'CITUS':
-                        if suffix == 'GROUP':
-                            value = parse_int(value)
-                        elif suffix != 'DATABASE':
-                            continue
-                    elif suffix == 'PORT':
+                    if suffix == 'PORT':
                         value = value and parse_int(value)
-                    elif suffix in ('HOSTS', 'PORTS', 'CHECKS', 'SERVICE_TAGS', 'RETRIABLE_HTTP_CODES'):
+                    elif suffix in ('HOSTS', 'PORTS', 'CHECKS'):
                         value = value and _parse_list(value)
                     elif suffix in ('LABELS', 'SET_ACLS'):
                         value = _parse_dict(value)
                     elif suffix in ('USE_PROXIES', 'REGISTER_SERVICE', 'USE_ENDPOINTS', 'BYPASS_API_SERVICE', 'VERIFY'):
                         value = parse_bool(value)
-                    if value is not None:
+                    if value:
                         ret[name.lower()][suffix.lower()] = value
         for dcs in ('etcd', 'etcd3'):
             if dcs in ret:
@@ -750,14 +371,14 @@ class Config(object):
         users = {}
         for param in list(os.environ.keys()):
             if param.startswith(PATRONI_ENV_PREFIX):
-                name, suffix = (param[len(PATRONI_ENV_PREFIX):].rsplit('_', 1) + [''])[:2]
+                name, suffix = (param[8:].rsplit('_', 1) + [''])[:2]
                 # PATRONI_<username>_PASSWORD=<password>, PATRONI_<username>_OPTIONS=<option1,option2,...>
                 # CREATE USER "<username>" WITH <OPTIONS> PASSWORD '<password>'
                 if name and suffix == 'PASSWORD':
                     password = os.environ.pop(param)
                     if password:
                         users[name] = {'password': password}
-                        options = os.environ.pop(param[:-9] + '_OPTIONS', None)  # replace "_PASSWORD" with "_OPTIONS"
+                        options = os.environ.pop(param[:-9] + '_OPTIONS', None)
                         options = options and _parse_list(options)
                         if options:
                             users[name]['options'] = options
@@ -766,25 +387,10 @@ class Config(object):
 
         return ret
 
-    def _build_effective_configuration(self, dynamic_configuration: Dict[str, Any],
-                                       local_configuration: Dict[str, Union[Dict[str, Any], Any]]) -> Dict[str, Any]:
-        """Build effective configuration by merging *dynamic_configuration* and *local_configuration*.
-
-        .. note::
-            *local_configuration* takes precedence over *dynamic_configuration* if a setting is defined in both.
-
-        :param dynamic_configuration: Patroni dynamic configuration.
-        :param local_configuration: Patroni local configuration.
-
-        :returns: _description_
-        """
+    def _build_effective_configuration(self, dynamic_configuration, local_configuration):
         config = self._safe_copy_dynamic_configuration(dynamic_configuration)
         for name, value in local_configuration.items():
-            if name == 'citus':  # remove invalid citus configuration
-                if isinstance(value, dict) and isinstance(value.get('group'), int)\
-                        and isinstance(value.get('database'), str):
-                    config[name] = value
-            elif name == 'postgresql':
+            if name == 'postgresql':
                 for name, value in (value or {}).items():
                     if name == 'parameters':
                         config['postgresql'][name].update(self._process_postgresql_parameters(value, True))
@@ -793,10 +399,9 @@ class Config(object):
             elif name not in config or name in ['watchdog']:
                 config[name] = deepcopy(value) if value else {}
 
-        # restapi server expects to get restapi.auth = 'username:password' and similarly for `ctl`
-        for section in ('ctl', 'restapi'):
-            if section in config and 'authentication' in config[section]:
-                config[section]['auth'] = '{username}:{password}'.format(**config[section]['authentication'])
+        # restapi server expects to get restapi.auth = 'username:password'
+        if 'restapi' in config and 'authentication' in config['restapi']:
+            config['restapi']['auth'] = '{username}:{password}'.format(**config['restapi']['authentication'])
 
         # special treatment for old config
 
@@ -823,75 +428,28 @@ class Config(object):
         if 'name' not in config and 'name' in pg_config:
             config['name'] = pg_config['name']
 
-        # when bootstrapping the new Citus cluster (coordinator/worker) enable sync replication in global configuration
-        if 'citus' in config:
-            bootstrap = config.setdefault('bootstrap', {})
-            dcs = bootstrap.setdefault('dcs', {})
-            dcs.setdefault('synchronous_mode', True)
-
         updated_fields = (
             'name',
             'scope',
             'retry_timeout',
-            'citus'
+            'synchronous_mode',
+            'synchronous_mode_strict',
+            'synchronous_node_count',
+            'maximum_lag_on_syncnode'
         )
 
         pg_config.update({p: config[p] for p in updated_fields if p in config})
 
         return config
 
-    def get(self, key: str, default: Optional[Any] = None) -> Any:
-        """Get effective value of ``key`` setting from Patroni configuration root.
-
-        Designed to work the same way as :func:`dict.get`.
-
-        :param key: name of the setting.
-        :param default: default value if *key* is not present in the effective configuration.
-
-        :returns: value of *key*, if present in the effective configuration, otherwise *default*.
-        """
+    def get(self, key, default=None):
         return self.__effective_configuration.get(key, default)
 
-    def __contains__(self, key: str) -> bool:
-        """Check if setting *key* is present in the effective configuration.
-
-        Designed to work the same way as :func:`dict.__contains__`.
-
-        :param key: name of the setting to be checked.
-
-        :returns: ``True`` if setting *key* exists in effective configuration, else ``False``.
-        """
+    def __contains__(self, key):
         return key in self.__effective_configuration
 
-    def __getitem__(self, key: str) -> Any:
-        """Get value of setting *key* from effective configuration.
-
-        Designed to work the same way as :func:`dict.__getitem__`.
-
-        :param key: name of the setting.
-
-        :returns: value of setting *key*.
-
-        :raises:
-            :class:`KeyError`: if *key* is not present in effective configuration.
-        """
+    def __getitem__(self, key):
         return self.__effective_configuration[key]
 
-    def copy(self) -> Dict[str, Any]:
-        """Get a deep copy of effective Patroni configuration.
-
-        :returns: a deep copy of the Patroni configuration.
-        """
+    def copy(self):
         return deepcopy(self.__effective_configuration)
-
-    def get_global_config(self, cluster: Optional[Cluster]) -> GlobalConfig:
-        """Instantiate :class:`GlobalConfig` based on input.
-
-        Use the configuration from provided *cluster* (the most up-to-date) or from the
-        local cache if *cluster.config* is not initialized or doesn't have a valid config.
-
-        :param cluster: the currently known cluster state from DCS.
-
-        :returns: :class:`GlobalConfig` object.
-        """
-        return get_global_config(cluster, self._dynamic_configuration)

patroni/config_generator.py

@@ -1,463 +0,0 @@
-"""patroni ``--generate-config`` machinery."""
-import abc
-import logging
-import os
-import psutil
-import socket
-import sys
-import yaml
-
-from getpass import getuser, getpass
-from contextlib import contextmanager
-from typing import Any, Dict, Iterator, List, Optional, Tuple, TYPE_CHECKING, Union
-if TYPE_CHECKING:  # pragma: no cover
-    from psycopg import Cursor
-    from psycopg2 import cursor
-
-from . import psycopg
-from .config import Config
-from .exceptions import PatroniException
-from .postgresql.config import ConfigHandler, parse_dsn
-from .postgresql.misc import postgres_major_version_to_int
-from .utils import get_major_version, parse_bool, patch_config, read_stripped
-
-
-# Mapping between the libpq connection parameters and the environment variables.
-# This dict should be kept in sync with `patroni.utils._AUTH_ALLOWED_PARAMETERS`
-# (we use "username" in the Patroni config for some reason, other parameter names are the same).
-_AUTH_ALLOWED_PARAMETERS_MAPPING = {
-    'user': 'PGUSER',
-    'password': 'PGPASSWORD',
-    'sslmode': 'PGSSLMODE',
-    'sslcert': 'PGSSLCERT',
-    'sslkey': 'PGSSLKEY',
-    'sslpassword': '',
-    'sslrootcert': 'PGSSLROOTCERT',
-    'sslcrl': 'PGSSLCRL',
-    'sslcrldir': 'PGSSLCRLDIR',
-    'gssencmode': 'PGGSSENCMODE',
-    'channel_binding': 'PGCHANNELBINDING'
-}
-_NO_VALUE_MSG = '#FIXME'
-
-
-def get_address() -> Tuple[str, str]:
-    """Try to get hostname and the ip address for it returned by :func:`~socket.gethostname`.
-
-    .. note::
-        Can also return local ip.
-
-    :returns: tuple consisting of the hostname returned by :func:`~socket.gethostname`
-        and the first element in the sorted list of the addresses returned by :func:`~socket.getaddrinfo`.
-        Sorting guarantees it will prefer IPv4.
-        If an exception occured, hostname and ip values are equal to :data:`~patroni.config_generator._NO_VALUE_MSG`.
-    """
-    hostname = None
-    try:
-        hostname = socket.gethostname()
-        return hostname, sorted(socket.getaddrinfo(hostname, 0, socket.AF_UNSPEC, socket.SOCK_STREAM, 0),
-                                key=lambda x: x[0])[0][4][0]
-    except Exception as err:
-        logging.warning('Failed to obtain address: %r', err)
-        return _NO_VALUE_MSG, _NO_VALUE_MSG
-
-
-class AbstractConfigGenerator(abc.ABC):
-    """Object representing the generated Patroni config.
-
-    :ivar output_file: full path to the output file to be used.
-    :ivar pg_major: integer representation of the major PostgreSQL version.
-    :ivar config: dictionary used for the generated configuration storage.
-    """
-
-    _HOSTNAME, _IP = get_address()
-
-    def __init__(self, output_file: Optional[str]) -> None:
-        """Set up the output file (if passed), helper vars and the minimal config structure.
-
-        :param output_file: full path to the output file to be used.
-        """
-        self.output_file = output_file
-        self.pg_major = 0
-        self.config = self.get_template_config()
-
-        self.generate()
-
-    @classmethod
-    def get_template_config(cls) -> Dict[str, Any]:
-        """Generate a template config for further extension (e.g. in the inherited classes).
-
-        :returns: dictionary with the values gathered from Patroni env, hopefully defined hostname and ip address
-                  (otherwise set to :data:`~patroni.config_generator._NO_VALUE_MSG`), and some sane defaults.
-        """
-        template_config: Dict[str, Any] = {
-            'scope': _NO_VALUE_MSG,
-            'name': cls._HOSTNAME,
-            'postgresql': {
-                'data_dir': _NO_VALUE_MSG,
-                'connect_address': _NO_VALUE_MSG + ':5432',
-                'listen': _NO_VALUE_MSG + ':5432',
-                'bin_dir': '',
-                'authentication': {
-                    'superuser': {
-                        'username': 'postgres',
-                        'password': _NO_VALUE_MSG
-                    },
-                    'replication': {
-                        'username': 'replicator',
-                        'password': _NO_VALUE_MSG
-                    }
-                }
-            },
-            'restapi': {
-                'connect_address': cls._IP + ':8008',
-                'listen': cls._IP + ':8008'
-            }
-        }
-
-        dynamic_config = Config.get_default_config()
-        # to properly dump CaseInsensitiveDict as YAML later
-        dynamic_config['postgresql']['parameters'] = dict(dynamic_config['postgresql']['parameters'])
-        config = Config('', None).local_configuration  # Get values from env
-        config.setdefault('bootstrap', {})['dcs'] = dynamic_config
-        config.setdefault('postgresql', {})
-        del config['bootstrap']['dcs']['standby_cluster']
-
-        patch_config(template_config, config)
-        return template_config
-
-    @abc.abstractmethod
-    def generate(self) -> None:
-        """Generate config and store in :attr:`~AbstractConfigGenerator.config`."""
-
-    def write_config(self) -> None:
-        """Write current :attr:`~AbstractConfigGenerator.config` to the output file if provided, to stdout otherwise."""
-        if self.output_file:
-            dir_path = os.path.dirname(self.output_file)
-            if dir_path and not os.path.isdir(dir_path):
-                os.makedirs(dir_path)
-            with open(self.output_file, 'w', encoding='UTF-8') as output_file:
-                yaml.safe_dump(self.config, output_file, default_flow_style=False, allow_unicode=True)
-        else:
-            yaml.safe_dump(self.config, sys.stdout, default_flow_style=False, allow_unicode=True)
-
-
-class SampleConfigGenerator(AbstractConfigGenerator):
-    """Object representing the generated sample Patroni config.
-
-    Sane defults are used based on the gathered PG version.
-    """
-
-    @property
-    def get_auth_method(self) -> str:
-        """Return the preferred authentication method for a specific PG version if provided or the default ``md5``.
-
-        :returns: :class:`str` value for the preferred authentication method.
-        """
-        return 'scram-sha-256' if self.pg_major and self.pg_major >= 100000 else 'md5'
-
-    def _get_int_major_version(self) -> int:
-        """Get major PostgreSQL version from the binary as an integer.
-
-        :returns: an integer PostgreSQL major version representation gathered from the PostgreSQL binary.
-                  See :func:`~patroni.postgresql.misc.postgres_major_version_to_int` and
-                  :func:`~patroni.utils.get_major_version`.
-        """
-        postgres_bin = ((self.config.get('postgresql') or {}).get('bin_name') or {}).get('postgres', 'postgres')
-        return postgres_major_version_to_int(get_major_version(self.config['postgresql'].get('bin_dir'), postgres_bin))
-
-    def generate(self) -> None:
-        """Generate sample config using some sane defaults and update :attr:`~AbstractConfigGenerator.config`."""
-        self.pg_major = self._get_int_major_version()
-
-        self.config['postgresql']['parameters'] = {'password_encryption': self.get_auth_method}
-        username = self.config["postgresql"]["authentication"]["replication"]["username"]
-        self.config['postgresql']['pg_hba'] = [
-            f'host all all all {self.get_auth_method}',
-            f'host replication {username} all {self.get_auth_method}'
-        ]
-
-        # add version-specific configuration
-        wal_keep_param = 'wal_keep_segments' if self.pg_major < 130000 else 'wal_keep_size'
-        self.config['bootstrap']['dcs']['postgresql']['parameters'][wal_keep_param] = \
-            ConfigHandler.CMDLINE_OPTIONS[wal_keep_param][0]
-
-        self.config['bootstrap']['dcs']['postgresql']['use_pg_rewind'] = True
-        if self.pg_major >= 110000:
-            self.config['postgresql']['authentication'].setdefault(
-                'rewind', {'username': 'rewind_user'}).setdefault('password', _NO_VALUE_MSG)
-
-
-class RunningClusterConfigGenerator(AbstractConfigGenerator):
-    """Object representing the Patroni config generated using information gathered from the running instance.
-
-    :ivar dsn: DSN string for the local instance to get GUC values from (if provided).
-    :ivar parsed_dsn: DSN string parsed into a dictionary (see :func:`~patroni.postgresql.config.parse_dsn`).
-    """
-
-    def __init__(self, output_file: Optional[str] = None, dsn: Optional[str] = None) -> None:
-        """Additionally store the passed dsn (if any) in both original and parsed version and run config generation.
-
-        :param output_file: full path to the output file to be used.
-        :param dsn: DSN string for the local instance to get GUC values from.
-
-        :raises:
-            :exc:`~patroni.exceptions.PatroniException`: if DSN parsing failed.
-        """
-        self.dsn = dsn
-        self.parsed_dsn = {}
-
-        super().__init__(output_file)
-
-    @property
-    def _get_hba_conn_types(self) -> Tuple[str, ...]:
-        """Return the connection types allowed.
-
-        If :attr:`~RunningClusterConfigGenerator.pg_major` is defined, adds additional parameters
-        for PostgreSQL version >=16.
-
-        :returns: tuple of the connection methods allowed.
-        """
-        allowed_types = ('local', 'host', 'hostssl', 'hostnossl', 'hostgssenc', 'hostnogssenc')
-        if self.pg_major and self.pg_major >= 160000:
-            allowed_types += ('include', 'include_if_exists', 'include_dir')
-        return allowed_types
-
-    @property
-    def _required_pg_params(self) -> List[str]:
-        """PG configuration prameters that have to be always present in the generated config.
-
-        :returns: list of the parameter names.
-        """
-        return ['hba_file', 'ident_file', 'config_file', 'data_directory'] + \
-            list(ConfigHandler.CMDLINE_OPTIONS.keys())
-
-    def _get_bin_dir_from_running_instance(self) -> str:
-        """Define the directory postgres binaries reside using postmaster's pid executable.
-
-        :returns: path to the PostgreSQL binaries directory.
-
-        :raises:
-            :exc:`~patroni.exceptions.PatroniException`: if:
-
-                * pid could not be obtained from the ``postmaster.pid`` file; or
-                * :exc:`OSError` occured during ``postmaster.pid`` file handling; or
-                * the obtained postmaster pid doesn't exist.
-        """
-        postmaster_pid = None
-        data_dir = self.config['postgresql']['data_dir']
-        try:
-            with open(f"{data_dir}/postmaster.pid", 'r') as pid_file:
-                postmaster_pid = pid_file.readline()
-                if not postmaster_pid:
-                    raise PatroniException('Failed to obtain postmaster pid from postmaster.pid file')
-                postmaster_pid = int(postmaster_pid.strip())
-        except OSError as err:
-            raise PatroniException(f'Error while reading postmaster.pid file: {err}')
-        try:
-            return os.path.dirname(psutil.Process(postmaster_pid).exe())
-        except psutil.NoSuchProcess:
-            raise PatroniException("Obtained postmaster pid doesn't exist.")
-
-    @contextmanager
-    def _get_connection_cursor(self) -> Iterator[Union['cursor', 'Cursor[Any]']]:
-        """Get cursor for the PG connection established based on the stored information.
-
-        :raises:
-            :exc:`~patroni.exceptions.PatroniException`: if :exc:`psycopg.Error` occured.
-        """
-        try:
-            conn = psycopg.connect(dsn=self.dsn,
-                                   password=self.config['postgresql']['authentication']['superuser']['password'])
-            with conn.cursor() as cur:
-                yield cur
-            conn.close()
-        except psycopg.Error as e:
-            raise PatroniException(f'Failed to establish PostgreSQL connection: {e}')
-
-    def _set_pg_params(self, cur: Union['cursor', 'Cursor[Any]']) -> None:
-        """Extend :attr:`~RunningClusterConfigGenerator.config` with the actual PG GUCs values.
-
-        THe following GUC values are set:
-
-            * Non-internal having configuration file, postmaster command line or environment variable
-              as a source.
-
-            * List of the always required parameters (see :meth:`~RunningClusterConfigGenerator._required_pg_params`).
-
-        :param cur: connection cursor to use.
-        """
-        cur.execute("SELECT name, current_setting(name) FROM pg_settings "
-                    "WHERE context <> 'internal' "
-                    "AND source IN ('configuration file', 'command line', 'environment variable') "
-                    "AND category <> 'Write-Ahead Log / Recovery Target' "
-                    "AND setting <> '(disabled)' "
-                    "OR name = ANY(%s)", (self._required_pg_params,))
-
-        helper_dict = dict.fromkeys(['port', 'listen_addresses'])
-        self.config['postgresql'].setdefault('parameters', {})
-        for param, value in cur.fetchall():
-            if param == 'data_directory':
-                self.config['postgresql']['data_dir'] = value
-            elif param == 'cluster_name' and value:
-                self.config['scope'] = value
-            elif param in ('archive_command', 'restore_command',
-                           'archive_cleanup_command', 'recovery_end_command',
-                           'ssl_passphrase_command', 'hba_file',
-                           'ident_file', 'config_file'):
-                # write commands to the local config due to security implications
-                # write hba/ident/config_file to local config to ensure they are not removed later
-                self.config['postgresql']['parameters'][param] = value
-            elif param in helper_dict:
-                helper_dict[param] = value
-            else:
-                self.config['bootstrap']['dcs']['postgresql']['parameters'][param] = value
-
-        connect_port = self.parsed_dsn.get('port', os.getenv('PGPORT', helper_dict['port']))
-        self.config['postgresql']['connect_address'] = f'{self._IP}:{connect_port}'
-        self.config['postgresql']['listen'] = f'{helper_dict["listen_addresses"]}:{helper_dict["port"]}'
-
-    def _set_su_params(self) -> None:
-        """Extend :attr:`~RunningClusterConfigGenerator.config` with the superuser auth information.
-
-        Information set is based on the options used for connection.
-        """
-        su_params: Dict[str, str] = {}
-        for conn_param, env_var in _AUTH_ALLOWED_PARAMETERS_MAPPING.items():
-            val = self.parsed_dsn.get(conn_param, os.getenv(env_var))
-            if val:
-                su_params[conn_param] = val
-        patroni_env_su_username = ((self.config.get('authentication') or {}).get('superuser') or {}).get('username')
-        patroni_env_su_pwd = ((self.config.get('authentication') or {}).get('superuser') or {}).get('password')
-        # because we use "username" in the config for some reason
-        su_params['username'] = su_params.pop('user', patroni_env_su_username) or getuser()
-        su_params['password'] = su_params.get('password', patroni_env_su_pwd) or \
-            getpass('Please enter the user password:')
-        self.config['postgresql']['authentication'] = {
-            'superuser': su_params,
-            'replication': {'username': _NO_VALUE_MSG, 'password': _NO_VALUE_MSG}
-        }
-
-    def _set_conf_files(self) -> None:
-        """Extend :attr:`~RunningClusterConfigGenerator.config` with ``pg_hba.conf`` and ``pg_ident.conf`` content.
-
-        .. note::
-            This function only defines ``postgresql.pg_hba`` and ``postgresql.pg_ident`` when
-            ``hba_file`` and ``ident_file`` are set to the defaults. It may happen these files
-            are located outside of ``PGDATA`` and Patroni doesn't have write permissions for them.
-
-        :raises:
-            :exc:`~patroni.exceptions.PatroniException`: if :exc:`OSError` occured during the conf files handling.
-        """
-        default_hba_path = os.path.join(self.config['postgresql']['data_dir'], 'pg_hba.conf')
-        if self.config['postgresql']['parameters']['hba_file'] == default_hba_path:
-            try:
-                self.config['postgresql']['pg_hba'] = list(
-                    filter(lambda i: i and i.split()[0] in self._get_hba_conn_types, read_stripped(default_hba_path)))
-            except OSError as err:
-                raise PatroniException(f'Failed to read pg_hba.conf: {err}')
-
-        default_ident_path = os.path.join(self.config['postgresql']['data_dir'], 'pg_ident.conf')
-        if self.config['postgresql']['parameters']['ident_file'] == default_ident_path:
-            try:
-                self.config['postgresql']['pg_ident'] = [i for i in read_stripped(default_ident_path)
-                                                         if i and not i.startswith('#')]
-            except OSError as err:
-                raise PatroniException(f'Failed to read pg_ident.conf: {err}')
-            if not self.config['postgresql']['pg_ident']:
-                del self.config['postgresql']['pg_ident']
-
-    def _enrich_config_from_running_instance(self) -> None:
-        """Extend :attr:`~RunningClusterConfigGenerator.config` with the values gathered from the running instance.
-
-        Retrieve the following information from the running PostgreSQL instance:
-
-        * superuser auth parameters (see :meth:`~RunningClusterConfigGenerator._set_su_params`);
-        * some GUC values (see :meth:`~RunningClusterConfigGenerator._set_pg_params`);
-        * ``postgresql.connect_address``, ``postgresql.listen``;
-        * ``postgresql.pg_hba`` and ``postgresql.pg_ident`` (see :meth:`~RunningClusterConfigGenerator._set_conf_files`)
-
-        And redefine ``scope`` with the ``cluster_name`` GUC value if set.
-
-        :raises:
-            :exc:`~patroni.exceptions.PatroniException`: if the provided user doesn't have superuser privileges.
-        """
-        self._set_su_params()
-
-        with self._get_connection_cursor() as cur:
-            self.pg_major = getattr(cur.connection, 'server_version', 0)
-
-            if not parse_bool(cur.connection.info.parameter_status('is_superuser')):
-                raise PatroniException('The provided user does not have superuser privilege')
-
-            self._set_pg_params(cur)
-
-        self._set_conf_files()
-
-    def generate(self) -> None:
-        """Generate config using the info gathered from the specified running PG instance.
-
-        Result is written to :attr:`~RunningClusterConfigGenerator.config`.
-        """
-        if self.dsn:
-            self.parsed_dsn = parse_dsn(self.dsn) or {}
-            if not self.parsed_dsn:
-                raise PatroniException('Failed to parse DSN string')
-
-        self._enrich_config_from_running_instance()
-        self.config['postgresql']['bin_dir'] = self._get_bin_dir_from_running_instance()
-
-
-def generate_config(output_file: str, sample: bool, dsn: Optional[str]) -> None:
-    """Generate Patroni configuration file.
-
-    Gather all the available non-internal GUC values having configuration file, postmaster command line or environment
-    variable as a source and store them in the appropriate part of Patroni configuration (``postgresql.parameters`` or
-    ``bootstrap.dcs.postgresql.parameters``). Either the provided DSN (takes precedence) or PG ENV vars will be used
-    for the connection. If password is not provided, it should be entered via prompt.
-
-    The created configuration contains:
-    * ``scope``: ``cluster_name`` GUC value or ``PATRONI_SCOPE ENV`` variable value if available.
-    * ``name``: ``PATRONI_NAME`` ENV variable value if set, otherwise hostname.
-
-    * ``bootstrap.dcs``: section with all the parameters (incl. the majority of PG GUCs) set to their default values
-      defined by Patroni and adjusted by the source instances's configuration values.
-
-    * ``postgresql.parameters``: the source instance's ``archive_command``, ``restore_command``,
-      ``archive_cleanup_command``, ``recovery_end_command``, ``ssl_passphrase_command``, ``hba_file``, ``ident_file``,
-      ``config_file`` GUC values.
-
-    * ``postgresql.bin_dir``: path to Postgres binaries gathered from the running instance or, if not available,
-      the value of ``PATRONI_POSTGRESQL_BIN_DIR`` ENV variable. Otherwise, an empty string.
-
-    * ``postgresql.datadir``: the value gathered from the corresponding PG GUC.
-    * ``postgresql.listen``: source instance's ``listen_addresses`` and port GUC values.
-    * ``postgresql.connect_address``: if possible, generated from the connection params.
-    * ``postgresql.authentication``:
-
-        * superuser and replication users defined (if possible, usernames are set from the respective Patroni ENV vars,
-          otherwise the default ``postgres`` and ``replicator`` values are used).
-          If not a sample config, either DSN or PG ENV vars are used to define superuser authentication parameters.
-
-        * rewind user is defined only for sample config, if PG version can be defined and PG version is >=11
-          (if possible, username is set from the respective Patroni ENV var).
-
-    * ``bootstrap.dcs.postgresql.use_pg_rewind`` set to ``True`` for a sample config only.
-    * ``postgresql.pg_hba`` defaults or the lines gathered from the source instance's ``hba_file``.
-    * ``postgresql.pg_ident`` the lines gathered from the source instance's ``ident_file``.
-
-    :param output_file: Full path to the configuration file to be used. If not provided, result is sent to ``stdout``.
-    :param sample: Optional flag. If set, no source instance will be used - generate config with some sane defaults.
-    :param dsn: Optional DSN string for the local instance to get GUC values from.
-    """
-    try:
-        if sample:
-            config_generator = SampleConfigGenerator(output_file)
-        else:
-            config_generator = RunningClusterConfigGenerator(output_file, dsn)
-
-        config_generator.write_config()
-    except PatroniException as e:
-        sys.exit(str(e))
-    except Exception as e:
-        sys.exit(f'Unexpected exception: {e}')

patroni/daemon.py

@@ -1,57 +1,16 @@
-"""Daemon processes abstraction module.
-
-This module implements abstraction classes and functions for creating and managing daemon processes in Patroni.
-Currently it is only used for the main "Thread" of ``patroni`` and ``patroni_raft_controller`` commands.
-"""
-from __future__ import print_function
-
 import abc
-import argparse
 import os
 import signal
+import six
 import sys
 
 from threading import Lock
-from typing import Any, Optional, Type, TYPE_CHECKING
-
-if TYPE_CHECKING:  # pragma: no cover
-    from .config import Config
 
 
-def get_base_arg_parser() -> argparse.ArgumentParser:
-    """Create a basic argument parser with the arguments used for both patroni and raft controller daemon.
+@six.add_metaclass(abc.ABCMeta)
+class AbstractPatroniDaemon(object):
 
-    :returns: 'argparse.ArgumentParser' object
-    """
-    from .config import Config
-    from .version import __version__
-
-    parser = argparse.ArgumentParser()
-    parser.add_argument('--version', action='version', version='%(prog)s {0}'.format(__version__))
-    parser.add_argument('configfile', nargs='?', default='',
-                        help='Patroni may also read the configuration from the {0} environment variable'
-                        .format(Config.PATRONI_CONFIG_VARIABLE))
-    return parser
-
-
-class AbstractPatroniDaemon(abc.ABC):
-    """A Patroni daemon process.
-
-    .. note::
-
-        When inheriting from :class:`AbstractPatroniDaemon` you are expected to define the methods :func:`_run_cycle`
-        to determine what it should do in each execution cycle, and :func:`_shutdown` to determine what it should do
-        when shutting down.
-
-    :ivar logger: log handler used by this daemon.
-    :ivar config: configuration options for this daemon.
-    """
-
-    def __init__(self, config: 'Config') -> None:
-        """Set up signal handlers, logging handler and configuration.
-
-        :param config: configuration options for this daemon.
-        """
+    def __init__(self, config):
         from patroni.log import PatroniLogger
 
         self.setup_signal_handlers()
@@ -60,44 +19,16 @@ class AbstractPatroniDaemon(abc.ABC):
         self.config = config
         AbstractPatroniDaemon.reload_config(self, local=True)
 
-    def sighup_handler(self, *_: Any) -> None:
-        """Handle SIGHUP signals.
-
-        Flag the daemon as "SIGHUP received".
-        """
+    def sighup_handler(self, *args):
         self._received_sighup = True
 
-    def api_sigterm(self) -> bool:
-        """Guarantee only a single SIGTERM is being processed.
-
-        Flag the daemon as "SIGTERM received" with a lock-based approach.
-
-        :returns: ``True`` if the daemon was flagged as "SIGTERM received".
-        """
-        ret = False
+    def sigterm_handler(self, *args):
         with self._sigterm_lock:
             if not self._received_sigterm:
                 self._received_sigterm = True
-                ret = True
-        return ret
+                sys.exit()
 
-    def sigterm_handler(self, *_: Any) -> None:
-        """Handle SIGTERM signals.
-
-        Terminate the daemon process through :func:`api_sigterm`.
-        """
-        if self.api_sigterm():
-            sys.exit()
-
-    def setup_signal_handlers(self) -> None:
-        """Set up daemon signal handlers.
-
-        Set up SIGHUP and SIGTERM signal handlers.
-
-        .. note::
-
-            SIGHUP is only handled in non-Windows environments.
-        """
+    def setup_signal_handlers(self):
         self._received_sighup = False
         self._sigterm_lock = Lock()
         self._received_sigterm = False
@@ -106,34 +37,19 @@ class AbstractPatroniDaemon(abc.ABC):
         signal.signal(signal.SIGTERM, self.sigterm_handler)
 
     @property
-    def received_sigterm(self) -> bool:
-        """If daemon was signaled with SIGTERM."""
+    def received_sigterm(self):
         with self._sigterm_lock:
             return self._received_sigterm
 
-    def reload_config(self, sighup: bool = False, local: Optional[bool] = False) -> None:
-        """Reload configuration.
-
-        :param sighup: if it is related to a SIGHUP signal.
-                       The sighup parameter could be used in the method overridden in a child class.
-        :param local: will be ``True`` if there are changes in the local configuration file.
-        """
+    def reload_config(self, sighup=False, local=False):
         if local:
             self.logger.reload_config(self.config.get('log', {}))
 
     @abc.abstractmethod
-    def _run_cycle(self) -> None:
-        """Define what the daemon should do in each execution cycle.
+    def _run_cycle(self):
+        """_run_cycle"""
 
-        Keep being called in the daemon's main loop until the daemon is eventually terminated.
-        """
-
-    def run(self) -> None:
-        """Run the daemon process.
-
-        Start the logger thread and keep running execution cycles until a SIGTERM is eventually received. Also reload
-        configuration uppon receiving SIGHUP.
-        """
+    def run(self):
         self.logger.start()
         while not self.received_sigterm:
             if self._received_sighup:
@@ -143,31 +59,41 @@ class AbstractPatroniDaemon(abc.ABC):
             self._run_cycle()
 
     @abc.abstractmethod
-    def _shutdown(self) -> None:
-        """Define what the daemon should do when shutting down."""
+    def _shutdown(self):
+        """_shutdown"""
 
-    def shutdown(self) -> None:
-        """Shut the daemon down when a SIGTERM is received.
-
-        Shut down the daemon process and the logger thread.
-        """
+    def shutdown(self):
         with self._sigterm_lock:
             self._received_sigterm = True
         self._shutdown()
         self.logger.shutdown()
 
 
-def abstract_main(cls: Type[AbstractPatroniDaemon], configfile: str) -> None:
-    """Create the main entry point of a given daemon process.
+def abstract_main(cls, validator=None):
+    import argparse
 
-    :param cls: a class that should inherit from :class:`AbstractPatroniDaemon`.
-    :param configfile:
-    """
     from .config import Config, ConfigParseError
+    from .version import __version__
+
+    parser = argparse.ArgumentParser()
+    parser.add_argument('--version', action='version', version='%(prog)s {0}'.format(__version__))
+    if validator:
+        parser.add_argument('--validate-config', action='store_true', help='Run config validator and exit')
+    parser.add_argument('configfile', nargs='?', default='',
+                        help='Patroni may also read the configuration from the {0} environment variable'
+                        .format(Config.PATRONI_CONFIG_VARIABLE))
+    args = parser.parse_args()
     try:
-        config = Config(configfile)
+        if validator and args.validate_config:
+            Config(args.configfile, validator=validator)
+            sys.exit()
+
+        config = Config(args.configfile)
     except ConfigParseError as e:
-        sys.exit(e.value)
+        if e.value:
+            print(e.value)
+        parser.print_help()
+        sys.exit(1)
 
     controller = cls(config)
     try:

patroni/dcs/consul.py

@@ -8,19 +8,15 @@ import ssl
 import time
 import urllib3
 
-from collections import defaultdict
+from collections import namedtuple
 from consul import ConsulException, NotFound, base
-from http.client import HTTPException
 from urllib3.exceptions import HTTPError
-from urllib.parse import urlencode, urlparse, quote
-from typing import Any, Callable, Dict, List, Mapping, NamedTuple, Optional, Union, Tuple, TYPE_CHECKING
+from six.moves.urllib.parse import urlencode, urlparse, quote
+from six.moves.http_client import HTTPException
 
-from . import AbstractDCS, Cluster, ClusterConfig, Failover, Leader, Member, SyncState, \
-    TimelineHistory, ReturnFalseException, catch_return_false_exception, citus_group_re
+from . import AbstractDCS, Cluster, ClusterConfig, Failover, Leader, Member, SyncState, TimelineHistory
 from ..exceptions import DCSError
 from ..utils import deep_compare, parse_bool, Retry, RetryFailedError, split_host_port, uri, USER_AGENT
-if TYPE_CHECKING:  # pragma: no cover
-    from ..config import Config
 
 logger = logging.getLogger(__name__)
 
@@ -41,17 +37,12 @@ class InvalidSession(ConsulException):
     """invalid session"""
 
 
-class Response(NamedTuple):
-    code: int
-    headers: Union[Mapping[str, str], Mapping[bytes, bytes], None]
-    body: str
-    content: bytes
+Response = namedtuple('Response', 'code,headers,body,content')
 
 
 class HTTPClient(object):
 
-    def __init__(self, host: str = '127.0.0.1', port: int = 8500, token: Optional[str] = None, scheme: str = 'http',
-                 verify: bool = True, cert: Optional[str] = None, ca_cert: Optional[str] = None) -> None:
+    def __init__(self, host='127.0.0.1', port=8500, token=None, scheme='http', verify=True, cert=None, ca_cert=None):
         self.token = token
         self._read_timeout = 10
         self.base_uri = uri(scheme, (host, port))
@@ -67,23 +58,23 @@ class HTTPClient(object):
         if ca_cert:
             kwargs['ca_certs'] = ca_cert
         kwargs['cert_reqs'] = ssl.CERT_REQUIRED if verify or ca_cert else ssl.CERT_NONE
-        self.http = urllib3.PoolManager(num_pools=10, maxsize=10, headers={}, **kwargs)
-        self._ttl = 30
+        self.http = urllib3.PoolManager(num_pools=10, maxsize=10, **kwargs)
+        self._ttl = None
 
-    def set_read_timeout(self, timeout: float) -> None:
-        self._read_timeout = timeout / 3.0
+    def set_read_timeout(self, timeout):
+        self._read_timeout = timeout/3.0
 
     @property
-    def ttl(self) -> int:
+    def ttl(self):
         return self._ttl
 
-    def set_ttl(self, ttl: int) -> bool:
+    def set_ttl(self, ttl):
         ret = self._ttl != ttl
         self._ttl = ttl
         return ret
 
     @staticmethod
-    def response(response: urllib3.response.HTTPResponse) -> Response:
+    def response(response):
         content = response.data
         body = content.decode('utf-8')
         if response.status == 500:
@@ -96,19 +87,14 @@ class HTTPClient(object):
                 raise ConsulInternalError(msg)
         return Response(response.status, response.headers, body, content)
 
-    def uri(self, path: str,
-            params: Union[None, Dict[str, Any], List[Tuple[str, Any]], Tuple[Tuple[str, Any], ...]] = None) -> str:
+    def uri(self, path, params=None):
         return '{0}{1}{2}'.format(self.base_uri, path, params and '?' + urlencode(params) or '')
 
-    def __getattr__(self, method: str) -> Callable[[Callable[[Response], Union[bool, Any, Tuple[str, Any]]],
-                                                    str, Union[None, Dict[str, Any], List[Tuple[str, Any]]],
-                                                    str, Optional[Dict[str, str]]], Union[bool, Any, Tuple[str, Any]]]:
+    def __getattr__(self, method):
         if method not in ('get', 'post', 'put', 'delete'):
             raise AttributeError("HTTPClient instance has no attribute '{0}'".format(method))
 
-        def wrapper(callback: Callable[[Response], Union[bool, Any, Tuple[str, Any]]], path: str,
-                    params: Union[None, Dict[str, Any], List[Tuple[str, Any]]] = None, data: str = '',
-                    headers: Optional[Dict[str, str]] = None) -> Union[bool, Any, Tuple[str, Any]]:
+        def wrapper(callback, path, params=None, data='', headers=None):
             # python-consul doesn't allow to specify ttl smaller then 10 seconds
             # because session_ttl_min defaults to 10s, so we have to do this ugly dirty hack...
             if method == 'put' and path == '/v1/session/create':
@@ -119,14 +105,14 @@ class HTTPClient(object):
                     data = data[:-1] + ', ' + ttl + '}'
             if isinstance(params, list):  # starting from v1.1.0 python-consul switched from `dict` to `list` for params
                 params = {k: v for k, v in params}
-            kwargs: Dict[str, Any] = {'retries': 0, 'preload_content': False, 'body': data}
+            kwargs = {'retries': 0, 'preload_content': False, 'body': data}
             if method == 'get' and isinstance(params, dict) and 'index' in params:
                 timeout = float(params['wait'][:-1]) if 'wait' in params else 300
                 # According to the documentation a small random amount of additional wait time is added to the
                 # supplied maximum wait time to spread out the wake up time of any concurrent requests. This adds
                 # up to wait / 16 additional time to the maximum duration. Since our goal is actually getting a
                 # response rather read timeout we will add to the timeout a slightly bigger value.
-                kwargs['timeout'] = timeout + max(timeout / 15.0, 1)
+                kwargs['timeout'] = timeout + max(timeout/15.0, 1)
             else:
                 kwargs['timeout'] = self._read_timeout
             kwargs['headers'] = (headers or {}).copy()
@@ -140,13 +126,13 @@ class HTTPClient(object):
 
 class ConsulClient(base.Consul):
 
-    def __init__(self, *args: Any, **kwargs: Any) -> None:
+    def __init__(self, *args, **kwargs):
         self._cert = kwargs.pop('cert', None)
         self._ca_cert = kwargs.pop('ca_cert', None)
         self.token = kwargs.get('token')
         super(ConsulClient, self).__init__(*args, **kwargs)
 
-    def http_connect(self, *args: Any, **kwargs: Any) -> HTTPClient:
+    def http_connect(self, *args, **kwargs):
         kwargs.update(dict(zip(['host', 'port', 'scheme', 'verify'], args)))
         if self._cert:
             kwargs['cert'] = self._cert
@@ -156,17 +142,17 @@ class ConsulClient(base.Consul):
             kwargs['token'] = self.token
         return HTTPClient(**kwargs)
 
-    def connect(self, *args: Any, **kwargs: Any) -> HTTPClient:
+    def connect(self, *args, **kwargs):
         return self.http_connect(*args, **kwargs)
 
-    def reload_config(self, config: Dict[str, Any]) -> None:
+    def reload_config(self, config):
         self.http.token = self.token = config.get('token')
         self.consistency = config.get('consistency', 'default')
         self.dc = config.get('dc')
 
 
-def catch_consul_errors(func: Callable[..., Any]) -> Callable[..., Any]:
-    def wrapper(*args: Any, **kwargs: Any) -> Any:
+def catch_consul_errors(func):
+    def wrapper(*args, **kwargs):
         try:
             return func(*args, **kwargs)
         except (RetryFailedError, ConsulException, HTTPException, HTTPError, socket.error, socket.timeout):
@@ -174,25 +160,24 @@ def catch_consul_errors(func: Callable[..., Any]) -> Callable[..., Any]:
     return wrapper
 
 
-def force_if_last_failed(func: Callable[..., Any]) -> Callable[..., Any]:
-    def wrapper(*args: Any, **kwargs: Any) -> Any:
-        if getattr(wrapper, 'last_result', None) is False:
+def force_if_last_failed(func):
+    def wrapper(*args, **kwargs):
+        if wrapper.last_result is False:
             kwargs['force'] = True
-        last_result = func(*args, **kwargs)
-        setattr(wrapper, 'last_result', last_result)
-        return last_result
+        wrapper.last_result = func(*args, **kwargs)
+        return wrapper.last_result
 
-    setattr(wrapper, 'last_result', None)
+    wrapper.last_result = None
     return wrapper
 
 
-def service_name_from_scope_name(scope_name: str) -> str:
+def service_name_from_scope_name(scope_name):
     """Translate scope name to service name which can be used in dns.
 
     230 = 253 - len('replica.') - len('.service.consul')
     """
 
-    def replace_char(match: Any) -> str:
+    def replace_char(match):
         c = match.group(0)
         return '-' if c in '. _' else "u{:04d}".format(ord(c))
 
@@ -202,9 +187,8 @@ def service_name_from_scope_name(scope_name: str) -> str:
 
 class Consul(AbstractDCS):
 
-    def __init__(self, config: Dict[str, Any]) -> None:
+    def __init__(self, config):
         super(Consul, self).__init__(config)
-        self._base_path = self._base_path[1:]
         self._scope = config['scope']
         self._session = None
         self.__do_not_watch = False
@@ -212,9 +196,9 @@ class Consul(AbstractDCS):
                             retry_exceptions=(ConsulInternalError, HTTPException,
                                               HTTPError, socket.error, socket.timeout))
 
+        kwargs = {}
         if 'url' in config:
-            url: str = config['url']
-            r = urlparse(url)
+            r = urlparse(config['url'])
             config.update({'scheme': r.scheme, 'host': r.hostname, 'port': r.port or 8500})
         elif 'host' in config:
             host, port = split_host_port(config.get('host', '127.0.0.1:8500'), 8500)
@@ -229,7 +213,7 @@ class Consul(AbstractDCS):
             config['cert'] = (config['cert'], config['key'])
 
         config_keys = ('host', 'port', 'token', 'scheme', 'cert', 'ca_cert', 'dc', 'consistency')
-        kwargs: Dict[str, Any] = {p: config.get(p) for p in config_keys if config.get(p)}
+        kwargs = {p: config.get(p) for p in config_keys if config.get(p)}
 
         verify = config.get('verify')
         if not isinstance(verify, bool):
@@ -252,12 +236,11 @@ class Consul(AbstractDCS):
         self._service_check_tls_server_name = config.get('service_check_tls_server_name', None)
         if not self._ctl:
             self.create_session()
-        self._previous_loop_token = self._client.token
 
-    def retry(self, method: Callable[..., Any], *args: Any, **kwargs: Any) -> Any:
-        return self._retry.copy()(method, *args, **kwargs)
+    def retry(self, *args, **kwargs):
+        return self._retry.copy()(*args, **kwargs)
 
-    def create_session(self) -> None:
+    def create_session(self):
         while not self._session:
             try:
                 self.refresh_session()
@@ -265,14 +248,13 @@ class Consul(AbstractDCS):
                 logger.info('waiting on consul')
                 time.sleep(5)
 
-    def reload_config(self, config: Union['Config', Dict[str, Any]]) -> None:
+    def reload_config(self, config):
         super(Consul, self).reload_config(config)
 
         consul_config = config.get('consul', {})
         self._client.reload_config(consul_config)
         self._previous_loop_service_tags = self._service_tags
-        self._service_tags: List[str] = consul_config.get('service_tags', [])
-        self._service_tags.sort()
+        self._service_tags = sorted(consul_config.get('service_tags', []))
 
         should_register_service = consul_config.get('register_service', False)
         if should_register_service and not self._register_service:
@@ -281,32 +263,31 @@ class Consul(AbstractDCS):
         self._previous_loop_register_service = self._register_service
         self._register_service = should_register_service
 
-    def set_ttl(self, ttl: int) -> Optional[bool]:
-        if self._client.http.set_ttl(ttl / 2.0):  # Consul multiplies the TTL by 2x
+    def set_ttl(self, ttl):
+        if self._client.http.set_ttl(ttl/2.0):  # Consul multiplies the TTL by 2x
             self._session = None
             self.__do_not_watch = True
-        return None
 
     @property
-    def ttl(self) -> int:
-        return self._client.http.ttl * 2  # we multiply the value by 2 because it was divided in the `set_ttl()` method
+    def ttl(self):
+        return self._client.http.ttl
 
-    def set_retry_timeout(self, retry_timeout: int) -> None:
+    def set_retry_timeout(self, retry_timeout):
         self._retry.deadline = retry_timeout
         self._client.http.set_read_timeout(retry_timeout)
 
-    def adjust_ttl(self) -> None:
+    def adjust_ttl(self):
         try:
             settings = self._client.agent.self()
-            min_ttl = (settings['Config']['SessionTTLMin'] or 10000000000) / 1000000000.0
+            min_ttl = (settings['Config']['SessionTTLMin'] or 10000000000)/1000000000.0
             logger.warning('Changing Session TTL from %s to %s', self._client.http.ttl, min_ttl)
             self._client.http.set_ttl(min_ttl)
         except Exception:
             logger.exception('adjust_ttl')
 
-    def _do_refresh_session(self, force: bool = False) -> bool:
+    def _do_refresh_session(self):
         """:returns: `!True` if it had to create new session"""
-        if not force and self._session and self._last_session_refresh + self._loop_wait > time.time():
+        if self._session and self._last_session_refresh + self._loop_wait > time.time():
             return False
 
         if self._session:
@@ -328,121 +309,103 @@ class Consul(AbstractDCS):
         self._last_session_refresh = time.time()
         return ret
 
-    def refresh_session(self) -> bool:
+    def refresh_session(self):
         try:
             return self.retry(self._do_refresh_session)
         except (ConsulException, RetryFailedError):
             logger.exception('refresh_session')
         raise ConsulError('Failed to renew/create session')
 
+    def client_path(self, path):
+        return super(Consul, self).client_path(path)[1:]
+
     @staticmethod
-    def member(node: Dict[str, str]) -> Member:
+    def member(node):
         return Member.from_node(node['ModifyIndex'], os.path.basename(node['Key']), node.get('Session'), node['Value'])
 
-    def _cluster_from_nodes(self, nodes: Dict[str, Any]) -> Cluster:
-        # get initialize flag
-        initialize = nodes.get(self._INITIALIZE)
-        initialize = initialize and initialize['Value']
-
-        # get global dynamic configuration
-        config = nodes.get(self._CONFIG)
-        config = config and ClusterConfig.from_node(config['ModifyIndex'], config['Value'])
-
-        # get timeline history
-        history = nodes.get(self._HISTORY)
-        history = history and TimelineHistory.from_node(history['ModifyIndex'], history['Value'])
-
-        # get last known leader lsn and slots
-        status = nodes.get(self._STATUS)
-        if status:
-            try:
-                status = json.loads(status['Value'])
-                last_lsn = status.get(self._OPTIME)
-                slots = status.get('slots')
-            except Exception:
-                slots = last_lsn = None
-        else:
-            last_lsn = nodes.get(self._LEADER_OPTIME)
-            last_lsn = last_lsn and last_lsn['Value']
-            slots = None
-
+    def _load_cluster(self):
         try:
-            last_lsn = int(last_lsn or '')
-        except Exception:
-            last_lsn = 0
+            path = self.client_path('/')
+            _, results = self.retry(self._client.kv.get, path, recurse=True)
 
-        # get list of members
-        members = [self.member(n) for k, n in nodes.items() if k.startswith(self._MEMBERS) and k.count('/') == 1]
+            if results is None:
+                raise NotFound
 
-        # get leader
-        leader = nodes.get(self._LEADER)
-
-        if leader:
-            member = Member(-1, leader['Value'], None, {})
-            member = ([m for m in members if m.name == leader['Value']] or [member])[0]
-            leader = Leader(leader['ModifyIndex'], leader.get('Session'), member)
-
-        # failover key
-        failover = nodes.get(self._FAILOVER)
-        if failover:
-            failover = Failover.from_node(failover['ModifyIndex'], failover['Value'])
-
-        # get synchronization state
-        sync = nodes.get(self._SYNC)
-        sync = SyncState.from_node(sync and sync['ModifyIndex'], sync and sync['Value'])
-
-        # get failsafe topology
-        failsafe = nodes.get(self._FAILSAFE)
-        try:
-            failsafe = json.loads(failsafe['Value']) if failsafe else None
-        except Exception:
-            failsafe = None
-
-        return Cluster(initialize, config, leader, last_lsn, members, failover, sync, history, slots, failsafe)
-
-    @property
-    def _consistency(self) -> str:
-        return 'consistent' if self._ctl else self._client.consistency
-
-    def _cluster_loader(self, path: str) -> Cluster:
-        _, results = self.retry(self._client.kv.get, path, recurse=True, consistency=self._consistency)
-        if results is None:
-            raise NotFound
-        nodes = {}
-        for node in results:
-            node['Value'] = (node['Value'] or b'').decode('utf-8')
-            nodes[node['Key'][len(path):]] = node
-
-        return self._cluster_from_nodes(nodes)
-
-    def _citus_cluster_loader(self, path: str) -> Dict[int, Cluster]:
-        _, results = self.retry(self._client.kv.get, path, recurse=True, consistency=self._consistency)
-        clusters: Dict[int, Dict[str, Cluster]] = defaultdict(dict)
-        for node in results or []:
-            key = node['Key'][len(path):].split('/', 1)
-            if len(key) == 2 and citus_group_re.match(key[0]):
+            nodes = {}
+            for node in results:
                 node['Value'] = (node['Value'] or b'').decode('utf-8')
-                clusters[int(key[0])][key[1]] = node
-        return {group: self._cluster_from_nodes(nodes) for group, nodes in clusters.items()}
+                nodes[node['Key'][len(path):].lstrip('/')] = node
 
-    def _load_cluster(
-            self, path: str, loader: Callable[[str], Union[Cluster, Dict[int, Cluster]]]
-    ) -> Union[Cluster, Dict[int, Cluster]]:
-        try:
-            return loader(path)
+            # get initialize flag
+            initialize = nodes.get(self._INITIALIZE)
+            initialize = initialize and initialize['Value']
+
+            # get global dynamic configuration
+            config = nodes.get(self._CONFIG)
+            config = config and ClusterConfig.from_node(config['ModifyIndex'], config['Value'])
+
+            # get timeline history
+            history = nodes.get(self._HISTORY)
+            history = history and TimelineHistory.from_node(history['ModifyIndex'], history['Value'])
+
+            # get last known leader lsn and slots
+            status = nodes.get(self._STATUS)
+            if status:
+                try:
+                    status = json.loads(status['Value'])
+                    last_lsn = status.get(self._OPTIME)
+                    slots = status.get('slots')
+                except Exception:
+                    slots = last_lsn = None
+            else:
+                last_lsn = nodes.get(self._LEADER_OPTIME)
+                last_lsn = last_lsn and last_lsn['Value']
+                slots = None
+
+            try:
+                last_lsn = int(last_lsn)
+            except Exception:
+                last_lsn = 0
+
+            # get list of members
+            members = [self.member(n) for k, n in nodes.items() if k.startswith(self._MEMBERS) and k.count('/') == 1]
+
+            # get leader
+            leader = nodes.get(self._LEADER)
+            if not self._ctl and leader and leader['Value'] == self._name \
+                    and self._session != leader.get('Session', 'x'):
+                logger.info('I am leader but not owner of the session. Removing leader node')
+                self._client.kv.delete(self.leader_path, cas=leader['ModifyIndex'])
+                leader = None
+
+            if leader:
+                member = Member(-1, leader['Value'], None, {})
+                member = ([m for m in members if m.name == leader['Value']] or [member])[0]
+                leader = Leader(leader['ModifyIndex'], leader.get('Session'), member)
+
+            # failover key
+            failover = nodes.get(self._FAILOVER)
+            if failover:
+                failover = Failover.from_node(failover['ModifyIndex'], failover['Value'])
+
+            # get synchronization state
+            sync = nodes.get(self._SYNC)
+            sync = SyncState.from_node(sync and sync['ModifyIndex'], sync and sync['Value'])
+
+            return Cluster(initialize, config, leader, last_lsn, members, failover, sync, history, slots)
         except NotFound:
-            return Cluster.empty()
+            return Cluster(None, None, None, None, [], None, None, None, None)
         except Exception:
             logger.exception('get_cluster')
             raise ConsulError('Consul is not responding properly')
 
     @catch_consul_errors
-    def touch_member(self, data: Dict[str, Any]) -> bool:
+    def touch_member(self, data, permanent=False):
         cluster = self.cluster
         member = cluster and cluster.get_member(self._name, fallback_to_leader=False)
 
         try:
-            create_member = self.refresh_session()
+            create_member = not permanent and self.refresh_session()
         except DCSError:
             return False
 
@@ -460,7 +423,8 @@ class Consul(AbstractDCS):
             return True
 
         try:
-            self._client.kv.put(self.member_path, json.dumps(data, separators=(',', ':')), acquire=self._session)
+            args = {} if permanent else {'acquire': self._session}
+            self._client.kv.put(self.member_path, json.dumps(data, separators=(',', ':')), **args)
             return True
         except InvalidSession:
             self._session = None
@@ -469,44 +433,37 @@ class Consul(AbstractDCS):
             logger.exception('touch_member')
         return False
 
-    def _set_service_name(self) -> None:
+    def _set_service_name(self):
         self._service_name = service_name_from_scope_name(self._scope)
         if self._scope != self._service_name:
             logger.warning('Using %s as consul service name instead of scope name %s', self._service_name, self._scope)
 
     @catch_consul_errors
-    def register_service(self, service_name: str, **kwargs: Any) -> bool:
+    def register_service(self, service_name, **kwargs):
         logger.info('Register service %s, params %s', service_name, kwargs)
         return self._client.agent.service.register(service_name, **kwargs)
 
     @catch_consul_errors
-    def deregister_service(self, service_id: str) -> bool:
+    def deregister_service(self, service_id):
         logger.info('Deregister service %s', service_id)
         # service_id can contain special characters, but is used as part of uri in deregister request
         service_id = quote(service_id)
         return self._client.agent.service.deregister(service_id)
 
-    def _update_service(self, data: Dict[str, Any]) -> Optional[bool]:
+    def _update_service(self, data):
         service_name = self._service_name
         role = data['role'].replace('_', '-')
         state = data['state']
-        api_url: str = data['api_url']
-        api_parts = urlparse(api_url)
+        api_parts = urlparse(data['api_url'])
         api_parts = api_parts._replace(path='/{0}'.format(role))
-        conn_url: str = data['conn_url']
-        conn_parts = urlparse(conn_url)
+        conn_parts = urlparse(data['conn_url'])
         check = base.Check.http(api_parts.geturl(), self._service_check_interval,
                                 deregister='{0}s'.format(self._client.http.ttl * 10))
         if self._service_check_tls_server_name is not None:
             check['TLSServerName'] = self._service_check_tls_server_name
         tags = self._service_tags[:]
         tags.append(role)
-        if role == 'master':
-            tags.append('primary')
-        elif role == 'primary':
-            tags.append('master')
         self._previous_loop_service_tags = self._service_tags
-        self._previous_loop_token = self._client.token
 
         params = {
             'service_id': '{0}/{1}'.format(self._scope, self._name),
@@ -522,7 +479,7 @@ class Consul(AbstractDCS):
             return self.deregister_service(params['service_id'])
 
         self._previous_loop_register_service = self._register_service
-        if role in ['master', 'primary', 'replica', 'standby-leader']:
+        if role in ['master', 'replica', 'standby-leader']:
             if state != 'running':
                 return
             return self.register_service(service_name, **params)
@@ -530,7 +487,7 @@ class Consul(AbstractDCS):
         logger.warning('Could not register service: unknown role type %s', role)
 
     @force_if_last_failed
-    def update_service(self, old_data: Dict[str, Any], new_data: Dict[str, Any], force: bool = False) -> Optional[bool]:
+    def update_service(self, old_data, new_data, force=False):
         update = False
 
         for key in ['role', 'api_url', 'conn_url', 'state']:
@@ -543,137 +500,99 @@ class Consul(AbstractDCS):
         if (
             force or update or self._register_service != self._previous_loop_register_service
             or self._service_tags != self._previous_loop_service_tags
-            or self._client.token != self._previous_loop_token
         ):
             return self._update_service(new_data)
 
-    def _do_attempt_to_acquire_leader(self, retry: Retry) -> bool:
+    @catch_consul_errors
+    def _do_attempt_to_acquire_leader(self, permanent):
         try:
-            return retry(self._client.kv.put, self.leader_path, self._name, acquire=self._session)
+            kwargs = {} if permanent else {'acquire': self._session}
+            return self.retry(self._client.kv.put, self.leader_path, self._name, **kwargs)
         except InvalidSession:
-            logger.error('Our session disappeared from Consul. Will try to get a new one and retry attempt')
             self._session = None
-            retry.ensure_deadline(0)
+            logger.error('Our session disappeared from Consul. Will try to get a new one and retry attempt')
+            self.refresh_session()
+            return self.retry(self._client.kv.put, self.leader_path, self._name, acquire=self._session)
 
-            retry(self._do_refresh_session)
+    def attempt_to_acquire_leader(self, permanent=False):
+        if not self._session and not permanent:
+            self.refresh_session()
 
-            retry.ensure_deadline(1, ConsulError('_do_attempt_to_acquire_leader timeout'))
-
-            return retry(self._client.kv.put, self.leader_path, self._name, acquire=self._session)
-
-    @catch_return_false_exception
-    def attempt_to_acquire_leader(self) -> bool:
-        retry = self._retry.copy()
-        self._run_and_handle_exceptions(self._do_refresh_session, retry=retry)
-
-        retry.ensure_deadline(1, ConsulError('attempt_to_acquire_leader timeout'))
-
-        ret = self._run_and_handle_exceptions(self._do_attempt_to_acquire_leader, retry, retry=None)
+        ret = self._do_attempt_to_acquire_leader(permanent)
         if not ret:
             logger.info('Could not take out TTL lock')
 
         return ret
 
-    def take_leader(self) -> bool:
+    def take_leader(self):
         return self.attempt_to_acquire_leader()
 
     @catch_consul_errors
-    def set_failover_value(self, value: str, version: Optional[int] = None) -> bool:
-        return self._client.kv.put(self.failover_path, value, cas=version)
+    def set_failover_value(self, value, index=None):
+        return self._client.kv.put(self.failover_path, value, cas=index)
 
     @catch_consul_errors
-    def set_config_value(self, value: str, version: Optional[int] = None) -> bool:
-        return self._client.kv.put(self.config_path, value, cas=version)
+    def set_config_value(self, value, index=None):
+        return self._client.kv.put(self.config_path, value, cas=index)
 
     @catch_consul_errors
-    def _write_leader_optime(self, last_lsn: str) -> bool:
+    def _write_leader_optime(self, last_lsn):
         return self._client.kv.put(self.leader_optime_path, last_lsn)
 
     @catch_consul_errors
-    def _write_status(self, value: str) -> bool:
+    def _write_status(self, value):
         return self._client.kv.put(self.status_path, value)
 
     @catch_consul_errors
-    def _write_failsafe(self, value: str) -> bool:
-        return self._client.kv.put(self.failsafe_path, value)
-
-    @staticmethod
-    def _run_and_handle_exceptions(method: Callable[..., Any], *args: Any, **kwargs: Any) -> Any:
-        retry = kwargs.pop('retry', None)
-        try:
-            return retry(method, *args, **kwargs) if retry else method(*args, **kwargs)
-        except (RetryFailedError, InvalidSession, HTTPException, HTTPError, socket.error, socket.timeout) as e:
-            raise ConsulError(e)
-        except ConsulException:
-            raise ReturnFalseException
-
-    @catch_return_false_exception
-    def _update_leader(self, leader: Leader) -> bool:
-        retry = self._retry.copy()
-
-        self._run_and_handle_exceptions(self._do_refresh_session, True, retry=retry)
-
-        if self._session and leader.session != self._session:
-            retry.ensure_deadline(1, ConsulError('update_leader timeout'))
-
-            logger.warning('Recreating the leader key due to session mismatch')
-            self._run_and_handle_exceptions(self._client.kv.delete, self.leader_path, cas=leader.version)
-
-            retry.ensure_deadline(0.5, ConsulError('update_leader timeout'))
-
-            self._run_and_handle_exceptions(self._client.kv.put, self.leader_path, self._name, acquire=self._session)
-
+    def _update_leader(self):
+        if self._session:
+            self.retry(self._client.session.renew, self._session)
+            self._last_session_refresh = time.time()
         return bool(self._session)
 
     @catch_consul_errors
-    def initialize(self, create_new: bool = True, sysid: str = '') -> bool:
+    def initialize(self, create_new=True, sysid=''):
         kwargs = {'cas': 0} if create_new else {}
         return self.retry(self._client.kv.put, self.initialize_path, sysid, **kwargs)
 
     @catch_consul_errors
-    def cancel_initialization(self) -> bool:
+    def cancel_initialization(self):
         return self.retry(self._client.kv.delete, self.initialize_path)
 
     @catch_consul_errors
-    def delete_cluster(self) -> bool:
+    def delete_cluster(self):
         return self.retry(self._client.kv.delete, self.client_path(''), recurse=True)
 
     @catch_consul_errors
-    def set_history_value(self, value: str) -> bool:
+    def set_history_value(self, value):
         return self._client.kv.put(self.history_path, value)
 
     @catch_consul_errors
-    def _delete_leader(self, leader: Leader) -> bool:
-        return self._client.kv.delete(self.leader_path, cas=int(leader.version))
+    def _delete_leader(self):
+        cluster = self.cluster
+        if cluster and isinstance(cluster.leader, Leader) and cluster.leader.name == self._name:
+            return self._client.kv.delete(self.leader_path, cas=cluster.leader.index)
 
     @catch_consul_errors
-    def set_sync_state_value(self, value: str, version: Optional[int] = None) -> Union[int, bool]:
-        retry = self._retry.copy()
-        ret = retry(self._client.kv.put, self.sync_path, value, cas=version)
-        if ret:  # We have no other choise, only read after write :(
-            if not retry.ensure_deadline(0.5):
-                return False
-            _, ret = self.retry(self._client.kv.get, self.sync_path)
-            if ret and (ret.get('Value') or b'').decode('utf-8') == value:
-                return ret['ModifyIndex']
-        return False
+    def set_sync_state_value(self, value, index=None):
+        return self.retry(self._client.kv.put, self.sync_path, value, cas=index)
 
     @catch_consul_errors
-    def delete_sync_state(self, version: Optional[int] = None) -> bool:
-        return self.retry(self._client.kv.delete, self.sync_path, cas=version)
+    def delete_sync_state(self, index=None):
+        return self.retry(self._client.kv.delete, self.sync_path, cas=index)
 
-    def watch(self, leader_version: Optional[int], timeout: float) -> bool:
+    def watch(self, leader_index, timeout):
         self._last_session_refresh = 0
         if self.__do_not_watch:
             self.__do_not_watch = False
             return True
 
-        if leader_version:
+        if leader_index:
             end_time = time.time() + timeout
             while timeout >= 1:
                 try:
-                    idx, _ = self._client.kv.get(self.leader_path, index=leader_version, wait=str(timeout) + 's')
-                    return str(idx) != str(leader_version)
+                    idx, _ = self._client.kv.get(self.leader_path, index=leader_index, wait=str(timeout) + 's')
+                    return str(idx) != str(leader_index)
                 except (ConsulException, HTTPException, HTTPError, socket.error, socket.timeout):
                     logger.exception('watch')
 

patroni/dcs/etcd.py

@@ -6,28 +6,23 @@ import logging
 import os
 import urllib3.util.connection
 import random
+import six
 import socket
 import time
 
-from collections import defaultdict
-from copy import deepcopy
 from dns.exception import DNSException
 from dns import resolver
-from http.client import HTTPException
-from queue import Queue
-from threading import Thread
-from typing import Any, Callable, Collection, Dict, List, Optional, Union, Tuple, Type, TYPE_CHECKING
-from urllib.parse import urlparse
 from urllib3 import Timeout
 from urllib3.exceptions import HTTPError, ReadTimeoutError, ProtocolError
+from six.moves.queue import Queue
+from six.moves.http_client import HTTPException
+from six.moves.urllib_parse import urlparse
+from threading import Thread
 
-from . import AbstractDCS, Cluster, ClusterConfig, Failover, Leader, Member, SyncState, \
-    TimelineHistory, ReturnFalseException, catch_return_false_exception, citus_group_re
+from . import AbstractDCS, Cluster, ClusterConfig, Failover, Leader, Member, SyncState, TimelineHistory
 from ..exceptions import DCSError
 from ..request import get as requests_get
 from ..utils import Retry, RetryFailedError, split_host_port, uri, USER_AGENT
-if TYPE_CHECKING:  # pragma: no cover
-    from ..config import Config
 
 logger = logging.getLogger(__name__)
 
@@ -40,21 +35,18 @@ class EtcdError(DCSError):
     pass
 
 
-_AddrInfo = Tuple[socket.AddressFamily, socket.SocketKind, int, str, Union[Tuple[str, int], Tuple[str, int, int, int]]]
-
-
 class DnsCachingResolver(Thread):
 
-    def __init__(self, cache_time: float = 600.0, cache_fail_time: float = 30.0) -> None:
+    def __init__(self, cache_time=600.0, cache_fail_time=30.0):
         super(DnsCachingResolver, self).__init__()
-        self._cache: Dict[Tuple[str, int], Tuple[float, List[_AddrInfo]]] = {}
+        self._cache = {}
         self._cache_time = cache_time
         self._cache_fail_time = cache_fail_time
-        self._resolve_queue: Queue[Tuple[Tuple[str, int], int]] = Queue()
+        self._resolve_queue = Queue()
         self.daemon = True
         self.start()
 
-    def run(self) -> None:
+    def run(self):
         while True:
             (host, port), attempt = self._resolve_queue.get()
             response = self._do_resolve(host, port)
@@ -65,7 +57,7 @@ class DnsCachingResolver(Thread):
                     self.resolve_async(host, port, attempt + 1)
                     time.sleep(1)
 
-    def resolve(self, host: str, port: int) -> List[_AddrInfo]:
+    def resolve(self, host, port):
         current_time = time.time()
         cached_time, response = self._cache.get((host, port), (0, []))
         time_passed = current_time - cached_time
@@ -76,14 +68,14 @@ class DnsCachingResolver(Thread):
                 response = new_response
         return response
 
-    def resolve_async(self, host: str, port: int, attempt: int = 0) -> None:
+    def resolve_async(self, host, port, attempt=0):
         self._resolve_queue.put(((host, port), attempt))
 
-    def remove(self, host: str, port: int) -> None:
+    def remove(self, host, port):
         self._cache.pop((host, port), None)
 
     @staticmethod
-    def _do_resolve(host: str, port: int) -> List[_AddrInfo]:
+    def _do_resolve(host, port):
         try:
             return socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM, socket.IPPROTO_TCP)
         except Exception as e:
@@ -91,21 +83,21 @@ class DnsCachingResolver(Thread):
             return []
 
 
-class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
+@six.add_metaclass(abc.ABCMeta)
+class AbstractEtcdClientWithFailover(etcd.Client):
 
-    ERROR_CLS: Type[Exception]
-
-    def __init__(self, config: Dict[str, Any], dns_resolver: DnsCachingResolver, cache_ttl: int = 300) -> None:
+    def __init__(self, config, dns_resolver, cache_ttl=300):
         self._dns_resolver = dns_resolver
         self.set_machines_cache_ttl(cache_ttl)
         self._machines_cache_updated = 0
-        kwargs = {p: config.get(p) for p in ('host', 'port', 'protocol', 'use_proxies', 'version_prefix',
-                                             'username', 'password', 'cert', 'ca_cert') if config.get(p)}
-        super(AbstractEtcdClientWithFailover, self).__init__(read_timeout=config['retry_timeout'], **kwargs)
+        args = {p: config.get(p) for p in ('host', 'port', 'protocol', 'use_proxies', 'username', 'password',
+                                           'cert', 'ca_cert') if config.get(p)}
+        super(AbstractEtcdClientWithFailover, self).__init__(read_timeout=config['retry_timeout'], **args)
         # For some reason python3-etcd on debian and ubuntu are not based on the latest version
         # Workaround for the case when https://github.com/jplana/python-etcd/pull/196 is not applied
         self.http.connection_pool_kw.pop('ssl_version', None)
         self._config = config
+        self._initial_machines_cache = []
         self._load_machines_cache()
         self._allow_reconnect = True
         # allow passing retry argument to api_execute in params
@@ -113,7 +105,7 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
         self._read_options.add('retry')
         self._del_conditions.add('retry')
 
-    def _calculate_timeouts(self, etcd_nodes: int, timeout: Optional[float] = None) -> Tuple[int, float, int]:
+    def _calculate_timeouts(self, etcd_nodes, timeout=None):
         """Calculate a request timeout and number of retries per single etcd node.
         In case if the timeout per node is too small (less than one second) we will reduce the number of nodes.
         For the cluster with only one node we will try to do 2 retries.
@@ -140,48 +132,54 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
 
         return etcd_nodes, per_node_timeout, per_node_retries - 1
 
-    def reload_config(self, config: Dict[str, Any]) -> None:
+    def reload_config(self, config):
         self.username = config.get('username')
         self.password = config.get('password')
 
-    def _get_headers(self) -> Dict[str, str]:
+    def _get_headers(self):
         basic_auth = ':'.join((self.username, self.password)) if self.username and self.password else None
         return urllib3.make_headers(basic_auth=basic_auth, user_agent=USER_AGENT)
 
-    def _prepare_common_parameters(self, etcd_nodes: int, timeout: Optional[float] = None) -> Dict[str, Any]:
-        kwargs: Dict[str, Any] = {'headers': self._get_headers(),
-                                  'redirect': self.allow_redirect, 'preload_content': False}
+    def _prepare_common_parameters(self, etcd_nodes, timeout=None):
+        kwargs = {'headers': self._get_headers(), 'redirect': self.allow_redirect, 'preload_content': False}
 
         if timeout is not None:
             kwargs.update(retries=0, timeout=timeout)
         else:
             _, per_node_timeout, per_node_retries = self._calculate_timeouts(etcd_nodes)
-            connect_timeout = max(1.0, per_node_timeout / 2.0)
+            connect_timeout = max(1, per_node_timeout/2)
             kwargs.update(timeout=Timeout(connect=connect_timeout, total=per_node_timeout), retries=per_node_retries)
         return kwargs
 
-    def set_machines_cache_ttl(self, cache_ttl: int) -> None:
+    def set_machines_cache_ttl(self, cache_ttl):
         self._machines_cache_ttl = cache_ttl
 
     @abc.abstractmethod
-    def _prepare_get_members(self, etcd_nodes: int) -> Dict[str, Any]:
+    def _prepare_get_members(self, etcd_nodes):
         """returns: request parameters"""
 
     @abc.abstractmethod
-    def _get_members(self, base_uri: str, **kwargs: Any) -> List[str]:
+    def _get_members(self, base_uri, **kwargs):
         """returns: list of clientURLs"""
 
     @property
-    def machines_cache(self) -> List[str]:
+    def machines_cache(self):
         base_uri, cache = self._base_uri, self._machines_cache
         return ([base_uri] if base_uri in cache else []) + [machine for machine in cache if machine != base_uri]
 
-    def _get_machines_list(self, machines_cache: List[str]) -> List[str]:
-        """Gets list of members from Etcd cluster using API
+    @property
+    def machines(self):
+        """Original `machines` method(property) of `etcd.Client` class raise exception
+        when it failed to get list of etcd cluster members. This method is being called
+        only when request failed on one of the etcd members during `api_execute` call.
+        For us it's more important to execute original request rather then get new topology
+        of etcd cluster. So we will catch this exception and return empty list of machines.
+        Later, during next `api_execute` call we will forcefully update machines_cache.
 
-        :param machines_cache: initial list of Etcd members
-        :returns: list of clientURLs retrieved from Etcd cluster
-        :raises EtcdConnectionFailed: if failed"""
+        Also this method implements the same timeout-retry logic as `api_execute`, because
+        the original method was retrying 2 times with the `read_timeout` on each node."""
+
+        machines_cache = self.machines_cache
         kwargs = self._prepare_get_members(len(machines_cache))
 
         for base_uri in machines_cache:
@@ -199,30 +197,10 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
 
         raise etcd.EtcdConnectionFailed('No more machines in the cluster')
 
-    @property
-    def machines(self) -> List[str]:
-        """Original `machines` method(property) of `etcd.Client` class raise exception
-        when it failed to get list of etcd cluster members. This method is being called
-        only when request failed on one of the etcd members during `api_execute` call.
-        For us it's more important to execute original request rather then get new topology
-        of etcd cluster. So we will catch this exception and return empty list of machines.
-        Later, during next `api_execute` call we will forcefully update machines_cache.
-
-        Also this method implements the same timeout-retry logic as `api_execute`, because
-        the original method was retrying 2 times with the `read_timeout` on each node.
-
-        After the next refactoring the whole logic was moved to the _get_machines_list() method."""
-
-        return self._get_machines_list(self.machines_cache)
-
-    def set_read_timeout(self, timeout: float) -> None:
+    def set_read_timeout(self, timeout):
         self._read_timeout = timeout
 
-    def _do_http_request(self, retry: Optional[Retry], machines_cache: List[str],
-                         request_executor: Callable[..., urllib3.response.HTTPResponse],
-                         method: str, path: str, fields: Optional[Dict[str, Any]] = None,
-                         **kwargs: Any) -> urllib3.response.HTTPResponse:
-        is_watch_request = isinstance(fields, dict) and fields.get('wait') == 'true'
+    def _do_http_request(self, retry, machines_cache, request_executor, method, path, fields=None, **kwargs):
         if fields is not None:
             kwargs['fields'] = fields
         some_request_failed = False
@@ -238,14 +216,12 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
                 return response
             except (HTTPError, HTTPException, socket.error, socket.timeout) as e:
                 self.http.clear()
-                if not retry:
-                    if len(machines_cache) == 1:
-                        self.set_base_uri(self._base_uri)  # trigger Etcd3 watcher restart
-                    # switch to the next etcd node because we don't know exactly what happened,
-                    # whether the key didn't received an update or there is a network problem.
-                    elif i + 1 < len(machines_cache):
-                        self.set_base_uri(machines_cache[i + 1])
-                if is_watch_request and isinstance(e, (ReadTimeoutError, ProtocolError)):
+                # switch to the next etcd node because we don't know exactly what happened,
+                # whether the key didn't received an update or there is a network problem.
+                if not retry and i + 1 < len(machines_cache):
+                    self.set_base_uri(machines_cache[i + 1])
+                if (isinstance(fields, dict) and fields.get("wait") == "true" and
+                        isinstance(e, (ReadTimeoutError, ProtocolError))):
                     logger.debug("Watch timed out.")
                     raise etcd.EtcdWatchTimedOut("Watch timed out: {0}".format(e), cause=e)
                 logger.error("Request to server %s failed: %r", base_uri, e)
@@ -257,12 +233,10 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
         raise etcd.EtcdConnectionFailed('No more machines in the cluster')
 
     @abc.abstractmethod
-    def _prepare_request(self, kwargs: Dict[str, Any], params: Optional[Dict[str, Any]] = None,
-                         method: Optional[str] = None) -> Callable[..., urllib3.response.HTTPResponse]:
+    def _prepare_request(self, kwargs, params=None, method=None):
         """returns: request_executor"""
 
-    def api_execute(self, path: str, method: str, params: Optional[Dict[str, Any]] = None,
-                    timeout: Optional[float] = None) -> Any:
+    def api_execute(self, path, method, params=None, timeout=None):
         retry = params.pop('retry', None) if isinstance(params, dict) else None
 
         # Update machines_cache if previous attempt of update has failed
@@ -290,8 +264,6 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
                         etcd_nodes = len(machines_cache)
                 except Exception as e:
                     logger.debug('Failed to update list of etcd nodes: %r', e)
-                if TYPE_CHECKING:  # pragma: no cover
-                    assert isinstance(retry, Retry)  # etcd.EtcdConnectionFailed is raised only if retry is not None!
                 sleeptime = retry.sleeptime
                 remaining_time = retry.stoptime - sleeptime - time.time()
                 nodes, timeout, retries = self._calculate_timeouts(etcd_nodes, remaining_time)
@@ -302,22 +274,22 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
                 retry.sleep_func(sleeptime)
                 retry.update_delay()
                 # We still have some time left. Partially reduce `machines_cache` and retry request
-                kwargs.update(timeout=Timeout(connect=max(1.0, timeout / 2.0), total=timeout), retries=retries)
+                kwargs.update(timeout=Timeout(connect=max(1, timeout/2), total=timeout), retries=retries)
                 machines_cache = machines_cache[:nodes]
 
     @staticmethod
-    def get_srv_record(host: str) -> List[Tuple[str, int]]:
+    def get_srv_record(host):
         try:
             return [(r.target.to_text(True), r.port) for r in resolver.query(host, 'SRV')]
         except DNSException:
             return []
 
-    def _get_machines_cache_from_srv(self, srv: str, srv_suffix: Optional[str] = None) -> List[str]:
+    def _get_machines_cache_from_srv(self, srv, srv_suffix=None):
         """Fetch list of etcd-cluster member by resolving _etcd-server._tcp. SRV record.
         This record should contain list of host and peer ports which could be used to run
         'GET http://{host}:{port}/members' request (peer protocol)"""
 
-        ret: List[str] = []
+        ret = []
         for r in ['-client-ssl', '-client', '-ssl', '', '-server-ssl', '-server']:
             r = '{0}-{1}'.format(r, srv_suffix) if srv_suffix else r
             protocol = 'https' if '-ssl' in r else 'http'
@@ -342,15 +314,15 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
             logger.warning('Can not resolve SRV for %s', srv)
         return list(set(ret))
 
-    def _get_machines_cache_from_dns(self, host: str, port: int) -> List[str]:
+    def _get_machines_cache_from_dns(self, host, port):
         """One host might be resolved into multiple ip addresses. We will make list out of it"""
         if self.protocol == 'http':
-            ret = [uri(self.protocol, res[-1][:2]) for res in self._dns_resolver.resolve(host, port)]
+            ret = map(lambda res: uri(self.protocol, res[-1][:2]), self._dns_resolver.resolve(host, port))
             if ret:
                 return list(set(ret))
         return [uri(self.protocol, (host, port))]
 
-    def _get_machines_cache_from_config(self) -> List[str]:
+    def _get_machines_cache_from_config(self):
         if 'proxy' in self._config:
             return [uri(self.protocol, (self._config['host'], self._config['port']))]
 
@@ -366,14 +338,13 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
         return machines_cache
 
     @staticmethod
-    def _update_dns_cache(func: Callable[[str, int], None], machines: List[str]) -> None:
+    def _update_dns_cache(func, machines):
         for url in machines:
             r = urlparse(url)
-            if r.hostname:
-                port = r.port or (443 if r.scheme == 'https' else 80)
-                func(r.hostname, port)
+            port = r.port or (443 if r.scheme == 'https' else 80)
+            func(r.hostname, port)
 
-    def _load_machines_cache(self) -> bool:
+    def _load_machines_cache(self):
         """This method should fill up `_machines_cache` from scratch.
         It could happen only in two cases:
         1. During class initialization
@@ -392,48 +363,38 @@ class AbstractEtcdClientWithFailover(abc.ABC, etcd.Client):
         # enforce resolving dns name,they might get new ips
         self._update_dns_cache(self._dns_resolver.remove, machines_cache)
 
-        # after filling up the initial list of machines_cache we should ask etcd-cluster about actual list
-        ret = self._refresh_machines_cache(machines_cache)
+        # The etcd cluster could change its topology over time and depending on how we resolve the initial
+        # topology (list of hosts in the Patroni config or DNS records, A or SRV) we might get into the situation
+        # the the real topology doesn't match anymore with the topology resolved from the configuration file.
+        # In case if the "initial" topology is the same as before we will not override the `_machines_cache`.
+        ret = set(machines_cache) != set(self._initial_machines_cache)
+        if ret:
+            self._initial_machines_cache = self._machines_cache = machines_cache
+
+            # After filling up the initial list of machines_cache we should ask etcd-cluster about actual list
+            self._refresh_machines_cache(True)
 
         self._update_machines_cache = False
         return ret
 
-    def _refresh_machines_cache(self, machines_cache: Optional[List[str]] = None) -> bool:
-        """Get etcd cluster topology using Etcd API and put it to self._machines_cache
-
-        :param machines_cache: the list of nodes we want to run through executing API request
-                               in addition to values stored in the self._machines_cache
-        :returns: `True` if self._machines_cache was updated with new values
-        :raises EtcdException: if failed to get topology and `machines_cache` was specified.
-
-        The self._machines_cache will not be updated if nodes from the list are
-        not accessible or if they are not returning correct results."""
-
+    def _refresh_machines_cache(self, updating_cache=False):
         if self._use_proxies:
-            value = self._get_machines_cache_from_config()
+            self._machines_cache = self._get_machines_cache_from_config()
         else:
             try:
-                # we want to go through the list obtained from the config file + last known health topology
-                value = self._get_machines_list(list(set((machines_cache or []) + self.machines_cache)))
+                self._machines_cache = self.machines
             except etcd.EtcdConnectionFailed:
-                value = []
-
-        if value:
-            ret = set(self._machines_cache) != set(value)
-            self._machines_cache = value
-        elif machines_cache:  # we are just starting or all nodes were not available at some point
-            raise etcd.EtcdException("Could not get the list of servers, "
-                                     "maybe you provided the wrong "
-                                     "host(s) to connect to?")
-        else:
-            return False
+                if updating_cache:
+                    raise etcd.EtcdException("Could not get the list of servers, "
+                                             "maybe you provided the wrong "
+                                             "host(s) to connect to?")
+                return
 
         if self._base_uri not in self._machines_cache:
             self.set_base_uri(self._machines_cache[0])
         self._machines_cache_updated = time.time()
-        return ret
 
-    def set_base_uri(self, value: str) -> None:
+    def set_base_uri(self, value):
         if self._base_uri != value:
             logger.info('Selected new etcd server %s', value)
             self._base_uri = value
@@ -443,25 +404,22 @@ class EtcdClient(AbstractEtcdClientWithFailover):
 
     ERROR_CLS = EtcdError
 
-    def __init__(self, config: Dict[str, Any], dns_resolver: DnsCachingResolver, cache_ttl: int = 300) -> None:
-        super(EtcdClient, self).__init__({**config, 'version_prefix': None}, dns_resolver, cache_ttl)
+    def __del__(self):
+        if self.http is not None:
+            try:
+                self.http.clear()
+            except (ReferenceError, TypeError, AttributeError):
+                pass
 
-    def __del__(self) -> None:
-        try:
-            self.http.clear()
-        except (ReferenceError, TypeError, AttributeError):
-            pass
-
-    def _prepare_get_members(self, etcd_nodes: int) -> Dict[str, Any]:
+    def _prepare_get_members(self, etcd_nodes):
         return self._prepare_common_parameters(etcd_nodes)
 
-    def _get_members(self, base_uri: str, **kwargs: Any) -> List[str]:
+    def _get_members(self, base_uri, **kwargs):
         response = self.http.request(self._MGET, base_uri + self.version_prefix + '/machines', **kwargs)
         data = self._handle_server_response(response).data.decode('utf-8')
         return [m.strip() for m in data.split(',') if m.strip()]
 
-    def _prepare_request(self, kwargs: Dict[str, Any], params: Optional[Dict[str, Any]] = None,
-                         method: Optional[str] = None) -> Callable[..., urllib3.response.HTTPResponse]:
+    def _prepare_request(self, kwargs, params=None, method=None):
         kwargs['fields'] = params
         if method in (self._MPOST, self._MPUT):
             kwargs['encode_multipart'] = False
@@ -470,32 +428,25 @@ class EtcdClient(AbstractEtcdClientWithFailover):
 
 class AbstractEtcd(AbstractDCS):
 
-    def __init__(self, config: Dict[str, Any], client_cls: Type[AbstractEtcdClientWithFailover],
-                 retry_errors_cls: Union[Type[Exception], Tuple[Type[Exception], ...]]) -> None:
+    def __init__(self, config, client_cls, retry_errors_cls):
         super(AbstractEtcd, self).__init__(config)
         self._retry = Retry(deadline=config['retry_timeout'], max_delay=1, max_tries=-1,
                             retry_exceptions=retry_errors_cls)
         self._ttl = int(config.get('ttl') or 30)
-        self._abstract_client = self.get_etcd_client(config, client_cls)
+        self._client = self.get_etcd_client(config, client_cls)
         self.__do_not_watch = False
         self._has_failed = False
 
-    @property
-    @abc.abstractmethod
-    def _client(self) -> AbstractEtcdClientWithFailover:
-        """return correct type of etcd client"""
-
-    def reload_config(self, config: Union['Config', Dict[str, Any]]) -> None:
+    def reload_config(self, config):
         super(AbstractEtcd, self).reload_config(config)
         self._client.reload_config(config.get(self.__class__.__name__.lower(), {}))
 
-    def retry(self, method: Callable[..., Any], *args: Any, **kwargs: Any) -> Any:
+    def retry(self, *args, **kwargs):
         retry = self._retry.copy()
         kwargs['retry'] = retry
-        return retry(method, *args, **kwargs)
+        return retry(*args, **kwargs)
 
-    def _handle_exception(self, e: Exception, name: str = '', do_sleep: bool = False,
-                          raise_ex: Optional[Exception] = None) -> None:
+    def _handle_exception(self, e, name='', do_sleep=False, raise_ex=None):
         if not self._has_failed:
             logger.exception(name)
         else:
@@ -506,43 +457,18 @@ class AbstractEtcd(AbstractDCS):
         if isinstance(raise_ex, Exception):
             raise raise_ex
 
-    def handle_etcd_exceptions(self, func: Callable[..., Any], *args: Any, **kwargs: Any) -> Any:
-        try:
-            retval = func(self, *args, **kwargs)
-            self._has_failed = False
-            return retval
-        except (RetryFailedError, etcd.EtcdException) as e:
-            self._handle_exception(e)
-            return False
-        except Exception as e:
-            self._handle_exception(e, raise_ex=self._client.ERROR_CLS('unexpected error'))
-
-    def _run_and_handle_exceptions(self, method: Callable[..., Any], *args: Any, **kwargs: Any) -> Any:
-        retry = kwargs.pop('retry', self.retry)
-        try:
-            return retry(method, *args, **kwargs) if retry else method(*args, **kwargs)
-        except (RetryFailedError, etcd.EtcdConnectionFailed) as e:
-            raise self._client.ERROR_CLS(e)
-        except etcd.EtcdException as e:
-            self._handle_exception(e)
-            raise ReturnFalseException
-        except Exception as e:
-            self._handle_exception(e, raise_ex=self._client.ERROR_CLS('unexpected error'))
-
-    def set_socket_options(self, sock: socket.socket,
-                           socket_options: Optional[Collection[Tuple[int, int, int]]]) -> None:
+    @staticmethod
+    def set_socket_options(sock, socket_options):
         if socket_options:
             for opt in socket_options:
                 sock.setsockopt(*opt)
 
-    def get_etcd_client(self, config: Dict[str, Any],
-                        client_cls: Type[AbstractEtcdClientWithFailover]) -> AbstractEtcdClientWithFailover:
-        config = deepcopy(config)
+    def get_etcd_client(self, config, client_cls):
         if 'proxy' in config:
             config['use_proxies'] = True
             config['url'] = config['proxy']
 
-        if 'url' in config and isinstance(config['url'], str):
+        if 'url' in config:
             r = urlparse(config['url'])
             config.update({'protocol': r.scheme, 'host': r.hostname, 'port': r.port or 2379,
                            'username': r.username, 'password': r.password})
@@ -551,14 +477,13 @@ class AbstractEtcd(AbstractDCS):
             default_port = config.pop('port', 2379)
             protocol = config.get('protocol', 'http')
 
-            if isinstance(hosts, str):
+            if isinstance(hosts, six.string_types):
                 hosts = hosts.split(',')
 
-            config_hosts: List[str] = []
+            config['hosts'] = []
             for value in hosts:
-                if isinstance(value, str):
-                    config_hosts.append(uri(protocol, split_host_port(value.strip(), default_port)))
-            config['hosts'] = config_hosts
+                if isinstance(value, six.string_types):
+                    config['hosts'].append(uri(protocol, split_host_port(value.strip(), default_port)))
         elif 'host' in config:
             host, port = split_host_port(config['host'], 2379)
             config['host'] = host
@@ -577,10 +502,8 @@ class AbstractEtcd(AbstractDCS):
 
         dns_resolver = DnsCachingResolver()
 
-        def create_connection_patched(
-                address: Tuple[str, int], timeout: Any = object(),
-                source_address: Optional[Any] = None, socket_options: Optional[Collection[Tuple[int, int, int]]] = None
-        ) -> socket.socket:
+        def create_connection_patched(address, timeout=socket._GLOBAL_DEFAULT_TIMEOUT,
+                                      source_address=None, socket_options=None):
             host, port = address
             if host.startswith('['):
                 host = host.strip('[]')
@@ -590,7 +513,7 @@ class AbstractEtcd(AbstractDCS):
                 try:
                     sock = socket.socket(af, socktype, proto)
                     self.set_socket_options(sock, socket_options)
-                    if timeout is None or isinstance(timeout, (float, int)):
+                    if timeout is not socket._GLOBAL_DEFAULT_TIMEOUT:
                         sock.settimeout(timeout)
                     if source_address:
                         sock.bind(source_address)
@@ -621,228 +544,196 @@ class AbstractEtcd(AbstractDCS):
                 time.sleep(5)
         return client
 
-    def set_ttl(self, ttl: int) -> Optional[bool]:
+    def set_ttl(self, ttl):
         ttl = int(ttl)
         ret = self._ttl != ttl
         self._ttl = ttl
-        self._client.set_machines_cache_ttl(ttl * 10)
+        self._client.set_machines_cache_ttl(ttl*10)
         return ret
 
     @property
-    def ttl(self) -> int:
+    def ttl(self):
         return self._ttl
 
-    def set_retry_timeout(self, retry_timeout: int) -> None:
+    def set_retry_timeout(self, retry_timeout):
         self._retry.deadline = retry_timeout
         self._client.set_read_timeout(retry_timeout)
 
 
-def catch_etcd_errors(func: Callable[..., Any]) -> Any:
-    def wrapper(self: AbstractEtcd, *args: Any, **kwargs: Any) -> Any:
-        return self.handle_etcd_exceptions(func, *args, **kwargs)
+def catch_etcd_errors(func):
+    def wrapper(self, *args, **kwargs):
+        try:
+            retval = func(self, *args, **kwargs) is not None
+            self._has_failed = False
+            return retval
+        except (RetryFailedError, etcd.EtcdException) as e:
+            self._handle_exception(e)
+            return False
+        except Exception as e:
+            self._handle_exception(e, raise_ex=self._client.ERROR_CLS('unexpected error'))
+
     return wrapper
 
 
 class Etcd(AbstractEtcd):
 
-    def __init__(self, config: Dict[str, Any]) -> None:
+    def __init__(self, config):
         super(Etcd, self).__init__(config, EtcdClient, (etcd.EtcdLeaderElectionInProgress, EtcdRaftInternal))
         self.__do_not_watch = False
 
-    @property
-    def _client(self) -> EtcdClient:
-        if TYPE_CHECKING:  # pragma: no cover
-            assert isinstance(self._abstract_client, EtcdClient)
-        return self._abstract_client
-
-    def set_ttl(self, ttl: int) -> Optional[bool]:
+    def set_ttl(self, ttl):
         self.__do_not_watch = super(Etcd, self).set_ttl(ttl)
-        return None
 
     @staticmethod
-    def member(node: etcd.EtcdResult) -> Member:
+    def member(node):
         return Member.from_node(node.modifiedIndex, os.path.basename(node.key), node.ttl, node.value)
 
-    def _cluster_from_nodes(self, etcd_index: int, nodes: Dict[str, etcd.EtcdResult]) -> Cluster:
-        # get initialize flag
-        initialize = nodes.get(self._INITIALIZE)
-        initialize = initialize and initialize.value
-
-        # get global dynamic configuration
-        config = nodes.get(self._CONFIG)
-        config = config and ClusterConfig.from_node(config.modifiedIndex, config.value)
-
-        # get timeline history
-        history = nodes.get(self._HISTORY)
-        history = history and TimelineHistory.from_node(history.modifiedIndex, history.value)
-
-        # get last know leader lsn and slots
-        status = nodes.get(self._STATUS)
-        if status:
-            try:
-                status = json.loads(status.value)
-                last_lsn = status.get(self._OPTIME)
-                slots = status.get('slots')
-            except Exception:
-                slots = last_lsn = None
-        else:
-            last_lsn = nodes.get(self._LEADER_OPTIME)
-            last_lsn = last_lsn and last_lsn.value
-            slots = None
-
-        try:
-            last_lsn = int(last_lsn or '')
-        except Exception:
-            last_lsn = 0
-
-        # get list of members
-        members = [self.member(n) for k, n in nodes.items() if k.startswith(self._MEMBERS) and k.count('/') == 1]
-
-        # get leader
-        leader = nodes.get(self._LEADER)
-        if leader:
-            member = Member(-1, leader.value, None, {})
-            member = ([m for m in members if m.name == leader.value] or [member])[0]
-            version = etcd_index if etcd_index > leader.modifiedIndex else leader.modifiedIndex + 1
-            leader = Leader(version, leader.ttl, member)
-
-        # failover key
-        failover = nodes.get(self._FAILOVER)
-        if failover:
-            failover = Failover.from_node(failover.modifiedIndex, failover.value)
-
-        # get synchronization state
-        sync = nodes.get(self._SYNC)
-        sync = SyncState.from_node(sync and sync.modifiedIndex, sync and sync.value)
-
-        # get failsafe topology
-        failsafe = nodes.get(self._FAILSAFE)
-        try:
-            failsafe = json.loads(failsafe.value) if failsafe else None
-        except Exception:
-            failsafe = None
-
-        return Cluster(initialize, config, leader, last_lsn, members, failover, sync, history, slots, failsafe)
-
-    def _cluster_loader(self, path: str) -> Cluster:
-        result = self.retry(self._client.read, path, recursive=True, quorum=self._ctl)
-        nodes = {node.key[len(result.key):].lstrip('/'): node for node in result.leaves}
-        return self._cluster_from_nodes(result.etcd_index, nodes)
-
-    def _citus_cluster_loader(self, path: str) -> Dict[int, Cluster]:
-        clusters: Dict[int, Dict[str, etcd.EtcdResult]] = defaultdict(dict)
-        result = self.retry(self._client.read, path, recursive=True, quorum=self._ctl)
-        for node in result.leaves:
-            key = node.key[len(result.key):].lstrip('/').split('/', 1)
-            if len(key) == 2 and citus_group_re.match(key[0]):
-                clusters[int(key[0])][key[1]] = node
-        return {group: self._cluster_from_nodes(result.etcd_index, nodes) for group, nodes in clusters.items()}
-
-    def _load_cluster(
-            self, path: str, loader: Callable[[str], Union[Cluster, Dict[int, Cluster]]]
-    ) -> Union[Cluster, Dict[int, Cluster]]:
+    def _load_cluster(self):
         cluster = None
         try:
-            cluster = loader(path)
+            result = self.retry(self._client.read, self.client_path(''), recursive=True)
+            nodes = {node.key[len(result.key):].lstrip('/'): node for node in result.leaves}
+
+            # get initialize flag
+            initialize = nodes.get(self._INITIALIZE)
+            initialize = initialize and initialize.value
+
+            # get global dynamic configuration
+            config = nodes.get(self._CONFIG)
+            config = config and ClusterConfig.from_node(config.modifiedIndex, config.value)
+
+            # get timeline history
+            history = nodes.get(self._HISTORY)
+            history = history and TimelineHistory.from_node(history.modifiedIndex, history.value)
+
+            # get last know leader lsn and slots
+            status = nodes.get(self._STATUS)
+            if status:
+                try:
+                    status = json.loads(status.value)
+                    last_lsn = status.get(self._OPTIME)
+                    slots = status.get('slots')
+                except Exception:
+                    slots = last_lsn = None
+            else:
+                last_lsn = nodes.get(self._LEADER_OPTIME)
+                last_lsn = last_lsn and last_lsn.value
+                slots = None
+
+            try:
+                last_lsn = int(last_lsn)
+            except Exception:
+                last_lsn = 0
+
+            # get list of members
+            members = [self.member(n) for k, n in nodes.items() if k.startswith(self._MEMBERS) and k.count('/') == 1]
+
+            # get leader
+            leader = nodes.get(self._LEADER)
+            if leader:
+                member = Member(-1, leader.value, None, {})
+                member = ([m for m in members if m.name == leader.value] or [member])[0]
+                index = result.etcd_index if result.etcd_index > leader.modifiedIndex else leader.modifiedIndex + 1
+                leader = Leader(index, leader.ttl, member)
+
+            # failover key
+            failover = nodes.get(self._FAILOVER)
+            if failover:
+                failover = Failover.from_node(failover.modifiedIndex, failover.value)
+
+            # get synchronization state
+            sync = nodes.get(self._SYNC)
+            sync = SyncState.from_node(sync and sync.modifiedIndex, sync and sync.value)
+
+            cluster = Cluster(initialize, config, leader, last_lsn, members, failover, sync, history, slots)
         except etcd.EtcdKeyNotFound:
-            cluster = Cluster.empty()
+            cluster = Cluster(None, None, None, None, [], None, None, None, None)
         except Exception as e:
             self._handle_exception(e, 'get_cluster', raise_ex=EtcdError('Etcd is not responding properly'))
         self._has_failed = False
-        if TYPE_CHECKING:  # pragma: no cover
-            assert cluster is not None
         return cluster
 
     @catch_etcd_errors
-    def touch_member(self, data: Dict[str, Any]) -> bool:
-        value = json.dumps(data, separators=(',', ':'))
-        return bool(self._client.set(self.member_path, value, self._ttl))
+    def touch_member(self, data, permanent=False):
+        data = json.dumps(data, separators=(',', ':'))
+        return self._client.set(self.member_path, data, None if permanent else self._ttl)
 
     @catch_etcd_errors
-    def take_leader(self) -> bool:
+    def take_leader(self):
         return self.retry(self._client.write, self.leader_path, self._name, ttl=self._ttl)
 
-    def _do_attempt_to_acquire_leader(self) -> bool:
+    def attempt_to_acquire_leader(self, permanent=False):
         try:
-            return bool(self.retry(self._client.write, self.leader_path, self._name, ttl=self._ttl, prevExist=False))
+            return bool(self.retry(self._client.write,
+                                   self.leader_path,
+                                   self._name,
+                                   ttl=None if permanent else self._ttl,
+                                   prevExist=False))
         except etcd.EtcdAlreadyExist:
             logger.info('Could not take out TTL lock')
-            return False
-
-    @catch_return_false_exception
-    def attempt_to_acquire_leader(self) -> bool:
-        return self._run_and_handle_exceptions(self._do_attempt_to_acquire_leader, retry=None)
+        except (RetryFailedError, etcd.EtcdException):
+            pass
+        return False
 
     @catch_etcd_errors
-    def set_failover_value(self, value: str, version: Optional[int] = None) -> bool:
-        return bool(self._client.write(self.failover_path, value, prevIndex=version or 0))
+    def set_failover_value(self, value, index=None):
+        return self._client.write(self.failover_path, value, prevIndex=index or 0)
 
     @catch_etcd_errors
-    def set_config_value(self, value: str, version: Optional[int] = None) -> bool:
-        return bool(self._client.write(self.config_path, value, prevIndex=version or 0))
+    def set_config_value(self, value, index=None):
+        return self._client.write(self.config_path, value, prevIndex=index or 0)
 
     @catch_etcd_errors
-    def _write_leader_optime(self, last_lsn: str) -> bool:
-        return bool(self._client.set(self.leader_optime_path, last_lsn))
+    def _write_leader_optime(self, last_lsn):
+        return self._client.set(self.leader_optime_path, last_lsn)
 
     @catch_etcd_errors
-    def _write_status(self, value: str) -> bool:
-        return bool(self._client.set(self.status_path, value))
-
-    def _do_update_leader(self) -> bool:
-        try:
-            return self.retry(self._client.write, self.leader_path, self._name,
-                              prevValue=self._name, ttl=self._ttl) is not None
-        except etcd.EtcdKeyNotFound:
-            return self._do_attempt_to_acquire_leader()
+    def _write_status(self, value):
+        return self._client.set(self.status_path, value)
 
     @catch_etcd_errors
-    def _write_failsafe(self, value: str) -> bool:
-        return bool(self._client.set(self.failsafe_path, value))
-
-    @catch_return_false_exception
-    def _update_leader(self, leader: Leader) -> bool:
-        return bool(self._run_and_handle_exceptions(self._do_update_leader, retry=None))
+    def _update_leader(self):
+        return self.retry(self._client.write, self.leader_path, self._name, prevValue=self._name, ttl=self._ttl)
 
     @catch_etcd_errors
-    def initialize(self, create_new: bool = True, sysid: str = "") -> bool:
-        return bool(self.retry(self._client.write, self.initialize_path, sysid, prevExist=(not create_new)))
+    def initialize(self, create_new=True, sysid=""):
+        return self.retry(self._client.write, self.initialize_path, sysid, prevExist=(not create_new))
 
     @catch_etcd_errors
-    def _delete_leader(self, leader: Leader) -> bool:
-        return bool(self._client.delete(self.leader_path, prevValue=self._name))
+    def _delete_leader(self):
+        return self._client.delete(self.leader_path, prevValue=self._name)
 
     @catch_etcd_errors
-    def cancel_initialization(self) -> bool:
-        return bool(self.retry(self._client.delete, self.initialize_path))
+    def cancel_initialization(self):
+        return self.retry(self._client.delete, self.initialize_path)
 
     @catch_etcd_errors
-    def delete_cluster(self) -> bool:
-        return bool(self.retry(self._client.delete, self.client_path(''), recursive=True))
+    def delete_cluster(self):
+        return self.retry(self._client.delete, self.client_path(''), recursive=True)
 
     @catch_etcd_errors
-    def set_history_value(self, value: str) -> bool:
-        return bool(self._client.write(self.history_path, value))
+    def set_history_value(self, value):
+        return self._client.write(self.history_path, value)
 
     @catch_etcd_errors
-    def set_sync_state_value(self, value: str, version: Optional[int] = None) -> Union[int, bool]:
-        return self.retry(self._client.write, self.sync_path, value, prevIndex=version or 0).modifiedIndex
+    def set_sync_state_value(self, value, index=None):
+        return self.retry(self._client.write, self.sync_path, value, prevIndex=index or 0)
 
     @catch_etcd_errors
-    def delete_sync_state(self, version: Optional[int] = None) -> bool:
-        return bool(self.retry(self._client.delete, self.sync_path, prevIndex=version or 0))
+    def delete_sync_state(self, index=None):
+        return self.retry(self._client.delete, self.sync_path, prevIndex=index or 0)
 
-    def watch(self, leader_version: Optional[int], timeout: float) -> bool:
+    def watch(self, leader_index, timeout):
         if self.__do_not_watch:
             self.__do_not_watch = False
             return True
 
-        if leader_version:
+        if leader_index:
             end_time = time.time() + timeout
 
             while timeout >= 1:  # when timeout is too small urllib3 doesn't have enough time to connect
                 try:
-                    result = self._client.watch(self.leader_path, index=leader_version, timeout=timeout + 0.5)
+                    result = self._client.watch(self.leader_path, index=leader_index, timeout=timeout + 0.5)
                     self._has_failed = False
                     if result.action == 'compareAndSwap':
                         time.sleep(0.01)

patroni/dcs/exhibitor.py

@@ -3,12 +3,9 @@ import logging
 import random
 import time
 
-from typing import Any, Callable, Dict, List, Union
-
-from . import Cluster
-from .zookeeper import ZooKeeper
-from ..request import get as requests_get
-from ..utils import uri
+from patroni.dcs.zookeeper import ZooKeeper
+from patroni.request import get as requests_get
+from patroni.utils import uri
 
 logger = logging.getLogger(__name__)
 
@@ -17,31 +14,29 @@ class ExhibitorEnsembleProvider(object):
 
     TIMEOUT = 3.1
 
-    def __init__(self, hosts: List[str], port: int,
-                 uri_path: str = '/exhibitor/v1/cluster/list', poll_interval: int = 300) -> None:
+    def __init__(self, hosts, port, uri_path='/exhibitor/v1/cluster/list', poll_interval=300):
         self._exhibitor_port = port
         self._uri_path = uri_path
         self._poll_interval = poll_interval
-        self._exhibitors: List[str] = hosts
-        self._boot_exhibitors = hosts
+        self._exhibitors = hosts
+        self._master_exhibitors = hosts
         self._zookeeper_hosts = ''
         self._next_poll = None
         while not self.poll():
             logger.info('waiting on exhibitor')
             time.sleep(5)
 
-    def poll(self) -> bool:
+    def poll(self):
         if self._next_poll and self._next_poll > time.time():
             return False
 
         json = self._query_exhibitors(self._exhibitors)
         if not json:
-            json = self._query_exhibitors(self._boot_exhibitors)
+            json = self._query_exhibitors(self._master_exhibitors)
 
         if isinstance(json, dict) and 'servers' in json and 'port' in json:
             self._next_poll = time.time() + self._poll_interval
-            servers: List[str] = json['servers']
-            zookeeper_hosts = ','.join([h + ':' + str(json['port']) for h in sorted(servers)])
+            zookeeper_hosts = ','.join([h + ':' + str(json['port']) for h in sorted(json['servers'])])
             if self._zookeeper_hosts != zookeeper_hosts:
                 logger.info('ZooKeeper connection string has changed: %s => %s', self._zookeeper_hosts, zookeeper_hosts)
                 self._zookeeper_hosts = zookeeper_hosts
@@ -49,7 +44,7 @@ class ExhibitorEnsembleProvider(object):
                 return True
         return False
 
-    def _query_exhibitors(self, exhibitors: List[str]) -> Union[Dict[str, Any], Any]:
+    def _query_exhibitors(self, exhibitors):
         random.shuffle(exhibitors)
         for host in exhibitors:
             try:
@@ -60,20 +55,20 @@ class ExhibitorEnsembleProvider(object):
         return None
 
     @property
-    def zookeeper_hosts(self) -> str:
+    def zookeeper_hosts(self):
         return self._zookeeper_hosts
 
 
 class Exhibitor(ZooKeeper):
 
-    def __init__(self, config: Dict[str, Any]) -> None:
+    def __init__(self, config):
         interval = config.get('poll_interval', 300)
         self._ensemble_provider = ExhibitorEnsembleProvider(config['hosts'], config['port'], poll_interval=interval)
-        super(Exhibitor, self).__init__({**config, 'hosts': self._ensemble_provider.zookeeper_hosts})
+        config = config.copy()
+        config['hosts'] = self._ensemble_provider.zookeeper_hosts
+        super(Exhibitor, self).__init__(config)
 
-    def _load_cluster(
-            self, path: str, loader: Callable[[str], Union[Cluster, Dict[int, Cluster]]]
-    ) -> Union[Cluster, Dict[int, Cluster]]:
+    def _load_cluster(self):
         if self._ensemble_provider.poll():
             self._client.set_hosts(self._ensemble_provider.zookeeper_hosts)
-        return super(Exhibitor, self)._load_cluster(path, loader)
+        return super(Exhibitor, self)._load_cluster()

patroni/dcs/raft.py

@@ -4,35 +4,25 @@ import os
 import threading
 import time
 
-from collections import defaultdict
 from pysyncobj import SyncObj, SyncObjConf, replicated, FAIL_REASON
 from pysyncobj.dns_resolver import globalDnsResolver
 from pysyncobj.node import TCPNode
 from pysyncobj.transport import TCPTransport, CONNECTION_STATE
 from pysyncobj.utility import TcpUtility
-from typing import Any, Callable, Collection, Dict, List, Optional, Set, Union, TYPE_CHECKING
 
-from . import AbstractDCS, ClusterConfig, Cluster, Failover, Leader, Member, SyncState, TimelineHistory, citus_group_re
-from ..exceptions import DCSError
+from . import AbstractDCS, ClusterConfig, Cluster, Failover, Leader, Member, SyncState, TimelineHistory
 from ..utils import validate_directory
-if TYPE_CHECKING:  # pragma: no cover
-    from ..config import Config
 
 logger = logging.getLogger(__name__)
 
 
-class RaftError(DCSError):
-    pass
-
-
 class _TCPTransport(TCPTransport):
 
-    def __init__(self, syncObj: 'DynMemberSyncObj', selfNode: Optional[TCPNode],
-                 otherNodes: Collection[TCPNode]) -> None:
+    def __init__(self, syncObj, selfNode, otherNodes):
         super(_TCPTransport, self).__init__(syncObj, selfNode, otherNodes)
         self.setOnUtilityMessageCallback('members', syncObj.getMembers)
 
-    def _connectIfNecessarySingle(self, node: TCPNode) -> bool:
+    def _connectIfNecessarySingle(self, node):
         try:
             return super(_TCPTransport, self)._connectIfNecessarySingle(node)
         except Exception as e:
@@ -40,7 +30,7 @@ class _TCPTransport(TCPTransport):
             return False
 
 
-def resolve_host(self: TCPNode) -> Optional[str]:
+def resolve_host(self):
     return globalDnsResolver().resolve(self.host)
 
 
@@ -49,19 +39,17 @@ setattr(TCPNode, 'ip', property(resolve_host))
 
 class SyncObjUtility(object):
 
-    def __init__(self, otherNodes: Collection[Union[str, TCPNode]], conf: SyncObjConf, retry_timeout: int = 10) -> None:
+    def __init__(self, otherNodes, conf):
         self._nodes = otherNodes
-        self._utility = TcpUtility(conf.password, retry_timeout / max(1, len(otherNodes)))
-        self.__node = next(iter(otherNodes), None)
+        self._utility = TcpUtility(conf.password)
 
-    def executeCommand(self, command: List[Any]) -> Any:
+    def executeCommand(self, command):
         try:
-            if self.__node:
-                return self._utility.executeCommand(self.__node, command)
+            return self._utility.executeCommand(self.__node, command)
         except Exception:
             return None
 
-    def getMembers(self) -> Optional[List[str]]:
+    def getMembers(self):
         for self.__node in self._nodes:
             response = self.executeCommand(['members'])
             if response:
@@ -70,12 +58,11 @@ class SyncObjUtility(object):
 
 class DynMemberSyncObj(SyncObj):
 
-    def __init__(self, selfAddress: Optional[str], partnerAddrs: Collection[str],
-                 conf: SyncObjConf, retry_timeout: int = 10) -> None:
+    def __init__(self, selfAddress, partnerAddrs, conf):
         self.__early_apply_local_log = selfAddress is not None
         self.applied_local_log = False
 
-        utility = SyncObjUtility(partnerAddrs, conf, retry_timeout)
+        utility = SyncObjUtility(partnerAddrs, conf)
         members = utility.getMembers()
         add_self = members and selfAddress not in members
 
@@ -88,12 +75,12 @@ class DynMemberSyncObj(SyncObj):
             thread.daemon = True
             thread.start()
 
-    def getMembers(self, args: Any, callback: Callable[[Any, Any], Any]) -> None:
+    def getMembers(self, args, callback):
         callback([{'addr': node.id, 'leader': node == self._getLeader(), 'status': CONNECTION_STATE.CONNECTED
-                   if self.isNodeConnected(node) else CONNECTION_STATE.DISCONNECTED} for node in self.otherNodes]
-                 + [{'addr': self.selfNode.id, 'leader': self._isLeader(), 'status': CONNECTION_STATE.CONNECTED}], None)
+                   if self.isNodeConnected(node) else CONNECTION_STATE.DISCONNECTED} for node in self.otherNodes] +
+                 [{'addr': self.selfNode.id, 'leader': self._isLeader(), 'status': CONNECTION_STATE.CONNECTED}], None)
 
-    def _onTick(self, timeToWait: float = 0.0):
+    def _onTick(self, timeToWait=0.0):
         super(DynMemberSyncObj, self)._onTick(timeToWait)
 
         # The SyncObj calls onReady callback only when cluster got the leader and is ready for writes.
@@ -105,16 +92,15 @@ class DynMemberSyncObj(SyncObj):
 
 class KVStoreTTL(DynMemberSyncObj):
 
-    def __init__(self, on_ready: Optional[Callable[..., Any]], on_set: Optional[Callable[[str, Dict[str, Any]], None]],
-                 on_delete: Optional[Callable[[str], None]], **config: Any) -> None:
+    def __init__(self, on_ready, on_set, on_delete, **config):
         self.__thread = None
         self.__on_set = on_set
         self.__on_delete = on_delete
-        self.__limb: Dict[str, Dict[str, Any]] = {}
-        self.set_retry_timeout(int(config.get('retry_timeout') or 10))
+        self.__limb = {}
+        self.__retry_timeout = None
 
         self_addr = config.get('self_addr')
-        partner_addrs: Set[str] = set(config.get('partner_addrs', []))
+        partner_addrs = set(config.get('partner_addrs', []))
         if config.get('patronictl'):
             if self_addr:
                 partner_addrs.add(self_addr)
@@ -135,23 +121,23 @@ class KVStoreTTL(DynMemberSyncObj):
                            journalFile=(file_template + '.journal' if self_addr else None),
                            onReady=on_ready, dynamicMembershipChange=True)
 
-        super(KVStoreTTL, self).__init__(self_addr, partner_addrs, conf, self.__retry_timeout)
-        self.__data: Dict[str, Dict[str, Any]] = {}
+        super(KVStoreTTL, self).__init__(self_addr, partner_addrs, conf)
+        self.__data = {}
 
     @staticmethod
-    def __check_requirements(old_value: Dict[str, Any], **kwargs: Any) -> bool:
-        return bool(('prevExist' not in kwargs or bool(kwargs['prevExist']) == bool(old_value))
-                    and ('prevValue' not in kwargs or old_value and old_value['value'] == kwargs['prevValue'])
-                    and (kwargs.get('prevIndex') is None or old_value and old_value['index'] == kwargs['prevIndex']))
+    def __check_requirements(old_value, **kwargs):
+        return ('prevExist' not in kwargs or bool(kwargs['prevExist']) == bool(old_value)) and \
+            ('prevValue' not in kwargs or old_value and old_value['value'] == kwargs['prevValue']) and \
+            (not kwargs.get('prevIndex') or old_value and old_value['index'] == kwargs['prevIndex'])
 
-    def set_retry_timeout(self, retry_timeout: int) -> None:
+    def set_retry_timeout(self, retry_timeout):
         self.__retry_timeout = retry_timeout
 
-    def retry(self, func: Callable[..., Any], *args: Any, **kwargs: Any) -> Any:
+    def retry(self, func, *args, **kwargs):
         event = threading.Event()
         ret = {'result': None, 'error': -1}
 
-        def callback(result: Any, error: Any) -> None:
+        def callback(result, error):
             ret.update(result=result, error=error)
             event.set()
 
@@ -170,12 +156,12 @@ class KVStoreTTL(DynMemberSyncObj):
             elif deadline:
                 timeout = deadline - time.time()
                 if timeout <= 0:
-                    raise RaftError('timeout')
+                    break
             time.sleep(1)
         return False
 
     @replicated
-    def _set(self, key: str, value: Dict[str, Any], **kwargs: Any) -> Union[bool, Dict[str, Any]]:
+    def _set(self, key, value, **kwargs):
         old_value = self.__data.get(key, {})
         if not self.__check_requirements(old_value, **kwargs):
             return False
@@ -187,32 +173,26 @@ class KVStoreTTL(DynMemberSyncObj):
         self.__data[key] = value
         if self.__on_set:
             self.__on_set(key, value)
-        return value
+        return True
 
-    def set(self, key: str, value: str, ttl: Optional[int] = None,
-            handle_raft_error: bool = True, **kwargs: Any) -> Union[bool, Dict[str, Any]]:
+    def set(self, key, value, ttl=None, **kwargs):
         old_value = self.__data.get(key, {})
         if not self.__check_requirements(old_value, **kwargs):
             return False
 
-        data: Dict[str, Any] = {'value': value, 'updated': time.time()}
-        data['created'] = old_value.get('created', data['updated'])
+        value = {'value': value, 'updated': time.time()}
+        value['created'] = old_value.get('created', value['updated'])
         if ttl:
-            data['expire'] = data['updated'] + ttl
-        try:
-            return self.retry(self._set, key, data, **kwargs)
-        except RaftError:
-            if not handle_raft_error:
-                raise
-            return False
+            value['expire'] = value['updated'] + ttl
+        return self.retry(self._set, key, value, **kwargs)
 
-    def __pop(self, key: str) -> None:
+    def __pop(self, key):
         self.__data.pop(key)
         if self.__on_delete:
             self.__on_delete(key)
 
     @replicated
-    def _delete(self, key: str, recursive: bool = False, **kwargs: Any) -> bool:
+    def _delete(self, key, recursive=False, **kwargs):
         if recursive:
             for k in list(self.__data.keys()):
                 if k.startswith(key):
@@ -223,41 +203,38 @@ class KVStoreTTL(DynMemberSyncObj):
             self.__pop(key)
         return True
 
-    def delete(self, key: str, recursive: bool = False, **kwargs: Any) -> bool:
+    def delete(self, key, recursive=False, **kwargs):
         if not recursive and not self.__check_requirements(self.__data.get(key, {}), **kwargs):
             return False
-        try:
-            return self.retry(self._delete, key, recursive=recursive, **kwargs)
-        except RaftError:
-            return False
+        return self.retry(self._delete, key, recursive=recursive, **kwargs)
 
     @staticmethod
-    def __values_match(old: Dict[str, Any], new: Dict[str, Any]) -> bool:
+    def __values_match(old, new):
         return all(old.get(n) == new.get(n) for n in ('created', 'updated', 'expire', 'value'))
 
     @replicated
-    def _expire(self, key: str, value: Dict[str, Any], callback: Optional[Callable[..., Any]] = None) -> None:
+    def _expire(self, key, value, callback=None):
         current = self.__data.get(key)
         if current and self.__values_match(current, value):
             self.__pop(key)
 
-    def __expire_keys(self) -> None:
+    def __expire_keys(self):
         for key, value in self.__data.items():
             if value and 'expire' in value and value['expire'] <= time.time() and \
                     not (key in self.__limb and self.__values_match(self.__limb[key], value)):
                 self.__limb[key] = value
 
-                def callback(*args: Any) -> None:
+                def callback(*args):
                     if key in self.__limb and self.__values_match(self.__limb[key], value):
                         self.__limb.pop(key)
                 self._expire(key, value, callback=callback)
 
-    def get(self, key: str, recursive: bool = False) -> Union[None, Dict[str, Any], Dict[str, Dict[str, Any]]]:
+    def get(self, key, recursive=False):
         if not recursive:
             return self.__data.get(key)
         return {k: v for k, v in self.__data.items() if k.startswith(key)}
 
-    def _onTick(self, timeToWait: float = 0.0) -> None:
+    def _onTick(self, timeToWait=0.0):
         super(KVStoreTTL, self)._onTick(timeToWait)
 
         if self._isLeader():
@@ -265,17 +242,17 @@ class KVStoreTTL(DynMemberSyncObj):
         else:
             self.__limb.clear()
 
-    def _autoTickThread(self) -> None:
+    def _autoTickThread(self):
         self.__destroying = False
         while not self.__destroying:
             self.doTick(self.conf.autoTickPeriod)
 
-    def startAutoTick(self) -> None:
+    def startAutoTick(self):
         self.__thread = threading.Thread(target=self._autoTickThread)
         self.__thread.daemon = True
         self.__thread.start()
 
-    def destroy(self) -> None:
+    def destroy(self):
         if self.__thread:
             self.__destroying = True
             self.__thread.join()
@@ -284,7 +261,7 @@ class KVStoreTTL(DynMemberSyncObj):
 
 class Raft(AbstractDCS):
 
-    def __init__(self, config: Dict[str, Any]) -> None:
+    def __init__(self, config):
         super(Raft, self).__init__(config)
         self._ttl = int(config.get('ttl') or 30)
 
@@ -298,8 +275,9 @@ class Raft(AbstractDCS):
                 break
             else:
                 logger.info('waiting on raft')
+        self.set_retry_timeout(int(config.get('retry_timeout') or 10))
 
-    def _on_set(self, key: str, value: Dict[str, Any]) -> None:
+    def _on_set(self, key, value):
         leader = (self._sync_obj.get(self.leader_path) or {}).get('value')
         if key == value['created'] == value['updated'] and \
                 (key.startswith(self.members_path) or key == self.leader_path and leader != self._name) or \
@@ -307,29 +285,35 @@ class Raft(AbstractDCS):
                 key in (self.config_path, self.sync_path):
             self.event.set()
 
-    def _on_delete(self, key: str) -> None:
+    def _on_delete(self, key):
         if key == self.leader_path:
             self.event.set()
 
-    def set_ttl(self, ttl: int) -> Optional[bool]:
+    def set_ttl(self, ttl):
         self._ttl = ttl
 
     @property
-    def ttl(self) -> int:
+    def ttl(self):
         return self._ttl
 
-    def set_retry_timeout(self, retry_timeout: int) -> None:
+    def set_retry_timeout(self, retry_timeout):
         self._sync_obj.set_retry_timeout(retry_timeout)
 
-    def reload_config(self, config: Union['Config', Dict[str, Any]]) -> None:
+    def reload_config(self, config):
         super(Raft, self).reload_config(config)
         globalDnsResolver().setTimeouts(self.ttl, self.loop_wait)
 
     @staticmethod
-    def member(key: str, value: Dict[str, Any]) -> Member:
+    def member(key, value):
         return Member.from_node(value['index'], os.path.basename(key), None, value['value'])
 
-    def _cluster_from_nodes(self, nodes: Dict[str, Any]) -> Cluster:
+    def _load_cluster(self):
+        prefix = self.client_path('')
+        response = self._sync_obj.get(prefix, recursive=True)
+        if not response:
+            return Cluster(None, None, None, None, [], None, None, None, None)
+        nodes = {os.path.relpath(key, prefix).replace('\\', '/'): value for key, value in response.items()}
+
         # get initialize flag
         initialize = nodes.get(self._INITIALIZE)
         initialize = initialize and initialize['value']
@@ -357,7 +341,7 @@ class Raft(AbstractDCS):
             slots = None
 
         try:
-            last_lsn = int(last_lsn or '')
+            last_lsn = int(last_lsn)
         except Exception:
             last_lsn = 0
 
@@ -380,95 +364,60 @@ class Raft(AbstractDCS):
         sync = nodes.get(self._SYNC)
         sync = SyncState.from_node(sync and sync['index'], sync and sync['value'])
 
-        # get failsafe topology
-        failsafe = nodes.get(self._FAILSAFE)
-        try:
-            failsafe = json.loads(failsafe['value']) if failsafe else None
-        except Exception:
-            failsafe = None
+        return Cluster(initialize, config, leader, last_lsn, members, failover, sync, history, slots)
 
-        return Cluster(initialize, config, leader, last_lsn, members, failover, sync, history, slots, failsafe)
+    def _write_leader_optime(self, last_lsn):
+        return self._sync_obj.set(self.leader_optime_path, last_lsn, timeout=1)
 
-    def _cluster_loader(self, path: str) -> Cluster:
-        response = self._sync_obj.get(path, recursive=True)
-        if not response:
-            return Cluster.empty()
-        nodes = {key[len(path):]: value for key, value in response.items()}
-        return self._cluster_from_nodes(nodes)
+    def _write_status(self, value):
+        return self._sync_obj.set(self.status_path, value, timeout=1)
 
-    def _citus_cluster_loader(self, path: str) -> Dict[int, Cluster]:
-        clusters: Dict[int, Dict[str, Any]] = defaultdict(dict)
-        response = self._sync_obj.get(path, recursive=True)
-        for key, value in (response or {}).items():
-            key = key[len(path):].split('/', 1)
-            if len(key) == 2 and citus_group_re.match(key[0]):
-                clusters[int(key[0])][key[1]] = value
-        return {group: self._cluster_from_nodes(nodes) for group, nodes in clusters.items()}
-
-    def _load_cluster(
-            self, path: str, loader: Callable[[str], Union[Cluster, Dict[int, Cluster]]]
-    ) -> Union[Cluster, Dict[int, Cluster]]:
-        return loader(path)
-
-    def _write_leader_optime(self, last_lsn: str) -> bool:
-        return self._sync_obj.set(self.leader_optime_path, last_lsn, timeout=1) is not False
-
-    def _write_status(self, value: str) -> bool:
-        return self._sync_obj.set(self.status_path, value, timeout=1) is not False
-
-    def _write_failsafe(self, value: str) -> bool:
-        return self._sync_obj.set(self.failsafe_path, value, timeout=1) is not False
-
-    def _update_leader(self, leader: Leader) -> bool:
-        ret = self._sync_obj.set(self.leader_path, self._name, ttl=self._ttl,
-                                 handle_raft_error=False, prevValue=self._name) is not False
+    def _update_leader(self):
+        ret = self._sync_obj.set(self.leader_path, self._name, ttl=self._ttl, prevValue=self._name)
         if not ret and self._sync_obj.get(self.leader_path) is None:
             ret = self.attempt_to_acquire_leader()
         return ret
 
-    def attempt_to_acquire_leader(self) -> bool:
-        return self._sync_obj.set(self.leader_path, self._name, ttl=self._ttl,
-                                  handle_raft_error=False, prevExist=False) is not False
+    def attempt_to_acquire_leader(self, permanent=False):
+        return self._sync_obj.set(self.leader_path, self._name, prevExist=False,
+                                  ttl=None if permanent else self._ttl)
 
-    def set_failover_value(self, value: str, version: Optional[int] = None) -> bool:
-        return self._sync_obj.set(self.failover_path, value, prevIndex=version) is not False
+    def set_failover_value(self, value, index=None):
+        return self._sync_obj.set(self.failover_path, value, prevIndex=index)
 
-    def set_config_value(self, value: str, version: Optional[int] = None) -> bool:
-        return self._sync_obj.set(self.config_path, value, prevIndex=version) is not False
+    def set_config_value(self, value, index=None):
+        return self._sync_obj.set(self.config_path, value, prevIndex=index)
 
-    def touch_member(self, data: Dict[str, Any]) -> bool:
-        value = json.dumps(data, separators=(',', ':'))
-        return self._sync_obj.set(self.member_path, value, self._ttl, timeout=2) is not False
+    def touch_member(self, data, permanent=False):
+        data = json.dumps(data, separators=(',', ':'))
+        return self._sync_obj.set(self.member_path, data, None if permanent else self._ttl, timeout=2)
 
-    def take_leader(self) -> bool:
-        return self._sync_obj.set(self.leader_path, self._name, ttl=self._ttl) is not False
+    def take_leader(self):
+        return self._sync_obj.set(self.leader_path, self._name, ttl=self._ttl)
 
-    def initialize(self, create_new: bool = True, sysid: str = '') -> bool:
-        return self._sync_obj.set(self.initialize_path, sysid, prevExist=(not create_new)) is not False
+    def initialize(self, create_new=True, sysid=''):
+        return self._sync_obj.set(self.initialize_path, sysid, prevExist=(not create_new))
 
-    def _delete_leader(self, leader: Leader) -> bool:
+    def _delete_leader(self):
         return self._sync_obj.delete(self.leader_path, prevValue=self._name, timeout=1)
 
-    def cancel_initialization(self) -> bool:
+    def cancel_initialization(self):
         return self._sync_obj.delete(self.initialize_path)
 
-    def delete_cluster(self) -> bool:
+    def delete_cluster(self):
         return self._sync_obj.delete(self.client_path(''), recursive=True)
 
-    def set_history_value(self, value: str) -> bool:
-        return self._sync_obj.set(self.history_path, value) is not False
+    def set_history_value(self, value):
+        return self._sync_obj.set(self.history_path, value)
 
-    def set_sync_state_value(self, value: str, version: Optional[int] = None) -> Union[int, bool]:
-        ret = self._sync_obj.set(self.sync_path, value, prevIndex=version)
-        if isinstance(ret, dict):
-            return ret['index']
-        return ret
+    def set_sync_state_value(self, value, index=None):
+        return self._sync_obj.set(self.sync_path, value, prevIndex=index)
 
-    def delete_sync_state(self, version: Optional[int] = None) -> bool:
-        return self._sync_obj.delete(self.sync_path, prevIndex=version)
+    def delete_sync_state(self, index=None):
+        return self._sync_obj.delete(self.sync_path, prevIndex=index)
 
-    def watch(self, leader_version: Optional[int], timeout: float) -> bool:
+    def watch(self, leader_index, timeout):
         try:
-            return super(Raft, self).watch(leader_version, timeout)
+            return super(Raft, self).watch(leader_index, timeout)
         finally:
             self.event.clear()

patroni/dcs/zookeeper.py

@@ -1,22 +1,17 @@
 import json
 import logging
 import select
-import socket
 import time
 
 from kazoo.client import KazooClient, KazooState, KazooRetry
-from kazoo.exceptions import ConnectionClosedError, NoNodeError, NodeExistsError, SessionExpiredError
-from kazoo.handlers.threading import AsyncResult, SequentialThreadingHandler
-from kazoo.protocol.states import KeeperState, WatchedEvent, ZnodeStat
-from kazoo.retry import RetryFailedError
-from kazoo.security import ACL, make_acl
-from typing import Any, Callable, Dict, List, Optional, Union, Tuple, TYPE_CHECKING
+from kazoo.exceptions import NoNodeError, NodeExistsError, SessionExpiredError
+from kazoo.handlers.threading import SequentialThreadingHandler
+from kazoo.protocol.states import KeeperState
+from kazoo.security import make_acl
 
-from . import AbstractDCS, ClusterConfig, Cluster, Failover, Leader, Member, SyncState, TimelineHistory, citus_group_re
+from . import AbstractDCS, ClusterConfig, Cluster, Failover, Leader, Member, SyncState, TimelineHistory
 from ..exceptions import DCSError
 from ..utils import deep_compare
-if TYPE_CHECKING:  # pragma: no cover
-    from ..config import Config
 
 logger = logging.getLogger(__name__)
 
@@ -27,14 +22,14 @@ class ZooKeeperError(DCSError):
 
 class PatroniSequentialThreadingHandler(SequentialThreadingHandler):
 
-    def __init__(self, connect_timeout: Union[int, float]) -> None:
+    def __init__(self, connect_timeout):
         super(PatroniSequentialThreadingHandler, self).__init__()
         self.set_connect_timeout(connect_timeout)
 
-    def set_connect_timeout(self, connect_timeout: Union[int, float]) -> None:
-        self._connect_timeout = max(1.0, connect_timeout / 2.0)  # try to connect to zookeeper node during loop_wait/2
+    def set_connect_timeout(self, connect_timeout):
+        self._connect_timeout = max(1.0, connect_timeout/2.0)  # try to connect to zookeeper node during loop_wait/2
 
-    def create_connection(self, *args: Any, **kwargs: Any) -> socket.socket:
+    def create_connection(self, *args, **kwargs):
         """This method is trying to establish connection with one of the zookeeper nodes.
            Somehow strategy "fail earlier and retry more often" works way better comparing to
            the original strategy "try to connect with specified timeout".
@@ -45,34 +40,26 @@ class PatroniSequentialThreadingHandler(SequentialThreadingHandler):
         :param args: always contains `tuple(host, port)` as the first element and could contain
                      `connect_timeout` (negotiated session timeout) as the second element."""
 
-        args_list: List[Any] = list(args)
-        if len(args_list) == 0:  # kazoo 2.6.0 slightly changed the way how it calls create_connection method
-            kwargs['timeout'] = max(self._connect_timeout, kwargs.get('timeout', self._connect_timeout * 10) / 10.0)
-        elif len(args_list) == 1:
-            args_list.append(self._connect_timeout)
+        args = list(args)
+        if len(args) == 0:  # kazoo 2.6.0 slightly changed the way how it calls create_connection method
+            kwargs['timeout'] = max(self._connect_timeout, kwargs.get('timeout', self._connect_timeout*10)/10.0)
+        elif len(args) == 1:
+            args.append(self._connect_timeout)
         else:
-            args_list[1] = max(self._connect_timeout, args_list[1] / 10.0)
-        return super(PatroniSequentialThreadingHandler, self).create_connection(*args_list, **kwargs)
-
-    def select(self, *args: Any, **kwargs: Any) -> Any:
-        """
-        Python 3.XY may raise following exceptions if select/poll are called with an invalid socket:
-        - `ValueError`: because fd == -1
-        - `TypeError`: Invalid file descriptor: -1 (starting from kazoo 2.9)
-        Python 2.7 may raise the `IOError` instead of `socket.error` (starting from kazoo 2.9)
-
-        When it is appropriate we map these exceptions to `socket.error`.
-        """
+            args[1] = max(self._connect_timeout, args[1]/10.0)
+        return super(PatroniSequentialThreadingHandler, self).create_connection(*args, **kwargs)
 
+    def select(self, *args, **kwargs):
+        """Python3 raises `ValueError` if socket is closed, because fd == -1"""
         try:
             return super(PatroniSequentialThreadingHandler, self).select(*args, **kwargs)
-        except (TypeError, ValueError) as e:
+        except ValueError as e:
             raise select.error(9, str(e))
 
 
 class PatroniKazooClient(KazooClient):
 
-    def _call(self, request: Tuple[Any], async_object: AsyncResult) -> Optional[bool]:
+    def _call(self, request, async_object):
         # Before kazoo==2.7.0 it wasn't possible to send requests to zookeeper if
         # the connection is in the SUSPENDED state and Patroni was strongly relying on it.
         # The https://github.com/python-zk/kazoo/pull/588 changed it, and now such requests are queued.
@@ -86,7 +73,7 @@ class PatroniKazooClient(KazooClient):
 
 class ZooKeeper(AbstractDCS):
 
-    def __init__(self, config: Dict[str, Any]) -> None:
+    def __init__(self, config):
         super(ZooKeeper, self).__init__(config)
 
         hosts = config.get('hosts', [])
@@ -98,18 +85,17 @@ class ZooKeeper(AbstractDCS):
         kwargs = {v: config[k] for k, v in mapping.items() if k in config}
 
         if 'set_acls' in config:
-            default_acl: List[ACL] = []
+            kwargs['default_acl'] = []
             for principal, permissions in config['set_acls'].items():
                 normalizedPermissions = [p.upper() for p in permissions]
-                default_acl.append(make_acl(scheme='x509',
-                                            credential=principal,
-                                            read='READ' in normalizedPermissions,
-                                            write='WRITE' in normalizedPermissions,
-                                            create='CREATE' in normalizedPermissions,
-                                            delete='DELETE' in normalizedPermissions,
-                                            admin='ADMIN' in normalizedPermissions,
-                                            all='ALL' in normalizedPermissions))
-            kwargs['default_acl'] = default_acl
+                kwargs['default_acl'].append(make_acl(scheme='x509',
+                                                      credential=principal,
+                                                      read='READ' in normalizedPermissions,
+                                                      write='WRITE' in normalizedPermissions,
+                                                      create='CREATE' in normalizedPermissions,
+                                                      delete='DELETE' in normalizedPermissions,
+                                                      admin='ADMIN' in normalizedPermissions,
+                                                      all='ALL' in normalizedPermissions))
 
         self._client = PatroniKazooClient(hosts, handler=PatroniSequentialThreadingHandler(config['retry_timeout']),
                                           timeout=config['ttl'], connection_retry=KazooRetry(max_delay=1, max_tries=-1,
@@ -117,16 +103,16 @@ class ZooKeeper(AbstractDCS):
                                           deadline=config['retry_timeout'], sleep_func=time.sleep), **kwargs)
         self._client.add_listener(self.session_listener)
 
-        self._fetch_cluster: bool = True
-        self._fetch_status: bool = True
-        self.__last_member_data: Optional[Dict[str, Any]] = None
+        self._fetch_cluster = True
+        self._fetch_status = True
+        self.__last_member_data = None
 
         self._orig_kazoo_connect = self._client._connection._connect
         self._client._connection._connect = self._kazoo_connect
 
         self._client.start()
 
-    def _kazoo_connect(self, *args: Any) -> Tuple[Union[int, float], Union[int, float]]:
+    def _kazoo_connect(self, *args):
         """Kazoo is using Ping's to determine health of connection to zookeeper. If there is no
         response on Ping after Ping interval (1/2 from read_timeout) it will consider current
         connection dead and try to connect to another node. Without this "magic" it was taking
@@ -139,30 +125,28 @@ class ZooKeeper(AbstractDCS):
         `write_leader_optime()` methods, which also may hang..."""
 
         ret = self._orig_kazoo_connect(*args)
-        return max(self.loop_wait - 2, 2) * 1000, ret[1]
+        return max(self.loop_wait - 2, 2)*1000, ret[1]
 
-    def session_listener(self, state: str) -> None:
+    def session_listener(self, state):
         if state in [KazooState.SUSPENDED, KazooState.LOST]:
             self.cluster_watcher(None)
 
-    def status_watcher(self, event: Optional[WatchedEvent]) -> None:
+    def status_watcher(self, event):
         self._fetch_status = True
         self.event.set()
 
-    def cluster_watcher(self, event: Optional[WatchedEvent]) -> None:
+    def cluster_watcher(self, event):
         self._fetch_cluster = True
-        if not event or event.state != KazooState.CONNECTED or event.path.startswith(self.client_path('')):
-            self.status_watcher(event)
+        self.status_watcher(event)
 
-    def reload_config(self, config: Union['Config', Dict[str, Any]]) -> None:
+    def reload_config(self, config):
         self.set_retry_timeout(config['retry_timeout'])
 
         loop_wait = config['loop_wait']
 
         loop_wait_changed = self._loop_wait != loop_wait
         self._loop_wait = loop_wait
-        if isinstance(self._client.handler, PatroniSequentialThreadingHandler):
-            self._client.handler.set_connect_timeout(loop_wait)
+        self._client.handler.set_connect_timeout(loop_wait)
 
         # We need to reestablish connection to zookeeper if we want to change
         # read_timeout (and Ping interval respectively), because read_timeout
@@ -173,7 +157,7 @@ class ZooKeeper(AbstractDCS):
         if not self.set_ttl(config['ttl']) and loop_wait_changed:
             self._client._connection._socket.close()
 
-    def set_ttl(self, ttl: int) -> Optional[bool]:
+    def set_ttl(self, ttl):
         """It is not possible to change ttl (session_timeout) in zookeeper without
         destroying old session and creating the new one. This method returns `!True`
         if session_timeout has been changed (`restart()` has been called)."""
@@ -184,26 +168,24 @@ class ZooKeeper(AbstractDCS):
             return True
 
     @property
-    def ttl(self) -> int:
-        return int(self._client._session_timeout / 1000.0)
+    def ttl(self):
+        return self._client._session_timeout / 1000.0
 
-    def set_retry_timeout(self, retry_timeout: int) -> None:
+    def set_retry_timeout(self, retry_timeout):
         retry = self._client.retry if isinstance(self._client.retry, KazooRetry) else self._client._retry
         retry.deadline = retry_timeout
 
-    def get_node(
-            self, key: str, watch: Optional[Callable[[WatchedEvent], None]] = None
-    ) -> Optional[Tuple[str, ZnodeStat]]:
+    def get_node(self, key, watch=None):
         try:
             ret = self._client.get(key, watch)
             return (ret[0].decode('utf-8'), ret[1])
         except NoNodeError:
             return None
 
-    def get_status(self, path: str, leader: Optional[Leader]) -> Tuple[int, Optional[Dict[str, int]]]:
+    def get_status(self, leader):
         watch = self.status_watcher if not leader or leader.name != self._name else None
 
-        status = self.get_node(path + self._STATUS, watch)
+        status = self.get_node(self.status_path, watch)
         if status:
             try:
                 status = json.loads(status[0])
@@ -212,12 +194,12 @@ class ZooKeeper(AbstractDCS):
             except Exception:
                 slots = last_lsn = None
         else:
-            last_lsn = self.get_node(path + self._LEADER_OPTIME, watch)
+            last_lsn = self.get_node(self.leader_optime_path, watch)
             last_lsn = last_lsn and last_lsn[0]
             slots = None
 
         try:
-            last_lsn = int(last_lsn or '')
+            last_lsn = int(last_lsn)
         except Exception:
             last_lsn = 0
 
@@ -225,89 +207,78 @@ class ZooKeeper(AbstractDCS):
         return last_lsn, slots
 
     @staticmethod
-    def member(name: str, value: str, znode: ZnodeStat) -> Member:
+    def member(name, value, znode):
         return Member.from_node(znode.version, name, znode.ephemeralOwner, value)
 
-    def get_children(self, key: str, watch: Optional[Callable[[WatchedEvent], None]] = None) -> List[str]:
+    def get_children(self, key, watch=None):
         try:
             return self._client.get_children(key, watch)
         except NoNodeError:
             return []
 
-    def load_members(self, path: str) -> List[Member]:
-        members: List[Member] = []
-        for member in self.get_children(path + self._MEMBERS, self.cluster_watcher):
-            data = self.get_node(path + self._MEMBERS + member)
+    def load_members(self):
+        members = []
+        for member in self.get_children(self.members_path, self.cluster_watcher):
+            data = self.get_node(self.members_path + member)
             if data is not None:
                 members.append(self.member(member, *data))
         return members
 
-    def _cluster_loader(self, path: str) -> Cluster:
+    def _inner_load_cluster(self):
         self._fetch_cluster = False
         self.event.clear()
-        nodes = set(self.get_children(path, self.cluster_watcher))
+        nodes = set(self.get_children(self.client_path(''), self.cluster_watcher))
         if not nodes:
             self._fetch_cluster = True
 
         # get initialize flag
-        initialize = (self.get_node(path + self._INITIALIZE) or [None])[0] if self._INITIALIZE in nodes else None
+        initialize = (self.get_node(self.initialize_path) or [None])[0] if self._INITIALIZE in nodes else None
 
         # get global dynamic configuration
-        config = self.get_node(path + self._CONFIG, watch=self.cluster_watcher) if self._CONFIG in nodes else None
+        config = self.get_node(self.config_path, watch=self.cluster_watcher) if self._CONFIG in nodes else None
         config = config and ClusterConfig.from_node(config[1].version, config[0], config[1].mzxid)
 
         # get timeline history
-        history = self.get_node(path + self._HISTORY, watch=self.cluster_watcher) if self._HISTORY in nodes else None
+        history = self.get_node(self.history_path, watch=self.cluster_watcher) if self._HISTORY in nodes else None
         history = history and TimelineHistory.from_node(history[1].mzxid, history[0])
 
         # get synchronization state
-        sync = self.get_node(path + self._SYNC, watch=self.cluster_watcher) if self._SYNC in nodes else None
+        sync = self.get_node(self.sync_path, watch=self.cluster_watcher) if self._SYNC in nodes else None
         sync = SyncState.from_node(sync and sync[1].version, sync and sync[0])
 
         # get list of members
-        members = self.load_members(path) if self._MEMBERS[:-1] in nodes else []
+        members = self.load_members() if self._MEMBERS[:-1] in nodes else []
 
         # get leader
-        leader = self.get_node(path + self._LEADER) if self._LEADER in nodes else None
+        leader = self.get_node(self.leader_path) if self._LEADER in nodes else None
         if leader:
-            member = Member(-1, leader[0], None, {})
-            member = ([m for m in members if m.name == leader[0]] or [member])[0]
-            leader = Leader(leader[1].version, leader[1].ephemeralOwner, member)
-            self._fetch_cluster = member.version == -1
+            client_id = self._client.client_id
+            if not self._ctl and leader[0] == self._name and client_id is not None \
+                    and client_id[0] != leader[1].ephemeralOwner:
+                logger.info('I am leader but not owner of the session. Removing leader node')
+                self._client.delete(self.leader_path)
+                leader = None
+
+            if leader:
+                member = Member(-1, leader[0], None, {})
+                member = ([m for m in members if m.name == leader[0]] or [member])[0]
+                leader = Leader(leader[1].version, leader[1].ephemeralOwner, member)
+                self._fetch_cluster = member.index == -1
 
         # get last known leader lsn and slots
-        last_lsn, slots = self.get_status(path, leader)
+        last_lsn, slots = self.get_status(leader)
 
         # failover key
-        failover = self.get_node(path + self._FAILOVER, watch=self.cluster_watcher) if self._FAILOVER in nodes else None
+        failover = self.get_node(self.failover_path, watch=self.cluster_watcher) if self._FAILOVER in nodes else None
         failover = failover and Failover.from_node(failover[1].version, failover[0])
 
-        # get failsafe topology
-        failsafe = self.get_node(path + self._FAILSAFE, watch=self.cluster_watcher) if self._FAILSAFE in nodes else None
-        try:
-            failsafe = json.loads(failsafe[0]) if failsafe else None
-        except Exception:
-            failsafe = None
+        return Cluster(initialize, config, leader, last_lsn, members, failover, sync, history, slots)
 
-        return Cluster(initialize, config, leader, last_lsn, members, failover, sync, history, slots, failsafe)
-
-    def _citus_cluster_loader(self, path: str) -> Dict[int, Cluster]:
-        fetch_cluster = False
-        ret: Dict[int, Cluster] = {}
-        for node in self.get_children(path, self.cluster_watcher):
-            if citus_group_re.match(node):
-                ret[int(node)] = self._cluster_loader(path + node + '/')
-                fetch_cluster = fetch_cluster or self._fetch_cluster
-        self._fetch_cluster = fetch_cluster
-        return ret
-
-    def _load_cluster(
-            self, path: str, loader: Callable[[str], Union[Cluster, Dict[int, Cluster]]]
-    ) -> Union[Cluster, Dict[int, Cluster]]:
-        cluster = self.cluster if path == self._base_path + '/' else None
+    def _load_cluster(self):
+        cluster = self.cluster
         if self._fetch_cluster or cluster is None:
             try:
-                cluster = self._client.retry(loader, path)
+                cluster = self._client.retry(self._inner_load_cluster)
             except Exception:
                 logger.exception('get_cluster')
                 self.cluster_watcher(None)
@@ -320,20 +291,18 @@ class ZooKeeper(AbstractDCS):
                 self.event.clear()
             else:
                 try:
-                    last_lsn, slots = self.get_status(self.client_path(''), cluster.leader)
+                    last_lsn, slots = self.get_status(cluster.leader)
                     self.event.clear()
-                    new_cluster: List[Any] = list(cluster)
-                    new_cluster[3] = last_lsn
-                    new_cluster[8] = slots
-                    cluster = Cluster(*new_cluster)
+                    cluster = Cluster(cluster.initialize, cluster.config, cluster.leader, last_lsn,
+                                      cluster.members, cluster.failover, cluster.sync, cluster.history, slots)
                 except Exception:
                     pass
         return cluster
 
-    def _bypass_caches(self) -> None:
+    def _bypass_caches(self):
         self._fetch_cluster = True
 
-    def _create(self, path: str, value: bytes, retry: bool = False, ephemeral: bool = False) -> bool:
+    def _create(self, path, value, retry=False, ephemeral=False):
         try:
             if retry:
                 self._client.retry(self._client.create, path, value, makepath=True, ephemeral=ephemeral)
@@ -344,63 +313,50 @@ class ZooKeeper(AbstractDCS):
             logger.exception('Failed to create %s', path)
         return False
 
-    def attempt_to_acquire_leader(self) -> bool:
-        try:
-            self._client.retry(self._client.create, self.leader_path, self._name.encode('utf-8'),
-                               makepath=True, ephemeral=True)
-            return True
-        except (ConnectionClosedError, RetryFailedError) as e:
-            raise ZooKeeperError(e)
-        except Exception as e:
-            if not isinstance(e, NodeExistsError):
-                logger.error('Failed to create %s: %r', self.leader_path, e)
-        logger.info('Could not take out TTL lock')
-        return False
+    def attempt_to_acquire_leader(self, permanent=False):
+        ret = self._create(self.leader_path, self._name.encode('utf-8'), retry=True, ephemeral=not permanent)
+        if not ret:
+            logger.info('Could not take out TTL lock')
+        return ret
 
-    def _set_or_create(self, key: str, value: str, version: Optional[int] = None,
-                       retry: bool = False, do_not_create_empty: bool = False) -> Union[int, bool]:
-        value_bytes = value.encode('utf-8')
+    def _set_or_create(self, key, value, index=None, retry=False, do_not_create_empty=False):
+        value = value.encode('utf-8')
         try:
             if retry:
-                ret = self._client.retry(self._client.set, key, value_bytes, version=version or -1)
+                self._client.retry(self._client.set, key, value, version=index or -1)
             else:
-                ret = self._client.set_async(key, value_bytes, version=version or -1).get(timeout=1)
-            return ret.version
+                self._client.set_async(key, value, version=index or -1).get(timeout=1)
+            return True
         except NoNodeError:
-            if do_not_create_empty and not value_bytes:
+            if do_not_create_empty and not value:
                 return True
-            elif version is None:
-                if self._create(key, value_bytes, retry):
-                    return 0
+            elif index is None:
+                return self._create(key, value, retry)
             else:
                 return False
         except Exception:
             logger.exception('Failed to update %s', key)
         return False
 
-    def set_failover_value(self, value: str, version: Optional[int] = None) -> bool:
-        return self._set_or_create(self.failover_path, value, version) is not False
+    def set_failover_value(self, value, index=None):
+        return self._set_or_create(self.failover_path, value, index)
 
-    def set_config_value(self, value: str, version: Optional[int] = None) -> bool:
-        return self._set_or_create(self.config_path, value, version, retry=True) is not False
+    def set_config_value(self, value, index=None):
+        return self._set_or_create(self.config_path, value, index, retry=True)
 
-    def initialize(self, create_new: bool = True, sysid: str = "") -> bool:
-        sysid_bytes = sysid.encode('utf-8')
-        return self._create(self.initialize_path, sysid_bytes, retry=True) if create_new \
-            else self._client.retry(self._client.set, self.initialize_path, sysid_bytes)
+    def initialize(self, create_new=True, sysid=""):
+        sysid = sysid.encode('utf-8')
+        return self._create(self.initialize_path, sysid, retry=True) if create_new \
+            else self._client.retry(self._client.set, self.initialize_path, sysid)
 
-    def touch_member(self, data: Dict[str, Any]) -> bool:
+    def touch_member(self, data, permanent=False):
         cluster = self.cluster
         member = cluster and cluster.get_member(self._name, fallback_to_leader=False)
         member_data = self.__last_member_data or member and member.data
-        #  We want to notify leader if some important fields in the member key changed by removing ZNode
-        if member and (self._client.client_id is not None and member.session != self._client.client_id[0]
-                       or not (member_data and deep_compare(member_data.get('tags', {}), data.get('tags', {}))
-                               and (member_data.get('state') == data.get('state')
-                                    or 'running' not in (member_data.get('state'), data.get('state')))
-                               and member_data.get('version') == data.get('version')
-                               and member_data.get('checkpoint_after_promote')
-                               == data.get('checkpoint_after_promote'))):
+        if member and (self._client.client_id is not None and member.session != self._client.client_id[0] or
+                       not (deep_compare(member_data.get('tags', {}), data.get('tags', {})) and
+                            member_data.get('version') == data.get('version') and
+                            member_data.get('checkpoint_after_promote') == data.get('checkpoint_after_promote'))):
             try:
                 self._client.delete_async(self.member_path).get(timeout=1)
             except NoNodeError:
@@ -410,12 +366,13 @@ class ZooKeeper(AbstractDCS):
             member = None
 
         encoded_data = json.dumps(data, separators=(',', ':')).encode('utf-8')
-        if member and member_data:
+        if member:
             if deep_compare(data, member_data):
                 return True
         else:
             try:
-                self._client.create_async(self.member_path, encoded_data, makepath=True, ephemeral=True).get(timeout=1)
+                self._client.create_async(self.member_path, encoded_data, makepath=True,
+                                          ephemeral=not permanent).get(timeout=1)
                 self.__last_member_data = data
                 return True
             except Exception as e:
@@ -431,75 +388,50 @@ class ZooKeeper(AbstractDCS):
 
         return False
 
-    def take_leader(self) -> bool:
+    def take_leader(self):
         return self.attempt_to_acquire_leader()
 
-    def _write_leader_optime(self, last_lsn: str) -> bool:
-        return self._set_or_create(self.leader_optime_path, last_lsn) is not False
+    def _write_leader_optime(self, last_lsn):
+        return self._set_or_create(self.leader_optime_path, last_lsn)
 
-    def _write_status(self, value: str) -> bool:
-        return self._set_or_create(self.status_path, value) is not False
+    def _write_status(self, value):
+        return self._set_or_create(self.status_path, value)
 
-    def _write_failsafe(self, value: str) -> bool:
-        return self._set_or_create(self.failsafe_path, value) is not False
-
-    def _update_leader(self, leader: Leader) -> bool:
-        if self._client.client_id and self._client.client_id[0] != leader.session:
-            logger.warning('Recreating the leader ZNode due to ownership mismatch')
-            try:
-                self._client.retry(self._client.delete, self.leader_path)
-            except NoNodeError:
-                pass
-            except (ConnectionClosedError, RetryFailedError) as e:
-                raise ZooKeeperError(e)
-            except Exception as e:
-                logger.error('Failed to remove %s: %r', self.leader_path, e)
-                return False
-
-            try:
-                self._client.retry(self._client.create, self.leader_path,
-                                   self._name.encode('utf-8'), makepath=True, ephemeral=True)
-            except (ConnectionClosedError, RetryFailedError) as e:
-                raise ZooKeeperError(e)
-            except Exception as e:
-                logger.error('Failed to create %s: %r', self.leader_path, e)
-                return False
+    def _update_leader(self):
         return True
 
-    def _delete_leader(self, leader: Leader) -> bool:
+    def _delete_leader(self):
         self._client.restart()
         return True
 
-    def _cancel_initialization(self) -> None:
+    def _cancel_initialization(self):
         node = self.get_node(self.initialize_path)
         if node:
             self._client.delete(self.initialize_path, version=node[1].version)
 
-    def cancel_initialization(self) -> bool:
+    def cancel_initialization(self):
         try:
             self._client.retry(self._cancel_initialization)
-            return True
         except Exception:
             logger.exception("Unable to delete initialize key")
-        return False
 
-    def delete_cluster(self) -> bool:
+    def delete_cluster(self):
         try:
             return self._client.retry(self._client.delete, self.client_path(''), recursive=True)
         except NoNodeError:
             return True
 
-    def set_history_value(self, value: str) -> bool:
-        return self._set_or_create(self.history_path, value) is not False
+    def set_history_value(self, value):
+        return self._set_or_create(self.history_path, value)
 
-    def set_sync_state_value(self, value: str, version: Optional[int] = None) -> Union[int, bool]:
-        return self._set_or_create(self.sync_path, value, version, retry=True, do_not_create_empty=True)
+    def set_sync_state_value(self, value, index=None):
+        return self._set_or_create(self.sync_path, value, index, retry=True, do_not_create_empty=True)
 
-    def delete_sync_state(self, version: Optional[int] = None) -> bool:
-        return self.set_sync_state_value("{}", version) is not False
+    def delete_sync_state(self, index=None):
+        return self.set_sync_state_value("{}", index)
 
-    def watch(self, leader_version: Optional[int], timeout: float) -> bool:
-        ret = super(ZooKeeper, self).watch(leader_version, timeout + 0.5)
+    def watch(self, leader_index, timeout):
+        ret = super(ZooKeeper, self).watch(leader_index, timeout + 0.5)
         if ret and not self._fetch_status:
             self._fetch_cluster = True
         return ret or self._fetch_cluster

patroni/exceptions.py

@@ -1,55 +1,37 @@
-"""Implement high-level Patroni exceptions.
-
-More specific exceptions can be found in other modules, as subclasses of any exception defined in this module.
-"""
-from typing import Any
-
-
 class PatroniException(Exception):
-    """Parent class for all kind of Patroni exceptions.
 
-    :ivar value: description of the exception.
-    """
+    """Parent class for all kind of exceptions related to selected distributed configuration store"""
 
-    def __init__(self, value: Any) -> None:
-        """Create a new instance of :class:`PatroniException` with the given description.
-
-        :param value: description of the exception.
-        """
+    def __init__(self, value):
         self.value = value
 
+    def __str__(self):
+        """
+        >>> str(PatroniException('foo'))
+        "'foo'"
+        """
+        return repr(self.value)
+
 
 class PatroniFatalException(PatroniException):
-    """Catastrophic exception that prevents Patroni from performing its job."""
-
     pass
 
 
 class PostgresException(PatroniException):
-    """Any exception related with Postgres management."""
-
     pass
 
 
 class DCSError(PatroniException):
-    """Parent class for all kind of DCS related exceptions."""
-
     pass
 
 
 class PostgresConnectionException(PostgresException):
-    """Any problem faced while connecting to a Postgres instance."""
-
     pass
 
 
 class WatchdogError(PatroniException):
-    """Any problem faced while managing a watchdog device."""
-
     pass
 
 
 class ConfigParseError(PatroniException):
-    """Any issue identified while loading or validating the Patroni configuration."""
-
     pass

patroni/file_perm.py

@@ -1,95 +0,0 @@
-"""Helper object that helps with figuring out file and directory permissions based on permissions of PGDATA.
-
-:var logger: logger of this module.
-:var pg_perm: instance of the :class:`__FilePermissions` object.
-"""
-import logging
-import os
-import stat
-
-logger = logging.getLogger(__name__)
-
-
-class __FilePermissions:
-    """Helper class for managing permissions of directories and files under PGDATA.
-
-    Execute :meth:`set_permissions_from_data_directory` to figure out which permissions should be used for files and
-    directories under PGDATA based on permissions of PGDATA root directory.
-    """
-
-    # Mode mask for data directory permissions that only allows the owner to
-    # read/write directories and files -- mask 077.
-    __PG_MODE_MASK_OWNER = stat.S_IRWXG | stat.S_IRWXO
-
-    # Mode mask for data directory permissions that also allows group read/execute -- mask 027.
-    __PG_MODE_MASK_GROUP = stat.S_IWGRP | stat.S_IRWXO
-
-    # Default mode for creating directories -- mode 700.
-    __PG_DIR_MODE_OWNER = stat.S_IRWXU
-
-    # Mode for creating directories that allows group read/execute -- mode 750.
-    __PG_DIR_MODE_GROUP = stat.S_IRWXU | stat.S_IRGRP | stat.S_IXGRP
-
-    # Default mode for creating files -- mode 600.
-    __PG_FILE_MODE_OWNER = stat.S_IRUSR | stat.S_IWUSR
-
-    # Mode for creating files that allows group read -- mode 640.
-    __PG_FILE_MODE_GROUP = stat.S_IRUSR | stat.S_IWUSR | stat.S_IRGRP
-
-    def __init__(self) -> None:
-        """Create a :class:`__FilePermissions` object and set default permissions."""
-        self.__set_owner_permissions()
-        self.__set_umask()
-
-    def __set_umask(self) -> None:
-        """Set umask value based on calculations.
-
-        .. note::
-            Should only be called once either :meth:`__set_owner_permissions`
-            or :meth:`__set_group_permissions` has been executed.
-        """
-        try:
-            os.umask(self.__pg_mode_mask)
-        except Exception as e:
-            logger.error('Can not set umask to %03o: %r', self.__pg_mode_mask, e)
-
-    def __set_owner_permissions(self) -> None:
-        """Make directories/files accessible only by the owner."""
-        self.__pg_dir_create_mode = self.__PG_DIR_MODE_OWNER
-        self.__pg_file_create_mode = self.__PG_FILE_MODE_OWNER
-        self.__pg_mode_mask = self.__PG_MODE_MASK_OWNER
-
-    def __set_group_permissions(self) -> None:
-        """Make directories/files accessible by the owner and readable by group."""
-        self.__pg_dir_create_mode = self.__PG_DIR_MODE_GROUP
-        self.__pg_file_create_mode = self.__PG_FILE_MODE_GROUP
-        self.__pg_mode_mask = self.__PG_MODE_MASK_GROUP
-
-    def set_permissions_from_data_directory(self, data_dir: str) -> None:
-        """Set new permissions based on provided *data_dir*.
-
-        :param data_dir: reference to PGDATA to calculate permissions from.
-        """
-        try:
-            st = os.stat(data_dir)
-            if (st.st_mode & self.__PG_DIR_MODE_GROUP) == self.__PG_DIR_MODE_GROUP:
-                self.__set_group_permissions()
-            else:
-                self.__set_owner_permissions()
-        except Exception as e:
-            logger.error('Can not check permissions on %s: %r', data_dir, e)
-        else:
-            self.__set_umask()
-
-    @property
-    def dir_create_mode(self) -> int:
-        """Directory permissions."""
-        return self.__pg_dir_create_mode
-
-    @property
-    def file_create_mode(self) -> int:
-        """File permissions."""
-        return self.__pg_file_create_mode
-
-
-pg_perm = __FilePermissions()

patroni/log.py

@@ -1,8 +1,3 @@
-"""Patroni logging facilities.
-
-Daemon processes will use a 2-step logging handler. Whenever a log message is issued it is initially enqueued in-memory
-and is later asynchronously flushed by a thread to the final destination.
-"""
 import logging
 import os
 import sys
@@ -10,84 +5,41 @@ import sys
 from copy import deepcopy
 from logging.handlers import RotatingFileHandler
 from patroni.utils import deep_compare
-from queue import Queue, Full
+from six.moves.queue import Queue, Full
 from threading import Lock, Thread
 
-from typing import Any, Dict, List, Optional, Union, TYPE_CHECKING
-
 _LOGGER = logging.getLogger(__name__)
 
 
-def debug_exception(self: logging.Logger, msg: object, *args: Any, **kwargs: Any) -> None:
-    """Add full stack trace info to debug log messages and partial to others.
-
-    Handle :func:`~self.exception` calls for *self*.
-
-    .. note::
-        * If *self* log level is set to ``DEBUG``, then issue a ``DEBUG`` message with the complete stack trace;
-        * If *self* log level is ``INFO`` or higher, then issue an ``ERROR`` message with only the last line of
-            the stack trace.
-
-    :param self: logger for which :func:`~self.exception` will be processed.
-    :param msg: the message related to the exception to be logged.
-    :param args: positional arguments to be passed to :func:`~self.debug` or :func:`~self.error`.
-    :param kwargs: keyword arguments to be passed to :func:`~self.debug` or :func:`~self.error`.
-    """
+def debug_exception(logger_obj, msg, *args, **kwargs):
     kwargs.pop("exc_info", False)
-    if self.isEnabledFor(logging.DEBUG):
-        self.debug(msg, *args, exc_info=True, **kwargs)
+    if logger_obj.isEnabledFor(logging.DEBUG):
+        logger_obj.debug(msg, *args, exc_info=True, **kwargs)
     else:
         msg = "{0}, DETAIL: '{1}'".format(msg, sys.exc_info()[1])
-        self.error(msg, *args, exc_info=False, **kwargs)
+        logger_obj.error(msg, *args, exc_info=False, **kwargs)
 
 
-def error_exception(self: logging.Logger, msg: object, *args: Any, **kwargs: Any) -> None:
-    """Add full stack trace info to error messages.
-
-    Handle :func:`~self.exception` calls for *self*.
-
-    .. note::
-        * By default issue an ``ERROR`` message with the complete stack trace. If you do not want to show the complete
-          stack trace, call with ``exc_info=False``.
-
-    :param self: logger for which :func:`~self.exception` will be processed.
-    :param msg: the message related to the exception to be logged.
-    :param args: positional arguments to be passed to :func:`~self.error`.
-    :param kwargs: keyword arguments to be passed to :func:`~self.error`.
-    """
+def error_exception(logger_obj, msg, *args, **kwargs):
     exc_info = kwargs.pop("exc_info", True)
-    self.error(msg, *args, exc_info=exc_info, **kwargs)
+    logger_obj.error(msg, *args, exc_info=exc_info, **kwargs)
 
 
 class QueueHandler(logging.Handler):
-    """Queue-based logging handler.
 
-    :ivar queue: queue to hold log messages that are pending to be flushed to the final destination.
-    """
-
-    def __init__(self) -> None:
-        """Queue initialised and initial records_lost established."""
-        super().__init__()
-        self.queue: Queue[Union[logging.LogRecord, None]] = Queue()
+    def __init__(self):
+        logging.Handler.__init__(self)
+        self.queue = Queue()
         self._records_lost = 0
 
-    def _put_record(self, record: logging.LogRecord) -> None:
-        """Asynchronously enqueue a log record.
-
-        :param record: the record to be logged.
-        """
+    def _put_record(self, record):
         self.format(record)
         record.msg = record.message
         record.args = None
         record.exc_info = None
         self.queue.put_nowait(record)
 
-    def _try_to_report_lost_records(self) -> None:
-        """Report the number of log messages that have been lost and reset the counter.
-
-        .. note::
-            It will issue an ``WARNING`` message in the logs with the number of lost log messages.
-        """
+    def _try_to_report_lost_records(self):
         if self._records_lost:
             try:
                 record = _LOGGER.makeRecord(_LOGGER.name, logging.WARNING, __file__, 0,
@@ -98,15 +50,7 @@ class QueueHandler(logging.Handler):
             except Exception:
                 pass
 
-    def emit(self, record: logging.LogRecord) -> None:
-        """Handle each log record that is emitted.
-
-        Call :func:`_put_record` to enqueue the emitted log record.
-
-        Also check if we have previously lost any log record, and if so, log a ``WARNING`` message.
-
-        :param record: the record that was emitted.
-        """
+    def emit(self, record):
         try:
             self._put_record(record)
             self._try_to_report_lost_records()
@@ -114,60 +58,21 @@ class QueueHandler(logging.Handler):
             self._records_lost += 1
 
     @property
-    def records_lost(self) -> int:
-        """Number of log messages that have been lost while the queue was full."""
+    def records_lost(self):
         return self._records_lost
 
 
 class ProxyHandler(logging.Handler):
-    """Handle log records in place of pending log handlers.
 
-    .. note::
-        This is used to handle log messages while the logger thread has not started yet, in which case the queue-based
-        handler is not yet started.
-
-    :ivar patroni_logger: the logger thread.
-    """
-
-    def __init__(self, patroni_logger: 'PatroniLogger') -> None:
-        """Create a new :class:`ProxyHandler` instance.
-
-        :param patroni_logger: the logger thread.
-        """
-        super().__init__()
+    def __init__(self, patroni_logger):
+        logging.Handler.__init__(self)
         self.patroni_logger = patroni_logger
 
-    def emit(self, record: logging.LogRecord) -> None:
-        """Emit each log record that is handled.
-
-        Will push the log record down to :func:`~logging.Handler.handle` method of the currently configured log handler.
-
-        :param record: the record that was emitted.
-        """
-        if self.patroni_logger.log_handler is not None:
-            self.patroni_logger.log_handler.handle(record)
+    def emit(self, record):
+        self.patroni_logger.log_handler.handle(record)
 
 
 class PatroniLogger(Thread):
-    """Logging thread for the Patroni daemon process.
-
-    It is a 2-step logging approach. Any time a log message is issued it is initially enqueued in-memory, and then
-    asynchronously flushed to the final destination by the logging thread.
-
-    .. seealso::
-        :class:`QueueHandler`: object used for enqueueing messages in-memory.
-
-    :cvar DEFAULT_LEVEL: default logging level (``INFO``).
-    :cvar DEFAULT_TRACEBACK_LEVEL: default traceback logging level (``ERROR``).
-    :cvar DEFAULT_FORMAT: default format of log messages (``%(asctime)s %(levelname)s: %(message)s``).
-    :cvar NORMAL_LOG_QUEUE_SIZE: expected number of log messages per HA loop when operating under a normal situation.
-    :cvar DEFAULT_MAX_QUEUE_SIZE: default maximum queue size for holding a backlog of log messages that are pending
-        to be flushed.
-    :cvar LOGGING_BROKEN_EXIT_CODE: exit code to be used if it detects(``5``).
-
-    :ivar log_handler: log handler that is currently being used by the thread.
-    :ivar log_handler_lock: lock used to modify ``log_handler``.
-    """
 
     DEFAULT_LEVEL = 'INFO'
     DEFAULT_TRACEBACK_LEVEL = 'ERROR'
@@ -177,24 +82,14 @@ class PatroniLogger(Thread):
     DEFAULT_MAX_QUEUE_SIZE = 1000
     LOGGING_BROKEN_EXIT_CODE = 5
 
-    def __init__(self) -> None:
-        """Prepare logging queue and proxy handlers as they become ready during daemon startup.
-
-        .. note::
-            While Patroni is starting up it keeps ``DEBUG`` log level, and writes log messages through a proxy handler.
-            Once the logger thread is finally started, it switches from that proxy handler to the queue based logger,
-            and applies the configured log settings. The switching is used to avoid that the logger thread prevents
-            Patroni from shutting down if any issue occurs in the meantime until the thread is properly started.
-        """
+    def __init__(self):
         super(PatroniLogger, self).__init__()
         self._queue_handler = QueueHandler()
         self._root_logger = logging.getLogger()
-        self._config: Optional[Dict[str, Any]] = None
+        self._config = None
         self.log_handler = None
         self.log_handler_lock = Lock()
-        self._old_handlers: List[logging.Handler] = []
-        # initially set log level to ``DEBUG`` while the logger thread has not started running yet. The daemon process
-        # will later adjust all log related settings with what was provided through the user configuration file.
+        self._old_handlers = []
         self.reload_config({'level': 'DEBUG'})
         # We will switch to the QueueHandler only when thread was started.
         # This is necessary to protect from the cases when Patroni constructor
@@ -202,46 +97,26 @@ class PatroniLogger(Thread):
         self._proxy_handler = ProxyHandler(self)
         self._root_logger.addHandler(self._proxy_handler)
 
-    def update_loggers(self) -> None:
-        """Configure loggers' log level as defined in ``log.loggers`` section of Patroni configuration.
-
-        .. note::
-            It creates logger objects that are not defined yet in the log manager.
-        """
-        loggers = deepcopy((self._config or {}).get('loggers') or {})
+    def update_loggers(self):
+        loggers = deepcopy(self._config.get('loggers') or {})
         for name, logger in self._root_logger.manager.loggerDict.items():
-            # ``Placeholder`` is a node in the log manager for which no logger has been defined. We are interested only
-            # in the ones that were defined
             if not isinstance(logger, logging.PlaceHolder):
-                # if this logger is present in ``log.loggers`` Patroni configuration, use the configured level,
-                # otherwise use ``logging.NOTSET``, which means it will inherit the level from any parent node up to
-                # the root for which log level is defined.
                 level = loggers.pop(name, logging.NOTSET)
                 logger.setLevel(level)
 
-        # define loggers that do not exist yet and set level as configured in ``log.loggers`` section of configuration.
         for name, level in loggers.items():
             logger = self._root_logger.manager.getLogger(name)
             logger.setLevel(level)
 
-    def reload_config(self, config: Dict[str, Any]) -> None:
-        """Apply log related configuration.
-
-        .. note::
-            It is also able to deal with runtime configuration changes.
-
-        :param config: ``log`` section from Patroni configuration.
-        """
+    def reload_config(self, config):
         if self._config is None or not deep_compare(self._config, config):
             with self._queue_handler.queue.mutex:
                 self._queue_handler.queue.maxsize = config.get('max_queue_size', self.DEFAULT_MAX_QUEUE_SIZE)
 
             self._root_logger.setLevel(config.get('level', PatroniLogger.DEFAULT_LEVEL))
             if config.get('traceback_level', PatroniLogger.DEFAULT_TRACEBACK_LEVEL).lower() == 'debug':
-                # show stack traces only if ``log.traceback_level`` is ``DEBUG``
                 logging.Logger.exception = debug_exception
             else:
-                # show stack traces as ``ERROR`` log messages
                 logging.Logger.exception = error_exception
 
             new_handler = None
@@ -249,9 +124,7 @@ class PatroniLogger(Thread):
                 if not isinstance(self.log_handler, RotatingFileHandler):
                     new_handler = RotatingFileHandler(os.path.join(config['dir'], __name__))
                 handler = new_handler or self.log_handler
-                if TYPE_CHECKING:  # pragma: no cover
-                    assert isinstance(handler, RotatingFileHandler)
-                handler.maxBytes = int(config.get('file_size', 25000000))  # pyright: ignore [reportGeneralTypeIssues]
+                handler.maxBytes = int(config.get('file_size', 25000000))
                 handler.backupCount = int(config.get('file_num', 4))
             else:
                 if self.log_handler is None or isinstance(self.log_handler, RotatingFileHandler):
@@ -264,7 +137,7 @@ class PatroniLogger(Thread):
             olddateformat = (self._config or {}).get('dateformat') or None
             dateformat = config.get('dateformat') or None  # Convert empty string to `None`
 
-            if (oldlogformat != logformat or olddateformat != dateformat or new_handler) and handler:
+            if oldlogformat != logformat or olddateformat != dateformat or new_handler:
                 handler.setFormatter(logging.Formatter(logformat, dateformat))
 
             if new_handler:
@@ -276,14 +149,7 @@ class PatroniLogger(Thread):
             self._config = config.copy()
             self.update_loggers()
 
-    def _close_old_handlers(self) -> None:
-        """Close old log handlers.
-
-        .. note::
-            It is used to remove different handlers that were configured previous to a reload in the configuration,
-            e.g. if we are switching from :class:`~logging.handlers.RotatingFileHandler` to
-            class:`~logging.StreamHandler` and vice-versa.
-        """
+    def _close_old_handlers(self):
         while True:
             with self.log_handler_lock:
                 if not self._old_handlers:
@@ -294,11 +160,7 @@ class PatroniLogger(Thread):
             except Exception:
                 _LOGGER.exception('Failed to close the old log handler %s', handler)
 
-    def run(self) -> None:
-        """Run logger's thread main loop.
-
-        Keep consuming log queue until requested to quit through ``None`` special log record.
-        """
+    def run(self):
         # switch to QueueHandler only when the thread was started
         with self.log_handler_lock:
             self._root_logger.addHandler(self._queue_handler)
@@ -308,17 +170,12 @@ class PatroniLogger(Thread):
 
         while True:
             self._close_old_handlers()
-            if TYPE_CHECKING:  # pragma: no cover
-                assert self.log_handler is not None
 
             record = self._queue_handler.queue.get(True)
-            # special message that indicates Patroni is shutting down
             if record is None:
                 break
 
             if self._root_logger.level == logging.INFO:
-                # messages like ``Lock owner: postgresql0; I am postgresql1`` will be shown only when stream doesn't
-                # look normal. This is used to reduce chattiness of Patroni logs.
                 if record.msg.startswith('Lock owner: '):
                     prev_record, record = record, None
                 else:
@@ -332,10 +189,8 @@ class PatroniLogger(Thread):
 
             self._queue_handler.queue.task_done()
 
-    def shutdown(self) -> None:
-        """Shut down the logger thread."""
+    def shutdown(self):
         try:
-            # ``None`` is a special message indicating to queue handler that it should quit its main loop.
             self._queue_handler.queue.put_nowait(None)
         except Full:  # Queue is full.
             # It seems that logging is not working, exiting with non-standard exit-code is the best we can do.
@@ -344,11 +199,9 @@ class PatroniLogger(Thread):
         logging.shutdown()
 
     @property
-    def queue_size(self) -> int:
-        """Number of log records in the queue."""
+    def queue_size(self):
         return self._queue_handler.queue.qsize()
 
     @property
-    def records_lost(self) -> int:
-        """Number of logging records that have been lost while the queue was full."""
+    def records_lost(self):
         return self._queue_handler.records_lost

patroni/manual_failover.py

@@ -1,93 +0,0 @@
-from enum import Enum
-from typing import Optional, Tuple, TYPE_CHECKING
-
-if TYPE_CHECKING:  # pragma: no cover
-    import datetime
-
-    from .dcs import Cluster
-    from .ha import Patroni
-    from .utils import ParseScheduleErrors
-
-from .utils import parse_schedule
-
-
-class ManualFailoverPrecheckStatus(Enum):
-    FAILOVER_NO_CANDIDATE = ('Failover could be performed only to a specific candidate', 400)
-    SWITCHOVER_NO_LEADER = ('Switchover could be performed only from a specific leader', 400)
-    SCHEDULED_FAILOVER = ("Failover can't be scheduled", 400)
-    SCHEDULED_SWITCHOVER_PAUSE = ("Can't schedule switchover in the paused state", 400)
-    SWITCHOVER_PAUSE_NO_CANDIDATE = ('Switchover is possible only to a specific candidate in a paused state', 400)
-    SWITCHOVER_TO_LEADER = ('Switchover target and source are the same', 400)
-
-    CLUSTER_NO_LEADER = ('Cluster {cluster_name} has no leader', 412)
-    LEADER_NOT_MEMBER = ('Member {leader} is not the leader of cluster {cluster_name}', 412)
-    CANDIDATE_NOT_SYNC_STANDBY = ('candidate name does not match with sync_standby', 412)
-    NO_SYNC_CANDIDATE = ('{action} is not possible: can not find sync_standby', 412)
-    ONLY_LEADER = ('{action} is not possible: cluster does not have members except leader', 412)
-    CANDIDATE_NOT_MEMEBER = ('Member {candidate} does not exist in cluster {cluster_name} or is tagged as nofailover',
-                             412)
-    NO_GOOD_CANDIDATES = ('{action} is not possible: no good candidates have been found', 412)
-
-    CHECK_PASSED = ('', None)
-
-
-class ManualFailover(object):
-
-    def __init__(self, action: str, cluster: 'Cluster',
-                 leader: Optional[str], candidate: Optional[str], scheduled: Optional[str],
-                 paused: bool = False, sync_mode: bool = False, patroni_obj: Optional['Patroni'] = None) -> None:
-        self.action = action
-        self.cluster = cluster
-        self.leader = leader
-        self.candidate = candidate
-        self.scheduled = scheduled
-        self.paused = paused
-        self.sync_mode = sync_mode
-        self.patroni = patroni_obj
-
-    def parse_scheduled(self) -> Tuple[Optional['ParseScheduleErrors'], Optional['datetime.datetime']]:
-        return parse_schedule(self.scheduled)
-
-    def run_precheck(self) -> ManualFailoverPrecheckStatus:
-        if self.action == 'failover' and not self.candidate:
-            return ManualFailoverPrecheckStatus.FAILOVER_NO_CANDIDATE
-        elif self.action == 'switchover' and not self.leader:
-            return ManualFailoverPrecheckStatus.SWITCHOVER_NO_LEADER
-
-        if self.scheduled:
-            if self.action == 'failover':
-                return ManualFailoverPrecheckStatus.SCHEDULED_FAILOVER
-            elif self.paused:
-                return ManualFailoverPrecheckStatus.SCHEDULED_SWITCHOVER_PAUSE
-
-        if self.paused and not self.candidate:
-            return ManualFailoverPrecheckStatus.SWITCHOVER_PAUSE_NO_CANDIDATE
-
-        if self.leader == self.candidate:
-            return ManualFailoverPrecheckStatus.SWITCHOVER_TO_LEADER
-
-        if self.action == 'switchover':
-            if self.cluster.leader is None or not self.cluster.leader.name:
-                return ManualFailoverPrecheckStatus.CLUSTER_NO_LEADER
-            if self.cluster.leader.name != self.leader:
-                return ManualFailoverPrecheckStatus.LEADER_NOT_MEMBER
-
-        if self.candidate:
-            if self.action == 'switchover' and self.sync_mode and not self.cluster.sync.matches(self.candidate):
-                return ManualFailoverPrecheckStatus.CANDIDATE_NOT_SYNC_STANDBY
-            members = [m for m in self.cluster.members if m.name == self.candidate]
-            if not members:
-                return ManualFailoverPrecheckStatus.CANDIDATE_NOT_MEMEBER
-        elif self.sync_mode:
-            members = [m for m in self.cluster.members if self.cluster.sync.matches(m.name)]
-            if not members:
-                return ManualFailoverPrecheckStatus.NO_SYNC_CANDIDATE
-        else:
-            members = [m for m in self.cluster.members if not self.cluster.leader or m.name != self.cluster.leader.name and m.api_url]
-            if not members:
-                return ManualFailoverPrecheckStatus.ONLY_LEADER
-
-        if self.patroni and not self.patroni.ha.has_members_eligible_to_promote(members, fast_path=True):
-            return ManualFailoverPrecheckStatus.NO_GOOD_CANDIDATES
-
-        return ManualFailoverPrecheckStatus.CHECK_PASSED