gitops/patroni
1
0
Fork 0
mirror of https://github.com/outbackdingo/patroni.git synced 2026-08-25 14:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Run CHECKPOINT before calling shutdown.

Browse Source 
In addition, restart is now performed as stop/start,
which would allow it to benefit from the shutdown speedup.

The hooks in start/stop are modified in order not to run
when called as a part of restart.
This commit is contained in:
Oleksii Kliukin
2015-09-02 14:14:16 +02:00
parent a5f2ab6f88
commit 80f92b1dee
1 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
helpers/postgresql.py
+18 -6
View File
@@ -183,7 +183,7 @@ class Postgresql:
return False
return True
def start(self):
def start(self, block_callbacks=False):
if self.is_running():
self.load_replication_slots()
logger.error('Cannot start PostgreSQL because one is already running.')
@@ -196,18 +196,28 @@ class Postgresql:
ret = subprocess.call(self._pg_ctl + ['start', '-o', self.server_options()]) == 0
ret and self.load_replication_slots()
self.save_configuration_files()
if ret and ACTION_ON_START in self.callback:
# block_callbacks is used during restart to avoid
# running start/stop callbacks in addition to restart ones
if not block_callbacks and ret and ACTION_ON_START in self.callback:
self.call_nowait(ACTION_ON_START)
return ret
def stop(self):
def stop(self, block_callbacks=False):
try:
is_leader = self.is_leader(check_only=True)
except:
is_leader = None
pass
ret = subprocess.call(self._pg_ctl + ['stop', '-m', 'fast'])
if ret == 0 and ACTION_ON_STOP in self.callback:
try:
self.query("CHECKPOINT")
except psycopg2.OperationalError:
# likely PostgreSQL is already stopped.
ret = 0
else:
ret = subprocess.call(self._pg_ctl + ['stop', '-m', 'fast'])
# block_callbacks is used during restart to avoid
# running start/stop callbacks in addition to restart ones
if not block_callbacks and ret == 0 and ACTION_ON_STOP in self.callback:
self.call_nowait(ACTION_ON_STOP, is_leader=is_leader)
return ret == 0
@@ -223,7 +233,9 @@ class Postgresql:
except:
is_leader = None
pass
ret = subprocess.call(self._pg_ctl + ['restart', '-m', 'fast'])
ret = self.stop(block_callbacks=True)
if ret == 0:
ret = self.start(block_callbacks=True)
if ret == 0 and ACTION_ON_RESTART in self.callback:
self.call_nowait(ACTION_ON_RESTART, is_leader=is_leader)
return ret == 0