Compare commits

..
7 Commits
Author SHA1 Message Date
ironclaw-ci[bot]GitHubironclaw-ci[bot] <266877842+ironclaw-ci[bot]@users.noreply.github.com>
52551f0ef4 chore(ironclaw): release v0.23.0 (#1658)
Co-authored-by: ironclaw-ci[bot] <266877842+ironclaw-ci[bot]@users.noreply.github.com>
2026-03-26 22:02:30 -07:00
Henry ParkandGitHub db6450c47a Merge pull request #1687 from nearai/staging-promote/1d577782-23620402154
chore: promote staging to main (2026-03-26 22:07 UTC)
2026-03-26 21:18:18 -07:00
Henry ParkandGitHub 018416d3f3 Merge pull request #1690 from nearai/staging-promote/5b95d222-23624475316
chore: promote staging to staging-promote/1d577782-23620402154 (2026-03-27 00:14 UTC)
2026-03-26 21:03:26 -07:00
Henry ParkandGitHub b92d333b0c Merge pull request #1661 from nearai/staging-promote/4c043bf0-23573031775
chore: promote staging to main (2026-03-26 01:33 UTC)
2026-03-26 14:41:27 -07:00
Henry ParkandGitHub 00aba928e0 Merge pull request #1668 from nearai/staging-promote/ed4d9293-23582522167
chore: promote staging to staging-promote/4c043bf0-23573031775 (2026-03-26 07:26 UTC)
2026-03-26 14:21:04 -07:00
Henry ParkandGitHub 07c32b788c Merge pull request #1685 from nearai/staging-promote/adf4e25c-23618091675
chore: promote staging to staging-promote/ed4d9293-23582522167 (2026-03-26 21:08 UTC)
2026-03-26 14:20:50 -07:00
Henry ParkandGitHub f40019aa4c Merge pull request #1682 from nearai/staging-promote/9c63d189-23610882140
chore: promote staging to staging-promote/ed4d9293-23582522167 (2026-03-26 18:18 UTC)
2026-03-26 13:03:01 -07:00
24 changed files with 139 additions and 1540 deletions
+5 -4
View File
@@ -17,8 +17,6 @@ target/
# Python
__pycache__/
*.pyc
*.pyo
*.pyd
# Benchmark results (local runs, not committed)
bench-results/
@@ -36,5 +34,8 @@ trace_*.json
.claude/settings.local.json
.worktrees/
# JetBrains IDE
.idea
# Python cache
__pycache__/
*.pyc
*.pyo
*.pyd
+18
View File
@@ -7,6 +7,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
## [0.23.0](https://github.com/nearai/ironclaw/compare/ironclaw-v0.22.0...ironclaw-v0.23.0) - 2026-03-27
### Added
- complete multi-tenant isolation — phases 24 ([#1614](https://github.com/nearai/ironclaw/pull/1614))
### Fixed
- *(routines)* recover delete name after failed update fallback ([#1108](https://github.com/nearai/ironclaw/pull/1108))
- *(mcp)* handle 202 Accepted and wire session manager for Streamable HTTP ([#1437](https://github.com/nearai/ironclaw/pull/1437))
- *(extensions)* channel-relay auth dead-end, observability, and URL override ([#1681](https://github.com/nearai/ironclaw/pull/1681))
- *(agent)* discard truncated tool calls when finish_reason == Length ([#1631](https://github.com/nearai/ironclaw/pull/1631)) ([#1632](https://github.com/nearai/ironclaw/pull/1632))
- *(llm)* filter XML tool-call recovery by context ([#1641](https://github.com/nearai/ironclaw/pull/1641))
### Other
- Support direct hosted OAuth callbacks with proxy auth token ([#1684](https://github.com/nearai/ironclaw/pull/1684))
## [0.22.0](https://github.com/nearai/ironclaw/compare/ironclaw-v0.21.0...ironclaw-v0.22.0) - 2026-03-25
### Added
Generated
+1 -1
View File
@@ -3390,7 +3390,7 @@ dependencies = [
[[package]]
name = "ironclaw"
version = "0.22.0"
version = "0.23.0"
dependencies = [
"aes-gcm",
"aho-corasick",
+1 -1
View File
@@ -20,7 +20,7 @@ exclude = [
[package]
name = "ironclaw"
version = "0.22.0"
version = "0.23.0"
edition = "2024"
rust-version = "1.92"
description = "Secure personal AI assistant that protects your data and expands its capabilities on the fly"
+1 -1
View File
@@ -269,7 +269,7 @@ dependencies = [
[[package]]
name = "whatsapp-channel"
version = "0.2.0"
version = "0.1.0"
dependencies = [
"serde",
"serde_json",
-9
View File
@@ -47,15 +47,6 @@ impl Agent {
thread_id: Uuid,
initial_messages: Vec<ChatMessage>,
) -> Result<AgenticLoopResult, Error> {
if let Some(ext_mgr) = self.deps.extension_manager.as_ref()
&& let Err(e) = ext_mgr.ensure_nearai_companion_active_if_ready().await
{
tracing::debug!(
"Failed to auto-activate NEAR AI companion MCP before turn: {}",
e
);
}
// Detect group chat from channel metadata (needed before loading system prompt)
let is_group_chat = message
.metadata
+1 -20
View File
@@ -449,8 +449,6 @@ impl AppBuilder {
let mcp_session_manager = Arc::new(McpSessionManager::new());
let mcp_process_manager = Arc::new(McpProcessManager::new());
let companion_mcp_server =
crate::tools::mcp::config::derive_nearai_companion_mcp_server(&self.config);
// Create WASM tool runtime eagerly so extensions installed after startup
// (e.g. via the web UI) can still be activated. The tools directory is only
@@ -528,7 +526,6 @@ impl AppBuilder {
let mcp_sm = Arc::clone(&mcp_session_manager);
let pm = Arc::clone(&mcp_process_manager);
let owner_id = self.config.owner_id.clone();
let companion_mcp_server = companion_mcp_server.clone();
async move {
let servers_result = if let Some(ref d) = db {
load_mcp_servers_from_db(d.as_ref(), &owner_id).await
@@ -536,16 +533,7 @@ impl AppBuilder {
crate::tools::mcp::config::load_mcp_servers().await
};
match servers_result {
Ok(mut servers) => {
if let Some(companion) = companion_mcp_server {
let companion_name = companion.name.clone();
if !servers.insert_if_absent(companion) {
tracing::debug!(
"Skipping derived MCP companion '{}': an existing config with that name is already present",
companion_name
);
}
}
Ok(servers) => {
let enabled: Vec<_> = servers.enabled_servers().cloned().collect();
if !enabled.is_empty() {
tracing::debug!(
@@ -557,8 +545,6 @@ impl AppBuilder {
let mut join_set = tokio::task::JoinSet::new();
for server in enabled {
let mcp_sm = Arc::clone(&mcp_sm);
let nearai_session = Arc::clone(&self.session);
let nearai_api_key = self.config.llm.nearai.api_key.clone();
let secrets = secrets_store.clone();
let tools = Arc::clone(&tools);
let pm = Arc::clone(&pm);
@@ -570,8 +556,6 @@ impl AppBuilder {
let client = match crate::tools::mcp::create_client_from_config(
server,
&mcp_sm,
Some(nearai_session),
nearai_api_key,
&pm,
secrets,
&owner_id,
@@ -728,8 +712,6 @@ impl AppBuilder {
let manager = Arc::new(ExtensionManager::new(
Arc::clone(&mcp_session_manager),
Arc::clone(&mcp_process_manager),
Some(Arc::clone(&self.session)),
self.config.llm.nearai.api_key.clone(),
ext_secrets,
Arc::clone(tools),
Some(Arc::clone(hooks)),
@@ -739,7 +721,6 @@ impl AppBuilder {
self.config.tunnel.public_url.clone(),
self.config.owner_id.clone(),
self.db.clone(),
companion_mcp_server,
catalog_entries.clone(),
));
tools.register_extension_tools(Arc::clone(&manager));
-1
View File
@@ -70,7 +70,6 @@ pub async fn extensions_list_handler(
tools: ext.tools,
needs_setup: ext.needs_setup,
has_auth: ext.has_auth,
derived: ext.derived,
activation_status,
activation_error: ext.activation_error,
version: ext.version,
-6
View File
@@ -2092,7 +2092,6 @@ async fn extensions_list_handler(
tools: ext.tools,
needs_setup: ext.needs_setup,
has_auth: ext.has_auth,
derived: ext.derived,
activation_status,
activation_error: ext.activation_error,
version: ext.version,
@@ -2949,7 +2948,6 @@ mod tests {
tools: Vec::new(),
needs_setup: true,
has_auth: false,
derived: false,
installed: true,
activation_error: None,
version: None,
@@ -2987,7 +2985,6 @@ mod tests {
tools: Vec::new(),
needs_setup: true,
has_auth: false,
derived: false,
installed: true,
activation_error: None,
version: None,
@@ -4180,8 +4177,6 @@ mod tests {
let ext_mgr = Arc::new(ExtensionManager::new(
mcp_sm,
mcp_pm,
None,
None,
secrets,
tool_registry,
None,
@@ -4191,7 +4186,6 @@ mod tests {
None,
"test".to_string(),
None,
None,
vec![],
));
(ext_mgr, wasm_tools_dir, wasm_channels_dir)
+10 -23
View File
@@ -1160,7 +1160,7 @@ function addToolCard(name) {
const toolName = document.createElement('span');
toolName.className = 'activity-tool-name';
toolName.textContent = humanizeToolName(name);
toolName.textContent = name;
const duration = document.createElement('span');
duration.className = 'activity-tool-duration';
@@ -1344,7 +1344,7 @@ function finalizeActivityGroup() {
function humanizeToolName(rawName) {
if (!rawName) return '';
return stripDerivedCompanionToolPrefix(String(rawName))
return String(rawName)
.replace(/[_-]+/g, ' ')
.replace(/([a-z0-9])([A-Z])/g, '$1 $2')
.replace(/^tool([a-zA-Z])/, 'tool $1')
@@ -1352,12 +1352,6 @@ function humanizeToolName(rawName) {
.trim();
}
function stripDerivedCompanionToolPrefix(rawName) {
if (!rawName) return '';
const prefix = '_nearai_companion_mcp_';
return rawName.startsWith(prefix) ? rawName.slice(prefix.length) : rawName;
}
function shouldShowChannelConnectedMessage(extensionName, success) {
if (!success || !extensionName) return false;
return String(extensionName).toLowerCase().includes('telegram');
@@ -1877,7 +1871,7 @@ function createToolCallsSummaryElement(toolCalls) {
const icon = tc.has_error ? '\u2717' : '\u2713';
const nameSpan = document.createElement('span');
nameSpan.className = 'tool-call-name';
nameSpan.textContent = icon + ' ' + humanizeToolName(tc.name);
nameSpan.textContent = icon + ' ' + tc.name;
item.appendChild(nameSpan);
if (tc.result_preview) {
@@ -2912,12 +2906,7 @@ function renderExtensionCard(ext) {
if (ext.tools && ext.tools.length > 0) {
const tools = document.createElement('div');
tools.className = 'ext-tools';
const toolNames = ext.tools.map((toolName) => (
ext.derived && ext.kind === 'mcp_server'
? stripDerivedCompanionToolPrefix(toolName)
: toolName
));
tools.textContent = 'Tools: ' + toolNames.join(', ');
tools.textContent = 'Tools: ' + ext.tools.join(', ');
card.appendChild(tools);
}
@@ -2978,7 +2967,7 @@ function renderExtensionCard(ext) {
// Skip when has_auth is true but needs_setup is false and not yet authenticated —
// this means OAuth credentials resolve automatically (builtin/env) and the user
// just needs to complete the OAuth flow, not fill in a config form.
if (!ext.derived && (ext.needs_setup || (ext.has_auth && ext.authenticated))) {
if (ext.needs_setup || (ext.has_auth && ext.authenticated)) {
const configBtn = document.createElement('button');
configBtn.className = 'btn-ext configure';
configBtn.textContent = ext.authenticated ? I18n.t('ext.reconfigure') : I18n.t('ext.configure');
@@ -2987,13 +2976,11 @@ function renderExtensionCard(ext) {
}
}
if (!ext.derived) {
const removeBtn = document.createElement('button');
removeBtn.className = 'btn-ext remove';
removeBtn.textContent = I18n.t('ext.remove');
removeBtn.addEventListener('click', () => removeExtension(ext.name));
actions.appendChild(removeBtn);
}
const removeBtn = document.createElement('button');
removeBtn.className = 'btn-ext remove';
removeBtn.textContent = I18n.t('ext.remove');
removeBtn.addEventListener('click', () => removeExtension(ext.name));
actions.appendChild(removeBtn);
card.appendChild(actions);
-3
View File
@@ -344,9 +344,6 @@ pub struct ExtensionInfo {
/// Whether this extension has an auth configuration (OAuth or manual token).
#[serde(default)]
pub has_auth: bool,
/// Whether this extension is derived from runtime/provider state.
#[serde(default)]
pub derived: bool,
/// WASM channel activation status.
#[serde(skip_serializing_if = "Option::is_none")]
pub activation_status: Option<ExtensionActivationStatus>,
+42 -326
View File
@@ -8,7 +8,7 @@ use std::sync::Arc;
use clap::{Args, Subcommand};
use crate::config::{Config, LlmConfig};
use crate::config::Config;
use crate::db::Database;
use crate::secrets::SecretsStore;
use crate::tools::mcp::{
@@ -173,13 +173,6 @@ async fn add_server(args: McpAddArgs) -> anyhow::Result<()> {
description,
} = args;
if config::is_nearai_companion_server_name(&name) {
anyhow::bail!(
"Server name '{}' is reserved for the NEAR AI companion MCP server",
name
);
}
let transport_lower = transport.to_lowercase();
let mut config = match transport_lower.as_str() {
@@ -251,7 +244,7 @@ async fn add_server(args: McpAddArgs) -> anyhow::Result<()> {
// Save (DB if available, else disk)
let db = connect_db().await;
let mut servers = load_persisted_servers(db.as_deref()).await?;
let mut servers = load_servers(db.as_deref()).await?;
servers.upsert(config);
save_servers(db.as_deref(), &servers).await?;
@@ -288,15 +281,8 @@ async fn add_server(args: McpAddArgs) -> anyhow::Result<()> {
/// Remove an MCP server.
async fn remove_server(name: String) -> anyhow::Result<()> {
if config::is_nearai_companion_server_name(&name) {
anyhow::bail!(
"Server '{}' is derived from the active NEAR AI provider and cannot be removed directly",
name
);
}
let db = connect_db().await;
let mut servers = load_persisted_servers(db.as_deref()).await?;
let mut servers = load_servers(db.as_deref()).await?;
if !servers.remove(&name) {
anyhow::bail!("Server '{}' not found", name);
}
@@ -312,7 +298,7 @@ async fn remove_server(name: String) -> anyhow::Result<()> {
/// List configured MCP servers.
async fn list_servers(verbose: bool) -> anyhow::Result<()> {
let db = connect_db().await;
let servers = load_servers_with_derived(db.as_deref()).await?;
let servers = load_servers(db.as_deref()).await?;
if servers.servers.is_empty() {
println!();
@@ -418,23 +404,12 @@ async fn list_servers(verbose: bool) -> anyhow::Result<()> {
async fn auth_server(name: String, user_id: String) -> anyhow::Result<()> {
// Get server config
let db = connect_db().await;
let servers = load_servers_with_derived(db.as_deref()).await?;
let servers = load_servers(db.as_deref()).await?;
let server = servers
.get(&name)
.cloned()
.ok_or_else(|| anyhow::anyhow!("Server '{}' not found", name))?;
if server.uses_runtime_auth_source() {
println!();
println!(
" Server '{}' reuses your active NEAR AI authentication and does not support separate MCP OAuth.",
name
);
println!(" Configure NEAR AI auth (API key or session login) instead.");
println!();
return Ok(());
}
// Initialize secrets store
let secrets = get_secrets_store().await?;
@@ -502,7 +477,7 @@ async fn auth_server(name: String, user_id: String) -> anyhow::Result<()> {
async fn test_server(name: String, user_id: String) -> anyhow::Result<()> {
// Get server config
let db = connect_db().await;
let servers = load_servers_with_derived(db.as_deref()).await?;
let servers = load_servers(db.as_deref()).await?;
let server = servers
.get(&name)
.cloned()
@@ -513,66 +488,35 @@ async fn test_server(name: String, user_id: String) -> anyhow::Result<()> {
// Create client
let session_manager = Arc::new(McpSessionManager::new());
let (client, has_tokens) = if server.uses_runtime_auth_source() {
let process_manager = Arc::new(McpProcessManager::new());
let llm = resolve_llm_for_cli(as_settings_store(db.as_deref())).await?;
let nearai_session = crate::llm::create_session_manager(llm.session.clone()).await;
(
create_client_from_config(
server.clone(),
&session_manager,
Some(nearai_session),
llm.nearai.api_key.clone(),
&process_manager,
None,
"default",
)
.await
.map_err(|e| anyhow::anyhow!("{}", e))?,
false,
)
} else {
// Only initialize the secrets store for non-runtime-auth servers that
// can actually use persisted OAuth/DCR tokens.
let secrets = get_secrets_store().await?;
let has_tokens = is_authenticated(&server, &secrets, &user_id).await;
if has_tokens {
(
McpClient::new_authenticated(
server.clone(),
session_manager.clone(),
secrets,
user_id,
),
true,
)
} else if server.requires_auth() {
println!();
println!(
" ✗ Not authenticated. Run 'ironclaw mcp auth {}' first.",
name
);
println!();
return Ok(());
} else {
// Use the factory to dispatch on transport type (HTTP, stdio, unix)
let process_manager = Arc::new(McpProcessManager::new());
(
create_client_from_config(
server.clone(),
&session_manager,
None,
None,
&process_manager,
None,
"default",
)
.await
.map_err(|e| anyhow::anyhow!("{}", e))?,
false,
)
}
// Always check for stored tokens (from either pre-configured OAuth or DCR)
let secrets = get_secrets_store().await?;
let has_tokens = is_authenticated(&server, &secrets, &user_id).await;
let client = if has_tokens {
// We have stored tokens, use authenticated client
McpClient::new_authenticated(server.clone(), session_manager.clone(), secrets, user_id)
} else if server.requires_auth() {
// OAuth configured but no tokens - need to authenticate
println!();
println!(
" ✗ Not authenticated. Run 'ironclaw mcp auth {}' first.",
name
);
println!();
return Ok(());
} else {
// Use the factory to dispatch on transport type (HTTP, stdio, unix)
let process_manager = Arc::new(McpProcessManager::new());
create_client_from_config(
server.clone(),
&session_manager,
&process_manager,
None,
"default",
)
.await
.map_err(|e| anyhow::anyhow!("{}", e))?
};
// Test connection
@@ -637,15 +581,8 @@ async fn test_server(name: String, user_id: String) -> anyhow::Result<()> {
/// Toggle server enabled/disabled state.
async fn toggle_server(name: String, enable: bool, disable: bool) -> anyhow::Result<()> {
if config::is_nearai_companion_server_name(&name) {
anyhow::bail!(
"Server '{}' is derived from the active NEAR AI provider and cannot be toggled directly",
name
);
}
let db = connect_db().await;
let mut servers = load_persisted_servers(db.as_deref()).await?;
let mut servers = load_servers(db.as_deref()).await?;
let server = servers
.get_mut(&name)
@@ -678,30 +615,13 @@ async fn connect_db() -> Option<Arc<dyn Database>> {
crate::db::connect_from_config(&config.database).await.ok()
}
/// Load only persisted MCP servers (DB if available, else disk).
async fn load_persisted_servers(
db: Option<&dyn Database>,
) -> Result<McpServersFile, config::ConfigError> {
Ok(if let Some(db) = db {
config::load_mcp_servers_from_db(db, DEFAULT_USER_ID).await?
/// Load MCP servers (DB if available, else disk).
async fn load_servers(db: Option<&dyn Database>) -> Result<McpServersFile, config::ConfigError> {
if let Some(db) = db {
config::load_mcp_servers_from_db(db, DEFAULT_USER_ID).await
} else {
config::load_mcp_servers().await?
})
}
/// Load MCP servers plus any derived runtime companions.
async fn load_servers_with_derived(
db: Option<&dyn Database>,
) -> Result<McpServersFile, config::ConfigError> {
let mut servers = load_persisted_servers(db).await?;
if let Ok(llm) = resolve_llm_for_cli(as_settings_store(db)).await
&& let Some(companion) = config::derive_nearai_companion_mcp_server_from_llm(&llm)
{
servers.insert_if_absent(companion);
config::load_mcp_servers().await
}
Ok(servers)
}
/// Save MCP servers (DB if available, else disk).
@@ -709,15 +629,10 @@ async fn save_servers(
db: Option<&dyn Database>,
servers: &McpServersFile,
) -> Result<(), config::ConfigError> {
let mut persisted = servers.clone();
persisted
.servers
.retain(|server| !config::is_nearai_companion_server_name(&server.name));
if let Some(db) = db {
config::save_mcp_servers_to_db(db, DEFAULT_USER_ID, &persisted).await
config::save_mcp_servers_to_db(db, DEFAULT_USER_ID, servers).await
} else {
config::save_mcp_servers(&persisted).await
config::save_mcp_servers(servers).await
}
}
@@ -726,84 +641,10 @@ async fn get_secrets_store() -> anyhow::Result<Arc<dyn SecretsStore + Send + Syn
crate::cli::init_secrets_store().await
}
fn as_settings_store(db: Option<&dyn Database>) -> Option<&(dyn crate::db::SettingsStore + Sync)> {
db.map(|db| db as &(dyn crate::db::SettingsStore + Sync))
}
async fn resolve_llm_for_cli(
store: Option<&(dyn crate::db::SettingsStore + Sync)>,
) -> Result<LlmConfig, crate::error::ConfigError> {
resolve_llm_for_cli_with_toml(store, None).await
}
async fn resolve_llm_for_cli_with_toml(
store: Option<&(dyn crate::db::SettingsStore + Sync)>,
toml_path: Option<&std::path::Path>,
) -> Result<LlmConfig, crate::error::ConfigError> {
if let Some(store) = store {
let _ = dotenvy::dotenv();
crate::bootstrap::load_ironclaw_env();
let mut settings = match store.get_all_settings(DEFAULT_USER_ID).await {
Ok(map) => crate::settings::Settings::from_db_map(&map),
Err(e) => {
tracing::warn!(
"Failed to load CLI settings from DB, falling back to defaults before env/TOML resolution: {}",
e
);
crate::settings::Settings::default()
}
};
apply_cli_toml_overlay(&mut settings, toml_path)?;
return LlmConfig::resolve(&settings);
}
let settings = crate::config::load_bootstrap_settings(toml_path)?;
LlmConfig::resolve(&settings)
}
fn apply_cli_toml_overlay(
settings: &mut crate::settings::Settings,
explicit_path: Option<&std::path::Path>,
) -> Result<(), crate::error::ConfigError> {
let path = explicit_path
.map(std::path::PathBuf::from)
.unwrap_or_else(crate::settings::Settings::default_toml_path);
match crate::settings::Settings::load_toml(&path) {
Ok(Some(toml_settings)) => {
settings.merge_from(&toml_settings);
}
Ok(None) => {
if explicit_path.is_some() {
return Err(crate::error::ConfigError::ParseError(format!(
"Config file not found: {}",
path.display()
)));
}
}
Err(e) => {
return Err(crate::error::ConfigError::ParseError(e));
}
}
Ok(())
}
#[cfg(test)]
mod tests {
use super::*;
use std::collections::HashMap;
use async_trait::async_trait;
use crate::error::DatabaseError;
use crate::history::SettingRow;
#[cfg(feature = "libsql")]
use tempfile::NamedTempFile;
#[test]
fn test_mcp_command_parsing() {
// Just verify the command structure is valid
@@ -860,129 +701,4 @@ mod tests {
assert!(result.is_err());
assert!(result.unwrap_err().contains("invalid env var format"));
}
#[cfg(feature = "libsql")]
#[allow(clippy::await_holding_lock)]
#[tokio::test]
async fn test_resolve_llm_for_cli_uses_db_backed_selected_model() {
struct MockSettingsStore {
settings: HashMap<String, serde_json::Value>,
}
#[async_trait]
impl crate::db::SettingsStore for MockSettingsStore {
async fn get_setting(
&self,
_user_id: &str,
key: &str,
) -> Result<Option<serde_json::Value>, DatabaseError> {
Ok(self.settings.get(key).cloned())
}
async fn get_setting_full(
&self,
_user_id: &str,
_key: &str,
) -> Result<Option<SettingRow>, DatabaseError> {
Ok(None)
}
async fn set_setting(
&self,
_user_id: &str,
_key: &str,
_value: &serde_json::Value,
) -> Result<(), DatabaseError> {
Err(DatabaseError::Query("unused in test".to_string()))
}
async fn delete_setting(
&self,
_user_id: &str,
_key: &str,
) -> Result<bool, DatabaseError> {
Err(DatabaseError::Query("unused in test".to_string()))
}
async fn list_settings(
&self,
_user_id: &str,
) -> Result<Vec<SettingRow>, DatabaseError> {
Ok(Vec::new())
}
async fn get_all_settings(
&self,
_user_id: &str,
) -> Result<HashMap<String, serde_json::Value>, DatabaseError> {
Ok(self.settings.clone())
}
async fn set_all_settings(
&self,
_user_id: &str,
_settings: &HashMap<String, serde_json::Value>,
) -> Result<(), DatabaseError> {
Err(DatabaseError::Query("unused in test".to_string()))
}
async fn has_settings(&self, _user_id: &str) -> Result<bool, DatabaseError> {
Ok(!self.settings.is_empty())
}
}
struct EnvGuard(&'static str, Option<String>);
impl Drop for EnvGuard {
fn drop(&mut self) {
// SAFETY: Protected by ENV_MUTEX for the duration of the test.
unsafe {
match &self.1 {
Some(value) => std::env::set_var(self.0, value),
None => std::env::remove_var(self.0),
}
}
}
}
let _mutex = crate::config::helpers::ENV_MUTEX.lock().expect("env mutex");
let prev_backend = std::env::var("LLM_BACKEND").ok();
let prev_base_url = std::env::var("NEARAI_BASE_URL").ok();
let prev_auth_url = std::env::var("NEARAI_AUTH_URL").ok();
let prev_model = std::env::var("NEARAI_MODEL").ok();
// SAFETY: Protected by ENV_MUTEX for the duration of the test.
unsafe {
std::env::set_var("LLM_BACKEND", "");
std::env::set_var("NEARAI_BASE_URL", "http://127.0.0.1:11434/v1");
std::env::set_var("NEARAI_AUTH_URL", "http://127.0.0.1:11435");
std::env::set_var("NEARAI_MODEL", "");
}
let _backend_guard = EnvGuard("LLM_BACKEND", prev_backend);
let _base_url_guard = EnvGuard("NEARAI_BASE_URL", prev_base_url);
let _auth_url_guard = EnvGuard("NEARAI_AUTH_URL", prev_auth_url);
let _model_guard = EnvGuard("NEARAI_MODEL", prev_model);
let empty_toml = NamedTempFile::new().expect("temp toml");
let store = MockSettingsStore {
settings: HashMap::from([
("llm_backend".to_string(), serde_json::json!("nearai")),
(
"selected_model".to_string(),
serde_json::json!("db-backed-nearai-model"),
),
]),
};
let llm = resolve_llm_for_cli_with_toml(Some(&store), Some(empty_toml.path()))
.await
.expect("resolve llm");
assert_eq!(llm.backend, "nearai");
assert_eq!(llm.nearai.model, "db-backed-nearai-model");
let companion =
config::derive_nearai_companion_mcp_server_from_llm(&llm).expect("derived companion");
assert_eq!(companion.url, "http://127.0.0.1:11434/mcp");
}
}
+18 -472
View File
@@ -366,8 +366,6 @@ pub struct ExtensionManager {
// MCP infrastructure
mcp_session_manager: Arc<McpSessionManager>,
mcp_process_manager: Arc<crate::tools::mcp::process::McpProcessManager>,
nearai_session_manager: Option<Arc<crate::llm::SessionManager>>,
nearai_api_key: Option<secrecy::SecretString>,
/// Active MCP clients keyed by server name.
mcp_clients: RwLock<HashMap<String, Arc<McpClient>>>,
@@ -391,8 +389,6 @@ pub struct ExtensionManager {
user_id: String,
/// Optional database store for DB-backed MCP config.
store: Option<Arc<dyn crate::db::Database>>,
/// Companion MCP server derived from the active provider config.
companion_mcp_server: Option<McpServerConfig>,
/// Names of WASM channels that were successfully loaded at startup.
active_channel_names: RwLock<HashSet<String>>,
/// Installed channel-relay extensions (no on-disk artifact, tracked in memory).
@@ -501,8 +497,6 @@ impl ExtensionManager {
pub fn new(
mcp_session_manager: Arc<McpSessionManager>,
mcp_process_manager: Arc<crate::tools::mcp::process::McpProcessManager>,
nearai_session_manager: Option<Arc<crate::llm::SessionManager>>,
nearai_api_key: Option<secrecy::SecretString>,
secrets: Arc<dyn SecretsStore + Send + Sync>,
tool_registry: Arc<ToolRegistry>,
hooks: Option<Arc<HookRegistry>>,
@@ -512,7 +506,6 @@ impl ExtensionManager {
tunnel_url: Option<String>,
user_id: String,
store: Option<Arc<dyn crate::db::Database>>,
companion_mcp_server: Option<McpServerConfig>,
catalog_entries: Vec<RegistryEntry>,
) -> Self {
let registry = if catalog_entries.is_empty() {
@@ -525,8 +518,6 @@ impl ExtensionManager {
discovery: OnlineDiscovery::new(),
mcp_session_manager,
mcp_process_manager,
nearai_session_manager,
nearai_api_key,
mcp_clients: RwLock::new(HashMap::new()),
wasm_tool_runtime,
wasm_tools_dir,
@@ -540,7 +531,6 @@ impl ExtensionManager {
tunnel_url,
user_id,
store,
companion_mcp_server,
active_channel_names: RwLock::new(HashSet::new()),
installed_relay_extensions: RwLock::new(HashSet::new()),
activation_errors: RwLock::new(HashMap::new()),
@@ -1279,12 +1269,6 @@ impl ExtensionManager {
tracing::info!(extension = %name, url = ?sanitized_url, kind = ?kind_hint, "Installing extension");
Self::validate_extension_name(name)?;
if crate::tools::mcp::config::is_nearai_companion_server_name(name) {
return Err(ExtensionError::Config(
"This extension name is reserved for the NEAR AI companion MCP server".to_string(),
));
}
// If we have a registry entry, use it (prefer kind_hint to resolve collisions)
if let Some(entry) = self.registry.get_with_kind(name, kind_hint).await {
return self.install_from_entry(&entry, user_id).await.map_err(|e| {
@@ -1360,32 +1344,6 @@ impl ExtensionManager {
}
}
/// Activate the derived NEAR AI companion MCP server if auth is already
/// available and the companion is not active yet.
///
/// Returns `Ok(true)` only when this call performed an activation.
pub async fn ensure_nearai_companion_active_if_ready(&self) -> Result<bool, ExtensionError> {
let Some(companion) = self.companion_mcp_server.as_ref() else {
return Ok(false);
};
let companion_name = companion.name.clone();
{
let clients = self.mcp_clients.read().await;
if clients.contains_key(&companion_name) {
return Ok(false);
}
}
if !self.is_runtime_authenticated(companion).await {
return Ok(false);
}
self.activate(&companion_name, &self.user_id).await?;
Ok(true)
}
/// List extensions with their status.
///
/// When `include_available` is `true`, registry entries that are not yet
@@ -1403,11 +1361,7 @@ impl ExtensionManager {
match self.load_mcp_servers(user_id).await {
Ok(servers) => {
for server in &servers.servers {
let authenticated = if server.uses_runtime_auth_source() {
self.is_runtime_authenticated(server).await
} else {
is_authenticated(server, &self.secrets, user_id).await
};
let authenticated = is_authenticated(server, &self.secrets, user_id).await;
let clients = self.mcp_clients.read().await;
let active = clients.contains_key(&server.name);
@@ -1423,17 +1377,11 @@ impl ExtensionManager {
Vec::new()
};
let display_name =
if crate::tools::mcp::config::is_nearai_companion_server_name(
&server.name,
) {
Some("NEAR AI Companion".to_string())
} else {
self.registry
.get_with_kind(&server.name, Some(ExtensionKind::McpServer))
.await
.map(|e| e.display_name)
};
let display_name = self
.registry
.get_with_kind(&server.name, Some(ExtensionKind::McpServer))
.await
.map(|e| e.display_name);
extensions.push(InstalledExtension {
name: server.name.clone(),
kind: ExtensionKind::McpServer,
@@ -1444,10 +1392,7 @@ impl ExtensionManager {
active,
tools,
needs_setup: false,
has_auth: server.requires_auth(),
derived: crate::tools::mcp::config::is_nearai_companion_server_name(
&server.name,
),
has_auth: false,
installed: true,
activation_error: None,
version: None,
@@ -1499,7 +1444,6 @@ impl ExtensionManager {
tools: if active { vec![name] } else { Vec::new() },
needs_setup: auth_state == ToolAuthState::NeedsSetup,
has_auth: auth_state != ToolAuthState::NoAuth,
derived: false,
installed: true,
activation_error: None,
version,
@@ -1556,7 +1500,6 @@ impl ExtensionManager {
tools: Vec::new(),
needs_setup: auth_state == ToolAuthState::NeedsSetup,
has_auth: auth_state != ToolAuthState::NoAuth,
derived: false,
installed: true,
activation_error,
version,
@@ -1595,7 +1538,6 @@ impl ExtensionManager {
tools: Vec::new(),
needs_setup: false,
has_auth: true,
derived: false,
installed: true,
activation_error,
version: None,
@@ -1630,7 +1572,6 @@ impl ExtensionManager {
tools: Vec::new(),
needs_setup: false,
has_auth: false,
derived: false,
installed: false,
activation_error: None,
version: entry.version,
@@ -1661,12 +1602,6 @@ impl ExtensionManager {
match kind {
ExtensionKind::McpServer => {
if crate::tools::mcp::config::is_nearai_companion_server_name(name) {
return Err(ExtensionError::Config(
"This MCP server is derived from the active NEAR AI provider and cannot be removed directly".to_string(),
));
}
// Unregister tools with this server's prefix
let tool_names: Vec<String> = self
.tool_registry
@@ -2124,39 +2059,10 @@ impl ExtensionManager {
user_id: &str,
) -> Result<crate::tools::mcp::config::McpServersFile, crate::tools::mcp::config::ConfigError>
{
let mut servers = if let Some(ref store) = self.store {
crate::tools::mcp::config::load_mcp_servers_from_db(store.as_ref(), user_id).await?
if let Some(ref store) = self.store {
crate::tools::mcp::config::load_mcp_servers_from_db(store.as_ref(), user_id).await
} else {
crate::tools::mcp::config::load_mcp_servers().await?
};
if let Some(ref companion) = self.companion_mcp_server {
servers.insert_if_absent(companion.clone());
}
Ok(servers)
}
async fn is_runtime_authenticated(&self, server: &McpServerConfig) -> bool {
match server.auth_source {
Some(crate::tools::mcp::config::McpAuthSource::NearAi) => {
if self.nearai_api_key.is_some() {
return true;
}
if let Some(key) = crate::config::helpers::env_or_override("NEARAI_API_KEY")
&& !key.trim().is_empty()
{
return true;
}
if let Some(ref session) = self.nearai_session_manager {
return session.has_token().await;
}
false
}
None => false,
crate::tools::mcp::config::load_mcp_servers().await
}
}
@@ -2718,20 +2624,6 @@ impl ExtensionManager {
.await
.map_err(|e| ExtensionError::NotInstalled(e.to_string()))?;
if server.uses_runtime_auth_source() {
if self.is_runtime_authenticated(&server).await {
return Ok(AuthResult::authenticated(name, ExtensionKind::McpServer));
}
return Ok(AuthResult::needs_setup(
name,
ExtensionKind::McpServer,
"This MCP server reuses your active NEAR AI authentication. Configure a NEAR AI API key or sign in to NEAR AI first, then try again."
.to_string(),
None,
));
}
// Check if already authenticated
if is_authenticated(&server, &self.secrets, user_id).await {
return Ok(AuthResult::authenticated(name, ExtensionKind::McpServer));
@@ -3783,8 +3675,6 @@ impl ExtensionManager {
let client = crate::tools::mcp::create_client_from_config(
server.clone(),
&self.mcp_session_manager,
self.nearai_session_manager.clone(),
self.nearai_api_key.clone(),
&self.mcp_process_manager,
Some(Arc::clone(&self.secrets)),
user_id,
@@ -5405,12 +5295,6 @@ impl ExtensionManager {
.get_mcp_server(name, user_id)
.await
.map_err(|e| ExtensionError::NotInstalled(e.to_string()))?;
if server.uses_runtime_auth_source() {
return Err(ExtensionError::Other(format!(
"Server '{}' reuses your active NEAR AI authentication and does not accept manually configured MCP tokens",
name
)));
}
let mut names = std::collections::HashSet::new();
names.insert(server.token_secret_name());
(names, Vec::new())
@@ -6415,8 +6299,6 @@ mod tests {
tools_dir: std::path::PathBuf,
channels_dir: std::path::PathBuf,
store: Option<Arc<dyn crate::db::Database>>,
companion_mcp_server: Option<crate::tools::mcp::config::McpServerConfig>,
nearai_session_manager: Option<Arc<crate::llm::SessionManager>>,
) -> crate::extensions::manager::ExtensionManager {
use crate::secrets::{InMemorySecretsStore, SecretsCrypto};
use crate::tools::mcp::process::McpProcessManager;
@@ -6435,18 +6317,15 @@ mod tests {
crate::extensions::manager::ExtensionManager::new(
mcp,
Arc::new(McpProcessManager::new()),
nearai_session_manager,
None,
secrets,
tools,
None, // hooks
wasm_runtime,
tools_dir,
channels_dir,
None, // tunnel_url
"test".to_string(),
None, // tunnel_url
"test".to_string(), // user_id
store,
companion_mcp_server,
vec![],
)
}
@@ -6455,7 +6334,7 @@ mod tests {
wasm_runtime: Option<Arc<crate::tools::wasm::WasmToolRuntime>>,
tools_dir: std::path::PathBuf,
) -> crate::extensions::manager::ExtensionManager {
make_test_manager_with_dirs(wasm_runtime, tools_dir.clone(), tools_dir, None, None, None)
make_test_manager_with_dirs(wasm_runtime, tools_dir.clone(), tools_dir, None)
}
fn write_test_tool(
@@ -6516,8 +6395,6 @@ mod tests {
dir.path().join("tools"),
dir.path().join("channels"),
Some(Arc::clone(&store)),
None,
None,
);
let field = crate::tools::wasm::ToolFieldSetupSchema {
name: "provider".to_string(),
@@ -6559,14 +6436,8 @@ mod tests {
);
let channels_dir = dir.path().join("channels");
let mgr = make_test_manager_with_dirs(
None,
tools_dir,
channels_dir,
Some(Arc::clone(&store)),
None,
None,
);
let mgr =
make_test_manager_with_dirs(None, tools_dir, channels_dir, Some(Arc::clone(&store)));
let mut fields = std::collections::HashMap::new();
fields.insert("llm_backend".to_string(), "openai".to_string());
@@ -6618,14 +6489,8 @@ mod tests {
);
let channels_dir = dir.path().join("channels");
let mgr = make_test_manager_with_dirs(
None,
tools_dir,
channels_dir,
Some(Arc::clone(&store)),
None,
None,
);
let mgr =
make_test_manager_with_dirs(None, tools_dir, channels_dir, Some(Arc::clone(&store)));
let mut fields = std::collections::HashMap::new();
fields.insert("session".to_string(), "overwrite".to_string());
@@ -6698,272 +6563,6 @@ mod tests {
);
}
#[tokio::test]
async fn test_install_rejects_reserved_nearai_companion_name() {
let dir = tempfile::tempdir().expect("temp dir");
let manager = make_test_manager(None, dir.path().to_path_buf());
let err = manager
.install(
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME,
Some("https://mcp.example.com"),
Some(ExtensionKind::McpServer),
"test",
)
.await
.expect_err("reserved companion name should be rejected");
assert!(
matches!(err, ExtensionError::Config(_)),
"Expected config error, got: {err:?}"
);
assert!(
err.to_string().contains("reserved"),
"Expected reserved-name message, got: {err}"
);
}
#[tokio::test]
async fn test_ensure_nearai_companion_active_if_ready_skips_without_auth() {
let dir = tempfile::tempdir().expect("temp dir");
let companion = crate::tools::mcp::config::McpServerConfig::new(
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME,
"https://private.near.ai/mcp",
)
.with_auth_source(crate::tools::mcp::config::McpAuthSource::NearAi);
let manager = make_test_manager_with_dirs(
None,
dir.path().join("tools"),
dir.path().join("channels"),
None,
Some(companion),
None,
);
let activated = manager
.ensure_nearai_companion_active_if_ready()
.await
.expect("helper should not fail when auth is missing");
assert!(!activated, "companion should not activate without auth");
assert!(
!manager
.mcp_clients
.read()
.await
.contains_key(crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME)
);
}
#[allow(clippy::await_holding_lock)]
#[tokio::test]
async fn test_runtime_auth_detects_runtime_nearai_api_key_override() {
struct EnvGuard(&'static str, Option<String>);
impl Drop for EnvGuard {
fn drop(&mut self) {
// SAFETY: Protected by ENV_MUTEX for the duration of the test.
unsafe {
match &self.1 {
Some(value) => std::env::set_var(self.0, value),
None => std::env::remove_var(self.0),
}
}
crate::config::helpers::set_runtime_env(self.0, "");
}
}
let _mutex = crate::config::helpers::ENV_MUTEX.lock().expect("env mutex");
let prev = std::env::var("NEARAI_API_KEY").ok();
// SAFETY: Protected by ENV_MUTEX for the duration of the test.
unsafe { std::env::remove_var("NEARAI_API_KEY") };
let _env_guard = EnvGuard("NEARAI_API_KEY", prev);
crate::config::helpers::set_runtime_env("NEARAI_API_KEY", "runtime-overlay-key");
let dir = tempfile::tempdir().expect("temp dir");
let companion = crate::tools::mcp::config::McpServerConfig::new(
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME,
"https://private.near.ai/mcp",
)
.with_auth_source(crate::tools::mcp::config::McpAuthSource::NearAi);
let manager = make_test_manager_with_dirs(
None,
dir.path().join("tools"),
dir.path().join("channels"),
None,
Some(companion.clone()),
None,
);
assert!(
manager.is_runtime_authenticated(&companion).await,
"runtime NEARAI_API_KEY override should count as authenticated"
);
}
async fn start_runtime_auth_mock_mcp_server() -> (String, tokio::task::JoinHandle<()>) {
use axum::extract::State;
use axum::http::{HeaderMap, StatusCode};
use axum::response::IntoResponse;
use axum::routing::post;
use axum::{Json, Router};
use std::sync::Arc;
#[derive(Clone)]
struct MockState {
auth_token: &'static str,
}
#[derive(serde::Deserialize)]
struct JsonRpcRequest {
id: Option<serde_json::Value>,
method: String,
}
async fn handle_mcp(
State(state): State<Arc<MockState>>,
headers: HeaderMap,
Json(req): Json<JsonRpcRequest>,
) -> impl IntoResponse {
let auth = headers
.get("authorization")
.and_then(|v| v.to_str().ok())
.unwrap_or("");
if auth != format!("Bearer {}", state.auth_token) {
return (
StatusCode::UNAUTHORIZED,
Json(serde_json::json!({
"jsonrpc": "2.0",
"id": req.id,
"error": {"code": -32000, "message": "Unauthorized"}
})),
)
.into_response();
}
if req.id.is_none() {
return StatusCode::OK.into_response();
}
let body = match req.method.as_str() {
"initialize" => serde_json::json!({
"jsonrpc": "2.0",
"id": req.id,
"result": {
"protocolVersion": "2024-11-05",
"serverInfo": {
"name": "mock-mcp-server",
"version": "1.0.0"
},
"capabilities": {
"tools": {}
}
}
}),
"tools/list" => serde_json::json!({
"jsonrpc": "2.0",
"id": req.id,
"result": {
"tools": [{
"name": "echo",
"description": "Mock companion tool",
"inputSchema": {
"type": "object",
"properties": {}
}
}]
}
}),
_ => serde_json::json!({
"jsonrpc": "2.0",
"id": req.id,
"error": {
"code": -32601,
"message": format!("Method not found: {}", req.method)
}
}),
};
Json(body).into_response()
}
let listener = tokio::net::TcpListener::bind("127.0.0.1:0")
.await
.expect("bind mock MCP server");
let addr = listener.local_addr().expect("local addr");
let base_url = format!("http://127.0.0.1:{}", addr.port());
let app = Router::new()
.route("/mcp", post(handle_mcp))
.with_state(Arc::new(MockState {
auth_token: "mock-access-token",
}));
let handle = tokio::spawn(async move {
axum::serve(listener, app).await.expect("serve mock MCP");
});
(format!("{base_url}/mcp"), handle)
}
#[tokio::test]
async fn test_ensure_nearai_companion_active_if_ready_activates_after_auth_becomes_available() {
let dir = tempfile::tempdir().expect("temp dir");
let (mcp_url, server_handle) = start_runtime_auth_mock_mcp_server().await;
let session = Arc::new(crate::llm::SessionManager::new(
crate::llm::SessionConfig::default(),
));
let companion = crate::tools::mcp::config::McpServerConfig::new(
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME,
mcp_url,
)
.with_auth_source(crate::tools::mcp::config::McpAuthSource::NearAi);
let manager = make_test_manager_with_dirs(
None,
dir.path().join("tools"),
dir.path().join("channels"),
None,
Some(companion),
Some(session.clone()),
);
let first = manager
.ensure_nearai_companion_active_if_ready()
.await
.expect("helper should skip cleanly before auth exists");
assert!(!first, "companion should not activate before auth exists");
session
.set_token(secrecy::SecretString::from("mock-access-token"))
.await;
let second = manager
.ensure_nearai_companion_active_if_ready()
.await
.expect("helper should activate once auth becomes available");
assert!(second, "companion should activate after auth appears");
assert!(
manager
.mcp_clients
.read()
.await
.contains_key(crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME)
);
assert!(
manager.tool_registry.list().await.into_iter().any(|name| {
name == format!(
"{}_echo",
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME
)
}),
"expected companion tool to be registered after delayed activation"
);
server_handle.abort();
}
#[test]
fn test_capabilities_files_also_separate() {
// capabilities.json files for tools and channels should also be separate.
@@ -7086,8 +6685,6 @@ mod tests {
ExtensionManager::new(
Arc::new(McpSessionManager::new()),
Arc::new(McpProcessManager::new()),
None,
None,
Arc::new(InMemorySecretsStore::new(crypto)),
Arc::new(ToolRegistry::new()),
None,
@@ -7097,7 +6694,6 @@ mod tests {
None,
"test".to_string(),
None,
None,
Vec::new(),
)
}
@@ -7239,8 +6835,6 @@ mod tests {
ExtensionManager::new(
Arc::new(McpSessionManager::new()),
Arc::new(McpProcessManager::new()),
None,
None,
Arc::new(InMemorySecretsStore::new(crypto)),
Arc::new(ToolRegistry::new()),
None,
@@ -7250,7 +6844,6 @@ mod tests {
None,
"test".to_string(),
Some(db),
None,
Vec::new(),
)
};
@@ -7504,8 +7097,6 @@ mod tests {
let manager = ExtensionManager::new(
Arc::new(McpSessionManager::new()),
Arc::new(McpProcessManager::new()),
None,
None,
Arc::new(InMemorySecretsStore::new(crypto)),
Arc::new(ToolRegistry::new()),
None,
@@ -7515,7 +7106,6 @@ mod tests {
None,
"test".to_string(),
Some(db.clone() as Arc<dyn crate::db::Database>),
None,
Vec::new(),
);
@@ -8000,8 +7590,7 @@ mod tests {
let dir = tempfile::tempdir().expect("temp dir");
let tools_dir = dir.path().join("tools");
let channels_dir = dir.path().join("channels");
let mgr =
make_test_manager_with_dirs(None, tools_dir, channels_dir.clone(), None, None, None);
let mgr = make_test_manager_with_dirs(None, tools_dir, channels_dir.clone(), None);
let wasm_path = channels_dir.join("telegram.wasm");
let cap_path = channels_dir.join("telegram.capabilities.json");
@@ -8145,8 +7734,6 @@ mod tests {
ExtensionManager::new(
mcp,
Arc::new(McpProcessManager::new()),
None,
None,
secrets,
tools,
None,
@@ -8156,7 +7743,6 @@ mod tests {
tunnel_url,
"test".to_string(),
None,
None,
vec![],
)
}
@@ -8439,46 +8025,6 @@ mod tests {
);
}
#[tokio::test]
async fn test_configure_token_rejects_runtime_auth_companion() {
let dir = tempfile::tempdir().expect("temp dir");
let companion = crate::tools::mcp::config::McpServerConfig::new(
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME,
"https://private.near.ai/mcp",
)
.with_auth_source(crate::tools::mcp::config::McpAuthSource::NearAi);
let token_secret_name = companion.token_secret_name();
let mgr = make_test_manager_with_dirs(
None,
dir.path().join("tools"),
dir.path().join("channels"),
None,
Some(companion),
None,
);
let err = mgr
.configure_token(
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME,
"manual-token",
"test",
)
.await
.expect_err("runtime-auth companion should reject manual token configuration");
assert!(
err.to_string().contains("active NEAR AI authentication"),
"expected runtime-auth rejection message, got: {err}"
);
assert!(
!mgr.secrets
.exists("test", &token_secret_name)
.await
.unwrap_or(false),
"configure_token must not persist a manual MCP token for the runtime-auth companion"
);
}
#[tokio::test]
async fn test_auth_is_read_only_for_wasm_channel() {
// Regression: auth() must be a pure status check — it must not store
-8
View File
@@ -506,10 +506,6 @@ pub struct InstalledExtension {
/// Whether this extension has an auth configuration (OAuth or manual token).
#[serde(default)]
pub has_auth: bool,
/// Whether this extension is derived from provider/runtime state instead of
/// being a user-managed persisted configuration.
#[serde(default)]
pub derived: bool,
/// Whether this extension is installed locally (false = available in registry but not installed).
#[serde(default = "default_true")]
pub installed: bool,
@@ -940,7 +936,6 @@ mod tests {
assert!(ext.installed, "installed should default to true");
assert!(!ext.needs_setup, "needs_setup should default to false");
assert!(!ext.has_auth);
assert!(!ext.derived);
assert!(ext.tools.is_empty());
assert!(ext.display_name.is_none());
assert!(ext.description.is_none());
@@ -961,7 +956,6 @@ mod tests {
tools: vec!["send_email".to_string(), "read_inbox".to_string()],
needs_setup: true,
has_auth: true,
derived: true,
installed: false,
activation_error: Some("token expired".to_string()),
version: None,
@@ -971,7 +965,6 @@ mod tests {
assert_eq!(json["description"], "Read and send emails");
assert_eq!(json["url"], "https://gmail.example.com");
assert_eq!(json["needs_setup"], true);
assert_eq!(json["derived"], true);
assert_eq!(json["installed"], false);
assert_eq!(json["activation_error"], "token expired");
@@ -979,7 +972,6 @@ mod tests {
assert_eq!(back.name, "gmail");
assert_eq!(back.tools.len(), 2);
assert!(back.needs_setup);
assert!(back.derived);
assert!(!back.installed);
assert_eq!(back.activation_error.as_deref(), Some("token expired"));
}
-2
View File
@@ -21,7 +21,6 @@ pub mod failover;
pub mod gemini_oauth;
mod github_copilot;
pub(crate) mod github_copilot_auth;
pub mod nearai_auth;
mod nearai_chat;
pub mod oauth_helpers;
pub mod openai_codex_provider;
@@ -54,7 +53,6 @@ pub use config::{
pub use error::LlmError;
pub use failover::{CooldownConfig, FailoverProvider};
pub use gemini_oauth::GeminiOauthProvider;
pub use nearai_auth::{resolve_nearai_bearer_token, resolve_nearai_bearer_token_if_available};
pub use nearai_chat::{DEFAULT_MODEL, ModelInfo, NearAiChatProvider, default_models};
pub use openai_codex_provider::OpenAiCodexProvider;
pub use openai_codex_session::{OpenAiCodexSession, OpenAiCodexSessionManager};
-95
View File
@@ -1,95 +0,0 @@
use secrecy::{ExposeSecret, SecretString};
use crate::llm::LlmError;
use crate::llm::session::SessionManager;
/// Resolve the active NEAR AI bearer token only if already available.
///
/// Unlike [`resolve_nearai_bearer_token`], this helper is side-effect free:
/// it never triggers an interactive login flow.
pub async fn resolve_nearai_bearer_token_if_available(
api_key: Option<&SecretString>,
session: &SessionManager,
) -> Result<Option<String>, LlmError> {
if let Some(api_key) = api_key {
return Ok(Some(api_key.expose_secret().to_string()));
}
if session.has_token().await {
let token = session.get_token().await?;
return Ok(Some(token.expose_secret().to_string()));
}
if let Some(key) = crate::config::helpers::env_or_override("NEARAI_API_KEY") {
return Ok(Some(key));
}
Ok(None)
}
/// Resolve the active NEAR AI bearer token.
///
/// Priority order:
/// 1. Explicit API key from resolved config
/// 2. Existing session token
/// 3. Interactive session authentication
/// 4. `NEARAI_API_KEY` from runtime environment
pub async fn resolve_nearai_bearer_token(
api_key: Option<&SecretString>,
session: &SessionManager,
) -> Result<String, LlmError> {
if let Some(token) = resolve_nearai_bearer_token_if_available(api_key, session).await? {
return Ok(token);
}
session.ensure_authenticated().await?;
if let Some(token) = resolve_nearai_bearer_token_if_available(api_key, session).await? {
return Ok(token);
}
Err(LlmError::AuthFailed {
provider: "nearai".to_string(),
})
}
#[cfg(test)]
mod tests {
use super::*;
use crate::config::helpers::{ENV_MUTEX, set_runtime_env};
use crate::llm::session::SessionConfig;
struct EnvGuard(&'static str, Option<String>);
impl Drop for EnvGuard {
fn drop(&mut self) {
// SAFETY: tests hold ENV_MUTEX while mutating the process environment.
unsafe {
match &self.1 {
Some(value) => std::env::set_var(self.0, value),
None => std::env::remove_var(self.0),
}
}
set_runtime_env(self.0, "");
}
}
#[allow(clippy::await_holding_lock)]
#[tokio::test]
async fn test_resolve_bearer_token_if_available_uses_runtime_env_override() {
let _guard = ENV_MUTEX.lock().expect("env mutex");
let prev = std::env::var("NEARAI_API_KEY").ok();
// SAFETY: tests hold ENV_MUTEX while mutating the process environment.
unsafe { std::env::remove_var("NEARAI_API_KEY") };
let _env_guard = EnvGuard("NEARAI_API_KEY", prev);
set_runtime_env("NEARAI_API_KEY", "runtime-overlay-key");
let session = SessionManager::new(SessionConfig::default());
let token = resolve_nearai_bearer_token_if_available(None, &session)
.await
.expect("resolve token");
assert_eq!(token.as_deref(), Some("runtime-overlay-key"));
}
}
+30 -1
View File
@@ -173,7 +173,36 @@ impl NearAiChatProvider {
/// The env var fallback (#3) only triggers after `ensure_authenticated()`
/// runs, because `api_key_login()` sets the env var but not a session token.
async fn resolve_bearer_token(&self) -> Result<String, LlmError> {
crate::llm::resolve_nearai_bearer_token(self.config.api_key.as_ref(), &self.session).await
// 1. Config-level API key takes priority
if let Some(ref api_key) = self.config.api_key {
return Ok(api_key.expose_secret().to_string());
}
// 2. Existing session token (OAuth was already completed)
if self.session.has_token().await {
let token = self.session.get_token().await?;
return Ok(token.expose_secret().to_string());
}
// No token yet, trigger interactive login
self.session.ensure_authenticated().await?;
// 3. After login, check if a session token was stored (OAuth path)
if self.session.has_token().await {
let token = self.session.get_token().await?;
return Ok(token.expose_secret().to_string());
}
// 4. api_key_login() sets NEARAI_API_KEY env var but not a session token
if let Ok(key) = std::env::var("NEARAI_API_KEY")
&& !key.is_empty()
{
return Ok(key);
}
Err(LlmError::AuthFailed {
provider: "nearai".to_string(),
})
}
/// Send a single request to the chat completions API.
-3
View File
@@ -139,8 +139,6 @@ mod tests {
Arc::new(ExtensionManager::new(
Arc::new(McpSessionManager::new()),
Arc::new(McpProcessManager::new()),
None,
None,
secrets,
tools,
Some(Arc::new(HookRegistry::default())),
@@ -150,7 +148,6 @@ mod tests {
None,
owner_id.to_string(),
None,
None,
Vec::new(),
))
}
-3
View File
@@ -800,8 +800,6 @@ mod tests {
Arc::new(ExtensionManager::new(
Arc::new(McpSessionManager::new()),
Arc::new(crate::tools::mcp::process::McpProcessManager::new()),
None,
None,
Arc::new(InMemorySecretsStore::new(crypto)),
Arc::new(ToolRegistry::new()),
None,
@@ -811,7 +809,6 @@ mod tests {
None,
"test".to_string(),
None,
None,
Vec::new(),
))
}
+8 -311
View File
@@ -8,13 +8,12 @@ use std::sync::Arc;
use std::sync::atomic::{AtomicU64, Ordering};
use async_trait::async_trait;
use secrecy::SecretString;
use tokio::sync::RwLock;
use crate::context::JobContext;
use crate::secrets::SecretsStore;
use crate::tools::mcp::auth::refresh_access_token;
use crate::tools::mcp::config::{McpAuthSource, McpServerConfig};
use crate::tools::mcp::config::McpServerConfig;
use crate::tools::mcp::http_transport::HttpMcpTransport;
use crate::tools::mcp::protocol::{
CallToolResult, InitializeResult, ListToolsResult, McpRequest, McpResponse, McpTool,
@@ -47,13 +46,6 @@ pub struct McpClient {
/// Session manager (shared across clients).
session_manager: Option<Arc<McpSessionManager>>,
/// NEAR AI auth/session manager for companion MCP servers that reuse the
/// active provider bearer token.
nearai_session_manager: Option<Arc<crate::llm::SessionManager>>,
/// Resolved NEAR AI API key for companion MCP servers.
nearai_api_key: Option<SecretString>,
/// Secrets store for retrieving access tokens.
secrets: Option<Arc<dyn SecretsStore + Send + Sync>>,
@@ -88,8 +80,6 @@ impl McpClient {
next_id: AtomicU64::new(1),
tools_cache: RwLock::new(None),
session_manager: None,
nearai_session_manager: None,
nearai_api_key: None,
secrets: None,
user_id: "default".to_string(),
server_config: None,
@@ -113,8 +103,6 @@ impl McpClient {
next_id: AtomicU64::new(1),
tools_cache: RwLock::new(None),
session_manager: None,
nearai_session_manager: None,
nearai_api_key: None,
secrets: None,
user_id: "default".to_string(),
server_config: None,
@@ -135,9 +123,6 @@ impl McpClient {
/// the transport with session tracking.
#[cfg(test)]
pub fn new_with_config(config: McpServerConfig) -> Result<Self, ToolError> {
config
.validate()
.map_err(|e| ToolError::InvalidParameters(e.to_string()))?;
if !matches!(
config.effective_transport(),
crate::tools::mcp::config::EffectiveTransport::Http
@@ -159,8 +144,6 @@ impl McpClient {
next_id: AtomicU64::new(1),
tools_cache: RwLock::new(None),
session_manager: None,
nearai_session_manager: None,
nearai_api_key: None,
secrets: None,
user_id: "default".to_string(),
custom_headers: config.headers.clone(),
@@ -192,8 +175,6 @@ impl McpClient {
next_id: AtomicU64::new(1),
tools_cache: RwLock::new(None),
session_manager: Some(session_manager),
nearai_session_manager: None,
nearai_api_key: None,
secrets: Some(secrets),
user_id: user_id.into(),
server_config: Some(config),
@@ -230,8 +211,6 @@ impl McpClient {
next_id: AtomicU64::new(1),
tools_cache: RwLock::new(None),
session_manager,
nearai_session_manager: None,
nearai_api_key: None,
secrets,
user_id: user_id.into(),
server_config,
@@ -253,21 +232,6 @@ impl McpClient {
self
}
/// Attach the NEAR AI session manager for companion MCP auth reuse.
pub fn with_nearai_session_manager(
mut self,
nearai_session_manager: Arc<crate::llm::SessionManager>,
) -> Self {
self.nearai_session_manager = Some(nearai_session_manager);
self
}
/// Attach the resolved NEAR AI API key for companion MCP auth reuse.
pub fn with_nearai_api_key(mut self, nearai_api_key: Option<SecretString>) -> Self {
self.nearai_api_key = nearai_api_key;
self
}
/// Get the server name.
pub fn server_name(&self) -> &str {
&self.server_name
@@ -302,9 +266,6 @@ impl McpClient {
let Some(ref config) = self.server_config else {
return Ok(None);
};
if config.uses_runtime_auth_source() {
return Ok(None);
}
match secrets
.get_decrypted(&self.user_id, &config.token_secret_name())
.await
@@ -318,36 +279,6 @@ impl McpClient {
}
}
/// Resolve a runtime-provided auth token for companion MCP servers.
async fn get_runtime_auth_token(&self) -> Result<Option<String>, ToolError> {
let Some(ref config) = self.server_config else {
return Ok(None);
};
match config.auth_source {
Some(McpAuthSource::NearAi) => {
let Some(ref session_manager) = self.nearai_session_manager else {
return Err(ToolError::ExternalService(
"Missing NEAR AI session manager for companion MCP server".to_string(),
));
};
crate::llm::resolve_nearai_bearer_token_if_available(
self.nearai_api_key.as_ref(),
session_manager,
)
.await
.map_err(|e| {
ToolError::ExternalService(format!(
"Failed to resolve NEAR AI token for MCP server '{}': {}",
self.server_name, e
))
})
}
None => Ok(None),
}
}
/// Build the headers map for a request (auth, session-id, custom headers).
///
/// Custom headers are applied first. OAuth token injection is skipped if the
@@ -361,9 +292,6 @@ impl McpClient {
.custom_headers
.keys()
.any(|k| k.eq_ignore_ascii_case("authorization"));
if !has_custom_auth && let Some(token) = self.get_runtime_auth_token().await? {
headers.insert("Authorization".to_string(), format!("Bearer {}", token));
}
if !has_custom_auth && let Some(token) = self.get_access_token().await? {
let trimmed = token.trim();
if !trimmed.is_empty() {
@@ -584,12 +512,13 @@ impl McpClient {
)));
}
let raw_result = response
response
.result
.ok_or_else(|| ToolError::ExternalService("No result in MCP response".to_string()))?;
serde_json::from_value(raw_result)
.map_err(|e| ToolError::ExternalService(format!("Invalid tool result: {}", e)))
.ok_or_else(|| ToolError::ExternalService("No result in MCP response".to_string()))
.and_then(|r| {
serde_json::from_value(r)
.map_err(|e| ToolError::ExternalService(format!("Invalid tool result: {}", e)))
})
}
/// Clear the tools cache.
@@ -636,8 +565,6 @@ impl Clone for McpClient {
next_id: AtomicU64::new(self.next_id.load(Ordering::SeqCst)),
tools_cache: RwLock::new(None),
session_manager: self.session_manager.clone(),
nearai_session_manager: self.nearai_session_manager.clone(),
nearai_api_key: self.nearai_api_key.clone(),
secrets: self.secrets.clone(),
user_id: self.user_id.clone(),
server_config: self.server_config.clone(),
@@ -685,7 +612,7 @@ impl Tool for McpToolWrapper {
// Strip top-level null values before forwarding — LLMs often emit
// `"field": null` for optional params, but many MCP servers reject
// explicit nulls for fields that should simply be absent.
let params = normalize_mcp_tool_arguments(&self.tool.name, strip_top_level_nulls(params));
let params = strip_top_level_nulls(params);
let result = self.client.call_tool(&self.tool.name, params).await?;
let content: String = result
@@ -729,31 +656,6 @@ fn strip_top_level_nulls(value: serde_json::Value) -> serde_json::Value {
}
}
fn normalize_mcp_tool_arguments(tool_name: &str, value: serde_json::Value) -> serde_json::Value {
if tool_name != "web_search" {
return value;
}
let serde_json::Value::Object(mut map) = value else {
return value;
};
// Keep this intentionally narrow: only strip optional fields that the
// model frequently emits as empty strings. Provider-specific validation
// should remain server-side, and tighter constraints should come from the
// tool schema rather than client-side normalization.
map.retain(|key, value| match key.as_str() {
// Only strip known optional string fields. Never remove required
// fields like `query`, even when the model emits an empty string.
"country" | "freshness" | "goggles" | "result_filter" | "search_lang" | "ui_lang" => {
!value.as_str().is_some_and(|s| s.trim().is_empty())
}
_ => true,
});
serde_json::Value::Object(map)
}
#[cfg(test)]
mod tests {
use super::*;
@@ -921,138 +823,6 @@ mod tests {
assert!(client.has_session_manager());
}
#[tokio::test]
async fn test_build_request_headers_with_nearai_runtime_auth() {
use crate::llm::{
SessionConfig as NearAiSessionConfig, SessionManager as NearAiSessionManager,
};
use secrecy::SecretString;
let config = McpServerConfig::new(
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME,
"http://localhost:3000/mcp",
)
.with_auth_source(crate::tools::mcp::config::McpAuthSource::NearAi);
let nearai_session = Arc::new(NearAiSessionManager::new(NearAiSessionConfig::default()));
nearai_session
.set_token(SecretString::from("sess_test_token"))
.await;
let client = McpClient::new_with_config(config)
.expect("valid MCP config")
.with_nearai_session_manager(nearai_session);
let headers = client.build_request_headers().await.expect("headers");
assert_eq!(
headers.get("Authorization").map(String::as_str),
Some("Bearer sess_test_token")
);
}
#[tokio::test]
async fn test_build_request_headers_without_nearai_auth_does_not_trigger_login() {
use crate::llm::{
SessionConfig as NearAiSessionConfig, SessionManager as NearAiSessionManager,
};
let config = McpServerConfig::new(
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME,
"http://localhost:3000/mcp",
)
.with_auth_source(crate::tools::mcp::config::McpAuthSource::NearAi);
let nearai_session = Arc::new(NearAiSessionManager::new(NearAiSessionConfig::default()));
let client = McpClient::new_with_config(config)
.expect("valid MCP config")
.with_nearai_session_manager(nearai_session);
let headers = client.build_request_headers().await.expect("headers");
assert!(
!headers.contains_key("Authorization"),
"runtime auth should stay absent when no token is available"
);
}
#[tokio::test]
async fn test_build_request_headers_runtime_auth_ignores_persisted_mcp_token() {
use crate::llm::{
SessionConfig as NearAiSessionConfig, SessionManager as NearAiSessionManager,
};
use crate::secrets::{CreateSecretParams, DecryptedSecret, Secret, SecretError, SecretRef};
use secrecy::SecretString;
use uuid::Uuid;
struct PersistedTokenStore;
#[async_trait]
impl crate::secrets::SecretsStore for PersistedTokenStore {
async fn create(
&self,
_user_id: &str,
_params: CreateSecretParams,
) -> Result<Secret, SecretError> {
unimplemented!()
}
async fn get(&self, _user_id: &str, _name: &str) -> Result<Secret, SecretError> {
unimplemented!()
}
async fn get_decrypted(
&self,
_user_id: &str,
_name: &str,
) -> Result<DecryptedSecret, SecretError> {
DecryptedSecret::from_bytes(b"persisted-mcp-token".to_vec())
}
async fn exists(&self, _user_id: &str, _name: &str) -> Result<bool, SecretError> {
Ok(true)
}
async fn delete(&self, _user_id: &str, _name: &str) -> Result<bool, SecretError> {
Ok(true)
}
async fn list(&self, _user_id: &str) -> Result<Vec<SecretRef>, SecretError> {
Ok(Vec::new())
}
async fn record_usage(&self, _secret_id: Uuid) -> Result<(), SecretError> {
Ok(())
}
async fn is_accessible(
&self,
_user_id: &str,
_secret_name: &str,
_allowed_secrets: &[String],
) -> Result<bool, SecretError> {
Ok(true)
}
}
let config = McpServerConfig::new(
crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME,
"http://localhost:3000/mcp",
)
.with_auth_source(crate::tools::mcp::config::McpAuthSource::NearAi);
let nearai_session = Arc::new(NearAiSessionManager::new(NearAiSessionConfig::default()));
nearai_session
.set_token(SecretString::from("sess_runtime_token"))
.await;
let secrets: Arc<dyn crate::secrets::SecretsStore + Send + Sync> =
Arc::new(PersistedTokenStore);
let client = McpClient::new_authenticated(
config,
Arc::new(McpSessionManager::new()),
secrets,
"test-user",
)
.with_nearai_session_manager(nearai_session);
let headers = client.build_request_headers().await.expect("headers");
assert_eq!(
headers.get("Authorization").map(String::as_str),
Some("Bearer sess_runtime_token"),
"runtime auth must win even if a persisted MCP token exists"
);
}
#[test]
fn test_next_request_id_monotonically_increasing() {
let client = McpClient::new("http://localhost:1234");
@@ -1434,20 +1204,6 @@ mod tests {
);
}
#[test]
fn test_new_with_config_rejects_invalid_runtime_auth_name() {
let config = McpServerConfig::new("chat_api", "http://localhost:3000/mcp")
.with_auth_source(crate::tools::mcp::config::McpAuthSource::NearAi);
let err = match McpClient::new_with_config(config) {
Ok(_) => panic!("invalid runtime-auth config must be rejected"),
Err(err) => err.to_string(),
};
assert!(
err.contains(crate::tools::mcp::config::NEARAI_COMPANION_MCP_NAME),
"error should mention reserved companion requirement: {err}"
);
}
// --- Issue 13: McpToolWrapper unit tests ---
fn make_test_mcp_tool(destructive: bool) -> McpTool {
@@ -1678,63 +1434,4 @@ mod tests {
"Token must be trimmed before use in Authorization header"
);
}
#[test]
fn test_normalize_web_search_arguments_removes_empty_optional_fields() {
let input = serde_json::json!({
"query": "Rust MCP server example",
"goggles": "",
"result_filter": " ",
"ui_lang": "en-US"
});
let result = normalize_mcp_tool_arguments("web_search", input);
let obj = result.as_object().unwrap();
assert_eq!(obj["query"], "Rust MCP server example");
assert_eq!(obj["ui_lang"], "en-US");
assert!(!obj.contains_key("goggles"));
assert!(!obj.contains_key("result_filter"));
}
#[test]
fn test_normalize_web_search_arguments_strips_whitelisted_empty_optional_fields() {
let input = serde_json::json!({
"query": "Rust MCP server example",
"goggles": "",
"freshness": " ",
"country": "US"
});
let result = normalize_mcp_tool_arguments("web_search", input);
let obj = result.as_object().unwrap();
assert_eq!(obj["country"], "US");
assert!(!obj.contains_key("freshness"));
assert!(!obj.contains_key("goggles"));
}
#[test]
fn test_normalize_web_search_arguments_preserves_empty_required_query() {
let input = serde_json::json!({
"query": " ",
"goggles": "",
"country": "US"
});
let result = normalize_mcp_tool_arguments("web_search", input);
let obj = result.as_object().unwrap();
assert_eq!(obj["query"], " ");
assert_eq!(obj["country"], "US");
assert!(!obj.contains_key("goggles"));
}
#[test]
fn test_normalize_mcp_tool_arguments_leaves_other_tools_unchanged() {
let input = serde_json::json!({
"goggles": "",
"country": "us"
});
let result = normalize_mcp_tool_arguments("other_tool", input.clone());
assert_eq!(result, input);
}
}
+3 -211
View File
@@ -51,16 +51,6 @@ pub struct McpServerConfig {
#[serde(skip_serializing_if = "Option::is_none")]
pub oauth: Option<OAuthConfig>,
/// Built-in auth source provided by IronClaw at runtime.
///
/// This is used for companion MCP servers that should reuse an existing
/// provider identity instead of running their own MCP OAuth flow.
///
/// Security: this field is runtime-only. Persisted user config must not be
/// able to opt a server into reusing the active provider bearer token.
#[serde(default, skip_serializing, skip_deserializing)]
pub auth_source: Option<McpAuthSource>,
/// Whether this server is enabled.
#[serde(default = "default_true")]
pub enabled: bool,
@@ -70,14 +60,6 @@ pub struct McpServerConfig {
pub description: Option<String>,
}
/// Runtime-provided auth sources for MCP companion servers.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
#[serde(rename_all = "snake_case")]
pub enum McpAuthSource {
/// Reuse the active NEAR AI bearer token (session token or API key).
NearAi,
}
fn default_true() -> bool {
true
}
@@ -91,7 +73,6 @@ impl McpServerConfig {
transport: None,
headers: HashMap::new(),
oauth: None,
auth_source: None,
enabled: true,
description: None,
}
@@ -114,7 +95,6 @@ impl McpServerConfig {
}),
headers: HashMap::new(),
oauth: None,
auth_source: None,
enabled: true,
description: None,
}
@@ -130,7 +110,6 @@ impl McpServerConfig {
}),
headers: HashMap::new(),
oauth: None,
auth_source: None,
enabled: true,
description: None,
}
@@ -142,12 +121,6 @@ impl McpServerConfig {
self
}
/// Set a runtime-provided auth source.
pub fn with_auth_source(mut self, auth_source: McpAuthSource) -> Self {
self.auth_source = Some(auth_source);
self
}
/// Set description.
pub fn with_description(mut self, description: impl Into<String>) -> Self {
self.description = Some(description.into());
@@ -181,15 +154,6 @@ impl McpServerConfig {
});
}
if self.uses_runtime_auth_source() && !is_nearai_companion_server_name(&self.name) {
return Err(ConfigError::InvalidConfig {
reason: format!(
"Runtime auth source is only allowed for reserved server '{}'",
NEARAI_COMPANION_MCP_NAME
),
});
}
match self.effective_transport() {
EffectiveTransport::Http => {
if self.url.is_empty() {
@@ -258,11 +222,6 @@ impl McpServerConfig {
.any(|k| k.eq_ignore_ascii_case("authorization"))
}
/// Check if this server uses a built-in runtime auth bridge.
pub fn uses_runtime_auth_source(&self) -> bool {
self.auth_source.is_some()
}
/// Check if this server requires authentication.
///
/// Returns true if OAuth is pre-configured OR if this is a remote HTTPS server
@@ -275,7 +234,7 @@ impl McpServerConfig {
return false;
}
if self.oauth.is_some() || self.uses_runtime_auth_source() {
if self.oauth.is_some() {
return true;
}
// Remote HTTPS servers need auth handling (DCR, token refresh, 401 detection).
@@ -301,66 +260,6 @@ impl McpServerConfig {
}
}
/// Reserved name used for the companion MCP server derived from active NEAR AI config.
pub const NEARAI_COMPANION_MCP_NAME: &str = "_nearai_companion_mcp";
pub fn is_nearai_companion_server_name(name: &str) -> bool {
name == NEARAI_COMPANION_MCP_NAME
}
fn strip_reserved_nearai_companion_servers(config: &mut McpServersFile, source: &str) -> usize {
let len_before = config.servers.len();
config
.servers
.retain(|server| !is_nearai_companion_server_name(&server.name));
let removed = len_before.saturating_sub(config.servers.len());
if removed > 0 {
tracing::warn!(
count = removed,
source,
"Ignoring persisted reserved MCP companion config(s); this name is system-managed"
);
}
removed
}
/// Build the companion MCP server from the active NEAR AI config.
///
/// The MCP endpoint is treated as a sibling to the versioned REST API:
/// `https://host/v1` becomes `https://host/mcp`.
pub fn derive_nearai_companion_mcp_server(
config: &crate::config::Config,
) -> Option<McpServerConfig> {
derive_nearai_companion_mcp_server_from_llm(&config.llm)
}
/// Build the companion MCP server from an LLM config.
///
/// This lighter-weight helper is used by CLI code paths that should not need
/// to resolve the full application config (and therefore should not require
/// database configuration) just to discover the derived companion MCP server.
pub fn derive_nearai_companion_mcp_server_from_llm(
llm: &crate::config::LlmConfig,
) -> Option<McpServerConfig> {
if llm.backend != "nearai" {
return None;
}
let base = llm.nearai.base_url.trim_end_matches('/');
let mcp_base = base
.strip_suffix("/v1")
.unwrap_or(base)
.trim_end_matches('/');
Some(
McpServerConfig::new(NEARAI_COMPANION_MCP_NAME, format!("{mcp_base}/mcp"))
.with_auth_source(McpAuthSource::NearAi)
.with_description("Companion MCP server derived from the active NEAR AI provider"),
)
}
/// OAuth 2.1 configuration for an MCP server.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct OAuthConfig {
@@ -457,16 +356,6 @@ impl McpServersFile {
}
}
/// Insert a server only if no server with the same name already exists.
pub fn insert_if_absent(&mut self, config: McpServerConfig) -> bool {
if self.get(&config.name).is_some() {
false
} else {
self.servers.push(config);
true
}
}
/// Remove a server by name.
pub fn remove(&mut self, name: &str) -> bool {
let len_before = self.servers.len();
@@ -521,8 +410,7 @@ pub async fn load_mcp_servers_from(path: impl AsRef<Path>) -> Result<McpServersF
}
let content = fs::read_to_string(path).await?;
let mut config: McpServersFile = serde_json::from_str(&content)?;
strip_reserved_nearai_companion_servers(&mut config, &path.display().to_string());
let config: McpServersFile = serde_json::from_str(&content)?;
// Validate every server on load so corrupted configs are caught early
for server in &config.servers {
@@ -564,15 +452,6 @@ pub async fn save_mcp_servers_to(
/// Add a new MCP server configuration.
pub async fn add_mcp_server(config: McpServerConfig) -> Result<(), ConfigError> {
if is_nearai_companion_server_name(&config.name) {
return Err(ConfigError::InvalidConfig {
reason: format!(
"Server name '{}' is reserved for the NEAR AI companion MCP server",
config.name
),
});
}
config.validate()?;
let mut servers = load_mcp_servers().await?;
@@ -620,8 +499,7 @@ pub async fn load_mcp_servers_from_db(
) -> Result<McpServersFile, ConfigError> {
match store.get_setting(user_id, "mcp_servers").await {
Ok(Some(value)) => {
let mut config: McpServersFile = serde_json::from_value(value)?;
strip_reserved_nearai_companion_servers(&mut config, "database");
let config: McpServersFile = serde_json::from_value(value)?;
// Validate every server on load so corrupted DB configs are caught early
for server in &config.servers {
server.validate().map_err(|e| ConfigError::InvalidConfig {
@@ -664,15 +542,6 @@ pub async fn add_mcp_server_db(
user_id: &str,
config: McpServerConfig,
) -> Result<(), ConfigError> {
if is_nearai_companion_server_name(&config.name) {
return Err(ConfigError::InvalidConfig {
reason: format!(
"Server name '{}' is reserved for the NEAR AI companion MCP server",
config.name
),
});
}
config.validate()?;
let mut servers = load_mcp_servers_from_db(store, user_id).await?;
@@ -849,69 +718,6 @@ mod tests {
assert!(config.servers.is_empty());
}
#[tokio::test]
async fn test_load_drops_reserved_nearai_companion_server() {
let dir = tempdir().unwrap();
let path = dir.path().join("mcp-servers.json");
let persisted = serde_json::json!({
"servers": [
{
"name": NEARAI_COMPANION_MCP_NAME,
"url": "https://evil.example.com/mcp",
"enabled": true,
"auth_source": "near_ai"
},
{
"name": "notion",
"url": "https://mcp.notion.com",
"enabled": true
}
]
});
tokio::fs::write(&path, persisted.to_string())
.await
.unwrap();
let config = load_mcp_servers_from(&path).await.unwrap();
assert_eq!(config.servers.len(), 1);
assert!(config.get(NEARAI_COMPANION_MCP_NAME).is_none());
assert_eq!(
config.get("notion").map(|server| server.url.as_str()),
Some("https://mcp.notion.com")
);
}
#[test]
fn test_deserialize_ignores_persisted_auth_source() {
let raw = serde_json::json!({
"name": "user-managed",
"url": "https://mcp.example.com",
"enabled": true,
"auth_source": "near_ai"
});
let server: McpServerConfig = serde_json::from_value(raw).expect("server");
assert_eq!(server.auth_source, None);
}
#[cfg(feature = "libsql")]
#[test]
fn test_derive_nearai_companion_mcp_server_strips_trailing_v1() {
let mut config = crate::config::Config::for_testing(
std::env::temp_dir().join("ironclaw-test-companion.db"),
std::env::temp_dir().join("ironclaw-test-skills"),
std::env::temp_dir().join("ironclaw-test-installed-skills"),
);
config.llm.backend = "nearai".to_string();
config.llm.nearai.base_url = "https://private.near.ai/v1".to_string();
let server = derive_nearai_companion_mcp_server(&config).expect("companion server");
assert_eq!(server.name, NEARAI_COMPANION_MCP_NAME);
assert_eq!(server.url, "https://private.near.ai/mcp");
assert_eq!(server.auth_source, Some(McpAuthSource::NearAi));
}
#[tokio::test]
async fn test_load_rejects_corrupted_headers() {
let dir = tempdir().unwrap();
@@ -957,20 +763,6 @@ mod tests {
assert!(config.requires_auth());
}
#[test]
fn test_validate_rejects_runtime_auth_on_user_managed_server() {
let config = McpServerConfig::new("user-managed", "https://mcp.example.com")
.with_auth_source(McpAuthSource::NearAi);
let err = config
.validate()
.expect_err("runtime auth should be reserved for the companion server");
assert!(
err.to_string().contains(NEARAI_COMPANION_MCP_NAME),
"expected reserved-name validation message, got: {err}"
);
}
#[test]
fn test_requires_auth_remote_https_without_oauth() {
// Remote HTTPS servers need auth even without pre-configured OAuth (DCR)
+1 -33
View File
@@ -21,8 +21,6 @@ pub enum McpFactoryError {
UnixNotSupported { name: String },
#[error("Invalid configuration for MCP server '{name}': {reason}")]
InvalidConfig { name: String, reason: String },
#[error("Missing runtime auth context for MCP server '{name}': {reason}")]
MissingRuntimeAuthContext { name: String, reason: String },
}
/// Create an `McpClient` from a server configuration, dispatching on the
@@ -30,8 +28,6 @@ pub enum McpFactoryError {
pub async fn create_client_from_config(
server: McpServerConfig,
session_manager: &Arc<McpSessionManager>,
nearai_session_manager: Option<Arc<crate::llm::SessionManager>>,
nearai_api_key: Option<secrecy::SecretString>,
process_manager: &Arc<McpProcessManager>,
secrets: Option<Arc<dyn SecretsStore + Send + Sync>>,
user_id: &str,
@@ -83,31 +79,7 @@ pub async fn create_client_from_config(
Err(McpFactoryError::UnixNotSupported { name: server_name })
}
EffectiveTransport::Http => {
if server.uses_runtime_auth_source() {
let nearai_session_manager = nearai_session_manager.ok_or_else(|| {
McpFactoryError::MissingRuntimeAuthContext {
name: server_name.clone(),
reason: "NearAI companion MCP servers require a NearAI session manager"
.to_string(),
}
})?;
let transport = Arc::new(
HttpMcpTransport::new(server.url.clone(), server.name.clone())
.with_session_manager(Arc::clone(session_manager)),
);
return Ok(McpClient::new_with_transport(
server.name.clone(),
transport,
Some(Arc::clone(session_manager)),
secrets,
user_id,
Some(server),
)
.with_nearai_session_manager(nearai_session_manager)
.with_nearai_api_key(nearai_api_key));
}
// Authenticated (OAuth) path: tokens exist or server requires auth.
if let Some(ref secrets) = secrets {
let has_tokens =
crate::tools::mcp::is_authenticated(&server, secrets, user_id).await;
@@ -155,8 +127,6 @@ mod tests {
let client = create_client_from_config(
server,
&session_manager,
None,
None,
&process_manager,
None,
"test-user",
@@ -215,8 +185,6 @@ mod tests {
let client = create_client_from_config(
server,
&session_manager,
None,
None,
&process_manager,
None,
"test-user",
-3
View File
@@ -290,8 +290,6 @@ mod tests {
Arc::new(ExtensionManager::new(
Arc::new(McpSessionManager::new()),
Arc::new(McpProcessManager::new()),
None,
None,
secrets,
tools,
None,
@@ -301,7 +299,6 @@ mod tests {
None,
owner_id.to_string(),
None,
None,
Vec::new(),
))
}
-3
View File
@@ -203,8 +203,6 @@ async fn extension_manager_with_process_manager_constructs() {
let manager = ExtensionManager::new(
Arc::new(McpSessionManager::new()),
Arc::new(McpProcessManager::new()),
None,
None,
secrets,
tools,
None,
@@ -214,7 +212,6 @@ async fn extension_manager_with_process_manager_constructs() {
None,
"test".to_string(),
None,
None,
Vec::new(),
);