gitops/optimclaw
1
0
Fork 0
mirror of https://github.com/outbackdingo/optimclaw.git synced 2026-08-25 14:53:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: clarify test comment and use exact assertions

Browse Source 
Address Gemini review feedback:
- Fix misleading comment: \u{00e9} is precomposed e-acute, not combining accent
- Replace weak assertions (ends_with/is_empty) with exact assert_eq!

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This commit is contained in:
Zaki
2026-03-26 16:56:56 -07:00
co-authored by Claude Opus 4.6
parent 6198c98673
commit 9cb64dd8a7
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cli/memory.rs
+6 -8
View File
@@ -296,16 +296,14 @@ mod tests {
#[test]
fn test_truncate_content_multibyte_does_not_panic() {
// "cafe\u{0301}" = "café" where é is e + combining accent (2 bytes for accent)
// Slicing at byte 5 would land inside the combining character
let s = "caf\u{00e9} au lait"; // café = 5 bytes (é is 2 bytes)
let result = truncate_content(s, 4); // byte 4 is inside é
assert!(result.ends_with("..."));
assert!(!result.is_empty());
// \u{00e9} is precomposed 'é' (2 bytes in UTF-8)
let s = "caf\u{00e9} au lait"; // "café au lait", é starts at byte 3
let result = truncate_content(s, 4); // byte 4 is inside 2-byte é
assert_eq!(result, "caf...");
// 4-byte emoji: slicing mid-emoji must not panic
let emoji = "Hi \u{1F600} there"; // 😀 is 4 bytes
let emoji = "Hi \u{1F600} there"; // 😀 is 4 bytes, starts at byte 3
let result = truncate_content(emoji, 4); // byte 4 is inside 😀
assert!(result.ends_with("..."));
assert_eq!(result, "Hi ...");
}
}