wifi: mt76: mt7925: replace zero-length array with flexible-array member

mirror of https://github.com/outbackdingo/mt76.git synced 2026-10-24 13:26:48 +00:00

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1],
introduced in C99:

struct foo {
	int stuff;
	struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last, which is beneficial
to cultivate a high-quality code.[2]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Zhang Kunbo <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Felix Fietkau <[email protected]>

This commit is contained in:

Zhang Kunbo

2024-12-30 20:31:48 +01:00

committed by

Felix Fietkau

parent 5d12c7404c

commit ef965d408b

1 changed files with 1 additions and 1 deletions

									
										mt7925/mcu.c
									
		+1
		-1
	
												View File
												
				@@ -386,7 +386,7 @@ mt7925_mcu_tx_done_event(struct mt792x_dev *dev, struct sk_buff *skb)

					struct mt7925_mcu_txs_event {

						u8 ver;

						u8 rsv[3];

						u8 data[0];

						u8 data[];

					} __packed * txs;

					struct tlv *tlv;

					u32 tlv_len;