wifi: mt76: mt7921: add mt7921_mutex_acquire at mt7921_[start, stop]_ap

Add mt7921_mutex_acquire at mt7921_[start, stop]_ap to fix the race
with the context holding dev->muxtex and the driver might access the
device in low power state.

Fixes: 9d958b60ebc2 ("mt76: mt7921: fix command timeout in AP stop period")
Tested-by: AngeloGioacchino Del Regno <[email protected]>
Signed-off-by: Sean Wang <[email protected]>
Acked-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Felix Fietkau <[email protected]>
This commit is contained in:
Sean Wang
2022-09-15 13:14:11 +02:00
committed by Felix Fietkau
parent 019ef069e7
commit 0a392ca03d
+16 -5
View File
@@ -1524,17 +1524,23 @@ mt7921_start_ap(struct ieee80211_hw *hw,
struct mt7921_dev *dev = mt7921_hw_dev(hw);
int err;
mt7921_mutex_acquire(dev);
err = mt76_connac_mcu_uni_add_bss(phy->mt76, vif, &mvif->sta.wcid,
true);
if (err)
return err;
goto out;
err = mt7921_mcu_set_bss_pm(dev, vif, true);
if (err)
return err;
goto out;
return mt7921_mcu_sta_update(dev, NULL, vif, true,
MT76_STA_INFO_STATE_NONE);
err = mt7921_mcu_sta_update(dev, NULL, vif, true,
MT76_STA_INFO_STATE_NONE);
out:
mt7921_mutex_release(dev);
return err;
}
static void
@@ -1546,11 +1552,16 @@ mt7921_stop_ap(struct ieee80211_hw *hw,
struct mt7921_dev *dev = mt7921_hw_dev(hw);
int err;
mt7921_mutex_acquire(dev);
err = mt7921_mcu_set_bss_pm(dev, vif, false);
if (err)
return;
goto out;
mt76_connac_mcu_uni_add_bss(phy->mt76, vif, &mvif->sta.wcid, false);
out:
mt7921_mutex_release(dev);
}
const struct ieee80211_ops mt7921_ops = {