gitops/mt76
1
0
Fork 0
mirror of https://github.com/outbackdingo/mt76.git synced 2026-10-24 13:26:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

wifi: mt76: Drop unnecessary error check for debugfs_create_dir()

Browse Source 
debugfs_create_dir() returns ERR_PTR and never return NULL.

As Russell suggested, this patch removes the error checking for
debugfs_create_dir(). This is because the DebugFS kernel API is developed
in a way that the caller can safely ignore the errors that occur during
the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in
start_creating() which can handle it gracefully. So these checks are
unnecessary.

Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
Signed-off-by: Jinjie Ruan <[email protected]>
Suggested-by: Russell King (Oracle) <[email protected]>
Signed-off-by: Felix Fietkau <[email protected]>
This commit is contained in:
Jinjie Ruan
2023-09-16 14:13:34 +02:00
committed by Felix Fietkau
parent 791a45cffa
commit 08e1e6cb7d
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
debugfs.c
-3
View File
@@ -109,9 +109,6 @@ mt76_register_debugfs_fops(struct mt76_phy *phy,
struct dentry *dir;
dir = debugfs_create_dir("mt76", phy->hw->wiphy->debugfsdir);
if (!dir)
return NULL;
debugfs_create_u8("led_pin", 0600, dir, &phy->leds.pin);
debugfs_create_bool("led_active_low", 0600, dir, &phy->leds.al);
debugfs_create_u32("regidx", 0600, dir, &dev->debugfs_reg);