From 4f87ea96ca414c7cf36f0b4a6aa3cdfd4884f500 Mon Sep 17 00:00:00 2001 From: Alexander Kukushkin Date: Thu, 24 Aug 2017 07:55:30 +0200 Subject: [PATCH] "Could not take out TTL lock" message was never logged (#502) This is not a critical bug, because `attempt_to_acquire_leader` method was still returning False in this case. --- patroni/dcs/consul.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/patroni/dcs/consul.py b/patroni/dcs/consul.py index 4108f908..df907803 100644 --- a/patroni/dcs/consul.py +++ b/patroni/dcs/consul.py @@ -245,12 +245,14 @@ class Consul(AbstractDCS): return False @catch_consul_errors + def _do_attempt_to_acquire_leader(self, kwargs): + return self.retry(self._client.kv.put, self.leader_path, self._name, **kwargs) + def attempt_to_acquire_leader(self, permanent=False): if not self._session and not permanent: self.refresh_session() - args = {} if permanent else {'acquire': self._session} - ret = self.retry(self._client.kv.put, self.leader_path, self._name, **args) + ret = self._do_attempt_to_acquire_leader({} if permanent else {'acquire': self._session}) if not ret: logger.info('Could not take out TTL lock') return ret