Factor out tags handling into a dedicated class (#2823)

The same (almost) logic was used in three different places:
1. `Patroni` class
2. `Member` class
3. `_MemberStatus` class

Now they all inherit newly intoduced `Tags` class.

tests/test_api.py

@@ -100,7 +100,7 @@ class MockHa(object):
 
     @staticmethod
     def fetch_nodes_statuses(members):
-        return [_MemberStatus(None, True, None, 0, 0, None, {}, False)]
+        return [_MemberStatus(None, True, None, 0, {})]
 
     @staticmethod
     def schedule_future_restart(data):

tests/test_ha.py

@@ -99,7 +99,9 @@ def get_node_status(reachable=True, in_recovery=True, dcs_last_seen=0,
         tags = {}
         if nofailover:
             tags['nofailover'] = True
-        return _MemberStatus(e, reachable, in_recovery, dcs_last_seen, timeline, wal_position, tags, watchdog_failed)
+        return _MemberStatus(e, reachable, in_recovery, wal_position,
+                             {'tags': tags, 'watchdog_failed': watchdog_failed,
+                              'dcs_last_seen': dcs_last_seen, 'timeline': timeline})
     return fetch_node_status
 
 
@@ -1294,14 +1296,16 @@ class TestHa(PostgresInit):
         mock_restart.assert_called_once()
         self.ha.dcs.get_cluster.assert_not_called()
 
+    @patch.object(Cluster, 'is_unlocked', Mock(return_value=False))
     def test_enable_synchronous_mode(self):
         self.ha.is_synchronous_mode = true
         self.ha.has_lock = true
         self.p.name = 'leader'
+        self.p.sync_handler.current_state = Mock(return_value=(CaseInsensitiveSet(), CaseInsensitiveSet()))
         self.ha.dcs.write_sync_state = Mock(return_value=SyncState.empty())
         with patch('patroni.ha.logger.info') as mock_logger:
             self.ha.run_cycle()
-            self.assertEqual(mock_logger.call_args[0][0], 'Enabled synchronous replication')
+            self.assertEqual(mock_logger.call_args_list[0][0][0], 'Enabled synchronous replication')
         self.ha.dcs.write_sync_state = Mock(return_value=None)
         with patch('patroni.ha.logger.warning') as mock_logger:
             self.ha.run_cycle()

tests/test_patroni.py

@@ -185,7 +185,7 @@ class TestPatroni(unittest.TestCase):
 
     def test_reload_config(self):
         self.p.reload_config()
-        self.p.get_tags = Mock(side_effect=Exception)
+        self.p._get_tags = Mock(side_effect=Exception)
         self.p.reload_config(local=True)
 
     def test_nosync(self):