Refactor format_dsn() method (#3069)

so that it doesn't take any decisions about which keywords should appear in the connection string and just uses a provided dict.
This commit is contained in:
Alexander Kukushkin
2024-06-11 12:12:36 +02:00
committed by GitHub
parent 0a91948a49
commit 1b7b8e60fb
4 changed files with 60 additions and 39 deletions
+4 -1
View File
@@ -103,7 +103,10 @@ class TestRewind(BaseTestPostgresql):
@patch.object(Postgresql, 'stop', Mock(return_value=False))
@patch.object(Postgresql, 'start', Mock())
def test_execute(self, mock_checkpoint):
self.r.execute(self.leader)
with patch('patroni.postgresql.rewind.logger.info') as mock_logger:
self.r.execute(self.leader)
self.assertEqual(mock_logger.call_args_list[0][0],
('running pg_rewind from %s', 'dbname=postgres user=foo host=127.0.0.1 port=5435'))
with patch.object(Postgresql, 'major_version', PropertyMock(return_value=130000)):
self.r.execute(self.leader)
with patch.object(MockCursor, 'fetchone', Mock(side_effect=Exception)):