mirror of
https://github.com/outbackdingo/optimclaw.git
synced 2026-08-25 23:10:11 +00:00
* fix staging CI coverage regressions * ci: cover all e2e scenarios in staging * ci: restrict staging PR checks and fix webhook assertions * ci: keep code style checks on PRs * ci: preserve e2e PR coverage * test: stabilize staging e2e coverage * fix: propagate postgres tls builder errors
105 lines
3.8 KiB
Rust
105 lines
3.8 KiB
Rust
//! TLS connector factory for PostgreSQL connections.
|
|
//!
|
|
//! Builds a [`deadpool_postgres::Pool`] with the appropriate TLS connector
|
|
//! based on the configured [`SslMode`]. Uses `rustls` with system root
|
|
//! certificates — the same TLS stack that `reqwest` already uses for HTTP.
|
|
|
|
use deadpool_postgres::{Pool, Runtime};
|
|
use thiserror::Error;
|
|
use tokio_postgres::NoTls;
|
|
use tokio_postgres_rustls::MakeRustlsConnect;
|
|
|
|
use crate::config::SslMode;
|
|
|
|
#[derive(Debug, Error)]
|
|
pub enum CreatePoolError {
|
|
#[error("{0}")]
|
|
Pool(#[from] deadpool_postgres::CreatePoolError),
|
|
#[error("postgres TLS configuration failed: {0}")]
|
|
TlsConfig(#[from] rustls::Error),
|
|
}
|
|
|
|
/// Build a rustls-based TLS connector using the platform's root certificate store.
|
|
fn make_rustls_connector() -> Result<MakeRustlsConnect, rustls::Error> {
|
|
let mut root_store = rustls::RootCertStore::empty();
|
|
let native = rustls_native_certs::load_native_certs();
|
|
for e in &native.errors {
|
|
tracing::warn!("error loading system root certs: {e}");
|
|
}
|
|
for cert in native.certs {
|
|
if let Err(e) = root_store.add(cert) {
|
|
tracing::warn!("skipping invalid system root cert: {e}");
|
|
}
|
|
}
|
|
if root_store.is_empty() {
|
|
tracing::error!("no system root certificates found -- TLS connections will fail");
|
|
}
|
|
// `--all-features` brings in both aws-lc-rs and ring-backed rustls providers.
|
|
// Pick the same ring provider reqwest already uses so postgres TLS setup stays deterministic.
|
|
let config = rustls::ClientConfig::builder_with_provider(
|
|
rustls::crypto::ring::default_provider().into(),
|
|
)
|
|
.with_safe_default_protocol_versions()?
|
|
.with_root_certificates(root_store)
|
|
.with_no_client_auth();
|
|
Ok(MakeRustlsConnect::new(config))
|
|
}
|
|
|
|
/// Create a [`deadpool_postgres::Pool`] with the appropriate TLS connector.
|
|
///
|
|
/// - `Disable` → plain TCP (no TLS)
|
|
/// - `Prefer` / `Require` → rustls with system root certificates
|
|
///
|
|
/// **Note:** `Prefer` and `Require` currently behave identically — both
|
|
/// provide a TLS connector and will fail if the server rejects the TLS
|
|
/// handshake. True `prefer` semantics (retry without TLS on failure)
|
|
/// would require reconnection logic that tokio-postgres does not provide
|
|
/// out of the box. The three-variant enum is kept for forward-compatibility
|
|
/// and familiarity with libpq's `sslmode` parameter.
|
|
pub fn create_pool(
|
|
config: &deadpool_postgres::Config,
|
|
ssl_mode: SslMode,
|
|
) -> Result<Pool, CreatePoolError> {
|
|
match ssl_mode {
|
|
SslMode::Disable => config
|
|
.create_pool(Some(Runtime::Tokio1), NoTls)
|
|
.map_err(CreatePoolError::from),
|
|
SslMode::Prefer | SslMode::Require => {
|
|
let tls = make_rustls_connector()?;
|
|
config
|
|
.create_pool(Some(Runtime::Tokio1), tls)
|
|
.map_err(CreatePoolError::from)
|
|
}
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn create_pool_disable_mode() {
|
|
let mut config = deadpool_postgres::Config::new();
|
|
config.url = Some("postgres://localhost/test".to_string());
|
|
// Should succeed — pool is created lazily, no actual connection needed.
|
|
let pool = create_pool(&config, SslMode::Disable);
|
|
assert!(pool.is_ok());
|
|
}
|
|
|
|
#[test]
|
|
fn create_pool_prefer_mode() {
|
|
let mut config = deadpool_postgres::Config::new();
|
|
config.url = Some("postgres://localhost/test".to_string());
|
|
let pool = create_pool(&config, SslMode::Prefer);
|
|
assert!(pool.is_ok());
|
|
}
|
|
|
|
#[test]
|
|
fn create_pool_require_mode() {
|
|
let mut config = deadpool_postgres::Config::new();
|
|
config.url = Some("postgres://localhost/test".to_string());
|
|
let pool = create_pool(&config, SslMode::Require);
|
|
assert!(pool.is_ok());
|
|
}
|
|
}
|