3 people 09e1c97a27 fix(approval): make "always" auto-approve work for credentialed HTTP requests (#1257) ...

The HTTP tool returned `ApprovalRequirement::Always` for requests with
credentials, but `Always` is hardcoded to ignore the session auto-approve
set. This meant users who clicked "always" were re-prompted on every
subsequent HTTP call — the UI offered "always" but the backend ignored it.

Two fixes:
1. HTTP credentialed requests now return `UnlessAutoApproved` instead of
   `Always`, so the session auto-approve set is respected.
2. `StatusUpdate::ApprovalNeeded` now carries `allow_always: bool`. All
   channel UIs (Telegram, Slack, Signal, REPL, Web) conditionally hide
   the "always" option when a tool truly requires per-invocation approval
   (`ApprovalRequirement::Always`, e.g. destructive shell commands).

Also boxes `PendingApproval` in `AgenticLoopResult::NeedApproval` to fix
a pre-existing clippy `large_enum_variant` warning.

Regression tests included (test_credentialed_requests_respect_auto_approve,
test_allow_always_matches_approval_requirement) but CI heuristic cannot
detect them in cross-fork PR diffs.

[skip-regression-check]

Co-authored-by: Tyler <[email protected]>

2026-03-19 11:45:32 -07:00

..

bundled.rs

feat: add Feishu/Lark WASM channel plugin (#1110)

2026-03-15 05:25:05 +00:00

capabilities.rs

Implementing channels to be handled in wasm

2026-02-03 14:57:27 -08:00

error.rs

feat: WASM extension versioning with WIT compat checks (#592)

2026-03-06 04:38:07 +00:00

host.rs

Fix UTF-8 unsafe truncation in WASM emit_message (#1015)

2026-03-12 11:10:31 -07:00

loader.rs

Refactor owner scope across channels and fix default routing fallback (#1151)

2026-03-16 13:31:03 -07:00

mod.rs

Refactor owner scope across channels and fix default routing fallback (#1151)

2026-03-16 13:31:03 -07:00

router.rs

Refactor owner scope across channels and fix default routing fallback (#1151)

2026-03-16 13:31:03 -07:00

runtime.rs

fix(wasm): use per-engine cache dirs on Windows to avoid file lock error (#624)

2026-03-06 23:31:58 +00:00

schema.rs

feat: WASM extension versioning with WIT compat checks (#592)

2026-03-06 04:38:07 +00:00

setup.rs

Refactor owner scope across channels and fix default routing fallback (#1151)

2026-03-16 13:31:03 -07:00

signature.rs

Add generic host-verified /webhook/tools/{tool} ingress (#757)

2026-03-11 03:36:25 +00:00

storage.rs

feat: WASM extension versioning with WIT compat checks (#592)

2026-03-06 04:38:07 +00:00

telegram_host_config.rs

feat: verify telegram owner during hot activation (#1157)

2026-03-16 08:07:45 -07:00

wrapper.rs

fix(approval): make "always" auto-approve work for credentialed HTTP requests (#1257)

2026-03-19 11:45:32 -07:00