* Add event-triggered routines and workflow skill templates * fix(ci): secrets can't be used in step if conditions [skip-regression-check] (#787) GitHub Actions step-level `if:` doesn't have access to `secrets` context. Replace `if: secrets.X != ''` with `continue-on-error: true` and let the Set token step handle the fallback. Co-authored-by: Claude Sonnet 4.6 <[email protected]> * fix(ci): clean up staging pipeline — remove hacks, skip redundant checks [skip-regression-check] (#794) - Remove continue-on-error from staging-ci.yml app token steps (secrets are configured) - Skip test.yml and code_style.yml on PRs targeting staging (staging-ci.yml already runs tests before promoting, promotion PR gets full CI on main) - Allow ironclaw-ci[bot] in Claude Code review for bot-created promotion PRs Co-authored-by: Claude Opus 4.6 <[email protected]> * fix: address PR review feedback for event_emit security and quality Security fixes: - Require approval (UnlessAutoApproved) for event_emit, matching routine_fire - Enable sanitization on event_emit payload (external JSON reaches LLM) - Remove user_id parameter from event_emit to prevent IDOR — always use ctx.user_id Correctness fixes: - Rename source → event_source in event_emit for consistency with routine_create - Use json_value_as_filter_string for filter parsing (handles numbers/booleans) - Case-insensitive matching for event source and event_type - Add debug logging for missing filter keys in payload - Fix skill_install_routine_webhook_sim test missing .with_skills() - Fix schema_validator test for event_emit payload properties Code quality: - Move EventEmitTool struct/impl after RoutineHistoryTool (fix split layout) - Deduplicate routine_to_info into RoutineInfo::from_routine in types.rs - Add test section headers in e2e_routine_heartbeat.rs - Clarify event_emit description to specify system_event routines only Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix(ci): run fmt + clippy on staging PRs, skip Windows clippy [skip-regression-check] (#802) - Remove branches:[main] filter from code_style.yml so it runs on all PRs - Gate clippy-windows with `if: github.base_ref == 'main'` (skip on staging PRs) - Update rollup job to allow skipped clippy-windows - Simplify claude-review.yml to only trigger on labeled event (avoids duplicate runs) Co-authored-by: Claude Opus 4.6 <[email protected]> * feat: persist user_id in save_job and expose job_id on routine runs (#709) * feat: persist worker events to DB and fix activity tab rendering In-process Worker (used by Scheduler::dispatch_job) now persists events via save_job_event at key execution points: plan creation, LLM responses, tool_use, tool_result, and job completion/failure/stuck. Event data shapes match the container worker format so the gateway activity tab renders them correctly. Frontend: tool_result errors now show a red X icon with danger styling instead of a silent empty output. The result event falls back to the error field when message is absent. Co-Authored-By: Claude Opus 4.6 <[email protected]> * feat: wire RoutineEngine into gateway for direct manual trigger firing Replace the message-channel hack in routines_trigger_handler with a direct call to RoutineEngine::fire_manual(), ensuring FullJob routines dispatch correctly when triggered from the web UI. Inject the engine into GatewayState from Agent::run after construction. Also persists user_id in save_job for both PG and libSQL backends, removes the source='sandbox' filter so all jobs are visible, and exposes job_id on RoutineRunInfo for the frontend job link. Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: remove stale gateway_state argument from Agent::new test call sites The gateway_state parameter was removed from Agent::new during rebase (replaced by post-construction set_routine_engine_slot), but three test call sites still passed the extra None argument. Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: address PR review — restore sandbox source filter, remove blank lines - Revert removal of `source = 'sandbox'` filter in all SandboxStore queries (8 sites across PG and libSQL). Sandbox-specific APIs should stay scoped to sandbox jobs; unified job listing for the Jobs tab should use a separate query path. - Remove extra blank lines in agent_loop.rs and worker.rs that caused formatting CI failure. [skip-regression-check] Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: address review — regenerate Cargo.lock, add user_id regression test - Regenerate Cargo.lock from main's lockfile to eliminate dependency version downgrades (anyhow, syn, etc.) that were churn from rebase. - Add regression test verifying user_id round-trips through save_job and get_job in the libSQL backend. Co-Authored-By: Claude Opus 4.6 <[email protected]> * style: remove trailing blank line in libsql jobs.rs [skip-regression-check] Co-Authored-By: Claude Opus 4.6 <[email protected]> * test: add Postgres-side regression test for user_id persistence in save_job Mirrors the existing libSQL test (test_save_job_persists_user_id) for the Postgres backend. Gated behind #[cfg(feature = "postgres")] + #[ignore] since it requires a running PostgreSQL instance (integration tier). Co-Authored-By: Claude Opus 4.6 <[email protected]> --------- Co-authored-by: Claude Opus 4.6 <[email protected]> * fix: make routine_system_event_emit test create routine before emitting - Add routine_create step to trace fixture so event_emit has a matching routine to fire - Assert fired_routines > 0, not just key presence (Copilot review) - Add .with_auto_approve_tools(true) since event_emit now requires approval Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: renumber test headers after system_event test insertion Test 4 was duplicated (routine_cooldown and heartbeat_findings). Renumber heartbeat_findings to Test 5 and heartbeat_empty_skip to Test 6. [skip-regression-check] Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: merge staging and add missing RoutineEngine args in test RoutineEngine::new on staging requires `tools` and `safety` params. Update system_event_trigger_matches_and_filters test to pass them. [skip-regression-check] Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: address new Copilot review comments - Add .with_auto_approve_tools(true) to skill_install_routine_webhook_sim test so event_emit doesn't block on approval - Fix module-level doc comment for event_emit to specify system_event trigger [skip-regression-check] Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: deduplicate json_value_as_string helper Remove private `json_value_as_string` from routine_engine.rs and use the identical public `json_value_as_filter_string` from routine.rs, eliminating divergence risk. (Copilot review) [skip-regression-check] Co-Authored-By: Claude Opus 4.6 <[email protected]> --------- Co-authored-by: Henry Park <[email protected]> Co-authored-by: Claude Sonnet 4.6 <[email protected]>
LLM Trace Fixtures
Trace fixtures are JSON files that script LLM behavior for deterministic E2E testing. The TraceLlm provider (tests/support/trace_llm.rs) replays these canned responses in order, allowing tests to exercise the full agent loop -- tool dispatch, safety layer, context accumulation -- without calling a real LLM.
Traces can be hand-written or recorded from a live session using the RecordingLlm wrapper (src/llm/recording.rs). Recorded traces include additional fields (memory snapshots, HTTP exchanges, expected tool results) that enable fully deterministic replay.
Trace Format
A trace is a model name and a list of turns. Each turn pairs a user message with the LLM response steps that follow it.
{
"model_name": "descriptive-name",
"turns": [
{
"user_input": "Write hello to /tmp/test.txt",
"steps": [
{
"response": {
"type": "tool_calls",
"tool_calls": [{ "id": "c1", "name": "write_file", "arguments": {"path": "/tmp/test.txt", "content": "hello"} }],
"input_tokens": 60, "output_tokens": 20
}
},
{
"response": {
"type": "text",
"content": "Done, wrote hello to the file.",
"input_tokens": 80, "output_tokens": 15
}
}
]
},
{
"user_input": "Actually, change it to goodbye instead",
"steps": [
{
"response": {
"type": "tool_calls",
"tool_calls": [{ "id": "c2", "name": "write_file", "arguments": {"path": "/tmp/test.txt", "content": "goodbye"} }],
"input_tokens": 100, "output_tokens": 20
}
},
{
"response": {
"type": "text",
"content": "Updated the file to say goodbye.",
"input_tokens": 120, "output_tokens": 15
}
}
]
}
]
}
TestRig::run_trace() drives the entire conversation automatically -- no test code needed to send user messages.
Legacy flat format
For backward compatibility, traces with a top-level "steps" array (no "turns") are accepted. They are deserialized as a single turn with a placeholder user message. Existing fixtures work unchanged; test code provides the user message via rig.send_message().
{
"model_name": "descriptive-name",
"memory_snapshot": [
{ "path": "context/vision.md", "content": "..." }
],
"http_exchanges": [
{
"request": { "method": "GET", "url": "https://api.example.com/data", "headers": [], "body": null },
"response": { "status": 200, "headers": [], "body": "{\"result\": 42}" }
}
],
"steps": [
{ "response": { "type": "text", "content": "Hello", "input_tokens": 10, "output_tokens": 5 } },
{
"response": { "type": "user_input", "content": "What time is it?" }
},
{
"request_hint": {
"last_user_message_contains": "optional substring",
"min_message_count": 1
},
"expected_tool_results": [
{ "tool_call_id": "call_time_1", "name": "time", "content": "14:30:00" }
],
"response": { "..." }
}
]
}
Top-level fields
| Field | Type | Required | Description |
|---|---|---|---|
model_name |
string | yes | Identifier returned by LlmProvider::model_name(). Convention: {category}-{scenario} (e.g. spot-smoke-greeting, advanced-tool-error-recovery). |
turns |
array | yes* | List of turns. Each turn has user_input (string) and steps (array of response steps). |
memory_snapshot |
array | no | Workspace memory documents captured before the recording session. Replay should restore these before running the trace. Each entry has path (string) and content (string). |
http_exchanges |
array | no | HTTP request/response pairs recorded during the session, in order. During replay, the ReplayingHttpInterceptor returns these instead of making real HTTP requests. |
expects |
object | no | Declarative expectations verified after replay. See Expects fields. |
*Or steps for the legacy flat format (deserialized as a single turn with a placeholder user message). Legacy steps are ordered: each complete() or complete_with_tools() call consumes the next text/tool_calls step. user_input steps are metadata markers and must be skipped during replay. If LLM calls exceed the number of playable steps, TraceLlm returns an error.
Turn fields
| Field | Type | Required | Description |
|---|---|---|---|
user_input |
string | yes | The user message that starts this turn. |
steps |
array | yes | Ordered list of LLM response steps for this turn. |
expects |
object | no | Per-turn expectations. Same schema as top-level expects. |
Step fields
| Field | Type | Required | Description |
|---|---|---|---|
request_hint |
object | no | Soft validation against the incoming request. Mismatches log a warning but do not fail the call. |
response |
object | yes | The canned response for this step. |
expected_tool_results |
array | no | Tool results that appeared in the message context since the previous step. During replay, the test harness can compare actual Role::Tool messages against these to verify tool output hasn't changed (regression detection). Each entry has tool_call_id, name, and content. |
Request hints
| Field | Type | Description |
|---|---|---|
last_user_message_contains |
string | Asserts the last Role::User message contains this substring. |
min_message_count |
integer | Asserts the message list has at least this many entries. |
Hints are intentionally soft -- they help catch wiring mistakes during test development without making traces brittle.
Determinism requirement
Trace fixtures must produce deterministic results across runs. Do not use tools whose output varies by time or environment state. Specifically:
Avoid:
time-- output changes every runlist_diron directories not created by the trace itselfshellwith commands that depend on system state (e.g.date,ps,ls /var)http-- external endpoints may change or be unavailablememory_searchunless the trace writes the memory entry first
Prefer:
echo-- always returns its inputjson-- deterministic parsing/formattingwrite_file+read_file-- self-contained if the trace writes firstmemory_write+memory_read-- deterministic if the trace writes firstshellwith deterministic commands (e.g.echo "hello",printf)
When a trace needs to exercise a stateful tool (like list_dir), have an earlier step create the expected state (e.g. write_file to create the directory contents first).
Response types
Responses are tagged via the type field.
text -- plain text completion
{
"type": "text",
"content": "The capital of France is Paris.",
"input_tokens": 40,
"output_tokens": 10
}
Returns a CompletionResponse / ToolCompletionResponse with no tool calls and FinishReason::Stop. If complete() is called (not complete_with_tools()), this is the only valid response type.
tool_calls -- one or more tool invocations
{
"type": "tool_calls",
"tool_calls": [
{
"id": "call_write_1",
"name": "write_file",
"arguments": { "path": "/tmp/test.txt", "content": "hello" }
}
],
"input_tokens": 80,
"output_tokens": 25
}
Returns a ToolCompletionResponse with FinishReason::ToolUse. The agent loop executes the tool calls against real tool implementations, feeds the results back as tool-result messages, then calls the LLM again (consuming the next step).
Important: tool_calls steps cause real tool execution. The tools run against the actual tool registry, so side effects (file writes, memory operations) happen for real. This is what makes these E2E tests -- the only mock is the LLM itself.
| Field | Type | Description |
|---|---|---|
id |
string | Unique call ID. Convention: call_{tool}_{n}. |
name |
string | Must match a registered tool name (e.g. echo, write_file, read_file, memory_write, shell). |
arguments |
object | Tool parameters as JSON. Must conform to the tool's parameters_schema(). |
user_input -- user message marker (recording only)
{
"type": "user_input",
"content": "What time is it?"
}
A metadata marker recording what the user said. This does not correspond to an LLM call. During replay, TraceLlm must skip user_input steps and only consume text/tool_calls steps. These steps are emitted by RecordingLlm when it detects new Role::User messages between LLM calls.
Token counts
Every text and tool_calls response includes input_tokens and output_tokens. These are synthetic values for cost tracking -- set them to reasonable estimates for your scenario. user_input steps do not have token counts.
Expected tool results
When present on a step, expected_tool_results lists the tool output that appeared in the message context before this LLM call. Each entry has:
| Field | Type | Description |
|---|---|---|
tool_call_id |
string | The id of the tool call that produced this result. |
name |
string | The tool name. |
content |
string | The full tool result content as it appeared in the message context. |
During replay, after tools execute and before returning the canned LLM response, the test harness should compare actual tool results against these entries. A content mismatch indicates a tool behavior change (regression).
Expects fields
The expects object can appear at the top level (whole trace) or per-turn. All fields are optional; traces without expects work unchanged.
| Field | Type | Description |
|---|---|---|
response_contains |
string[] |
Each must appear in response (case-insensitive). |
response_not_contains |
string[] |
None may appear in response. |
response_matches |
string |
Regex that must match response. |
tools_used |
string[] |
Each tool name must appear in started calls. |
tools_not_used |
string[] |
None of these may appear. |
all_tools_succeeded |
bool |
If true, all tools must succeed. |
max_tool_calls |
usize |
Upper bound on tool call count. |
min_responses |
usize |
Minimum response count. |
tool_results_contain |
map<string,string> |
Tool result preview must contain substring. |
Example (top-level):
{
"model_name": "recorded-telegram-check",
"expects": {
"response_contains": ["Telegram", "connected"],
"tools_used": ["echo"],
"all_tools_succeeded": true,
"tool_results_contain": { "echo": "Checking telegram" },
"min_responses": 1
},
"steps": [ ... ]
}
Example (per-turn):
{
"model_name": "multi-turn-example",
"turns": [
{
"user_input": "say hello",
"expects": { "response_contains": ["hello"], "tools_not_used": ["shell"] },
"steps": [ ... ]
}
]
}
run_recorded_trace("filename.json") in test code loads the fixture, builds a rig, replays, verifies all expects, and shuts down -- turning recorded trace tests into one-liners.
What gets mocked vs. what runs for real
| Component | Mocked? | Notes |
|---|---|---|
| LLM responses | Yes | TraceLlm replays canned responses from the trace |
| Tool execution | No | Real tools run: file I/O, memory ops, shell commands all execute |
| Outgoing HTTP (from tools) | Depends | Mocked when http_exchanges present and ReplayingHttpInterceptor is wired; real otherwise |
| Memory/workspace | Depends | Pre-seeded from memory_snapshot if present; real workspace operations otherwise |
| Safety layer | No | Sanitizer, validator, policy, leak detector all run |
| Context/message accumulation | No | Messages accumulate naturally across turns |
| Token counting | Partial | Uses synthetic counts from the trace |
Directory structure
llm_traces/
simple_text.json # Minimal single-turn text response
file_write_read.json # Write then read a file
memory_write_read.json # Memory write then text confirmation
error_path.json # Tool call with missing params, then recovery
spot/ # Quick smoke tests (1-3 steps each)
smoke_greeting.json # Simple greeting, no tools
smoke_math.json # Math question, no tools
robust_no_tool.json # Factual question, no tools
tool_echo.json # Single echo tool call + confirmation
tool_json.json # JSON parse tool call + confirmation
chain_write_read.json # Write file -> read file -> confirm
memory_save_recall.json # Memory write -> memory search -> confirm
robust_correct_tool.json
coverage/ # Broader tool and feature coverage
shell_echo.json # Shell command execution
list_dir.json # Directory listing
apply_patch_chain.json # File patching workflow
json_operations.json # JSON tool usage
injection_in_echo.json # Prompt injection in tool output
memory_full_cycle.json # Full memory write/search/read cycle
status_events_tool_chain.json
advanced/ # Multi-step and edge-case scenarios
long_tool_chain.json # Many sequential tool calls
tool_error_recovery.json # Failed tool call -> retry with valid path
multi_turn_memory.json # Memory across multiple turns
steering.json # User steering: correct agent mid-conversation
workspace_search.json # Workspace search workflows
prompt_injection_resilience.json
iteration_limit.json # Tests agent loop iteration bounds
Writing a new trace
-
Pick a category:
spot/for quick smoke tests,coverage/for tool/feature coverage,advanced/for complex multi-step scenarios. -
Name the model: Use
{category}-{scenario}(e.g.spot-tool-echo,coverage-shell-echo). -
Script the conversation: Think through the turn sequence. Each LLM call is one step. After a
tool_callsstep, the agent executes the tools and calls the LLM again with the results -- that's the next step. -
Add request hints on the first step of each turn (at minimum) to catch wiring issues. Later steps often omit hints since the message content depends on tool output.
-
End each turn with a
textstep so the agent has a final response to return.
Example -- single-turn trace:
{
"model_name": "spot-tool-echo",
"turns": [
{
"user_input": "Please echo hello for me",
"steps": [
{
"request_hint": { "last_user_message_contains": "echo" },
"response": {
"type": "tool_calls",
"tool_calls": [{ "id": "call_echo_1", "name": "echo", "arguments": { "message": "hello" } }],
"input_tokens": 60, "output_tokens": 20
}
},
{
"response": {
"type": "text",
"content": "The echo tool returned: hello",
"input_tokens": 80, "output_tokens": 15
}
}
]
}
]
}
Example -- multi-turn steering:
{
"model_name": "advanced-steering",
"turns": [
{
"user_input": "Write hello to /tmp/test.txt",
"steps": [
{
"response": {
"type": "tool_calls",
"tool_calls": [{ "id": "c1", "name": "write_file", "arguments": {"path": "/tmp/test.txt", "content": "hello"} }],
"input_tokens": 60, "output_tokens": 20
}
},
{ "response": { "type": "text", "content": "Done.", "input_tokens": 80, "output_tokens": 5 } }
]
},
{
"user_input": "Actually, change it to goodbye",
"steps": [
{
"response": {
"type": "tool_calls",
"tool_calls": [{ "id": "c2", "name": "write_file", "arguments": {"path": "/tmp/test.txt", "content": "goodbye"} }],
"input_tokens": 100, "output_tokens": 20
}
},
{ "response": { "type": "text", "content": "Updated.", "input_tokens": 120, "output_tokens": 5 } }
]
}
]
}
TraceLlm API
The provider exposes inspection methods for test assertions:
let llm = TraceLlm::from_file("tests/fixtures/llm_traces/spot/tool_echo.json")?;
// ... run agent loop ...
assert_eq!(llm.calls(), 2); // Total LLM calls made
assert_eq!(llm.hint_mismatches(), 0); // Request hint failures
let reqs = llm.captured_requests(); // Vec<Vec<ChatMessage>> of all requests
TestRig::run_trace()
For traces with multiple turns, run_trace() drives the entire conversation automatically:
let trace = LlmTrace::from_file("tests/fixtures/llm_traces/advanced/steering.json")?;
let rig = TestRigBuilder::new()
.with_trace(trace.clone())
.with_tools(tools_with_file_support())
.build()
.await;
// Sends each turn's user_input, waits for response, accumulates results.
let all_responses = rig.run_trace(&trace, Duration::from_secs(15)).await;
assert!(!all_responses[0].is_empty(), "Turn 1: no response");
assert!(!all_responses[1].is_empty(), "Turn 2: no response");
For legacy flat traces or when you need fine-grained control, use send_message() + wait_for_responses() directly.
Recording traces from live sessions
Instead of hand-writing traces, you can record them from a real LLM session using the RecordingLlm wrapper (src/llm/recording.rs). This captures everything needed for deterministic replay: user inputs, LLM responses, memory state, HTTP exchanges, and tool results.
Environment variables
| Variable | Required | Default | Description |
|---|---|---|---|
IRONCLAW_RECORD_TRACE |
yes | — | Set to any non-empty value to enable recording. |
IRONCLAW_TRACE_OUTPUT |
no | ./trace_{timestamp}.json |
Output file path for the recorded trace. |
IRONCLAW_TRACE_MODEL_NAME |
no | recorded-{model} |
The model_name field in the trace JSON. |
Usage
# Record a trace (writes to ./trace_20260304T120000.json)
IRONCLAW_RECORD_TRACE=1 cargo run
# Custom output path
IRONCLAW_RECORD_TRACE=1 IRONCLAW_TRACE_OUTPUT=my_trace.json cargo run
# Custom model name
IRONCLAW_RECORD_TRACE=1 IRONCLAW_TRACE_MODEL_NAME=regression-auth-flow cargo run
Run the agent normally, interact with it, then quit. The trace file is written on shutdown.
What gets recorded
- Memory snapshot -- all workspace documents are captured before the agent starts, saved in
memory_snapshot. - User inputs -- new
Role::Usermessages detected between LLM calls are emitted asuser_inputsteps. - LLM responses -- every
complete()/complete_with_tools()response is saved as atextortool_callsstep withrequest_hint. - Tool results -- new
Role::Toolmessages between LLM calls are captured inexpected_tool_resultson the next step. - HTTP exchanges -- all outgoing HTTP requests from tools are recorded via the
HttpInterceptorand saved inhttp_exchanges.
Using a recorded trace for replay
A recorded trace is a superset of the hand-written format. To use it:
- The replay provider (
TraceLlm) must skipuser_inputsteps -- they are metadata markers, not LLM responses. - If
memory_snapshotis present, restore workspace documents before running the trace. - If
http_exchangesis present, wire aReplayingHttpInterceptorintoJobContext.http_interceptorso tools get pre-recorded HTTP responses instead of making real requests. - If
expected_tool_resultsis present on a step, compare actual tool output against recorded values before returning the canned LLM response.
Example recorded trace
{
"model_name": "recorded-claude-3-5-sonnet",
"memory_snapshot": [
{ "path": "context/vision.md", "content": "# Vision\nBuild a secure AI assistant." }
],
"http_exchanges": [
{
"request": { "method": "GET", "url": "https://api.example.com/time" },
"response": { "status": 200, "body": "{\"time\": \"14:30\"}" }
}
],
"steps": [
{
"response": { "type": "user_input", "content": "What time is it?" }
},
{
"request_hint": { "last_user_message_contains": "What time is it?", "min_message_count": 2 },
"response": {
"type": "tool_calls",
"tool_calls": [
{ "id": "call_http_1", "name": "http", "arguments": { "url": "https://api.example.com/time" } }
],
"input_tokens": 60,
"output_tokens": 20
}
},
{
"request_hint": { "min_message_count": 4 },
"expected_tool_results": [
{ "tool_call_id": "call_http_1", "name": "http", "content": "{\"status\":200,\"body\":{\"time\":\"14:30\"}}" }
],
"response": {
"type": "text",
"content": "The current time is 2:30 PM.",
"input_tokens": 80,
"output_tokens": 15
}
}
]
}
Backward compatibility
Recorded traces are backward-compatible with hand-written traces. All new fields (memory_snapshot, http_exchanges, expected_tool_results, user_input steps) are optional and default to empty. Existing hand-written traces work unchanged.