mirror of
https://github.com/outbackdingo/optimclaw.git
synced 2026-08-26 15:40:18 +00:00
Compare commits
10
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
702af21aeb | ||
|
|
d9d48fdc72 | ||
|
|
71e200af74 | ||
|
|
ba4645b192 | ||
|
|
d59e2a1d4b | ||
|
|
bafe945c90 | ||
|
|
170566ab93 | ||
|
|
9170b28f7b | ||
|
|
cda0df3d7f | ||
|
|
75f7bea0fd |
@@ -12,7 +12,6 @@ jobs:
|
|||||||
tests:
|
tests:
|
||||||
name: Tests (${{ matrix.name }})
|
name: Tests (${{ matrix.name }})
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
timeout-minutes: 45
|
|
||||||
strategy:
|
strategy:
|
||||||
fail-fast: false
|
fail-fast: false
|
||||||
matrix:
|
matrix:
|
||||||
@@ -41,14 +40,11 @@ jobs:
|
|||||||
- name: Build WASM channels (for integration tests)
|
- name: Build WASM channels (for integration tests)
|
||||||
run: ./scripts/build-wasm-extensions.sh --channels
|
run: ./scripts/build-wasm-extensions.sh --channels
|
||||||
- name: Run Tests
|
- name: Run Tests
|
||||||
run: |
|
run: cargo test ${{ matrix.flags }} -- --nocapture
|
||||||
timeout --signal=INT --kill-after=30s 40m \
|
|
||||||
cargo test ${{ matrix.flags }} -- --nocapture
|
|
||||||
|
|
||||||
heavy-integration-tests:
|
heavy-integration-tests:
|
||||||
name: Heavy Integration Tests
|
name: Heavy Integration Tests
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
timeout-minutes: 20
|
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@v6
|
uses: actions/checkout@v6
|
||||||
@@ -62,13 +58,9 @@ jobs:
|
|||||||
- name: Build Telegram WASM channel
|
- name: Build Telegram WASM channel
|
||||||
run: cargo build --manifest-path channels-src/telegram/Cargo.toml --target wasm32-wasip2 --release
|
run: cargo build --manifest-path channels-src/telegram/Cargo.toml --target wasm32-wasip2 --release
|
||||||
- name: Run thread scheduling integration tests
|
- name: Run thread scheduling integration tests
|
||||||
run: |
|
run: cargo test --no-default-features --features libsql,integration --test e2e_thread_scheduling -- --nocapture
|
||||||
timeout --signal=INT --kill-after=30s 15m \
|
|
||||||
cargo test --no-default-features --features libsql,integration --test e2e_thread_scheduling -- --nocapture
|
|
||||||
- name: Run Telegram thread-scope regression test
|
- name: Run Telegram thread-scope regression test
|
||||||
run: |
|
run: cargo test --features integration --test telegram_auth_integration test_private_messages_use_chat_id_as_thread_scope -- --exact
|
||||||
timeout --signal=INT --kill-after=30s 10m \
|
|
||||||
cargo test --features integration --test telegram_auth_integration test_private_messages_use_chat_id_as_thread_scope -- --exact
|
|
||||||
|
|
||||||
telegram-tests:
|
telegram-tests:
|
||||||
name: Telegram Channel Tests
|
name: Telegram Channel Tests
|
||||||
@@ -76,7 +68,6 @@ jobs:
|
|||||||
github.event_name != 'pull_request' ||
|
github.event_name != 'pull_request' ||
|
||||||
github.base_ref != 'staging'
|
github.base_ref != 'staging'
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
timeout-minutes: 15
|
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@v6
|
uses: actions/checkout@v6
|
||||||
@@ -84,9 +75,7 @@ jobs:
|
|||||||
uses: dtolnay/rust-toolchain@stable
|
uses: dtolnay/rust-toolchain@stable
|
||||||
- uses: Swatinem/rust-cache@v2
|
- uses: Swatinem/rust-cache@v2
|
||||||
- name: Run Telegram Channel Tests
|
- name: Run Telegram Channel Tests
|
||||||
run: |
|
run: cargo test --manifest-path channels-src/telegram/Cargo.toml -- --nocapture
|
||||||
timeout --signal=INT --kill-after=30s 10m \
|
|
||||||
cargo test --manifest-path channels-src/telegram/Cargo.toml -- --nocapture
|
|
||||||
|
|
||||||
windows-build:
|
windows-build:
|
||||||
name: Windows Build (${{ matrix.name }})
|
name: Windows Build (${{ matrix.name }})
|
||||||
@@ -121,7 +110,6 @@ jobs:
|
|||||||
github.event_name != 'pull_request' ||
|
github.event_name != 'pull_request' ||
|
||||||
github.base_ref != 'staging'
|
github.base_ref != 'staging'
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
timeout-minutes: 30
|
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@v6
|
uses: actions/checkout@v6
|
||||||
@@ -137,9 +125,7 @@ jobs:
|
|||||||
- name: Build all WASM extensions against current WIT
|
- name: Build all WASM extensions against current WIT
|
||||||
run: ./scripts/build-wasm-extensions.sh
|
run: ./scripts/build-wasm-extensions.sh
|
||||||
- name: Instantiation test (host linker compatibility)
|
- name: Instantiation test (host linker compatibility)
|
||||||
run: |
|
run: cargo test --all-features wit_compat -- --nocapture
|
||||||
timeout --signal=INT --kill-after=30s 20m \
|
|
||||||
cargo test --all-features wit_compat -- --nocapture
|
|
||||||
|
|
||||||
bench-compile:
|
bench-compile:
|
||||||
name: Benchmark Compilation
|
name: Benchmark Compilation
|
||||||
|
|||||||
-150
@@ -7,156 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|||||||
|
|
||||||
## [Unreleased]
|
## [Unreleased]
|
||||||
|
|
||||||
## [0.23.0](https://github.com/nearai/ironclaw/compare/ironclaw-v0.22.0...ironclaw-v0.23.0) - 2026-03-27
|
|
||||||
|
|
||||||
### Added
|
|
||||||
|
|
||||||
- complete multi-tenant isolation — phases 2–4 ([#1614](https://github.com/nearai/ironclaw/pull/1614))
|
|
||||||
|
|
||||||
### Fixed
|
|
||||||
|
|
||||||
- *(routines)* recover delete name after failed update fallback ([#1108](https://github.com/nearai/ironclaw/pull/1108))
|
|
||||||
- *(mcp)* handle 202 Accepted and wire session manager for Streamable HTTP ([#1437](https://github.com/nearai/ironclaw/pull/1437))
|
|
||||||
- *(extensions)* channel-relay auth dead-end, observability, and URL override ([#1681](https://github.com/nearai/ironclaw/pull/1681))
|
|
||||||
- *(agent)* discard truncated tool calls when finish_reason == Length ([#1631](https://github.com/nearai/ironclaw/pull/1631)) ([#1632](https://github.com/nearai/ironclaw/pull/1632))
|
|
||||||
- *(llm)* filter XML tool-call recovery by context ([#1641](https://github.com/nearai/ironclaw/pull/1641))
|
|
||||||
|
|
||||||
### Other
|
|
||||||
|
|
||||||
- Support direct hosted OAuth callbacks with proxy auth token ([#1684](https://github.com/nearai/ironclaw/pull/1684))
|
|
||||||
|
|
||||||
## [0.22.0](https://github.com/nearai/ironclaw/compare/ironclaw-v0.21.0...ironclaw-v0.22.0) - 2026-03-25
|
|
||||||
|
|
||||||
### Added
|
|
||||||
|
|
||||||
- *(agent)* thread per-tool reasoning through provider, session, and all surfaces ([#1513](https://github.com/nearai/ironclaw/pull/1513))
|
|
||||||
- *(cli)* show credential auth status in tool info ([#1572](https://github.com/nearai/ironclaw/pull/1572))
|
|
||||||
- multi-tenant auth with per-user workspace isolation ([#1118](https://github.com/nearai/ironclaw/pull/1118))
|
|
||||||
- *(cli)* add ironclaw models subcommands (list/status/set/set-provider) ([#1043](https://github.com/nearai/ironclaw/pull/1043))
|
|
||||||
- *(workspace)* multi-scope workspace reads ([#1117](https://github.com/nearai/ironclaw/pull/1117))
|
|
||||||
- *(ux)* complete UX overhaul — design system, onboarding, web polish ([#1277](https://github.com/nearai/ironclaw/pull/1277))
|
|
||||||
- *(gemini_oauth)* full Gemini CLI OAuth integration with Cloud Code API ([#1356](https://github.com/nearai/ironclaw/pull/1356))
|
|
||||||
- *(shell)* add Low/Medium/High risk levels for graduated command approval (closes #172) ([#368](https://github.com/nearai/ironclaw/pull/368))
|
|
||||||
- *(agent)* queue and merge messages during active turns ([#1412](https://github.com/nearai/ironclaw/pull/1412))
|
|
||||||
- *(cli)* add `ironclaw hooks list` subcommand ([#1023](https://github.com/nearai/ironclaw/pull/1023))
|
|
||||||
- *(extensions)* support text setup fields in web configure modal ([#496](https://github.com/nearai/ironclaw/pull/496))
|
|
||||||
- *(llm)* add GitHub Copilot as LLM provider ([#1512](https://github.com/nearai/ironclaw/pull/1512))
|
|
||||||
- *(workspace)* layered memory with sensitivity-based privacy redirect ([#1112](https://github.com/nearai/ironclaw/pull/1112))
|
|
||||||
- *(webhooks)* add public webhook trigger endpoint for routines ([#736](https://github.com/nearai/ironclaw/pull/736))
|
|
||||||
- *(llm)* Add OpenAI Codex (ChatGPT subscription) as LLM provider ([#1461](https://github.com/nearai/ironclaw/pull/1461))
|
|
||||||
- *(web)* add light theme with dark/light/system toggle ([#1457](https://github.com/nearai/ironclaw/pull/1457))
|
|
||||||
- *(agent)* activate stuck_threshold for time-based stuck job detection ([#1234](https://github.com/nearai/ironclaw/pull/1234))
|
|
||||||
- chat onboarding and routine advisor ([#927](https://github.com/nearai/ironclaw/pull/927))
|
|
||||||
|
|
||||||
### Fixed
|
|
||||||
|
|
||||||
- ensure LLM calls always end with user message (closes #763) ([#1259](https://github.com/nearai/ironclaw/pull/1259))
|
|
||||||
- restore owner-scoped gateway startup ([#1625](https://github.com/nearai/ironclaw/pull/1625))
|
|
||||||
- remove stale stream_token gate from channel-relay activation ([#1623](https://github.com/nearai/ironclaw/pull/1623))
|
|
||||||
- *(agent)* case-insensitive channel match and user_id filter for event triggers ([#1211](https://github.com/nearai/ironclaw/pull/1211))
|
|
||||||
- *(routines)* normalize status display across web and CLI ([#1469](https://github.com/nearai/ironclaw/pull/1469))
|
|
||||||
- *(tunnel)* managed tunnels target wrong port and die from SIGPIPE ([#1093](https://github.com/nearai/ironclaw/pull/1093))
|
|
||||||
- *(agent)* persist /model selection to .env, TOML, and DB ([#1581](https://github.com/nearai/ironclaw/pull/1581))
|
|
||||||
- post-merge review sweep — 8 fixes across security, perf, and correctness ([#1550](https://github.com/nearai/ironclaw/pull/1550))
|
|
||||||
- generate Mistral-compatible 9-char alphanumeric tool call IDs ([#1242](https://github.com/nearai/ironclaw/pull/1242))
|
|
||||||
- *(mcp)* handle empty 202 notification acknowledgements ([#1539](https://github.com/nearai/ironclaw/pull/1539))
|
|
||||||
- *(tests)* eliminate env mutex poison cascade ([#1558](https://github.com/nearai/ironclaw/pull/1558))
|
|
||||||
- *(safety)* escape tool output XML content and remove misleading sanitized attr ([#1067](https://github.com/nearai/ironclaw/pull/1067))
|
|
||||||
- *(oauth)* reject malformed ic2.* states in decode_hosted_oauth_state ([#1441](https://github.com/nearai/ironclaw/pull/1441)) ([#1454](https://github.com/nearai/ironclaw/pull/1454))
|
|
||||||
- parameter coercion and validation for oneOf/anyOf/allOf schemas ([#1397](https://github.com/nearai/ironclaw/pull/1397))
|
|
||||||
- persist startup-loaded MCP clients in ExtensionManager ([#1509](https://github.com/nearai/ironclaw/pull/1509))
|
|
||||||
- *(deps)* patch rustls-webpki vulnerability (RUSTSEC-2026-0049)
|
|
||||||
- *(routines)* add missing extension_manager field in trigger_manual EngineContext
|
|
||||||
- *(ci)* serialize env-mutating OAuth wildcard tests with ENV_MUTEX ([#1280](https://github.com/nearai/ironclaw/pull/1280)) ([#1468](https://github.com/nearai/ironclaw/pull/1468))
|
|
||||||
- *(setup)* remove redundant LLM config and API keys from bootstrap .env ([#1448](https://github.com/nearai/ironclaw/pull/1448))
|
|
||||||
- resolve wasm broadcast merge conflicts with staging ([#395](https://github.com/nearai/ironclaw/pull/395)) ([#1460](https://github.com/nearai/ironclaw/pull/1460))
|
|
||||||
- skip credential validation for Bedrock backend ([#1011](https://github.com/nearai/ironclaw/pull/1011))
|
|
||||||
- register sandbox jobs in ContextManager for query tool visibility ([#1426](https://github.com/nearai/ironclaw/pull/1426))
|
|
||||||
- prefer execution-local message routing metadata ([#1449](https://github.com/nearai/ironclaw/pull/1449))
|
|
||||||
- *(security)* validate embedding base URLs to prevent SSRF ([#1221](https://github.com/nearai/ironclaw/pull/1221))
|
|
||||||
- f32→f64 precision artifact in temperature causes provider 400 errors ([#1450](https://github.com/nearai/ironclaw/pull/1450))
|
|
||||||
- *(routines)* surface errors when sandbox unavailable for full_job routines ([#769](https://github.com/nearai/ironclaw/pull/769))
|
|
||||||
- restore libSQL vector search with dynamic dimensions ([#1393](https://github.com/nearai/ironclaw/pull/1393))
|
|
||||||
- staging CI triage — consolidate retry parsing, fix flaky tests, add docs ([#1427](https://github.com/nearai/ironclaw/pull/1427))
|
|
||||||
|
|
||||||
### Other
|
|
||||||
|
|
||||||
- Merge branch 'main' into staging-promote/455f543b-23329172268
|
|
||||||
- Merge pull request #1655 from nearai/codex/fix-staging-promotion-1451-version-bumps
|
|
||||||
- Merge pull request #1499 from nearai/staging-promote/9603fefd-23364438978
|
|
||||||
- Fix libsql prompt scope regressions ([#1651](https://github.com/nearai/ironclaw/pull/1651))
|
|
||||||
- Normalize cron schedules on routine create ([#1648](https://github.com/nearai/ironclaw/pull/1648))
|
|
||||||
- Fix MCP lifecycle trace user scope ([#1646](https://github.com/nearai/ironclaw/pull/1646))
|
|
||||||
- Fix REPL single-message hang and cap CI test duration ([#1643](https://github.com/nearai/ironclaw/pull/1643))
|
|
||||||
- extract AppEvent to crates/ironclaw_common ([#1615](https://github.com/nearai/ironclaw/pull/1615))
|
|
||||||
- Fix hosted OAuth refresh via proxy ([#1602](https://github.com/nearai/ironclaw/pull/1602))
|
|
||||||
- *(agent)* optimize approval thread resolution (UUID parsing + lock contention) ([#1592](https://github.com/nearai/ironclaw/pull/1592))
|
|
||||||
- *(tools)* auto-compact WASM tool schemas, add descriptions, improve credential prompts ([#1525](https://github.com/nearai/ironclaw/pull/1525))
|
|
||||||
- Default new lightweight routines to tools-enabled ([#1573](https://github.com/nearai/ironclaw/pull/1573))
|
|
||||||
- Google OAuth URL broken when initiated from Telegram channel ([#1165](https://github.com/nearai/ironclaw/pull/1165))
|
|
||||||
- add gitcgr code graph badge ([#1563](https://github.com/nearai/ironclaw/pull/1563))
|
|
||||||
- Fix owner-scoped message routing fallbacks ([#1574](https://github.com/nearai/ironclaw/pull/1574))
|
|
||||||
- *(tools)* remove unconditional params clone in shared execution (fix #893) ([#926](https://github.com/nearai/ironclaw/pull/926))
|
|
||||||
- *(llm)* move transcription module into src/llm/ ([#1559](https://github.com/nearai/ironclaw/pull/1559))
|
|
||||||
- *(agent)* avoid preview allocations for non-truncated strings (fix #894) ([#924](https://github.com/nearai/ironclaw/pull/924))
|
|
||||||
- Expand AGENTS.md with coding agents guidance ([#1392](https://github.com/nearai/ironclaw/pull/1392))
|
|
||||||
- Fix CI approval flows and stale fixtures ([#1478](https://github.com/nearai/ironclaw/pull/1478))
|
|
||||||
- Use live owner tool scope for autonomous routines and jobs ([#1453](https://github.com/nearai/ironclaw/pull/1453))
|
|
||||||
- use Arc in embedding cache to avoid clones on miss path ([#1438](https://github.com/nearai/ironclaw/pull/1438))
|
|
||||||
- Add owner-scoped permissions for full-job routines ([#1440](https://github.com/nearai/ironclaw/pull/1440))
|
|
||||||
|
|
||||||
## [0.21.0](https://github.com/nearai/ironclaw/compare/v0.20.0...v0.21.0) - 2026-03-20
|
|
||||||
|
|
||||||
### Added
|
|
||||||
|
|
||||||
- structured fallback deliverables for failed/stuck jobs ([#236](https://github.com/nearai/ironclaw/pull/236))
|
|
||||||
- LRU embedding cache for workspace search ([#1423](https://github.com/nearai/ironclaw/pull/1423))
|
|
||||||
- receive relay events via webhook callbacks ([#1254](https://github.com/nearai/ironclaw/pull/1254))
|
|
||||||
|
|
||||||
### Fixed
|
|
||||||
|
|
||||||
- bump Feishu channel version for promotion
|
|
||||||
- *(approval)* make "always" auto-approve work for credentialed HTTP requests ([#1257](https://github.com/nearai/ironclaw/pull/1257))
|
|
||||||
- skip NEAR AI session check when backend is not nearai ([#1413](https://github.com/nearai/ironclaw/pull/1413))
|
|
||||||
|
|
||||||
### Other
|
|
||||||
|
|
||||||
- Make hosted OAuth and MCP auth generic ([#1375](https://github.com/nearai/ironclaw/pull/1375))
|
|
||||||
|
|
||||||
## [0.20.0](https://github.com/nearai/ironclaw/compare/v0.19.0...v0.20.0) - 2026-03-19
|
|
||||||
|
|
||||||
### Added
|
|
||||||
|
|
||||||
- *(self-repair)* wire stuck_threshold, store, and builder ([#712](https://github.com/nearai/ironclaw/pull/712))
|
|
||||||
- *(testing)* add FaultInjector framework for StubLlm ([#1233](https://github.com/nearai/ironclaw/pull/1233))
|
|
||||||
- *(gateway)* unified settings page with subtabs ([#1191](https://github.com/nearai/ironclaw/pull/1191))
|
|
||||||
- upgrade MiniMax default model to M2.7 ([#1357](https://github.com/nearai/ironclaw/pull/1357))
|
|
||||||
|
|
||||||
### Fixed
|
|
||||||
|
|
||||||
- navigate telegram E2E tests to channels subtab ([#1408](https://github.com/nearai/ironclaw/pull/1408))
|
|
||||||
- add missing `builder` field and update E2E extensions tab navigation ([#1400](https://github.com/nearai/ironclaw/pull/1400))
|
|
||||||
- remove debug_assert guards that panic on valid error paths ([#1385](https://github.com/nearai/ironclaw/pull/1385))
|
|
||||||
- address valid review comments from PR #1359 ([#1380](https://github.com/nearai/ironclaw/pull/1380))
|
|
||||||
- full_job routine runs stay running until linked job completion ([#1374](https://github.com/nearai/ironclaw/pull/1374))
|
|
||||||
- full_job routine concurrency tracks linked job lifetime ([#1372](https://github.com/nearai/ironclaw/pull/1372))
|
|
||||||
- remove -x from coverage pytest to prevent suite-blocking failures ([#1360](https://github.com/nearai/ironclaw/pull/1360))
|
|
||||||
- add debug_assert invariant guards to critical code paths ([#1312](https://github.com/nearai/ironclaw/pull/1312))
|
|
||||||
- *(mcp)* retry after missing session id errors ([#1355](https://github.com/nearai/ironclaw/pull/1355))
|
|
||||||
- *(telegram)* preserve polling after secret-blocked updates ([#1353](https://github.com/nearai/ironclaw/pull/1353))
|
|
||||||
- *(llm)* cap retry-after delays ([#1351](https://github.com/nearai/ironclaw/pull/1351))
|
|
||||||
- *(setup)* remove nonexistent webhook secret command hint ([#1349](https://github.com/nearai/ironclaw/pull/1349))
|
|
||||||
- Rate limiter returns retry after None instead of a duration ([#1269](https://github.com/nearai/ironclaw/pull/1269))
|
|
||||||
|
|
||||||
### Other
|
|
||||||
|
|
||||||
- bump telegram channel version to 0.2.5 ([#1410](https://github.com/nearai/ironclaw/pull/1410))
|
|
||||||
- *(ci)* enforce test requirement for state machine and resilience changes ([#1230](https://github.com/nearai/ironclaw/pull/1230)) ([#1304](https://github.com/nearai/ironclaw/pull/1304))
|
|
||||||
- Fix duplicate LLM responses for matched event routines ([#1275](https://github.com/nearai/ironclaw/pull/1275))
|
|
||||||
- add Japanese README ([#1306](https://github.com/nearai/ironclaw/pull/1306))
|
|
||||||
- *(ci)* add coverage gates via codecov.yml ([#1228](https://github.com/nearai/ironclaw/pull/1228)) ([#1291](https://github.com/nearai/ironclaw/pull/1291))
|
|
||||||
- Redesign routine create requests for LLMs ([#1147](https://github.com/nearai/ironclaw/pull/1147))
|
|
||||||
|
|
||||||
## [0.19.0](https://github.com/nearai/ironclaw/compare/v0.18.0...v0.19.0) - 2026-03-17
|
## [0.19.0](https://github.com/nearai/ironclaw/compare/v0.18.0...v0.19.0) - 2026-03-17
|
||||||
|
|
||||||
### Added
|
### Added
|
||||||
|
|||||||
Generated
+5
-5
@@ -2323,7 +2323,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
|
|||||||
checksum = "39cab71617ae0d63f51a36d69f866391735b51691dbda63cf6f96d042b63efeb"
|
checksum = "39cab71617ae0d63f51a36d69f866391735b51691dbda63cf6f96d042b63efeb"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"libc",
|
"libc",
|
||||||
"windows-sys 0.59.0",
|
"windows-sys 0.52.0",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
@@ -3390,7 +3390,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "ironclaw"
|
name = "ironclaw"
|
||||||
version = "0.23.0"
|
version = "0.19.0"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"aes-gcm",
|
"aes-gcm",
|
||||||
"aho-corasick",
|
"aho-corasick",
|
||||||
@@ -3496,7 +3496,7 @@ dependencies = [
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "ironclaw_safety"
|
name = "ironclaw_safety"
|
||||||
version = "0.2.0"
|
version = "0.1.0"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"aho-corasick",
|
"aho-corasick",
|
||||||
"regex",
|
"regex",
|
||||||
@@ -5481,7 +5481,7 @@ dependencies = [
|
|||||||
"errno",
|
"errno",
|
||||||
"libc",
|
"libc",
|
||||||
"linux-raw-sys 0.12.1",
|
"linux-raw-sys 0.12.1",
|
||||||
"windows-sys 0.59.0",
|
"windows-sys 0.52.0",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
@@ -6388,7 +6388,7 @@ dependencies = [
|
|||||||
"getrandom 0.4.2",
|
"getrandom 0.4.2",
|
||||||
"once_cell",
|
"once_cell",
|
||||||
"rustix 1.1.4",
|
"rustix 1.1.4",
|
||||||
"windows-sys 0.59.0",
|
"windows-sys 0.52.0",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
|
|||||||
+2
-2
@@ -20,7 +20,7 @@ exclude = [
|
|||||||
|
|
||||||
[package]
|
[package]
|
||||||
name = "ironclaw"
|
name = "ironclaw"
|
||||||
version = "0.23.0"
|
version = "0.19.0"
|
||||||
edition = "2024"
|
edition = "2024"
|
||||||
rust-version = "1.92"
|
rust-version = "1.92"
|
||||||
description = "Secure personal AI assistant that protects your data and expands its capabilities on the fly"
|
description = "Secure personal AI assistant that protects your data and expands its capabilities on the fly"
|
||||||
@@ -104,7 +104,7 @@ cron = "0.13"
|
|||||||
ironclaw_common = { path = "crates/ironclaw_common", version = "0.1.0" }
|
ironclaw_common = { path = "crates/ironclaw_common", version = "0.1.0" }
|
||||||
|
|
||||||
# Safety/sanitization
|
# Safety/sanitization
|
||||||
ironclaw_safety = { path = "crates/ironclaw_safety", version = "0.2.0" }
|
ironclaw_safety = { path = "crates/ironclaw_safety", version = "0.1.0" }
|
||||||
regex = "1"
|
regex = "1"
|
||||||
aho-corasick = "1"
|
aho-corasick = "1"
|
||||||
|
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ authors = ["NEAR AI <[email protected]>"]
|
|||||||
license = "MIT OR Apache-2.0"
|
license = "MIT OR Apache-2.0"
|
||||||
homepage = "https://github.com/nearai/ironclaw"
|
homepage = "https://github.com/nearai/ironclaw"
|
||||||
repository = "https://github.com/nearai/ironclaw"
|
repository = "https://github.com/nearai/ironclaw"
|
||||||
|
publish = false
|
||||||
|
|
||||||
[package.metadata.dist]
|
[package.metadata.dist]
|
||||||
dist = false
|
dist = false
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
[package]
|
[package]
|
||||||
name = "ironclaw_safety"
|
name = "ironclaw_safety"
|
||||||
version = "0.2.0"
|
version = "0.1.0"
|
||||||
edition = "2024"
|
edition = "2024"
|
||||||
rust-version = "1.92"
|
rust-version = "1.92"
|
||||||
description = "Prompt injection defense, input validation, secret leak detection, and safety policy enforcement"
|
description = "Prompt injection defense, input validation, secret leak detection, and safety policy enforcement"
|
||||||
@@ -8,6 +8,7 @@ authors = ["NEAR AI <[email protected]>"]
|
|||||||
license = "MIT OR Apache-2.0"
|
license = "MIT OR Apache-2.0"
|
||||||
homepage = "https://github.com/nearai/ironclaw"
|
homepage = "https://github.com/nearai/ironclaw"
|
||||||
repository = "https://github.com/nearai/ironclaw"
|
repository = "https://github.com/nearai/ironclaw"
|
||||||
|
publish = false
|
||||||
|
|
||||||
[package.metadata.dist]
|
[package.metadata.dist]
|
||||||
dist = false
|
dist = false
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "feishu",
|
"name": "feishu",
|
||||||
"display_name": "Feishu / Lark Channel",
|
"display_name": "Feishu / Lark Channel",
|
||||||
"kind": "channel",
|
"kind": "channel",
|
||||||
"version": "0.1.3",
|
"version": "0.1.1",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Talk to your agent through a Feishu or Lark bot",
|
"description": "Talk to your agent through a Feishu or Lark bot",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -19,8 +19,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"sha256": "a66ff0dafb67d2216d8161bb7e96e724a94acb0ab993b85d2782d30412f8fe94",
|
"sha256": "5fca74022264d1c8e78a0853766276f7ffa3cf0d8065b2f51ca10985acad4714",
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/channel-feishu-0.1.3-wasm32-wasip2.tar.gz"
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.19.0/channel-feishu-0.1.1-wasm32-wasip2.tar.gz"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -18,8 +18,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/v0.20.0/channel-telegram-0.2.5-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.19.0/channel-telegram-0.2.4-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "1ef20a538f55b379e049356e4d6758006251846bc3365ceaa1c87eba8379a329"
|
"sha256": "a7cb300ec1c946831cfceaa95c1dc8f30d0f42a3924f3cb5de8098821573f4b8"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "github",
|
"name": "github",
|
||||||
"display_name": "GitHub",
|
"display_name": "GitHub",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.2",
|
"version": "0.2.1",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "GitHub integration for issues, PRs, repos, and code search",
|
"description": "GitHub integration for issues, PRs, repos, and code search",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -19,8 +19,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-github-0.2.2-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.19.0/tool-github-0.2.1-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "70b55af593193d8fa495c0f702ea23284d83a624124f8a5f7564916ec5032c3f"
|
"sha256": "92c530b3ad172e2372d819744b5233f1d8f65768e26eb5a6c213eba3ce1de758"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "gmail",
|
"name": "gmail",
|
||||||
"display_name": "Gmail",
|
"display_name": "Gmail",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.1",
|
"version": "0.2.0",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Read, send, and manage Gmail messages and threads",
|
"description": "Read, send, and manage Gmail messages and threads",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -18,8 +18,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-gmail-0.2.1-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.18.0/gmail-0.2.0-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "79025b40ee70ce1120acc4320bae50da095d7afb0ef67bd56d99b064b72ea779"
|
"sha256": "ee9574e02e92bc1d481f1310eb88afd99ee52bf6971074ab33bd76bf99b34b1d"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "google-calendar",
|
"name": "google-calendar",
|
||||||
"display_name": "Google Calendar",
|
"display_name": "Google Calendar",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.1",
|
"version": "0.2.0",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Create, read, update, and delete Google Calendar events",
|
"description": "Create, read, update, and delete Google Calendar events",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -18,8 +18,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-google-calendar-0.2.1-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.18.0/google-calendar-0.2.0-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "86bcc075010b08f5ab2f98f504cec1c6c9e0ca144857d185cbecf72a11f504bf"
|
"sha256": "2fa47150ea222e787c122182ad6f4dfa2ffaf5fe490d05e8de887a76445f8d2d"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "google-docs",
|
"name": "google-docs",
|
||||||
"display_name": "Google Docs",
|
"display_name": "Google Docs",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.1",
|
"version": "0.2.0",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Create and edit Google Docs documents",
|
"description": "Create and edit Google Docs documents",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -18,8 +18,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-google-docs-0.2.1-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.18.0/google-docs-0.2.0-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "39d476029764949498a53a6a223f9952b5f4df151be7b8b19bf3fe4d401a57cd"
|
"sha256": "40e134a1c1564f832ca861c3396895d4e33ec67b99313fc1f97baf8d971423a9"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "google-drive",
|
"name": "google-drive",
|
||||||
"display_name": "Google Drive",
|
"display_name": "Google Drive",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.1",
|
"version": "0.2.0",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Upload, download, search, and manage Google Drive files and folders",
|
"description": "Upload, download, search, and manage Google Drive files and folders",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -18,8 +18,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-google-drive-0.2.1-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.18.0/google-drive-0.2.0-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "6e9a700fab93865c852af718666af64c5b534ad6a419fb4b736e07740188f494"
|
"sha256": "002a341a1d58125563a7c69561b26fbc2629b04ea723cade744102bdc0fbb71f"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "google-sheets",
|
"name": "google-sheets",
|
||||||
"display_name": "Google Sheets",
|
"display_name": "Google Sheets",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.1",
|
"version": "0.2.0",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Read and write Google Sheets spreadsheet data",
|
"description": "Read and write Google Sheets spreadsheet data",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -18,8 +18,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-google-sheets-0.2.1-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.18.0/google-sheets-0.2.0-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "1f8c381799a916be83263cac9d497d52946e21b1b588592a3a42ca94a73b7051"
|
"sha256": "8aa2c9d52f033edea3a6c2311b0ec694ccb6d0a54ef07e94d72bf8be1ce8009a"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "google-slides",
|
"name": "google-slides",
|
||||||
"display_name": "Google Slides",
|
"display_name": "Google Slides",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.1",
|
"version": "0.2.0",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Create and edit Google Slides presentations",
|
"description": "Create and edit Google Slides presentations",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -17,8 +17,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-google-slides-0.2.1-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.18.0/google-slides-0.2.0-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "e2528be5da02f1b8cfc8ee9b0cdd849516c53d412e2f75c6175b3bded7f512cb"
|
"sha256": "e931a97d4fd0b0b938e464dc7c7f2be6ea6b4d1508f5ea3cd931d44db23f05f5"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "llm-context",
|
"name": "llm-context",
|
||||||
"display_name": "LLM Context",
|
"display_name": "LLM Context",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.1.1",
|
"version": "0.1.0",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Fetch pre-extracted web content from Brave Search for grounding LLM answers (RAG, fact-checking)",
|
"description": "Fetch pre-extracted web content from Brave Search for grounding LLM answers (RAG, fact-checking)",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -21,8 +21,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-llm-context-0.1.1-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.19.0/tool-llm-context-0.1.0-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "9b19e2fd05dbbbe3c8bd55309a91db09124e8415eb0f767828b6e10b55771e63"
|
"sha256": "d9ced2b1226b879135891e0ee40e072c7c95412e1b2462925a23853e1f92497e"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "slack-tool",
|
"name": "slack-tool",
|
||||||
"display_name": "Slack Tool",
|
"display_name": "Slack Tool",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.1",
|
"version": "0.2.0",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Your agent uses Slack to post and read messages in your workspace",
|
"description": "Your agent uses Slack to post and read messages in your workspace",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -17,8 +17,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-slack-0.2.1-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.19.0/tool-slack-0.2.0-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "927519e5b7734beeb022d3b8bbd152e0e6b9f67c9452a8ad47809d3c4221a137"
|
"sha256": "ccfb0415d7a04f9497726c712d15216de36e86f498b849101283c017f5ab4efb"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "telegram-mtproto",
|
"name": "telegram-mtproto",
|
||||||
"display_name": "Telegram Tool",
|
"display_name": "Telegram Tool",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.1",
|
"version": "0.2.0",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Your agent uses your Telegram account to read and send messages",
|
"description": "Your agent uses your Telegram account to read and send messages",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -18,8 +18,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-telegram-0.2.1-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.19.0/tool-telegram-0.2.0-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "1e57d0755fc9c7b3ec013d079f30168898b484a6919f9edd105f0cd80131c1cd"
|
"sha256": "c17065ca41fae5f2a7c43b36144686718cd310a2f22442313bb1aa82bbad0ae4"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
"name": "web-search",
|
"name": "web-search",
|
||||||
"display_name": "Web Search",
|
"display_name": "Web Search",
|
||||||
"kind": "tool",
|
"kind": "tool",
|
||||||
"version": "0.2.2",
|
"version": "0.2.1",
|
||||||
"wit_version": "0.3.0",
|
"wit_version": "0.3.0",
|
||||||
"description": "Search the web using Brave Search API",
|
"description": "Search the web using Brave Search API",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -18,8 +18,8 @@
|
|||||||
},
|
},
|
||||||
"artifacts": {
|
"artifacts": {
|
||||||
"wasm32-wasip2": {
|
"wasm32-wasip2": {
|
||||||
"url": "https://github.com/nearai/ironclaw/releases/download/ironclaw-v0.22.0/tool-web-search-0.2.2-wasm32-wasip2.tar.gz",
|
"url": "https://github.com/nearai/ironclaw/releases/download/v0.19.0/tool-web-search-0.2.1-wasm32-wasip2.tar.gz",
|
||||||
"sha256": "47382b50c1ea7525b20d59dc02fab04e336d018665826c2f24710bdf460779ae"
|
"sha256": "bad275ca4ec314adea5241d6b92c44ccf9cebcbca8e30ba2493cc0bcb4b57218"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"auth_summary": {
|
"auth_summary": {
|
||||||
|
|||||||
@@ -1,2 +1,7 @@
|
|||||||
[workspace]
|
[workspace]
|
||||||
git_release_enable = false
|
git_release_enable = false
|
||||||
|
|
||||||
|
[[package]]
|
||||||
|
name = "ironclaw_safety"
|
||||||
|
publish = false
|
||||||
|
release = false
|
||||||
|
|||||||
+23
-181
@@ -13,10 +13,9 @@ use futures::StreamExt;
|
|||||||
use uuid::Uuid;
|
use uuid::Uuid;
|
||||||
|
|
||||||
use crate::agent::context_monitor::ContextMonitor;
|
use crate::agent::context_monitor::ContextMonitor;
|
||||||
use crate::agent::heartbeat::{spawn_heartbeat, spawn_multi_user_heartbeat};
|
use crate::agent::heartbeat::spawn_heartbeat;
|
||||||
use crate::agent::routine_engine::{RoutineEngine, spawn_cron_ticker};
|
use crate::agent::routine_engine::{RoutineEngine, spawn_cron_ticker};
|
||||||
use crate::agent::self_repair::{DefaultSelfRepair, RepairResult, SelfRepair};
|
use crate::agent::self_repair::{DefaultSelfRepair, RepairResult, SelfRepair};
|
||||||
use crate::agent::session::ThreadState;
|
|
||||||
use crate::agent::session_manager::SessionManager;
|
use crate::agent::session_manager::SessionManager;
|
||||||
use crate::agent::submission::{Submission, SubmissionParser, SubmissionResult};
|
use crate::agent::submission::{Submission, SubmissionParser, SubmissionResult};
|
||||||
use crate::agent::{HeartbeatConfig as AgentHeartbeatConfig, Router, Scheduler, SchedulerDeps};
|
use crate::agent::{HeartbeatConfig as AgentHeartbeatConfig, Router, Scheduler, SchedulerDeps};
|
||||||
@@ -85,15 +84,6 @@ fn resolve_owner_scope_notification_user(
|
|||||||
trimmed_option(explicit_user).or_else(|| trimmed_option(owner_fallback))
|
trimmed_option(explicit_user).or_else(|| trimmed_option(owner_fallback))
|
||||||
}
|
}
|
||||||
|
|
||||||
fn is_single_message_repl(message: &IncomingMessage) -> bool {
|
|
||||||
message.channel == "repl"
|
|
||||||
&& message
|
|
||||||
.metadata
|
|
||||||
.get("single_message_mode")
|
|
||||||
.and_then(|value| value.as_bool())
|
|
||||||
.unwrap_or(false)
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn resolve_channel_notification_user(
|
async fn resolve_channel_notification_user(
|
||||||
extension_manager: Option<&Arc<ExtensionManager>>,
|
extension_manager: Option<&Arc<ExtensionManager>>,
|
||||||
channel: Option<&str>,
|
channel: Option<&str>,
|
||||||
@@ -182,8 +172,6 @@ pub struct AgentDeps {
|
|||||||
/// Resolved LLM backend identifier (e.g., "nearai", "openai", "groq").
|
/// Resolved LLM backend identifier (e.g., "nearai", "openai", "groq").
|
||||||
/// Used by `/model` persistence to determine which env var to update.
|
/// Used by `/model` persistence to determine which env var to update.
|
||||||
pub llm_backend: String,
|
pub llm_backend: String,
|
||||||
/// Per-tenant rate limiting registry (lazily creates rate state per user).
|
|
||||||
pub tenant_rates: Arc<crate::tenant::TenantRateRegistry>,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The main agent that coordinates all components.
|
/// The main agent that coordinates all components.
|
||||||
@@ -246,10 +234,7 @@ impl Agent {
|
|||||||
SchedulerDeps {
|
SchedulerDeps {
|
||||||
tools: deps.tools.clone(),
|
tools: deps.tools.clone(),
|
||||||
extension_manager: deps.extension_manager.clone(),
|
extension_manager: deps.extension_manager.clone(),
|
||||||
store: deps
|
store: deps.store.clone(),
|
||||||
.store
|
|
||||||
.as_ref()
|
|
||||||
.map(|db| crate::tenant::AdminScope::new(Arc::clone(db))),
|
|
||||||
hooks: deps.hooks.clone(),
|
hooks: deps.hooks.clone(),
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
@@ -330,50 +315,6 @@ impl Agent {
|
|||||||
&self.deps.cost_guard
|
&self.deps.cost_guard
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Build a tenant-scoped execution context for the given user.
|
|
||||||
///
|
|
||||||
/// This is the standard entry point for per-user operations. The returned
|
|
||||||
/// [`TenantCtx`] provides a [`TenantScope`] that auto-binds `user_id` on
|
|
||||||
/// every database operation and a per-user rate limiter.
|
|
||||||
pub(super) async fn tenant_ctx(&self, user_id: &str) -> crate::tenant::TenantCtx {
|
|
||||||
let rate = self.deps.tenant_rates.get_or_create(user_id).await;
|
|
||||||
|
|
||||||
let store = self
|
|
||||||
.deps
|
|
||||||
.store
|
|
||||||
.as_ref()
|
|
||||||
.map(|db| crate::tenant::TenantScope::new(user_id, Arc::clone(db)));
|
|
||||||
|
|
||||||
// Reuse the owner workspace if user matches, otherwise create per-user.
|
|
||||||
let workspace = match &self.deps.workspace {
|
|
||||||
Some(ws) if ws.user_id() == user_id => Some(Arc::clone(ws)),
|
|
||||||
_ => self
|
|
||||||
.deps
|
|
||||||
.store
|
|
||||||
.as_ref()
|
|
||||||
.map(|db| Arc::new(Workspace::new_with_db(user_id, Arc::clone(db)))),
|
|
||||||
};
|
|
||||||
|
|
||||||
crate::tenant::TenantCtx::new(
|
|
||||||
user_id,
|
|
||||||
store,
|
|
||||||
workspace,
|
|
||||||
Arc::clone(&self.deps.cost_guard),
|
|
||||||
rate,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Get an admin-scoped database accessor for cross-tenant operations.
|
|
||||||
///
|
|
||||||
/// Only for system-level components (heartbeat, routine engine, self-repair,
|
|
||||||
/// scheduler). Handler code should use [`tenant_ctx()`](Self::tenant_ctx) instead.
|
|
||||||
pub(super) fn admin_store(&self) -> Option<crate::tenant::AdminScope> {
|
|
||||||
self.deps
|
|
||||||
.store
|
|
||||||
.as_ref()
|
|
||||||
.map(|db| crate::tenant::AdminScope::new(Arc::clone(db)))
|
|
||||||
}
|
|
||||||
|
|
||||||
pub(super) fn skill_registry(&self) -> Option<&Arc<std::sync::RwLock<SkillRegistry>>> {
|
pub(super) fn skill_registry(&self) -> Option<&Arc<std::sync::RwLock<SkillRegistry>>> {
|
||||||
self.deps.skill_registry.as_ref()
|
self.deps.skill_registry.as_ref()
|
||||||
}
|
}
|
||||||
@@ -459,8 +400,8 @@ impl Agent {
|
|||||||
self.config.stuck_threshold,
|
self.config.stuck_threshold,
|
||||||
self.config.max_repair_attempts,
|
self.config.max_repair_attempts,
|
||||||
);
|
);
|
||||||
if let Some(admin) = self.admin_store() {
|
if let Some(ref store) = self.deps.store {
|
||||||
self_repair = self_repair.with_store(admin);
|
self_repair = self_repair.with_store(Arc::clone(store));
|
||||||
}
|
}
|
||||||
if let Some(ref builder) = self.deps.builder {
|
if let Some(ref builder) = self.deps.builder {
|
||||||
self_repair = self_repair.with_builder(Arc::clone(builder), Arc::clone(self.tools()));
|
self_repair = self_repair.with_builder(Arc::clone(builder), Arc::clone(self.tools()));
|
||||||
@@ -567,7 +508,6 @@ impl Agent {
|
|||||||
.with_interval(std::time::Duration::from_secs(hb_config.interval_secs));
|
.with_interval(std::time::Duration::from_secs(hb_config.interval_secs));
|
||||||
config.quiet_hours_start = hb_config.quiet_hours_start;
|
config.quiet_hours_start = hb_config.quiet_hours_start;
|
||||||
config.quiet_hours_end = hb_config.quiet_hours_end;
|
config.quiet_hours_end = hb_config.quiet_hours_end;
|
||||||
config.multi_tenant = hb_config.multi_tenant;
|
|
||||||
config.timezone = hb_config
|
config.timezone = hb_config
|
||||||
.timezone
|
.timezone
|
||||||
.clone()
|
.clone()
|
||||||
@@ -597,43 +537,22 @@ impl Agent {
|
|||||||
.await;
|
.await;
|
||||||
let notify_user = heartbeat_notify_user;
|
let notify_user = heartbeat_notify_user;
|
||||||
let channels = self.channels.clone();
|
let channels = self.channels.clone();
|
||||||
let is_multi_tenant = hb_config.multi_tenant;
|
|
||||||
tokio::spawn(async move {
|
tokio::spawn(async move {
|
||||||
while let Some(response) = notify_rx.recv().await {
|
while let Some(response) = notify_rx.recv().await {
|
||||||
// In multi-tenant mode, extract the owning user_id from
|
|
||||||
// the response metadata so notifications reach the
|
|
||||||
// correct user rather than the agent's owner.
|
|
||||||
// This intentionally overrides the configured notify_target
|
|
||||||
// because each user's heartbeat should notify that user.
|
|
||||||
let effective_user = if is_multi_tenant {
|
|
||||||
response
|
|
||||||
.metadata
|
|
||||||
.get("owner_id")
|
|
||||||
.and_then(|v| v.as_str())
|
|
||||||
.map(String::from)
|
|
||||||
} else {
|
|
||||||
None
|
|
||||||
};
|
|
||||||
|
|
||||||
// Try the configured channel first, fall back to
|
// Try the configured channel first, fall back to
|
||||||
// broadcasting on all channels.
|
// broadcasting on all channels.
|
||||||
let targeted_ok = if let Some(ref channel) = notify_channel {
|
let targeted_ok = if let Some(ref channel) = notify_channel
|
||||||
let target = effective_user.as_deref().or(notify_target.as_deref());
|
&& let Some(ref user) = notify_target
|
||||||
if let Some(user) = target {
|
{
|
||||||
channels
|
channels
|
||||||
.broadcast(channel, user, response.clone())
|
.broadcast(channel, user, response.clone())
|
||||||
.await
|
.await
|
||||||
.is_ok()
|
.is_ok()
|
||||||
} else {
|
} else {
|
||||||
false
|
false
|
||||||
}
|
|
||||||
} else {
|
|
||||||
false
|
|
||||||
};
|
};
|
||||||
|
|
||||||
if !targeted_ok {
|
if !targeted_ok && let Some(ref user) = notify_user {
|
||||||
let fallback = effective_user.as_deref().or(notify_user.as_deref());
|
|
||||||
if let Some(user) = fallback {
|
|
||||||
let results = channels.broadcast_all(user, response).await;
|
let results = channels.broadcast_all(user, response).await;
|
||||||
for (ch, result) in results {
|
for (ch, result) in results {
|
||||||
if let Err(e) = result {
|
if let Err(e) = result {
|
||||||
@@ -646,7 +565,6 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
});
|
});
|
||||||
|
|
||||||
let hygiene = self
|
let hygiene = self
|
||||||
@@ -655,29 +573,14 @@ impl Agent {
|
|||||||
.map(|h| h.to_workspace_config())
|
.map(|h| h.to_workspace_config())
|
||||||
.unwrap_or_default();
|
.unwrap_or_default();
|
||||||
|
|
||||||
if config.multi_tenant {
|
|
||||||
if let Some(admin) = self.admin_store() {
|
|
||||||
Some(spawn_multi_user_heartbeat(
|
|
||||||
config,
|
|
||||||
hygiene,
|
|
||||||
self.cheap_llm().clone(),
|
|
||||||
Some(notify_tx),
|
|
||||||
admin,
|
|
||||||
))
|
|
||||||
} else {
|
|
||||||
tracing::warn!("Multi-tenant heartbeat requires a database store");
|
|
||||||
None
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
Some(spawn_heartbeat(
|
Some(spawn_heartbeat(
|
||||||
config,
|
config,
|
||||||
hygiene,
|
hygiene,
|
||||||
workspace.clone(),
|
workspace.clone(),
|
||||||
self.cheap_llm().clone(),
|
self.cheap_llm().clone(),
|
||||||
Some(notify_tx),
|
Some(notify_tx),
|
||||||
self.admin_store(),
|
self.store().map(Arc::clone),
|
||||||
))
|
))
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
tracing::warn!("Heartbeat enabled but no workspace available");
|
tracing::warn!("Heartbeat enabled but no workspace available");
|
||||||
None
|
None
|
||||||
@@ -699,7 +602,7 @@ impl Agent {
|
|||||||
|
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
rt_config.clone(),
|
rt_config.clone(),
|
||||||
crate::tenant::AdminScope::new(Arc::clone(store)),
|
Arc::clone(store),
|
||||||
self.llm().clone(),
|
self.llm().clone(),
|
||||||
Arc::clone(workspace),
|
Arc::clone(workspace),
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -1237,14 +1140,9 @@ impl Agent {
|
|||||||
&& let Submission::UserInput { ref content } = submission
|
&& let Submission::UserInput { ref content } = submission
|
||||||
&& let Some(engine) = self.routine_engine().await
|
&& let Some(engine) = self.routine_engine().await
|
||||||
{
|
{
|
||||||
let single_message_repl = is_single_message_repl(message);
|
|
||||||
// Use post-hook content so that BeforeInbound hooks that rewrite
|
// Use post-hook content so that BeforeInbound hooks that rewrite
|
||||||
// input are respected by event trigger matching.
|
// input are respected by event trigger matching.
|
||||||
let fired = if single_message_repl {
|
let fired = engine.check_event_triggers(message, content).await;
|
||||||
engine.check_event_triggers_and_wait(message, content).await
|
|
||||||
} else {
|
|
||||||
engine.check_event_triggers(message, content).await
|
|
||||||
};
|
|
||||||
if fired > 0 {
|
if fired > 0 {
|
||||||
tracing::debug!(
|
tracing::debug!(
|
||||||
channel = %message.channel,
|
channel = %message.channel,
|
||||||
@@ -1252,30 +1150,15 @@ impl Agent {
|
|||||||
fired,
|
fired,
|
||||||
"Consumed inbound user message with matching event-triggered routine(s)"
|
"Consumed inbound user message with matching event-triggered routine(s)"
|
||||||
);
|
);
|
||||||
return if single_message_repl {
|
return Ok(Some(String::new()));
|
||||||
Ok(None)
|
|
||||||
} else {
|
|
||||||
Ok(Some(String::new()))
|
|
||||||
};
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Build per-tenant execution context once; threaded through all handlers.
|
|
||||||
let tenant = self.tenant_ctx(&message.user_id).await;
|
|
||||||
|
|
||||||
let session_for_empty_exit = Arc::clone(&session);
|
|
||||||
|
|
||||||
// Process based on submission type
|
// Process based on submission type
|
||||||
let result = match submission {
|
let result = match submission {
|
||||||
Submission::UserInput { content } => {
|
Submission::UserInput { content } => {
|
||||||
let mut result = self
|
let mut result = self
|
||||||
.process_user_input(
|
.process_user_input(message, session.clone(), thread_id, &content)
|
||||||
message,
|
|
||||||
tenant.clone(),
|
|
||||||
session.clone(),
|
|
||||||
thread_id,
|
|
||||||
&content,
|
|
||||||
)
|
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
// Drain any messages queued during processing.
|
// Drain any messages queued during processing.
|
||||||
@@ -1342,13 +1225,7 @@ impl Agent {
|
|||||||
let mut queued_msg = message.clone();
|
let mut queued_msg = message.clone();
|
||||||
queued_msg.attachments.clear();
|
queued_msg.attachments.clear();
|
||||||
result = self
|
result = self
|
||||||
.process_user_input(
|
.process_user_input(&queued_msg, session.clone(), thread_id, &next_content)
|
||||||
&queued_msg,
|
|
||||||
tenant.clone(),
|
|
||||||
session.clone(),
|
|
||||||
thread_id,
|
|
||||||
&next_content,
|
|
||||||
)
|
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
// If processing failed, re-queue the drained content so it
|
// If processing failed, re-queue the drained content so it
|
||||||
@@ -1386,17 +1263,11 @@ impl Agent {
|
|||||||
SubmissionResult::Error { message } => {
|
SubmissionResult::Error { message } => {
|
||||||
Ok(Some(format!("Error: {}", message)))
|
Ok(Some(format!("Error: {}", message)))
|
||||||
}
|
}
|
||||||
_ => {
|
_ => Ok(Some(String::new())),
|
||||||
if is_single_message_repl(message) {
|
|
||||||
Ok(None)
|
|
||||||
} else {
|
|
||||||
Ok(Some(String::new()))
|
|
||||||
}
|
|
||||||
}
|
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
// Authorization checks (including restart channel check) are enforced in handle_system_command
|
// Authorization checks (including restart channel check) are enforced in handle_system_command
|
||||||
self.handle_system_command(&command, &args, &message.channel, &tenant)
|
self.handle_system_command(&command, &args, &message.channel)
|
||||||
.await
|
.await
|
||||||
}
|
}
|
||||||
Submission::Undo => self.process_undo(session, thread_id).await,
|
Submission::Undo => self.process_undo(session, thread_id).await,
|
||||||
@@ -1409,9 +1280,12 @@ impl Agent {
|
|||||||
Submission::Summarize => self.process_summarize(session, thread_id).await,
|
Submission::Summarize => self.process_summarize(session, thread_id).await,
|
||||||
Submission::Suggest => self.process_suggest(session, thread_id).await,
|
Submission::Suggest => self.process_suggest(session, thread_id).await,
|
||||||
Submission::JobStatus { job_id } => {
|
Submission::JobStatus { job_id } => {
|
||||||
self.process_job_status(&tenant, job_id.as_deref()).await
|
self.process_job_status(&message.user_id, job_id.as_deref())
|
||||||
|
.await
|
||||||
|
}
|
||||||
|
Submission::JobCancel { job_id } => {
|
||||||
|
self.process_job_cancel(&message.user_id, &job_id).await
|
||||||
}
|
}
|
||||||
Submission::JobCancel { job_id } => self.process_job_cancel(&tenant, &job_id).await,
|
|
||||||
Submission::Quit => return Ok(None),
|
Submission::Quit => return Ok(None),
|
||||||
Submission::SwitchThread { thread_id: target } => {
|
Submission::SwitchThread { thread_id: target } => {
|
||||||
self.process_switch_thread(message, target).await
|
self.process_switch_thread(message, target).await
|
||||||
@@ -1451,26 +1325,7 @@ impl Agent {
|
|||||||
Ok(Some(content))
|
Ok(Some(content))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
SubmissionResult::Ok {
|
SubmissionResult::Ok { message } => Ok(message),
|
||||||
message: output_message,
|
|
||||||
} => {
|
|
||||||
let should_exit =
|
|
||||||
if output_message.as_deref() == Some("") && is_single_message_repl(message) {
|
|
||||||
let sess = session_for_empty_exit.lock().await;
|
|
||||||
sess.threads
|
|
||||||
.get(&thread_id)
|
|
||||||
.map(|thread| thread.state != ThreadState::AwaitingApproval)
|
|
||||||
.unwrap_or(true)
|
|
||||||
} else {
|
|
||||||
false
|
|
||||||
};
|
|
||||||
|
|
||||||
if should_exit {
|
|
||||||
Ok(None)
|
|
||||||
} else {
|
|
||||||
Ok(output_message)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
SubmissionResult::Error { message } => Ok(Some(format!("Error: {}", message))),
|
SubmissionResult::Error { message } => Ok(Some(format!("Error: {}", message))),
|
||||||
SubmissionResult::Interrupted => Ok(Some("Interrupted.".into())),
|
SubmissionResult::Interrupted => Ok(Some("Interrupted.".into())),
|
||||||
SubmissionResult::NeedApproval { .. } => {
|
SubmissionResult::NeedApproval { .. } => {
|
||||||
@@ -1486,7 +1341,7 @@ impl Agent {
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::{
|
use super::{
|
||||||
chat_tool_execution_metadata, is_single_message_repl, resolve_routine_notification_user,
|
chat_tool_execution_metadata, resolve_routine_notification_user,
|
||||||
should_fallback_routine_notification, truncate_for_preview,
|
should_fallback_routine_notification, truncate_for_preview,
|
||||||
};
|
};
|
||||||
use crate::channels::IncomingMessage;
|
use crate::channels::IncomingMessage;
|
||||||
@@ -1648,17 +1503,4 @@ mod tests {
|
|||||||
|
|
||||||
assert!(should_fallback_routine_notification(&error)); // safety: test-only assertion
|
assert!(should_fallback_routine_notification(&error)); // safety: test-only assertion
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn single_message_repl_detection_requires_repl_channel_and_metadata_flag() {
|
|
||||||
let repl = IncomingMessage::new("repl", "owner-scope", "hello")
|
|
||||||
.with_metadata(serde_json::json!({ "single_message_mode": true }));
|
|
||||||
let gateway = IncomingMessage::new("gateway", "owner-scope", "hello")
|
|
||||||
.with_metadata(serde_json::json!({ "single_message_mode": true }));
|
|
||||||
let plain_repl = IncomingMessage::new("repl", "owner-scope", "hello");
|
|
||||||
|
|
||||||
assert!(is_single_message_repl(&repl)); // safety: test-only assertion
|
|
||||||
assert!(!is_single_message_repl(&gateway)); // safety: test-only assertion
|
|
||||||
assert!(!is_single_message_repl(&plain_repl)); // safety: test-only assertion
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-125
@@ -10,7 +10,7 @@ use std::borrow::Cow;
|
|||||||
|
|
||||||
use crate::agent::session::PendingApproval;
|
use crate::agent::session::PendingApproval;
|
||||||
use crate::error::Error;
|
use crate::error::Error;
|
||||||
use crate::llm::{ChatMessage, FinishReason, Reasoning, ReasoningContext, RespondResult};
|
use crate::llm::{ChatMessage, Reasoning, ReasoningContext, RespondResult};
|
||||||
|
|
||||||
/// Signal from the delegate indicating how the loop should proceed.
|
/// Signal from the delegate indicating how the loop should proceed.
|
||||||
pub enum LoopSignal {
|
pub enum LoopSignal {
|
||||||
@@ -134,9 +134,6 @@ pub async fn run_agentic_loop(
|
|||||||
config: &AgenticLoopConfig,
|
config: &AgenticLoopConfig,
|
||||||
) -> Result<LoopOutcome, Error> {
|
) -> Result<LoopOutcome, Error> {
|
||||||
let mut consecutive_tool_intent_nudges: u32 = 0;
|
let mut consecutive_tool_intent_nudges: u32 = 0;
|
||||||
// Accumulates across all iterations (not reset by text responses) so
|
|
||||||
// non-consecutive truncations still escalate to force_text.
|
|
||||||
let mut truncation_count: u32 = 0;
|
|
||||||
|
|
||||||
for iteration in 1..=config.max_iterations {
|
for iteration in 1..=config.max_iterations {
|
||||||
// Check for external signals (stop, cancellation, user messages)
|
// Check for external signals (stop, cancellation, user messages)
|
||||||
@@ -218,35 +215,7 @@ pub async fn run_agentic_loop(
|
|||||||
tool_calls,
|
tool_calls,
|
||||||
content,
|
content,
|
||||||
} => {
|
} => {
|
||||||
// If the response was truncated, tool call parameters are likely
|
|
||||||
// incomplete. Discard them and tell the LLM to try a different
|
|
||||||
// approach rather than executing malformed tool calls.
|
|
||||||
if output.finish_reason == FinishReason::Length {
|
|
||||||
truncation_count += 1;
|
|
||||||
let names: Vec<&str> = tool_calls.iter().map(|tc| tc.name.as_str()).collect();
|
|
||||||
tracing::warn!(
|
|
||||||
iteration,
|
|
||||||
tools = ?names,
|
|
||||||
truncation_count,
|
|
||||||
"Discarding truncated tool calls (finish_reason=Length)"
|
|
||||||
);
|
|
||||||
if let Some(ref text) = content {
|
|
||||||
reason_ctx.messages.push(ChatMessage::assistant(text));
|
|
||||||
}
|
|
||||||
reason_ctx
|
|
||||||
.messages
|
|
||||||
.push(ChatMessage::user(crate::llm::TRUNCATED_TOOL_CALL_NOTICE));
|
|
||||||
// After repeated truncations, force text-only mode so the LLM
|
|
||||||
// stops attempting tool calls it can't fit in the output budget.
|
|
||||||
if truncation_count >= 3 {
|
|
||||||
reason_ctx.force_text = true;
|
|
||||||
}
|
|
||||||
delegate.after_iteration(iteration).await;
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
consecutive_tool_intent_nudges = 0;
|
consecutive_tool_intent_nudges = 0;
|
||||||
truncation_count = 0;
|
|
||||||
|
|
||||||
if let Some(outcome) = delegate
|
if let Some(outcome) = delegate
|
||||||
.execute_tool_calls(tool_calls, content, reason_ctx)
|
.execute_tool_calls(tool_calls, content, reason_ctx)
|
||||||
@@ -302,7 +271,6 @@ mod tests {
|
|||||||
RespondOutput {
|
RespondOutput {
|
||||||
result: RespondResult::Text(text.to_string()),
|
result: RespondResult::Text(text.to_string()),
|
||||||
usage: zero_usage(),
|
usage: zero_usage(),
|
||||||
finish_reason: FinishReason::Stop,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -313,7 +281,6 @@ mod tests {
|
|||||||
content: None,
|
content: None,
|
||||||
},
|
},
|
||||||
usage: zero_usage(),
|
usage: zero_usage(),
|
||||||
finish_reason: FinishReason::ToolUse,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -655,95 +622,4 @@ mod tests {
|
|||||||
let result = truncate_for_preview("café", 4);
|
let result = truncate_for_preview("café", 4);
|
||||||
assert_eq!(result, "caf...");
|
assert_eq!(result, "caf...");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_truncated_tool_calls_discarded_on_length() {
|
|
||||||
let truncated_tool_call = ToolCall {
|
|
||||||
id: "call_1".to_string(),
|
|
||||||
name: "memory_write".to_string(),
|
|
||||||
arguments: serde_json::json!({}), // empty — truncated
|
|
||||||
reasoning: None,
|
|
||||||
};
|
|
||||||
let truncated_output = RespondOutput {
|
|
||||||
result: RespondResult::ToolCalls {
|
|
||||||
tool_calls: vec![truncated_tool_call],
|
|
||||||
content: Some("I'll write the report.".to_string()),
|
|
||||||
},
|
|
||||||
usage: zero_usage(),
|
|
||||||
finish_reason: FinishReason::Length, // response was truncated
|
|
||||||
};
|
|
||||||
let delegate = MockDelegate::new(vec![truncated_output, text_output("Summarized it.")]);
|
|
||||||
let reasoning = stub_reasoning();
|
|
||||||
let mut ctx = ReasoningContext::new();
|
|
||||||
let config = AgenticLoopConfig {
|
|
||||||
max_iterations: 5,
|
|
||||||
..Default::default()
|
|
||||||
};
|
|
||||||
|
|
||||||
let outcome = run_agentic_loop(&delegate, &reasoning, &mut ctx, &config)
|
|
||||||
.await
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
// Tool calls should NOT have been executed
|
|
||||||
assert_eq!(delegate.tool_exec_count.load(Ordering::SeqCst), 0);
|
|
||||||
// The loop should have continued and returned the text response
|
|
||||||
assert!(matches!(outcome, LoopOutcome::Response(ref t) if t == "Summarized it."));
|
|
||||||
// A truncation notice should have been injected into context
|
|
||||||
assert!(
|
|
||||||
ctx.messages
|
|
||||||
.iter()
|
|
||||||
.any(|m| m.role == crate::llm::Role::User && m.content.contains("truncated")),
|
|
||||||
"Should inject truncation notice into context"
|
|
||||||
);
|
|
||||||
// The partial assistant content should have been preserved
|
|
||||||
assert!(
|
|
||||||
ctx.messages
|
|
||||||
.iter()
|
|
||||||
.any(|m| m.role == crate::llm::Role::Assistant
|
|
||||||
&& m.content.contains("write the report")),
|
|
||||||
"Should preserve partial assistant content"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_repeated_truncations_force_text_mode() {
|
|
||||||
let make_truncated = || RespondOutput {
|
|
||||||
result: RespondResult::ToolCalls {
|
|
||||||
tool_calls: vec![ToolCall {
|
|
||||||
id: "call_1".to_string(),
|
|
||||||
name: "memory_write".to_string(),
|
|
||||||
arguments: serde_json::json!({}),
|
|
||||||
reasoning: None,
|
|
||||||
}],
|
|
||||||
content: None,
|
|
||||||
},
|
|
||||||
usage: zero_usage(),
|
|
||||||
finish_reason: FinishReason::Length,
|
|
||||||
};
|
|
||||||
// Three truncated responses, then a text response
|
|
||||||
let delegate = MockDelegate::new(vec![
|
|
||||||
make_truncated(),
|
|
||||||
make_truncated(),
|
|
||||||
make_truncated(),
|
|
||||||
text_output("Gave up on tool calls."),
|
|
||||||
]);
|
|
||||||
let reasoning = stub_reasoning();
|
|
||||||
let mut ctx = ReasoningContext::new();
|
|
||||||
let config = AgenticLoopConfig {
|
|
||||||
max_iterations: 5,
|
|
||||||
..Default::default()
|
|
||||||
};
|
|
||||||
|
|
||||||
let outcome = run_agentic_loop(&delegate, &reasoning, &mut ctx, &config)
|
|
||||||
.await
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
assert!(matches!(outcome, LoopOutcome::Response(_)));
|
|
||||||
assert_eq!(delegate.tool_exec_count.load(Ordering::SeqCst), 0);
|
|
||||||
// After 3 truncations, force_text should be set
|
|
||||||
assert!(
|
|
||||||
ctx.force_text,
|
|
||||||
"Should escalate to force_text after repeated truncations"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
+42
-77
@@ -33,7 +33,6 @@ impl Agent {
|
|||||||
&self,
|
&self,
|
||||||
intent: MessageIntent,
|
intent: MessageIntent,
|
||||||
message: &IncomingMessage,
|
message: &IncomingMessage,
|
||||||
tenant: &crate::tenant::TenantCtx,
|
|
||||||
) -> Result<SubmissionResult, Error> {
|
) -> Result<SubmissionResult, Error> {
|
||||||
// Send thinking status for non-trivial operations
|
// Send thinking status for non-trivial operations
|
||||||
if let MessageIntent::CreateJob { .. } = &intent {
|
if let MessageIntent::CreateJob { .. } = &intent {
|
||||||
@@ -53,18 +52,24 @@ impl Agent {
|
|||||||
description,
|
description,
|
||||||
category,
|
category,
|
||||||
} => {
|
} => {
|
||||||
self.handle_create_job(tenant, title, description, category)
|
self.handle_create_job(&message.user_id, title, description, category)
|
||||||
.await?
|
.await?
|
||||||
}
|
}
|
||||||
MessageIntent::CheckJobStatus { job_id } => {
|
MessageIntent::CheckJobStatus { job_id } => {
|
||||||
self.handle_check_status(tenant, job_id).await?
|
self.handle_check_status(&message.user_id, job_id).await?
|
||||||
|
}
|
||||||
|
MessageIntent::CancelJob { job_id } => {
|
||||||
|
self.handle_cancel_job(&message.user_id, &job_id).await?
|
||||||
|
}
|
||||||
|
MessageIntent::ListJobs { filter } => {
|
||||||
|
self.handle_list_jobs(&message.user_id, filter).await?
|
||||||
|
}
|
||||||
|
MessageIntent::HelpJob { job_id } => {
|
||||||
|
self.handle_help_job(&message.user_id, &job_id).await?
|
||||||
}
|
}
|
||||||
MessageIntent::CancelJob { job_id } => self.handle_cancel_job(tenant, &job_id).await?,
|
|
||||||
MessageIntent::ListJobs { filter } => self.handle_list_jobs(tenant, filter).await?,
|
|
||||||
MessageIntent::HelpJob { job_id } => self.handle_help_job(tenant, &job_id).await?,
|
|
||||||
MessageIntent::Command { command, args } => {
|
MessageIntent::Command { command, args } => {
|
||||||
match self
|
match self
|
||||||
.handle_command(&command, &args, &message.channel, tenant)
|
.handle_command(&command, &args, &message.channel)
|
||||||
.await?
|
.await?
|
||||||
{
|
{
|
||||||
Some(s) => s,
|
Some(s) => s,
|
||||||
@@ -78,14 +83,14 @@ impl Agent {
|
|||||||
|
|
||||||
async fn handle_create_job(
|
async fn handle_create_job(
|
||||||
&self,
|
&self,
|
||||||
tenant: &crate::tenant::TenantCtx,
|
user_id: &str,
|
||||||
title: String,
|
title: String,
|
||||||
description: String,
|
description: String,
|
||||||
category: Option<String>,
|
category: Option<String>,
|
||||||
) -> Result<String, Error> {
|
) -> Result<String, Error> {
|
||||||
let job_id = self
|
let job_id = self
|
||||||
.scheduler
|
.scheduler
|
||||||
.dispatch_job(tenant.user_id(), &title, &description, None)
|
.dispatch_job(user_id, &title, &description, None)
|
||||||
.await?;
|
.await?;
|
||||||
|
|
||||||
// Set the dedicated category field (not stored in metadata)
|
// Set the dedicated category field (not stored in metadata)
|
||||||
@@ -108,7 +113,7 @@ impl Agent {
|
|||||||
|
|
||||||
async fn handle_check_status(
|
async fn handle_check_status(
|
||||||
&self,
|
&self,
|
||||||
tenant: &crate::tenant::TenantCtx,
|
user_id: &str,
|
||||||
job_id: Option<String>,
|
job_id: Option<String>,
|
||||||
) -> Result<String, Error> {
|
) -> Result<String, Error> {
|
||||||
match job_id {
|
match job_id {
|
||||||
@@ -117,8 +122,7 @@ impl Agent {
|
|||||||
.map_err(|_| crate::error::JobError::NotFound { id: Uuid::nil() })?;
|
.map_err(|_| crate::error::JobError::NotFound { id: Uuid::nil() })?;
|
||||||
|
|
||||||
// Try DB first for persistent state, fall back to ContextManager.
|
// Try DB first for persistent state, fall back to ContextManager.
|
||||||
// TenantScope.get_job() auto-filters by ownership — no manual check needed.
|
if let Some(store) = self.store()
|
||||||
if let Some(store) = tenant.store()
|
|
||||||
&& let Ok(Some(ctx)) = store.get_job(uuid).await
|
&& let Ok(Some(ctx)) = store.get_job(uuid).await
|
||||||
{
|
{
|
||||||
return Ok(format!(
|
return Ok(format!(
|
||||||
@@ -134,7 +138,7 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
|
|
||||||
let ctx = self.context_manager.get_context(uuid).await?;
|
let ctx = self.context_manager.get_context(uuid).await?;
|
||||||
if ctx.user_id != tenant.user_id() {
|
if ctx.user_id != user_id {
|
||||||
return Err(crate::error::JobError::NotFound { id: uuid }.into());
|
return Err(crate::error::JobError::NotFound { id: uuid }.into());
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -151,8 +155,7 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
None => {
|
None => {
|
||||||
// Show summary from DB for consistency with Jobs tab.
|
// Show summary from DB for consistency with Jobs tab.
|
||||||
// TenantScope methods auto-scope to user — no user_id parameter needed.
|
if let Some(store) = self.store() {
|
||||||
if let Some(store) = tenant.store() {
|
|
||||||
let mut total = 0;
|
let mut total = 0;
|
||||||
let mut in_progress = 0;
|
let mut in_progress = 0;
|
||||||
let mut completed = 0;
|
let mut completed = 0;
|
||||||
@@ -180,7 +183,7 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Fallback to ContextManager if no DB.
|
// Fallback to ContextManager if no DB.
|
||||||
let summary = self.context_manager.summary_for(tenant.user_id()).await;
|
let summary = self.context_manager.summary_for(user_id).await;
|
||||||
Ok(format!(
|
Ok(format!(
|
||||||
"Jobs summary: Total: {} In Progress: {} Completed: {} Failed: {} Stuck: {}",
|
"Jobs summary: Total: {} In Progress: {} Completed: {} Failed: {} Stuck: {}",
|
||||||
summary.total,
|
summary.total,
|
||||||
@@ -193,24 +196,19 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn handle_cancel_job(
|
async fn handle_cancel_job(&self, user_id: &str, job_id: &str) -> Result<String, Error> {
|
||||||
&self,
|
|
||||||
tenant: &crate::tenant::TenantCtx,
|
|
||||||
job_id: &str,
|
|
||||||
) -> Result<String, Error> {
|
|
||||||
let uuid = Uuid::parse_str(job_id)
|
let uuid = Uuid::parse_str(job_id)
|
||||||
.map_err(|_| crate::error::JobError::NotFound { id: Uuid::nil() })?;
|
.map_err(|_| crate::error::JobError::NotFound { id: Uuid::nil() })?;
|
||||||
|
|
||||||
let ctx = self.context_manager.get_context(uuid).await?;
|
let ctx = self.context_manager.get_context(uuid).await?;
|
||||||
if ctx.user_id != tenant.user_id() {
|
if ctx.user_id != user_id {
|
||||||
return Err(crate::error::JobError::NotFound { id: uuid }.into());
|
return Err(crate::error::JobError::NotFound { id: uuid }.into());
|
||||||
}
|
}
|
||||||
|
|
||||||
self.scheduler.stop(uuid).await?;
|
self.scheduler.stop(uuid).await?;
|
||||||
|
|
||||||
// Also update DB so the Jobs tab reflects cancellation immediately.
|
// Also update DB so the Jobs tab reflects cancellation immediately.
|
||||||
// Use TenantScope — ownership already verified above.
|
if let Some(store) = self.store()
|
||||||
if let Some(store) = tenant.store()
|
|
||||||
&& let Err(e) = store
|
&& let Err(e) = store
|
||||||
.update_job_status(uuid, JobState::Cancelled, Some("Cancelled by user"))
|
.update_job_status(uuid, JobState::Cancelled, Some("Cancelled by user"))
|
||||||
.await
|
.await
|
||||||
@@ -223,12 +221,11 @@ impl Agent {
|
|||||||
|
|
||||||
async fn handle_list_jobs(
|
async fn handle_list_jobs(
|
||||||
&self,
|
&self,
|
||||||
tenant: &crate::tenant::TenantCtx,
|
user_id: &str,
|
||||||
_filter: Option<String>,
|
_filter: Option<String>,
|
||||||
) -> Result<String, Error> {
|
) -> Result<String, Error> {
|
||||||
// List from DB for consistency with Jobs tab.
|
// List from DB for consistency with Jobs tab.
|
||||||
// TenantScope methods auto-scope to user.
|
if let Some(store) = self.store() {
|
||||||
if let Some(store) = tenant.store() {
|
|
||||||
let agent_jobs = match store.list_agent_jobs().await {
|
let agent_jobs = match store.list_agent_jobs().await {
|
||||||
Ok(jobs) => jobs,
|
Ok(jobs) => jobs,
|
||||||
Err(e) => {
|
Err(e) => {
|
||||||
@@ -259,7 +256,7 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Fallback to ContextManager if no DB.
|
// Fallback to ContextManager if no DB.
|
||||||
let jobs = self.context_manager.all_jobs_for(tenant.user_id()).await;
|
let jobs = self.context_manager.all_jobs_for(user_id).await;
|
||||||
if jobs.is_empty() {
|
if jobs.is_empty() {
|
||||||
return Ok("No jobs found.".to_string());
|
return Ok("No jobs found.".to_string());
|
||||||
}
|
}
|
||||||
@@ -273,16 +270,12 @@ impl Agent {
|
|||||||
Ok(output)
|
Ok(output)
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn handle_help_job(
|
async fn handle_help_job(&self, user_id: &str, job_id: &str) -> Result<String, Error> {
|
||||||
&self,
|
|
||||||
tenant: &crate::tenant::TenantCtx,
|
|
||||||
job_id: &str,
|
|
||||||
) -> Result<String, Error> {
|
|
||||||
let uuid = Uuid::parse_str(job_id)
|
let uuid = Uuid::parse_str(job_id)
|
||||||
.map_err(|_| crate::error::JobError::NotFound { id: Uuid::nil() })?;
|
.map_err(|_| crate::error::JobError::NotFound { id: Uuid::nil() })?;
|
||||||
|
|
||||||
let ctx = self.context_manager.get_context(uuid).await?;
|
let ctx = self.context_manager.get_context(uuid).await?;
|
||||||
if ctx.user_id != tenant.user_id() {
|
if ctx.user_id != user_id {
|
||||||
return Err(crate::error::JobError::NotFound { id: uuid }.into());
|
return Err(crate::error::JobError::NotFound { id: uuid }.into());
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -315,11 +308,11 @@ impl Agent {
|
|||||||
/// Show job status inline — either all jobs (no id) or a specific job.
|
/// Show job status inline — either all jobs (no id) or a specific job.
|
||||||
pub(super) async fn process_job_status(
|
pub(super) async fn process_job_status(
|
||||||
&self,
|
&self,
|
||||||
tenant: &crate::tenant::TenantCtx,
|
user_id: &str,
|
||||||
job_id: Option<&str>,
|
job_id: Option<&str>,
|
||||||
) -> Result<SubmissionResult, Error> {
|
) -> Result<SubmissionResult, Error> {
|
||||||
match self
|
match self
|
||||||
.handle_check_status(tenant, job_id.map(|s| s.to_string()))
|
.handle_check_status(user_id, job_id.map(|s| s.to_string()))
|
||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
Ok(text) => Ok(SubmissionResult::response(text)),
|
Ok(text) => Ok(SubmissionResult::response(text)),
|
||||||
@@ -330,10 +323,10 @@ impl Agent {
|
|||||||
/// Cancel a job by ID.
|
/// Cancel a job by ID.
|
||||||
pub(super) async fn process_job_cancel(
|
pub(super) async fn process_job_cancel(
|
||||||
&self,
|
&self,
|
||||||
tenant: &crate::tenant::TenantCtx,
|
user_id: &str,
|
||||||
job_id: &str,
|
job_id: &str,
|
||||||
) -> Result<SubmissionResult, Error> {
|
) -> Result<SubmissionResult, Error> {
|
||||||
match self.handle_cancel_job(tenant, job_id).await {
|
match self.handle_cancel_job(user_id, job_id).await {
|
||||||
Ok(text) => Ok(SubmissionResult::response(text)),
|
Ok(text) => Ok(SubmissionResult::response(text)),
|
||||||
Err(e) => Ok(SubmissionResult::error(format!("Cancel error: {}", e))),
|
Err(e) => Ok(SubmissionResult::error(format!("Cancel error: {}", e))),
|
||||||
}
|
}
|
||||||
@@ -566,7 +559,6 @@ impl Agent {
|
|||||||
command: &str,
|
command: &str,
|
||||||
args: &[String],
|
args: &[String],
|
||||||
channel: &str,
|
channel: &str,
|
||||||
tenant: &crate::tenant::TenantCtx,
|
|
||||||
) -> Result<SubmissionResult, Error> {
|
) -> Result<SubmissionResult, Error> {
|
||||||
match command {
|
match command {
|
||||||
"help" => Ok(SubmissionResult::response(concat!(
|
"help" => Ok(SubmissionResult::response(concat!(
|
||||||
@@ -760,22 +752,10 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if self.config.multi_tenant {
|
|
||||||
// Multi-tenant: only persist to per-user DB settings.
|
|
||||||
// Do NOT call set_model() on the shared provider — that
|
|
||||||
// would change the default for all users. The per-request
|
|
||||||
// model_override in the dispatcher reads from the same
|
|
||||||
// "selected_model" setting and applies it per-user.
|
|
||||||
self.persist_selected_model(tenant, requested).await;
|
|
||||||
Ok(SubmissionResult::response(format!(
|
|
||||||
"Model preference set to: {} (per-user)",
|
|
||||||
requested
|
|
||||||
)))
|
|
||||||
} else {
|
|
||||||
match self.llm().set_model(requested) {
|
match self.llm().set_model(requested) {
|
||||||
Ok(()) => {
|
Ok(()) => {
|
||||||
// Persist the model choice so it survives restarts.
|
// Persist the model choice so it survives restarts.
|
||||||
self.persist_selected_model(tenant, requested).await;
|
self.persist_selected_model(requested).await;
|
||||||
Ok(SubmissionResult::response(format!(
|
Ok(SubmissionResult::response(format!(
|
||||||
"Switched model to: {}",
|
"Switched model to: {}",
|
||||||
requested
|
requested
|
||||||
@@ -788,7 +768,6 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
_ => Ok(SubmissionResult::error(format!(
|
_ => Ok(SubmissionResult::error(format!(
|
||||||
"Unknown command: {}. Try /help",
|
"Unknown command: {}. Try /help",
|
||||||
@@ -927,14 +906,10 @@ impl Agent {
|
|||||||
command: &str,
|
command: &str,
|
||||||
args: &[String],
|
args: &[String],
|
||||||
channel: &str,
|
channel: &str,
|
||||||
tenant: &crate::tenant::TenantCtx,
|
|
||||||
) -> Result<Option<String>, Error> {
|
) -> Result<Option<String>, Error> {
|
||||||
// System commands are now handled directly via Submission::SystemCommand,
|
// System commands are now handled directly via Submission::SystemCommand,
|
||||||
// but the router may still send us unknown /commands.
|
// but the router may still send us unknown /commands.
|
||||||
match self
|
match self.handle_system_command(command, args, channel).await? {
|
||||||
.handle_system_command(command, args, channel, tenant)
|
|
||||||
.await?
|
|
||||||
{
|
|
||||||
SubmissionResult::Response { content } => Ok(Some(content)),
|
SubmissionResult::Response { content } => Ok(Some(content)),
|
||||||
SubmissionResult::Ok { message } => Ok(message),
|
SubmissionResult::Ok { message } => Ok(message),
|
||||||
SubmissionResult::Error { message } => Ok(Some(format!("Error: {}", message))),
|
SubmissionResult::Error { message } => Ok(Some(format!("Error: {}", message))),
|
||||||
@@ -946,33 +921,23 @@ impl Agent {
|
|||||||
///
|
///
|
||||||
/// Best-effort: logs warnings on failure but does not propagate errors,
|
/// Best-effort: logs warnings on failure but does not propagate errors,
|
||||||
/// since the in-memory model switch already succeeded.
|
/// since the in-memory model switch already succeeded.
|
||||||
///
|
async fn persist_selected_model(&self, model: &str) {
|
||||||
/// In multi-tenant mode, only the per-user DB setting is written — global
|
// 1. Persist to DB if available.
|
||||||
/// .env and TOML files are shared across users and must not be mutated.
|
if let Some(store) = self.store() {
|
||||||
async fn persist_selected_model(&self, tenant: &crate::tenant::TenantCtx, model: &str) {
|
|
||||||
// 1. Persist to DB if available (per-user scoped via TenantScope).
|
|
||||||
if let Some(store) = tenant.store() {
|
|
||||||
let value = serde_json::Value::String(model.to_string());
|
let value = serde_json::Value::String(model.to_string());
|
||||||
if let Err(e) = store.set_setting("selected_model", &value).await {
|
if let Err(e) = store
|
||||||
|
.set_setting(self.owner_id(), "selected_model", &value)
|
||||||
|
.await
|
||||||
|
{
|
||||||
tracing::warn!("Failed to persist model to DB: {}", e);
|
tracing::warn!("Failed to persist model to DB: {}", e);
|
||||||
} else {
|
} else {
|
||||||
tracing::debug!(
|
tracing::debug!("Persisted selected_model to DB: {}", model);
|
||||||
user_id = tenant.user_id(),
|
|
||||||
"Persisted selected_model to DB: {}",
|
|
||||||
model
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
tracing::warn!("No database store available — model choice will not persist to DB");
|
tracing::warn!("No database store available — model choice will not persist to DB");
|
||||||
}
|
}
|
||||||
|
|
||||||
// 2. In multi-tenant mode, skip .env/TOML writes — these are global
|
// 2. Update .env and TOML config file (sync I/O in spawn_blocking).
|
||||||
// files shared by all users. The per-user DB setting is sufficient.
|
|
||||||
if self.config.multi_tenant {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
// 3. Update .env and TOML config file (sync I/O in spawn_blocking).
|
|
||||||
let model_owned = model.to_string();
|
let model_owned = model.to_string();
|
||||||
let backend = self.deps.llm_backend.clone();
|
let backend = self.deps.llm_backend.clone();
|
||||||
if let Err(e) = tokio::task::spawn_blocking(move || {
|
if let Err(e) = tokio::task::spawn_blocking(move || {
|
||||||
|
|||||||
+3
-236
@@ -21,9 +21,6 @@ pub struct CostGuardConfig {
|
|||||||
pub max_cost_per_day_cents: Option<u64>,
|
pub max_cost_per_day_cents: Option<u64>,
|
||||||
/// Maximum LLM calls per hour. None = unlimited.
|
/// Maximum LLM calls per hour. None = unlimited.
|
||||||
pub max_actions_per_hour: Option<u64>,
|
pub max_actions_per_hour: Option<u64>,
|
||||||
/// Maximum spend per user per day in cents. None = unlimited.
|
|
||||||
/// Applied independently per user alongside the global budget.
|
|
||||||
pub max_cost_per_user_per_day_cents: Option<u64>,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Error returned when a cost limit is exceeded.
|
/// Error returned when a cost limit is exceeded.
|
||||||
@@ -33,12 +30,6 @@ pub enum CostLimitExceeded {
|
|||||||
DailyBudget { spent_cents: u64, limit_cents: u64 },
|
DailyBudget { spent_cents: u64, limit_cents: u64 },
|
||||||
/// Hourly action rate limit reached.
|
/// Hourly action rate limit reached.
|
||||||
HourlyRate { actions: u64, limit: u64 },
|
HourlyRate { actions: u64, limit: u64 },
|
||||||
/// Per-user daily spending cap reached.
|
|
||||||
UserDailyBudget {
|
|
||||||
user_id: String,
|
|
||||||
spent_cents: u64,
|
|
||||||
limit_cents: u64,
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl std::fmt::Display for CostLimitExceeded {
|
impl std::fmt::Display for CostLimitExceeded {
|
||||||
@@ -58,17 +49,6 @@ impl std::fmt::Display for CostLimitExceeded {
|
|||||||
"Hourly action limit exceeded: {} actions of {} allowed per hour",
|
"Hourly action limit exceeded: {} actions of {} allowed per hour",
|
||||||
actions, limit
|
actions, limit
|
||||||
),
|
),
|
||||||
Self::UserDailyBudget {
|
|
||||||
user_id,
|
|
||||||
spent_cents,
|
|
||||||
limit_cents,
|
|
||||||
} => write!(
|
|
||||||
f,
|
|
||||||
"User '{}' daily cost limit exceeded: spent ${:.2} of ${:.2} allowed",
|
|
||||||
user_id,
|
|
||||||
*spent_cents as f64 / 100.0,
|
|
||||||
*limit_cents as f64 / 100.0
|
|
||||||
),
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -98,9 +78,6 @@ pub struct CostGuard {
|
|||||||
|
|
||||||
/// Per-model token usage since startup.
|
/// Per-model token usage since startup.
|
||||||
model_tokens: Mutex<HashMap<String, ModelTokens>>,
|
model_tokens: Mutex<HashMap<String, ModelTokens>>,
|
||||||
|
|
||||||
/// Per-user daily cost tracking. Each entry resets independently at midnight UTC.
|
|
||||||
per_user_daily_cost: Mutex<HashMap<String, DailyCost>>,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
struct DailyCost {
|
struct DailyCost {
|
||||||
@@ -120,7 +97,6 @@ impl CostGuard {
|
|||||||
action_window: Mutex::new(VecDeque::new()),
|
action_window: Mutex::new(VecDeque::new()),
|
||||||
budget_exceeded: AtomicBool::new(false),
|
budget_exceeded: AtomicBool::new(false),
|
||||||
model_tokens: Mutex::new(HashMap::new()),
|
model_tokens: Mutex::new(HashMap::new()),
|
||||||
per_user_daily_cost: Mutex::new(HashMap::new()),
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -227,11 +203,6 @@ impl CostGuard {
|
|||||||
daily.reset_date = today;
|
daily.reset_date = today;
|
||||||
self.budget_exceeded.store(false, Ordering::Relaxed);
|
self.budget_exceeded.store(false, Ordering::Relaxed);
|
||||||
tracing::info!("Cost guard: daily counter reset for {}", today);
|
tracing::info!("Cost guard: daily counter reset for {}", today);
|
||||||
|
|
||||||
// Prune per-user entries from previous days to prevent
|
|
||||||
// unbounded HashMap growth in long-lived deployments.
|
|
||||||
let mut per_user = self.per_user_daily_cost.lock().await;
|
|
||||||
per_user.retain(|_, entry| entry.reset_date == today);
|
|
||||||
}
|
}
|
||||||
daily.total += cost;
|
daily.total += cost;
|
||||||
|
|
||||||
@@ -277,85 +248,6 @@ impl CostGuard {
|
|||||||
cost
|
cost
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Record an LLM call with per-user attribution.
|
|
||||||
///
|
|
||||||
/// Delegates to `record_llm_call` for global tracking, then additionally
|
|
||||||
/// records the cost against the user's daily budget.
|
|
||||||
#[allow(clippy::too_many_arguments)]
|
|
||||||
pub async fn record_llm_call_for_user(
|
|
||||||
&self,
|
|
||||||
user_id: &str,
|
|
||||||
model: &str,
|
|
||||||
input_tokens: u32,
|
|
||||||
output_tokens: u32,
|
|
||||||
cache_read_input_tokens: u32,
|
|
||||||
cache_creation_input_tokens: u32,
|
|
||||||
cache_read_discount: Decimal,
|
|
||||||
cache_write_multiplier: Decimal,
|
|
||||||
cost_per_token: Option<(Decimal, Decimal)>,
|
|
||||||
) -> Decimal {
|
|
||||||
let cost = self
|
|
||||||
.record_llm_call(
|
|
||||||
model,
|
|
||||||
input_tokens,
|
|
||||||
output_tokens,
|
|
||||||
cache_read_input_tokens,
|
|
||||||
cache_creation_input_tokens,
|
|
||||||
cache_read_discount,
|
|
||||||
cache_write_multiplier,
|
|
||||||
cost_per_token,
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
|
|
||||||
// Track per-user daily cost
|
|
||||||
{
|
|
||||||
let today = chrono::Utc::now().date_naive();
|
|
||||||
let mut per_user = self.per_user_daily_cost.lock().await;
|
|
||||||
let entry = per_user
|
|
||||||
.entry(user_id.to_string())
|
|
||||||
.or_insert_with(|| DailyCost {
|
|
||||||
total: Decimal::ZERO,
|
|
||||||
reset_date: today,
|
|
||||||
});
|
|
||||||
if today != entry.reset_date {
|
|
||||||
entry.total = Decimal::ZERO;
|
|
||||||
entry.reset_date = today;
|
|
||||||
}
|
|
||||||
entry.total += cost;
|
|
||||||
}
|
|
||||||
|
|
||||||
cost
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Check whether the next action is allowed for a specific user.
|
|
||||||
///
|
|
||||||
/// Checks the global limits first (via `check_allowed`), then additionally
|
|
||||||
/// checks the per-user daily budget if configured.
|
|
||||||
pub async fn check_allowed_for_user(&self, user_id: &str) -> Result<(), CostLimitExceeded> {
|
|
||||||
// Check global limits first
|
|
||||||
self.check_allowed().await?;
|
|
||||||
|
|
||||||
// Check per-user daily budget
|
|
||||||
if let Some(limit_cents) = self.config.max_cost_per_user_per_day_cents {
|
|
||||||
let today = chrono::Utc::now().date_naive();
|
|
||||||
let per_user = self.per_user_daily_cost.lock().await;
|
|
||||||
if let Some(entry) = per_user.get(user_id)
|
|
||||||
&& entry.reset_date == today
|
|
||||||
{
|
|
||||||
let spent_cents = to_cents(entry.total);
|
|
||||||
if spent_cents >= limit_cents {
|
|
||||||
return Err(CostLimitExceeded::UserDailyBudget {
|
|
||||||
user_id: user_id.to_string(),
|
|
||||||
spent_cents,
|
|
||||||
limit_cents,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
Ok(())
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Current daily spend in USD (as Decimal).
|
/// Current daily spend in USD (as Decimal).
|
||||||
pub async fn daily_spend(&self) -> Decimal {
|
pub async fn daily_spend(&self) -> Decimal {
|
||||||
let daily = self.daily_cost.lock().await;
|
let daily = self.daily_cost.lock().await;
|
||||||
@@ -367,16 +259,6 @@ impl CostGuard {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Current daily spend for a specific user in USD (as Decimal).
|
|
||||||
pub async fn daily_spend_for_user(&self, user_id: &str) -> Decimal {
|
|
||||||
let today = chrono::Utc::now().date_naive();
|
|
||||||
let per_user = self.per_user_daily_cost.lock().await;
|
|
||||||
match per_user.get(user_id) {
|
|
||||||
Some(entry) if entry.reset_date == today => entry.total,
|
|
||||||
_ => Decimal::ZERO,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Number of actions in the current hourly window.
|
/// Number of actions in the current hourly window.
|
||||||
pub async fn actions_this_hour(&self) -> u64 {
|
pub async fn actions_this_hour(&self) -> u64 {
|
||||||
let mut window = self.action_window.lock().await;
|
let mut window = self.action_window.lock().await;
|
||||||
@@ -432,7 +314,7 @@ mod tests {
|
|||||||
async fn test_daily_budget_enforcement() {
|
async fn test_daily_budget_enforcement() {
|
||||||
let guard = CostGuard::new(CostGuardConfig {
|
let guard = CostGuard::new(CostGuardConfig {
|
||||||
max_cost_per_day_cents: Some(1), // $0.01 limit
|
max_cost_per_day_cents: Some(1), // $0.01 limit
|
||||||
..CostGuardConfig::default()
|
max_actions_per_hour: None,
|
||||||
});
|
});
|
||||||
|
|
||||||
// First call allowed
|
// First call allowed
|
||||||
@@ -468,8 +350,8 @@ mod tests {
|
|||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_hourly_rate_enforcement() {
|
async fn test_hourly_rate_enforcement() {
|
||||||
let guard = CostGuard::new(CostGuardConfig {
|
let guard = CostGuard::new(CostGuardConfig {
|
||||||
|
max_cost_per_day_cents: None,
|
||||||
max_actions_per_hour: Some(3),
|
max_actions_per_hour: Some(3),
|
||||||
..CostGuardConfig::default()
|
|
||||||
});
|
});
|
||||||
|
|
||||||
// First 3 actions allowed
|
// First 3 actions allowed
|
||||||
@@ -751,8 +633,8 @@ mod tests {
|
|||||||
// A fresh CostGuard with rate limits should not panic even if
|
// A fresh CostGuard with rate limits should not panic even if
|
||||||
// checked_sub returns None (simulating short uptime).
|
// checked_sub returns None (simulating short uptime).
|
||||||
let guard = CostGuard::new(CostGuardConfig {
|
let guard = CostGuard::new(CostGuardConfig {
|
||||||
|
max_cost_per_day_cents: None,
|
||||||
max_actions_per_hour: Some(100),
|
max_actions_per_hour: Some(100),
|
||||||
..CostGuardConfig::default()
|
|
||||||
});
|
});
|
||||||
|
|
||||||
// These must not panic regardless of system uptime
|
// These must not panic regardless of system uptime
|
||||||
@@ -774,119 +656,4 @@ mod tests {
|
|||||||
let result = Instant::now().checked_sub(std::time::Duration::MAX);
|
let result = Instant::now().checked_sub(std::time::Duration::MAX);
|
||||||
assert!(result.is_none());
|
assert!(result.is_none());
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_per_user_daily_budget_enforcement() {
|
|
||||||
let guard = CostGuard::new(CostGuardConfig {
|
|
||||||
max_cost_per_day_cents: None,
|
|
||||||
max_actions_per_hour: None,
|
|
||||||
max_cost_per_user_per_day_cents: Some(1), // $0.01 per user
|
|
||||||
});
|
|
||||||
|
|
||||||
// Both users initially allowed
|
|
||||||
assert!(guard.check_allowed_for_user("alice").await.is_ok());
|
|
||||||
assert!(guard.check_allowed_for_user("bob").await.is_ok());
|
|
||||||
|
|
||||||
// Alice makes an expensive call
|
|
||||||
guard
|
|
||||||
.record_llm_call_for_user(
|
|
||||||
"alice",
|
|
||||||
"gpt-4o",
|
|
||||||
10_000,
|
|
||||||
10_000,
|
|
||||||
0,
|
|
||||||
0,
|
|
||||||
Decimal::ONE,
|
|
||||||
Decimal::ONE,
|
|
||||||
None,
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
|
|
||||||
// Alice should be blocked, Bob should still be allowed
|
|
||||||
let result = guard.check_allowed_for_user("alice").await;
|
|
||||||
assert!(result.is_err());
|
|
||||||
match result.unwrap_err() {
|
|
||||||
CostLimitExceeded::UserDailyBudget {
|
|
||||||
user_id,
|
|
||||||
limit_cents,
|
|
||||||
..
|
|
||||||
} => {
|
|
||||||
assert_eq!(user_id, "alice");
|
|
||||||
assert_eq!(limit_cents, 1);
|
|
||||||
}
|
|
||||||
other => panic!("Expected UserDailyBudget, got {:?}", other),
|
|
||||||
}
|
|
||||||
assert!(guard.check_allowed_for_user("bob").await.is_ok());
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_per_user_daily_spend_tracking() {
|
|
||||||
let guard = CostGuard::new(CostGuardConfig::default());
|
|
||||||
|
|
||||||
assert_eq!(guard.daily_spend_for_user("alice").await, Decimal::ZERO);
|
|
||||||
assert_eq!(guard.daily_spend_for_user("bob").await, Decimal::ZERO);
|
|
||||||
|
|
||||||
let cost = guard
|
|
||||||
.record_llm_call_for_user(
|
|
||||||
"alice",
|
|
||||||
"gpt-4o",
|
|
||||||
1000,
|
|
||||||
500,
|
|
||||||
0,
|
|
||||||
0,
|
|
||||||
Decimal::ONE,
|
|
||||||
Decimal::ONE,
|
|
||||||
None,
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
|
|
||||||
assert_eq!(guard.daily_spend_for_user("alice").await, cost);
|
|
||||||
assert_eq!(guard.daily_spend_for_user("bob").await, Decimal::ZERO);
|
|
||||||
// Global spend should also be tracked
|
|
||||||
assert_eq!(guard.daily_spend().await, cost);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_per_user_budget_independent_of_global() {
|
|
||||||
let guard = CostGuard::new(CostGuardConfig {
|
|
||||||
max_cost_per_day_cents: Some(100_000), // $1000 global limit
|
|
||||||
max_actions_per_hour: None,
|
|
||||||
max_cost_per_user_per_day_cents: Some(1), // $0.01 per user
|
|
||||||
});
|
|
||||||
|
|
||||||
// User hits their personal limit
|
|
||||||
guard
|
|
||||||
.record_llm_call_for_user(
|
|
||||||
"alice",
|
|
||||||
"gpt-4o",
|
|
||||||
10_000,
|
|
||||||
10_000,
|
|
||||||
0,
|
|
||||||
0,
|
|
||||||
Decimal::ONE,
|
|
||||||
Decimal::ONE,
|
|
||||||
None,
|
|
||||||
)
|
|
||||||
.await;
|
|
||||||
|
|
||||||
// Alice blocked by per-user limit, not global
|
|
||||||
assert!(guard.check_allowed_for_user("alice").await.is_err());
|
|
||||||
// Global limit is far from reached
|
|
||||||
assert!(guard.check_allowed().await.is_ok());
|
|
||||||
// Bob is unaffected
|
|
||||||
assert!(guard.check_allowed_for_user("bob").await.is_ok());
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_user_cost_limit_display() {
|
|
||||||
let limit = CostLimitExceeded::UserDailyBudget {
|
|
||||||
user_id: "alice".to_string(),
|
|
||||||
spent_cents: 150,
|
|
||||||
limit_cents: 100,
|
|
||||||
};
|
|
||||||
let msg = limit.to_string();
|
|
||||||
assert!(msg.contains("alice"));
|
|
||||||
assert!(msg.contains("$1.50"));
|
|
||||||
assert!(msg.contains("$1.00"));
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
+10
-61
@@ -42,7 +42,6 @@ impl Agent {
|
|||||||
pub(super) async fn run_agentic_loop(
|
pub(super) async fn run_agentic_loop(
|
||||||
&self,
|
&self,
|
||||||
message: &IncomingMessage,
|
message: &IncomingMessage,
|
||||||
tenant: crate::tenant::TenantCtx,
|
|
||||||
session: Arc<Mutex<Session>>,
|
session: Arc<Mutex<Session>>,
|
||||||
thread_id: Uuid,
|
thread_id: Uuid,
|
||||||
initial_messages: Vec<ChatMessage>,
|
initial_messages: Vec<ChatMessage>,
|
||||||
@@ -64,12 +63,7 @@ impl Agent {
|
|||||||
);
|
);
|
||||||
|
|
||||||
let system_prompt = if let Some(ws) = self.workspace() {
|
let system_prompt = if let Some(ws) = self.workspace() {
|
||||||
let scoped_workspace = if ws.user_id() == message.user_id {
|
match ws
|
||||||
Arc::clone(ws)
|
|
||||||
} else {
|
|
||||||
Arc::new(ws.scoped_to_user(&message.user_id))
|
|
||||||
};
|
|
||||||
match scoped_workspace
|
|
||||||
.system_prompt_for_context_tz(is_group_chat, user_tz)
|
.system_prompt_for_context_tz(is_group_chat, user_tz)
|
||||||
.await
|
.await
|
||||||
{
|
{
|
||||||
@@ -169,7 +163,6 @@ impl Agent {
|
|||||||
|
|
||||||
let delegate = ChatDelegate {
|
let delegate = ChatDelegate {
|
||||||
agent: self,
|
agent: self,
|
||||||
tenant,
|
|
||||||
session: session.clone(),
|
session: session.clone(),
|
||||||
thread_id,
|
thread_id,
|
||||||
message,
|
message,
|
||||||
@@ -242,7 +235,6 @@ impl Agent {
|
|||||||
/// auth intercept, and cost tracking.
|
/// auth intercept, and cost tracking.
|
||||||
struct ChatDelegate<'a> {
|
struct ChatDelegate<'a> {
|
||||||
agent: &'a Agent,
|
agent: &'a Agent,
|
||||||
tenant: crate::tenant::TenantCtx,
|
|
||||||
session: Arc<Mutex<Session>>,
|
session: Arc<Mutex<Session>>,
|
||||||
thread_id: Uuid,
|
thread_id: Uuid,
|
||||||
message: &'a IncomingMessage,
|
message: &'a IncomingMessage,
|
||||||
@@ -306,8 +298,6 @@ impl<'a> LoopDelegate for ChatDelegate<'a> {
|
|||||||
|
|
||||||
// Update context for this iteration
|
// Update context for this iteration
|
||||||
reason_ctx.available_tools = tool_defs;
|
reason_ctx.available_tools = tool_defs;
|
||||||
// Preserve force_text if already set (e.g. by truncation escalation).
|
|
||||||
let force_text = force_text || reason_ctx.force_text;
|
|
||||||
reason_ctx.system_prompt = Some(if force_text {
|
reason_ctx.system_prompt = Some(if force_text {
|
||||||
self.cached_prompt_no_tools.clone()
|
self.cached_prompt_no_tools.clone()
|
||||||
} else {
|
} else {
|
||||||
@@ -341,8 +331,8 @@ impl<'a> LoopDelegate for ChatDelegate<'a> {
|
|||||||
reason_ctx: &mut ReasoningContext,
|
reason_ctx: &mut ReasoningContext,
|
||||||
iteration: usize,
|
iteration: usize,
|
||||||
) -> Result<crate::llm::RespondOutput, Error> {
|
) -> Result<crate::llm::RespondOutput, Error> {
|
||||||
// Enforce cost guardrails before the LLM call (global + per-user)
|
// Enforce cost guardrails before the LLM call
|
||||||
if let Err(limit) = self.tenant.check_cost_allowed().await {
|
if let Err(limit) = self.agent.cost_guard().check_allowed().await {
|
||||||
return Err(crate::error::LlmError::InvalidResponse {
|
return Err(crate::error::LlmError::InvalidResponse {
|
||||||
provider: "agent".to_string(),
|
provider: "agent".to_string(),
|
||||||
reason: limit.to_string(),
|
reason: limit.to_string(),
|
||||||
@@ -350,21 +340,6 @@ impl<'a> LoopDelegate for ChatDelegate<'a> {
|
|||||||
.into());
|
.into());
|
||||||
}
|
}
|
||||||
|
|
||||||
// Apply per-user model override from settings (first iteration only
|
|
||||||
// to avoid repeated DB lookups within the same agentic loop).
|
|
||||||
// Uses "selected_model" — the same key the /model command persists to
|
|
||||||
// via SettingsStore (per-user scoped via TenantScope).
|
|
||||||
if iteration == 0
|
|
||||||
&& let Some(store) = self.tenant.store()
|
|
||||||
&& let Ok(Some(value)) = store.get_setting("selected_model").await
|
|
||||||
&& let Some(model) = value.as_str()
|
|
||||||
{
|
|
||||||
let model = model.trim();
|
|
||||||
if !model.is_empty() {
|
|
||||||
reason_ctx.model_override = Some(model.to_string());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let output = match reasoning.respond_with_tools(reason_ctx).await {
|
let output = match reasoning.respond_with_tools(reason_ctx).await {
|
||||||
Ok(output) => output,
|
Ok(output) => output,
|
||||||
Err(crate::error::LlmError::ContextLengthExceeded { used, limit }) => {
|
Err(crate::error::LlmError::ContextLengthExceeded { used, limit }) => {
|
||||||
@@ -399,22 +374,13 @@ impl<'a> LoopDelegate for ChatDelegate<'a> {
|
|||||||
Err(e) => return Err(e.into()),
|
Err(e) => return Err(e.into()),
|
||||||
};
|
};
|
||||||
|
|
||||||
// Record cost and track token usage (global + per-user).
|
// Record cost and track token usage
|
||||||
// When a model override is active, use the override name for attribution
|
let model_name = self.agent.llm().active_model_name();
|
||||||
// and let CostGuard look up pricing via costs::model_cost() instead of
|
|
||||||
// using the default provider's cost_per_token (which reflects the wrong model).
|
|
||||||
let (model_name, cost_per_token) = if let Some(ref ovr) = reason_ctx.model_override {
|
|
||||||
(ovr.clone(), None)
|
|
||||||
} else {
|
|
||||||
(
|
|
||||||
self.agent.llm().active_model_name(),
|
|
||||||
Some(self.agent.llm().cost_per_token()),
|
|
||||||
)
|
|
||||||
};
|
|
||||||
let read_discount = self.agent.llm().cache_read_discount();
|
let read_discount = self.agent.llm().cache_read_discount();
|
||||||
let write_multiplier = self.agent.llm().cache_write_multiplier();
|
let write_multiplier = self.agent.llm().cache_write_multiplier();
|
||||||
let call_cost = self
|
let call_cost = self
|
||||||
.tenant
|
.agent
|
||||||
|
.cost_guard()
|
||||||
.record_llm_call(
|
.record_llm_call(
|
||||||
&model_name,
|
&model_name,
|
||||||
output.usage.input_tokens,
|
output.usage.input_tokens,
|
||||||
@@ -423,7 +389,7 @@ impl<'a> LoopDelegate for ChatDelegate<'a> {
|
|||||||
output.usage.cache_creation_input_tokens,
|
output.usage.cache_creation_input_tokens,
|
||||||
read_discount,
|
read_discount,
|
||||||
write_multiplier,
|
write_multiplier,
|
||||||
cost_per_token,
|
Some(self.agent.llm().cost_per_token()),
|
||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
tracing::debug!(
|
tracing::debug!(
|
||||||
@@ -1334,7 +1300,6 @@ mod tests {
|
|||||||
sandbox_readiness: crate::agent::routine_engine::SandboxReadiness::DisabledByConfig,
|
sandbox_readiness: crate::agent::routine_engine::SandboxReadiness::DisabledByConfig,
|
||||||
builder: None,
|
builder: None,
|
||||||
llm_backend: "nearai".to_string(),
|
llm_backend: "nearai".to_string(),
|
||||||
tenant_rates: Arc::new(crate::tenant::TenantRateRegistry::new(4, 3)),
|
|
||||||
};
|
};
|
||||||
|
|
||||||
Agent::new(
|
Agent::new(
|
||||||
@@ -1350,14 +1315,10 @@ mod tests {
|
|||||||
allow_local_tools: false,
|
allow_local_tools: false,
|
||||||
max_cost_per_day_cents: None,
|
max_cost_per_day_cents: None,
|
||||||
max_actions_per_hour: None,
|
max_actions_per_hour: None,
|
||||||
max_cost_per_user_per_day_cents: None,
|
|
||||||
max_tool_iterations: 50,
|
max_tool_iterations: 50,
|
||||||
auto_approve_tools: false,
|
auto_approve_tools: false,
|
||||||
default_timezone: "UTC".to_string(),
|
default_timezone: "UTC".to_string(),
|
||||||
max_tokens_per_job: 0,
|
max_tokens_per_job: 0,
|
||||||
multi_tenant: false,
|
|
||||||
max_llm_concurrent_per_user: None,
|
|
||||||
max_jobs_concurrent_per_user: None,
|
|
||||||
},
|
},
|
||||||
deps,
|
deps,
|
||||||
Arc::new(ChannelManager::new()),
|
Arc::new(ChannelManager::new()),
|
||||||
@@ -2215,7 +2176,6 @@ mod tests {
|
|||||||
sandbox_readiness: crate::agent::routine_engine::SandboxReadiness::DisabledByConfig,
|
sandbox_readiness: crate::agent::routine_engine::SandboxReadiness::DisabledByConfig,
|
||||||
builder: None,
|
builder: None,
|
||||||
llm_backend: "nearai".to_string(),
|
llm_backend: "nearai".to_string(),
|
||||||
tenant_rates: Arc::new(crate::tenant::TenantRateRegistry::new(4, 3)),
|
|
||||||
};
|
};
|
||||||
|
|
||||||
Agent::new(
|
Agent::new(
|
||||||
@@ -2231,14 +2191,10 @@ mod tests {
|
|||||||
allow_local_tools: false,
|
allow_local_tools: false,
|
||||||
max_cost_per_day_cents: None,
|
max_cost_per_day_cents: None,
|
||||||
max_actions_per_hour: None,
|
max_actions_per_hour: None,
|
||||||
max_cost_per_user_per_day_cents: None,
|
|
||||||
max_tool_iterations,
|
max_tool_iterations,
|
||||||
auto_approve_tools: true,
|
auto_approve_tools: true,
|
||||||
default_timezone: "UTC".to_string(),
|
default_timezone: "UTC".to_string(),
|
||||||
max_tokens_per_job: 0,
|
max_tokens_per_job: 0,
|
||||||
multi_tenant: false,
|
|
||||||
max_llm_concurrent_per_user: None,
|
|
||||||
max_jobs_concurrent_per_user: None,
|
|
||||||
},
|
},
|
||||||
deps,
|
deps,
|
||||||
Arc::new(ChannelManager::new()),
|
Arc::new(ChannelManager::new()),
|
||||||
@@ -2273,14 +2229,13 @@ mod tests {
|
|||||||
|
|
||||||
let message = IncomingMessage::new("test", "test-user", "do something");
|
let message = IncomingMessage::new("test", "test-user", "do something");
|
||||||
let initial_messages = vec![ChatMessage::user("do something")];
|
let initial_messages = vec![ChatMessage::user("do something")];
|
||||||
let tenant = agent.tenant_ctx("test-user").await;
|
|
||||||
|
|
||||||
// The dispatcher must terminate within 5 seconds. If there is an
|
// The dispatcher must terminate within 5 seconds. If there is an
|
||||||
// infinite loop bug (e.g., index not advancing on tool failure), the
|
// infinite loop bug (e.g., index not advancing on tool failure), the
|
||||||
// timeout will fire and the test will fail.
|
// timeout will fire and the test will fail.
|
||||||
let result = tokio::time::timeout(
|
let result = tokio::time::timeout(
|
||||||
Duration::from_secs(5),
|
Duration::from_secs(5),
|
||||||
agent.run_agentic_loop(&message, tenant, session, thread_id, initial_messages),
|
agent.run_agentic_loop(&message, session, thread_id, initial_messages),
|
||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
@@ -2342,7 +2297,6 @@ mod tests {
|
|||||||
sandbox_readiness: crate::agent::routine_engine::SandboxReadiness::DisabledByConfig,
|
sandbox_readiness: crate::agent::routine_engine::SandboxReadiness::DisabledByConfig,
|
||||||
builder: None,
|
builder: None,
|
||||||
llm_backend: "nearai".to_string(),
|
llm_backend: "nearai".to_string(),
|
||||||
tenant_rates: Arc::new(crate::tenant::TenantRateRegistry::new(4, 3)),
|
|
||||||
};
|
};
|
||||||
|
|
||||||
Agent::new(
|
Agent::new(
|
||||||
@@ -2358,14 +2312,10 @@ mod tests {
|
|||||||
allow_local_tools: false,
|
allow_local_tools: false,
|
||||||
max_cost_per_day_cents: None,
|
max_cost_per_day_cents: None,
|
||||||
max_actions_per_hour: None,
|
max_actions_per_hour: None,
|
||||||
max_cost_per_user_per_day_cents: None,
|
|
||||||
max_tool_iterations: max_iter,
|
max_tool_iterations: max_iter,
|
||||||
auto_approve_tools: true,
|
auto_approve_tools: true,
|
||||||
default_timezone: "UTC".to_string(),
|
default_timezone: "UTC".to_string(),
|
||||||
max_tokens_per_job: 0,
|
max_tokens_per_job: 0,
|
||||||
multi_tenant: false,
|
|
||||||
max_llm_concurrent_per_user: None,
|
|
||||||
max_jobs_concurrent_per_user: None,
|
|
||||||
},
|
},
|
||||||
deps,
|
deps,
|
||||||
Arc::new(ChannelManager::new()),
|
Arc::new(ChannelManager::new()),
|
||||||
@@ -2385,14 +2335,13 @@ mod tests {
|
|||||||
|
|
||||||
let message = IncomingMessage::new("test", "test-user", "keep calling tools");
|
let message = IncomingMessage::new("test", "test-user", "keep calling tools");
|
||||||
let initial_messages = vec![ChatMessage::user("keep calling tools")];
|
let initial_messages = vec![ChatMessage::user("keep calling tools")];
|
||||||
let tenant = agent.tenant_ctx("test-user").await;
|
|
||||||
|
|
||||||
// Even with an LLM that always wants to call tools, the dispatcher
|
// Even with an LLM that always wants to call tools, the dispatcher
|
||||||
// must terminate within the timeout thanks to force_text at
|
// must terminate within the timeout thanks to force_text at
|
||||||
// max_tool_iterations.
|
// max_tool_iterations.
|
||||||
let result = tokio::time::timeout(
|
let result = tokio::time::timeout(
|
||||||
Duration::from_secs(5),
|
Duration::from_secs(5),
|
||||||
agent.run_agentic_loop(&message, tenant, session, thread_id, initial_messages),
|
agent.run_agentic_loop(&message, session, thread_id, initial_messages),
|
||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
|
|||||||
+7
-184
@@ -31,8 +31,8 @@ use chrono_tz::Tz;
|
|||||||
use tokio::sync::mpsc;
|
use tokio::sync::mpsc;
|
||||||
|
|
||||||
use crate::channels::OutgoingResponse;
|
use crate::channels::OutgoingResponse;
|
||||||
|
use crate::db::Database;
|
||||||
use crate::llm::{ChatMessage, CompletionRequest, LlmProvider, Reasoning};
|
use crate::llm::{ChatMessage, CompletionRequest, LlmProvider, Reasoning};
|
||||||
use crate::tenant::AdminScope;
|
|
||||||
use crate::workspace::Workspace;
|
use crate::workspace::Workspace;
|
||||||
use crate::workspace::hygiene::HygieneConfig;
|
use crate::workspace::hygiene::HygieneConfig;
|
||||||
|
|
||||||
@@ -57,9 +57,6 @@ pub struct HeartbeatConfig {
|
|||||||
pub quiet_hours_end: Option<u32>,
|
pub quiet_hours_end: Option<u32>,
|
||||||
/// Timezone for fire_at and quiet hours evaluation (IANA name).
|
/// Timezone for fire_at and quiet hours evaluation (IANA name).
|
||||||
pub timezone: Option<String>,
|
pub timezone: Option<String>,
|
||||||
/// When true, cycle through all users with routines instead of
|
|
||||||
/// running heartbeat for a single user. Requires a database store.
|
|
||||||
pub multi_tenant: bool,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Default for HeartbeatConfig {
|
impl Default for HeartbeatConfig {
|
||||||
@@ -74,7 +71,6 @@ impl Default for HeartbeatConfig {
|
|||||||
quiet_hours_start: None,
|
quiet_hours_start: None,
|
||||||
quiet_hours_end: None,
|
quiet_hours_end: None,
|
||||||
timezone: None,
|
timezone: None,
|
||||||
multi_tenant: false,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -182,7 +178,7 @@ pub struct HeartbeatRunner {
|
|||||||
workspace: Arc<Workspace>,
|
workspace: Arc<Workspace>,
|
||||||
llm: Arc<dyn LlmProvider>,
|
llm: Arc<dyn LlmProvider>,
|
||||||
response_tx: Option<mpsc::Sender<OutgoingResponse>>,
|
response_tx: Option<mpsc::Sender<OutgoingResponse>>,
|
||||||
store: Option<AdminScope>,
|
store: Option<Arc<dyn Database>>,
|
||||||
consecutive_failures: u32,
|
consecutive_failures: u32,
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -211,8 +207,8 @@ impl HeartbeatRunner {
|
|||||||
self
|
self
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Set the admin-scoped database store for persistent heartbeat conversations.
|
/// Set the database store for persistent heartbeat conversations.
|
||||||
pub fn with_store(mut self, store: AdminScope) -> Self {
|
pub fn with_store(mut self, store: Arc<dyn Database>) -> Self {
|
||||||
self.store = Some(store);
|
self.store = Some(store);
|
||||||
self
|
self
|
||||||
}
|
}
|
||||||
@@ -400,7 +396,7 @@ impl HeartbeatRunner {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Send a notification about heartbeat findings.
|
/// Send a notification about heartbeat findings.
|
||||||
pub(crate) async fn send_notification(&self, message: &str) {
|
async fn send_notification(&self, message: &str) {
|
||||||
let Some(ref tx) = self.response_tx else {
|
let Some(ref tx) = self.response_tx else {
|
||||||
tracing::debug!("No response channel configured for heartbeat notifications");
|
tracing::debug!("No response channel configured for heartbeat notifications");
|
||||||
return;
|
return;
|
||||||
@@ -497,7 +493,7 @@ pub fn spawn_heartbeat(
|
|||||||
workspace: Arc<Workspace>,
|
workspace: Arc<Workspace>,
|
||||||
llm: Arc<dyn LlmProvider>,
|
llm: Arc<dyn LlmProvider>,
|
||||||
response_tx: Option<mpsc::Sender<OutgoingResponse>>,
|
response_tx: Option<mpsc::Sender<OutgoingResponse>>,
|
||||||
store: Option<AdminScope>,
|
store: Option<Arc<dyn Database>>,
|
||||||
) -> tokio::task::JoinHandle<()> {
|
) -> tokio::task::JoinHandle<()> {
|
||||||
let mut runner = HeartbeatRunner::new(config, hygiene_config, workspace, llm);
|
let mut runner = HeartbeatRunner::new(config, hygiene_config, workspace, llm);
|
||||||
if let Some(tx) = response_tx {
|
if let Some(tx) = response_tx {
|
||||||
@@ -512,179 +508,6 @@ pub fn spawn_heartbeat(
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Spawn a multi-user heartbeat runner that cycles through all users that
|
|
||||||
/// own routines (enabled or not). Each tick, it queries the DB for distinct
|
|
||||||
/// user_ids, creates a per-user workspace, and runs a heartbeat check for
|
|
||||||
/// each user concurrently. Per-user failure counts are tracked independently.
|
|
||||||
pub fn spawn_multi_user_heartbeat(
|
|
||||||
config: HeartbeatConfig,
|
|
||||||
hygiene_config: HygieneConfig,
|
|
||||||
llm: Arc<dyn LlmProvider>,
|
|
||||||
response_tx: Option<mpsc::Sender<OutgoingResponse>>,
|
|
||||||
store: AdminScope,
|
|
||||||
) -> tokio::task::JoinHandle<()> {
|
|
||||||
tokio::spawn(async move {
|
|
||||||
if !config.enabled {
|
|
||||||
tracing::info!("Multi-user heartbeat is disabled");
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut tick_interval = if config.fire_at.is_none() {
|
|
||||||
let mut iv = tokio::time::interval(config.interval);
|
|
||||||
iv.tick().await; // skip immediate tick
|
|
||||||
Some(iv)
|
|
||||||
} else {
|
|
||||||
None
|
|
||||||
};
|
|
||||||
|
|
||||||
// Track consecutive failures per user so we can disable heartbeat
|
|
||||||
// for persistently-failing users (same semantics as single-user mode).
|
|
||||||
let mut user_failures: std::collections::HashMap<String, u32> =
|
|
||||||
std::collections::HashMap::new();
|
|
||||||
|
|
||||||
tracing::info!("Starting multi-user heartbeat loop");
|
|
||||||
|
|
||||||
loop {
|
|
||||||
if let Some(fire_at) = config.fire_at {
|
|
||||||
let sleep_dur = duration_until_next_fire(fire_at, config.resolved_tz());
|
|
||||||
tokio::time::sleep(sleep_dur).await;
|
|
||||||
} else if let Some(ref mut iv) = tick_interval {
|
|
||||||
iv.tick().await;
|
|
||||||
}
|
|
||||||
|
|
||||||
if config.is_quiet_hours() {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Get distinct user_ids from routines
|
|
||||||
let user_ids = match store.list_all_routines().await {
|
|
||||||
Ok(routines) => {
|
|
||||||
let mut ids: Vec<String> = routines
|
|
||||||
.iter()
|
|
||||||
.map(|r| r.user_id.clone())
|
|
||||||
.collect::<std::collections::HashSet<_>>()
|
|
||||||
.into_iter()
|
|
||||||
.collect();
|
|
||||||
ids.sort();
|
|
||||||
ids
|
|
||||||
}
|
|
||||||
Err(e) => {
|
|
||||||
tracing::error!("Multi-user heartbeat: failed to list routines: {}", e);
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
};
|
|
||||||
|
|
||||||
// Run user heartbeats concurrently so one slow LLM call doesn't
|
|
||||||
// block others. Cap concurrency to avoid flooding the LLM provider.
|
|
||||||
const MAX_CONCURRENT_HEARTBEATS: usize = 8;
|
|
||||||
let mut join_set = tokio::task::JoinSet::new();
|
|
||||||
|
|
||||||
for user_id in &user_ids {
|
|
||||||
// Skip users that have exceeded max_failures
|
|
||||||
let failures = user_failures.get(user_id).copied().unwrap_or(0);
|
|
||||||
if failures >= config.max_failures {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
let workspace = Arc::new(Workspace::new_with_db(user_id, Arc::clone(store.db())));
|
|
||||||
|
|
||||||
// Run memory hygiene per user (same as single-user heartbeat).
|
|
||||||
let hygiene_ws = Arc::clone(&workspace);
|
|
||||||
let hygiene_cfg = hygiene_config.clone();
|
|
||||||
let hygiene_user = user_id.clone();
|
|
||||||
tokio::spawn(async move {
|
|
||||||
let report =
|
|
||||||
crate::workspace::hygiene::run_if_due(&hygiene_ws, &hygiene_cfg).await;
|
|
||||||
if report.had_work() {
|
|
||||||
tracing::info!(
|
|
||||||
user_id = hygiene_user,
|
|
||||||
daily_logs_deleted = report.daily_logs_deleted,
|
|
||||||
conversation_docs_deleted = report.conversation_docs_deleted,
|
|
||||||
"multi-user heartbeat: memory hygiene deleted stale documents"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
// Drain completed tasks to stay within the concurrency cap.
|
|
||||||
while join_set.len() >= MAX_CONCURRENT_HEARTBEATS {
|
|
||||||
if let Some(join_result) = join_set.join_next().await {
|
|
||||||
collect_heartbeat_result(join_result, &mut user_failures, &config);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let uid = user_id.clone();
|
|
||||||
let cfg = config.clone();
|
|
||||||
let hyg = hygiene_config.clone();
|
|
||||||
let llm_clone = llm.clone();
|
|
||||||
let tx = response_tx.clone();
|
|
||||||
let admin = store.clone();
|
|
||||||
|
|
||||||
join_set.spawn(async move {
|
|
||||||
let mut runner = HeartbeatRunner::new(cfg, hyg, workspace, llm_clone);
|
|
||||||
if let Some(tx) = tx {
|
|
||||||
runner = runner.with_response_channel(tx);
|
|
||||||
}
|
|
||||||
runner = runner.with_store(admin);
|
|
||||||
|
|
||||||
let result = runner.check_heartbeat().await;
|
|
||||||
if let HeartbeatResult::NeedsAttention(msg) = &result {
|
|
||||||
runner.send_notification(msg).await;
|
|
||||||
}
|
|
||||||
(uid, result)
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
// Collect remaining results and update failure counts
|
|
||||||
while let Some(join_result) = join_set.join_next().await {
|
|
||||||
collect_heartbeat_result(join_result, &mut user_failures, &config);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Process a single JoinSet result from the multi-user heartbeat loop.
|
|
||||||
fn collect_heartbeat_result(
|
|
||||||
join_result: Result<(String, HeartbeatResult), tokio::task::JoinError>,
|
|
||||||
user_failures: &mut std::collections::HashMap<String, u32>,
|
|
||||||
config: &HeartbeatConfig,
|
|
||||||
) {
|
|
||||||
let (uid, result) = match join_result {
|
|
||||||
Ok(pair) => pair,
|
|
||||||
Err(e) => {
|
|
||||||
tracing::error!("Multi-user heartbeat task panicked: {}", e);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
};
|
|
||||||
match result {
|
|
||||||
HeartbeatResult::Ok => {
|
|
||||||
tracing::trace!(user_id = uid, "Multi-user heartbeat OK");
|
|
||||||
user_failures.remove(&uid);
|
|
||||||
}
|
|
||||||
HeartbeatResult::NeedsAttention(_) => {
|
|
||||||
tracing::info!(user_id = uid, "Multi-user heartbeat needs attention");
|
|
||||||
user_failures.remove(&uid);
|
|
||||||
}
|
|
||||||
HeartbeatResult::Skipped => {}
|
|
||||||
HeartbeatResult::Failed(err) => {
|
|
||||||
let count = user_failures.entry(uid.clone()).or_insert(0);
|
|
||||||
*count += 1;
|
|
||||||
tracing::error!(
|
|
||||||
user_id = uid,
|
|
||||||
consecutive_failures = *count,
|
|
||||||
"Multi-user heartbeat failed: {}",
|
|
||||||
err
|
|
||||||
);
|
|
||||||
if *count >= config.max_failures {
|
|
||||||
tracing::error!(
|
|
||||||
user_id = uid,
|
|
||||||
"Multi-user heartbeat disabled for user after {} consecutive failures",
|
|
||||||
count
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::*;
|
use super::*;
|
||||||
@@ -903,7 +726,7 @@ mod tests {
|
|||||||
Arc<crate::workspace::Workspace>,
|
Arc<crate::workspace::Workspace>,
|
||||||
Arc<dyn crate::llm::LlmProvider>,
|
Arc<dyn crate::llm::LlmProvider>,
|
||||||
Option<tokio::sync::mpsc::Sender<crate::channels::OutgoingResponse>>,
|
Option<tokio::sync::mpsc::Sender<crate::channels::OutgoingResponse>>,
|
||||||
Option<AdminScope>,
|
Option<Arc<dyn crate::db::Database>>,
|
||||||
) -> tokio::task::JoinHandle<()> = spawn_heartbeat;
|
) -> tokio::task::JoinHandle<()> = spawn_heartbeat;
|
||||||
let _ = _fn_ptr;
|
let _ = _fn_ptr;
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-3
@@ -36,9 +36,7 @@ pub(crate) use agent_loop::truncate_for_preview;
|
|||||||
pub use agent_loop::{Agent, AgentDeps};
|
pub use agent_loop::{Agent, AgentDeps};
|
||||||
pub use compaction::{CompactionResult, ContextCompactor};
|
pub use compaction::{CompactionResult, ContextCompactor};
|
||||||
pub use context_monitor::{CompactionStrategy, ContextBreakdown, ContextMonitor};
|
pub use context_monitor::{CompactionStrategy, ContextBreakdown, ContextMonitor};
|
||||||
pub use heartbeat::{
|
pub use heartbeat::{HeartbeatConfig, HeartbeatResult, HeartbeatRunner, spawn_heartbeat};
|
||||||
HeartbeatConfig, HeartbeatResult, HeartbeatRunner, spawn_heartbeat, spawn_multi_user_heartbeat,
|
|
||||||
};
|
|
||||||
pub use router::{MessageIntent, Router};
|
pub use router::{MessageIntent, Router};
|
||||||
pub use routine::{Routine, RoutineAction, RoutineRun, Trigger};
|
pub use routine::{Routine, RoutineAction, RoutineRun, Trigger};
|
||||||
pub use routine_engine::{RoutineEngine, SandboxReadiness};
|
pub use routine_engine::{RoutineEngine, SandboxReadiness};
|
||||||
|
|||||||
+18
-90
@@ -18,7 +18,6 @@ use std::time::Duration;
|
|||||||
use chrono::Utc;
|
use chrono::Utc;
|
||||||
use regex::Regex;
|
use regex::Regex;
|
||||||
use tokio::sync::{RwLock, mpsc};
|
use tokio::sync::{RwLock, mpsc};
|
||||||
use tokio::task::JoinHandle;
|
|
||||||
use uuid::Uuid;
|
use uuid::Uuid;
|
||||||
|
|
||||||
use crate::agent::Scheduler;
|
use crate::agent::Scheduler;
|
||||||
@@ -28,12 +27,12 @@ use crate::agent::routine::{
|
|||||||
use crate::channels::{IncomingMessage, OutgoingResponse};
|
use crate::channels::{IncomingMessage, OutgoingResponse};
|
||||||
use crate::config::RoutineConfig;
|
use crate::config::RoutineConfig;
|
||||||
use crate::context::{JobContext, JobState};
|
use crate::context::{JobContext, JobState};
|
||||||
|
use crate::db::Database;
|
||||||
use crate::error::RoutineError;
|
use crate::error::RoutineError;
|
||||||
use crate::extensions::ExtensionManager;
|
use crate::extensions::ExtensionManager;
|
||||||
use crate::llm::{
|
use crate::llm::{
|
||||||
ChatMessage, CompletionRequest, FinishReason, LlmProvider, ToolCall, ToolCompletionRequest,
|
ChatMessage, CompletionRequest, FinishReason, LlmProvider, ToolCall, ToolCompletionRequest,
|
||||||
};
|
};
|
||||||
use crate::tenant::AdminScope;
|
|
||||||
use crate::tools::{
|
use crate::tools::{
|
||||||
ToolError, ToolRegistry, autonomous_allowed_tool_names, autonomous_unavailable_message,
|
ToolError, ToolRegistry, autonomous_allowed_tool_names, autonomous_unavailable_message,
|
||||||
prepare_tool_params,
|
prepare_tool_params,
|
||||||
@@ -46,11 +45,6 @@ enum EventMatcher {
|
|||||||
System { routine: Routine },
|
System { routine: Routine },
|
||||||
}
|
}
|
||||||
|
|
||||||
struct TriggeredRoutine {
|
|
||||||
routine: Routine,
|
|
||||||
detail: String,
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Distinguishes why sandbox is unavailable so error messages are accurate.
|
/// Distinguishes why sandbox is unavailable so error messages are accurate.
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
pub enum SandboxReadiness {
|
pub enum SandboxReadiness {
|
||||||
@@ -99,7 +93,7 @@ pub(crate) fn routine_matches_message(routine: &Routine, message: &IncomingMessa
|
|||||||
/// The routine execution engine.
|
/// The routine execution engine.
|
||||||
pub struct RoutineEngine {
|
pub struct RoutineEngine {
|
||||||
config: RoutineConfig,
|
config: RoutineConfig,
|
||||||
store: AdminScope,
|
store: Arc<dyn Database>,
|
||||||
llm: Arc<dyn LlmProvider>,
|
llm: Arc<dyn LlmProvider>,
|
||||||
workspace: Arc<Workspace>,
|
workspace: Arc<Workspace>,
|
||||||
/// Sender for notifications (routed to channel manager).
|
/// Sender for notifications (routed to channel manager).
|
||||||
@@ -128,7 +122,7 @@ impl RoutineEngine {
|
|||||||
#[allow(clippy::too_many_arguments)]
|
#[allow(clippy::too_many_arguments)]
|
||||||
pub fn new(
|
pub fn new(
|
||||||
config: RoutineConfig,
|
config: RoutineConfig,
|
||||||
store: AdminScope,
|
store: Arc<dyn Database>,
|
||||||
llm: Arc<dyn LlmProvider>,
|
llm: Arc<dyn LlmProvider>,
|
||||||
workspace: Arc<Workspace>,
|
workspace: Arc<Workspace>,
|
||||||
notify_tx: mpsc::Sender<OutgoingResponse>,
|
notify_tx: mpsc::Sender<OutgoingResponse>,
|
||||||
@@ -208,44 +202,6 @@ impl RoutineEngine {
|
|||||||
|
|
||||||
/// Check incoming message against event triggers. Returns number of routines fired.
|
/// Check incoming message against event triggers. Returns number of routines fired.
|
||||||
pub async fn check_event_triggers(&self, message: &IncomingMessage, content: &str) -> usize {
|
pub async fn check_event_triggers(&self, message: &IncomingMessage, content: &str) -> usize {
|
||||||
let triggered = self.matching_event_triggers(message, content).await;
|
|
||||||
let fired = triggered.len();
|
|
||||||
for triggered in triggered {
|
|
||||||
std::mem::drop(self.spawn_fire(triggered.routine, "event", Some(triggered.detail)));
|
|
||||||
}
|
|
||||||
fired
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Fire matching event-triggered routines and wait for them to complete.
|
|
||||||
///
|
|
||||||
/// Used by single-message REPL mode so the process does not exit before
|
|
||||||
/// background event-triggered routines finish.
|
|
||||||
pub async fn check_event_triggers_and_wait(
|
|
||||||
&self,
|
|
||||||
message: &IncomingMessage,
|
|
||||||
content: &str,
|
|
||||||
) -> usize {
|
|
||||||
let triggered = self.matching_event_triggers(message, content).await;
|
|
||||||
let fired = triggered.len();
|
|
||||||
let handles: Vec<JoinHandle<()>> = triggered
|
|
||||||
.into_iter()
|
|
||||||
.map(|triggered| self.spawn_fire(triggered.routine, "event", Some(triggered.detail)))
|
|
||||||
.collect();
|
|
||||||
|
|
||||||
for handle in handles {
|
|
||||||
if let Err(e) = handle.await {
|
|
||||||
tracing::warn!(error = %e, "Event-triggered routine task failed");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fired
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn matching_event_triggers(
|
|
||||||
&self,
|
|
||||||
message: &IncomingMessage,
|
|
||||||
content: &str,
|
|
||||||
) -> Vec<TriggeredRoutine> {
|
|
||||||
let cache = self.event_cache.read().await;
|
let cache = self.event_cache.read().await;
|
||||||
|
|
||||||
// Early return if there are no message matchers at all.
|
// Early return if there are no message matchers at all.
|
||||||
@@ -253,9 +209,10 @@ impl RoutineEngine {
|
|||||||
.iter()
|
.iter()
|
||||||
.any(|m| matches!(m, EventMatcher::Message { .. }))
|
.any(|m| matches!(m, EventMatcher::Message { .. }))
|
||||||
{
|
{
|
||||||
return Vec::new();
|
return 0;
|
||||||
}
|
}
|
||||||
let mut triggered = Vec::new();
|
|
||||||
|
let mut fired = 0;
|
||||||
|
|
||||||
// Collect routine IDs for batch query
|
// Collect routine IDs for batch query
|
||||||
let routine_ids: Vec<Uuid> = cache
|
let routine_ids: Vec<Uuid> = cache
|
||||||
@@ -267,13 +224,13 @@ impl RoutineEngine {
|
|||||||
.collect();
|
.collect();
|
||||||
|
|
||||||
if routine_ids.is_empty() {
|
if routine_ids.is_empty() {
|
||||||
return Vec::new();
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Single batch query instead of N queries
|
// Single batch query instead of N queries
|
||||||
let concurrent_counts = match self.batch_concurrent_counts(&routine_ids).await {
|
let concurrent_counts = match self.batch_concurrent_counts(&routine_ids).await {
|
||||||
Some(counts) => counts,
|
Some(counts) => counts,
|
||||||
None => return Vec::new(),
|
None => return 0,
|
||||||
};
|
};
|
||||||
|
|
||||||
for matcher in cache.iter() {
|
for matcher in cache.iter() {
|
||||||
@@ -328,13 +285,11 @@ impl RoutineEngine {
|
|||||||
}
|
}
|
||||||
|
|
||||||
let detail = truncate(content, 200);
|
let detail = truncate(content, 200);
|
||||||
triggered.push(TriggeredRoutine {
|
self.spawn_fire(routine.clone(), "event", Some(detail));
|
||||||
routine: routine.clone(),
|
fired += 1;
|
||||||
detail,
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
|
|
||||||
triggered
|
fired
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Emit a structured event to system-event routines.
|
/// Emit a structured event to system-event routines.
|
||||||
@@ -782,22 +737,12 @@ impl RoutineEngine {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
// Per-user workspace (same pattern as spawn_fire).
|
|
||||||
let routine_workspace = if routine.user_id == self.workspace.user_id() {
|
|
||||||
self.workspace.clone()
|
|
||||||
} else {
|
|
||||||
Arc::new(Workspace::new_with_db(
|
|
||||||
&routine.user_id,
|
|
||||||
Arc::clone(self.store.db()),
|
|
||||||
))
|
|
||||||
};
|
|
||||||
|
|
||||||
// Execute inline for manual triggers (caller wants to wait)
|
// Execute inline for manual triggers (caller wants to wait)
|
||||||
let engine = EngineContext {
|
let engine = EngineContext {
|
||||||
config: self.config.clone(),
|
config: self.config.clone(),
|
||||||
store: self.store.clone(),
|
store: self.store.clone(),
|
||||||
llm: self.llm.clone(),
|
llm: self.llm.clone(),
|
||||||
workspace: routine_workspace,
|
workspace: self.workspace.clone(),
|
||||||
notify_tx: self.notify_tx.clone(),
|
notify_tx: self.notify_tx.clone(),
|
||||||
running_count: self.running_count.clone(),
|
running_count: self.running_count.clone(),
|
||||||
scheduler: self.scheduler.clone(),
|
scheduler: self.scheduler.clone(),
|
||||||
@@ -900,12 +845,7 @@ impl RoutineEngine {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Spawn a fire in a background task.
|
/// Spawn a fire in a background task.
|
||||||
fn spawn_fire(
|
fn spawn_fire(&self, routine: Routine, trigger_type: &str, trigger_detail: Option<String>) {
|
||||||
&self,
|
|
||||||
routine: Routine,
|
|
||||||
trigger_type: &str,
|
|
||||||
trigger_detail: Option<String>,
|
|
||||||
) -> JoinHandle<()> {
|
|
||||||
let run = RoutineRun {
|
let run = RoutineRun {
|
||||||
id: Uuid::new_v4(),
|
id: Uuid::new_v4(),
|
||||||
routine_id: routine.id,
|
routine_id: routine.id,
|
||||||
@@ -920,23 +860,11 @@ impl RoutineEngine {
|
|||||||
created_at: Utc::now(),
|
created_at: Utc::now(),
|
||||||
};
|
};
|
||||||
|
|
||||||
// Use per-user workspace so each routine executes in the correct
|
|
||||||
// user's context. Fall back to the engine-wide workspace when the
|
|
||||||
// routine belongs to the same user (avoids unnecessary allocation).
|
|
||||||
let routine_workspace = if routine.user_id == self.workspace.user_id() {
|
|
||||||
self.workspace.clone()
|
|
||||||
} else {
|
|
||||||
Arc::new(Workspace::new_with_db(
|
|
||||||
&routine.user_id,
|
|
||||||
Arc::clone(self.store.db()),
|
|
||||||
))
|
|
||||||
};
|
|
||||||
|
|
||||||
let engine = EngineContext {
|
let engine = EngineContext {
|
||||||
config: self.config.clone(),
|
config: self.config.clone(),
|
||||||
store: self.store.clone(),
|
store: self.store.clone(),
|
||||||
llm: self.llm.clone(),
|
llm: self.llm.clone(),
|
||||||
workspace: routine_workspace,
|
workspace: self.workspace.clone(),
|
||||||
notify_tx: self.notify_tx.clone(),
|
notify_tx: self.notify_tx.clone(),
|
||||||
running_count: self.running_count.clone(),
|
running_count: self.running_count.clone(),
|
||||||
scheduler: self.scheduler.clone(),
|
scheduler: self.scheduler.clone(),
|
||||||
@@ -954,7 +882,7 @@ impl RoutineEngine {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
execute_routine(engine, routine, run).await;
|
execute_routine(engine, routine, run).await;
|
||||||
})
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
fn check_cooldown(&self, routine: &Routine) -> bool {
|
fn check_cooldown(&self, routine: &Routine) -> bool {
|
||||||
@@ -989,7 +917,7 @@ impl RoutineEngine {
|
|||||||
/// an active state (Pending/InProgress/Stuck). Maps the final `JobState` to
|
/// an active state (Pending/InProgress/Stuck). Maps the final `JobState` to
|
||||||
/// a `RunStatus` for the routine run.
|
/// a `RunStatus` for the routine run.
|
||||||
struct FullJobWatcher {
|
struct FullJobWatcher {
|
||||||
store: AdminScope,
|
store: Arc<dyn Database>,
|
||||||
job_id: Uuid,
|
job_id: Uuid,
|
||||||
routine_name: String,
|
routine_name: String,
|
||||||
}
|
}
|
||||||
@@ -1000,7 +928,7 @@ impl FullJobWatcher {
|
|||||||
/// Safety ceiling: 24 hours, derived from POLL_INTERVAL.
|
/// Safety ceiling: 24 hours, derived from POLL_INTERVAL.
|
||||||
const MAX_POLLS: u32 = (24 * 60 * 60) / Self::POLL_INTERVAL.as_secs() as u32;
|
const MAX_POLLS: u32 = (24 * 60 * 60) / Self::POLL_INTERVAL.as_secs() as u32;
|
||||||
|
|
||||||
fn new(store: AdminScope, job_id: Uuid, routine_name: String) -> Self {
|
fn new(store: Arc<dyn Database>, job_id: Uuid, routine_name: String) -> Self {
|
||||||
Self {
|
Self {
|
||||||
store,
|
store,
|
||||||
job_id,
|
job_id,
|
||||||
@@ -1072,7 +1000,7 @@ impl FullJobWatcher {
|
|||||||
/// Shared context passed to the execution function.
|
/// Shared context passed to the execution function.
|
||||||
struct EngineContext {
|
struct EngineContext {
|
||||||
config: RoutineConfig,
|
config: RoutineConfig,
|
||||||
store: AdminScope,
|
store: Arc<dyn Database>,
|
||||||
llm: Arc<dyn LlmProvider>,
|
llm: Arc<dyn LlmProvider>,
|
||||||
workspace: Arc<Workspace>,
|
workspace: Arc<Workspace>,
|
||||||
notify_tx: mpsc::Sender<OutgoingResponse>,
|
notify_tx: mpsc::Sender<OutgoingResponse>,
|
||||||
|
|||||||
@@ -11,12 +11,12 @@ use uuid::Uuid;
|
|||||||
use crate::agent::task::{Task, TaskContext, TaskOutput};
|
use crate::agent::task::{Task, TaskContext, TaskOutput};
|
||||||
use crate::config::AgentConfig;
|
use crate::config::AgentConfig;
|
||||||
use crate::context::{ContextManager, JobContext, JobState};
|
use crate::context::{ContextManager, JobContext, JobState};
|
||||||
|
use crate::db::Database;
|
||||||
use crate::error::{Error, JobError};
|
use crate::error::{Error, JobError};
|
||||||
use crate::extensions::ExtensionManager;
|
use crate::extensions::ExtensionManager;
|
||||||
use crate::hooks::HookRegistry;
|
use crate::hooks::HookRegistry;
|
||||||
use crate::llm::LlmProvider;
|
use crate::llm::LlmProvider;
|
||||||
use crate::safety::SafetyLayer;
|
use crate::safety::SafetyLayer;
|
||||||
use crate::tenant::AdminScope;
|
|
||||||
use crate::tools::{
|
use crate::tools::{
|
||||||
ApprovalContext, ToolRegistry, autonomous_allowed_tool_names, autonomous_unavailable_error,
|
ApprovalContext, ToolRegistry, autonomous_allowed_tool_names, autonomous_unavailable_error,
|
||||||
prepare_tool_params,
|
prepare_tool_params,
|
||||||
@@ -52,7 +52,7 @@ struct ScheduledSubtask {
|
|||||||
pub struct SchedulerDeps {
|
pub struct SchedulerDeps {
|
||||||
pub tools: Arc<ToolRegistry>,
|
pub tools: Arc<ToolRegistry>,
|
||||||
pub extension_manager: Option<Arc<ExtensionManager>>,
|
pub extension_manager: Option<Arc<ExtensionManager>>,
|
||||||
pub store: Option<AdminScope>,
|
pub store: Option<Arc<dyn Database>>,
|
||||||
pub hooks: Arc<HookRegistry>,
|
pub hooks: Arc<HookRegistry>,
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -64,7 +64,7 @@ pub struct Scheduler {
|
|||||||
safety: Arc<SafetyLayer>,
|
safety: Arc<SafetyLayer>,
|
||||||
tools: Arc<ToolRegistry>,
|
tools: Arc<ToolRegistry>,
|
||||||
extension_manager: Option<Arc<ExtensionManager>>,
|
extension_manager: Option<Arc<ExtensionManager>>,
|
||||||
store: Option<AdminScope>,
|
store: Option<Arc<dyn Database>>,
|
||||||
hooks: Arc<HookRegistry>,
|
hooks: Arc<HookRegistry>,
|
||||||
/// SSE manager for live job event streaming.
|
/// SSE manager for live job event streaming.
|
||||||
sse_tx: Option<Arc<crate::channels::web::sse::SseManager>>,
|
sse_tx: Option<Arc<crate::channels::web::sse::SseManager>>,
|
||||||
@@ -780,14 +780,10 @@ mod tests {
|
|||||||
allow_local_tools: true,
|
allow_local_tools: true,
|
||||||
max_cost_per_day_cents: None,
|
max_cost_per_day_cents: None,
|
||||||
max_actions_per_hour: None,
|
max_actions_per_hour: None,
|
||||||
max_cost_per_user_per_day_cents: None,
|
|
||||||
max_tool_iterations: 10,
|
max_tool_iterations: 10,
|
||||||
auto_approve_tools: true,
|
auto_approve_tools: true,
|
||||||
default_timezone: "UTC".to_string(),
|
default_timezone: "UTC".to_string(),
|
||||||
max_tokens_per_job,
|
max_tokens_per_job,
|
||||||
multi_tenant: false,
|
|
||||||
max_llm_concurrent_per_user: None,
|
|
||||||
max_jobs_concurrent_per_user: None,
|
|
||||||
};
|
};
|
||||||
let cm = Arc::new(ContextManager::new(5));
|
let cm = Arc::new(ContextManager::new(5));
|
||||||
let llm: Arc<dyn LlmProvider> = Arc::new(StubLlm);
|
let llm: Arc<dyn LlmProvider> = Arc::new(StubLlm);
|
||||||
|
|||||||
@@ -8,8 +8,8 @@ use chrono::{DateTime, Utc};
|
|||||||
use uuid::Uuid;
|
use uuid::Uuid;
|
||||||
|
|
||||||
use crate::context::{ContextManager, JobState};
|
use crate::context::{ContextManager, JobState};
|
||||||
|
use crate::db::Database;
|
||||||
use crate::error::RepairError;
|
use crate::error::RepairError;
|
||||||
use crate::tenant::AdminScope;
|
|
||||||
use crate::tools::{BuildRequirement, Language, SoftwareBuilder, SoftwareType, ToolRegistry};
|
use crate::tools::{BuildRequirement, Language, SoftwareBuilder, SoftwareType, ToolRegistry};
|
||||||
|
|
||||||
/// A job that has been detected as stuck.
|
/// A job that has been detected as stuck.
|
||||||
@@ -69,7 +69,7 @@ pub struct DefaultSelfRepair {
|
|||||||
/// Jobs in `InProgress` longer than this are treated as stuck.
|
/// Jobs in `InProgress` longer than this are treated as stuck.
|
||||||
stuck_threshold: Duration,
|
stuck_threshold: Duration,
|
||||||
max_repair_attempts: u32,
|
max_repair_attempts: u32,
|
||||||
store: Option<AdminScope>,
|
store: Option<Arc<dyn Database>>,
|
||||||
builder: Option<Arc<dyn SoftwareBuilder>>,
|
builder: Option<Arc<dyn SoftwareBuilder>>,
|
||||||
tools: Option<Arc<ToolRegistry>>,
|
tools: Option<Arc<ToolRegistry>>,
|
||||||
}
|
}
|
||||||
@@ -91,8 +91,8 @@ impl DefaultSelfRepair {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Add an admin-scoped store for tool failure tracking.
|
/// Add a Store for tool failure tracking.
|
||||||
pub fn with_store(mut self, store: AdminScope) -> Self {
|
pub fn with_store(mut self, store: Arc<dyn Database>) -> Self {
|
||||||
self.store = Some(store);
|
self.store = Some(store);
|
||||||
self
|
self
|
||||||
}
|
}
|
||||||
@@ -806,7 +806,7 @@ mod tests {
|
|||||||
// Create self-repair with zero threshold (detect immediately),
|
// Create self-repair with zero threshold (detect immediately),
|
||||||
// wired with store, builder, and tools.
|
// wired with store, builder, and tools.
|
||||||
let repair = DefaultSelfRepair::new(Arc::clone(&cm), Duration::from_secs(0), 3)
|
let repair = DefaultSelfRepair::new(Arc::clone(&cm), Duration::from_secs(0), 3)
|
||||||
.with_store(crate::tenant::AdminScope::new(Arc::clone(&db)))
|
.with_store(Arc::clone(&db))
|
||||||
.with_builder(
|
.with_builder(
|
||||||
Arc::clone(&builder) as Arc<dyn crate::tools::SoftwareBuilder>,
|
Arc::clone(&builder) as Arc<dyn crate::tools::SoftwareBuilder>,
|
||||||
tools,
|
tools,
|
||||||
|
|||||||
+199
-42
@@ -175,7 +175,6 @@ impl Agent {
|
|||||||
pub(super) async fn process_user_input(
|
pub(super) async fn process_user_input(
|
||||||
&self,
|
&self,
|
||||||
message: &IncomingMessage,
|
message: &IncomingMessage,
|
||||||
tenant: crate::tenant::TenantCtx,
|
|
||||||
session: Arc<Mutex<Session>>,
|
session: Arc<Mutex<Session>>,
|
||||||
thread_id: Uuid,
|
thread_id: Uuid,
|
||||||
content: &str,
|
content: &str,
|
||||||
@@ -352,7 +351,7 @@ impl Agent {
|
|||||||
|
|
||||||
if let Some(intent) = self.router.route_command(&temp_message) {
|
if let Some(intent) = self.router.route_command(&temp_message) {
|
||||||
// Explicit command like /status, /job, /list - handle directly
|
// Explicit command like /status, /job, /list - handle directly
|
||||||
return self.handle_job_or_command(intent, message, &tenant).await;
|
return self.handle_job_or_command(intent, message).await;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Natural language goes through the agentic loop
|
// Natural language goes through the agentic loop
|
||||||
@@ -463,7 +462,7 @@ impl Agent {
|
|||||||
|
|
||||||
// Run the agentic tool execution loop
|
// Run the agentic tool execution loop
|
||||||
let result = self
|
let result = self
|
||||||
.run_agentic_loop(message, tenant, session.clone(), thread_id, turn_messages)
|
.run_agentic_loop(message, session.clone(), thread_id, turn_messages)
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
// Re-acquire lock and check if interrupted
|
// Re-acquire lock and check if interrupted
|
||||||
@@ -969,6 +968,10 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Process an approval or rejection of a pending tool execution.
|
/// Process an approval or rejection of a pending tool execution.
|
||||||
|
// Nested `if` blocks are intentional: collapsing them would produce
|
||||||
|
// `if let … && …` (let-chains), which require `#![feature(let_chains)]`
|
||||||
|
// and are not available on our MSRV.
|
||||||
|
#[allow(clippy::collapsible_if)]
|
||||||
pub(super) async fn process_approval(
|
pub(super) async fn process_approval(
|
||||||
&self,
|
&self,
|
||||||
message: &IncomingMessage,
|
message: &IncomingMessage,
|
||||||
@@ -978,7 +981,10 @@ impl Agent {
|
|||||||
approved: bool,
|
approved: bool,
|
||||||
always: bool,
|
always: bool,
|
||||||
) -> Result<SubmissionResult, Error> {
|
) -> Result<SubmissionResult, Error> {
|
||||||
// Get pending approval for this thread
|
// Get pending approval for this thread.
|
||||||
|
// The take-verify sequence is atomic under a single lock acquisition
|
||||||
|
// to prevent a TOCTOU race where a concurrent operation could modify
|
||||||
|
// or delete the thread between take and restore (#1486).
|
||||||
let pending = {
|
let pending = {
|
||||||
let mut sess = session.lock().await;
|
let mut sess = session.lock().await;
|
||||||
let thread = sess
|
let thread = sess
|
||||||
@@ -996,10 +1002,7 @@ impl Agent {
|
|||||||
return Ok(SubmissionResult::ok_with_message(""));
|
return Ok(SubmissionResult::ok_with_message(""));
|
||||||
}
|
}
|
||||||
|
|
||||||
thread.take_pending_approval()
|
let taken = match thread.take_pending_approval() {
|
||||||
};
|
|
||||||
|
|
||||||
let pending = match pending {
|
|
||||||
Some(p) => p,
|
Some(p) => p,
|
||||||
None => {
|
None => {
|
||||||
tracing::debug!(
|
tracing::debug!(
|
||||||
@@ -1010,19 +1013,20 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
// Verify request ID if provided
|
// Verify request ID while still holding the lock — atomic with take
|
||||||
if let Some(req_id) = request_id
|
if let Some(req_id) = request_id {
|
||||||
&& req_id != pending.request_id
|
if req_id != taken.request_id {
|
||||||
{
|
// Restore atomically under same lock
|
||||||
// Put it back and return error
|
thread.await_approval(taken);
|
||||||
let mut sess = session.lock().await;
|
|
||||||
if let Some(thread) = sess.threads.get_mut(&thread_id) {
|
|
||||||
thread.await_approval(pending);
|
|
||||||
}
|
|
||||||
return Ok(SubmissionResult::error(
|
return Ok(SubmissionResult::error(
|
||||||
"Request ID mismatch. Use the correct request ID.",
|
"Request ID mismatch. Use the correct request ID.",
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
taken
|
||||||
|
// Lock dropped here — pending approval validated
|
||||||
|
};
|
||||||
|
|
||||||
if approved {
|
if approved {
|
||||||
// If always, add to auto-approved set
|
// If always, add to auto-approved set
|
||||||
@@ -1039,9 +1043,20 @@ impl Agent {
|
|||||||
// Reset thread state to processing
|
// Reset thread state to processing
|
||||||
{
|
{
|
||||||
let mut sess = session.lock().await;
|
let mut sess = session.lock().await;
|
||||||
if let Some(thread) = sess.threads.get_mut(&thread_id) {
|
match sess.threads.get_mut(&thread_id) {
|
||||||
|
Some(thread) => {
|
||||||
thread.state = ThreadState::Processing;
|
thread.state = ThreadState::Processing;
|
||||||
}
|
}
|
||||||
|
None => {
|
||||||
|
tracing::error!(
|
||||||
|
%thread_id,
|
||||||
|
"Thread disappeared while setting state to Processing during approval"
|
||||||
|
);
|
||||||
|
return Ok(SubmissionResult::error(
|
||||||
|
"Internal error: thread no longer exists",
|
||||||
|
));
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Execute the approved tool and continue the loop
|
// Execute the approved tool and continue the loop
|
||||||
@@ -1091,9 +1106,8 @@ impl Agent {
|
|||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
if let Ok(ref output) = tool_result
|
if let Ok(ref output) = tool_result {
|
||||||
&& !output.is_empty()
|
if !output.is_empty() {
|
||||||
{
|
|
||||||
let _ = self
|
let _ = self
|
||||||
.channels
|
.channels
|
||||||
.send_status(
|
.send_status(
|
||||||
@@ -1106,6 +1120,7 @@ impl Agent {
|
|||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Build context including the tool result
|
// Build context including the tool result
|
||||||
let mut context_messages = pending.context_messages;
|
let mut context_messages = pending.context_messages;
|
||||||
@@ -1124,11 +1139,14 @@ impl Agent {
|
|||||||
// Record sanitized result in thread
|
// Record sanitized result in thread
|
||||||
{
|
{
|
||||||
let mut sess = session.lock().await;
|
let mut sess = session.lock().await;
|
||||||
if let Some(thread) = sess.threads.get_mut(&thread_id)
|
match sess.threads.get_mut(&thread_id) {
|
||||||
&& let Some(turn) = thread.last_turn_mut()
|
Some(thread) => {
|
||||||
{
|
if let Some(turn) = thread.last_turn_mut() {
|
||||||
if is_tool_error {
|
if is_tool_error {
|
||||||
turn.record_tool_error_for(&pending.tool_call_id, result_content.clone());
|
turn.record_tool_error_for(
|
||||||
|
&pending.tool_call_id,
|
||||||
|
result_content.clone(),
|
||||||
|
);
|
||||||
} else {
|
} else {
|
||||||
turn.record_tool_result_for(
|
turn.record_tool_result_for(
|
||||||
&pending.tool_call_id,
|
&pending.tool_call_id,
|
||||||
@@ -1137,6 +1155,14 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
None => {
|
||||||
|
tracing::error!(
|
||||||
|
%thread_id,
|
||||||
|
"Thread disappeared while recording tool result during approval"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// If tool_auth returned awaiting_token, enter auth mode and
|
// If tool_auth returned awaiting_token, enter auth mode and
|
||||||
// return instructions directly (skip agentic loop continuation).
|
// return instructions directly (skip agentic loop continuation).
|
||||||
@@ -1352,9 +1378,8 @@ impl Agent {
|
|||||||
let mut deferred_auth: Option<String> = None;
|
let mut deferred_auth: Option<String> = None;
|
||||||
|
|
||||||
for (tc, deferred_result) in exec_results {
|
for (tc, deferred_result) in exec_results {
|
||||||
if let Ok(ref output) = deferred_result
|
if let Ok(ref output) = deferred_result {
|
||||||
&& !output.is_empty()
|
if !output.is_empty() {
|
||||||
{
|
|
||||||
let _ = self
|
let _ = self
|
||||||
.channels
|
.channels
|
||||||
.send_status(
|
.send_status(
|
||||||
@@ -1367,6 +1392,7 @@ impl Agent {
|
|||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Sanitize first, then record the cleaned version in thread.
|
// Sanitize first, then record the cleaned version in thread.
|
||||||
// Must happen before auth detection which may set deferred_auth.
|
// Must happen before auth detection which may set deferred_auth.
|
||||||
@@ -1381,9 +1407,9 @@ impl Agent {
|
|||||||
// Record sanitized result in thread
|
// Record sanitized result in thread
|
||||||
{
|
{
|
||||||
let mut sess = session.lock().await;
|
let mut sess = session.lock().await;
|
||||||
if let Some(thread) = sess.threads.get_mut(&thread_id)
|
match sess.threads.get_mut(&thread_id) {
|
||||||
&& let Some(turn) = thread.last_turn_mut()
|
Some(thread) => {
|
||||||
{
|
if let Some(turn) = thread.last_turn_mut() {
|
||||||
if is_deferred_error {
|
if is_deferred_error {
|
||||||
turn.record_tool_error_for(&tc.id, deferred_content.clone());
|
turn.record_tool_error_for(&tc.id, deferred_content.clone());
|
||||||
} else {
|
} else {
|
||||||
@@ -1394,10 +1420,19 @@ impl Agent {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
None => {
|
||||||
|
tracing::error!(
|
||||||
|
%thread_id,
|
||||||
|
tool_name = %tc.name,
|
||||||
|
"Thread disappeared while recording deferred tool result during approval"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Auth detection — defer return until all results are recorded
|
// Auth detection — defer return until all results are recorded
|
||||||
if deferred_auth.is_none()
|
if deferred_auth.is_none() {
|
||||||
&& let Some((ext_name, instructions)) =
|
if let Some((ext_name, instructions)) =
|
||||||
check_auth_required(&tc.name, &deferred_result)
|
check_auth_required(&tc.name, &deferred_result)
|
||||||
{
|
{
|
||||||
self.handle_auth_intercept(
|
self.handle_auth_intercept(
|
||||||
@@ -1411,6 +1446,7 @@ impl Agent {
|
|||||||
.await;
|
.await;
|
||||||
deferred_auth = Some(instructions);
|
deferred_auth = Some(instructions);
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
context_messages.push(ChatMessage::tool_result(&tc.id, &tc.name, deferred_content));
|
context_messages.push(ChatMessage::tool_result(&tc.id, &tc.name, deferred_content));
|
||||||
}
|
}
|
||||||
@@ -1443,9 +1479,20 @@ impl Agent {
|
|||||||
|
|
||||||
{
|
{
|
||||||
let mut sess = session.lock().await;
|
let mut sess = session.lock().await;
|
||||||
if let Some(thread) = sess.threads.get_mut(&thread_id) {
|
match sess.threads.get_mut(&thread_id) {
|
||||||
|
Some(thread) => {
|
||||||
thread.await_approval(new_pending);
|
thread.await_approval(new_pending);
|
||||||
}
|
}
|
||||||
|
None => {
|
||||||
|
tracing::error!(
|
||||||
|
%thread_id,
|
||||||
|
"Thread disappeared while setting up deferred tool approval"
|
||||||
|
);
|
||||||
|
return Ok(SubmissionResult::error(
|
||||||
|
"Internal error: thread no longer exists",
|
||||||
|
));
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
let _ = self
|
let _ = self
|
||||||
@@ -1474,13 +1521,7 @@ impl Agent {
|
|||||||
|
|
||||||
// Continue the agentic loop (a tool was already executed this turn)
|
// Continue the agentic loop (a tool was already executed this turn)
|
||||||
let result = self
|
let result = self
|
||||||
.run_agentic_loop(
|
.run_agentic_loop(message, session.clone(), thread_id, context_messages)
|
||||||
message,
|
|
||||||
self.tenant_ctx(&message.user_id).await,
|
|
||||||
session.clone(),
|
|
||||||
thread_id,
|
|
||||||
context_messages,
|
|
||||||
)
|
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
// Handle the result
|
// Handle the result
|
||||||
@@ -1583,7 +1624,8 @@ impl Agent {
|
|||||||
);
|
);
|
||||||
{
|
{
|
||||||
let mut sess = session.lock().await;
|
let mut sess = session.lock().await;
|
||||||
if let Some(thread) = sess.threads.get_mut(&thread_id) {
|
match sess.threads.get_mut(&thread_id) {
|
||||||
|
Some(thread) => {
|
||||||
thread.clear_pending_approval();
|
thread.clear_pending_approval();
|
||||||
thread.complete_turn(&rejection);
|
thread.complete_turn(&rejection);
|
||||||
// User message already persisted at turn start; save rejection response
|
// User message already persisted at turn start; save rejection response
|
||||||
@@ -1595,6 +1637,16 @@ impl Agent {
|
|||||||
)
|
)
|
||||||
.await;
|
.await;
|
||||||
}
|
}
|
||||||
|
None => {
|
||||||
|
tracing::error!(
|
||||||
|
%thread_id,
|
||||||
|
"Thread disappeared during approval rejection"
|
||||||
|
);
|
||||||
|
return Ok(SubmissionResult::error(
|
||||||
|
"Internal error: thread no longer exists",
|
||||||
|
));
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
let _ = self
|
let _ = self
|
||||||
@@ -2152,6 +2204,70 @@ mod tests {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn test_approval_on_missing_thread_should_error() {
|
||||||
|
// Regression for #1487: when a thread disappears from the session
|
||||||
|
// during approval processing, the code must return a visible error
|
||||||
|
// rather than silently succeeding.
|
||||||
|
//
|
||||||
|
// We can't call process_approval() directly (requires full Agent),
|
||||||
|
// so we simulate the exact code pattern used in the rejection and
|
||||||
|
// state-setting paths: lock session, match on get_mut, verify the
|
||||||
|
// None arm produces an error.
|
||||||
|
use crate::agent::session::{Session, Thread, ThreadState};
|
||||||
|
use std::sync::Arc;
|
||||||
|
use tokio::sync::Mutex;
|
||||||
|
use uuid::Uuid;
|
||||||
|
|
||||||
|
let thread_id = Uuid::new_v4();
|
||||||
|
let session_id = Uuid::new_v4();
|
||||||
|
let session = Arc::new(Mutex::new(Session::new("test-user")));
|
||||||
|
|
||||||
|
// Scenario 1: Thread never existed
|
||||||
|
{
|
||||||
|
let sess = session.lock().await;
|
||||||
|
let result = match sess.threads.get(&thread_id) {
|
||||||
|
Some(_) => Ok("processed"),
|
||||||
|
None => Err("Internal error: thread no longer exists"),
|
||||||
|
};
|
||||||
|
assert!(result.is_err());
|
||||||
|
assert_eq!(
|
||||||
|
result.unwrap_err(),
|
||||||
|
"Internal error: thread no longer exists"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Scenario 2: Thread existed then was removed (simulates disappearance
|
||||||
|
// between lock acquisitions -- the TOCTOU window this fix addresses)
|
||||||
|
{
|
||||||
|
let mut sess = session.lock().await;
|
||||||
|
let mut thread = Thread::with_id(thread_id, session_id);
|
||||||
|
thread.start_turn("pending approval");
|
||||||
|
thread.state = ThreadState::AwaitingApproval;
|
||||||
|
sess.threads.insert(thread_id, thread);
|
||||||
|
}
|
||||||
|
{
|
||||||
|
let mut sess = session.lock().await;
|
||||||
|
// Simulate thread disappearing (e.g., pruned by another task)
|
||||||
|
sess.threads.remove(&thread_id);
|
||||||
|
|
||||||
|
// The rejection path must detect this and return an error
|
||||||
|
let result = match sess.threads.get_mut(&thread_id) {
|
||||||
|
Some(thread) => {
|
||||||
|
thread.clear_pending_approval();
|
||||||
|
thread.complete_turn("rejected");
|
||||||
|
Ok("rejection persisted")
|
||||||
|
}
|
||||||
|
None => Err("Internal error: thread no longer exists"),
|
||||||
|
};
|
||||||
|
assert!(result.is_err());
|
||||||
|
assert_eq!(
|
||||||
|
result.unwrap_err(),
|
||||||
|
"Internal error: thread no longer exists"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_queue_cap_rejects_at_capacity() {
|
fn test_queue_cap_rejects_at_capacity() {
|
||||||
use crate::agent::session::{MAX_PENDING_MESSAGES, Thread, ThreadState};
|
use crate::agent::session::{MAX_PENDING_MESSAGES, Thread, ThreadState};
|
||||||
@@ -2258,6 +2374,47 @@ mod tests {
|
|||||||
assert!(t.pending_messages.is_empty());
|
assert!(t.pending_messages.is_empty());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_approval_request_id_mismatch_restores_pending() {
|
||||||
|
// Regression test for #1486: after a request_id mismatch, the pending
|
||||||
|
// approval must still be intact (take + verify + restore is atomic).
|
||||||
|
use crate::agent::session::{PendingApproval, Thread, ThreadState};
|
||||||
|
use uuid::Uuid;
|
||||||
|
|
||||||
|
let session_id = Uuid::new_v4();
|
||||||
|
let thread_id = Uuid::new_v4();
|
||||||
|
let mut thread = Thread::with_id(thread_id, session_id);
|
||||||
|
|
||||||
|
let correct_request_id = Uuid::new_v4();
|
||||||
|
let pending = PendingApproval {
|
||||||
|
request_id: correct_request_id,
|
||||||
|
tool_name: "shell".to_string(),
|
||||||
|
parameters: serde_json::json!({}),
|
||||||
|
display_parameters: serde_json::json!({}),
|
||||||
|
description: "test".to_string(),
|
||||||
|
tool_call_id: "call_0".to_string(),
|
||||||
|
context_messages: vec![],
|
||||||
|
deferred_tool_calls: vec![],
|
||||||
|
user_timezone: None,
|
||||||
|
allow_always: true,
|
||||||
|
};
|
||||||
|
thread.await_approval(pending);
|
||||||
|
assert_eq!(thread.state, ThreadState::AwaitingApproval);
|
||||||
|
|
||||||
|
// Simulate: take, verify mismatch, restore -- all must be atomic
|
||||||
|
let taken = thread.take_pending_approval().unwrap();
|
||||||
|
assert_eq!(taken.request_id, correct_request_id);
|
||||||
|
// On mismatch, restore
|
||||||
|
thread.await_approval(taken);
|
||||||
|
// Must still be in AwaitingApproval with pending intact
|
||||||
|
assert_eq!(thread.state, ThreadState::AwaitingApproval);
|
||||||
|
assert!(thread.pending_approval.is_some());
|
||||||
|
assert_eq!(
|
||||||
|
thread.pending_approval.as_ref().unwrap().request_id,
|
||||||
|
correct_request_id
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
// Helper function to extract the approval message without needing a full Agent instance
|
// Helper function to extract the approval message without needing a full Agent instance
|
||||||
fn extract_approval_message(
|
fn extract_approval_message(
|
||||||
session: &crate::agent::session::Session,
|
session: &crate::agent::session::Session,
|
||||||
|
|||||||
@@ -880,7 +880,6 @@ impl AppBuilder {
|
|||||||
crate::agent::cost_guard::CostGuardConfig {
|
crate::agent::cost_guard::CostGuardConfig {
|
||||||
max_cost_per_day_cents: self.config.agent.max_cost_per_day_cents,
|
max_cost_per_day_cents: self.config.agent.max_cost_per_day_cents,
|
||||||
max_actions_per_hour: self.config.agent.max_actions_per_hour,
|
max_actions_per_hour: self.config.agent.max_actions_per_hour,
|
||||||
max_cost_per_user_per_day_cents: self.config.agent.max_cost_per_user_per_day_cents,
|
|
||||||
},
|
},
|
||||||
));
|
));
|
||||||
|
|
||||||
|
|||||||
@@ -122,32 +122,18 @@ impl RelayClient {
|
|||||||
/// instance_url in chat-api. IronClaw only passes an optional CSRF nonce
|
/// instance_url in chat-api. IronClaw only passes an optional CSRF nonce
|
||||||
/// for validating the callback — no URLs.
|
/// for validating the callback — no URLs.
|
||||||
pub async fn initiate_oauth(&self, state_nonce: Option<&str>) -> Result<String, RelayError> {
|
pub async fn initiate_oauth(&self, state_nonce: Option<&str>) -> Result<String, RelayError> {
|
||||||
let url = format!("{}/oauth/slack/auth", self.base_url);
|
|
||||||
tracing::debug!(relay_url = %url, "RelayClient::initiate_oauth: sending request");
|
|
||||||
let mut query: Vec<(&str, &str)> = vec![];
|
let mut query: Vec<(&str, &str)> = vec![];
|
||||||
if let Some(nonce) = state_nonce {
|
if let Some(nonce) = state_nonce {
|
||||||
query.push(("state_nonce", nonce));
|
query.push(("state_nonce", nonce));
|
||||||
}
|
}
|
||||||
let resp = self
|
let resp = self
|
||||||
.http
|
.http
|
||||||
.get(&url)
|
.get(format!("{}/oauth/slack/auth", self.base_url))
|
||||||
.bearer_auth(self.api_key.expose_secret())
|
.bearer_auth(self.api_key.expose_secret())
|
||||||
.query(&query)
|
.query(&query)
|
||||||
.send()
|
.send()
|
||||||
.await
|
.await
|
||||||
.map_err(|e| {
|
.map_err(|e| RelayError::Network(e.to_string()))?;
|
||||||
tracing::warn!(
|
|
||||||
relay_url = %url,
|
|
||||||
error = %e,
|
|
||||||
"RelayClient::initiate_oauth: network request failed"
|
|
||||||
);
|
|
||||||
RelayError::Network(e.to_string())
|
|
||||||
})?;
|
|
||||||
tracing::debug!(
|
|
||||||
relay_url = %url,
|
|
||||||
status = %resp.status(),
|
|
||||||
"RelayClient::initiate_oauth: received response"
|
|
||||||
);
|
|
||||||
|
|
||||||
let status = resp.status();
|
let status = resp.status();
|
||||||
if status.is_redirection() {
|
if status.is_redirection() {
|
||||||
@@ -238,39 +224,20 @@ impl RelayClient {
|
|||||||
method: &str,
|
method: &str,
|
||||||
body: serde_json::Value,
|
body: serde_json::Value,
|
||||||
) -> Result<serde_json::Value, RelayError> {
|
) -> Result<serde_json::Value, RelayError> {
|
||||||
let url = format!("{}/proxy/{}/{}", self.base_url, provider, method);
|
|
||||||
tracing::debug!(
|
|
||||||
relay_url = %url,
|
|
||||||
provider = %provider,
|
|
||||||
method = %method,
|
|
||||||
"RelayClient::proxy_provider: sending request"
|
|
||||||
);
|
|
||||||
let query: Vec<(&str, &str)> = vec![("team_id", team_id)];
|
let query: Vec<(&str, &str)> = vec![("team_id", team_id)];
|
||||||
let resp = self
|
let resp = self
|
||||||
.http
|
.http
|
||||||
.post(&url)
|
.post(format!("{}/proxy/{}/{}", self.base_url, provider, method))
|
||||||
.bearer_auth(self.api_key.expose_secret())
|
.bearer_auth(self.api_key.expose_secret())
|
||||||
.query(&query)
|
.query(&query)
|
||||||
.json(&body)
|
.json(&body)
|
||||||
.send()
|
.send()
|
||||||
.await
|
.await
|
||||||
.map_err(|e| {
|
.map_err(|e| RelayError::Network(e.to_string()))?;
|
||||||
tracing::warn!(
|
|
||||||
relay_url = %url,
|
|
||||||
error = %e,
|
|
||||||
"RelayClient::proxy_provider: network request failed"
|
|
||||||
);
|
|
||||||
RelayError::Network(e.to_string())
|
|
||||||
})?;
|
|
||||||
|
|
||||||
if !resp.status().is_success() {
|
if !resp.status().is_success() {
|
||||||
let status = resp.status().as_u16();
|
let status = resp.status().as_u16();
|
||||||
let body = resp.text().await.unwrap_or_default();
|
let body = resp.text().await.unwrap_or_default();
|
||||||
tracing::warn!(
|
|
||||||
relay_url = %url,
|
|
||||||
status = status,
|
|
||||||
"RelayClient::proxy_provider: channel-relay returned error"
|
|
||||||
);
|
|
||||||
return Err(RelayError::Api {
|
return Err(RelayError::Api {
|
||||||
status,
|
status,
|
||||||
message: body,
|
message: body,
|
||||||
@@ -288,45 +255,23 @@ impl RelayClient {
|
|||||||
/// 32-byte secret. Called once at activation time; the result is cached in the
|
/// 32-byte secret. Called once at activation time; the result is cached in the
|
||||||
/// extension manager so subsequent calls to `relay_signing_secret()` use it.
|
/// extension manager so subsequent calls to `relay_signing_secret()` use it.
|
||||||
pub async fn get_signing_secret(&self, team_id: &str) -> Result<Vec<u8>, RelayError> {
|
pub async fn get_signing_secret(&self, team_id: &str) -> Result<Vec<u8>, RelayError> {
|
||||||
let url = format!("{}/relay/signing-secret", self.base_url);
|
|
||||||
tracing::debug!(
|
|
||||||
relay_url = %url,
|
|
||||||
"RelayClient::get_signing_secret: fetching signing secret"
|
|
||||||
);
|
|
||||||
let resp = self
|
let resp = self
|
||||||
.http
|
.http
|
||||||
.get(&url)
|
.get(format!("{}/relay/signing-secret", self.base_url))
|
||||||
.bearer_auth(self.api_key.expose_secret())
|
.bearer_auth(self.api_key.expose_secret())
|
||||||
.query(&[("team_id", team_id)])
|
.query(&[("team_id", team_id)])
|
||||||
.send()
|
.send()
|
||||||
.await
|
.await
|
||||||
.map_err(|e| {
|
.map_err(|e| RelayError::Network(e.to_string()))?;
|
||||||
tracing::warn!(
|
|
||||||
relay_url = %url,
|
|
||||||
error = %e,
|
|
||||||
"RelayClient::get_signing_secret: network request failed"
|
|
||||||
);
|
|
||||||
RelayError::Network(e.to_string())
|
|
||||||
})?;
|
|
||||||
|
|
||||||
if !resp.status().is_success() {
|
if !resp.status().is_success() {
|
||||||
let status = resp.status().as_u16();
|
let status = resp.status().as_u16();
|
||||||
let body = resp.text().await.unwrap_or_default();
|
let body = resp.text().await.unwrap_or_default();
|
||||||
tracing::warn!(
|
|
||||||
relay_url = %url,
|
|
||||||
status = status,
|
|
||||||
body = %body,
|
|
||||||
"RelayClient::get_signing_secret: channel-relay returned error"
|
|
||||||
);
|
|
||||||
return Err(RelayError::Api {
|
return Err(RelayError::Api {
|
||||||
status,
|
status,
|
||||||
message: body,
|
message: body,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
tracing::debug!(
|
|
||||||
relay_url = %url,
|
|
||||||
"RelayClient::get_signing_secret: received successful response"
|
|
||||||
);
|
|
||||||
|
|
||||||
let body: serde_json::Value = resp
|
let body: serde_json::Value = resp
|
||||||
.json()
|
.json()
|
||||||
|
|||||||
+9
-51
@@ -431,18 +431,6 @@ impl ReplChannel {
|
|||||||
let _ = execute!(stderr, terminal::Clear(terminal::ClearType::FromCursorDown));
|
let _ = execute!(stderr, terminal::Clear(terminal::ClearType::FromCursorDown));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn finish_single_message_turn(&self) {
|
|
||||||
if self.single_message.is_none() {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
let tx = self.msg_tx.lock().ok().and_then(|mut guard| guard.take());
|
|
||||||
if let Some(tx) = tx {
|
|
||||||
let msg = IncomingMessage::new("repl", &self.user_id, "/quit");
|
|
||||||
let _ = tx.send(msg).await;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Default for ReplChannel {
|
impl Default for ReplChannel {
|
||||||
@@ -492,9 +480,7 @@ impl Channel for ReplChannel {
|
|||||||
|
|
||||||
async fn start(&self) -> Result<MessageStream, ChannelError> {
|
async fn start(&self) -> Result<MessageStream, ChannelError> {
|
||||||
let (tx, rx) = mpsc::channel(32);
|
let (tx, rx) = mpsc::channel(32);
|
||||||
// Approval prompts inject responses back through this sender.
|
// Store tx so send_status can inject approval responses directly
|
||||||
// In single-message mode we keep it until the turn finishes, then
|
|
||||||
// drop it after enqueuing /quit so the receiver stream can close.
|
|
||||||
if let Ok(mut guard) = self.msg_tx.lock() {
|
if let Ok(mut guard) = self.msg_tx.lock() {
|
||||||
*guard = Some(tx.clone());
|
*guard = Some(tx.clone());
|
||||||
}
|
}
|
||||||
@@ -510,10 +496,11 @@ impl Channel for ReplChannel {
|
|||||||
|
|
||||||
// Single message mode: send it and return
|
// Single message mode: send it and return
|
||||||
if let Some(msg) = single_message {
|
if let Some(msg) = single_message {
|
||||||
let incoming = IncomingMessage::new("repl", &user_id, &msg)
|
let incoming = IncomingMessage::new("repl", &user_id, &msg).with_timezone(&sys_tz);
|
||||||
.with_metadata(serde_json::json!({ "single_message_mode": true }))
|
|
||||||
.with_timezone(&sys_tz);
|
|
||||||
let _ = tx.blocking_send(incoming);
|
let _ = tx.blocking_send(incoming);
|
||||||
|
// Ensure the agent exits after handling exactly one turn in -m mode,
|
||||||
|
// even when other channels (gateway/http) are enabled.
|
||||||
|
let _ = tx.blocking_send(IncomingMessage::new("repl", &user_id, "/quit"));
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -676,7 +663,6 @@ impl Channel for ReplChannel {
|
|||||||
println!();
|
println!();
|
||||||
println!();
|
println!();
|
||||||
self.stdin_locked.store(false, Ordering::Relaxed);
|
self.stdin_locked.store(false, Ordering::Relaxed);
|
||||||
self.finish_single_message_turn().await;
|
|
||||||
return Ok(());
|
return Ok(());
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -695,7 +681,6 @@ impl Channel for ReplChannel {
|
|||||||
println!();
|
println!();
|
||||||
// Unlock stdin so readline can resume
|
// Unlock stdin so readline can resume
|
||||||
self.stdin_locked.store(false, Ordering::Relaxed);
|
self.stdin_locked.store(false, Ordering::Relaxed);
|
||||||
self.finish_single_message_turn().await;
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -795,7 +780,6 @@ impl Channel for ReplChannel {
|
|||||||
let msg_tx = Arc::clone(&self.msg_tx);
|
let msg_tx = Arc::clone(&self.msg_tx);
|
||||||
let user_id = self.user_id.clone();
|
let user_id = self.user_id.clone();
|
||||||
let lock_flag = Arc::clone(&self.stdin_locked);
|
let lock_flag = Arc::clone(&self.stdin_locked);
|
||||||
let single_message_mode = self.single_message.is_some();
|
|
||||||
tokio::task::spawn_blocking(move || {
|
tokio::task::spawn_blocking(move || {
|
||||||
let action = run_approval_selector(allow_always).unwrap_or("n");
|
let action = run_approval_selector(allow_always).unwrap_or("n");
|
||||||
// Unlock stdin so readline can resume after approval
|
// Unlock stdin so readline can resume after approval
|
||||||
@@ -804,12 +788,7 @@ impl Channel for ReplChannel {
|
|||||||
return;
|
return;
|
||||||
};
|
};
|
||||||
if let Some(tx) = guard.as_ref() {
|
if let Some(tx) = guard.as_ref() {
|
||||||
let msg = if single_message_mode {
|
let msg = IncomingMessage::new("repl", &user_id, action);
|
||||||
IncomingMessage::new("repl", &user_id, action)
|
|
||||||
.with_metadata(serde_json::json!({ "single_message_mode": true }))
|
|
||||||
} else {
|
|
||||||
IncomingMessage::new("repl", &user_id, action)
|
|
||||||
};
|
|
||||||
let _ = tx.blocking_send(msg);
|
let _ = tx.blocking_send(msg);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
@@ -910,7 +889,6 @@ impl Channel for ReplChannel {
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use futures::StreamExt;
|
use futures::StreamExt;
|
||||||
use tokio::time::{Duration, timeout};
|
|
||||||
|
|
||||||
use super::*;
|
use super::*;
|
||||||
|
|
||||||
@@ -919,36 +897,16 @@ mod tests {
|
|||||||
let repl = ReplChannel::with_message("hi".to_string());
|
let repl = ReplChannel::with_message("hi".to_string());
|
||||||
let mut stream = repl.start().await.expect("repl start should succeed");
|
let mut stream = repl.start().await.expect("repl start should succeed");
|
||||||
|
|
||||||
let first = timeout(Duration::from_secs(1), stream.next())
|
let first = stream.next().await.expect("first message missing");
|
||||||
.await
|
|
||||||
.expect("timed out waiting for first message")
|
|
||||||
.expect("first message missing");
|
|
||||||
assert_eq!(first.channel, "repl");
|
assert_eq!(first.channel, "repl");
|
||||||
assert_eq!(first.content, "hi");
|
assert_eq!(first.content, "hi");
|
||||||
|
|
||||||
assert!(
|
let second = stream.next().await.expect("quit message missing");
|
||||||
timeout(Duration::from_millis(100), stream.next())
|
|
||||||
.await
|
|
||||||
.is_err(),
|
|
||||||
"single-message mode should wait for the turn to finish before quitting"
|
|
||||||
);
|
|
||||||
|
|
||||||
repl.respond(&first, OutgoingResponse::text("done"))
|
|
||||||
.await
|
|
||||||
.expect("respond should succeed");
|
|
||||||
|
|
||||||
let second = timeout(Duration::from_secs(1), stream.next())
|
|
||||||
.await
|
|
||||||
.expect("timed out waiting for quit message")
|
|
||||||
.expect("quit message missing");
|
|
||||||
assert_eq!(second.channel, "repl");
|
assert_eq!(second.channel, "repl");
|
||||||
assert_eq!(second.content, "/quit");
|
assert_eq!(second.content, "/quit");
|
||||||
|
|
||||||
assert!(
|
assert!(
|
||||||
timeout(Duration::from_secs(1), stream.next())
|
stream.next().await.is_none(),
|
||||||
.await
|
|
||||||
.expect("timed out waiting for stream to close")
|
|
||||||
.is_none(),
|
|
||||||
"stream should end after /quit"
|
"stream should end after /quit"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -54,37 +54,10 @@ fn validate_webhook_secret(
|
|||||||
///
|
///
|
||||||
/// This endpoint is **public** (no gateway auth token required) but protected
|
/// This endpoint is **public** (no gateway auth token required) but protected
|
||||||
/// by the per-routine webhook secret sent via the `X-Webhook-Secret` header.
|
/// by the per-routine webhook secret sent via the `X-Webhook-Secret` header.
|
||||||
///
|
|
||||||
/// **Single-user/backward-compatible**: looks up routines by path across all
|
|
||||||
/// users. For multi-tenant isolation, use the user-scoped endpoint at
|
|
||||||
/// `/api/webhooks/u/{user_id}/{path}` instead.
|
|
||||||
pub async fn webhook_trigger_handler(
|
pub async fn webhook_trigger_handler(
|
||||||
State(state): State<Arc<GatewayState>>,
|
State(state): State<Arc<GatewayState>>,
|
||||||
Path(path): Path<String>,
|
Path(path): Path<String>,
|
||||||
headers: HeaderMap,
|
headers: HeaderMap,
|
||||||
) -> Result<Json<serde_json::Value>, (StatusCode, String)> {
|
|
||||||
fire_webhook_inner(state, &path, None, &headers).await
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Handle incoming webhook POST to `/api/webhooks/u/{user_id}/{path}`.
|
|
||||||
///
|
|
||||||
/// User-scoped variant for multi-tenant deployments. The `user_id` in the URL
|
|
||||||
/// restricts the routine lookup to that user only, preventing cross-user
|
|
||||||
/// webhook triggering even when paths collide.
|
|
||||||
pub async fn webhook_trigger_user_scoped_handler(
|
|
||||||
State(state): State<Arc<GatewayState>>,
|
|
||||||
Path((user_id, path)): Path<(String, String)>,
|
|
||||||
headers: HeaderMap,
|
|
||||||
) -> Result<Json<serde_json::Value>, (StatusCode, String)> {
|
|
||||||
fire_webhook_inner(state, &path, Some(&user_id), &headers).await
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Shared webhook logic for both scoped and unscoped endpoints.
|
|
||||||
async fn fire_webhook_inner(
|
|
||||||
state: Arc<GatewayState>,
|
|
||||||
path: &str,
|
|
||||||
user_id: Option<&str>,
|
|
||||||
headers: &HeaderMap,
|
|
||||||
) -> Result<Json<serde_json::Value>, (StatusCode, String)> {
|
) -> Result<Json<serde_json::Value>, (StatusCode, String)> {
|
||||||
// Rate limit check
|
// Rate limit check
|
||||||
if !state.webhook_rate_limiter.check() {
|
if !state.webhook_rate_limiter.check() {
|
||||||
@@ -99,9 +72,9 @@ async fn fire_webhook_inner(
|
|||||||
"Database not available".to_string(),
|
"Database not available".to_string(),
|
||||||
))?;
|
))?;
|
||||||
|
|
||||||
// Targeted query — when user_id is provided, restrict to that user's routines
|
// Targeted query instead of loading all routines
|
||||||
let routine = store
|
let routine = store
|
||||||
.get_webhook_routine_by_path(path, user_id)
|
.get_webhook_routine_by_path(&path)
|
||||||
.await
|
.await
|
||||||
.map_err(|e| (StatusCode::INTERNAL_SERVER_ERROR, e.to_string()))?
|
.map_err(|e| (StatusCode::INTERNAL_SERVER_ERROR, e.to_string()))?
|
||||||
.ok_or((
|
.ok_or((
|
||||||
@@ -126,7 +99,7 @@ async fn fire_webhook_inner(
|
|||||||
))?
|
))?
|
||||||
};
|
};
|
||||||
|
|
||||||
let run_id = engine.fire_webhook(routine.id, path).await.map_err(|e| {
|
let run_id = engine.fire_webhook(routine.id, &path).await.map_err(|e| {
|
||||||
let status = match &e {
|
let status = match &e {
|
||||||
crate::error::RoutineError::NotFound { .. } => StatusCode::NOT_FOUND,
|
crate::error::RoutineError::NotFound { .. } => StatusCode::NOT_FOUND,
|
||||||
crate::error::RoutineError::Disabled { .. }
|
crate::error::RoutineError::Disabled { .. }
|
||||||
|
|||||||
+5
-489
@@ -414,11 +414,6 @@ pub async fn start_server(
|
|||||||
.route(
|
.route(
|
||||||
"/api/webhooks/{path}",
|
"/api/webhooks/{path}",
|
||||||
post(crate::channels::web::handlers::webhooks::webhook_trigger_handler),
|
post(crate::channels::web::handlers::webhooks::webhook_trigger_handler),
|
||||||
)
|
|
||||||
// User-scoped webhook endpoint for multi-tenant isolation
|
|
||||||
.route(
|
|
||||||
"/api/webhooks/u/{user_id}/{path}",
|
|
||||||
post(crate::channels::web::handlers::webhooks::webhook_trigger_user_scoped_handler),
|
|
||||||
);
|
);
|
||||||
|
|
||||||
// Protected routes (require auth)
|
// Protected routes (require auth)
|
||||||
@@ -836,10 +831,10 @@ async fn oauth_callback_handler(
|
|||||||
|
|
||||||
let result: Result<(), String> = async {
|
let result: Result<(), String> = async {
|
||||||
let token_response = if let Some(proxy_url) = &exchange_proxy_url {
|
let token_response = if let Some(proxy_url) = &exchange_proxy_url {
|
||||||
let oauth_proxy_auth_token = flow.oauth_proxy_auth_token().unwrap_or_default();
|
let gateway_token = flow.gateway_token.as_deref().unwrap_or_default();
|
||||||
oauth_defaults::exchange_via_proxy(oauth_defaults::ProxyTokenExchangeRequest {
|
oauth_defaults::exchange_via_proxy(oauth_defaults::ProxyTokenExchangeRequest {
|
||||||
proxy_url,
|
proxy_url,
|
||||||
gateway_token: oauth_proxy_auth_token,
|
gateway_token,
|
||||||
token_url: &flow.token_url,
|
token_url: &flow.token_url,
|
||||||
client_id: &flow.client_id,
|
client_id: &flow.client_id,
|
||||||
client_secret: flow.client_secret.as_deref(),
|
client_secret: flow.client_secret.as_deref(),
|
||||||
@@ -1177,31 +1172,11 @@ async fn slack_relay_oauth_callback_handler(
|
|||||||
|
|
||||||
// Store team_id in settings
|
// Store team_id in settings
|
||||||
let team_id_key = format!("relay:{}:team_id", DEFAULT_RELAY_NAME);
|
let team_id_key = format!("relay:{}:team_id", DEFAULT_RELAY_NAME);
|
||||||
tracing::info!(
|
let _ = store
|
||||||
relay = DEFAULT_RELAY_NAME,
|
|
||||||
owner_id = %state.owner_id,
|
|
||||||
team_id_key = %team_id_key,
|
|
||||||
"relay OAuth callback: storing team_id in settings"
|
|
||||||
);
|
|
||||||
store
|
|
||||||
.set_setting(&state.owner_id, &team_id_key, &serde_json::json!(team_id))
|
.set_setting(&state.owner_id, &team_id_key, &serde_json::json!(team_id))
|
||||||
.await
|
.await;
|
||||||
.map_err(|e| {
|
|
||||||
tracing::error!(
|
|
||||||
relay = DEFAULT_RELAY_NAME,
|
|
||||||
owner_id = %state.owner_id,
|
|
||||||
error = %e,
|
|
||||||
"relay OAuth callback: failed to persist team_id to settings store"
|
|
||||||
);
|
|
||||||
format!("Failed to persist relay team_id: {e}")
|
|
||||||
})?;
|
|
||||||
|
|
||||||
// Activate the relay channel
|
// Activate the relay channel
|
||||||
tracing::info!(
|
|
||||||
relay = DEFAULT_RELAY_NAME,
|
|
||||||
owner_id = %state.owner_id,
|
|
||||||
"relay OAuth callback: activating relay channel"
|
|
||||||
);
|
|
||||||
ext_mgr
|
ext_mgr
|
||||||
.activate_stored_relay(DEFAULT_RELAY_NAME, &state.owner_id)
|
.activate_stored_relay(DEFAULT_RELAY_NAME, &state.owner_id)
|
||||||
.await
|
.await
|
||||||
@@ -2201,11 +2176,6 @@ async fn extensions_activate_handler(
|
|||||||
AuthenticatedUser(user): AuthenticatedUser,
|
AuthenticatedUser(user): AuthenticatedUser,
|
||||||
Path(name): Path<String>,
|
Path(name): Path<String>,
|
||||||
) -> Result<Json<ActionResponse>, (StatusCode, String)> {
|
) -> Result<Json<ActionResponse>, (StatusCode, String)> {
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
user_id = %user.user_id,
|
|
||||||
"extensions_activate_handler: received activate request"
|
|
||||||
);
|
|
||||||
let ext_mgr = state.extension_manager.as_ref().ok_or((
|
let ext_mgr = state.extension_manager.as_ref().ok_or((
|
||||||
StatusCode::NOT_IMPLEMENTED,
|
StatusCode::NOT_IMPLEMENTED,
|
||||||
"Extension manager not available (secrets store required)".to_string(),
|
"Extension manager not available (secrets store required)".to_string(),
|
||||||
@@ -2213,10 +2183,6 @@ async fn extensions_activate_handler(
|
|||||||
|
|
||||||
match ext_mgr.activate(&name, &user.user_id).await {
|
match ext_mgr.activate(&name, &user.user_id).await {
|
||||||
Ok(result) => {
|
Ok(result) => {
|
||||||
tracing::info!(
|
|
||||||
extension = %name,
|
|
||||||
"extensions_activate_handler: activation succeeded"
|
|
||||||
);
|
|
||||||
// Activation loaded the WASM module. Check if the tool needs
|
// Activation loaded the WASM module. Check if the tool needs
|
||||||
// OAuth scope expansion (e.g., adding google-docs when gmail
|
// OAuth scope expansion (e.g., adding google-docs when gmail
|
||||||
// already has a token but missing the documents scope).
|
// already has a token but missing the documents scope).
|
||||||
@@ -2235,13 +2201,6 @@ async fn extensions_activate_handler(
|
|||||||
crate::extensions::ExtensionError::AuthRequired
|
crate::extensions::ExtensionError::AuthRequired
|
||||||
);
|
);
|
||||||
|
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
error = %activate_err,
|
|
||||||
needs_auth = needs_auth,
|
|
||||||
"extensions_activate_handler: activation failed, attempting auth fallback"
|
|
||||||
);
|
|
||||||
|
|
||||||
if !needs_auth {
|
if !needs_auth {
|
||||||
return Ok(Json(ActionResponse::fail(activate_err.to_string())));
|
return Ok(Json(ActionResponse::fail(activate_err.to_string())));
|
||||||
}
|
}
|
||||||
@@ -2249,21 +2208,10 @@ async fn extensions_activate_handler(
|
|||||||
// Activation failed due to auth; try authenticating first.
|
// Activation failed due to auth; try authenticating first.
|
||||||
match ext_mgr.auth(&name, &user.user_id).await {
|
match ext_mgr.auth(&name, &user.user_id).await {
|
||||||
Ok(auth_result) if auth_result.is_authenticated() => {
|
Ok(auth_result) if auth_result.is_authenticated() => {
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
"extensions_activate_handler: auth reports authenticated, retrying activate"
|
|
||||||
);
|
|
||||||
// Auth succeeded, retry activation.
|
// Auth succeeded, retry activation.
|
||||||
match ext_mgr.activate(&name, &user.user_id).await {
|
match ext_mgr.activate(&name, &user.user_id).await {
|
||||||
Ok(result) => Ok(Json(ActionResponse::ok(result.message))),
|
Ok(result) => Ok(Json(ActionResponse::ok(result.message))),
|
||||||
Err(e) => {
|
Err(e) => Ok(Json(ActionResponse::fail(e.to_string()))),
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
error = %e,
|
|
||||||
"extensions_activate_handler: retry after auth still failed"
|
|
||||||
);
|
|
||||||
Ok(Json(ActionResponse::fail(e.to_string())))
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
Ok(auth_result) => {
|
Ok(auth_result) => {
|
||||||
@@ -3057,160 +3005,6 @@ mod tests {
|
|||||||
.with_state(state)
|
.with_state(state)
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Clone, Debug)]
|
|
||||||
struct RecordedOauthProxyRequest {
|
|
||||||
authorization: Option<String>,
|
|
||||||
form: std::collections::HashMap<String, String>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Clone)]
|
|
||||||
struct MockOauthProxyState {
|
|
||||||
requests: Arc<tokio::sync::Mutex<Vec<RecordedOauthProxyRequest>>>,
|
|
||||||
}
|
|
||||||
|
|
||||||
struct MockOauthProxyServer {
|
|
||||||
addr: std::net::SocketAddr,
|
|
||||||
requests: Arc<tokio::sync::Mutex<Vec<RecordedOauthProxyRequest>>>,
|
|
||||||
shutdown_tx: Option<tokio::sync::oneshot::Sender<()>>,
|
|
||||||
server_task: Option<tokio::task::JoinHandle<()>>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl MockOauthProxyServer {
|
|
||||||
async fn start() -> Self {
|
|
||||||
async fn exchange_handler(
|
|
||||||
State(state): State<MockOauthProxyState>,
|
|
||||||
headers: axum::http::HeaderMap,
|
|
||||||
axum::Form(form): axum::Form<std::collections::HashMap<String, String>>,
|
|
||||||
) -> Json<serde_json::Value> {
|
|
||||||
state.requests.lock().await.push(RecordedOauthProxyRequest {
|
|
||||||
authorization: headers
|
|
||||||
.get(axum::http::header::AUTHORIZATION)
|
|
||||||
.and_then(|value| value.to_str().ok())
|
|
||||||
.map(str::to_string),
|
|
||||||
form,
|
|
||||||
});
|
|
||||||
Json(serde_json::json!({
|
|
||||||
"access_token": "proxy-access-token",
|
|
||||||
"refresh_token": "proxy-refresh-token",
|
|
||||||
"expires_in": 7200
|
|
||||||
}))
|
|
||||||
}
|
|
||||||
|
|
||||||
let requests = Arc::new(tokio::sync::Mutex::new(Vec::new()));
|
|
||||||
let listener = tokio::net::TcpListener::bind("127.0.0.1:0")
|
|
||||||
.await
|
|
||||||
.expect("bind mock oauth proxy");
|
|
||||||
let addr = listener.local_addr().expect("mock oauth proxy addr");
|
|
||||||
let app = Router::new()
|
|
||||||
.route("/oauth/exchange", post(exchange_handler))
|
|
||||||
.with_state(MockOauthProxyState {
|
|
||||||
requests: Arc::clone(&requests),
|
|
||||||
});
|
|
||||||
let (shutdown_tx, shutdown_rx) = tokio::sync::oneshot::channel::<()>();
|
|
||||||
let server_task = tokio::spawn(async move {
|
|
||||||
let _ = axum::serve(listener, app)
|
|
||||||
.with_graceful_shutdown(async {
|
|
||||||
let _ = shutdown_rx.await;
|
|
||||||
})
|
|
||||||
.await;
|
|
||||||
});
|
|
||||||
|
|
||||||
Self {
|
|
||||||
addr,
|
|
||||||
requests,
|
|
||||||
shutdown_tx: Some(shutdown_tx),
|
|
||||||
server_task: Some(server_task),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn base_url(&self) -> String {
|
|
||||||
format!("http://{}", self.addr)
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn requests(&self) -> Vec<RecordedOauthProxyRequest> {
|
|
||||||
self.requests.lock().await.clone()
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn shutdown(mut self) {
|
|
||||||
if let Some(tx) = self.shutdown_tx.take() {
|
|
||||||
let _ = tx.send(());
|
|
||||||
}
|
|
||||||
if let Some(task) = self.server_task.take() {
|
|
||||||
let _ = task.await;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
impl Drop for MockOauthProxyServer {
|
|
||||||
fn drop(&mut self) {
|
|
||||||
if let Some(tx) = self.shutdown_tx.take() {
|
|
||||||
let _ = tx.send(());
|
|
||||||
}
|
|
||||||
if let Some(task) = self.server_task.take() {
|
|
||||||
task.abort();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
struct EnvVarGuard {
|
|
||||||
key: &'static str,
|
|
||||||
original: Option<String>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl Drop for EnvVarGuard {
|
|
||||||
fn drop(&mut self) {
|
|
||||||
// SAFETY: Tests use lock_env() to serialize environment access.
|
|
||||||
unsafe {
|
|
||||||
if let Some(ref value) = self.original {
|
|
||||||
std::env::set_var(self.key, value);
|
|
||||||
} else {
|
|
||||||
std::env::remove_var(self.key);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn set_env_var(key: &'static str, value: Option<&str>) -> EnvVarGuard {
|
|
||||||
let original = std::env::var(key).ok();
|
|
||||||
// SAFETY: Tests use lock_env() to serialize environment access.
|
|
||||||
unsafe {
|
|
||||||
if let Some(value) = value {
|
|
||||||
std::env::set_var(key, value);
|
|
||||||
} else {
|
|
||||||
std::env::remove_var(key);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
EnvVarGuard { key, original }
|
|
||||||
}
|
|
||||||
|
|
||||||
fn fresh_pending_oauth_flow(
|
|
||||||
secrets: Arc<dyn crate::secrets::SecretsStore + Send + Sync>,
|
|
||||||
sse_manager: Option<Arc<SseManager>>,
|
|
||||||
oauth_proxy_auth_token: Option<String>,
|
|
||||||
) -> crate::cli::oauth_defaults::PendingOAuthFlow {
|
|
||||||
crate::cli::oauth_defaults::PendingOAuthFlow {
|
|
||||||
extension_name: "test_tool".to_string(),
|
|
||||||
display_name: "Test Tool".to_string(),
|
|
||||||
token_url: "https://example.com/token".to_string(),
|
|
||||||
client_id: "client123".to_string(),
|
|
||||||
client_secret: None,
|
|
||||||
redirect_uri: "https://example.com/oauth/callback".to_string(),
|
|
||||||
code_verifier: Some("test-code-verifier".to_string()),
|
|
||||||
access_token_field: "access_token".to_string(),
|
|
||||||
secret_name: "test_token".to_string(),
|
|
||||||
provider: Some("google".to_string()),
|
|
||||||
validation_endpoint: None,
|
|
||||||
scopes: vec!["email".to_string()],
|
|
||||||
user_id: "test".to_string(),
|
|
||||||
secrets,
|
|
||||||
sse_manager,
|
|
||||||
gateway_token: oauth_proxy_auth_token,
|
|
||||||
token_exchange_extra_params: std::collections::HashMap::new(),
|
|
||||||
client_id_secret_name: None,
|
|
||||||
created_at: std::time::Instant::now(),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_extensions_setup_submit_returns_failure_when_not_activated() {
|
async fn test_extensions_setup_submit_returns_failure_when_not_activated() {
|
||||||
use axum::body::Body;
|
use axum::body::Body;
|
||||||
@@ -3868,284 +3662,6 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_oauth_callback_accepts_versioned_hosted_state_without_instance_name() {
|
|
||||||
use axum::body::Body;
|
|
||||||
use tower::ServiceExt;
|
|
||||||
|
|
||||||
let secrets: Arc<dyn crate::secrets::SecretsStore + Send + Sync> =
|
|
||||||
Arc::new(crate::secrets::InMemorySecretsStore::new(Arc::new(
|
|
||||||
crate::secrets::SecretsCrypto::new(secrecy::SecretString::from(
|
|
||||||
TEST_GATEWAY_CRYPTO_KEY.to_string(),
|
|
||||||
))
|
|
||||||
.expect("crypto"),
|
|
||||||
)));
|
|
||||||
let (ext_mgr, _wasm_tools_dir, _wasm_channels_dir) = test_ext_mgr(secrets.clone());
|
|
||||||
|
|
||||||
let Some(created_at) = expired_flow_created_at() else {
|
|
||||||
eprintln!(
|
|
||||||
"Skipping versioned OAuth state without instance test: monotonic uptime below expiry window"
|
|
||||||
);
|
|
||||||
return;
|
|
||||||
};
|
|
||||||
let flow = crate::cli::oauth_defaults::PendingOAuthFlow {
|
|
||||||
extension_name: "test_tool".to_string(),
|
|
||||||
display_name: "Test Tool".to_string(),
|
|
||||||
token_url: "https://example.com/token".to_string(),
|
|
||||||
client_id: "client123".to_string(),
|
|
||||||
client_secret: None,
|
|
||||||
redirect_uri: "https://example.com/oauth/callback".to_string(),
|
|
||||||
code_verifier: None,
|
|
||||||
access_token_field: "access_token".to_string(),
|
|
||||||
secret_name: "test_token".to_string(),
|
|
||||||
provider: None,
|
|
||||||
validation_endpoint: None,
|
|
||||||
scopes: vec![],
|
|
||||||
user_id: "test".to_string(),
|
|
||||||
secrets,
|
|
||||||
sse_manager: None,
|
|
||||||
gateway_token: None,
|
|
||||||
token_exchange_extra_params: std::collections::HashMap::new(),
|
|
||||||
client_id_secret_name: None,
|
|
||||||
created_at,
|
|
||||||
};
|
|
||||||
|
|
||||||
ext_mgr
|
|
||||||
.pending_oauth_flows()
|
|
||||||
.write()
|
|
||||||
.await
|
|
||||||
.insert("test_nonce".to_string(), flow);
|
|
||||||
|
|
||||||
let state = test_gateway_state(Some(ext_mgr.clone()));
|
|
||||||
let app = test_oauth_router(state);
|
|
||||||
let versioned_state =
|
|
||||||
crate::cli::oauth_defaults::encode_hosted_oauth_state("test_nonce", None);
|
|
||||||
|
|
||||||
let req = axum::http::Request::builder()
|
|
||||||
.uri(format!(
|
|
||||||
"/oauth/callback?code=fake_code&state={}",
|
|
||||||
urlencoding::encode(&versioned_state)
|
|
||||||
))
|
|
||||||
.body(Body::empty())
|
|
||||||
.expect("request");
|
|
||||||
|
|
||||||
let resp = ServiceExt::<axum::http::Request<Body>>::oneshot(app, req)
|
|
||||||
.await
|
|
||||||
.expect("response");
|
|
||||||
assert_eq!(resp.status(), StatusCode::OK);
|
|
||||||
|
|
||||||
let body = axum::body::to_bytes(resp.into_body(), 1024 * 64)
|
|
||||||
.await
|
|
||||||
.expect("body");
|
|
||||||
let html = String::from_utf8_lossy(&body);
|
|
||||||
assert!(html.contains("Authorization Failed"));
|
|
||||||
assert!(
|
|
||||||
ext_mgr
|
|
||||||
.pending_oauth_flows()
|
|
||||||
.read()
|
|
||||||
.await
|
|
||||||
.get("test_nonce")
|
|
||||||
.is_none()
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[allow(clippy::await_holding_lock)]
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_oauth_callback_happy_path_with_gateway_token_fallback() {
|
|
||||||
use axum::body::Body;
|
|
||||||
use tower::ServiceExt;
|
|
||||||
|
|
||||||
let proxy = MockOauthProxyServer::start().await;
|
|
||||||
// Keep the process-wide env locked for the full callback so the handler
|
|
||||||
// sees a stable proxy URL/token configuration throughout the test.
|
|
||||||
let _env_guard = crate::config::helpers::lock_env();
|
|
||||||
let _exchange_url_guard =
|
|
||||||
set_env_var("IRONCLAW_OAUTH_EXCHANGE_URL", Some(&proxy.base_url()));
|
|
||||||
let _proxy_auth_guard = set_env_var("IRONCLAW_OAUTH_PROXY_AUTH_TOKEN", None);
|
|
||||||
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", Some("gateway-test-token"));
|
|
||||||
|
|
||||||
let secrets = test_secrets_store();
|
|
||||||
let (ext_mgr, _wasm_tools_dir, _wasm_channels_dir) = test_ext_mgr(Arc::clone(&secrets));
|
|
||||||
let sse_mgr = Arc::new(SseManager::new());
|
|
||||||
let mut receiver = sse_mgr.sender().subscribe();
|
|
||||||
let flow = fresh_pending_oauth_flow(
|
|
||||||
Arc::clone(&secrets),
|
|
||||||
Some(Arc::clone(&sse_mgr)),
|
|
||||||
crate::cli::oauth_defaults::oauth_proxy_auth_token(),
|
|
||||||
);
|
|
||||||
|
|
||||||
ext_mgr
|
|
||||||
.pending_oauth_flows()
|
|
||||||
.write()
|
|
||||||
.await
|
|
||||||
.insert("test_nonce".to_string(), flow);
|
|
||||||
|
|
||||||
let state = test_gateway_state(Some(ext_mgr.clone()));
|
|
||||||
let app = test_oauth_router(state);
|
|
||||||
let versioned_state =
|
|
||||||
crate::cli::oauth_defaults::encode_hosted_oauth_state("test_nonce", Some("myinstance"));
|
|
||||||
|
|
||||||
let req = axum::http::Request::builder()
|
|
||||||
.uri(format!(
|
|
||||||
"/oauth/callback?code=fake_code&state={}",
|
|
||||||
urlencoding::encode(&versioned_state)
|
|
||||||
))
|
|
||||||
.body(Body::empty())
|
|
||||||
.expect("request");
|
|
||||||
|
|
||||||
let resp = ServiceExt::<axum::http::Request<Body>>::oneshot(app, req)
|
|
||||||
.await
|
|
||||||
.expect("response");
|
|
||||||
assert_eq!(resp.status(), StatusCode::OK);
|
|
||||||
|
|
||||||
let body = axum::body::to_bytes(resp.into_body(), 1024 * 64)
|
|
||||||
.await
|
|
||||||
.expect("body");
|
|
||||||
let html = String::from_utf8_lossy(&body);
|
|
||||||
assert!(html.contains("Test Tool Connected"));
|
|
||||||
|
|
||||||
let requests = proxy.requests().await;
|
|
||||||
assert_eq!(requests.len(), 1);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].authorization.as_deref(),
|
|
||||||
Some("Bearer gateway-test-token")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("code").map(String::as_str),
|
|
||||||
Some("fake_code")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("code_verifier").map(String::as_str),
|
|
||||||
Some("test-code-verifier")
|
|
||||||
);
|
|
||||||
|
|
||||||
let access_token = secrets
|
|
||||||
.get_decrypted("test", "test_token")
|
|
||||||
.await
|
|
||||||
.expect("access token stored");
|
|
||||||
assert_eq!(access_token.expose(), "proxy-access-token");
|
|
||||||
|
|
||||||
let refresh_token = secrets
|
|
||||||
.get_decrypted("test", "test_token_refresh_token")
|
|
||||||
.await
|
|
||||||
.expect("refresh token stored");
|
|
||||||
assert_eq!(refresh_token.expose(), "proxy-refresh-token");
|
|
||||||
|
|
||||||
match receiver.recv().await.expect("auth_completed event").event {
|
|
||||||
crate::channels::web::types::AppEvent::AuthCompleted {
|
|
||||||
extension_name,
|
|
||||||
success,
|
|
||||||
..
|
|
||||||
} => {
|
|
||||||
assert_eq!(extension_name, "test_tool");
|
|
||||||
assert!(success, "OAuth callback should broadcast success");
|
|
||||||
}
|
|
||||||
event => panic!("expected AuthCompleted event, got {event:?}"),
|
|
||||||
}
|
|
||||||
|
|
||||||
proxy.shutdown().await;
|
|
||||||
}
|
|
||||||
|
|
||||||
#[allow(clippy::await_holding_lock)]
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_oauth_callback_happy_path_with_dedicated_proxy_auth_token() {
|
|
||||||
use axum::body::Body;
|
|
||||||
use tower::ServiceExt;
|
|
||||||
|
|
||||||
let proxy = MockOauthProxyServer::start().await;
|
|
||||||
// Keep the process-wide env locked for the full callback so the handler
|
|
||||||
// sees a stable proxy URL/token configuration throughout the test.
|
|
||||||
let _env_guard = crate::config::helpers::lock_env();
|
|
||||||
let _exchange_url_guard =
|
|
||||||
set_env_var("IRONCLAW_OAUTH_EXCHANGE_URL", Some(&proxy.base_url()));
|
|
||||||
let _proxy_auth_guard = set_env_var(
|
|
||||||
"IRONCLAW_OAUTH_PROXY_AUTH_TOKEN",
|
|
||||||
Some("shared-oauth-proxy-secret"),
|
|
||||||
);
|
|
||||||
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", None);
|
|
||||||
|
|
||||||
let secrets = test_secrets_store();
|
|
||||||
let (ext_mgr, _wasm_tools_dir, _wasm_channels_dir) = test_ext_mgr(Arc::clone(&secrets));
|
|
||||||
let sse_mgr = Arc::new(SseManager::new());
|
|
||||||
let mut receiver = sse_mgr.sender().subscribe();
|
|
||||||
let flow = fresh_pending_oauth_flow(
|
|
||||||
Arc::clone(&secrets),
|
|
||||||
Some(Arc::clone(&sse_mgr)),
|
|
||||||
crate::cli::oauth_defaults::oauth_proxy_auth_token(),
|
|
||||||
);
|
|
||||||
|
|
||||||
ext_mgr
|
|
||||||
.pending_oauth_flows()
|
|
||||||
.write()
|
|
||||||
.await
|
|
||||||
.insert("test_nonce".to_string(), flow);
|
|
||||||
|
|
||||||
let state = test_gateway_state(Some(ext_mgr.clone()));
|
|
||||||
let app = test_oauth_router(state);
|
|
||||||
let versioned_state =
|
|
||||||
crate::cli::oauth_defaults::encode_hosted_oauth_state("test_nonce", None);
|
|
||||||
|
|
||||||
let req = axum::http::Request::builder()
|
|
||||||
.uri(format!(
|
|
||||||
"/oauth/callback?code=fake_code&state={}",
|
|
||||||
urlencoding::encode(&versioned_state)
|
|
||||||
))
|
|
||||||
.body(Body::empty())
|
|
||||||
.expect("request");
|
|
||||||
|
|
||||||
let resp = ServiceExt::<axum::http::Request<Body>>::oneshot(app, req)
|
|
||||||
.await
|
|
||||||
.expect("response");
|
|
||||||
assert_eq!(resp.status(), StatusCode::OK);
|
|
||||||
|
|
||||||
let body = axum::body::to_bytes(resp.into_body(), 1024 * 64)
|
|
||||||
.await
|
|
||||||
.expect("body");
|
|
||||||
let html = String::from_utf8_lossy(&body);
|
|
||||||
assert!(html.contains("Test Tool Connected"));
|
|
||||||
|
|
||||||
let requests = proxy.requests().await;
|
|
||||||
assert_eq!(requests.len(), 1);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].authorization.as_deref(),
|
|
||||||
Some("Bearer shared-oauth-proxy-secret")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("code").map(String::as_str),
|
|
||||||
Some("fake_code")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("code_verifier").map(String::as_str),
|
|
||||||
Some("test-code-verifier")
|
|
||||||
);
|
|
||||||
|
|
||||||
let access_token = secrets
|
|
||||||
.get_decrypted("test", "test_token")
|
|
||||||
.await
|
|
||||||
.expect("access token stored");
|
|
||||||
assert_eq!(access_token.expose(), "proxy-access-token");
|
|
||||||
|
|
||||||
let refresh_token = secrets
|
|
||||||
.get_decrypted("test", "test_token_refresh_token")
|
|
||||||
.await
|
|
||||||
.expect("refresh token stored");
|
|
||||||
assert_eq!(refresh_token.expose(), "proxy-refresh-token");
|
|
||||||
|
|
||||||
match receiver.recv().await.expect("auth_completed event").event {
|
|
||||||
crate::channels::web::types::AppEvent::AuthCompleted {
|
|
||||||
extension_name,
|
|
||||||
success,
|
|
||||||
..
|
|
||||||
} => {
|
|
||||||
assert_eq!(extension_name, "test_tool");
|
|
||||||
assert!(success, "OAuth callback should broadcast success");
|
|
||||||
}
|
|
||||||
event => panic!("expected AuthCompleted event, got {event:?}"),
|
|
||||||
}
|
|
||||||
|
|
||||||
proxy.shutdown().await;
|
|
||||||
}
|
|
||||||
|
|
||||||
// --- Slack relay OAuth CSRF tests ---
|
// --- Slack relay OAuth CSRF tests ---
|
||||||
|
|
||||||
fn test_relay_oauth_router(state: Arc<GatewayState>) -> Router {
|
fn test_relay_oauth_router(state: Arc<GatewayState>) -> Router {
|
||||||
|
|||||||
+5
-184
@@ -473,8 +473,7 @@ pub struct PendingOAuthFlow {
|
|||||||
pub secrets: Arc<dyn SecretsStore + Send + Sync>,
|
pub secrets: Arc<dyn SecretsStore + Send + Sync>,
|
||||||
/// SSE broadcast manager for notifying the web UI.
|
/// SSE broadcast manager for notifying the web UI.
|
||||||
pub sse_manager: Option<Arc<crate::channels::web::sse::SseManager>>,
|
pub sse_manager: Option<Arc<crate::channels::web::sse::SseManager>>,
|
||||||
/// OAuth proxy auth token for authenticating with the hosted token exchange proxy.
|
/// Gateway auth token for authenticating with the platform token exchange proxy.
|
||||||
/// Kept as `gateway_token` for public API compatibility.
|
|
||||||
pub gateway_token: Option<String>,
|
pub gateway_token: Option<String>,
|
||||||
/// Additional form params for the token exchange request.
|
/// Additional form params for the token exchange request.
|
||||||
/// Used for provider-specific requirements such as RFC 8707 `resource`.
|
/// Used for provider-specific requirements such as RFC 8707 `resource`.
|
||||||
@@ -497,12 +496,6 @@ impl std::fmt::Debug for PendingOAuthFlow {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl PendingOAuthFlow {
|
|
||||||
pub fn oauth_proxy_auth_token(&self) -> Option<&str> {
|
|
||||||
self.gateway_token.as_deref()
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Thread-safe registry of pending OAuth flows, keyed by CSRF `state` parameter.
|
/// Thread-safe registry of pending OAuth flows, keyed by CSRF `state` parameter.
|
||||||
pub type PendingOAuthRegistry = Arc<RwLock<HashMap<String, PendingOAuthFlow>>>;
|
pub type PendingOAuthRegistry = Arc<RwLock<HashMap<String, PendingOAuthFlow>>>;
|
||||||
|
|
||||||
@@ -536,22 +529,6 @@ pub fn exchange_proxy_url() -> Option<String> {
|
|||||||
.filter(|url| !url.is_empty())
|
.filter(|url| !url.is_empty())
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Returns the configured OAuth proxy auth token, if any.
|
|
||||||
///
|
|
||||||
/// New hosted infra can inject a dedicated shared proxy secret via
|
|
||||||
/// `IRONCLAW_OAUTH_PROXY_AUTH_TOKEN`. Existing hosted instances continue to
|
|
||||||
/// work by falling back to `GATEWAY_AUTH_TOKEN`.
|
|
||||||
pub fn oauth_proxy_auth_token() -> Option<String> {
|
|
||||||
fn normalized_env_value(key: &str) -> Option<String> {
|
|
||||||
crate::config::helpers::env_or_override(key)
|
|
||||||
.map(|value| value.trim().to_string())
|
|
||||||
.filter(|value| !value.is_empty())
|
|
||||||
}
|
|
||||||
|
|
||||||
normalized_env_value("IRONCLAW_OAUTH_PROXY_AUTH_TOKEN")
|
|
||||||
.or_else(|| normalized_env_value("GATEWAY_AUTH_TOKEN"))
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Maximum age for pending OAuth flows (5 minutes, matching TCP listener timeout).
|
/// Maximum age for pending OAuth flows (5 minutes, matching TCP listener timeout).
|
||||||
pub const OAUTH_FLOW_EXPIRY: Duration = Duration::from_secs(300);
|
pub const OAUTH_FLOW_EXPIRY: Duration = Duration::from_secs(300);
|
||||||
|
|
||||||
@@ -697,8 +674,6 @@ pub fn strip_instance_prefix(state: &str) -> &str {
|
|||||||
|
|
||||||
pub struct ProxyTokenExchangeRequest<'a> {
|
pub struct ProxyTokenExchangeRequest<'a> {
|
||||||
pub proxy_url: &'a str,
|
pub proxy_url: &'a str,
|
||||||
/// OAuth proxy auth token.
|
|
||||||
/// Kept as `gateway_token` for public API compatibility.
|
|
||||||
pub gateway_token: &'a str,
|
pub gateway_token: &'a str,
|
||||||
pub token_url: &'a str,
|
pub token_url: &'a str,
|
||||||
pub client_id: &'a str,
|
pub client_id: &'a str,
|
||||||
@@ -712,8 +687,6 @@ pub struct ProxyTokenExchangeRequest<'a> {
|
|||||||
|
|
||||||
pub struct ProxyRefreshTokenRequest<'a> {
|
pub struct ProxyRefreshTokenRequest<'a> {
|
||||||
pub proxy_url: &'a str,
|
pub proxy_url: &'a str,
|
||||||
/// OAuth proxy auth token.
|
|
||||||
/// Kept as `gateway_token` for public API compatibility.
|
|
||||||
pub gateway_token: &'a str,
|
pub gateway_token: &'a str,
|
||||||
pub token_url: &'a str,
|
pub token_url: &'a str,
|
||||||
pub client_id: &'a str,
|
pub client_id: &'a str,
|
||||||
@@ -756,7 +729,7 @@ fn oauth_token_response_from_json(
|
|||||||
|
|
||||||
/// Exchange an OAuth authorization code via the platform's token exchange proxy.
|
/// Exchange an OAuth authorization code via the platform's token exchange proxy.
|
||||||
///
|
///
|
||||||
/// Authenticated via an OAuth proxy auth token (Bearer header). The caller may
|
/// Authenticated via the gateway auth token (Bearer header). The caller may
|
||||||
/// either rely on proxy-side secret lookup or forward a `client_secret` when
|
/// either rely on proxy-side secret lookup or forward a `client_secret` when
|
||||||
/// the provider requires it.
|
/// the provider requires it.
|
||||||
///
|
///
|
||||||
@@ -768,7 +741,7 @@ pub async fn exchange_via_proxy(
|
|||||||
) -> Result<OAuthTokenResponse, OAuthCallbackError> {
|
) -> Result<OAuthTokenResponse, OAuthCallbackError> {
|
||||||
if request.gateway_token.is_empty() {
|
if request.gateway_token.is_empty() {
|
||||||
return Err(OAuthCallbackError::Io(
|
return Err(OAuthCallbackError::Io(
|
||||||
"OAuth proxy auth token is required for proxy token exchange".to_string(),
|
"Gateway auth token is required for proxy token exchange".to_string(),
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
let exchange_url = format!("{}/oauth/exchange", request.proxy_url.trim_end_matches('/'));
|
let exchange_url = format!("{}/oauth/exchange", request.proxy_url.trim_end_matches('/'));
|
||||||
@@ -823,7 +796,7 @@ pub async fn exchange_via_proxy(
|
|||||||
|
|
||||||
/// Refresh an OAuth access token via the platform's token refresh proxy.
|
/// Refresh an OAuth access token via the platform's token refresh proxy.
|
||||||
///
|
///
|
||||||
/// Authenticated via an OAuth proxy auth token (Bearer header). The caller may
|
/// Authenticated via the gateway auth token (Bearer header). The caller may
|
||||||
/// either rely on proxy-side secret lookup or forward a `client_secret` when
|
/// either rely on proxy-side secret lookup or forward a `client_secret` when
|
||||||
/// the provider requires it.
|
/// the provider requires it.
|
||||||
pub async fn refresh_token_via_proxy(
|
pub async fn refresh_token_via_proxy(
|
||||||
@@ -831,7 +804,7 @@ pub async fn refresh_token_via_proxy(
|
|||||||
) -> Result<OAuthTokenResponse, OAuthCallbackError> {
|
) -> Result<OAuthTokenResponse, OAuthCallbackError> {
|
||||||
if request.gateway_token.is_empty() {
|
if request.gateway_token.is_empty() {
|
||||||
return Err(OAuthCallbackError::Io(
|
return Err(OAuthCallbackError::Io(
|
||||||
"OAuth proxy auth token is required for proxy token refresh".to_string(),
|
"Gateway auth token is required for proxy token refresh".to_string(),
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1037,37 +1010,6 @@ mod tests {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
struct EnvVarGuard {
|
|
||||||
key: &'static str,
|
|
||||||
original: Option<String>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl Drop for EnvVarGuard {
|
|
||||||
fn drop(&mut self) {
|
|
||||||
// SAFETY: Under ENV_MUTEX, no concurrent env access.
|
|
||||||
unsafe {
|
|
||||||
if let Some(ref value) = self.original {
|
|
||||||
std::env::set_var(self.key, value);
|
|
||||||
} else {
|
|
||||||
std::env::remove_var(self.key);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn set_env_var(key: &'static str, value: Option<&str>) -> EnvVarGuard {
|
|
||||||
let original = std::env::var(key).ok();
|
|
||||||
// SAFETY: Under ENV_MUTEX, no concurrent env access.
|
|
||||||
unsafe {
|
|
||||||
if let Some(value) = value {
|
|
||||||
std::env::set_var(key, value);
|
|
||||||
} else {
|
|
||||||
std::env::remove_var(key);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
EnvVarGuard { key, original }
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_hosted_proxy_client_secret_suppresses_builtin_secret() {
|
fn test_hosted_proxy_client_secret_suppresses_builtin_secret() {
|
||||||
let builtin = builtin_credentials("google_oauth_token").expect("google builtin creds");
|
let builtin = builtin_credentials("google_oauth_token").expect("google builtin creds");
|
||||||
@@ -1088,79 +1030,6 @@ mod tests {
|
|||||||
assert_eq!(result, client_secret);
|
assert_eq!(result, client_secret);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_exchange_via_proxy_sends_auth_and_form() {
|
|
||||||
let server = MockProxyServer::start().await;
|
|
||||||
let mut extra_token_params = HashMap::new();
|
|
||||||
extra_token_params.insert("resource".to_string(), "https://mcp.notion.com".to_string());
|
|
||||||
|
|
||||||
let response = super::exchange_via_proxy(super::ProxyTokenExchangeRequest {
|
|
||||||
proxy_url: &server.base_url(),
|
|
||||||
gateway_token: "shared-oauth-proxy-secret",
|
|
||||||
code: "auth-code-123",
|
|
||||||
redirect_uri: "https://oauth.example.com/oauth/callback",
|
|
||||||
token_url: "https://oauth2.googleapis.com/token",
|
|
||||||
client_id: TEST_OAUTH_CLIENT_ID,
|
|
||||||
client_secret: Some(TEST_OAUTH_CLIENT_SECRET),
|
|
||||||
access_token_field: "access_token",
|
|
||||||
code_verifier: Some("code-verifier-123"),
|
|
||||||
extra_token_params: &extra_token_params,
|
|
||||||
})
|
|
||||||
.await
|
|
||||||
.expect("proxy exchange succeeds");
|
|
||||||
|
|
||||||
assert_eq!(response.access_token, "proxy-access-token");
|
|
||||||
assert_eq!(
|
|
||||||
response.refresh_token.as_deref(),
|
|
||||||
Some("proxy-refresh-token")
|
|
||||||
);
|
|
||||||
assert_eq!(response.expires_in, Some(7200));
|
|
||||||
|
|
||||||
let requests = server.requests().await;
|
|
||||||
assert_eq!(requests.len(), 1);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].authorization.as_deref(),
|
|
||||||
Some("Bearer shared-oauth-proxy-secret")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("code").map(String::as_str),
|
|
||||||
Some("auth-code-123")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("redirect_uri").map(String::as_str),
|
|
||||||
Some("https://oauth.example.com/oauth/callback")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("token_url").map(String::as_str),
|
|
||||||
Some("https://oauth2.googleapis.com/token")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("client_id").map(String::as_str),
|
|
||||||
Some(TEST_OAUTH_CLIENT_ID)
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("client_secret").map(String::as_str),
|
|
||||||
Some(TEST_OAUTH_CLIENT_SECRET)
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0]
|
|
||||||
.form
|
|
||||||
.get("access_token_field")
|
|
||||||
.map(String::as_str),
|
|
||||||
Some("access_token")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("code_verifier").map(String::as_str),
|
|
||||||
Some("code-verifier-123")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
requests[0].form.get("resource").map(String::as_str),
|
|
||||||
Some("https://mcp.notion.com")
|
|
||||||
);
|
|
||||||
|
|
||||||
server.shutdown().await;
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_refresh_token_via_proxy_sends_auth_and_form() {
|
async fn test_refresh_token_via_proxy_sends_auth_and_form() {
|
||||||
let server = MockProxyServer::start().await;
|
let server = MockProxyServer::start().await;
|
||||||
@@ -1666,54 +1535,6 @@ mod tests {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_oauth_proxy_auth_token_prefers_dedicated_env() {
|
|
||||||
let _guard = lock_env();
|
|
||||||
let _proxy_guard = set_env_var(
|
|
||||||
"IRONCLAW_OAUTH_PROXY_AUTH_TOKEN",
|
|
||||||
Some("shared-proxy-secret"),
|
|
||||||
);
|
|
||||||
let _gateway_guard = set_env_var("GATEWAY_AUTH_TOKEN", Some("gateway-token"));
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
crate::cli::oauth_defaults::oauth_proxy_auth_token().as_deref(),
|
|
||||||
Some("shared-proxy-secret")
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_oauth_proxy_auth_token_falls_back_to_gateway_token() {
|
|
||||||
let _guard = lock_env();
|
|
||||||
let _proxy_guard = set_env_var("IRONCLAW_OAUTH_PROXY_AUTH_TOKEN", None);
|
|
||||||
let _gateway_guard = set_env_var("GATEWAY_AUTH_TOKEN", Some("gateway-token"));
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
crate::cli::oauth_defaults::oauth_proxy_auth_token().as_deref(),
|
|
||||||
Some("gateway-token")
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_oauth_proxy_auth_token_whitespace_dedicated_env_falls_back_to_gateway_token() {
|
|
||||||
let _guard = lock_env();
|
|
||||||
let _proxy_guard = set_env_var("IRONCLAW_OAUTH_PROXY_AUTH_TOKEN", Some(" "));
|
|
||||||
let _gateway_guard = set_env_var("GATEWAY_AUTH_TOKEN", Some("gateway-token"));
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
crate::cli::oauth_defaults::oauth_proxy_auth_token().as_deref(),
|
|
||||||
Some("gateway-token")
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_oauth_proxy_auth_token_returns_none_when_unset() {
|
|
||||||
let _guard = lock_env();
|
|
||||||
let _proxy_guard = set_env_var("IRONCLAW_OAUTH_PROXY_AUTH_TOKEN", None);
|
|
||||||
let _gateway_guard = set_env_var("GATEWAY_AUTH_TOKEN", None);
|
|
||||||
|
|
||||||
assert_eq!(crate::cli::oauth_defaults::oauth_proxy_auth_token(), None);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_strip_instance_prefix_with_colon() {
|
fn test_strip_instance_prefix_with_colon() {
|
||||||
use crate::cli::oauth_defaults::strip_instance_prefix;
|
use crate::cli::oauth_defaults::strip_instance_prefix;
|
||||||
|
|||||||
+1
-20
@@ -1,6 +1,6 @@
|
|||||||
use std::time::Duration;
|
use std::time::Duration;
|
||||||
|
|
||||||
use crate::config::helpers::{optional_env, parse_bool_env, parse_option_env, parse_optional_env};
|
use crate::config::helpers::{parse_bool_env, parse_option_env, parse_optional_env};
|
||||||
use crate::error::ConfigError;
|
use crate::error::ConfigError;
|
||||||
use crate::settings::Settings;
|
use crate::settings::Settings;
|
||||||
|
|
||||||
@@ -23,8 +23,6 @@ pub struct AgentConfig {
|
|||||||
pub max_cost_per_day_cents: Option<u64>,
|
pub max_cost_per_day_cents: Option<u64>,
|
||||||
/// Maximum LLM/tool actions per hour. None = unlimited.
|
/// Maximum LLM/tool actions per hour. None = unlimited.
|
||||||
pub max_actions_per_hour: Option<u64>,
|
pub max_actions_per_hour: Option<u64>,
|
||||||
/// Maximum daily LLM spend per user in cents. None = unlimited.
|
|
||||||
pub max_cost_per_user_per_day_cents: Option<u64>,
|
|
||||||
/// Maximum tool-call iterations per agentic loop invocation. Default 50.
|
/// Maximum tool-call iterations per agentic loop invocation. Default 50.
|
||||||
pub max_tool_iterations: usize,
|
pub max_tool_iterations: usize,
|
||||||
/// When true, skip tool approval checks entirely. For benchmarks/CI.
|
/// When true, skip tool approval checks entirely. For benchmarks/CI.
|
||||||
@@ -33,13 +31,6 @@ pub struct AgentConfig {
|
|||||||
pub default_timezone: String,
|
pub default_timezone: String,
|
||||||
/// Maximum tokens per job (0 = unlimited).
|
/// Maximum tokens per job (0 = unlimited).
|
||||||
pub max_tokens_per_job: u64,
|
pub max_tokens_per_job: u64,
|
||||||
/// Whether the deployment is multi-tenant (multiple users sharing one
|
|
||||||
/// instance). Auto-detected from GATEWAY_USER_TOKENS presence.
|
|
||||||
pub multi_tenant: bool,
|
|
||||||
/// Maximum concurrent LLM calls per user. None = use default (4).
|
|
||||||
pub max_llm_concurrent_per_user: Option<usize>,
|
|
||||||
/// Maximum concurrent jobs per user. None = use default (3).
|
|
||||||
pub max_jobs_concurrent_per_user: Option<usize>,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl AgentConfig {
|
impl AgentConfig {
|
||||||
@@ -58,14 +49,10 @@ impl AgentConfig {
|
|||||||
allow_local_tools: true,
|
allow_local_tools: true,
|
||||||
max_cost_per_day_cents: None,
|
max_cost_per_day_cents: None,
|
||||||
max_actions_per_hour: None,
|
max_actions_per_hour: None,
|
||||||
max_cost_per_user_per_day_cents: None,
|
|
||||||
max_tool_iterations: 10,
|
max_tool_iterations: 10,
|
||||||
auto_approve_tools: true,
|
auto_approve_tools: true,
|
||||||
default_timezone: "UTC".to_string(),
|
default_timezone: "UTC".to_string(),
|
||||||
max_tokens_per_job: 0,
|
max_tokens_per_job: 0,
|
||||||
multi_tenant: false,
|
|
||||||
max_llm_concurrent_per_user: None,
|
|
||||||
max_jobs_concurrent_per_user: None,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -100,7 +87,6 @@ impl AgentConfig {
|
|||||||
allow_local_tools: parse_bool_env("ALLOW_LOCAL_TOOLS", false)?,
|
allow_local_tools: parse_bool_env("ALLOW_LOCAL_TOOLS", false)?,
|
||||||
max_cost_per_day_cents: parse_option_env("MAX_COST_PER_DAY_CENTS")?,
|
max_cost_per_day_cents: parse_option_env("MAX_COST_PER_DAY_CENTS")?,
|
||||||
max_actions_per_hour: parse_option_env("MAX_ACTIONS_PER_HOUR")?,
|
max_actions_per_hour: parse_option_env("MAX_ACTIONS_PER_HOUR")?,
|
||||||
max_cost_per_user_per_day_cents: parse_option_env("MAX_COST_PER_USER_PER_DAY_CENTS")?,
|
|
||||||
max_tool_iterations: parse_optional_env(
|
max_tool_iterations: parse_optional_env(
|
||||||
"AGENT_MAX_TOOL_ITERATIONS",
|
"AGENT_MAX_TOOL_ITERATIONS",
|
||||||
settings.agent.max_tool_iterations,
|
settings.agent.max_tool_iterations,
|
||||||
@@ -126,11 +112,6 @@ impl AgentConfig {
|
|||||||
"AGENT_MAX_TOKENS_PER_JOB",
|
"AGENT_MAX_TOKENS_PER_JOB",
|
||||||
settings.agent.max_tokens_per_job,
|
settings.agent.max_tokens_per_job,
|
||||||
)?,
|
)?,
|
||||||
// Auto-detected from GATEWAY_USER_TOKENS presence. Not a separate
|
|
||||||
// knob — multi-tenant mode is always implied by configuring user tokens.
|
|
||||||
multi_tenant: optional_env("GATEWAY_USER_TOKENS")?.is_some(),
|
|
||||||
max_llm_concurrent_per_user: parse_option_env("TENANT_MAX_LLM_CONCURRENT")?,
|
|
||||||
max_jobs_concurrent_per_user: parse_option_env("TENANT_MAX_JOBS_CONCURRENT")?,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -21,9 +21,6 @@ pub struct HeartbeatConfig {
|
|||||||
pub quiet_hours_end: Option<u32>,
|
pub quiet_hours_end: Option<u32>,
|
||||||
/// Timezone for fire_at and quiet hours evaluation (IANA name).
|
/// Timezone for fire_at and quiet hours evaluation (IANA name).
|
||||||
pub timezone: Option<String>,
|
pub timezone: Option<String>,
|
||||||
/// When true, cycle through all users with routines. Auto-detected from
|
|
||||||
/// GATEWAY_USER_TOKENS or set explicitly via HEARTBEAT_MULTI_TENANT.
|
|
||||||
pub multi_tenant: bool,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Default for HeartbeatConfig {
|
impl Default for HeartbeatConfig {
|
||||||
@@ -37,7 +34,6 @@ impl Default for HeartbeatConfig {
|
|||||||
quiet_hours_start: None,
|
quiet_hours_start: None,
|
||||||
quiet_hours_end: None,
|
quiet_hours_end: None,
|
||||||
timezone: None,
|
timezone: None,
|
||||||
multi_tenant: false,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -105,12 +101,6 @@ impl HeartbeatConfig {
|
|||||||
}
|
}
|
||||||
tz
|
tz
|
||||||
},
|
},
|
||||||
// Auto-detect multi-tenant mode from GATEWAY_USER_TOKENS presence,
|
|
||||||
// or allow explicit override via HEARTBEAT_MULTI_TENANT.
|
|
||||||
multi_tenant: parse_bool_env(
|
|
||||||
"HEARTBEAT_MULTI_TENANT",
|
|
||||||
optional_env("GATEWAY_USER_TOKENS")?.is_some(),
|
|
||||||
)?,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -192,9 +192,6 @@ pub struct JobContext {
|
|||||||
/// but subsequent tools (e.g., `json`) may need the full output. This
|
/// but subsequent tools (e.g., `json`) may need the full output. This
|
||||||
/// stash stores the complete, unsanitized output so tools can reference
|
/// stash stores the complete, unsanitized output so tools can reference
|
||||||
/// previous results by ID via `$tool_call_id` parameter syntax.
|
/// previous results by ID via `$tool_call_id` parameter syntax.
|
||||||
///
|
|
||||||
/// Also used for cross-tool implicit state (keys prefixed with `__`) such
|
|
||||||
/// as `__routine_last_name` for fallback recovery in routine tool chains.
|
|
||||||
#[serde(skip)]
|
#[serde(skip)]
|
||||||
pub tool_output_stash: Arc<tokio::sync::RwLock<HashMap<String, String>>>,
|
pub tool_output_stash: Arc<tokio::sync::RwLock<HashMap<String, String>>>,
|
||||||
/// User's preferred timezone (IANA name, e.g. "America/New_York"). Defaults to "UTC".
|
/// User's preferred timezone (IANA name, e.g. "America/New_York"). Defaults to "UTC".
|
||||||
|
|||||||
@@ -530,24 +530,10 @@ impl RoutineStore for LibSqlBackend {
|
|||||||
async fn get_webhook_routine_by_path(
|
async fn get_webhook_routine_by_path(
|
||||||
&self,
|
&self,
|
||||||
path: &str,
|
path: &str,
|
||||||
user_id: Option<&str>,
|
|
||||||
) -> Result<Option<Routine>, DatabaseError> {
|
) -> Result<Option<Routine>, DatabaseError> {
|
||||||
let conn = self.connect().await?;
|
let conn = self.connect().await?;
|
||||||
let mut rows = if let Some(uid) = user_id {
|
let mut rows = conn
|
||||||
conn.query(
|
.query(
|
||||||
&format!(
|
|
||||||
"SELECT {} FROM routines WHERE enabled = 1 AND trigger_type = 'webhook' \
|
|
||||||
AND user_id = ?2 \
|
|
||||||
AND (json_extract(trigger_config, '$.path') = ?1 \
|
|
||||||
OR (json_extract(trigger_config, '$.path') IS NULL AND CAST(id AS TEXT) = ?1))",
|
|
||||||
ROUTINE_COLUMNS
|
|
||||||
),
|
|
||||||
params![path, uid],
|
|
||||||
)
|
|
||||||
.await
|
|
||||||
.map_err(|e| DatabaseError::Query(e.to_string()))?
|
|
||||||
} else {
|
|
||||||
conn.query(
|
|
||||||
&format!(
|
&format!(
|
||||||
"SELECT {} FROM routines WHERE enabled = 1 AND trigger_type = 'webhook' \
|
"SELECT {} FROM routines WHERE enabled = 1 AND trigger_type = 'webhook' \
|
||||||
AND (json_extract(trigger_config, '$.path') = ?1 \
|
AND (json_extract(trigger_config, '$.path') = ?1 \
|
||||||
@@ -557,8 +543,7 @@ impl RoutineStore for LibSqlBackend {
|
|||||||
params![path],
|
params![path],
|
||||||
)
|
)
|
||||||
.await
|
.await
|
||||||
.map_err(|e| DatabaseError::Query(e.to_string()))?
|
.map_err(|e| DatabaseError::Query(e.to_string()))?;
|
||||||
};
|
|
||||||
|
|
||||||
match rows
|
match rows
|
||||||
.next()
|
.next()
|
||||||
|
|||||||
@@ -545,7 +545,6 @@ pub trait RoutineStore: Send + Sync {
|
|||||||
async fn get_webhook_routine_by_path(
|
async fn get_webhook_routine_by_path(
|
||||||
&self,
|
&self,
|
||||||
path: &str,
|
path: &str,
|
||||||
user_id: Option<&str>,
|
|
||||||
) -> Result<Option<Routine>, DatabaseError>;
|
) -> Result<Option<Routine>, DatabaseError>;
|
||||||
|
|
||||||
/// List routine runs that were dispatched as full_job but have not yet
|
/// List routine runs that were dispatched as full_job but have not yet
|
||||||
|
|||||||
+1
-2
@@ -529,9 +529,8 @@ impl RoutineStore for PgBackend {
|
|||||||
async fn get_webhook_routine_by_path(
|
async fn get_webhook_routine_by_path(
|
||||||
&self,
|
&self,
|
||||||
path: &str,
|
path: &str,
|
||||||
user_id: Option<&str>,
|
|
||||||
) -> Result<Option<Routine>, DatabaseError> {
|
) -> Result<Option<Routine>, DatabaseError> {
|
||||||
self.store.get_webhook_routine_by_path(path, user_id).await
|
self.store.get_webhook_routine_by_path(path).await
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn list_dispatched_routine_runs(&self) -> Result<Vec<RoutineRun>, DatabaseError> {
|
async fn list_dispatched_routine_runs(&self) -> Result<Vec<RoutineRun>, DatabaseError> {
|
||||||
|
|||||||
+32
-392
@@ -403,10 +403,9 @@ pub struct ExtensionManager {
|
|||||||
/// when running in gateway mode, consumed by the web gateway's
|
/// when running in gateway mode, consumed by the web gateway's
|
||||||
/// `/oauth/callback` handler.
|
/// `/oauth/callback` handler.
|
||||||
pending_oauth_flows: crate::cli::oauth_defaults::PendingOAuthRegistry,
|
pending_oauth_flows: crate::cli::oauth_defaults::PendingOAuthRegistry,
|
||||||
/// OAuth proxy auth token for authenticating with the hosted token exchange proxy.
|
/// Gateway auth token for authenticating with the platform token exchange proxy.
|
||||||
/// Resolved once at construction from `IRONCLAW_OAUTH_PROXY_AUTH_TOKEN`,
|
/// Read once at construction from `GATEWAY_AUTH_TOKEN` env var.
|
||||||
/// then `GATEWAY_AUTH_TOKEN` as a backward-compatible fallback.
|
gateway_token: Option<String>,
|
||||||
oauth_proxy_auth_token: Option<String>,
|
|
||||||
/// Relay config captured at startup. Used by `auth_channel_relay` and
|
/// Relay config captured at startup. Used by `auth_channel_relay` and
|
||||||
/// `activate_channel_relay` instead of re-reading env vars.
|
/// `activate_channel_relay` instead of re-reading env vars.
|
||||||
relay_config: Option<crate::config::RelayConfig>,
|
relay_config: Option<crate::config::RelayConfig>,
|
||||||
@@ -536,7 +535,7 @@ impl ExtensionManager {
|
|||||||
activation_errors: RwLock::new(HashMap::new()),
|
activation_errors: RwLock::new(HashMap::new()),
|
||||||
sse_manager: RwLock::new(None),
|
sse_manager: RwLock::new(None),
|
||||||
pending_oauth_flows: crate::cli::oauth_defaults::new_pending_oauth_registry(),
|
pending_oauth_flows: crate::cli::oauth_defaults::new_pending_oauth_registry(),
|
||||||
oauth_proxy_auth_token: crate::cli::oauth_defaults::oauth_proxy_auth_token(),
|
gateway_token: std::env::var("GATEWAY_AUTH_TOKEN").ok(),
|
||||||
relay_config: crate::config::RelayConfig::from_env(),
|
relay_config: crate::config::RelayConfig::from_env(),
|
||||||
relay_event_tx: Arc::new(tokio::sync::Mutex::new(None)),
|
relay_event_tx: Arc::new(tokio::sync::Mutex::new(None)),
|
||||||
relay_signing_secret_cache: Arc::new(std::sync::Mutex::new(None)),
|
relay_signing_secret_cache: Arc::new(std::sync::Mutex::new(None)),
|
||||||
@@ -660,66 +659,6 @@ impl ExtensionManager {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Resolve the relay URL override for an extension from settings.
|
|
||||||
///
|
|
||||||
/// Returns `Some(url)` if a non-empty per-extension `relay_url` override is
|
|
||||||
/// set for the given extension; otherwise returns `None` and callers should
|
|
||||||
/// fall back to the env-level `RelayConfig`.
|
|
||||||
///
|
|
||||||
/// Uses `self.user_id` (owner scope) for consistency with `configure()`,
|
|
||||||
/// which also writes setting_path fields under the owner scope.
|
|
||||||
///
|
|
||||||
/// The override is validated: only `http` / `https` schemes are accepted
|
|
||||||
/// and the URL must not contain userinfo (embedded credentials). This
|
|
||||||
/// prevents a malicious override from exfiltrating the instance-wide relay
|
|
||||||
/// API key to an attacker-controlled host.
|
|
||||||
async fn effective_relay_url(&self, name: &str) -> Option<String> {
|
|
||||||
if let Some(ref store) = self.store {
|
|
||||||
let key = format!("extensions.{name}.relay_url");
|
|
||||||
if let Ok(Some(v)) = store.get_setting(&self.user_id, &key).await {
|
|
||||||
let url = v
|
|
||||||
.as_str()
|
|
||||||
.map(|s| s.trim().to_string())
|
|
||||||
.filter(|s| !s.is_empty());
|
|
||||||
if let Some(ref u) = url {
|
|
||||||
// Validate the override to prevent API-key exfiltration:
|
|
||||||
// only allow http(s) with no embedded credentials.
|
|
||||||
match url::Url::parse(u) {
|
|
||||||
Ok(parsed)
|
|
||||||
if (parsed.scheme() == "http" || parsed.scheme() == "https")
|
|
||||||
&& parsed.username().is_empty()
|
|
||||||
&& parsed.password().is_none() =>
|
|
||||||
{
|
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
relay_url_host = %parsed.host_str().unwrap_or("unknown"),
|
|
||||||
"effective_relay_url: using per-extension override from settings"
|
|
||||||
);
|
|
||||||
return url;
|
|
||||||
}
|
|
||||||
Ok(parsed) => {
|
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
scheme = %parsed.scheme(),
|
|
||||||
has_userinfo = !parsed.username().is_empty() || parsed.password().is_some(),
|
|
||||||
"effective_relay_url: rejecting override — \
|
|
||||||
only http/https without embedded credentials is allowed"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
Err(e) => {
|
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
error = %e,
|
|
||||||
"effective_relay_url: rejecting override — invalid URL"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
None
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Get the shared relay event sender for the webhook endpoint.
|
/// Get the shared relay event sender for the webhook endpoint.
|
||||||
pub fn relay_event_tx(
|
pub fn relay_event_tx(
|
||||||
&self,
|
&self,
|
||||||
@@ -953,46 +892,6 @@ impl ExtensionManager {
|
|||||||
false
|
false
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Check whether a stored `team_id` setting exists for the given relay extension.
|
|
||||||
///
|
|
||||||
/// Unlike [`is_relay_channel`], this does **not** consult the in-memory
|
|
||||||
/// `installed_relay_extensions` set — it only looks at the persistent settings
|
|
||||||
/// store. This distinction matters for `auth_channel_relay`: an extension can
|
|
||||||
/// be *installed* (present in the in-memory set) but not yet *authenticated*
|
|
||||||
/// (no OAuth completed, no team_id stored).
|
|
||||||
async fn has_stored_team_id(&self, name: &str, _user_id: &str) -> bool {
|
|
||||||
if let Some(ref store) = self.store {
|
|
||||||
let key = format!("relay:{}:team_id", name);
|
|
||||||
// Use owner scope (self.user_id) for consistency: the OAuth callback
|
|
||||||
// stores team_id under state.owner_id which maps to self.user_id.
|
|
||||||
match store.get_setting(&self.user_id, &key).await {
|
|
||||||
Ok(Some(v)) => {
|
|
||||||
let has_id = v.as_str().is_some_and(|s| !s.is_empty());
|
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
has_team_id = has_id,
|
|
||||||
"has_stored_team_id: checked store"
|
|
||||||
);
|
|
||||||
return has_id;
|
|
||||||
}
|
|
||||||
Ok(None) => {
|
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
"has_stored_team_id: no team_id setting found"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
Err(e) => {
|
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
error = %e,
|
|
||||||
"has_stored_team_id: failed to read from settings store"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
false
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Restore persisted relay channels after startup.
|
/// Restore persisted relay channels after startup.
|
||||||
///
|
///
|
||||||
/// Loads the persisted active channel list, filters to relay types (those with
|
/// Loads the persisted active channel list, filters to relay types (those with
|
||||||
@@ -1519,7 +1418,7 @@ impl ExtensionManager {
|
|||||||
let errors = self.activation_errors.read().await;
|
let errors = self.activation_errors.read().await;
|
||||||
for name in installed.iter() {
|
for name in installed.iter() {
|
||||||
let active = active_names.contains(name);
|
let active = active_names.contains(name);
|
||||||
let authenticated = self.has_stored_team_id(name, user_id).await;
|
let authenticated = self.is_relay_channel(name, user_id).await;
|
||||||
let activation_error = errors.get(name).cloned();
|
let activation_error = errors.get(name).cloned();
|
||||||
let registry_entry = self
|
let registry_entry = self
|
||||||
.registry
|
.registry
|
||||||
@@ -2789,7 +2688,7 @@ impl ExtensionManager {
|
|||||||
user_id: user_id.to_string(),
|
user_id: user_id.to_string(),
|
||||||
secrets: Arc::clone(&self.secrets),
|
secrets: Arc::clone(&self.secrets),
|
||||||
sse_manager: self.sse_manager.read().await.clone(),
|
sse_manager: self.sse_manager.read().await.clone(),
|
||||||
gateway_token: self.oauth_proxy_auth_token.clone(),
|
gateway_token: self.gateway_token.clone(),
|
||||||
token_exchange_extra_params,
|
token_exchange_extra_params,
|
||||||
client_id_secret_name: if server.oauth.is_none() {
|
client_id_secret_name: if server.oauth.is_none() {
|
||||||
Some(server.client_id_secret_name())
|
Some(server.client_id_secret_name())
|
||||||
@@ -3306,7 +3205,7 @@ impl ExtensionManager {
|
|||||||
user_id: user_id.to_string(),
|
user_id: user_id.to_string(),
|
||||||
secrets: Arc::clone(&self.secrets),
|
secrets: Arc::clone(&self.secrets),
|
||||||
sse_manager: self.sse_manager.read().await.clone(),
|
sse_manager: self.sse_manager.read().await.clone(),
|
||||||
gateway_token: self.oauth_proxy_auth_token.clone(),
|
gateway_token: self.gateway_token.clone(),
|
||||||
token_exchange_extra_params: std::collections::HashMap::new(),
|
token_exchange_extra_params: std::collections::HashMap::new(),
|
||||||
client_id_secret_name: None,
|
client_id_secret_name: None,
|
||||||
created_at: std::time::Instant::now(),
|
created_at: std::time::Instant::now(),
|
||||||
@@ -4292,69 +4191,20 @@ impl ExtensionManager {
|
|||||||
name: &str,
|
name: &str,
|
||||||
user_id: &str,
|
user_id: &str,
|
||||||
) -> Result<AuthResult, ExtensionError> {
|
) -> Result<AuthResult, ExtensionError> {
|
||||||
tracing::debug!(
|
// Check if already authenticated (team_id setting exists)
|
||||||
extension = %name,
|
if self.is_relay_channel(name, user_id).await {
|
||||||
user_id = %user_id,
|
|
||||||
"auth_channel_relay: starting"
|
|
||||||
);
|
|
||||||
|
|
||||||
// Check if already authenticated by looking for a stored team_id.
|
|
||||||
// We intentionally skip the `installed_relay_extensions` in-memory set
|
|
||||||
// here because that set only tracks *installed* extensions — an extension
|
|
||||||
// can be installed (via registry) but not yet authenticated (no OAuth
|
|
||||||
// completed). Checking just `is_relay_channel()` would short-circuit
|
|
||||||
// to "authenticated" even when no team_id exists, preventing the OAuth
|
|
||||||
// flow from being offered to the user.
|
|
||||||
if self.has_stored_team_id(name, user_id).await {
|
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
"auth_channel_relay: already authenticated (team_id in store)"
|
|
||||||
);
|
|
||||||
return Ok(AuthResult::authenticated(name, ExtensionKind::ChannelRelay));
|
return Ok(AuthResult::authenticated(name, ExtensionKind::ChannelRelay));
|
||||||
}
|
}
|
||||||
|
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
"auth_channel_relay: no stored team_id, initiating OAuth"
|
|
||||||
);
|
|
||||||
|
|
||||||
// Use relay config captured at startup
|
// Use relay config captured at startup
|
||||||
let relay_config = self.relay_config().map_err(|e| {
|
let relay_config = self.relay_config()?;
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
error = %e,
|
|
||||||
"auth_channel_relay: relay config not available — \
|
|
||||||
CHANNEL_RELAY_URL and CHANNEL_RELAY_API_KEY must be set"
|
|
||||||
);
|
|
||||||
e
|
|
||||||
})?;
|
|
||||||
|
|
||||||
// Allow per-extension URL override from settings
|
|
||||||
let effective_url = self
|
|
||||||
.effective_relay_url(name)
|
|
||||||
.await
|
|
||||||
.unwrap_or_else(|| relay_config.url.clone());
|
|
||||||
|
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
relay_url = %effective_url,
|
|
||||||
"auth_channel_relay: creating relay client for OAuth"
|
|
||||||
);
|
|
||||||
|
|
||||||
let client = crate::channels::relay::RelayClient::new(
|
let client = crate::channels::relay::RelayClient::new(
|
||||||
effective_url.clone(),
|
relay_config.url.clone(),
|
||||||
relay_config.api_key.clone(),
|
relay_config.api_key.clone(),
|
||||||
relay_config.request_timeout_secs,
|
relay_config.request_timeout_secs,
|
||||||
)
|
)
|
||||||
.map_err(|e| {
|
.map_err(|e| ExtensionError::Config(e.to_string()))?;
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
relay_url = %effective_url,
|
|
||||||
error = %e,
|
|
||||||
"auth_channel_relay: failed to create relay HTTP client"
|
|
||||||
);
|
|
||||||
ExtensionError::Config(e.to_string())
|
|
||||||
})?;
|
|
||||||
|
|
||||||
// Generate CSRF nonce — IronClaw validates this on the callback to ensure
|
// Generate CSRF nonce — IronClaw validates this on the callback to ensure
|
||||||
// the OAuth completion is legitimate. Channel-relay embeds it in the signed
|
// the OAuth completion is legitimate. Channel-relay embeds it in the signed
|
||||||
@@ -4366,44 +4216,18 @@ impl ExtensionManager {
|
|||||||
self.secrets
|
self.secrets
|
||||||
.create(user_id, CreateSecretParams::new(&state_key, &state_nonce))
|
.create(user_id, CreateSecretParams::new(&state_key, &state_nonce))
|
||||||
.await
|
.await
|
||||||
.map_err(|e| {
|
.map_err(|e| ExtensionError::AuthFailed(format!("Failed to store OAuth state: {e}")))?;
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
error = %e,
|
|
||||||
"auth_channel_relay: failed to store OAuth state nonce"
|
|
||||||
);
|
|
||||||
ExtensionError::AuthFailed(format!("Failed to store OAuth state: {e}"))
|
|
||||||
})?;
|
|
||||||
|
|
||||||
// Channel-relay derives all URLs from trusted instance_url in chat-api.
|
// Channel-relay derives all URLs from trusted instance_url in chat-api.
|
||||||
// We only pass the nonce for CSRF validation on the callback.
|
// We only pass the nonce for CSRF validation on the callback.
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
relay_url = %effective_url,
|
|
||||||
"auth_channel_relay: calling initiate_oauth on channel-relay"
|
|
||||||
);
|
|
||||||
match client.initiate_oauth(Some(&state_nonce)).await {
|
match client.initiate_oauth(Some(&state_nonce)).await {
|
||||||
Ok(auth_url) => {
|
Ok(auth_url) => Ok(AuthResult::awaiting_authorization(
|
||||||
tracing::info!(
|
|
||||||
extension = %name,
|
|
||||||
"auth_channel_relay: OAuth URL obtained, awaiting user authorization"
|
|
||||||
);
|
|
||||||
Ok(AuthResult::awaiting_authorization(
|
|
||||||
name,
|
name,
|
||||||
ExtensionKind::ChannelRelay,
|
ExtensionKind::ChannelRelay,
|
||||||
auth_url,
|
auth_url,
|
||||||
"redirect".to_string(),
|
"redirect".to_string(),
|
||||||
))
|
)),
|
||||||
}
|
Err(e) => Err(ExtensionError::AuthFailed(e.to_string())),
|
||||||
Err(e) => {
|
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
relay_url = %effective_url,
|
|
||||||
error = %e,
|
|
||||||
"auth_channel_relay: initiate_oauth call to channel-relay failed"
|
|
||||||
);
|
|
||||||
Err(ExtensionError::AuthFailed(e.to_string()))
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -4413,112 +4237,40 @@ impl ExtensionManager {
|
|||||||
name: &str,
|
name: &str,
|
||||||
user_id: &str,
|
user_id: &str,
|
||||||
) -> Result<ActivateResult, ExtensionError> {
|
) -> Result<ActivateResult, ExtensionError> {
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
user_id = %user_id,
|
|
||||||
"activate_channel_relay: starting"
|
|
||||||
);
|
|
||||||
|
|
||||||
let team_id_key = format!("relay:{}:team_id", name);
|
let team_id_key = format!("relay:{}:team_id", name);
|
||||||
|
|
||||||
// Get team_id from settings (stored by the OAuth callback)
|
// Get team_id from settings (stored by the OAuth callback)
|
||||||
let team_id = if let Some(ref store) = self.store {
|
let team_id = if let Some(ref store) = self.store {
|
||||||
match store.get_setting(user_id, &team_id_key).await {
|
store
|
||||||
Ok(Some(v)) => {
|
.get_setting(user_id, &team_id_key)
|
||||||
let id = v.as_str().map(|s| s.to_string()).unwrap_or_default();
|
.await
|
||||||
tracing::debug!(
|
.ok()
|
||||||
extension = %name,
|
.flatten()
|
||||||
team_id_empty = id.is_empty(),
|
.and_then(|v| v.as_str().map(|s| s.to_string()))
|
||||||
"activate_channel_relay: loaded team_id from store"
|
.unwrap_or_default()
|
||||||
);
|
|
||||||
id
|
|
||||||
}
|
|
||||||
Ok(None) => {
|
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
setting_key = %team_id_key,
|
|
||||||
"activate_channel_relay: no team_id in settings store"
|
|
||||||
);
|
|
||||||
String::new()
|
|
||||||
}
|
|
||||||
Err(e) => {
|
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
error = %e,
|
|
||||||
"activate_channel_relay: failed to read team_id from settings store"
|
|
||||||
);
|
|
||||||
String::new()
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
"activate_channel_relay: no settings store available"
|
|
||||||
);
|
|
||||||
String::new()
|
String::new()
|
||||||
};
|
};
|
||||||
|
|
||||||
if team_id.is_empty() {
|
if team_id.is_empty() {
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
"activate_channel_relay: team_id is empty, returning AuthRequired"
|
|
||||||
);
|
|
||||||
return Err(ExtensionError::AuthRequired);
|
return Err(ExtensionError::AuthRequired);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Use relay config captured at startup
|
// Use relay config captured at startup
|
||||||
let relay_config = self.relay_config().map_err(|e| {
|
let relay_config = self.relay_config()?;
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
error = %e,
|
|
||||||
"activate_channel_relay: relay config not available"
|
|
||||||
);
|
|
||||||
e
|
|
||||||
})?;
|
|
||||||
|
|
||||||
// Allow per-extension URL override from settings
|
|
||||||
let effective_url = self
|
|
||||||
.effective_relay_url(name)
|
|
||||||
.await
|
|
||||||
.unwrap_or_else(|| relay_config.url.clone());
|
|
||||||
|
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
relay_url = %effective_url,
|
|
||||||
"activate_channel_relay: relay config loaded"
|
|
||||||
);
|
|
||||||
|
|
||||||
let instance_id = self.relay_instance_id(relay_config, user_id);
|
let instance_id = self.relay_instance_id(relay_config, user_id);
|
||||||
|
|
||||||
let client = crate::channels::relay::RelayClient::new(
|
let client = crate::channels::relay::RelayClient::new(
|
||||||
effective_url.clone(),
|
relay_config.url.clone(),
|
||||||
relay_config.api_key.clone(),
|
relay_config.api_key.clone(),
|
||||||
relay_config.request_timeout_secs,
|
relay_config.request_timeout_secs,
|
||||||
)
|
)
|
||||||
.map_err(|e| {
|
.map_err(|e| ExtensionError::ActivationFailed(e.to_string()))?;
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
relay_url = %effective_url,
|
|
||||||
error = %e,
|
|
||||||
"activate_channel_relay: failed to create relay HTTP client"
|
|
||||||
);
|
|
||||||
ExtensionError::ActivationFailed(e.to_string())
|
|
||||||
})?;
|
|
||||||
|
|
||||||
// Fetch the per-instance signing secret from channel-relay.
|
// Fetch the per-instance signing secret from channel-relay.
|
||||||
// This must succeed — there is no fallback.
|
// This must succeed — there is no fallback.
|
||||||
tracing::debug!(
|
|
||||||
extension = %name,
|
|
||||||
relay_url = %effective_url,
|
|
||||||
"activate_channel_relay: fetching signing secret from channel-relay"
|
|
||||||
);
|
|
||||||
let signing_secret = client.get_signing_secret(&team_id).await.map_err(|e| {
|
let signing_secret = client.get_signing_secret(&team_id).await.map_err(|e| {
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
relay_url = %effective_url,
|
|
||||||
error = %e,
|
|
||||||
"activate_channel_relay: failed to fetch signing secret from channel-relay"
|
|
||||||
);
|
|
||||||
ExtensionError::Config(format!("Failed to fetch relay signing secret: {e}"))
|
ExtensionError::Config(format!("Failed to fetch relay signing secret: {e}"))
|
||||||
})?;
|
})?;
|
||||||
|
|
||||||
@@ -4537,29 +4289,16 @@ impl ExtensionManager {
|
|||||||
// Hot-add to channel manager
|
// Hot-add to channel manager
|
||||||
let cm_guard = self.relay_channel_manager.read().await;
|
let cm_guard = self.relay_channel_manager.read().await;
|
||||||
let channel_mgr = cm_guard.as_ref().ok_or_else(|| {
|
let channel_mgr = cm_guard.as_ref().ok_or_else(|| {
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
"activate_channel_relay: channel manager not initialized"
|
|
||||||
);
|
|
||||||
ExtensionError::ActivationFailed("Channel manager not initialized".to_string())
|
ExtensionError::ActivationFailed("Channel manager not initialized".to_string())
|
||||||
})?;
|
})?;
|
||||||
|
|
||||||
channel_mgr.hot_add(Box::new(channel)).await.map_err(|e| {
|
channel_mgr
|
||||||
tracing::warn!(
|
.hot_add(Box::new(channel))
|
||||||
extension = %name,
|
.await
|
||||||
error = %e,
|
.map_err(|e| ExtensionError::ActivationFailed(e.to_string()))?;
|
||||||
"activate_channel_relay: hot_add to channel manager failed"
|
|
||||||
);
|
|
||||||
ExtensionError::ActivationFailed(e.to_string())
|
|
||||||
})?;
|
|
||||||
|
|
||||||
if let Ok(mut cache) = self.relay_signing_secret_cache.lock() {
|
if let Ok(mut cache) = self.relay_signing_secret_cache.lock() {
|
||||||
*cache = Some(signing_secret);
|
*cache = Some(signing_secret);
|
||||||
} else {
|
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
"activate_channel_relay: failed to cache signing secret (mutex poisoned)"
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Store the event sender so the web gateway's relay webhook endpoint can push events
|
// Store the event sender so the web gateway's relay webhook endpoint can push events
|
||||||
@@ -4577,12 +4316,6 @@ impl ExtensionManager {
|
|||||||
self.broadcast_extension_status(name, "active", Some(&status_msg))
|
self.broadcast_extension_status(name, "active", Some(&status_msg))
|
||||||
.await;
|
.await;
|
||||||
|
|
||||||
tracing::info!(
|
|
||||||
extension = %name,
|
|
||||||
instance_id = %instance_id,
|
|
||||||
"activate_channel_relay: relay channel activated successfully"
|
|
||||||
);
|
|
||||||
|
|
||||||
Ok(ActivateResult {
|
Ok(ActivateResult {
|
||||||
name: name.to_string(),
|
name: name.to_string(),
|
||||||
kind: ExtensionKind::ChannelRelay,
|
kind: ExtensionKind::ChannelRelay,
|
||||||
@@ -4862,41 +4595,6 @@ impl ExtensionManager {
|
|||||||
}
|
}
|
||||||
Ok(ExtensionSetupSchema { secrets, fields })
|
Ok(ExtensionSetupSchema { secrets, fields })
|
||||||
}
|
}
|
||||||
ExtensionKind::ChannelRelay => {
|
|
||||||
let relay_url_key = format!("extensions.{name}.relay_url");
|
|
||||||
let current_url = if let Some(ref store) = self.store {
|
|
||||||
match store.get_setting(&self.user_id, &relay_url_key).await {
|
|
||||||
Ok(value_opt) => value_opt
|
|
||||||
.and_then(|v| v.as_str().map(|s| s.to_string()))
|
|
||||||
.filter(|s| !s.is_empty()),
|
|
||||||
Err(e) => {
|
|
||||||
tracing::warn!(
|
|
||||||
extension = %name,
|
|
||||||
setting_key = %relay_url_key,
|
|
||||||
error = %e,
|
|
||||||
"get_setup_schema: failed to read relay_url from settings"
|
|
||||||
);
|
|
||||||
None
|
|
||||||
}
|
|
||||||
}
|
|
||||||
} else {
|
|
||||||
None
|
|
||||||
};
|
|
||||||
let env_url = self.relay_config.as_ref().map(|c| c.url.as_str());
|
|
||||||
Ok(ExtensionSetupSchema {
|
|
||||||
secrets: Vec::new(),
|
|
||||||
fields: vec![crate::channels::web::types::SetupFieldInfo {
|
|
||||||
name: "relay_url".to_string(),
|
|
||||||
prompt: format!(
|
|
||||||
"Channel-relay service URL (leave empty to use env default{})",
|
|
||||||
env_url.map(|u| format!(": {u}")).unwrap_or_default()
|
|
||||||
),
|
|
||||||
optional: true,
|
|
||||||
provided: current_url.is_some(),
|
|
||||||
input_type: crate::tools::wasm::ToolSetupFieldInputType::Text,
|
|
||||||
}],
|
|
||||||
})
|
|
||||||
}
|
|
||||||
_ => Ok(ExtensionSetupSchema {
|
_ => Ok(ExtensionSetupSchema {
|
||||||
secrets: Vec::new(),
|
secrets: Vec::new(),
|
||||||
fields: Vec::new(),
|
fields: Vec::new(),
|
||||||
@@ -5299,17 +4997,7 @@ impl ExtensionManager {
|
|||||||
names.insert(server.token_secret_name());
|
names.insert(server.token_secret_name());
|
||||||
(names, Vec::new())
|
(names, Vec::new())
|
||||||
}
|
}
|
||||||
ExtensionKind::ChannelRelay => {
|
ExtensionKind::ChannelRelay => (std::collections::HashSet::new(), Vec::new()),
|
||||||
let relay_fields = vec![crate::tools::wasm::ToolFieldSetupSchema {
|
|
||||||
name: "relay_url".to_string(),
|
|
||||||
prompt: "Channel-relay service URL override".to_string(),
|
|
||||||
optional: true,
|
|
||||||
setting_path: Some(format!("extensions.{name}.relay_url")),
|
|
||||||
input_type: crate::tools::wasm::ToolSetupFieldInputType::Text,
|
|
||||||
restart_required: false,
|
|
||||||
}];
|
|
||||||
(std::collections::HashSet::new(), relay_fields)
|
|
||||||
}
|
|
||||||
};
|
};
|
||||||
|
|
||||||
let allowed_fields: std::collections::HashSet<String> =
|
let allowed_fields: std::collections::HashSet<String> =
|
||||||
@@ -5400,28 +5088,13 @@ impl ExtensionManager {
|
|||||||
)));
|
)));
|
||||||
}
|
}
|
||||||
let trimmed = field_value.trim();
|
let trimmed = field_value.trim();
|
||||||
let field_def = setup_field_defs.get(field_name);
|
|
||||||
|
|
||||||
// Empty value on an optional field with a setting_path: clear the
|
|
||||||
// stored override so the system reverts to the env/default value.
|
|
||||||
if trimmed.is_empty() {
|
if trimmed.is_empty() {
|
||||||
if let Some(def) = field_def
|
|
||||||
&& def.optional
|
|
||||||
{
|
|
||||||
stored_fields.remove(field_name);
|
|
||||||
if let Some(setting_path) = &def.setting_path {
|
|
||||||
Self::validate_setup_setting_path(name, setting_path)?;
|
|
||||||
if let Some(store) = self.store.as_ref() {
|
|
||||||
let _ = store.delete_setting(&self.user_id, setting_path).await;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
stored_fields.insert(field_name.clone(), trimmed.to_string());
|
stored_fields.insert(field_name.clone(), trimmed.to_string());
|
||||||
|
|
||||||
if let Some(field_def) = field_def {
|
if let Some(field_def) = setup_field_defs.get(field_name) {
|
||||||
if field_def.restart_required {
|
if field_def.restart_required {
|
||||||
restart_required = true;
|
restart_required = true;
|
||||||
}
|
}
|
||||||
@@ -7385,39 +7058,6 @@ mod tests {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Regression: installed-but-not-authenticated relay must NOT short-circuit
|
|
||||||
/// `auth_channel_relay()` to "authenticated". Previously, `auth_channel_relay`
|
|
||||||
/// called `is_relay_channel()` which checked the in-memory
|
|
||||||
/// `installed_relay_extensions` set; that returned `true` even when no team_id
|
|
||||||
/// existed in the store, so the OAuth URL was never offered.
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_auth_channel_relay_installed_without_team_id_is_not_authenticated() {
|
|
||||||
let dir = tempfile::tempdir().expect("temp dir");
|
|
||||||
let mgr = make_test_manager(None, dir.path().to_path_buf());
|
|
||||||
|
|
||||||
// Mark as installed (simulates clicking Install in the UI)
|
|
||||||
mgr.installed_relay_extensions
|
|
||||||
.write()
|
|
||||||
.await
|
|
||||||
.insert("slack-relay".to_string());
|
|
||||||
|
|
||||||
// Without a stored team_id, auth should NOT return authenticated.
|
|
||||||
// It should fail because relay config is missing (no CHANNEL_RELAY_URL),
|
|
||||||
// but the key assertion is that it does NOT return Ok(authenticated).
|
|
||||||
let result = mgr.auth_channel_relay("slack-relay", "test").await;
|
|
||||||
match result {
|
|
||||||
Ok(ref auth_result) if auth_result.is_authenticated() => {
|
|
||||||
panic!(
|
|
||||||
"auth_channel_relay returned authenticated for installed-but-no-team-id relay; \
|
|
||||||
expected either an OAuth URL or a config error"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
_ => {
|
|
||||||
// Config error (no relay URL) or awaiting_authorization — both are correct
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_remove_relay_shuts_down_via_relay_channel_manager() {
|
async fn test_remove_relay_shuts_down_via_relay_channel_manager() {
|
||||||
// Regression: remove() only checked channel_runtime for shutdown, missing
|
// Regression: remove() only checked channel_runtime for shutdown, missing
|
||||||
|
|||||||
+3
-13
@@ -1162,25 +1162,15 @@ impl Store {
|
|||||||
pub async fn get_webhook_routine_by_path(
|
pub async fn get_webhook_routine_by_path(
|
||||||
&self,
|
&self,
|
||||||
path: &str,
|
path: &str,
|
||||||
user_id: Option<&str>,
|
|
||||||
) -> Result<Option<Routine>, DatabaseError> {
|
) -> Result<Option<Routine>, DatabaseError> {
|
||||||
let conn = self.conn().await?;
|
let conn = self.conn().await?;
|
||||||
let row = if let Some(uid) = user_id {
|
let row = conn
|
||||||
conn.query_opt(
|
.query_opt(
|
||||||
"SELECT * FROM routines WHERE enabled AND trigger_type = 'webhook' \
|
|
||||||
AND user_id = $2 \
|
|
||||||
AND (trigger_config->>'path' = $1 OR (trigger_config->>'path' IS NULL AND id::text = $1))",
|
|
||||||
&[&path, &uid],
|
|
||||||
)
|
|
||||||
.await?
|
|
||||||
} else {
|
|
||||||
conn.query_opt(
|
|
||||||
"SELECT * FROM routines WHERE enabled AND trigger_type = 'webhook' \
|
"SELECT * FROM routines WHERE enabled AND trigger_type = 'webhook' \
|
||||||
AND (trigger_config->>'path' = $1 OR (trigger_config->>'path' IS NULL AND id::text = $1))",
|
AND (trigger_config->>'path' = $1 OR (trigger_config->>'path' IS NULL AND id::text = $1))",
|
||||||
&[&path],
|
&[&path],
|
||||||
)
|
)
|
||||||
.await?
|
.await?;
|
||||||
};
|
|
||||||
row.as_ref().map(row_to_routine).transpose()
|
row.as_ref().map(row_to_routine).transpose()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -69,7 +69,6 @@ pub mod service;
|
|||||||
pub mod settings;
|
pub mod settings;
|
||||||
pub mod setup;
|
pub mod setup;
|
||||||
pub mod skills;
|
pub mod skills;
|
||||||
pub mod tenant;
|
|
||||||
pub mod timezone;
|
pub mod timezone;
|
||||||
pub mod tools;
|
pub mod tools;
|
||||||
pub mod tracing_fmt;
|
pub mod tracing_fmt;
|
||||||
|
|||||||
+1
-2
@@ -63,8 +63,7 @@ pub use provider::{
|
|||||||
};
|
};
|
||||||
pub use reasoning::{
|
pub use reasoning::{
|
||||||
ActionPlan, Reasoning, ReasoningContext, RespondOutput, RespondResult, SILENT_REPLY_TOKEN,
|
ActionPlan, Reasoning, ReasoningContext, RespondOutput, RespondResult, SILENT_REPLY_TOKEN,
|
||||||
TOOL_INTENT_NUDGE, TRUNCATED_TOOL_CALL_NOTICE, TokenUsage, ToolSelection, is_silent_reply,
|
TOOL_INTENT_NUDGE, TokenUsage, ToolSelection, is_silent_reply, llm_signals_tool_intent,
|
||||||
llm_signals_tool_intent,
|
|
||||||
};
|
};
|
||||||
pub use recording::RecordingLlm;
|
pub use recording::RecordingLlm;
|
||||||
pub use registry::{ProviderDefinition, ProviderProtocol, ProviderRegistry};
|
pub use registry::{ProviderDefinition, ProviderProtocol, ProviderRegistry};
|
||||||
|
|||||||
+8
-211
@@ -8,8 +8,8 @@ use serde::{Deserialize, Serialize};
|
|||||||
use crate::llm::error::LlmError;
|
use crate::llm::error::LlmError;
|
||||||
|
|
||||||
use crate::llm::{
|
use crate::llm::{
|
||||||
ChatMessage, CompletionRequest, FinishReason, LlmProvider, Role, ToolCall,
|
ChatMessage, CompletionRequest, LlmProvider, Role, ToolCall, ToolCompletionRequest,
|
||||||
ToolCompletionRequest, ToolDefinition,
|
ToolDefinition,
|
||||||
};
|
};
|
||||||
|
|
||||||
/// Token the agent returns when it has nothing to say (e.g. in group chats).
|
/// Token the agent returns when it has nothing to say (e.g. in group chats).
|
||||||
@@ -23,13 +23,6 @@ You said you would perform an action, but you did not include any tool calls.\n\
|
|||||||
Do NOT describe what you intend to do — actually call the tool now.\n\
|
Do NOT describe what you intend to do — actually call the tool now.\n\
|
||||||
Use the tool_calls mechanism to invoke the appropriate tool.";
|
Use the tool_calls mechanism to invoke the appropriate tool.";
|
||||||
|
|
||||||
/// Notice injected when the LLM's response was truncated mid-tool-call,
|
|
||||||
/// causing incomplete parameters. Tells the LLM to try a different approach.
|
|
||||||
pub const TRUNCATED_TOOL_CALL_NOTICE: &str = "\
|
|
||||||
Your previous response was truncated while generating tool call parameters. \
|
|
||||||
The tool calls were discarded. Please try a different approach — \
|
|
||||||
summarize or transform the data instead of echoing it verbatim in a tool call.";
|
|
||||||
|
|
||||||
/// Seed value used as the second argument to `generate_tool_call_id` when
|
/// Seed value used as the second argument to `generate_tool_call_id` when
|
||||||
/// recovering tool calls from malformed LLM text responses. This must differ
|
/// recovering tool calls from malformed LLM text responses. This must differ
|
||||||
/// from the `0` seed used in `rig_adapter::normalized_tool_call_id` to avoid
|
/// from the `0` seed used in `rig_adapter::normalized_tool_call_id` to avoid
|
||||||
@@ -201,17 +194,11 @@ pub struct ReasoningContext {
|
|||||||
pub metadata: std::collections::HashMap<String, String>,
|
pub metadata: std::collections::HashMap<String, String>,
|
||||||
/// When true, force a text-only response (ignore available tools).
|
/// When true, force a text-only response (ignore available tools).
|
||||||
/// Used by the agentic loop to guarantee termination near the iteration limit.
|
/// Used by the agentic loop to guarantee termination near the iteration limit.
|
||||||
/// Sticky: once set, never cleared within a loop invocation. Callers must
|
|
||||||
/// create a fresh `ReasoningContext` per `run_agentic_loop()` call.
|
|
||||||
pub force_text: bool,
|
pub force_text: bool,
|
||||||
/// Pre-built system prompt. When set, `respond_with_tools` uses this directly
|
/// Pre-built system prompt. When set, `respond_with_tools` uses this directly
|
||||||
/// instead of calling `build_system_prompt_with_tools`. Allows callers to build
|
/// instead of calling `build_system_prompt_with_tools`. Allows callers to build
|
||||||
/// the prompt once and reuse it across iterations.
|
/// the prompt once and reuse it across iterations.
|
||||||
pub system_prompt: Option<String>,
|
pub system_prompt: Option<String>,
|
||||||
/// Per-user model override. When set, completion requests use this model
|
|
||||||
/// instead of the provider's default. Only effective with providers that
|
|
||||||
/// support per-request model overrides (e.g. NearAI).
|
|
||||||
pub model_override: Option<String>,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ReasoningContext {
|
impl ReasoningContext {
|
||||||
@@ -225,7 +212,6 @@ impl ReasoningContext {
|
|||||||
metadata: std::collections::HashMap::new(),
|
metadata: std::collections::HashMap::new(),
|
||||||
force_text: false,
|
force_text: false,
|
||||||
system_prompt: None,
|
system_prompt: None,
|
||||||
model_override: None,
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -358,7 +344,6 @@ pub enum RespondResult {
|
|||||||
pub struct RespondOutput {
|
pub struct RespondOutput {
|
||||||
pub result: RespondResult,
|
pub result: RespondResult,
|
||||||
pub usage: TokenUsage,
|
pub usage: TokenUsage,
|
||||||
pub finish_reason: FinishReason,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Reasoning engine for the agent.
|
/// Reasoning engine for the agent.
|
||||||
@@ -540,17 +525,6 @@ impl Reasoning {
|
|||||||
|
|
||||||
let response = self.llm.complete_with_tools(request).await?;
|
let response = self.llm.complete_with_tools(request).await?;
|
||||||
|
|
||||||
// If the response was truncated, tool call parameters are likely incomplete.
|
|
||||||
// Return empty so the caller can fall through to respond_with_tools() which
|
|
||||||
// has a larger output token budget.
|
|
||||||
if response.finish_reason == FinishReason::Length {
|
|
||||||
tracing::warn!(
|
|
||||||
"select_tools response truncated (finish_reason=Length), \
|
|
||||||
discarding potentially incomplete tool selections"
|
|
||||||
);
|
|
||||||
return Ok(vec![]);
|
|
||||||
}
|
|
||||||
|
|
||||||
let shared_reasoning = response
|
let shared_reasoning = response
|
||||||
.content
|
.content
|
||||||
.map(|c| {
|
.map(|c| {
|
||||||
@@ -697,9 +671,6 @@ Respond in JSON format:
|
|||||||
.with_temperature(0.7)
|
.with_temperature(0.7)
|
||||||
.with_tool_choice("auto");
|
.with_tool_choice("auto");
|
||||||
request.metadata = context.metadata.clone();
|
request.metadata = context.metadata.clone();
|
||||||
if let Some(ref model) = context.model_override {
|
|
||||||
request.model = Some(model.clone());
|
|
||||||
}
|
|
||||||
|
|
||||||
let response = self.llm.complete_with_tools(request).await?;
|
let response = self.llm.complete_with_tools(request).await?;
|
||||||
let usage = TokenUsage {
|
let usage = TokenUsage {
|
||||||
@@ -743,7 +714,6 @@ Respond in JSON format:
|
|||||||
content: narrative,
|
content: narrative,
|
||||||
},
|
},
|
||||||
usage,
|
usage,
|
||||||
finish_reason: response.finish_reason,
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -771,7 +741,6 @@ Respond in JSON format:
|
|||||||
},
|
},
|
||||||
},
|
},
|
||||||
usage,
|
usage,
|
||||||
finish_reason: response.finish_reason,
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -797,7 +766,6 @@ Respond in JSON format:
|
|||||||
Ok(RespondOutput {
|
Ok(RespondOutput {
|
||||||
result: RespondResult::Text(final_text),
|
result: RespondResult::Text(final_text),
|
||||||
usage,
|
usage,
|
||||||
finish_reason: response.finish_reason,
|
|
||||||
})
|
})
|
||||||
} else {
|
} else {
|
||||||
// No tools, use simple completion
|
// No tools, use simple completion
|
||||||
@@ -805,9 +773,6 @@ Respond in JSON format:
|
|||||||
.with_max_tokens(4096)
|
.with_max_tokens(4096)
|
||||||
.with_temperature(0.7);
|
.with_temperature(0.7);
|
||||||
request.metadata = context.metadata.clone();
|
request.metadata = context.metadata.clone();
|
||||||
if let Some(ref model) = context.model_override {
|
|
||||||
request.model = Some(model.clone());
|
|
||||||
}
|
|
||||||
|
|
||||||
let response = self.llm.complete(request).await?;
|
let response = self.llm.complete(request).await?;
|
||||||
let pre_truncated = truncate_at_tool_tags(&response.content);
|
let pre_truncated = truncate_at_tool_tags(&response.content);
|
||||||
@@ -829,7 +794,6 @@ Respond in JSON format:
|
|||||||
cache_read_input_tokens: response.cache_read_input_tokens,
|
cache_read_input_tokens: response.cache_read_input_tokens,
|
||||||
cache_creation_input_tokens: response.cache_creation_input_tokens,
|
cache_creation_input_tokens: response.cache_creation_input_tokens,
|
||||||
},
|
},
|
||||||
finish_reason: response.finish_reason,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1370,49 +1334,6 @@ fn is_inside_code(pos: usize, regions: &[CodeRegion]) -> bool {
|
|||||||
regions.iter().any(|r| pos >= r.start && pos < r.end)
|
regions.iter().any(|r| pos >= r.start && pos < r.end)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Check whether a byte range overlaps any code region.
|
|
||||||
fn overlaps_code_region(start: usize, end: usize, regions: &[CodeRegion]) -> bool {
|
|
||||||
regions.iter().any(|r| start < r.end && end > r.start)
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Return the byte bounds of the line containing `pos`, excluding the trailing newline.
|
|
||||||
fn line_bounds(text: &str, pos: usize) -> (usize, usize) {
|
|
||||||
let start = text[..pos].rfind('\n').map_or(0, |idx| idx + 1);
|
|
||||||
let end = text[pos..].find('\n').map_or(text.len(), |idx| pos + idx);
|
|
||||||
(start, end)
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Only recover XML-style tool calls when they are isolated content outside
|
|
||||||
/// markdown code and quote contexts. This avoids converting code examples or
|
|
||||||
/// quoted snippets into executable tool calls.
|
|
||||||
fn is_recoverable_tool_call_segment(
|
|
||||||
text: &str,
|
|
||||||
start: usize,
|
|
||||||
end: usize,
|
|
||||||
code_regions: &[CodeRegion],
|
|
||||||
) -> bool {
|
|
||||||
if overlaps_code_region(start, end, code_regions) {
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
let (first_line_start, first_line_end) = line_bounds(text, start);
|
|
||||||
let first_line = &text[first_line_start..first_line_end];
|
|
||||||
|
|
||||||
if first_line.trim_start().starts_with('>') {
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
let (_, last_line_end) = line_bounds(text, end.saturating_sub(1));
|
|
||||||
let first_line_prefix = &text[first_line_start..start];
|
|
||||||
let last_line_suffix = &text[end..last_line_end];
|
|
||||||
|
|
||||||
if !first_line_prefix.trim().is_empty() || !last_line_suffix.trim().is_empty() {
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Clean up LLM response by stripping model-internal tags and reasoning patterns.
|
/// Clean up LLM response by stripping model-internal tags and reasoning patterns.
|
||||||
///
|
///
|
||||||
/// Some models (GLM-4.7, etc.) emit XML-tagged internal state like
|
/// Some models (GLM-4.7, etc.) emit XML-tagged internal state like
|
||||||
@@ -1432,7 +1353,6 @@ fn recover_tool_calls_from_content(
|
|||||||
) -> Vec<ToolCall> {
|
) -> Vec<ToolCall> {
|
||||||
let tool_names: std::collections::HashSet<&str> =
|
let tool_names: std::collections::HashSet<&str> =
|
||||||
available_tools.iter().map(|t| t.name.as_str()).collect();
|
available_tools.iter().map(|t| t.name.as_str()).collect();
|
||||||
let code_regions = find_code_regions(content);
|
|
||||||
let mut calls = Vec::new();
|
let mut calls = Vec::new();
|
||||||
|
|
||||||
for (open, close) in &[
|
for (open, close) in &[
|
||||||
@@ -1441,23 +1361,15 @@ fn recover_tool_calls_from_content(
|
|||||||
("<function_call>", "</function_call>"),
|
("<function_call>", "</function_call>"),
|
||||||
("<|function_call|>", "<|/function_call|>"),
|
("<|function_call|>", "<|/function_call|>"),
|
||||||
] {
|
] {
|
||||||
let mut search_from = 0;
|
let mut remaining = content;
|
||||||
while let Some(offset) = content[search_from..].find(open) {
|
while let Some(start) = remaining.find(open) {
|
||||||
let start = search_from + offset;
|
|
||||||
let inner_start = start + open.len();
|
let inner_start = start + open.len();
|
||||||
let after = &content[inner_start..];
|
let after = &remaining[inner_start..];
|
||||||
let Some(end_offset) = after.find(close) else {
|
let Some(end) = after.find(close) else {
|
||||||
break;
|
break;
|
||||||
};
|
};
|
||||||
let end = inner_start + end_offset;
|
let inner = after[..end].trim();
|
||||||
let segment_end = end + close.len();
|
remaining = &after[end + close.len()..];
|
||||||
search_from = segment_end;
|
|
||||||
|
|
||||||
if !is_recoverable_tool_call_segment(content, start, segment_end, &code_regions) {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
let inner = content[inner_start..end].trim();
|
|
||||||
|
|
||||||
if inner.is_empty() {
|
if inner.is_empty() {
|
||||||
continue;
|
continue;
|
||||||
@@ -2390,40 +2302,6 @@ That's my plan."#;
|
|||||||
assert_eq!(calls[0].name, "tool_list");
|
assert_eq!(calls[0].name, "tool_list");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_recover_tool_call_in_fenced_code_block_ignored() {
|
|
||||||
let tools = make_tools(&["tool_list"]);
|
|
||||||
let content = "Here is the XML format:\n\n```xml\n<tool_call>tool_list</tool_call>\n```";
|
|
||||||
let calls = recover_tool_calls_from_content(content, &tools);
|
|
||||||
assert!(calls.is_empty());
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_recover_tool_call_in_inline_code_ignored() {
|
|
||||||
let tools = make_tools(&["tool_list"]);
|
|
||||||
let content = "Use `<tool_call>tool_list</tool_call>` to illustrate the syntax.";
|
|
||||||
let calls = recover_tool_calls_from_content(content, &tools);
|
|
||||||
assert!(calls.is_empty());
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_recover_tool_call_in_blockquote_ignored() {
|
|
||||||
let tools = make_tools(&["tool_list"]);
|
|
||||||
let content = "The page replied:\n> <tool_call>tool_list</tool_call>";
|
|
||||||
let calls = recover_tool_calls_from_content(content, &tools);
|
|
||||||
assert!(calls.is_empty());
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_recover_multiline_json_tool_call_on_own_line() {
|
|
||||||
let tools = make_tools(&["memory_search"]);
|
|
||||||
let content = "Let me check.\n\n<tool_call>\n{\"name\": \"memory_search\", \"arguments\": {\"query\": \"test\"}}\n</tool_call>\n\nDone.";
|
|
||||||
let calls = recover_tool_calls_from_content(content, &tools);
|
|
||||||
assert_eq!(calls.len(), 1);
|
|
||||||
assert_eq!(calls[0].name, "memory_search");
|
|
||||||
assert_eq!(calls[0].arguments, serde_json::json!({"query": "test"}));
|
|
||||||
}
|
|
||||||
|
|
||||||
// ---- System prompt building tests (issue #565) ----
|
// ---- System prompt building tests (issue #565) ----
|
||||||
|
|
||||||
fn make_test_reasoning() -> Reasoning {
|
fn make_test_reasoning() -> Reasoning {
|
||||||
@@ -3340,85 +3218,4 @@ That's my plan."#;
|
|||||||
let cleaned = clean_response(&pre_truncated);
|
let cleaned = clean_response(&pre_truncated);
|
||||||
assert!(cleaned.trim().is_empty());
|
assert!(cleaned.trim().is_empty());
|
||||||
}
|
}
|
||||||
|
|
||||||
// ---- select_tools truncation guard ----
|
|
||||||
|
|
||||||
/// Mock provider that returns tool calls with a configurable finish_reason.
|
|
||||||
struct TruncatingLlm {
|
|
||||||
finish_reason: crate::llm::FinishReason,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[async_trait::async_trait]
|
|
||||||
impl crate::llm::LlmProvider for TruncatingLlm {
|
|
||||||
fn model_name(&self) -> &str {
|
|
||||||
"truncating-stub"
|
|
||||||
}
|
|
||||||
fn cost_per_token(&self) -> (rust_decimal::Decimal, rust_decimal::Decimal) {
|
|
||||||
(rust_decimal::Decimal::ZERO, rust_decimal::Decimal::ZERO)
|
|
||||||
}
|
|
||||||
async fn complete(
|
|
||||||
&self,
|
|
||||||
_request: crate::llm::CompletionRequest,
|
|
||||||
) -> Result<crate::llm::CompletionResponse, crate::llm::error::LlmError> {
|
|
||||||
unimplemented!()
|
|
||||||
}
|
|
||||||
async fn complete_with_tools(
|
|
||||||
&self,
|
|
||||||
_request: crate::llm::ToolCompletionRequest,
|
|
||||||
) -> Result<crate::llm::ToolCompletionResponse, crate::llm::error::LlmError> {
|
|
||||||
Ok(crate::llm::ToolCompletionResponse {
|
|
||||||
content: Some("I'll write the report.".to_string()),
|
|
||||||
tool_calls: vec![ToolCall {
|
|
||||||
id: "call_1".to_string(),
|
|
||||||
name: "memory_write".to_string(),
|
|
||||||
arguments: serde_json::json!({}),
|
|
||||||
reasoning: None,
|
|
||||||
}],
|
|
||||||
input_tokens: 5000,
|
|
||||||
output_tokens: 1024,
|
|
||||||
finish_reason: self.finish_reason,
|
|
||||||
cache_read_input_tokens: 0,
|
|
||||||
cache_creation_input_tokens: 0,
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_select_tools_returns_empty_on_truncation() {
|
|
||||||
let llm = Arc::new(TruncatingLlm {
|
|
||||||
finish_reason: FinishReason::Length,
|
|
||||||
});
|
|
||||||
let reasoning = Reasoning::new(llm);
|
|
||||||
let mut ctx = ReasoningContext::new().with_message(ChatMessage::user("Write a report"));
|
|
||||||
ctx.available_tools.push(ToolDefinition {
|
|
||||||
name: "memory_write".to_string(),
|
|
||||||
description: "Write to memory".to_string(),
|
|
||||||
parameters: serde_json::json!({"type": "object"}),
|
|
||||||
});
|
|
||||||
|
|
||||||
let selections = reasoning.select_tools(&ctx).await.unwrap();
|
|
||||||
assert!(
|
|
||||||
selections.is_empty(),
|
|
||||||
"Truncated tool selections should be discarded (got {} selections)",
|
|
||||||
selections.len()
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_select_tools_returns_selections_when_not_truncated() {
|
|
||||||
let llm = Arc::new(TruncatingLlm {
|
|
||||||
finish_reason: FinishReason::ToolUse,
|
|
||||||
});
|
|
||||||
let reasoning = Reasoning::new(llm);
|
|
||||||
let mut ctx = ReasoningContext::new().with_message(ChatMessage::user("Write a report"));
|
|
||||||
ctx.available_tools.push(ToolDefinition {
|
|
||||||
name: "memory_write".to_string(),
|
|
||||||
description: "Write to memory".to_string(),
|
|
||||||
parameters: serde_json::json!({"type": "object"}),
|
|
||||||
});
|
|
||||||
|
|
||||||
let selections = reasoning.select_tools(&ctx).await.unwrap();
|
|
||||||
assert_eq!(selections.len(), 1);
|
|
||||||
assert_eq!(selections[0].tool_name, "memory_write");
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
+20
-32
@@ -598,30 +598,6 @@ fn build_rig_request(
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Inject a per-request model override into the rig request's `additional_params`.
|
|
||||||
///
|
|
||||||
/// Rig-core bakes the model name at construction time inside each provider's
|
|
||||||
/// `CompletionModel` implementation. The actual HTTP request body includes a
|
|
||||||
/// `model` field set by the provider. Rig-core's `#[serde(flatten)]` on
|
|
||||||
/// `additional_params` emits these fields AFTER the provider's own fields.
|
|
||||||
/// Most API servers (Python, Go) use last-key-wins when deserializing
|
|
||||||
/// duplicate JSON keys, so the injected `model` value takes effect.
|
|
||||||
fn inject_model_override(rig_req: &mut RigRequest, model_override: Option<&str>) {
|
|
||||||
let Some(model) = model_override else {
|
|
||||||
return;
|
|
||||||
};
|
|
||||||
match rig_req.additional_params {
|
|
||||||
Some(ref mut params) => {
|
|
||||||
if let Some(obj) = params.as_object_mut() {
|
|
||||||
obj.insert("model".to_string(), serde_json::json!(model));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
None => {
|
|
||||||
rig_req.additional_params = Some(serde_json::json!({ "model": model }));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[async_trait]
|
#[async_trait]
|
||||||
impl<M> LlmProvider for RigAdapter<M>
|
impl<M> LlmProvider for RigAdapter<M>
|
||||||
where
|
where
|
||||||
@@ -656,7 +632,15 @@ where
|
|||||||
&self,
|
&self,
|
||||||
mut request: CompletionRequest,
|
mut request: CompletionRequest,
|
||||||
) -> Result<CompletionResponse, LlmError> {
|
) -> Result<CompletionResponse, LlmError> {
|
||||||
let model_override = request.model.take();
|
if let Some(requested_model) = request.model.as_deref()
|
||||||
|
&& requested_model != self.model_name.as_str()
|
||||||
|
{
|
||||||
|
tracing::warn!(
|
||||||
|
requested_model = requested_model,
|
||||||
|
active_model = %self.model_name,
|
||||||
|
"Per-request model override is not supported for this provider; using configured model"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
self.strip_unsupported_completion_params(&mut request);
|
self.strip_unsupported_completion_params(&mut request);
|
||||||
|
|
||||||
@@ -664,7 +648,7 @@ where
|
|||||||
crate::llm::provider::sanitize_tool_messages(&mut messages);
|
crate::llm::provider::sanitize_tool_messages(&mut messages);
|
||||||
let (preamble, history) = convert_messages(&messages);
|
let (preamble, history) = convert_messages(&messages);
|
||||||
|
|
||||||
let mut rig_req = build_rig_request(
|
let rig_req = build_rig_request(
|
||||||
preamble,
|
preamble,
|
||||||
history,
|
history,
|
||||||
Vec::new(),
|
Vec::new(),
|
||||||
@@ -674,8 +658,6 @@ where
|
|||||||
self.cache_retention,
|
self.cache_retention,
|
||||||
)?;
|
)?;
|
||||||
|
|
||||||
inject_model_override(&mut rig_req, model_override.as_deref());
|
|
||||||
|
|
||||||
let response =
|
let response =
|
||||||
self.model
|
self.model
|
||||||
.completion(rig_req)
|
.completion(rig_req)
|
||||||
@@ -713,7 +695,15 @@ where
|
|||||||
&self,
|
&self,
|
||||||
mut request: ToolCompletionRequest,
|
mut request: ToolCompletionRequest,
|
||||||
) -> Result<ToolCompletionResponse, LlmError> {
|
) -> Result<ToolCompletionResponse, LlmError> {
|
||||||
let model_override = request.model.take();
|
if let Some(requested_model) = request.model.as_deref()
|
||||||
|
&& requested_model != self.model_name.as_str()
|
||||||
|
{
|
||||||
|
tracing::warn!(
|
||||||
|
requested_model = requested_model,
|
||||||
|
active_model = %self.model_name,
|
||||||
|
"Per-request model override is not supported for this provider; using configured model"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
self.strip_unsupported_tool_params(&mut request);
|
self.strip_unsupported_tool_params(&mut request);
|
||||||
|
|
||||||
@@ -726,7 +716,7 @@ where
|
|||||||
let tools = convert_tools(&request.tools);
|
let tools = convert_tools(&request.tools);
|
||||||
let tool_choice = convert_tool_choice(request.tool_choice.as_deref());
|
let tool_choice = convert_tool_choice(request.tool_choice.as_deref());
|
||||||
|
|
||||||
let mut rig_req = build_rig_request(
|
let rig_req = build_rig_request(
|
||||||
preamble,
|
preamble,
|
||||||
history,
|
history,
|
||||||
tools,
|
tools,
|
||||||
@@ -736,8 +726,6 @@ where
|
|||||||
self.cache_retention,
|
self.cache_retention,
|
||||||
)?;
|
)?;
|
||||||
|
|
||||||
inject_model_override(&mut rig_req, model_override.as_deref());
|
|
||||||
|
|
||||||
let response =
|
let response =
|
||||||
self.model
|
self.model
|
||||||
.completion(rig_req)
|
.completion(rig_req)
|
||||||
|
|||||||
@@ -914,10 +914,6 @@ async fn async_main() -> anyhow::Result<()> {
|
|||||||
},
|
},
|
||||||
builder: components.builder,
|
builder: components.builder,
|
||||||
llm_backend: config.llm.backend.clone(),
|
llm_backend: config.llm.backend.clone(),
|
||||||
tenant_rates: Arc::new(ironclaw::tenant::TenantRateRegistry::new(
|
|
||||||
config.agent.max_llm_concurrent_per_user.unwrap_or(4),
|
|
||||||
config.agent.max_jobs_concurrent_per_user.unwrap_or(3),
|
|
||||||
)),
|
|
||||||
};
|
};
|
||||||
|
|
||||||
let channels_for_warnings = Arc::clone(&channels);
|
let channels_for_warnings = Arc::clone(&channels);
|
||||||
|
|||||||
-906
@@ -1,906 +0,0 @@
|
|||||||
//! Compile-time tenant isolation.
|
|
||||||
//!
|
|
||||||
//! Provides two database access tiers:
|
|
||||||
//!
|
|
||||||
//! - **[`TenantScope`]** (default): All operations are bound to a single user.
|
|
||||||
//! ID-based lookups return `None` if the resource doesn't belong to this user.
|
|
||||||
//! This is the only way handler code should access the database.
|
|
||||||
//!
|
|
||||||
//! - **[`AdminScope`]**: Cross-tenant access for system-level operations
|
|
||||||
//! (heartbeat, routine engine, self-repair). Must be obtained explicitly via
|
|
||||||
//! [`AgentDeps::admin_store()`](crate::agent::AgentDeps::admin_store).
|
|
||||||
//!
|
|
||||||
//! [`TenantCtx`] bundles a `TenantScope` with workspace, cost guard, and
|
|
||||||
//! per-tenant rate limiting. Constructed once per request at the entry point
|
|
||||||
//! where a `user_id` becomes known.
|
|
||||||
|
|
||||||
use std::collections::HashMap;
|
|
||||||
use std::sync::Arc;
|
|
||||||
|
|
||||||
use chrono::{DateTime, Utc};
|
|
||||||
use rust_decimal::Decimal;
|
|
||||||
use tokio::sync::{Semaphore, SemaphorePermit};
|
|
||||||
use uuid::Uuid;
|
|
||||||
|
|
||||||
use crate::agent::BrokenTool;
|
|
||||||
use crate::agent::cost_guard::{CostGuard, CostLimitExceeded};
|
|
||||||
use crate::agent::routine::{Routine, RoutineRun, RunStatus};
|
|
||||||
use crate::context::{ActionRecord, JobContext, JobState};
|
|
||||||
use crate::db::Database;
|
|
||||||
use crate::error::DatabaseError;
|
|
||||||
use crate::history::{
|
|
||||||
AgentJobRecord, AgentJobSummary, ConversationMessage, ConversationSummary, LlmCallRecord,
|
|
||||||
SandboxJobRecord, SandboxJobSummary, SettingRow,
|
|
||||||
};
|
|
||||||
use crate::workspace::Workspace;
|
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
// TenantScope — scoped database access (default tier)
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
|
|
||||||
/// Scoped database view. All operations are bound to a single user.
|
|
||||||
///
|
|
||||||
/// This is the **only** way handler code should access the database.
|
|
||||||
/// ID-based lookups (jobs, routines, sandbox jobs) automatically filter
|
|
||||||
/// by ownership — returning `None` when the resource belongs to a
|
|
||||||
/// different user.
|
|
||||||
#[derive(Clone)]
|
|
||||||
pub struct TenantScope {
|
|
||||||
user_id: String,
|
|
||||||
inner: Arc<dyn Database>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl TenantScope {
|
|
||||||
pub fn new(user_id: impl Into<String>, db: Arc<dyn Database>) -> Self {
|
|
||||||
Self {
|
|
||||||
user_id: user_id.into(),
|
|
||||||
inner: db,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn user_id(&self) -> &str {
|
|
||||||
&self.user_id
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Jobs ===
|
|
||||||
|
|
||||||
pub async fn list_agent_jobs(&self) -> Result<Vec<AgentJobRecord>, DatabaseError> {
|
|
||||||
self.inner.list_agent_jobs_for_user(&self.user_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn agent_job_summary(&self) -> Result<AgentJobSummary, DatabaseError> {
|
|
||||||
self.inner.agent_job_summary_for_user(&self.user_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Fetch a job by ID, returning `None` if it doesn't belong to this user.
|
|
||||||
pub async fn get_job(&self, id: Uuid) -> Result<Option<JobContext>, DatabaseError> {
|
|
||||||
match self.inner.get_job(id).await? {
|
|
||||||
Some(ctx) if ctx.user_id == self.user_id => Ok(Some(ctx)),
|
|
||||||
_ => Ok(None),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_agent_job_failure_reason(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
) -> Result<Option<String>, DatabaseError> {
|
|
||||||
// Verify ownership first
|
|
||||||
if self.get_job(id).await?.is_none() {
|
|
||||||
return Ok(None);
|
|
||||||
}
|
|
||||||
self.inner.get_agent_job_failure_reason(id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn update_job_status(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
status: JobState,
|
|
||||||
failure_reason: Option<&str>,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
// Verify ownership before mutating
|
|
||||||
if self.get_job(id).await?.is_none() {
|
|
||||||
return Err(DatabaseError::NotFound {
|
|
||||||
entity: "job".to_string(),
|
|
||||||
id: id.to_string(),
|
|
||||||
});
|
|
||||||
}
|
|
||||||
self.inner
|
|
||||||
.update_job_status(id, status, failure_reason)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Sandbox jobs ===
|
|
||||||
|
|
||||||
pub async fn list_sandbox_jobs(&self) -> Result<Vec<SandboxJobRecord>, DatabaseError> {
|
|
||||||
self.inner.list_sandbox_jobs_for_user(&self.user_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn sandbox_job_summary(&self) -> Result<SandboxJobSummary, DatabaseError> {
|
|
||||||
self.inner.sandbox_job_summary_for_user(&self.user_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Fetch a sandbox job by ID, returning `None` if it doesn't belong to this user.
|
|
||||||
pub async fn get_sandbox_job(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
) -> Result<Option<SandboxJobRecord>, DatabaseError> {
|
|
||||||
match self.inner.get_sandbox_job(id).await? {
|
|
||||||
Some(job) if job.user_id == self.user_id => Ok(Some(job)),
|
|
||||||
_ => Ok(None),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn sandbox_job_belongs_to_user(&self, job_id: Uuid) -> Result<bool, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.sandbox_job_belongs_to_user(job_id, &self.user_id)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Routines ===
|
|
||||||
|
|
||||||
pub async fn list_routines(&self) -> Result<Vec<Routine>, DatabaseError> {
|
|
||||||
self.inner.list_routines(&self.user_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_routine_by_name(&self, name: &str) -> Result<Option<Routine>, DatabaseError> {
|
|
||||||
self.inner.get_routine_by_name(&self.user_id, name).await
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Fetch a routine by ID, returning `None` if it doesn't belong to this user.
|
|
||||||
pub async fn get_routine(&self, id: Uuid) -> Result<Option<Routine>, DatabaseError> {
|
|
||||||
match self.inner.get_routine(id).await? {
|
|
||||||
Some(r) if r.user_id == self.user_id => Ok(Some(r)),
|
|
||||||
_ => Ok(None),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn create_routine(&self, routine: &Routine) -> Result<(), DatabaseError> {
|
|
||||||
debug_assert_eq!(
|
|
||||||
routine.user_id, self.user_id,
|
|
||||||
"routine.user_id must match TenantScope user"
|
|
||||||
);
|
|
||||||
self.inner.create_routine(routine).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn update_routine(&self, routine: &Routine) -> Result<(), DatabaseError> {
|
|
||||||
// Verify ownership
|
|
||||||
if self.get_routine(routine.id).await?.is_none() {
|
|
||||||
return Err(DatabaseError::NotFound {
|
|
||||||
entity: "routine".to_string(),
|
|
||||||
id: routine.id.to_string(),
|
|
||||||
});
|
|
||||||
}
|
|
||||||
self.inner.update_routine(routine).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn delete_routine(&self, id: Uuid) -> Result<bool, DatabaseError> {
|
|
||||||
// Verify ownership
|
|
||||||
if self.get_routine(id).await?.is_none() {
|
|
||||||
return Err(DatabaseError::NotFound {
|
|
||||||
entity: "routine".to_string(),
|
|
||||||
id: id.to_string(),
|
|
||||||
});
|
|
||||||
}
|
|
||||||
self.inner.delete_routine(id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
/// List routine runs, verifying the routine belongs to this user.
|
|
||||||
pub async fn list_routine_runs(
|
|
||||||
&self,
|
|
||||||
routine_id: Uuid,
|
|
||||||
limit: i64,
|
|
||||||
) -> Result<Vec<RoutineRun>, DatabaseError> {
|
|
||||||
// Verify routine ownership first
|
|
||||||
if self.get_routine(routine_id).await?.is_none() {
|
|
||||||
return Err(DatabaseError::NotFound {
|
|
||||||
entity: "routine".to_string(),
|
|
||||||
id: routine_id.to_string(),
|
|
||||||
});
|
|
||||||
}
|
|
||||||
self.inner.list_routine_runs(routine_id, limit).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_webhook_routine_by_path(
|
|
||||||
&self,
|
|
||||||
path: &str,
|
|
||||||
) -> Result<Option<Routine>, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.get_webhook_routine_by_path(path, Some(&self.user_id))
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Settings ===
|
|
||||||
|
|
||||||
pub async fn get_setting(&self, key: &str) -> Result<Option<serde_json::Value>, DatabaseError> {
|
|
||||||
self.inner.get_setting(&self.user_id, key).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_setting_full(&self, key: &str) -> Result<Option<SettingRow>, DatabaseError> {
|
|
||||||
self.inner.get_setting_full(&self.user_id, key).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn set_setting(
|
|
||||||
&self,
|
|
||||||
key: &str,
|
|
||||||
value: &serde_json::Value,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.set_setting(&self.user_id, key, value).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn delete_setting(&self, key: &str) -> Result<bool, DatabaseError> {
|
|
||||||
self.inner.delete_setting(&self.user_id, key).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_settings(&self) -> Result<Vec<SettingRow>, DatabaseError> {
|
|
||||||
self.inner.list_settings(&self.user_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_all_settings(
|
|
||||||
&self,
|
|
||||||
) -> Result<HashMap<String, serde_json::Value>, DatabaseError> {
|
|
||||||
self.inner.get_all_settings(&self.user_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn set_all_settings(
|
|
||||||
&self,
|
|
||||||
settings: &HashMap<String, serde_json::Value>,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.set_all_settings(&self.user_id, settings).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn has_settings(&self) -> Result<bool, DatabaseError> {
|
|
||||||
self.inner.has_settings(&self.user_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Conversations ===
|
|
||||||
|
|
||||||
pub async fn create_conversation(
|
|
||||||
&self,
|
|
||||||
channel: &str,
|
|
||||||
thread_id: Option<&str>,
|
|
||||||
) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.create_conversation(channel, &self.user_id, thread_id)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn ensure_conversation(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
channel: &str,
|
|
||||||
thread_id: Option<&str>,
|
|
||||||
) -> Result<bool, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.ensure_conversation(id, channel, &self.user_id, thread_id)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_conversations_with_preview(
|
|
||||||
&self,
|
|
||||||
channel: &str,
|
|
||||||
limit: i64,
|
|
||||||
) -> Result<Vec<ConversationSummary>, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.list_conversations_with_preview(&self.user_id, channel, limit)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_conversations_all_channels(
|
|
||||||
&self,
|
|
||||||
limit: i64,
|
|
||||||
) -> Result<Vec<ConversationSummary>, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.list_conversations_all_channels(&self.user_id, limit)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_or_create_routine_conversation(
|
|
||||||
&self,
|
|
||||||
routine_id: Uuid,
|
|
||||||
routine_name: &str,
|
|
||||||
) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.get_or_create_routine_conversation(routine_id, routine_name, &self.user_id)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_or_create_heartbeat_conversation(&self) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.get_or_create_heartbeat_conversation(&self.user_id)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_or_create_assistant_conversation(
|
|
||||||
&self,
|
|
||||||
channel: &str,
|
|
||||||
) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.get_or_create_assistant_conversation(&self.user_id, channel)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn conversation_belongs_to_user(
|
|
||||||
&self,
|
|
||||||
conversation_id: Uuid,
|
|
||||||
) -> Result<bool, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.conversation_belongs_to_user(conversation_id, &self.user_id)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Add a message to a conversation owned by this tenant.
|
|
||||||
///
|
|
||||||
/// Verifies the conversation belongs to this user before adding.
|
|
||||||
pub async fn add_conversation_message(
|
|
||||||
&self,
|
|
||||||
conversation_id: Uuid,
|
|
||||||
role: &str,
|
|
||||||
content: &str,
|
|
||||||
) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.add_conversation_message(conversation_id, role, content)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn touch_conversation(&self, id: Uuid) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.touch_conversation(id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_conversation_messages(
|
|
||||||
&self,
|
|
||||||
conversation_id: Uuid,
|
|
||||||
) -> Result<Vec<ConversationMessage>, DatabaseError> {
|
|
||||||
self.inner.list_conversation_messages(conversation_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_conversation_messages_paginated(
|
|
||||||
&self,
|
|
||||||
conversation_id: Uuid,
|
|
||||||
before: Option<DateTime<Utc>>,
|
|
||||||
limit: i64,
|
|
||||||
) -> Result<(Vec<ConversationMessage>, bool), DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.list_conversation_messages_paginated(conversation_id, before, limit)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn create_conversation_with_metadata(
|
|
||||||
&self,
|
|
||||||
channel: &str,
|
|
||||||
metadata: &serde_json::Value,
|
|
||||||
) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.create_conversation_with_metadata(channel, &self.user_id, metadata)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn update_conversation_metadata_field(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
key: &str,
|
|
||||||
value: &serde_json::Value,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.update_conversation_metadata_field(id, key, value)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_conversation_metadata(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
) -> Result<Option<serde_json::Value>, DatabaseError> {
|
|
||||||
self.inner.get_conversation_metadata(id).await
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
// AdminScope — explicit cross-tenant access
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
|
|
||||||
/// Cross-tenant database access for system-level operations.
|
|
||||||
///
|
|
||||||
/// **Not** available through [`TenantCtx`] — must be obtained explicitly via
|
|
||||||
/// [`AgentDeps::admin_store()`](crate::agent::AgentDeps::admin_store).
|
|
||||||
///
|
|
||||||
/// Used by: heartbeat enumeration, routine engine scheduling, self-repair,
|
|
||||||
/// scheduler job persistence, worker status updates.
|
|
||||||
#[derive(Clone)]
|
|
||||||
pub struct AdminScope {
|
|
||||||
inner: Arc<dyn Database>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl AdminScope {
|
|
||||||
pub fn new(db: Arc<dyn Database>) -> Self {
|
|
||||||
Self { inner: db }
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Access the raw Database trait object.
|
|
||||||
///
|
|
||||||
/// Prefer using the typed methods on AdminScope instead. This is provided
|
|
||||||
/// for call sites that need sub-trait access not yet wrapped here.
|
|
||||||
pub fn db(&self) -> &Arc<dyn Database> {
|
|
||||||
&self.inner
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Routine engine ===
|
|
||||||
|
|
||||||
pub async fn list_all_routines(&self) -> Result<Vec<Routine>, DatabaseError> {
|
|
||||||
self.inner.list_all_routines().await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_event_routines(&self) -> Result<Vec<Routine>, DatabaseError> {
|
|
||||||
self.inner.list_event_routines().await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_due_cron_routines(&self) -> Result<Vec<Routine>, DatabaseError> {
|
|
||||||
self.inner.list_due_cron_routines().await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_dispatched_routine_runs(&self) -> Result<Vec<RoutineRun>, DatabaseError> {
|
|
||||||
self.inner.list_dispatched_routine_runs().await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn count_running_routine_runs_batch(
|
|
||||||
&self,
|
|
||||||
routine_ids: &[Uuid],
|
|
||||||
) -> Result<HashMap<Uuid, i64>, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.count_running_routine_runs_batch(routine_ids)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn batch_get_last_run_status(
|
|
||||||
&self,
|
|
||||||
routine_ids: &[Uuid],
|
|
||||||
) -> Result<HashMap<Uuid, RunStatus>, DatabaseError> {
|
|
||||||
self.inner.batch_get_last_run_status(routine_ids).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn count_running_routine_runs(&self, routine_id: Uuid) -> Result<i64, DatabaseError> {
|
|
||||||
self.inner.count_running_routine_runs(routine_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn update_routine_runtime(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
last_run_at: DateTime<Utc>,
|
|
||||||
next_fire_at: Option<DateTime<Utc>>,
|
|
||||||
run_count: u64,
|
|
||||||
consecutive_failures: u32,
|
|
||||||
state: &serde_json::Value,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.update_routine_runtime(
|
|
||||||
id,
|
|
||||||
last_run_at,
|
|
||||||
next_fire_at,
|
|
||||||
run_count,
|
|
||||||
consecutive_failures,
|
|
||||||
state,
|
|
||||||
)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn create_routine_run(&self, run: &RoutineRun) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.create_routine_run(run).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn complete_routine_run(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
status: RunStatus,
|
|
||||||
result_summary: Option<&str>,
|
|
||||||
tokens_used: Option<i32>,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.complete_routine_run(id, status, result_summary, tokens_used)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn link_routine_run_to_job(
|
|
||||||
&self,
|
|
||||||
run_id: Uuid,
|
|
||||||
job_id: Uuid,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.link_routine_run_to_job(run_id, job_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_routine(&self, id: Uuid) -> Result<Option<Routine>, DatabaseError> {
|
|
||||||
self.inner.get_routine(id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn update_routine(&self, routine: &Routine) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.update_routine(routine).await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Self-repair ===
|
|
||||||
|
|
||||||
pub async fn get_stuck_jobs(&self) -> Result<Vec<Uuid>, DatabaseError> {
|
|
||||||
self.inner.get_stuck_jobs().await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_broken_tools(&self, threshold: i32) -> Result<Vec<BrokenTool>, DatabaseError> {
|
|
||||||
self.inner.get_broken_tools(threshold).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn record_tool_failure(
|
|
||||||
&self,
|
|
||||||
tool_name: &str,
|
|
||||||
error_message: &str,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.record_tool_failure(tool_name, error_message)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn mark_tool_repaired(&self, tool_name: &str) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.mark_tool_repaired(tool_name).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn increment_repair_attempts(&self, tool_name: &str) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.increment_repair_attempts(tool_name).await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Sandbox housekeeping ===
|
|
||||||
|
|
||||||
pub async fn cleanup_stale_sandbox_jobs(&self) -> Result<u64, DatabaseError> {
|
|
||||||
self.inner.cleanup_stale_sandbox_jobs().await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_sandbox_job(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
) -> Result<Option<SandboxJobRecord>, DatabaseError> {
|
|
||||||
self.inner.get_sandbox_job(id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn save_sandbox_job(&self, job: &SandboxJobRecord) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.save_sandbox_job(job).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn update_sandbox_job_status(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
status: &str,
|
|
||||||
success: Option<bool>,
|
|
||||||
message: Option<&str>,
|
|
||||||
started_at: Option<DateTime<Utc>>,
|
|
||||||
completed_at: Option<DateTime<Utc>>,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.update_sandbox_job_status(id, status, success, message, started_at, completed_at)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn update_sandbox_job_mode(&self, id: Uuid, mode: &str) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.update_sandbox_job_mode(id, mode).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_sandbox_job_mode(&self, id: Uuid) -> Result<Option<String>, DatabaseError> {
|
|
||||||
self.inner.get_sandbox_job_mode(id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn save_job_event(
|
|
||||||
&self,
|
|
||||||
job_id: Uuid,
|
|
||||||
event_type: &str,
|
|
||||||
data: &serde_json::Value,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.save_job_event(job_id, event_type, data).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_job_events(
|
|
||||||
&self,
|
|
||||||
job_id: Uuid,
|
|
||||||
limit: Option<i64>,
|
|
||||||
) -> Result<Vec<crate::history::JobEventRecord>, DatabaseError> {
|
|
||||||
self.inner.list_job_events(job_id, limit).await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Job persistence (scheduler, worker) ===
|
|
||||||
|
|
||||||
pub async fn get_job(&self, id: Uuid) -> Result<Option<JobContext>, DatabaseError> {
|
|
||||||
self.inner.get_job(id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn save_job(&self, ctx: &JobContext) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.save_job(ctx).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn update_job_status(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
status: JobState,
|
|
||||||
failure_reason: Option<&str>,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.update_job_status(id, status, failure_reason)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn mark_job_stuck(&self, id: Uuid) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.mark_job_stuck(id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn list_agent_jobs(&self) -> Result<Vec<AgentJobRecord>, DatabaseError> {
|
|
||||||
self.inner.list_agent_jobs().await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_agent_job_failure_reason(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
) -> Result<Option<String>, DatabaseError> {
|
|
||||||
self.inner.get_agent_job_failure_reason(id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === LLM call recording ===
|
|
||||||
|
|
||||||
pub async fn record_llm_call(&self, record: &LlmCallRecord<'_>) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner.record_llm_call(record).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn save_action(
|
|
||||||
&self,
|
|
||||||
job_id: Uuid,
|
|
||||||
action: &ActionRecord,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner.save_action(job_id, action).await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_job_actions(&self, job_id: Uuid) -> Result<Vec<ActionRecord>, DatabaseError> {
|
|
||||||
self.inner.get_job_actions(job_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Estimation ===
|
|
||||||
|
|
||||||
pub async fn save_estimation_snapshot(
|
|
||||||
&self,
|
|
||||||
job_id: Uuid,
|
|
||||||
category: &str,
|
|
||||||
tool_names: &[String],
|
|
||||||
estimated_cost: Decimal,
|
|
||||||
estimated_time_secs: i32,
|
|
||||||
estimated_value: Decimal,
|
|
||||||
) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.save_estimation_snapshot(
|
|
||||||
job_id,
|
|
||||||
category,
|
|
||||||
tool_names,
|
|
||||||
estimated_cost,
|
|
||||||
estimated_time_secs,
|
|
||||||
estimated_value,
|
|
||||||
)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn update_estimation_actuals(
|
|
||||||
&self,
|
|
||||||
id: Uuid,
|
|
||||||
actual_cost: Decimal,
|
|
||||||
actual_time_secs: i32,
|
|
||||||
actual_value: Option<Decimal>,
|
|
||||||
) -> Result<(), DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.update_estimation_actuals(id, actual_cost, actual_time_secs, actual_value)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
// === Conversations (admin context) ===
|
|
||||||
|
|
||||||
pub async fn add_conversation_message(
|
|
||||||
&self,
|
|
||||||
conversation_id: Uuid,
|
|
||||||
role: &str,
|
|
||||||
content: &str,
|
|
||||||
) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.add_conversation_message(conversation_id, role, content)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_or_create_routine_conversation(
|
|
||||||
&self,
|
|
||||||
routine_id: Uuid,
|
|
||||||
routine_name: &str,
|
|
||||||
user_id: &str,
|
|
||||||
) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.get_or_create_routine_conversation(routine_id, routine_name, user_id)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
pub async fn get_or_create_heartbeat_conversation(
|
|
||||||
&self,
|
|
||||||
user_id: &str,
|
|
||||||
) -> Result<Uuid, DatabaseError> {
|
|
||||||
self.inner
|
|
||||||
.get_or_create_heartbeat_conversation(user_id)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
// TenantRateState / TenantRateRegistry — per-user concurrency
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
|
|
||||||
/// Per-tenant concurrency limits.
|
|
||||||
pub struct TenantRateState {
|
|
||||||
/// Limits concurrent LLM calls for this user.
|
|
||||||
pub llm_semaphore: Arc<Semaphore>,
|
|
||||||
/// Limits concurrent jobs for this user.
|
|
||||||
pub job_semaphore: Arc<Semaphore>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl TenantRateState {
|
|
||||||
pub fn new(max_llm_concurrent: usize, max_job_concurrent: usize) -> Self {
|
|
||||||
Self {
|
|
||||||
llm_semaphore: Arc::new(Semaphore::new(max_llm_concurrent)),
|
|
||||||
job_semaphore: Arc::new(Semaphore::new(max_job_concurrent)),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Registry that lazily creates per-tenant rate state.
|
|
||||||
///
|
|
||||||
/// Uses `tokio::sync::RwLock<HashMap>` (consistent with the rest of the
|
|
||||||
/// codebase — no DashMap dependency).
|
|
||||||
pub struct TenantRateRegistry {
|
|
||||||
state: tokio::sync::RwLock<HashMap<String, Arc<TenantRateState>>>,
|
|
||||||
max_llm_concurrent: usize,
|
|
||||||
max_job_concurrent: usize,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl TenantRateRegistry {
|
|
||||||
pub fn new(max_llm_concurrent: usize, max_job_concurrent: usize) -> Self {
|
|
||||||
Self {
|
|
||||||
state: tokio::sync::RwLock::new(HashMap::new()),
|
|
||||||
max_llm_concurrent,
|
|
||||||
max_job_concurrent,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Get or lazily create rate state for a user.
|
|
||||||
pub async fn get_or_create(&self, user_id: &str) -> Arc<TenantRateState> {
|
|
||||||
// Fast path: read lock
|
|
||||||
{
|
|
||||||
let map = self.state.read().await;
|
|
||||||
if let Some(s) = map.get(user_id) {
|
|
||||||
return Arc::clone(s);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
// Slow path: write lock with double-check
|
|
||||||
let mut map = self.state.write().await;
|
|
||||||
if let Some(s) = map.get(user_id) {
|
|
||||||
return Arc::clone(s);
|
|
||||||
}
|
|
||||||
let s = Arc::new(TenantRateState::new(
|
|
||||||
self.max_llm_concurrent,
|
|
||||||
self.max_job_concurrent,
|
|
||||||
));
|
|
||||||
map.insert(user_id.to_string(), Arc::clone(&s));
|
|
||||||
s
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
// TenantCtx — per-request tenant execution context
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
|
|
||||||
/// Per-request tenant execution context.
|
|
||||||
///
|
|
||||||
/// Bundles a [`TenantScope`] (scoped DB access), workspace, cost guard,
|
|
||||||
/// and per-tenant rate limiting. Constructed once per request via
|
|
||||||
/// [`AgentDeps::tenant_ctx()`](crate::agent::AgentDeps::tenant_ctx).
|
|
||||||
///
|
|
||||||
/// `Clone + Send + Sync` — safe to store on `ChatDelegate` without lifetime issues.
|
|
||||||
#[derive(Clone)]
|
|
||||||
pub struct TenantCtx {
|
|
||||||
user_id: String,
|
|
||||||
store: Option<TenantScope>,
|
|
||||||
workspace: Option<Arc<Workspace>>,
|
|
||||||
cost_guard: Arc<CostGuard>,
|
|
||||||
rate: Arc<TenantRateState>,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl TenantCtx {
|
|
||||||
pub fn new(
|
|
||||||
user_id: impl Into<String>,
|
|
||||||
store: Option<TenantScope>,
|
|
||||||
workspace: Option<Arc<Workspace>>,
|
|
||||||
cost_guard: Arc<CostGuard>,
|
|
||||||
rate: Arc<TenantRateState>,
|
|
||||||
) -> Self {
|
|
||||||
Self {
|
|
||||||
user_id: user_id.into(),
|
|
||||||
store,
|
|
||||||
workspace,
|
|
||||||
cost_guard,
|
|
||||||
rate,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn user_id(&self) -> &str {
|
|
||||||
&self.user_id
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn store(&self) -> Option<&TenantScope> {
|
|
||||||
self.store.as_ref()
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn workspace(&self) -> Option<&Arc<Workspace>> {
|
|
||||||
self.workspace.as_ref()
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn cost_guard(&self) -> &CostGuard {
|
|
||||||
&self.cost_guard
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Check cost limits for this tenant (global + per-user).
|
|
||||||
pub async fn check_cost_allowed(&self) -> Result<(), CostLimitExceeded> {
|
|
||||||
self.cost_guard.check_allowed_for_user(&self.user_id).await
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Record an LLM call for this tenant.
|
|
||||||
#[allow(clippy::too_many_arguments)]
|
|
||||||
pub async fn record_llm_call(
|
|
||||||
&self,
|
|
||||||
model: &str,
|
|
||||||
input_tokens: u32,
|
|
||||||
output_tokens: u32,
|
|
||||||
cache_read_input_tokens: u32,
|
|
||||||
cache_creation_input_tokens: u32,
|
|
||||||
cache_read_discount: Decimal,
|
|
||||||
cache_write_multiplier: Decimal,
|
|
||||||
cost_per_token: Option<(Decimal, Decimal)>,
|
|
||||||
) -> Decimal {
|
|
||||||
self.cost_guard
|
|
||||||
.record_llm_call_for_user(
|
|
||||||
&self.user_id,
|
|
||||||
model,
|
|
||||||
input_tokens,
|
|
||||||
output_tokens,
|
|
||||||
cache_read_input_tokens,
|
|
||||||
cache_creation_input_tokens,
|
|
||||||
cache_read_discount,
|
|
||||||
cache_write_multiplier,
|
|
||||||
cost_per_token,
|
|
||||||
)
|
|
||||||
.await
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Acquire an LLM concurrency permit for this tenant.
|
|
||||||
pub async fn acquire_llm_permit(&self) -> Result<SemaphorePermit<'_>, crate::error::Error> {
|
|
||||||
self.rate.llm_semaphore.acquire().await.map_err(|_| {
|
|
||||||
crate::error::Error::Config(crate::error::ConfigError::InvalidValue {
|
|
||||||
key: "llm_semaphore".to_string(),
|
|
||||||
message: "semaphore closed".to_string(),
|
|
||||||
})
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
// Tests
|
|
||||||
// ---------------------------------------------------------------------------
|
|
||||||
|
|
||||||
#[cfg(test)]
|
|
||||||
mod tests {
|
|
||||||
use super::*;
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_rate_registry_returns_same_state_for_same_user() {
|
|
||||||
let registry = TenantRateRegistry::new(4, 3);
|
|
||||||
let a1 = registry.get_or_create("alice").await;
|
|
||||||
let a2 = registry.get_or_create("alice").await;
|
|
||||||
assert!(Arc::ptr_eq(&a1, &a2));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_rate_registry_different_users_get_different_state() {
|
|
||||||
let registry = TenantRateRegistry::new(4, 3);
|
|
||||||
let alice = registry.get_or_create("alice").await;
|
|
||||||
let bob = registry.get_or_create("bob").await;
|
|
||||||
assert!(!Arc::ptr_eq(&alice, &bob));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -532,7 +532,6 @@ impl TestHarnessBuilder {
|
|||||||
let cost_guard = Arc::new(CostGuard::new(CostGuardConfig {
|
let cost_guard = Arc::new(CostGuard::new(CostGuardConfig {
|
||||||
max_cost_per_day_cents: None,
|
max_cost_per_day_cents: None,
|
||||||
max_actions_per_hour: None,
|
max_actions_per_hour: None,
|
||||||
max_cost_per_user_per_day_cents: None,
|
|
||||||
}));
|
}));
|
||||||
|
|
||||||
let channel = if self.stub_channel {
|
let channel = if self.stub_channel {
|
||||||
@@ -565,7 +564,6 @@ impl TestHarnessBuilder {
|
|||||||
sandbox_readiness: crate::agent::routine_engine::SandboxReadiness::DisabledByConfig,
|
sandbox_readiness: crate::agent::routine_engine::SandboxReadiness::DisabledByConfig,
|
||||||
builder: None,
|
builder: None,
|
||||||
llm_backend: "nearai".to_string(),
|
llm_backend: "nearai".to_string(),
|
||||||
tenant_rates: std::sync::Arc::new(crate::tenant::TenantRateRegistry::new(4, 3)),
|
|
||||||
};
|
};
|
||||||
|
|
||||||
TestHarness {
|
TestHarness {
|
||||||
|
|||||||
@@ -650,23 +650,6 @@ pub(crate) fn routine_update_parameters_schema() -> Value {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
const ROUTINE_LAST_NAME_STASH_KEY: &str = "__routine_last_name";
|
|
||||||
|
|
||||||
async fn stash_last_routine_name(ctx: &JobContext, name: &str) {
|
|
||||||
ctx.tool_output_stash
|
|
||||||
.write()
|
|
||||||
.await
|
|
||||||
.insert(ROUTINE_LAST_NAME_STASH_KEY.to_string(), name.to_string());
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn restore_last_routine_name(ctx: &JobContext) -> Option<String> {
|
|
||||||
ctx.tool_output_stash
|
|
||||||
.read()
|
|
||||||
.await
|
|
||||||
.get(ROUTINE_LAST_NAME_STASH_KEY)
|
|
||||||
.cloned()
|
|
||||||
}
|
|
||||||
|
|
||||||
fn nested_object<'a>(params: &'a Value, field: &str) -> Option<&'a Map<String, Value>> {
|
fn nested_object<'a>(params: &'a Value, field: &str) -> Option<&'a Map<String, Value>> {
|
||||||
params.get(field).and_then(Value::as_object)
|
params.get(field).and_then(Value::as_object)
|
||||||
}
|
}
|
||||||
@@ -932,7 +915,7 @@ fn parse_routine_create_request(
|
|||||||
fn build_routine_trigger(trigger: &NormalizedTriggerRequest) -> Trigger {
|
fn build_routine_trigger(trigger: &NormalizedTriggerRequest) -> Trigger {
|
||||||
match trigger {
|
match trigger {
|
||||||
NormalizedTriggerRequest::Cron { schedule, timezone } => Trigger::Cron {
|
NormalizedTriggerRequest::Cron { schedule, timezone } => Trigger::Cron {
|
||||||
schedule: normalize_cron_expression(schedule),
|
schedule: schedule.clone(),
|
||||||
timezone: timezone.clone(),
|
timezone: timezone.clone(),
|
||||||
},
|
},
|
||||||
NormalizedTriggerRequest::Manual => Trigger::Manual,
|
NormalizedTriggerRequest::Manual => Trigger::Manual,
|
||||||
@@ -1110,7 +1093,6 @@ impl Tool for RoutineCreateTool {
|
|||||||
) -> Result<ToolOutput, ToolError> {
|
) -> Result<ToolOutput, ToolError> {
|
||||||
let start = std::time::Instant::now();
|
let start = std::time::Instant::now();
|
||||||
let normalized = parse_routine_create_request(¶ms)?;
|
let normalized = parse_routine_create_request(¶ms)?;
|
||||||
stash_last_routine_name(ctx, &normalized.name).await;
|
|
||||||
let trigger = build_routine_trigger(&normalized.trigger);
|
let trigger = build_routine_trigger(&normalized.trigger);
|
||||||
let action =
|
let action =
|
||||||
build_routine_action(&normalized.name, &normalized.prompt, &normalized.execution);
|
build_routine_action(&normalized.name, &normalized.prompt, &normalized.execution);
|
||||||
@@ -1292,7 +1274,6 @@ impl Tool for RoutineUpdateTool {
|
|||||||
let start = std::time::Instant::now();
|
let start = std::time::Instant::now();
|
||||||
|
|
||||||
let name = require_str(¶ms, "name")?;
|
let name = require_str(¶ms, "name")?;
|
||||||
stash_last_routine_name(ctx, name).await;
|
|
||||||
|
|
||||||
let mut routine = self
|
let mut routine = self
|
||||||
.store
|
.store
|
||||||
@@ -1430,24 +1411,11 @@ impl Tool for RoutineDeleteTool {
|
|||||||
) -> Result<ToolOutput, ToolError> {
|
) -> Result<ToolOutput, ToolError> {
|
||||||
let start = std::time::Instant::now();
|
let start = std::time::Instant::now();
|
||||||
|
|
||||||
let name = if let Some(name) = params.get("name").and_then(|v| v.as_str()) {
|
let name = require_str(¶ms, "name")?;
|
||||||
if name.trim().is_empty() {
|
|
||||||
return Err(ToolError::InvalidParameters(
|
|
||||||
"'name' parameter cannot be empty".to_string(),
|
|
||||||
));
|
|
||||||
}
|
|
||||||
name.to_string()
|
|
||||||
} else {
|
|
||||||
restore_last_routine_name(ctx).await.ok_or_else(|| {
|
|
||||||
ToolError::InvalidParameters(
|
|
||||||
"missing 'name' parameter and no previous routine target to infer".to_string(),
|
|
||||||
)
|
|
||||||
})?
|
|
||||||
};
|
|
||||||
|
|
||||||
let routine = self
|
let routine = self
|
||||||
.store
|
.store
|
||||||
.get_routine_by_name(&ctx.user_id, &name)
|
.get_routine_by_name(&ctx.user_id, name)
|
||||||
.await
|
.await
|
||||||
.map_err(|e| ToolError::ExecutionFailed(format!("DB error: {e}")))?
|
.map_err(|e| ToolError::ExecutionFailed(format!("DB error: {e}")))?
|
||||||
.ok_or_else(|| ToolError::ExecutionFailed(format!("routine '{}' not found", name)))?;
|
.ok_or_else(|| ToolError::ExecutionFailed(format!("routine '{}' not found", name)))?;
|
||||||
@@ -1462,7 +1430,7 @@ impl Tool for RoutineDeleteTool {
|
|||||||
self.engine.refresh_event_cache().await;
|
self.engine.refresh_event_cache().await;
|
||||||
|
|
||||||
let result = serde_json::json!({
|
let result = serde_json::json!({
|
||||||
"name": &name,
|
"name": name,
|
||||||
"deleted": deleted,
|
"deleted": deleted,
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -1868,20 +1836,6 @@ mod tests {
|
|||||||
assert_eq!(parsed.cooldown_secs, 30);
|
assert_eq!(parsed.cooldown_secs, 30);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn build_routine_trigger_normalizes_cron_schedule() {
|
|
||||||
let trigger = build_routine_trigger(&NormalizedTriggerRequest::Cron {
|
|
||||||
schedule: "0 0 9 * * MON-FRI".to_string(),
|
|
||||||
timezone: Some("UTC".to_string()),
|
|
||||||
});
|
|
||||||
|
|
||||||
assert!(matches!(
|
|
||||||
trigger,
|
|
||||||
Trigger::Cron { schedule, timezone }
|
|
||||||
if schedule == "0 0 9 * * MON-FRI *" && timezone.as_deref() == Some("UTC")
|
|
||||||
));
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn parses_grouped_message_event_with_tools() {
|
fn parses_grouped_message_event_with_tools() {
|
||||||
let params = serde_json::json!({
|
let params = serde_json::json!({
|
||||||
|
|||||||
+1
-19
@@ -117,11 +117,6 @@ impl McpClient {
|
|||||||
/// The config must use HTTP transport (the default); for stdio/UDS use `new_with_transport`.
|
/// The config must use HTTP transport (the default); for stdio/UDS use `new_with_transport`.
|
||||||
///
|
///
|
||||||
/// Returns an error if the config uses a non-HTTP transport.
|
/// Returns an error if the config uses a non-HTTP transport.
|
||||||
///
|
|
||||||
/// **Note:** The session manager is NOT wired into the transport. For
|
|
||||||
/// production use, prefer `create_client_from_config()` which constructs
|
|
||||||
/// the transport with session tracking.
|
|
||||||
#[cfg(test)]
|
|
||||||
pub fn new_with_config(config: McpServerConfig) -> Result<Self, ToolError> {
|
pub fn new_with_config(config: McpServerConfig) -> Result<Self, ToolError> {
|
||||||
if !matches!(
|
if !matches!(
|
||||||
config.effective_transport(),
|
config.effective_transport(),
|
||||||
@@ -219,14 +214,7 @@ impl McpClient {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Attach a session manager to the **client** only.
|
/// Attach a session manager for Streamable HTTP session tracking.
|
||||||
///
|
|
||||||
/// **Warning:** This does NOT wire the session manager into the underlying
|
|
||||||
/// `HttpMcpTransport`, so the transport will not capture `Mcp-Session-Id`
|
|
||||||
/// from responses. For production use, construct the transport with
|
|
||||||
/// `HttpMcpTransport::with_session_manager()` and pass it to
|
|
||||||
/// `new_with_transport()` instead. See `create_client_from_config()`.
|
|
||||||
#[cfg(test)]
|
|
||||||
pub fn with_session_manager(mut self, session_manager: Arc<McpSessionManager>) -> Self {
|
pub fn with_session_manager(mut self, session_manager: Arc<McpSessionManager>) -> Self {
|
||||||
self.session_manager = Some(session_manager);
|
self.session_manager = Some(session_manager);
|
||||||
self
|
self
|
||||||
@@ -247,12 +235,6 @@ impl McpClient {
|
|||||||
self.session_manager.is_some()
|
self.session_manager.is_some()
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Get the underlying transport (test-only).
|
|
||||||
#[cfg(test)]
|
|
||||||
pub(crate) fn transport(&self) -> &Arc<dyn McpTransport> {
|
|
||||||
&self.transport
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Get the next request ID.
|
/// Get the next request ID.
|
||||||
fn next_request_id(&self) -> u64 {
|
fn next_request_id(&self) -> u64 {
|
||||||
self.next_id.fetch_add(1, Ordering::SeqCst)
|
self.next_id.fetch_add(1, Ordering::SeqCst)
|
||||||
|
|||||||
+17
-102
@@ -7,7 +7,6 @@ use std::sync::Arc;
|
|||||||
|
|
||||||
use crate::secrets::SecretsStore;
|
use crate::secrets::SecretsStore;
|
||||||
use crate::tools::mcp::config::{EffectiveTransport, McpServerConfig};
|
use crate::tools::mcp::config::{EffectiveTransport, McpServerConfig};
|
||||||
use crate::tools::mcp::http_transport::HttpMcpTransport;
|
|
||||||
use crate::tools::mcp::{McpClient, McpProcessManager, McpSessionManager, McpTransport};
|
use crate::tools::mcp::{McpClient, McpProcessManager, McpSessionManager, McpTransport};
|
||||||
|
|
||||||
/// Error returned when MCP client creation fails.
|
/// Error returned when MCP client creation fails.
|
||||||
@@ -79,37 +78,33 @@ pub async fn create_client_from_config(
|
|||||||
Err(McpFactoryError::UnixNotSupported { name: server_name })
|
Err(McpFactoryError::UnixNotSupported { name: server_name })
|
||||||
}
|
}
|
||||||
EffectiveTransport::Http => {
|
EffectiveTransport::Http => {
|
||||||
// Authenticated (OAuth) path: tokens exist or server requires auth.
|
|
||||||
if let Some(ref secrets) = secrets {
|
if let Some(ref secrets) = secrets {
|
||||||
let has_tokens =
|
let has_tokens =
|
||||||
crate::tools::mcp::is_authenticated(&server, secrets, user_id).await;
|
crate::tools::mcp::is_authenticated(&server, secrets, user_id).await;
|
||||||
|
|
||||||
if has_tokens || server.requires_auth() {
|
if has_tokens || server.requires_auth() {
|
||||||
return Ok(McpClient::new_authenticated(
|
Ok(McpClient::new_authenticated(
|
||||||
server,
|
server,
|
||||||
Arc::clone(session_manager),
|
Arc::clone(session_manager),
|
||||||
Arc::clone(secrets),
|
Arc::clone(secrets),
|
||||||
user_id,
|
user_id,
|
||||||
));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Non-OAuth HTTP: wire the session manager into the *transport* so
|
|
||||||
// it captures `Mcp-Session-Id` from responses. Passing it only to
|
|
||||||
// the client (via `with_session_manager`) is not enough — the
|
|
||||||
// transport must know about it to read/write the header.
|
|
||||||
let transport = Arc::new(
|
|
||||||
HttpMcpTransport::new(server.url.clone(), server.name.clone())
|
|
||||||
.with_session_manager(Arc::clone(session_manager)),
|
|
||||||
);
|
|
||||||
Ok(McpClient::new_with_transport(
|
|
||||||
server.name.clone(),
|
|
||||||
transport,
|
|
||||||
Some(Arc::clone(session_manager)),
|
|
||||||
secrets,
|
|
||||||
user_id,
|
|
||||||
Some(server),
|
|
||||||
))
|
))
|
||||||
|
} else {
|
||||||
|
Ok(McpClient::new_with_config(server)
|
||||||
|
.map_err(|e| McpFactoryError::InvalidConfig {
|
||||||
|
name: server_name.clone(),
|
||||||
|
reason: e.to_string(),
|
||||||
|
})?
|
||||||
|
.with_session_manager(Arc::clone(session_manager)))
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
Ok(McpClient::new_with_config(server)
|
||||||
|
.map_err(|e| McpFactoryError::InvalidConfig {
|
||||||
|
name: server_name,
|
||||||
|
reason: e.to_string(),
|
||||||
|
})?
|
||||||
|
.with_session_manager(Arc::clone(session_manager)))
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -139,84 +134,4 @@ mod tests {
|
|||||||
"non-OAuth HTTP clients must carry a session manager"
|
"non-OAuth HTTP clients must carry a session manager"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Regression test: the factory must wire the session manager into the
|
|
||||||
/// *transport*, not just the client. Otherwise the transport never
|
|
||||||
/// captures `Mcp-Session-Id` from responses and subsequent requests
|
|
||||||
/// lack the header, causing the server to reject them.
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_factory_non_oauth_http_transport_captures_session_id() {
|
|
||||||
use axum::http::header::HeaderName;
|
|
||||||
use axum::{Router, http::StatusCode, response::IntoResponse, routing::post};
|
|
||||||
use tokio::net::TcpListener;
|
|
||||||
|
|
||||||
const SESSION_ID: &str = "test-session-abc123";
|
|
||||||
|
|
||||||
async fn session_echo() -> impl IntoResponse {
|
|
||||||
let body = serde_json::json!({
|
|
||||||
"jsonrpc": "2.0",
|
|
||||||
"id": 1,
|
|
||||||
"result": {}
|
|
||||||
})
|
|
||||||
.to_string();
|
|
||||||
(
|
|
||||||
StatusCode::OK,
|
|
||||||
[(
|
|
||||||
HeaderName::from_static("mcp-session-id"),
|
|
||||||
SESSION_ID.to_string(),
|
|
||||||
)],
|
|
||||||
body,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
|
|
||||||
let app = Router::new().route("/", post(session_echo));
|
|
||||||
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
|
|
||||||
let addr = listener.local_addr().unwrap();
|
|
||||||
let url = format!("http://127.0.0.1:{}", addr.port());
|
|
||||||
|
|
||||||
tokio::spawn(async move {
|
|
||||||
axum::serve(listener, app).await.unwrap();
|
|
||||||
});
|
|
||||||
|
|
||||||
let server = McpServerConfig::new("session-test", &url);
|
|
||||||
let session_manager = Arc::new(McpSessionManager::new());
|
|
||||||
let process_manager = Arc::new(McpProcessManager::new());
|
|
||||||
|
|
||||||
let client = create_client_from_config(
|
|
||||||
server,
|
|
||||||
&session_manager,
|
|
||||||
&process_manager,
|
|
||||||
None,
|
|
||||||
"test-user",
|
|
||||||
)
|
|
||||||
.await
|
|
||||||
.expect("factory should succeed for HTTP config");
|
|
||||||
|
|
||||||
// Pre-create a session entry so that update_session_id has something to update.
|
|
||||||
// In production, the MCP initialize handshake calls get_or_create before responses arrive.
|
|
||||||
session_manager.get_or_create("session-test", &url).await;
|
|
||||||
|
|
||||||
// Send a request through the client's transport to trigger session capture.
|
|
||||||
use crate::tools::mcp::protocol::McpRequest;
|
|
||||||
let request = McpRequest {
|
|
||||||
jsonrpc: "2.0".to_string(),
|
|
||||||
id: Some(1),
|
|
||||||
method: "test".to_string(),
|
|
||||||
params: Some(serde_json::json!({})),
|
|
||||||
};
|
|
||||||
let headers = std::collections::HashMap::new();
|
|
||||||
client
|
|
||||||
.transport()
|
|
||||||
.send(&request, &headers)
|
|
||||||
.await
|
|
||||||
.expect("request should succeed");
|
|
||||||
|
|
||||||
// Verify the session manager captured the session ID from the response.
|
|
||||||
let captured = session_manager.get_session_id("session-test").await;
|
|
||||||
assert_eq!(
|
|
||||||
captured.as_deref(),
|
|
||||||
Some(SESSION_ID),
|
|
||||||
"transport must capture Mcp-Session-Id into session manager"
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -494,34 +494,6 @@ mod tests {
|
|||||||
assert_eq!(echoed["authorization"], "Bearer oauth-token");
|
assert_eq!(echoed["authorization"], "Bearer oauth-token");
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Regression test for #1436: 202 Accepted responses for notifications
|
|
||||||
/// were parsed as JSON, causing "Failed to parse MCP response" errors
|
|
||||||
/// that broke the MCP session handshake.
|
|
||||||
#[tokio::test]
|
|
||||||
async fn test_wire_202_accepted_for_notification() {
|
|
||||||
use axum::{Router, http::StatusCode, routing::post};
|
|
||||||
use tokio::net::TcpListener;
|
|
||||||
|
|
||||||
async fn accept_notification() -> StatusCode {
|
|
||||||
StatusCode::ACCEPTED
|
|
||||||
}
|
|
||||||
|
|
||||||
let app = Router::new().route("/", post(accept_notification));
|
|
||||||
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
|
|
||||||
let addr = listener.local_addr().unwrap();
|
|
||||||
let url = format!("http://127.0.0.1:{}", addr.port());
|
|
||||||
|
|
||||||
tokio::spawn(async move {
|
|
||||||
axum::serve(listener, app).await.unwrap();
|
|
||||||
});
|
|
||||||
|
|
||||||
let transport = HttpMcpTransport::new(&url, "test-202");
|
|
||||||
let request = McpRequest::initialized_notification();
|
|
||||||
let response = transport.send(&request, &HashMap::new()).await.unwrap();
|
|
||||||
assert!(response.result.is_none());
|
|
||||||
assert!(response.error.is_none());
|
|
||||||
}
|
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_wire_custom_auth_preserved_when_no_per_request_auth() {
|
async fn test_wire_custom_auth_preserved_when_no_per_request_auth() {
|
||||||
let (url, _handle) = spawn_echo_server().await;
|
let (url, _handle) = spawn_echo_server().await;
|
||||||
|
|||||||
@@ -446,14 +446,16 @@ fn resolve_oauth_refresh_config(cap_file: &CapabilitiesFile) -> Option<OAuthRefr
|
|||||||
builtin.as_ref(),
|
builtin.as_ref(),
|
||||||
exchange_proxy_url.is_some(),
|
exchange_proxy_url.is_some(),
|
||||||
);
|
);
|
||||||
let oauth_proxy_auth_token = crate::cli::oauth_defaults::oauth_proxy_auth_token();
|
let gateway_token = crate::config::helpers::env_or_override("GATEWAY_AUTH_TOKEN")
|
||||||
|
.map(|token| token.trim().to_string())
|
||||||
|
.filter(|token| !token.is_empty());
|
||||||
|
|
||||||
Some(OAuthRefreshConfig {
|
Some(OAuthRefreshConfig {
|
||||||
token_url: oauth.token_url.clone(),
|
token_url: oauth.token_url.clone(),
|
||||||
client_id,
|
client_id,
|
||||||
client_secret,
|
client_secret,
|
||||||
exchange_proxy_url,
|
exchange_proxy_url,
|
||||||
gateway_token: oauth_proxy_auth_token,
|
gateway_token,
|
||||||
secret_name: auth.secret_name.clone(),
|
secret_name: auth.secret_name.clone(),
|
||||||
provider: auth.provider.clone(),
|
provider: auth.provider.clone(),
|
||||||
})
|
})
|
||||||
@@ -889,11 +891,6 @@ mod tests {
|
|||||||
AuthCapabilitySchema, CapabilitiesFile, OAuthConfigSchema,
|
AuthCapabilitySchema, CapabilitiesFile, OAuthConfigSchema,
|
||||||
};
|
};
|
||||||
|
|
||||||
let _guard = lock_env();
|
|
||||||
let _proxy_guard = set_env_var("IRONCLAW_OAUTH_EXCHANGE_URL", None);
|
|
||||||
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", None);
|
|
||||||
let _oauth_proxy_token_guard = set_env_var("IRONCLAW_OAUTH_PROXY_AUTH_TOKEN", None);
|
|
||||||
|
|
||||||
let caps = CapabilitiesFile {
|
let caps = CapabilitiesFile {
|
||||||
auth: Some(AuthCapabilitySchema {
|
auth: Some(AuthCapabilitySchema {
|
||||||
secret_name: "google_oauth_token".to_string(),
|
secret_name: "google_oauth_token".to_string(),
|
||||||
@@ -985,7 +982,6 @@ mod tests {
|
|||||||
let _guard = lock_env();
|
let _guard = lock_env();
|
||||||
let _proxy_guard = set_env_var("IRONCLAW_OAUTH_EXCHANGE_URL", None);
|
let _proxy_guard = set_env_var("IRONCLAW_OAUTH_EXCHANGE_URL", None);
|
||||||
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", None);
|
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", None);
|
||||||
let _oauth_proxy_token_guard = set_env_var("IRONCLAW_OAUTH_PROXY_AUTH_TOKEN", None);
|
|
||||||
|
|
||||||
// google_oauth_token should fall back to built-in credentials
|
// google_oauth_token should fall back to built-in credentials
|
||||||
let caps = CapabilitiesFile {
|
let caps = CapabilitiesFile {
|
||||||
@@ -1025,7 +1021,6 @@ mod tests {
|
|||||||
Some("https://compose-api.example.com"),
|
Some("https://compose-api.example.com"),
|
||||||
);
|
);
|
||||||
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", Some("gateway-test-token"));
|
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", Some("gateway-test-token"));
|
||||||
let _oauth_proxy_token_guard = set_env_var("IRONCLAW_OAUTH_PROXY_AUTH_TOKEN", None);
|
|
||||||
let _client_id_guard =
|
let _client_id_guard =
|
||||||
set_env_var("GOOGLE_OAUTH_CLIENT_ID", Some("hosted-google-client-id"));
|
set_env_var("GOOGLE_OAUTH_CLIENT_ID", Some("hosted-google-client-id"));
|
||||||
|
|
||||||
@@ -1066,7 +1061,6 @@ mod tests {
|
|||||||
Some("https://compose-api.example.com"),
|
Some("https://compose-api.example.com"),
|
||||||
);
|
);
|
||||||
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", Some("gateway-test-token"));
|
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", Some("gateway-test-token"));
|
||||||
let _oauth_proxy_token_guard = set_env_var("IRONCLAW_OAUTH_PROXY_AUTH_TOKEN", None);
|
|
||||||
let _client_id_guard =
|
let _client_id_guard =
|
||||||
set_env_var("GOOGLE_OAUTH_CLIENT_ID", Some("hosted-google-client-id"));
|
set_env_var("GOOGLE_OAUTH_CLIENT_ID", Some("hosted-google-client-id"));
|
||||||
let _client_secret_guard =
|
let _client_secret_guard =
|
||||||
@@ -1101,47 +1095,6 @@ mod tests {
|
|||||||
assert_eq!(config.gateway_token.as_deref(), Some("gateway-test-token"));
|
assert_eq!(config.gateway_token.as_deref(), Some("gateway-test-token"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn test_resolve_oauth_refresh_config_hosted_proxy_prefers_dedicated_proxy_auth_token() {
|
|
||||||
use crate::tools::wasm::capabilities_schema::{
|
|
||||||
AuthCapabilitySchema, CapabilitiesFile, OAuthConfigSchema,
|
|
||||||
};
|
|
||||||
|
|
||||||
let _guard = lock_env();
|
|
||||||
let _proxy_guard = set_env_var(
|
|
||||||
"IRONCLAW_OAUTH_EXCHANGE_URL",
|
|
||||||
Some("https://compose-api.example.com"),
|
|
||||||
);
|
|
||||||
let _gateway_token_guard = set_env_var("GATEWAY_AUTH_TOKEN", Some("gateway-test-token"));
|
|
||||||
let _oauth_proxy_token_guard = set_env_var(
|
|
||||||
"IRONCLAW_OAUTH_PROXY_AUTH_TOKEN",
|
|
||||||
Some("shared-oauth-proxy-secret"),
|
|
||||||
);
|
|
||||||
let _client_id_guard =
|
|
||||||
set_env_var("GOOGLE_OAUTH_CLIENT_ID", Some("hosted-google-client-id"));
|
|
||||||
|
|
||||||
let caps = CapabilitiesFile {
|
|
||||||
auth: Some(AuthCapabilitySchema {
|
|
||||||
secret_name: "google_oauth_token".to_string(),
|
|
||||||
provider: Some("google".to_string()),
|
|
||||||
oauth: Some(OAuthConfigSchema {
|
|
||||||
authorization_url: "https://accounts.google.com/o/oauth2/v2/auth".to_string(),
|
|
||||||
token_url: "https://oauth2.googleapis.com/token".to_string(),
|
|
||||||
client_id_env: Some("GOOGLE_OAUTH_CLIENT_ID".to_string()),
|
|
||||||
..Default::default()
|
|
||||||
}),
|
|
||||||
..Default::default()
|
|
||||||
}),
|
|
||||||
..Default::default()
|
|
||||||
};
|
|
||||||
|
|
||||||
let config = super::resolve_oauth_refresh_config(&caps).expect("hosted oauth config");
|
|
||||||
assert_eq!(
|
|
||||||
config.gateway_token.as_deref(),
|
|
||||||
Some("shared-oauth-proxy-secret")
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
// ---------------------------------------------------------------
|
// ---------------------------------------------------------------
|
||||||
// Security regression tests
|
// Security regression tests
|
||||||
// ---------------------------------------------------------------
|
// ---------------------------------------------------------------
|
||||||
|
|||||||
@@ -62,8 +62,7 @@ pub struct OAuthRefreshConfig {
|
|||||||
pub client_secret: Option<String>,
|
pub client_secret: Option<String>,
|
||||||
/// Hosted OAuth proxy base URL (e.g., "http://host.docker.internal:8080").
|
/// Hosted OAuth proxy base URL (e.g., "http://host.docker.internal:8080").
|
||||||
pub exchange_proxy_url: Option<String>,
|
pub exchange_proxy_url: Option<String>,
|
||||||
/// OAuth proxy auth token for authenticating with the hosted OAuth proxy.
|
/// Gateway auth token for authenticating with the hosted OAuth proxy.
|
||||||
/// Kept as `gateway_token` for public API compatibility.
|
|
||||||
pub gateway_token: Option<String>,
|
pub gateway_token: Option<String>,
|
||||||
/// Secret name of the access token (e.g., "google_oauth_token").
|
/// Secret name of the access token (e.g., "google_oauth_token").
|
||||||
/// The refresh token lives at `{secret_name}_refresh_token`.
|
/// The refresh token lives at `{secret_name}_refresh_token`.
|
||||||
@@ -72,12 +71,6 @@ pub struct OAuthRefreshConfig {
|
|||||||
pub provider: Option<String>,
|
pub provider: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl OAuthRefreshConfig {
|
|
||||||
fn oauth_proxy_auth_token(&self) -> Option<&str> {
|
|
||||||
self.gateway_token.as_deref()
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Pre-resolved credential for host-based injection.
|
/// Pre-resolved credential for host-based injection.
|
||||||
///
|
///
|
||||||
/// Built before each WASM execution by decrypting secrets from the store.
|
/// Built before each WASM execution by decrypting secrets from the store.
|
||||||
@@ -1225,9 +1218,9 @@ async fn refresh_oauth_token(
|
|||||||
let refresh_name = format!("{}_refresh_token", config.secret_name);
|
let refresh_name = format!("{}_refresh_token", config.secret_name);
|
||||||
|
|
||||||
if let Some(proxy_url) = config.exchange_proxy_url.as_deref() {
|
if let Some(proxy_url) = config.exchange_proxy_url.as_deref() {
|
||||||
let Some(oauth_proxy_auth_token) = config.oauth_proxy_auth_token() else {
|
let Some(gateway_token) = config.gateway_token.as_deref() else {
|
||||||
tracing::warn!(
|
tracing::warn!(
|
||||||
"OAuth refresh proxy is configured, but no OAuth proxy auth token is available"
|
"OAuth refresh proxy is configured, but no gateway auth token is available"
|
||||||
);
|
);
|
||||||
return false;
|
return false;
|
||||||
};
|
};
|
||||||
@@ -1242,7 +1235,7 @@ async fn refresh_oauth_token(
|
|||||||
let token_response = match oauth_defaults::refresh_token_via_proxy(
|
let token_response = match oauth_defaults::refresh_token_via_proxy(
|
||||||
oauth_defaults::ProxyRefreshTokenRequest {
|
oauth_defaults::ProxyRefreshTokenRequest {
|
||||||
proxy_url,
|
proxy_url,
|
||||||
gateway_token: oauth_proxy_auth_token,
|
gateway_token,
|
||||||
token_url: &config.token_url,
|
token_url: &config.token_url,
|
||||||
client_id: &config.client_id,
|
client_id: &config.client_id,
|
||||||
client_secret: config.client_secret.as_deref(),
|
client_secret: config.client_secret.as_deref(),
|
||||||
@@ -2711,8 +2704,7 @@ mod tests {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn test_resolve_host_credentials_skips_refresh_token_lookup_without_oauth_proxy_auth_token()
|
async fn test_resolve_host_credentials_skips_refresh_token_lookup_without_gateway_token() {
|
||||||
{
|
|
||||||
use crate::secrets::{
|
use crate::secrets::{
|
||||||
CreateSecretParams, CredentialLocation, CredentialMapping, SecretsStore,
|
CreateSecretParams, CredentialLocation, CredentialMapping, SecretsStore,
|
||||||
};
|
};
|
||||||
|
|||||||
+3
-5
@@ -20,6 +20,7 @@ use crate::agent::scheduler::WorkerMessage;
|
|||||||
use crate::agent::task::TaskOutput;
|
use crate::agent::task::TaskOutput;
|
||||||
use crate::channels::web::types::ToolDecisionDto;
|
use crate::channels::web::types::ToolDecisionDto;
|
||||||
use crate::context::{ContextManager, JobState};
|
use crate::context::{ContextManager, JobState};
|
||||||
|
use crate::db::Database;
|
||||||
use crate::error::Error;
|
use crate::error::Error;
|
||||||
use crate::hooks::HookRegistry;
|
use crate::hooks::HookRegistry;
|
||||||
use crate::llm::{
|
use crate::llm::{
|
||||||
@@ -27,7 +28,6 @@ use crate::llm::{
|
|||||||
ToolSelection,
|
ToolSelection,
|
||||||
};
|
};
|
||||||
use crate::safety::SafetyLayer;
|
use crate::safety::SafetyLayer;
|
||||||
use crate::tenant::AdminScope;
|
|
||||||
use crate::tools::execute::process_tool_result;
|
use crate::tools::execute::process_tool_result;
|
||||||
use crate::tools::rate_limiter::RateLimitResult;
|
use crate::tools::rate_limiter::RateLimitResult;
|
||||||
use crate::tools::{
|
use crate::tools::{
|
||||||
@@ -45,7 +45,7 @@ pub struct WorkerDeps {
|
|||||||
pub llm: Arc<dyn LlmProvider>,
|
pub llm: Arc<dyn LlmProvider>,
|
||||||
pub safety: Arc<SafetyLayer>,
|
pub safety: Arc<SafetyLayer>,
|
||||||
pub tools: Arc<ToolRegistry>,
|
pub tools: Arc<ToolRegistry>,
|
||||||
pub store: Option<AdminScope>,
|
pub store: Option<Arc<dyn Database>>,
|
||||||
pub hooks: Arc<HookRegistry>,
|
pub hooks: Arc<HookRegistry>,
|
||||||
pub timeout: Duration,
|
pub timeout: Duration,
|
||||||
pub use_planning: bool,
|
pub use_planning: bool,
|
||||||
@@ -94,7 +94,7 @@ impl Worker {
|
|||||||
&self.deps.tools
|
&self.deps.tools
|
||||||
}
|
}
|
||||||
|
|
||||||
fn store(&self) -> Option<&AdminScope> {
|
fn store(&self) -> Option<&Arc<dyn Database>> {
|
||||||
self.deps.store.as_ref()
|
self.deps.store.as_ref()
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1158,7 +1158,6 @@ impl<'a> JobDelegate<'a> {
|
|||||||
Ok(crate::llm::RespondOutput {
|
Ok(crate::llm::RespondOutput {
|
||||||
result: RespondResult::Text(String::new()),
|
result: RespondResult::Text(String::new()),
|
||||||
usage: crate::llm::TokenUsage::default(),
|
usage: crate::llm::TokenUsage::default(),
|
||||||
finish_reason: crate::llm::FinishReason::Stop,
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1284,7 +1283,6 @@ impl<'a> LoopDelegate for JobDelegate<'a> {
|
|||||||
content: reasoning_text,
|
content: reasoning_text,
|
||||||
},
|
},
|
||||||
usage: crate::llm::TokenUsage::default(),
|
usage: crate::llm::TokenUsage::default(),
|
||||||
finish_reason: crate::llm::FinishReason::ToolUse,
|
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
Ok(_) => {} // empty selections, fall through
|
Ok(_) => {} // empty selections, fall through
|
||||||
|
|||||||
@@ -149,7 +149,6 @@ fn reject_if_injected(path: &str, content: &str) -> Result<(), WorkspaceError> {
|
|||||||
///
|
///
|
||||||
/// Allows Workspace to work with either a PostgreSQL `Repository` (the original
|
/// Allows Workspace to work with either a PostgreSQL `Repository` (the original
|
||||||
/// path) or any `Database` trait implementation (e.g. libSQL backend).
|
/// path) or any `Database` trait implementation (e.g. libSQL backend).
|
||||||
#[derive(Clone)]
|
|
||||||
enum WorkspaceStorage {
|
enum WorkspaceStorage {
|
||||||
/// PostgreSQL-backed repository (uses connection pool directly).
|
/// PostgreSQL-backed repository (uses connection pool directly).
|
||||||
#[cfg(feature = "postgres")]
|
#[cfg(feature = "postgres")]
|
||||||
@@ -577,60 +576,6 @@ impl Workspace {
|
|||||||
self
|
self
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Clone the workspace configuration for a different primary user scope.
|
|
||||||
///
|
|
||||||
/// This preserves search config, embeddings, shared read scopes, memory
|
|
||||||
/// layers, and privacy classifier while switching the primary read/write
|
|
||||||
/// scope to `user_id`.
|
|
||||||
pub fn scoped_to_user(&self, user_id: impl Into<String>) -> Self {
|
|
||||||
let user_id = user_id.into();
|
|
||||||
|
|
||||||
let mut memory_layers = self.memory_layers.clone();
|
|
||||||
for layer in &mut memory_layers {
|
|
||||||
if layer.sensitivity == crate::workspace::layer::LayerSensitivity::Private
|
|
||||||
&& layer.scope == self.user_id
|
|
||||||
{
|
|
||||||
layer.scope = user_id.clone();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut read_user_ids = vec![user_id.clone()];
|
|
||||||
for scope in &self.read_user_ids {
|
|
||||||
if scope != &self.user_id && !read_user_ids.contains(scope) {
|
|
||||||
read_user_ids.push(scope.clone());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
for scope in crate::workspace::layer::MemoryLayer::read_scopes(&memory_layers) {
|
|
||||||
if !read_user_ids.contains(&scope) {
|
|
||||||
read_user_ids.push(scope);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let preserve_flags = user_id == self.user_id;
|
|
||||||
Self {
|
|
||||||
user_id,
|
|
||||||
read_user_ids,
|
|
||||||
agent_id: self.agent_id,
|
|
||||||
storage: self.storage.clone(),
|
|
||||||
embeddings: self.embeddings.clone(),
|
|
||||||
bootstrap_pending: std::sync::atomic::AtomicBool::new(if preserve_flags {
|
|
||||||
self.bootstrap_pending
|
|
||||||
.load(std::sync::atomic::Ordering::Acquire)
|
|
||||||
} else {
|
|
||||||
false
|
|
||||||
}),
|
|
||||||
bootstrap_completed: std::sync::atomic::AtomicBool::new(if preserve_flags {
|
|
||||||
self.bootstrap_completed
|
|
||||||
.load(std::sync::atomic::Ordering::Acquire)
|
|
||||||
} else {
|
|
||||||
false
|
|
||||||
}),
|
|
||||||
search_defaults: self.search_defaults.clone(),
|
|
||||||
memory_layers,
|
|
||||||
privacy_classifier: self.privacy_classifier.clone(),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Get the user ID (primary scope for writes).
|
/// Get the user ID (primary scope for writes).
|
||||||
pub fn user_id(&self) -> &str {
|
pub fn user_id(&self) -> &str {
|
||||||
&self.user_id
|
&self.user_id
|
||||||
|
|||||||
@@ -15,7 +15,6 @@ use crate::workspace::document::{MemoryChunk, MemoryDocument, WorkspaceEntry};
|
|||||||
use crate::workspace::search::{RankedResult, SearchConfig, SearchResult, fuse_results};
|
use crate::workspace::search::{RankedResult, SearchConfig, SearchResult, fuse_results};
|
||||||
|
|
||||||
/// Database repository for workspace operations.
|
/// Database repository for workspace operations.
|
||||||
#[derive(Clone)]
|
|
||||||
pub struct Repository {
|
pub struct Repository {
|
||||||
pool: Pool,
|
pool: Pool,
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -253,6 +253,6 @@ async def test_telegram_hot_activation_transitions_installed_to_active(page):
|
|||||||
assert await card.locator(SEL["ext_pairing_label"]).count() == 0
|
assert await card.locator(SEL["ext_pairing_label"]).count() == 0
|
||||||
|
|
||||||
assert captured_setup_payloads == [
|
assert captured_setup_payloads == [
|
||||||
{"secrets": {"telegram_bot_token": "123456789:ABCdefGhI"}, "fields": {}},
|
{"secrets": {"telegram_bot_token": "123456789:ABCdefGhI"}},
|
||||||
{"secrets": {}, "fields": {}},
|
{"secrets": {}},
|
||||||
]
|
]
|
||||||
|
|||||||
@@ -587,7 +587,6 @@ mod advanced {
|
|||||||
async fn mcp_extension_lifecycle() {
|
async fn mcp_extension_lifecycle() {
|
||||||
use crate::support::mock_mcp_server::{MockToolResponse, start_mock_mcp_server};
|
use crate::support::mock_mcp_server::{MockToolResponse, start_mock_mcp_server};
|
||||||
use ironclaw::extensions::{AuthHint, ExtensionKind, ExtensionSource, RegistryEntry};
|
use ironclaw::extensions::{AuthHint, ExtensionKind, ExtensionSource, RegistryEntry};
|
||||||
const TEST_USER_ID: &str = "test-user";
|
|
||||||
|
|
||||||
// 1. Start mock MCP server with pre-configured tool responses.
|
// 1. Start mock MCP server with pre-configured tool responses.
|
||||||
let mock_server = start_mock_mcp_server(vec![
|
let mock_server = start_mock_mcp_server(vec![
|
||||||
@@ -655,14 +654,14 @@ mod advanced {
|
|||||||
ext_mgr
|
ext_mgr
|
||||||
.secrets()
|
.secrets()
|
||||||
.create(
|
.create(
|
||||||
TEST_USER_ID,
|
"default",
|
||||||
ironclaw::secrets::CreateSecretParams::new(secret_name, "mock-access-token")
|
ironclaw::secrets::CreateSecretParams::new(secret_name, "mock-access-token")
|
||||||
.with_provider("mcp:mock-notion".to_string()),
|
.with_provider("mcp:mock-notion".to_string()),
|
||||||
)
|
)
|
||||||
.await
|
.await
|
||||||
.expect("failed to inject test token");
|
.expect("failed to inject test token");
|
||||||
|
|
||||||
let activate_result = ext_mgr.activate("mock-notion", TEST_USER_ID).await;
|
let activate_result = ext_mgr.activate("mock-notion", "default").await;
|
||||||
assert!(
|
assert!(
|
||||||
activate_result.is_ok(),
|
activate_result.is_ok(),
|
||||||
"activation failed: {:?}",
|
"activation failed: {:?}",
|
||||||
|
|||||||
@@ -205,44 +205,7 @@ mod tests {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// -----------------------------------------------------------------------
|
// -----------------------------------------------------------------------
|
||||||
// Test 5: routine_update_fail_delete_fallback
|
// Test 5: routine_manual_create_defaults_to_tools_enabled
|
||||||
// -----------------------------------------------------------------------
|
|
||||||
|
|
||||||
#[tokio::test]
|
|
||||||
async fn routine_update_fail_delete_fallback() {
|
|
||||||
let trace = LlmTrace::from_file(concat!(
|
|
||||||
env!("CARGO_MANIFEST_DIR"),
|
|
||||||
"/tests/fixtures/llm_traces/tools/routine_update_fail_delete_fallback.json"
|
|
||||||
))
|
|
||||||
.expect("failed to load routine_update_fail_delete_fallback.json");
|
|
||||||
|
|
||||||
let rig = TestRigBuilder::new()
|
|
||||||
.with_trace(trace.clone())
|
|
||||||
.with_auto_approve_tools(true)
|
|
||||||
.build()
|
|
||||||
.await;
|
|
||||||
|
|
||||||
rig.send_message("Try converting a routine trigger, then recover by deleting it")
|
|
||||||
.await;
|
|
||||||
let responses = rig.wait_for_responses(1, Duration::from_secs(15)).await;
|
|
||||||
|
|
||||||
rig.verify_trace_expects(&trace, &responses);
|
|
||||||
|
|
||||||
let completed = rig.tool_calls_completed();
|
|
||||||
assert!(
|
|
||||||
completed.iter().any(|(n, ok)| n == "routine_update" && !ok),
|
|
||||||
"routine_update should fail in this regression path: {completed:?}"
|
|
||||||
);
|
|
||||||
assert!(
|
|
||||||
completed.iter().any(|(n, ok)| n == "routine_delete" && *ok),
|
|
||||||
"routine_delete should recover successfully via preserved routine identity: {completed:?}"
|
|
||||||
);
|
|
||||||
|
|
||||||
rig.shutdown();
|
|
||||||
}
|
|
||||||
|
|
||||||
// -----------------------------------------------------------------------
|
|
||||||
// Test 6: routine_manual_create_defaults_to_tools_enabled
|
|
||||||
// -----------------------------------------------------------------------
|
// -----------------------------------------------------------------------
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
@@ -283,7 +246,7 @@ mod tests {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// -----------------------------------------------------------------------
|
// -----------------------------------------------------------------------
|
||||||
// Test 7: routine_manual_create_explicit_no_tools
|
// Test 6: routine_manual_create_explicit_no_tools
|
||||||
// -----------------------------------------------------------------------
|
// -----------------------------------------------------------------------
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
@@ -324,7 +287,7 @@ mod tests {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// -----------------------------------------------------------------------
|
// -----------------------------------------------------------------------
|
||||||
// Test 8: routine_history
|
// Test 7: routine_history
|
||||||
// -----------------------------------------------------------------------
|
// -----------------------------------------------------------------------
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
@@ -476,7 +439,7 @@ mod tests {
|
|||||||
|
|
||||||
match &routine.trigger {
|
match &routine.trigger {
|
||||||
Trigger::Cron { schedule, timezone } => {
|
Trigger::Cron { schedule, timezone } => {
|
||||||
assert_eq!(schedule, "0 0 9 * * MON-FRI *");
|
assert_eq!(schedule, "0 0 9 * * MON-FRI");
|
||||||
assert_eq!(timezone.as_deref(), Some("UTC"));
|
assert_eq!(timezone.as_deref(), Some("UTC"));
|
||||||
}
|
}
|
||||||
other => panic!("expected cron trigger, got {other:?}"),
|
other => panic!("expected cron trigger, got {other:?}"),
|
||||||
|
|||||||
@@ -337,14 +337,14 @@ mod tests {
|
|||||||
SchedulerDeps {
|
SchedulerDeps {
|
||||||
tools: registry.clone(),
|
tools: registry.clone(),
|
||||||
extension_manager: extension_manager.clone(),
|
extension_manager: extension_manager.clone(),
|
||||||
store: Some(ironclaw::tenant::AdminScope::new(db.clone())),
|
store: Some(db.clone()),
|
||||||
hooks: Arc::new(HookRegistry::new()),
|
hooks: Arc::new(HookRegistry::new()),
|
||||||
},
|
},
|
||||||
));
|
));
|
||||||
|
|
||||||
Arc::new(RoutineEngine::new(
|
Arc::new(RoutineEngine::new(
|
||||||
RoutineConfig::default(),
|
RoutineConfig::default(),
|
||||||
ironclaw::tenant::AdminScope::new(db),
|
db,
|
||||||
llm,
|
llm,
|
||||||
ws,
|
ws,
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -448,7 +448,7 @@ mod tests {
|
|||||||
|
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
RoutineConfig::default(),
|
RoutineConfig::default(),
|
||||||
ironclaw::tenant::AdminScope::new(db.clone()),
|
db.clone(),
|
||||||
llm,
|
llm,
|
||||||
ws,
|
ws,
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -527,7 +527,7 @@ mod tests {
|
|||||||
|
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
RoutineConfig::default(),
|
RoutineConfig::default(),
|
||||||
ironclaw::tenant::AdminScope::new(db.clone()),
|
db.clone(),
|
||||||
llm,
|
llm,
|
||||||
ws,
|
ws,
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -614,7 +614,7 @@ mod tests {
|
|||||||
|
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
RoutineConfig::default(),
|
RoutineConfig::default(),
|
||||||
ironclaw::tenant::AdminScope::new(db.clone()),
|
db.clone(),
|
||||||
llm,
|
llm,
|
||||||
ws,
|
ws,
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -723,7 +723,7 @@ mod tests {
|
|||||||
|
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
RoutineConfig::default(),
|
RoutineConfig::default(),
|
||||||
ironclaw::tenant::AdminScope::new(db.clone()),
|
db.clone(),
|
||||||
llm,
|
llm,
|
||||||
ws,
|
ws,
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -866,7 +866,7 @@ mod tests {
|
|||||||
|
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
RoutineConfig::default(),
|
RoutineConfig::default(),
|
||||||
ironclaw::tenant::AdminScope::new(db.clone()),
|
db.clone(),
|
||||||
llm,
|
llm,
|
||||||
ws,
|
ws,
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -1049,7 +1049,7 @@ mod tests {
|
|||||||
|
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
RoutineConfig::default(),
|
RoutineConfig::default(),
|
||||||
ironclaw::tenant::AdminScope::new(Arc::clone(&db)),
|
Arc::clone(&db),
|
||||||
llm,
|
llm,
|
||||||
ws,
|
ws,
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -1171,7 +1171,7 @@ mod tests {
|
|||||||
|
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
RoutineConfig::default(),
|
RoutineConfig::default(),
|
||||||
ironclaw::tenant::AdminScope::new(db.clone()),
|
db.clone(),
|
||||||
llm,
|
llm,
|
||||||
ws,
|
ws,
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -1279,7 +1279,7 @@ mod tests {
|
|||||||
|
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
config,
|
config,
|
||||||
ironclaw::tenant::AdminScope::new(db.clone()),
|
db.clone(),
|
||||||
llm,
|
llm,
|
||||||
ws,
|
ws,
|
||||||
notify_tx,
|
notify_tx,
|
||||||
|
|||||||
@@ -201,7 +201,6 @@ mod tests {
|
|||||||
sandbox_readiness: ironclaw::agent::SandboxReadiness::DisabledByConfig,
|
sandbox_readiness: ironclaw::agent::SandboxReadiness::DisabledByConfig,
|
||||||
builder: None,
|
builder: None,
|
||||||
llm_backend: "nearai".to_string(),
|
llm_backend: "nearai".to_string(),
|
||||||
tenant_rates: std::sync::Arc::new(ironclaw::tenant::TenantRateRegistry::new(4, 3)),
|
|
||||||
};
|
};
|
||||||
|
|
||||||
let gateway = Arc::new(TestChannel::new());
|
let gateway = Arc::new(TestChannel::new());
|
||||||
|
|||||||
@@ -12,7 +12,6 @@ mod tests {
|
|||||||
|
|
||||||
use crate::support::test_rig::TestRigBuilder;
|
use crate::support::test_rig::TestRigBuilder;
|
||||||
use crate::support::trace_llm::LlmTrace;
|
use crate::support::trace_llm::LlmTrace;
|
||||||
use ironclaw::workspace::Workspace;
|
|
||||||
|
|
||||||
// -----------------------------------------------------------------------
|
// -----------------------------------------------------------------------
|
||||||
// Test 1: write_chunk_search
|
// Test 1: write_chunk_search
|
||||||
@@ -269,7 +268,6 @@ mod tests {
|
|||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn identity_in_system_prompt() {
|
async fn identity_in_system_prompt() {
|
||||||
const TEST_USER_ID: &str = "test-user";
|
|
||||||
let trace = LlmTrace::from_file(concat!(
|
let trace = LlmTrace::from_file(concat!(
|
||||||
env!("CARGO_MANIFEST_DIR"),
|
env!("CARGO_MANIFEST_DIR"),
|
||||||
"/tests/fixtures/llm_traces/workspace/identity_prompt.json"
|
"/tests/fixtures/llm_traces/workspace/identity_prompt.json"
|
||||||
@@ -282,7 +280,7 @@ mod tests {
|
|||||||
.await;
|
.await;
|
||||||
|
|
||||||
// Seed an IDENTITY.md so the system prompt has real content to inject.
|
// Seed an IDENTITY.md so the system prompt has real content to inject.
|
||||||
let ws = Workspace::new_with_db(TEST_USER_ID, rig.database().clone());
|
let ws = rig.workspace().expect("workspace must be available");
|
||||||
ws.write(
|
ws.write(
|
||||||
"IDENTITY.md",
|
"IDENTITY.md",
|
||||||
"I am TestBot, a helpful testing assistant created for E2E verification.",
|
"I am TestBot, a helpful testing assistant created for E2E verification.",
|
||||||
|
|||||||
@@ -1,70 +0,0 @@
|
|||||||
{
|
|
||||||
"model_name": "test-routine-update-fail-delete-fallback",
|
|
||||||
"expects": {
|
|
||||||
"tools_used": ["routine_create", "routine_update", "routine_delete"],
|
|
||||||
"tool_results_contain": {
|
|
||||||
"routine_update": "Cannot update schedule or timezone on a non-cron routine.",
|
|
||||||
"routine_delete": "temp-routine"
|
|
||||||
},
|
|
||||||
"min_responses": 1
|
|
||||||
},
|
|
||||||
"steps": [
|
|
||||||
{
|
|
||||||
"response": {
|
|
||||||
"type": "tool_calls",
|
|
||||||
"tool_calls": [
|
|
||||||
{
|
|
||||||
"id": "call_rc_fallback",
|
|
||||||
"name": "routine_create",
|
|
||||||
"arguments": {
|
|
||||||
"name": "temp-routine",
|
|
||||||
"trigger_type": "manual",
|
|
||||||
"prompt": "Temporary routine for fallback test."
|
|
||||||
}
|
|
||||||
}
|
|
||||||
],
|
|
||||||
"input_tokens": 120,
|
|
||||||
"output_tokens": 40
|
|
||||||
}
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"response": {
|
|
||||||
"type": "tool_calls",
|
|
||||||
"tool_calls": [
|
|
||||||
{
|
|
||||||
"id": "call_ru_fallback",
|
|
||||||
"name": "routine_update",
|
|
||||||
"arguments": {
|
|
||||||
"name": "temp-routine",
|
|
||||||
"schedule": "0 */10 * * * *"
|
|
||||||
}
|
|
||||||
}
|
|
||||||
],
|
|
||||||
"input_tokens": 200,
|
|
||||||
"output_tokens": 30
|
|
||||||
}
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"response": {
|
|
||||||
"type": "tool_calls",
|
|
||||||
"tool_calls": [
|
|
||||||
{
|
|
||||||
"id": "call_rd_fallback",
|
|
||||||
"name": "routine_delete",
|
|
||||||
"arguments": {}
|
|
||||||
}
|
|
||||||
],
|
|
||||||
"input_tokens": 300,
|
|
||||||
"output_tokens": 20
|
|
||||||
}
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"response": {
|
|
||||||
"type": "text",
|
|
||||||
"content": "I recovered from the failed update and cleaned up the original routine.",
|
|
||||||
"input_tokens": 380,
|
|
||||||
"output_tokens": 25
|
|
||||||
}
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
@@ -1,10 +1,10 @@
|
|||||||
//! Regression tests for multi-tenant system prompts.
|
//! Tests proving that multi-tenant system prompts are broken.
|
||||||
//!
|
//!
|
||||||
//! The agent must build the conversational system prompt from a workspace
|
//! Bug: In multi-tenant mode, the agent loop uses `self.workspace()` which
|
||||||
//! scoped to the incoming message's user, not from the shared owner-scope
|
//! returns a single shared workspace (user_id="default"). Identity files
|
||||||
//! workspace created at startup. Otherwise per-user identity files
|
//! (IDENTITY.md, SOUL.md, USER.md) seeded under per-user IDs ("alice",
|
||||||
//! (IDENTITY.md, SOUL.md, USER.md) become invisible and different users can
|
//! "bob") are invisible to this workspace, so the system prompt is
|
||||||
//! see the same owner-scoped prompt.
|
//! empty/wrong.
|
||||||
//!
|
//!
|
||||||
//! These tests:
|
//! These tests:
|
||||||
//! 1. Seed identity files for two users (alice, bob) in the database
|
//! 1. Seed identity files for two users (alice, bob) in the database
|
||||||
@@ -13,7 +13,7 @@
|
|||||||
//! correct user's identity
|
//! correct user's identity
|
||||||
//! 4. Verify user A's identity doesn't leak into user B's prompt
|
//! 4. Verify user A's identity doesn't leak into user B's prompt
|
||||||
//!
|
//!
|
||||||
//! These tests ensure each user's identity is isolated correctly.
|
//! All tests are expected to FAIL until the bug is fixed.
|
||||||
|
|
||||||
#[cfg(feature = "libsql")]
|
#[cfg(feature = "libsql")]
|
||||||
mod support;
|
mod support;
|
||||||
|
|||||||
@@ -266,7 +266,6 @@ impl GatewayWorkflowHarness {
|
|||||||
sandbox_readiness: ironclaw::agent::SandboxReadiness::DisabledByConfig,
|
sandbox_readiness: ironclaw::agent::SandboxReadiness::DisabledByConfig,
|
||||||
builder: None,
|
builder: None,
|
||||||
llm_backend: "nearai".to_string(),
|
llm_backend: "nearai".to_string(),
|
||||||
tenant_rates: std::sync::Arc::new(ironclaw::tenant::TenantRateRegistry::new(4, 3)),
|
|
||||||
},
|
},
|
||||||
channels,
|
channels,
|
||||||
None,
|
None,
|
||||||
|
|||||||
@@ -642,7 +642,7 @@ impl TestRigBuilder {
|
|||||||
let (notify_tx, _notify_rx) = tokio::sync::mpsc::channel(16);
|
let (notify_tx, _notify_rx) = tokio::sync::mpsc::channel(16);
|
||||||
let engine = Arc::new(RoutineEngine::new(
|
let engine = Arc::new(RoutineEngine::new(
|
||||||
routine_config,
|
routine_config,
|
||||||
ironclaw::tenant::AdminScope::new(Arc::clone(db_arc)),
|
Arc::clone(db_arc),
|
||||||
components.llm.clone(),
|
components.llm.clone(),
|
||||||
Arc::clone(ws),
|
Arc::clone(ws),
|
||||||
notify_tx,
|
notify_tx,
|
||||||
@@ -762,7 +762,6 @@ impl TestRigBuilder {
|
|||||||
sandbox_readiness: ironclaw::agent::SandboxReadiness::Available, // tests don't use real Docker
|
sandbox_readiness: ironclaw::agent::SandboxReadiness::Available, // tests don't use real Docker
|
||||||
builder: None,
|
builder: None,
|
||||||
llm_backend: "nearai".to_string(),
|
llm_backend: "nearai".to_string(),
|
||||||
tenant_rates: std::sync::Arc::new(ironclaw::tenant::TenantRateRegistry::new(4, 3)),
|
|
||||||
};
|
};
|
||||||
|
|
||||||
// 7. Create TestChannel and ChannelManager.
|
// 7. Create TestChannel and ChannelManager.
|
||||||
|
|||||||
Reference in New Issue
Block a user