Compare commits

...
Author SHA1 Message Date
Nick Pismenkov b01bfecb48 remove CLAUDE.md changes 2026-03-09 17:13:46 -07:00
Nick Pismenkov 940c182fea fix: remove accidentally committed binary 2026-03-09 17:13:04 -07:00
Nick Pismenkov 654bda9239 Merge main into fix/libsql-crash
Resolves conflict in CLAUDE.md by keeping our detailed Configuration section.

[skip-regression-check]
2026-03-09 16:40:16 -07:00
Nick Pismenkov 13cde37722 fix
[skip-regression-check]
2026-03-09 16:40:11 -07:00
Nick PismenkovandClaude Haiku 4.5 f5123055b5 docs: document libSQL CLI connection crash issue
Add detailed documentation for the libSQL CLI crash that blocks interactive
setup flows on libSQL deployments (ironclaw tool setup, ironclaw secret set,
ironclaw mcp auth).

- Add known issue comment to src/db/mod.rs create_secrets_store() documenting
  the "invalid connection string" crash on libSQL CLI subcommands
- Add related comments to src/cli/tool.rs init_secrets_store() and
  src/cli/mcp.rs get_secrets_store() functions
- Add to CLAUDE.md Current Limitations section as priority item #1
- Include workaround: manually read master key from /proc/PID/environ,
  encrypt secrets with AES-256-GCM, write directly to secrets table
- Root cause unknown: libSQL works fine in main process but fails when
  called from CLI subcommands (possibly path resolution, file permissions,
  or WAL mode conflicts)
- Related: #655 (libSQL backend gaps)

Co-Authored-By: Claude Haiku 4.5 <[email protected]>
2026-03-09 16:01:07 -07:00
3 changed files with 22 additions and 8 deletions
+1
View File
@@ -28,3 +28,4 @@ trace_*.json
# Local Claude Code settings (machine-specific, should not be committed)
.claude/settings.local.json
rust_out
+1 -1
View File
@@ -626,7 +626,7 @@ async fn save_servers(
}
}
/// Initialize and return the secrets store.
/// Get the secrets store for MCP authentication operations.
async fn get_secrets_store() -> anyhow::Result<Arc<dyn SecretsStore + Send + Sync>> {
let config = Config::from_env().await?;
+20 -7
View File
@@ -77,7 +77,7 @@ pub async fn connect_from_config(
Ok(Arc::new(backend))
}
#[cfg(feature = "postgres")]
_ => {
crate::config::DatabaseBackend::Postgres => {
let pg = postgres::PgBackend::new(config)
.await
.map_err(|e| DatabaseError::Pool(e.to_string()))?;
@@ -85,9 +85,16 @@ pub async fn connect_from_config(
Ok(Arc::new(pg))
}
#[cfg(not(feature = "postgres"))]
_ => Err(DatabaseError::Pool(
"No database backend available. Enable 'postgres' or 'libsql' feature.".to_string(),
crate::config::DatabaseBackend::Postgres => Err(DatabaseError::Pool(
"No postgres backend available. Rebuild with --features postgres.".to_string(),
)),
// Catches LibSql in postgres-only builds (libsql arm compiled out)
#[allow(unreachable_patterns)]
_ => Err(DatabaseError::Pool(format!(
"Database backend {:?} not available in this build. \
Set DATABASE_BACKEND to a compiled-in backend, or rebuild with the matching feature flag.",
config.backend
))),
}
}
@@ -130,7 +137,7 @@ pub async fn create_secrets_store(
)))
}
#[cfg(feature = "postgres")]
_ => {
crate::config::DatabaseBackend::Postgres => {
let pg = postgres::PgBackend::new(config)
.await
.map_err(|e| DatabaseError::Pool(e.to_string()))?;
@@ -142,10 +149,16 @@ pub async fn create_secrets_store(
)))
}
#[cfg(not(feature = "postgres"))]
_ => Err(DatabaseError::Pool(
"No database backend available for secrets. Enable 'postgres' or 'libsql' feature."
.to_string(),
crate::config::DatabaseBackend::Postgres => Err(DatabaseError::Pool(
"No postgres backend available. Rebuild with --features postgres.".to_string(),
)),
// Catches LibSql in postgres-only builds (libsql arm compiled out)
#[allow(unreachable_patterns)]
_ => Err(DatabaseError::Pool(format!(
"Database backend {:?} not available in this build. \
Set DATABASE_BACKEND to a compiled-in backend, or rebuild with the matching feature flag.",
config.backend
))),
}
}