Replace `unwrap_or_else(|e| e.into_inner())` with `expect("env mutex poisoned")`
in bind_rejects_wildcard_ipv4 and bind_rejects_wildcard_ipv6 tests to match the
ENV_MUTEX pattern used in oauth_defaults.rs. The old pattern silently recovered
from a poisoned mutex, potentially allowing concurrent env var access when a
prior test panicked while holding the lock.
[skip-regression-check]
Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
* fix: consolidate retry-after parsing and fix flaky OAuth env tests (#1288, #1280)
- Extract shared `parse_retry_after()` into `src/llm/retry.rs` supporting
both delay-seconds and RFC2822 formats, replacing duplicated inline parsing
in anthropic_oauth.rs, nearai_chat.rs, and embeddings.rs
- Fix flaky `bind_rejects_wildcard_*` tests in oauth_helpers.rs by adding
`tokio::sync::Mutex` to serialize env var access (matching the ENV_MUTEX
pattern in oauth_defaults.rs)
- Add regression tests for parse_retry_after edge cases
Closes#1288, #1280
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
* docs: add comments explaining CLI_ENABLED=false in service templates (#990)
Clarify that CLI_ENABLED=false is needed in daemon mode (launchd/systemd)
to prevent blocking on stdin when running as a background service.
Closes#990
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
* fix: address review comments on retry-after consolidation
- Change parse_retry_after() return type from Option<Duration> to Duration
(it never returns None due to the 60s fallback)
- Fix doc comment: reference RFC 7231 §7.1.1 for HTTP-date, not RFC 2822
- Add parse_retry_after_http_date test for the RFC 2822 date parsing branch
- Remove stale per-file test helpers (parse_retry_after_*_for_test) that
duplicated old inline logic instead of testing the shared function
- Remove unnecessary comments above #[cfg(test)] imports
- Use crate-wide ENV_MUTEX instead of local tokio::sync::Mutex in
oauth_helpers tests to prevent cross-module env-var races
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
* fix: reword await_holding_lock safety comment
Drop runtime-flavor assumption; justify by short-lived awaited operation.
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
* refactor: make src/llm/ self-contained for crate extraction
Move LlmError, LLM config types, and OAuth callback helpers into
src/llm/ so the module has zero `use crate::` imports outside of
crate::llm. This prepares the module for extraction into a standalone
workspace crate.
- Move LlmError enum from src/error.rs to src/llm/error.rs
- Move LlmConfig, NearAiConfig, RegistryProviderConfig, BedrockConfig,
CacheRetention, OAUTH_PLACEHOLDER from src/config/llm.rs to
src/llm/config.rs
- Move OAuth callback utilities (callback_url, bind_callback_listener,
wait_for_callback, landing_html, etc.) from src/cli/oauth_defaults.rs
to src/llm/oauth_helpers.rs
- Remove session.rs dependency on crate::bootstrap (inline default path)
- Add cache_retention field to RegistryProviderConfig, resolve from env
in config/llm.rs instead of reading env var in llm/mod.rs
- Add Check 6 to scripts/check-boundaries.sh enforcing LLM isolation
- All original locations re-export for backward compatibility
[skip-regression-check]
Co-Authored-By: Claude Opus 4.6 <[email protected]>
* style: fix formatting
Co-Authored-By: Claude Opus 4.6 <[email protected]>
* fix: address PR #767 review — session path bug and boundary check
1. Fix SessionConfig::default() usage in setup wizard: the fallback at
wizard.rs:995 now constructs SessionConfig with the real
default_session_path() instead of a relative "session.json", which
would write auth tokens to the CWD instead of ~/.ironclaw/.
2. Widen check-boundaries.sh Check 6 to catch all `crate::` references
(not just `use crate::` imports). Pre-existing inline references
(16 occurrences) are reported as warnings; only new `use crate::`
imports are hard violations.
[skip-regression-check]
Co-Authored-By: Claude Opus 4.6 <[email protected]>
* fix: address PR #767 review and audit findings in src/llm/
PR review fixes:
- Reject wildcard addresses (0.0.0.0, ::) in OAuth callback listener
to prevent session token exposure on all interfaces
- Fix boundary check comment-stripping that could hide real violations
(use sed to strip inline comments before matching)
Audit fixes:
- Fix UTF-8 byte-index slicing panic in recording.rs hint extraction
- Add effective_model_name() delegation to RetryProvider and
SmartRoutingProvider for consistency with other wrappers
- Add calculate_cost() delegation to CachedProvider and RecordingLlm
- Deduplicate retry loop logic in RetryProvider via generic helper
- Replace hardcoded /tmp path in recording tests with tempfile
Co-Authored-By: Claude Opus 4.6 <[email protected]>
---------
Co-authored-by: Claude Opus 4.6 <[email protected]>
