fix(auth): avoid false success and block chat during pending auth (#1111)

* fix(auth): avoid false success and block chat while auth pending

* fix(web): clear stale auth UI on failure and add setup regression test

* Update src/agent/thread_ops.rs

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* fix(fmt): place auth activation comment on separate line

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Illia Polosukhin <[email protected]>
This commit is contained in:
Nige
2026-03-15 07:08:06 +00:00
committed by GitHub
co-authored by gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Illia Polosukhin
parent e74214dce8
commit e0f393bf04
3 changed files with 145 additions and 9 deletions
+24 -1
View File
@@ -1540,7 +1540,8 @@ impl Agent {
.configure_token(&pending.extension_name, token)
.await
{
Ok(result) => {
Ok(result) if result.activated => {
// Ensure extension is actually activated
tracing::info!(
"Extension '{}' configured via auth mode: {}",
pending.extension_name,
@@ -1560,6 +1561,28 @@ impl Agent {
.await;
Ok(Some(result.message))
}
Ok(result) => {
{
let mut sess = session.lock().await;
if let Some(thread) = sess.threads.get_mut(&thread_id) {
thread.enter_auth_mode(pending.extension_name.clone());
}
}
let _ = self
.channels
.send_status(
&message.channel,
StatusUpdate::AuthRequired {
extension_name: pending.extension_name.clone(),
instructions: Some(result.message.clone()),
auth_url: None,
setup_url: None,
},
&message.metadata,
)
.await;
Ok(Some(result.message))
}
Err(e) => {
let msg = e.to_string();
// Token validation errors: re-enter auth mode and re-prompt