fix(agent): case-insensitive channel match and user_id filter for event triggers (#1211)

* fix(agent): case-insensitive channel match and user_id filter for event triggers (#1051, #1076)

Event-triggered routines had two bugs preventing them from firing:

1. Channel comparison was case-sensitive (e.g., "Telegram" != "telegram"),
   while emit_system_event already used eq_ignore_ascii_case. Fixed to match.

2. No user_id scoping — routines from any user were evaluated against every
   message. Added ownership check so routines only fire for their owner's
   messages.

Also adds periodic event cache refresh (every ~60s) in the cron ticker so
web/CLI mutations are picked up without requiring the tool path. Upgrades
skip-reason logging from trace to debug for debuggability.

Closes #1051
Refs #1076

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

* fix: correct refresh_every from 6 to 4 to match 15s default interval

The default cron_check_interval_secs is 15s, not 10s. With refresh_every=6,
the cache would refresh every 90s instead of the intended ~60s. Fix to 4
ticks (4 * 15s = 60s).

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

* fix(agent): address #1211 review -- extract routine_matches_message, fix refresh interval

Extract user/channel filter logic from check_event_triggers into a
standalone pure function routine_matches_message(). Rewrite tests to
call this function directly with controlled Routine and IncomingMessage
values, so they exercise the real code path and would catch a revert.

Add test_no_channel_filter_matches_any_channel for the None channel case.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

* ci: re-trigger CI with latest changes

Co-Authored-By: Claude Opus 4.6 <[email protected]>

* fix: add missing IncomingMessage fields in test helper

Co-Authored-By: Claude Opus 4.6 <[email protected]>

* fix(agent): address review -- time-based refresh, trace-level user mismatch, scope guard (#1211)

- Use tokio::time::Instant for cache refresh instead of tick counting
- Downgrade user-mismatch log to trace to reduce noise
- Add early return false for non-Event triggers in routine_matches_message
- Fix doc comment to say 'user scope' instead of 'message sender'

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

* style: run cargo fmt on agent_loop.rs

https://claude.ai/code/session_01ABGWibdKVQ3b6pEKtxPPkM

* fix(agent): resolve clippy warnings for unused binding and needless borrow

Fix unused `content` variable in event trigger guard (use `content: _`)
and remove redundant `&` on `message` which was already a reference.

https://claude.ai/code/session_01PzBK21BbUAuZbrfLpoz4Xb

* fix(test): update check_event_triggers call sites to new single-arg signature

The staging merge brought e2e_routine_heartbeat tests that still used
the old 3-argument check_event_triggers(user_id, channel, content)
signature. Updated all 11 call sites to pass &IncomingMessage directly.

[skip-regression-check]

https://claude.ai/code/session_012GrkTDrtDFkpJos2hkgTcE

* fix(agent): address review feedback on event trigger handling

- Use post-hook content for event trigger matching so BeforeInbound
  hooks that rewrite input are respected
- Set MissedTickBehavior::Skip on cron ticker to avoid burst catch-up
  after delays

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

* style: cargo fmt

https://claude.ai/code/session_01Va9wwvATNWFAx35GG7Zek7

---------

Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
Co-authored-by: firat.sertgoz <[email protected]>

tests/e2e_routine_heartbeat.rs

@@ -561,11 +561,7 @@ mod tests {
             "deploy to production now",
         );
         let fired = engine
-            .check_event_triggers(
-                &matching_msg.user_id,
-                &matching_msg.channel,
-                &matching_msg.content,
-            )
+            .check_event_triggers(&matching_msg, &matching_msg.content)
             .await;
         assert!(
             fired >= 1,
@@ -584,11 +580,7 @@ mod tests {
             "check the staging environment",
         );
         let fired_neg = engine
-            .check_event_triggers(
-                &non_matching_msg.user_id,
-                &non_matching_msg.channel,
-                &non_matching_msg.content,
-            )
+            .check_event_triggers(&non_matching_msg, &non_matching_msg.content)
             .await;
         assert_eq!(fired_neg, 0, "Expected 0 routines fired on non-match");
     }
@@ -652,7 +644,7 @@ mod tests {
             "deploy to production now",
         );
         let guest_fired = engine
-            .check_event_triggers(&guest_msg.user_id, &guest_msg.channel, &guest_msg.content)
+            .check_event_triggers(&guest_msg, &guest_msg.content)
             .await;
         assert_eq!(
             guest_fired, 0,
@@ -677,7 +669,7 @@ mod tests {
             "deploy to production now",
         );
         let owner_fired = engine
-            .check_event_triggers(&owner_msg.user_id, &owner_msg.channel, &owner_msg.content)
+            .check_event_triggers(&owner_msg, &owner_msg.content)
             .await;
         assert!(
             owner_fired >= 1,
@@ -906,9 +898,7 @@ mod tests {
             "default",
             "test-cooldown trigger",
         );
-        let fired1 = engine
-            .check_event_triggers(&msg.user_id, &msg.channel, &msg.content)
-            .await;
+        let fired1 = engine.check_event_triggers(&msg, &msg.content).await;
         assert!(fired1 >= 1, "First fire should work");
 
         // Give spawn time, then update last_run_at to simulate recent execution.
@@ -923,9 +913,7 @@ mod tests {
         engine.refresh_event_cache().await;
 
         // Second fire should be blocked by cooldown.
-        let fired2 = engine
-            .check_event_triggers(&msg.user_id, &msg.channel, &msg.content)
-            .await;
+        let fired2 = engine.check_event_triggers(&msg, &msg.content).await;
         assert_eq!(fired2, 0, "Second fire should be blocked by cooldown");
     }
 
@@ -1095,9 +1083,7 @@ mod tests {
         engine.refresh_event_cache().await;
 
         let msg = IncomingMessage::new("test", "default", "DISABLE_ME");
-        let fired_before = engine
-            .check_event_triggers(&msg.user_id, &msg.channel, &msg.content)
-            .await;
+        let fired_before = engine.check_event_triggers(&msg, &msg.content).await;
         assert!(fired_before >= 1, "Expected routine to fire before disable");
 
         // Simulate what routines_toggle_handler now does: update DB, then refresh.
@@ -1106,9 +1092,7 @@ mod tests {
         db.update_routine(&routine).await.expect("update_routine");
         engine.refresh_event_cache().await;
 
-        let fired_after = engine
-            .check_event_triggers(&msg.user_id, &msg.channel, &msg.content)
-            .await;
+        let fired_after = engine.check_event_triggers(&msg, &msg.content).await;
         assert_eq!(
             fired_after, 0,
             "Disabled routine must not fire after cache refresh"
@@ -1134,10 +1118,7 @@ mod tests {
 
         let msg = IncomingMessage::new("test", "default", "DELETE_ME");
         assert!(
-            engine
-                .check_event_triggers(&msg.user_id, &msg.channel, &msg.content)
-                .await
-                >= 1,
+            engine.check_event_triggers(&msg, &msg.content).await >= 1,
             "Expected routine to fire before delete"
         );
 
@@ -1146,9 +1127,7 @@ mod tests {
         engine.refresh_event_cache().await;
 
         assert_eq!(
-            engine
-                .check_event_triggers(&msg.user_id, &msg.channel, &msg.content)
-                .await,
+            engine.check_event_triggers(&msg, &msg.content).await,
             0,
             "Deleted routine must not fire after cache refresh"
         );
@@ -1462,8 +1441,9 @@ mod tests {
         db.create_routine(&routine).await.expect("create_routine");
         engine.refresh_event_cache().await;
 
+        let trigger_msg = IncomingMessage::new("test", "default", "owner-gate");
         let fired = engine
-            .check_event_triggers("default", "test", "owner-gate")
+            .check_event_triggers(&trigger_msg, &trigger_msg.content)
             .await;
         assert_eq!(fired, 1, "expected one matching event routine");