From bbb5321f34fae91f5c0f4dfdd3e9599ef8b683cb Mon Sep 17 00:00:00 2001 From: "ilblackdragon@gmail.com" Date: Tue, 10 Mar 2026 00:35:17 -0700 Subject: [PATCH] fix: address PR review feedback for cargo-deny integration - quality_gate_strict.sh: fail hard when cargo-deny is not installed instead of silently skipping, and let set -e handle check failures - deny.toml: remove empty [graph].targets so cargo-deny checks all platforms instead of only the runner's default target Co-Authored-By: Claude Opus 4.6 --- deny.toml | 3 --- scripts/ci/quality_gate_strict.sh | 8 ++++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/deny.toml b/deny.toml index f61992a6..dd7a2373 100644 --- a/deny.toml +++ b/deny.toml @@ -1,6 +1,3 @@ -[graph] -targets = [] - [advisories] unmaintained = "workspace" yanked = "deny" diff --git a/scripts/ci/quality_gate_strict.sh b/scripts/ci/quality_gate_strict.sh index f66c20e0..48ef2433 100755 --- a/scripts/ci/quality_gate_strict.sh +++ b/scripts/ci/quality_gate_strict.sh @@ -8,11 +8,11 @@ echo "==> clippy (all warnings)" cargo clippy --locked --all --benches --tests --examples --all-features -- -D warnings echo "==> cargo deny" -if command -v cargo-deny &>/dev/null; then - cargo deny check -else - echo "WARN: cargo-deny not installed, skipping (install with: cargo install cargo-deny)" +if ! command -v cargo-deny &>/dev/null; then + echo "ERROR: cargo-deny not installed (install with: cargo install cargo-deny)" + exit 1 fi +cargo deny check echo "==> tests" cargo test --locked