From b11b0331b4f58b9612c194e50e0d80ddd14b5796 Mon Sep 17 00:00:00 2001 From: "ilblackdragon@gmail.com" Date: Mon, 9 Mar 2026 23:03:27 -0700 Subject: [PATCH] feat: add PR template with risk assessment and review tracks Add a pull request template that includes summary, change type, validation checklist, security/database impact sections, blast radius, and rollback plan. Update CONTRIBUTING.md with review track definitions (A/B/C) based on change risk level. Co-Authored-By: Claude Opus 4.6 --- .github/pull_request_template.md | 50 ++++++++++++++++++++++++++++++++ CONTRIBUTING.md | 12 ++++++++ 2 files changed, 62 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..4fc7cbf2 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,50 @@ +## Summary + + + +- + +## Change Type + + + +- [ ] Bug fix +- [ ] New feature +- [ ] Refactor +- [ ] Documentation +- [ ] CI/Infrastructure +- [ ] Security +- [ ] Dependencies + +## Linked Issue + + + +## Validation + + + +- [ ] `cargo fmt` +- [ ] `cargo clippy --all --benches --tests --examples --all-features` +- [ ] Relevant tests pass: +- [ ] Manual testing: + +## Security Impact + + + +## Database Impact + + + +## Blast Radius + + + +## Rollback Plan + + + +--- + +**Review track**: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5c719811..ee6b2b6c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,3 +9,15 @@ When your change affects a tracked capability, update `FEATURE_PARITY.md` in the 1. Review the relevant parity rows in `FEATURE_PARITY.md`. 2. Update status/notes if behavior changed. 3. Include the `FEATURE_PARITY.md` diff in your commit when applicable. + +## Review Tracks + +All PRs follow a risk-based review process: + +| Track | Scope | Requirements | +|-------|-------|-------------| +| **A** | Docs, tests, chore, dependency bumps | 1 approval + CI green | +| **B** | Features, refactors, new tools/channels | 1 approval + CI green + test evidence | +| **C** | Security (`src/safety/`, `src/secrets/`), runtime (`src/agent/`, `src/worker/`), database schema, CI workflows | 2 approvals + rollback plan documented | + +Select the appropriate track in the PR template based on what your changes touch.