From 9aefa981398fc3510aed4659475cfc9f7211d5ff Mon Sep 17 00:00:00 2001 From: "ilblackdragon@gmail.com" Date: Wed, 11 Mar 2026 14:20:46 -0700 Subject: [PATCH] fix: tighten clippy-windows check in roll-up job Change from checking only `== "failure"` to checking `!= "success" && != "skipped"`. This ensures any unexpected result (e.g., cancelled) also blocks the merge, while still allowing the expected "skipped" state for non-main PRs. Addresses zmanian's review feedback on PR #834. Co-Authored-By: Claude Opus 4.6 --- .github/workflows/code_style.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/code_style.yml b/.github/workflows/code_style.yml index d2c404d9..bd964729 100644 --- a/.github/workflows/code_style.yml +++ b/.github/workflows/code_style.yml @@ -90,8 +90,8 @@ jobs: echo "One or more jobs failed" exit 1 fi - # clippy-windows only runs on main PRs, so skip/success are both acceptable - if [[ "${{ needs.clippy-windows.result }}" == "failure" ]]; then - echo "Windows clippy failed" + # clippy-windows only runs on main PRs, so skipped is acceptable but failure is not + if [[ "${{ needs.clippy-windows.result }}" != "success" && "${{ needs.clippy-windows.result }}" != "skipped" ]]; then + echo "Windows clippy failed: ${{ needs.clippy-windows.result }}" exit 1 fi