fix: Telegram bot token validation fails intermittently (HTTP 404) (#1166)

* fix: Telegram bot token validation fails intermittently (HTTP 404) * fix: code style * fix * fix * fix * review fix
2026-08-25 14:53:34 +00:00 · 2026-03-15 22:06:33 -07:00
parent e81fb7e5cb
commit 81724cad93
4 changed files with 219 additions and 4 deletions
@@ -0,0 +1,172 @@
+"""Scenario: Telegram bot token validation - configure modal UI test.
+
+Tests the Telegram extension configure modal renders and accepts tokens with colons.
+
+Note: The core URL-building logic (colon preservation, no %3A encoding) is verified
+by unit tests in src/extensions/manager.rs. This E2E test verifies the configure modal
+UI can accept Telegram tokens with colons and renders correctly.
+"""
+
+import json
+
+from helpers import SEL
+
+
+# ─── Fixture data ─────────────────────────────────────────────────────────────
+
+_TELEGRAM_EXTENSION = {
+    "name": "telegram",
+    "display_name": "Telegram",
+    "kind": "wasm_channel",
+    "description": "Telegram bot channel",
+    "url": None,
+    "active": False,
+    "authenticated": False,
+    "has_auth": True,
+    "needs_setup": True,
+    "tools": [],
+    "activation_status": "installed",
+    "activation_error": None,
+}
+
+_TELEGRAM_SECRETS = [
+    {
+        "name": "telegram_bot_token",
+        "prompt": "Telegram Bot Token",
+        "provided": False,
+        "optional": False,
+        "auto_generate": False,
+    }
+]
+
+
+# ─── Tests ────────────────────────────────────────────────────────────────────
+
+async def test_telegram_configure_modal_renders(page):
+    """
+    Telegram extension configure modal renders with correct fields.
+
+    Verifies that the configure modal appears with the Telegram bot token field
+    and all expected UI elements are present.
+    """
+    ext_body = json.dumps({"extensions": [_TELEGRAM_EXTENSION]})
+
+    async def handle_ext_list(route):
+        if route.request.url.endswith("/api/extensions"):
+            await route.fulfill(
+                status=200, content_type="application/json", body=ext_body
+            )
+        else:
+            await route.continue_()
+
+    await page.route("**/api/extensions*", handle_ext_list)
+
+    async def handle_setup(route):
+        if route.request.method == "GET":
+            await route.fulfill(
+                status=200,
+                content_type="application/json",
+                body=json.dumps({"secrets": _TELEGRAM_SECRETS}),
+            )
+        else:
+            await route.continue_()
+
+    await page.route("**/api/extensions/telegram/setup", handle_setup)
+    await page.evaluate("showConfigureModal('telegram')")
+    modal = page.locator(SEL["configure_modal"])
+    await modal.wait_for(state="visible", timeout=5000)
+
+    # Modal should contain the extension name and token prompt
+    modal_text = await modal.text_content()
+    assert "telegram" in modal_text.lower()
+    assert "bot token" in modal_text.lower()
+
+    # Input field should be present
+    input_field = page.locator(SEL["configure_input"])
+    assert await input_field.is_visible()
+
+
+async def test_telegram_token_input_accepts_colon_format(page):
+    """
+    Telegram bot token input accepts tokens with colon separator.
+
+    Verifies that a token in the format `numeric_id:alphanumeric_string`
+    can be entered without browser-side validation errors.
+    """
+    ext_body = json.dumps({"extensions": [_TELEGRAM_EXTENSION]})
+
+    async def handle_ext_list(route):
+        if route.request.url.endswith("/api/extensions"):
+            await route.fulfill(
+                status=200, content_type="application/json", body=ext_body
+            )
+        else:
+            await route.continue_()
+
+    await page.route("**/api/extensions*", handle_ext_list)
+
+    async def handle_setup(route):
+        if route.request.method == "GET":
+            await route.fulfill(
+                status=200,
+                content_type="application/json",
+                body=json.dumps({"secrets": _TELEGRAM_SECRETS}),
+            )
+
+    await page.route("**/api/extensions/telegram/setup", handle_setup)
+    await page.evaluate("showConfigureModal('telegram')")
+    await page.locator(SEL["configure_modal"]).wait_for(state="visible", timeout=5000)
+
+    # Enter a valid Telegram bot token with colon
+    token_value = "123456789:AABBccDDeeFFgg_Test-Token"
+    input_field = page.locator(SEL["configure_input"])
+    await input_field.fill(token_value)
+
+    # Verify the value was entered and colon is preserved
+    entered_value = await input_field.input_value()
+    assert entered_value == token_value
+    assert ":" in entered_value, "Colon should be preserved in token"
+    assert "%3A" not in entered_value, "Colon should not be URL-encoded in input"
+
+
+async def test_telegram_token_with_underscores_and_hyphens(page):
+    """
+    Telegram tokens with hyphens and underscores are accepted.
+
+    Verifies that valid Telegram token characters (hyphens, underscores) are
+    properly accepted by the input field.
+    """
+    ext_body = json.dumps({"extensions": [_TELEGRAM_EXTENSION]})
+
+    async def handle_ext_list(route):
+        if route.request.url.endswith("/api/extensions"):
+            await route.fulfill(
+                status=200, content_type="application/json", body=ext_body
+            )
+        else:
+            await route.continue_()
+
+    await page.route("**/api/extensions*", handle_ext_list)
+
+    async def handle_setup(route):
+        if route.request.method == "GET":
+            await route.fulfill(
+                status=200,
+                content_type="application/json",
+                body=json.dumps({"secrets": _TELEGRAM_SECRETS}),
+            )
+
+    await page.route("**/api/extensions/telegram/setup", handle_setup)
+    await page.evaluate("showConfigureModal('telegram')")
+    await page.locator(SEL["configure_modal"]).wait_for(state="visible", timeout=5000)
+
+    # Token with hyphens and underscores
+    token_value = "987654321:ABCD-EFgh_ijkl-MNOP_qrst"
+    input_field = page.locator(SEL["configure_input"])
+    await input_field.fill(token_value)
+
+    # Verify the value was entered correctly with all characters preserved
+    entered_value = await input_field.input_value()
+    assert entered_value == token_value
+    assert "-" in entered_value
+    assert "_" in entered_value