refactor: centralize test credential constants into testing::credentials (#829)

mirror of https://github.com/outbackdingo/optimclaw.git synced 2026-08-30 01:19:34 +00:00

* refactor: centralize test credential constants into testing::credentials

Scattered test credential strings (API keys, OAuth tokens, crypto keys,
Telegram tokens, session tokens) across ~25 files made security auditing
harder and created unnecessary duplication. Centralize all test-only fake
credentials into a new `src/testing/credentials.rs` module with named
constants and a shared `test_secrets_store()` helper.

- Convert `src/testing.rs` to directory module (`src/testing/mod.rs`)
- Add `src/testing/credentials.rs` with ~30 named constants
- Replace hardcoded literals in 24 source files
- Deduplicate `test_store()` helper (was copy-pasted in 3 files)
- Leave leak_detector/shell/signature tests as-is (inline values
  aid readability for pattern detection tests)

[skip-regression-check]

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

* refactor: replace real Telegram bot token with obviously fake test stub

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

* Update src/testing/credentials.rs

Co-authored-by: Copilot <[email protected]>

* Update src/testing/credentials.rs

Co-authored-by: Copilot <[email protected]>

* refactor: address PR review feedback on test credentials

- Fix TEST_CRYPTO_KEY doc comment ("32-byte hex" → "32-character key string")
- Rename confusing "real"/"fake" Anthropic constant names and values
- Change TEST_STRIPE_KEY from "sk-live" to "sk_test_fake123" to avoid scanners
- Use test_secrets_store() helper in orchestrator and http tool tests
- Clarify config_round_trip.rs doc comment about integration test visibility

Co-Authored-By: Claude Opus 4.6 <[email protected]>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
Co-authored-by: Copilot <[email protected]>

This commit is contained in:

Henry Park

2026-03-10 13:25:32 -07:00

committed by

GitHub

co-authored by

Claude Opus 4.6

Copilot

parent 24d4fbb8a7

commit 76375f2eaa

25 changed files with 314 additions and 201 deletions

									
										src/orchestrator/api.rs
									
		+2
		-5
	
												View File
												
				@@ -661,12 +661,9 @@ mod tests {

				    #[tokio::test]

				    async fn credentials_returns_secrets_when_store_configured() {

				        use crate::testing::credentials::test_secrets_store;

				        use secrecy::SecretString;

				        let key = "0123456789abcdef0123456789abcdef";

				        let crypto = Arc::new(

				            crate::secrets::SecretsCrypto::new(SecretString::from(key.to_string())).unwrap(),

				        );

				        let secrets_store = Arc::new(crate::secrets::InMemorySecretsStore::new(crypto));

				        let secrets_store = Arc::new(test_secrets_store());

				        // Create a secret

				        secrets_store