diff --git a/src/context/state.rs b/src/context/state.rs index f5307947..bae5bdf1 100644 --- a/src/context/state.rs +++ b/src/context/state.rs @@ -258,6 +258,13 @@ impl JobContext { new_state: JobState, reason: Option, ) -> Result<(), String> { + debug_assert!( + self.state.can_transition_to(new_state), + "BUG: invalid job state transition {} -> {} for job {}", + self.state, + new_state, + self.job_id + ); if !self.state.can_transition_to(new_state) { return Err(format!( "Cannot transition from {} to {}", diff --git a/src/llm/circuit_breaker.rs b/src/llm/circuit_breaker.rs index db47647e..46f29ded 100644 --- a/src/llm/circuit_breaker.rs +++ b/src/llm/circuit_breaker.rs @@ -167,6 +167,12 @@ impl CircuitBreakerProvider { } } CircuitState::Open => { + debug_assert!( + false, + "BUG: record_success() called while circuit breaker is Open — \ + check_allowed() was bypassed for provider {}", + self.inner.model_name() + ); // Shouldn't get here (check_allowed blocks Open), but recover state.state = CircuitState::Closed; state.consecutive_failures = 0; diff --git a/src/tools/execute.rs b/src/tools/execute.rs index c6c20dc1..fa52c59c 100644 --- a/src/tools/execute.rs +++ b/src/tools/execute.rs @@ -22,6 +22,10 @@ pub async fn execute_tool_with_safety( params: &serde_json::Value, job_ctx: &JobContext, ) -> Result { + debug_assert!( + !tool_name.is_empty(), + "BUG: execute_tool_with_safety called with empty tool_name" + ); let tool = tools .get(tool_name) .await @@ -291,6 +295,25 @@ mod tests { registry } + #[tokio::test] + async fn test_execute_empty_tool_name_returns_not_found() { + // Regression: execute_tool_with_safety must reject empty tool names before + // even attempting a registry lookup (the debug_assert guards this invariant). + let registry = registry_with(vec![]).await; + let safety = test_safety(); + + let result = execute_tool_with_safety( + ®istry, + &safety, + "", + &serde_json::json!({}), + &test_job_ctx(), + ) + .await; + + assert!(result.is_err(), "Empty tool name should return an error"); // safety: test-only assertion + } + #[tokio::test] async fn test_execute_success() { let registry = registry_with(vec![Arc::new(EchoTool)]).await;