mirror of
https://github.com/outbackdingo/mt76.git
synced 2026-10-24 13:26:48 +00:00
Abdun NihaalandFelix Fietkau
e35e4f8fcf
In mt76_wmac_probe(), when the mt76_alloc_device() call succeeds, memory
is allocated for both struct ieee80211_hw and a workqueue. However, on
the error path, the workqueue is not freed. Fix that by calling
mt76_free_device() on the error path.
Fixes: c8846e101502 ("mt76: add driver for MT7603E and MT7628/7688")
Signed-off-by: Abdun Nihaal <[email protected]>
Reviewed-by: Jiri Slaby <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Felix Fietkau <[email protected]>
89 lines
1.8 KiB
C
89 lines
1.8 KiB
C
// SPDX-License-Identifier: ISC
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include "mt7603.h"
|
|
|
|
static int
|
|
mt76_wmac_probe(struct platform_device *pdev)
|
|
{
|
|
struct mt7603_dev *dev;
|
|
void __iomem *mem_base;
|
|
struct mt76_dev *mdev;
|
|
int irq;
|
|
int ret;
|
|
|
|
irq = platform_get_irq(pdev, 0);
|
|
if (irq < 0)
|
|
return irq;
|
|
|
|
mem_base = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(mem_base))
|
|
return PTR_ERR(mem_base);
|
|
|
|
mdev = mt76_alloc_device(&pdev->dev, sizeof(*dev), &mt7603_ops,
|
|
&mt7603_drv_ops);
|
|
if (!mdev)
|
|
return -ENOMEM;
|
|
|
|
dev = container_of(mdev, struct mt7603_dev, mt76);
|
|
mt76_mmio_init(mdev, mem_base);
|
|
|
|
mdev->rev = (mt76_rr(dev, MT_HW_CHIPID) << 16) |
|
|
(mt76_rr(dev, MT_HW_REV) & 0xff);
|
|
dev_info(mdev->dev, "ASIC revision: %04x\n", mdev->rev);
|
|
|
|
mt76_wr(dev, MT_INT_MASK_CSR, 0);
|
|
|
|
ret = devm_request_irq(mdev->dev, irq, mt7603_irq_handler,
|
|
IRQF_SHARED, KBUILD_MODNAME, dev);
|
|
if (ret)
|
|
goto error;
|
|
|
|
ret = mt7603_register_device(dev);
|
|
if (ret)
|
|
goto error;
|
|
|
|
return 0;
|
|
error:
|
|
mt76_free_device(mdev);
|
|
return ret;
|
|
}
|
|
|
|
#if LINUX_VERSION_CODE < KERNEL_VERSION(6,11,0)
|
|
static int
|
|
#else
|
|
static void
|
|
#endif
|
|
mt76_wmac_remove(struct platform_device *pdev)
|
|
{
|
|
struct mt76_dev *mdev = platform_get_drvdata(pdev);
|
|
struct mt7603_dev *dev = container_of(mdev, struct mt7603_dev, mt76);
|
|
|
|
mt7603_unregister_device(dev);
|
|
|
|
#if LINUX_VERSION_CODE < KERNEL_VERSION(6,11,0)
|
|
return 0;
|
|
#endif
|
|
}
|
|
|
|
static const struct of_device_id of_wmac_match[] = {
|
|
{ .compatible = "mediatek,mt7628-wmac" },
|
|
{},
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, of_wmac_match);
|
|
MODULE_FIRMWARE(MT7628_FIRMWARE_E1);
|
|
MODULE_FIRMWARE(MT7628_FIRMWARE_E2);
|
|
|
|
struct platform_driver mt76_wmac_driver = {
|
|
.probe = mt76_wmac_probe,
|
|
.remove = mt76_wmac_remove,
|
|
.driver = {
|
|
.name = "mt76_wmac",
|
|
.of_match_table = of_wmac_match,
|
|
},
|
|
};
|