mirror of
https://github.com/outbackdingo/mt76.git
synced 2026-10-24 13:26:48 +00:00
Jiajia LiuandFelix Fietkau
7825972b0a
commit b478e162f227 ("PCI/ASPM: Consolidate link state defines") changed
PCIE_LINK_STATE_L0S (1) to (BIT(0) | BIT(1)). PCI_EXP_LNKCTL_ASPM_L0S (1)
and PCI_EXP_LNKCTL_ASPM_L1 (2) are no longer matched with
PCIE_LINK_STATE_L0S (3) and PCIE_LINK_STATE_L1 (4).
On the platform enabling ASPM L0s and L1, mt76_pci_disable_aspm is not able
to disable L1. Fix this by transforming aspm_conf to pcie link state.
Signed-off-by: Jiajia Liu <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Felix Fietkau <[email protected]>
77 lines
1.9 KiB
C
77 lines
1.9 KiB
C
// SPDX-License-Identifier: BSD-3-Clause-Clear
|
|
/*
|
|
* Copyright (C) 2019 Lorenzo Bianconi <[email protected]>
|
|
*/
|
|
|
|
#include "mt76.h"
|
|
#include <linux/pci.h>
|
|
|
|
void mt76_pci_disable_aspm(struct pci_dev *pdev)
|
|
{
|
|
struct pci_dev *parent = pdev->bus->self;
|
|
u16 aspm_conf, parent_aspm_conf = 0;
|
|
|
|
pcie_capability_read_word(pdev, PCI_EXP_LNKCTL, &aspm_conf);
|
|
aspm_conf &= PCI_EXP_LNKCTL_ASPMC;
|
|
if (parent) {
|
|
pcie_capability_read_word(parent, PCI_EXP_LNKCTL,
|
|
&parent_aspm_conf);
|
|
parent_aspm_conf &= PCI_EXP_LNKCTL_ASPMC;
|
|
}
|
|
|
|
if (!aspm_conf && (!parent || !parent_aspm_conf)) {
|
|
/* aspm already disabled */
|
|
return;
|
|
}
|
|
|
|
dev_info(&pdev->dev, "disabling ASPM %s %s\n",
|
|
(aspm_conf & PCI_EXP_LNKCTL_ASPM_L0S) ? "L0s" : "",
|
|
(aspm_conf & PCI_EXP_LNKCTL_ASPM_L1) ? "L1" : "");
|
|
|
|
if (IS_ENABLED(CONFIG_PCIEASPM)) {
|
|
int err;
|
|
int state = 0;
|
|
|
|
if (aspm_conf & PCI_EXP_LNKCTL_ASPM_L0S)
|
|
state |= PCIE_LINK_STATE_L0S;
|
|
if (aspm_conf & PCI_EXP_LNKCTL_ASPM_L1)
|
|
state |= PCIE_LINK_STATE_L1;
|
|
|
|
err = pci_disable_link_state(pdev, state);
|
|
if (!err)
|
|
return;
|
|
}
|
|
|
|
/* both device and parent should have the same ASPM setting.
|
|
* disable ASPM in downstream component first and then upstream.
|
|
*/
|
|
pcie_capability_clear_word(pdev, PCI_EXP_LNKCTL, aspm_conf);
|
|
if (parent)
|
|
pcie_capability_clear_word(parent, PCI_EXP_LNKCTL,
|
|
aspm_conf);
|
|
}
|
|
EXPORT_SYMBOL_GPL(mt76_pci_disable_aspm);
|
|
|
|
bool mt76_pci_aspm_supported(struct pci_dev *pdev)
|
|
{
|
|
struct pci_dev *parent = pdev->bus->self;
|
|
u16 aspm_conf, parent_aspm_conf = 0;
|
|
bool result = true;
|
|
|
|
pcie_capability_read_word(pdev, PCI_EXP_LNKCTL, &aspm_conf);
|
|
aspm_conf &= PCI_EXP_LNKCTL_ASPMC;
|
|
if (parent) {
|
|
pcie_capability_read_word(parent, PCI_EXP_LNKCTL,
|
|
&parent_aspm_conf);
|
|
parent_aspm_conf &= PCI_EXP_LNKCTL_ASPMC;
|
|
}
|
|
|
|
if (!aspm_conf && (!parent || !parent_aspm_conf)) {
|
|
/* aspm already disabled */
|
|
result = false;
|
|
}
|
|
|
|
return result;
|
|
}
|
|
EXPORT_SYMBOL_GPL(mt76_pci_aspm_supported);
|