mirror of
https://github.com/outbackdingo/mt76.git
synced 2026-10-24 13:26:48 +00:00
Add rx_page_lock spinlock in order to make rx page fragment access atomic. This patch fixes the following crash that occasionally occurs during module loading/unloading BUG: unable to handle kernel paging request at ffff9f8322e19000 PGD 27ba01067 P4D 27ba01067 PUD 27ddba063 PMD 263b35063 PTE 8000000262e19061 Oops: 0003 [#1] SMP PTI CPU: 2 PID: 1766 Comm: systemd-udevd Not tainted 4.19.0-rc5+ #6 Hardware name: ASUSTeK COMPUTER INC. ESC2000 G2/Z9PE-D8 WS, BIOS 0405 03/19/2012 RIP: 0010:__memcpy+0x12/0x20 RSP: 0018:ffffba13849b3ad8 EFLAGS: 00010246 RAX: ffff9f8322e17004 RBX: 00000000000038f0 RCX: 000000000000031f RDX: 0000000000000000 RSI: ffffba13844cf058 RDI: ffff9f8322e18ffc RBP: 0000000000010c6c R08: 0000000000000000 R09: 0000607ec0000000 R10: 0000000000000003 R11: 0000000000003e2e R12: ffff9f8324cd9540 R13: 0000000000000000 R14: ffffba13849b3b30 R15: ffff9f8322e17000 FS: 00007fadec85b880(0000) GS:ffff9f833fa80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffff9f8322e19000 CR3: 0000000263428001 CR4: 00000000000606e0 Call Trace: mt76x02u_mcu_fw_send_data+0x16c/0x270 [mt76x02_usb] mt76x0u_probe+0x35a/0x598 [mt76x0u] usb_probe_interface+0x113/0x310 really_probe+0x1c8/0x400 driver_probe_device+0x5c/0x130 __driver_attach+0xec/0x110 bus_for_each_dev+0x50/0x90 bus_add_driver+0x1c0/0x280 driver_register+0x5b/0xe0 usb_register_driver+0x7c/0x140 do_one_initcall+0x44/0x19b do_init_module+0x5a/0x210 load_module+0x175c/0x1bc0 __do_sys_finit_module+0x97/0xc0 do_syscall_64+0x3f/0xf0 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7fadeb6f1809 RSP: 002b:00007ffe548f9f38 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 RAX: ffffffffffffffda RBX: 00007fadebdf0d89 RCX: 00007fadeb6f1809 RDX: 0000000000000000 RSI: 00007fadebdf0d89 RDI: 0000000000000006 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000006 R11: 0000000000000246 R12: 0000560b9ef58ab0 R13: 0000560b9ef29800 R14: 0000560b9ef59040 R15: 0000000000020000 Fixes: c12128ce44b0 ("mt76: use a per rx queue page fragment cache") Reported-by: Stanislaw Gruszka <[email protected]> Tested-by: Stanislaw Gruszka <[email protected]> Signed-off-by: Lorenzo Bianconi <[email protected]>
364 lines
9.3 KiB
C
364 lines
9.3 KiB
C
/*
|
|
* Copyright (C) 2015 Jakub Kicinski <[email protected]>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2
|
|
* as published by the Free Software Foundation
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/firmware.h>
|
|
#include <linux/usb.h>
|
|
|
|
#include "mt76x0.h"
|
|
#include "mcu.h"
|
|
#include "trace.h"
|
|
#include "../mt76x02_util.h"
|
|
#include "../mt76x02_usb.h"
|
|
|
|
#define MT7610U_FIRMWARE "mediatek/mt7610u.bin"
|
|
|
|
static struct usb_device_id mt76x0_device_table[] = {
|
|
{ USB_DEVICE(0x148F, 0x7610) }, /* MT7610U */
|
|
{ USB_DEVICE(0x13B1, 0x003E) }, /* Linksys AE6000 */
|
|
{ USB_DEVICE(0x0E8D, 0x7610) }, /* Sabrent NTWLAC */
|
|
{ USB_DEVICE(0x7392, 0xa711) }, /* Edimax 7711mac */
|
|
{ USB_DEVICE(0x7392, 0xb711) }, /* Edimax / Elecom */
|
|
{ USB_DEVICE(0x148f, 0x761a) }, /* TP-Link TL-WDN5200 */
|
|
{ USB_DEVICE(0x148f, 0x760a) }, /* TP-Link unknown */
|
|
{ USB_DEVICE(0x0b05, 0x17d1) }, /* Asus USB-AC51 */
|
|
{ USB_DEVICE(0x0b05, 0x17db) }, /* Asus USB-AC50 */
|
|
{ USB_DEVICE(0x0df6, 0x0075) }, /* Sitecom WLA-3100 */
|
|
{ USB_DEVICE(0x2019, 0xab31) }, /* Planex GW-450D */
|
|
{ USB_DEVICE(0x2001, 0x3d02) }, /* D-LINK DWA-171 rev B1 */
|
|
{ USB_DEVICE(0x0586, 0x3425) }, /* Zyxel NWD6505 */
|
|
{ USB_DEVICE(0x07b8, 0x7610) }, /* AboCom AU7212 */
|
|
{ USB_DEVICE(0x04bb, 0x0951) }, /* I-O DATA WN-AC433UK */
|
|
{ USB_DEVICE(0x057c, 0x8502) }, /* AVM FRITZ!WLAN USB Stick AC 430 */
|
|
{ USB_DEVICE(0x293c, 0x5702) }, /* Comcast Xfinity KXW02AAA */
|
|
{ USB_DEVICE(0x20f4, 0x806b) }, /* TRENDnet TEW-806UBH */
|
|
{ USB_DEVICE(0x7392, 0xc711) }, /* Devolo Wifi ac Stick */
|
|
{ USB_DEVICE(0x0df6, 0x0079) }, /* Sitecom Europe B.V. ac Stick */
|
|
{ USB_DEVICE(0x2357, 0x0105) }, /* TP-LINK Archer T1U */
|
|
{ USB_DEVICE_AND_INTERFACE_INFO(0x0E8D, 0x7630, 0xff, 0x2, 0xff)}, /* MT7630U */
|
|
{ USB_DEVICE_AND_INTERFACE_INFO(0x0E8D, 0x7650, 0xff, 0x2, 0xff)}, /* MT7650U */
|
|
{ 0, }
|
|
};
|
|
|
|
#define MCU_FW_URB_MAX_PAYLOAD 0x38f8
|
|
#define MCU_FW_URB_SIZE (MCU_FW_URB_MAX_PAYLOAD + 12)
|
|
|
|
static int
|
|
mt76x0u_upload_firmware(struct mt76x0_dev *dev,
|
|
const struct mt76x02_fw_header *hdr)
|
|
{
|
|
u8 *fw_payload = (u8 *)(hdr + 1);
|
|
u32 ilm_len, dlm_len;
|
|
void *ivb;
|
|
int err;
|
|
|
|
ivb = kmemdup(fw_payload, MT_MCU_IVB_SIZE, GFP_KERNEL);
|
|
if (!ivb)
|
|
return -ENOMEM;
|
|
|
|
ilm_len = le32_to_cpu(hdr->ilm_len) - MT_MCU_IVB_SIZE;
|
|
dev_dbg(dev->mt76.dev, "loading FW - ILM %u + IVB %u\n",
|
|
ilm_len, MT_MCU_IVB_SIZE);
|
|
err = mt76x02u_mcu_fw_send_data(&dev->mt76,
|
|
fw_payload + MT_MCU_IVB_SIZE,
|
|
ilm_len, MCU_FW_URB_MAX_PAYLOAD,
|
|
MT_MCU_IVB_SIZE);
|
|
if (err)
|
|
goto out;
|
|
|
|
dlm_len = le32_to_cpu(hdr->dlm_len);
|
|
dev_dbg(dev->mt76.dev, "loading FW - DLM %u\n", dlm_len);
|
|
err = mt76x02u_mcu_fw_send_data(&dev->mt76,
|
|
fw_payload + le32_to_cpu(hdr->ilm_len),
|
|
dlm_len, MCU_FW_URB_MAX_PAYLOAD,
|
|
MT_MCU_DLM_OFFSET);
|
|
if (err)
|
|
goto out;
|
|
|
|
err = mt76u_vendor_request(&dev->mt76, MT_VEND_DEV_MODE,
|
|
USB_DIR_OUT | USB_TYPE_VENDOR,
|
|
0x12, 0, ivb, MT_MCU_IVB_SIZE);
|
|
if (err < 0)
|
|
goto out;
|
|
|
|
if (!mt76_poll_msec(dev, MT_MCU_COM_REG0, 1, 1, 1000)) {
|
|
dev_err(dev->mt76.dev, "Firmware failed to start\n");
|
|
err = -ETIMEDOUT;
|
|
goto out;
|
|
}
|
|
|
|
dev_dbg(dev->mt76.dev, "Firmware running!\n");
|
|
|
|
out:
|
|
kfree(ivb);
|
|
|
|
return err;
|
|
}
|
|
|
|
static int mt76x0u_load_firmware(struct mt76x0_dev *dev)
|
|
{
|
|
const struct firmware *fw;
|
|
const struct mt76x02_fw_header *hdr;
|
|
int len, ret;
|
|
u32 val;
|
|
|
|
mt76_wr(dev, MT_USB_DMA_CFG, (MT_USB_DMA_CFG_RX_BULK_EN |
|
|
MT_USB_DMA_CFG_TX_BULK_EN));
|
|
|
|
if (mt76x0_firmware_running(dev))
|
|
return 0;
|
|
|
|
ret = request_firmware(&fw, MT7610U_FIRMWARE, dev->mt76.dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (!fw || !fw->data || fw->size < sizeof(*hdr))
|
|
goto err_inv_fw;
|
|
|
|
hdr = (const struct mt76x02_fw_header *)fw->data;
|
|
|
|
if (le32_to_cpu(hdr->ilm_len) <= MT_MCU_IVB_SIZE)
|
|
goto err_inv_fw;
|
|
|
|
len = sizeof(*hdr);
|
|
len += le32_to_cpu(hdr->ilm_len);
|
|
len += le32_to_cpu(hdr->dlm_len);
|
|
|
|
if (fw->size != len)
|
|
goto err_inv_fw;
|
|
|
|
val = le16_to_cpu(hdr->fw_ver);
|
|
dev_dbg(dev->mt76.dev,
|
|
"Firmware Version: %d.%d.%02d Build: %x Build time: %.16s\n",
|
|
(val >> 12) & 0xf, (val >> 8) & 0xf, val & 0xf,
|
|
le16_to_cpu(hdr->build_ver), hdr->build_time);
|
|
|
|
len = le32_to_cpu(hdr->ilm_len);
|
|
|
|
mt76_wr(dev, 0x1004, 0x2c);
|
|
|
|
mt76_set(dev, MT_USB_DMA_CFG, (MT_USB_DMA_CFG_RX_BULK_EN |
|
|
MT_USB_DMA_CFG_TX_BULK_EN) |
|
|
FIELD_PREP(MT_USB_DMA_CFG_RX_BULK_AGG_TOUT, 0x20));
|
|
mt76x02u_mcu_fw_reset(&dev->mt76);
|
|
msleep(5);
|
|
/*
|
|
mt76x0_rmw(dev, MT_PBF_CFG, 0, (MT_PBF_CFG_TX0Q_EN |
|
|
MT_PBF_CFG_TX1Q_EN |
|
|
MT_PBF_CFG_TX2Q_EN |
|
|
MT_PBF_CFG_TX3Q_EN));
|
|
*/
|
|
|
|
mt76_wr(dev, MT_FCE_PSE_CTRL, 1);
|
|
|
|
/* FCE tx_fs_base_ptr */
|
|
mt76_wr(dev, MT_TX_CPU_FROM_FCE_BASE_PTR, 0x400230);
|
|
/* FCE tx_fs_max_cnt */
|
|
mt76_wr(dev, MT_TX_CPU_FROM_FCE_MAX_COUNT, 1);
|
|
/* FCE pdma enable */
|
|
mt76_wr(dev, MT_FCE_PDMA_GLOBAL_CONF, 0x44);
|
|
/* FCE skip_fs_en */
|
|
mt76_wr(dev, MT_FCE_SKIP_FS, 3);
|
|
|
|
val = mt76_rr(dev, MT_USB_DMA_CFG);
|
|
val |= MT_USB_DMA_CFG_UDMA_TX_WL_DROP;
|
|
mt76_wr(dev, MT_USB_DMA_CFG, val);
|
|
val &= ~MT_USB_DMA_CFG_UDMA_TX_WL_DROP;
|
|
mt76_wr(dev, MT_USB_DMA_CFG, val);
|
|
|
|
ret = mt76x0u_upload_firmware(dev, hdr);
|
|
mt76x02_set_ethtool_fwver(&dev->mt76, hdr);
|
|
release_firmware(fw);
|
|
|
|
mt76_wr(dev, MT_FCE_PSE_CTRL, 1);
|
|
|
|
return ret;
|
|
|
|
err_inv_fw:
|
|
dev_err(dev->mt76.dev, "Invalid firmware image\n");
|
|
release_firmware(fw);
|
|
return -ENOENT;
|
|
}
|
|
|
|
static int mt76x0u_mcu_init(struct mt76x0_dev *dev)
|
|
{
|
|
int ret;
|
|
|
|
ret = mt76x0u_load_firmware(dev);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
set_bit(MT76_STATE_MCU_RUNNING, &dev->mt76.state);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mt76x0u_probe(struct usb_interface *usb_intf,
|
|
const struct usb_device_id *id)
|
|
{
|
|
static const struct mt76_driver_ops drv_ops = {
|
|
.tx_prepare_skb = mt76x0_tx_prepare_skb,
|
|
.tx_complete_skb = mt76x02_tx_complete_skb,
|
|
.tx_status_data = mt76x02_tx_status_data,
|
|
.rx_skb = mt76x0_queue_rx_skb,
|
|
};
|
|
struct usb_device *usb_dev = interface_to_usbdev(usb_intf);
|
|
struct mt76x0_dev *dev;
|
|
u32 asic_rev, mac_rev;
|
|
int ret;
|
|
|
|
dev = mt76x0_alloc_device(&usb_intf->dev, &drv_ops);
|
|
if (!dev)
|
|
return -ENOMEM;
|
|
|
|
usb_dev = usb_get_dev(usb_dev);
|
|
usb_reset_device(usb_dev);
|
|
|
|
usb_set_intfdata(usb_intf, dev);
|
|
|
|
mt76x02u_init_mcu(&dev->mt76);
|
|
ret = mt76u_init(&dev->mt76, usb_intf);
|
|
if (ret)
|
|
goto err;
|
|
|
|
/* Disable the HW, otherwise MCU fail to initalize on hot reboot */
|
|
mt76x0_chip_onoff(dev, false, false);
|
|
|
|
if (!mt76x02_wait_for_mac(&dev->mt76)) {
|
|
ret = -ETIMEDOUT;
|
|
goto err;
|
|
}
|
|
|
|
asic_rev = mt76_rr(dev, MT_ASIC_VERSION);
|
|
mac_rev = mt76_rr(dev, MT_MAC_CSR0);
|
|
dev_info(dev->mt76.dev, "ASIC revision: %08x MAC revision: %08x\n",
|
|
asic_rev, mac_rev);
|
|
|
|
/* Note: vendor driver skips this check for MT76X0U */
|
|
if (!(mt76_rr(dev, MT_EFUSE_CTRL) & MT_EFUSE_CTRL_SEL))
|
|
dev_warn(dev->mt76.dev, "Warning: eFUSE not present\n");
|
|
|
|
ret = mt76u_alloc_queues(&dev->mt76);
|
|
if (ret < 0)
|
|
goto err;
|
|
|
|
ret = mt76u_mcu_init_rx(&dev->mt76);
|
|
if (ret < 0)
|
|
goto err;
|
|
|
|
mt76x0_chip_onoff(dev, true, true);
|
|
|
|
if (!mt76x02_wait_for_mac(&dev->mt76))
|
|
return -ETIMEDOUT;
|
|
|
|
ret = mt76x0u_mcu_init(dev);
|
|
if (ret)
|
|
goto err_hw;
|
|
|
|
ret = mt76x0_register_device(dev);
|
|
if (ret)
|
|
goto err_hw;
|
|
|
|
set_bit(MT76_STATE_INITIALIZED, &dev->mt76.state);
|
|
|
|
return 0;
|
|
err_hw:
|
|
mt76x0_cleanup(dev);
|
|
err:
|
|
usb_set_intfdata(usb_intf, NULL);
|
|
usb_put_dev(interface_to_usbdev(usb_intf));
|
|
|
|
ieee80211_free_hw(dev->mt76.hw);
|
|
return ret;
|
|
}
|
|
|
|
static void mt76x0_disconnect(struct usb_interface *usb_intf)
|
|
{
|
|
struct mt76x0_dev *dev = usb_get_intfdata(usb_intf);
|
|
bool initalized = test_bit(MT76_STATE_INITIALIZED, &dev->mt76.state);
|
|
|
|
if (!initalized)
|
|
return;
|
|
|
|
ieee80211_unregister_hw(dev->mt76.hw);
|
|
mt76x0_cleanup(dev);
|
|
|
|
usb_set_intfdata(usb_intf, NULL);
|
|
usb_put_dev(interface_to_usbdev(usb_intf));
|
|
|
|
ieee80211_free_hw(dev->mt76.hw);
|
|
}
|
|
|
|
static int __maybe_unused mt76x0_suspend(struct usb_interface *usb_intf,
|
|
pm_message_t state)
|
|
{
|
|
struct mt76x0_dev *dev = usb_get_intfdata(usb_intf);
|
|
struct mt76_usb *usb = &dev->mt76.usb;
|
|
|
|
mt76u_stop_queues(&dev->mt76);
|
|
mt76x0_mac_stop(dev);
|
|
usb_kill_urb(usb->mcu.res.urb);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int __maybe_unused mt76x0_resume(struct usb_interface *usb_intf)
|
|
{
|
|
struct mt76x0_dev *dev = usb_get_intfdata(usb_intf);
|
|
struct mt76_usb *usb = &dev->mt76.usb;
|
|
int ret;
|
|
|
|
reinit_completion(&usb->mcu.cmpl);
|
|
ret = mt76u_submit_buf(&dev->mt76, USB_DIR_IN,
|
|
MT_EP_IN_CMD_RESP,
|
|
&usb->mcu.res, GFP_KERNEL,
|
|
mt76u_mcu_complete_urb,
|
|
&usb->mcu.cmpl);
|
|
if (ret < 0)
|
|
goto err;
|
|
|
|
ret = mt76u_submit_rx_buffers(&dev->mt76);
|
|
if (ret < 0)
|
|
goto err;
|
|
|
|
tasklet_enable(&usb->rx_tasklet);
|
|
tasklet_enable(&usb->tx_tasklet);
|
|
|
|
ret = mt76x0_init_hardware(dev);
|
|
if (ret)
|
|
goto err;
|
|
|
|
return 0;
|
|
err:
|
|
mt76x0_cleanup(dev);
|
|
return ret;
|
|
}
|
|
|
|
MODULE_DEVICE_TABLE(usb, mt76x0_device_table);
|
|
MODULE_FIRMWARE(MT7610U_FIRMWARE);
|
|
MODULE_LICENSE("GPL");
|
|
|
|
static struct usb_driver mt76x0_driver = {
|
|
.name = KBUILD_MODNAME,
|
|
.id_table = mt76x0_device_table,
|
|
.probe = mt76x0u_probe,
|
|
.disconnect = mt76x0_disconnect,
|
|
.suspend = mt76x0_suspend,
|
|
.resume = mt76x0_resume,
|
|
.reset_resume = mt76x0_resume,
|
|
.soft_unbind = 1,
|
|
.disable_hub_initiated_lpm = 1,
|
|
};
|
|
module_usb_driver(mt76x0_driver);
|