From f7f6c6dcc6eba34c5c81b839dae8f0f209d7cbee Mon Sep 17 00:00:00 2001 From: Ben Greear Date: Sat, 8 Jan 2022 11:08:14 -0800 Subject: [PATCH] mt76: mt7921: fix crash when startup fails. If the nic fails to start, it is possible that the reset_work has already been scheduled. Ensure the work item is canceled so we do not have use-after-free crash in case cleanup is called before the work item is executed. This fixes crash on my x86_64 apu2 when mt7921k radio fails to work. Radio still fails, but OS does not crash. Signed-off-by: Ben Greear Signed-off-by: Felix Fietkau --- mt7921/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mt7921/main.c b/mt7921/main.c index 6073beda..9b33002d 100644 --- a/mt7921/main.c +++ b/mt7921/main.c @@ -272,6 +272,7 @@ static void mt7921_stop(struct ieee80211_hw *hw) cancel_delayed_work_sync(&dev->pm.ps_work); cancel_work_sync(&dev->pm.wake_work); + cancel_work_sync(&dev->reset_work); mt76_connac_free_pending_tx_skbs(&dev->pm, NULL); mt7921_mutex_acquire(dev);