From e2cc063238c08e59f39e814b742c1e24686e25f0 Mon Sep 17 00:00:00 2001 From: Sean Wang Date: Sun, 12 Dec 2021 00:31:30 +0800 Subject: [PATCH] mt76: mt7921s: fix suspend error with enlarging mcu timeout value Fix the false positive suspend error that may occur on mt7921s with enlarging mcu timeout value. The reason why we have to enlarge mcu timeout from HZ / 3 to HZ is we should consider the additional overhead caused by running concurrently with btmtksdio (a MT7921 bluetooth SDIO driver) that would compete for the same SDIO bus in process context to complete the suspend procedure. Fixes: 48fab5bbef40 ("mt76: mt7921: introduce mt7921s support") Signed-off-by: Sean Wang Signed-off-by: Felix Fietkau --- mt7921/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mt7921/mcu.c b/mt7921/mcu.c index a4949914..f805c4a5 100644 --- a/mt7921/mcu.c +++ b/mt7921/mcu.c @@ -229,7 +229,7 @@ int mt7921_mcu_fill_message(struct mt76_dev *mdev, struct sk_buff *skb, if (cmd == MCU_UNI_CMD(HIF_CTRL) || cmd == MCU_UNI_CMD(SUSPEND) || cmd == MCU_UNI_CMD(OFFLOAD)) - mdev->mcu.timeout = HZ / 3; + mdev->mcu.timeout = HZ; else mdev->mcu.timeout = 3 * HZ;