From b4e6f0d6f15aa6ca2b821baf99776f3d0e425088 Mon Sep 17 00:00:00 2001 From: Lorenzo Bianconi Date: Mon, 24 Jan 2022 21:03:44 +0100 Subject: [PATCH] mt76: mt7921s: fix a possible memory leak in mt7921_load_patch Always release fw data at the end of mt7921_load_patch routine. Fixes: 78b217580c509 ("mt76: mt7921s: fix bus hang with wrong privilege") Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau --- mt7921/mcu.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/mt7921/mcu.c b/mt7921/mcu.c index 509595c4..33a83682 100644 --- a/mt7921/mcu.c +++ b/mt7921/mcu.c @@ -541,12 +541,8 @@ static int mt7921_load_patch(struct mt7921_dev *dev) if (mt76_is_sdio(&dev->mt76)) { /* activate again */ ret = __mt7921_mcu_fw_pmctrl(dev); - if (ret) - return ret; - - ret = __mt7921_mcu_drv_pmctrl(dev); - if (ret) - return ret; + if (!ret) + ret = __mt7921_mcu_drv_pmctrl(dev); } out: