gitops/mt76
1
0
Fork 0
mirror of https://github.com/outbackdingo/mt76.git synced 2026-10-24 13:26:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

wifi: mt76: mt7996: bound the device EEPROM address before the EFUSE copy

Browse Source 
mt7996_mcu_get_eeprom() derives the destination of the EFUSE/EXT block
copy from the address reported by the MCU response (event->addr, a
device-controlled __le32) and clamps only the copy length, never the
destination offset into dev->mt76.eeprom.data. A malicious or
malfunctioning device can report an arbitrary address and drive an
out-of-bounds write of up to MT7996_EXT_EEPROM_BLOCK_SIZE bytes past
eeprom.data.

Reject a response whose address would place the copy outside eeprom.data
before deriving the destination pointer. Devices that echo the requested
in-bounds offset are unaffected.

Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices")
Cc: [email protected]
Signed-off-by: Bryam Vargas <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Felix Fietkau <[email protected]>
This commit is contained in:
Bryam Vargas
2026-07-21 12:39:16 +02:00
committed by Felix Fietkau
parent a1d83aad6c
commit 76c38706bb
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mt7996/mcu.c
+8 -1
View File
@@ -4575,11 +4575,18 @@ int mt7996_mcu_get_eeprom(struct mt7996_dev *dev, u32 offset, u8 *buf, u32 buf_l
event = (struct mt7996_mcu_eeprom_access_event *)skb->data;
if (event->valid) {
u32 ret_len = le32_to_cpu(event->eeprom.ext_eeprom.data_len);
u32 block = mode == EEPROM_MODE_EXT ? MT7996_EXT_EEPROM_BLOCK_SIZE :
MT7996_EEPROM_BLOCK_SIZE;
addr = le32_to_cpu(event->addr);
if (!buf)
if (!buf) {
if (addr > dev->mt76.eeprom.size - block) {
dev_kfree_skb(skb);
return -EINVAL;
}
buf = (u8 *)dev->mt76.eeprom.data + addr;
}
switch (mode) {
case EEPROM_MODE_EFUSE: