From 34eea1414b8ba0b401935b43629128f16d9fb286 Mon Sep 17 00:00:00 2001 From: Lorenzo Bianconi Date: Wed, 5 Jun 2019 00:12:20 +0200 Subject: [PATCH] mt76: mt7615: remove key check in mt7615_mcu_set_wtbl_key Do not check key pointer in mt7615_mcu_set_wtbl_key since if set_key_cmd is SET_KEY, key will be always not NULL. This patch will address a false positive reported by Coverity-Scan Addresses-Coverity-ID: 1445463 ("Dereference after null check") Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau --- mt7615/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mt7615/mcu.c b/mt7615/mcu.c index f2f6b776..76431d00 100644 --- a/mt7615/mcu.c +++ b/mt7615/mcu.c @@ -879,7 +879,7 @@ int mt7615_mcu_set_wtbl_key(struct mt7615_dev *dev, int wcid, u8 cipher; cipher = mt7615_get_key_info(key, req.key.key_material); - if (cipher == MT_CIPHER_NONE && key) + if (cipher == MT_CIPHER_NONE) return -EOPNOTSUPP; req.key.rkv = 1;