From 0aca66c123f8f685c5393ff5f04f7e82cc14225a Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Thu, 30 Apr 2026 10:33:34 +0200 Subject: [PATCH] wifi: mt76: mt792xu: drop redundant device reference Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260430083335.215239-5-johan@kernel.org Signed-off-by: Felix Fietkau --- mt7921/usb.c | 2 -- mt7925/usb.c | 2 -- mt792x_usb.c | 1 - 3 files changed, 5 deletions(-) diff --git a/mt7921/usb.c b/mt7921/usb.c index 17057e68..9bfc234f 100644 --- a/mt7921/usb.c +++ b/mt7921/usb.c @@ -197,7 +197,6 @@ static int mt7921u_probe(struct usb_interface *usb_intf, dev->fw_features = features; dev->hif_ops = &hif_ops; - udev = usb_get_dev(udev); usb_reset_device(udev); usb_set_intfdata(usb_intf, dev); @@ -246,7 +245,6 @@ error: mt76u_queues_deinit(&dev->mt76); usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); mt76_free_device(&dev->mt76); diff --git a/mt7925/usb.c b/mt7925/usb.c index d9968f03..84bcebbf 100644 --- a/mt7925/usb.c +++ b/mt7925/usb.c @@ -185,7 +185,6 @@ static int mt7925u_probe(struct usb_interface *usb_intf, dev->fw_features = features; dev->hif_ops = &hif_ops; - udev = usb_get_dev(udev); usb_reset_device(udev); usb_set_intfdata(usb_intf, dev); @@ -234,7 +233,6 @@ error: mt76u_queues_deinit(&dev->mt76); usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); mt76_free_device(&dev->mt76); diff --git a/mt792x_usb.c b/mt792x_usb.c index 47827d1c..0d9dbd0a 100644 --- a/mt792x_usb.c +++ b/mt792x_usb.c @@ -341,7 +341,6 @@ void mt792xu_disconnect(struct usb_interface *usb_intf) mt792xu_cleanup(dev); usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); mt76_free_device(&dev->mt76); }